Received: by mail.netbsd.org (Postfix, from userid 605) id C245584EF2; Tue, 11 Sep 2018 16:26:08 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id EE52184EDE for ; Tue, 11 Sep 2018 16:13:30 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id uyhxFsjIIaPg for ; Tue, 11 Sep 2018 16:13:29 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id 8F13384D32 for ; Tue, 11 Sep 2018 16:13:29 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 88855FBF8; Tue, 11 Sep 2018 16:13:29 +0000 (UTC) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_1536682409214930" MIME-Version: 1.0 Date: Tue, 11 Sep 2018 16:13:29 +0000 From: "Greg Troxel" Subject: CVS commit: pkgsrc/geography/geos To: pkgsrc-changes@NetBSD.org Reply-To: gdt@netbsd.org X-Mailer: log_accum Message-Id: <20180911161329.88855FBF8@cvs.NetBSD.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: pkgsrc-changes.NetBSD.org Precedence: bulk List-Unsubscribe: This is a multi-part message in MIME format. --_----------=_1536682409214930 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Module Name: pkgsrc Committed By: gdt Date: Tue Sep 11 16:13:29 UTC 2018 Modified Files: pkgsrc/geography/geos: Makefile PLIST buildlink3.mk distinfo pkgsrc/geography/geos/patches: patch-ae patch-capi_geos__ts__c.cpp Log Message: Update to 3.7.0: pkgsrc changes: revise comments about geos C vs C++ library linking in light of unexpected libtool behavior (which defeats geos's scheme) Upstream NEWS: 3.7.0 changes 2018-09-10 - New things: - CAPI: GEOSDistanceIndexed (#795, Dan Baston) - CAPI: GEOSCoordSeq_isCCW (#870, Dan Baston) - CAPI: GEOSGeom_getXMin, GEOSGeom_getXMax, GEOSGeom_getYMin, GEOSGeom_getYMax (#871, Dan Baston) - CAPI: GEOSFrechetDistance (#797, Shinichi SUGIYAMA) - CAPI: GEOSReverse (#872, Dan Baston) - CAPI: GEOSGeomGetZ (#581, J Smith) - Improvements - Interruptible snap operation (Paul Ramsey) - Numerous packaging, doc, and build changes (Debian group: Bas Couwenberg, Francesco Paolo Lovergine) (NetBSD: Greg Troxel) - Allow static library with C API for CMake builds (#878, Dakota Hawkins) - C++ API changes: - Require defining USE_UNSTABLE_GEOS_CPP_API for use without warnings. - Make C++11 required (Mateusz Loskot) - Use C++11 unique_ptr, nullptr, and override constructs (Mateusz Loskot) - C++11 standard delete on noncopyable (#851, Vicky Vergara) - Fix CommonBits::getBit to correctly handle i >= 32 (#834, Kurt Schwehr) To generate a diff of this commit: cvs rdiff -u -r1.30 -r1.31 pkgsrc/geography/geos/Makefile cvs rdiff -u -r1.14 -r1.15 pkgsrc/geography/geos/PLIST cvs rdiff -u -r1.11 -r1.12 pkgsrc/geography/geos/buildlink3.mk cvs rdiff -u -r1.27 -r1.28 pkgsrc/geography/geos/distinfo cvs rdiff -u -r1.5 -r1.6 pkgsrc/geography/geos/patches/patch-ae cvs rdiff -u -r1.1 -r1.2 \ pkgsrc/geography/geos/patches/patch-capi_geos__ts__c.cpp Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. --_----------=_1536682409214930 Content-Disposition: inline Content-Length: 8035 Content-Transfer-Encoding: binary Content-Type: text/x-diff; charset=us-ascii Modified files: Index: pkgsrc/geography/geos/Makefile diff -u pkgsrc/geography/geos/Makefile:1.30 pkgsrc/geography/geos/Makefile:1.31 --- pkgsrc/geography/geos/Makefile:1.30 Thu Sep 28 00:24:41 2017 +++ pkgsrc/geography/geos/Makefile Tue Sep 11 16:13:29 2018 @@ -1,6 +1,6 @@ -# $NetBSD: Makefile,v 1.30 2017/09/28 00:24:41 gdt Exp $ +# $NetBSD: Makefile,v 1.31 2018/09/11 16:13:29 gdt Exp $ -DISTNAME= geos-3.6.2 +DISTNAME= geos-3.7.0 CATEGORIES= geography MASTER_SITES= http://download.osgeo.org/geos/ EXTRACT_SUFX= .tar.bz2 @@ -11,25 +11,26 @@ EXTRACT_SUFX= .tar.bz2 # According to the geos project (as documented in README), the C++ # interface should not be directly used and other packages should not -# link against it. Therefore, pkgsrc will perform a recursive revbump -# when the geos_c shlib version changes, and will generally ignore -# geos shlib name changes. However, people on the geos list dispute -# this characterization. - -# The following packages either incorrectly (from the geos README -# viewpoint) or suboptimally (from some comments on the list) link -# directly against -lgeos and should be revbumped on every update (and -# perhaps fixed not to use -lgeos): +# link against it. Therefore, in theory pkgsrc would perform a +# recursive revbump when the libgeos_c.so version changes, and would +# generally ignore libgeos.so shlib name changes. +# +# However, libtool explicitly adds dependency_libs, so packages that +# intend to only depend on the C library end up being linked directly +# to the C++ library also. Thus, they need revbumping because of +# libtools {bug or feature}. +# +# Packages that need revbumping because of libtool's baehvior: # geography/gdal-lib -# geoggraph/osm2pgsql -# https://github.com/openstreetmap/osm2pgsql/issues/634 +# Packages that need revbumping because of direct use of the C++ lib: +# (none known) MAINTAINER= gdt@NetBSD.org HOMEPAGE= https://trac.osgeo.org/geos COMMENT= C++ port of the Java Topology Suite (JTS) LICENSE= gnu-lgpl-v2.1 -USE_LANGUAGES= c c++ +USE_LANGUAGES= c c++11 USE_LIBTOOL= yes USE_PKGLOCALEDIR= yes GNU_CONFIGURE= yes Index: pkgsrc/geography/geos/PLIST diff -u pkgsrc/geography/geos/PLIST:1.14 pkgsrc/geography/geos/PLIST:1.15 --- pkgsrc/geography/geos/PLIST:1.14 Thu Sep 28 00:24:41 2017 +++ pkgsrc/geography/geos/PLIST Tue Sep 11 16:13:29 2018 @@ -1,4 +1,4 @@ -@comment $NetBSD: PLIST,v 1.14 2017/09/28 00:24:41 gdt Exp $ +@comment $NetBSD: PLIST,v 1.15 2018/09/11 16:13:29 gdt Exp $ bin/geos-config include/geos.h include/geos/algorithm/Angle.h @@ -25,6 +25,7 @@ include/geos/algorithm/RayCrossingCounte include/geos/algorithm/RobustDeterminant.h include/geos/algorithm/SIRtreePointInRing.h include/geos/algorithm/SimplePointInRing.h +include/geos/algorithm/distance/DiscreteFrechetDistance.h include/geos/algorithm/distance/DiscreteHausdorffDistance.h include/geos/algorithm/distance/DistanceToPoint.h include/geos/algorithm/distance/PointPairDistance.h @@ -54,7 +55,6 @@ include/geos/geom/GeometryComponentFilte include/geos/geom/GeometryFactory.h include/geos/geom/GeometryFactory.inl include/geos/geom/GeometryFilter.h -include/geos/geom/GeometryList.h include/geos/geom/IntersectionMatrix.h include/geos/geom/LineSegment.h include/geos/geom/LineSegment.inl @@ -267,6 +267,7 @@ include/geos/operation/distance/Distance include/geos/operation/distance/FacetSequence.h include/geos/operation/distance/FacetSequenceTreeBuilder.h include/geos/operation/distance/GeometryLocation.h +include/geos/operation/distance/IndexedFacetDistance.h include/geos/operation/intersection/Rectangle.h include/geos/operation/intersection/RectangleIntersection.h include/geos/operation/intersection/RectangleIntersectionBuilder.h Index: pkgsrc/geography/geos/buildlink3.mk diff -u pkgsrc/geography/geos/buildlink3.mk:1.11 pkgsrc/geography/geos/buildlink3.mk:1.12 --- pkgsrc/geography/geos/buildlink3.mk:1.11 Sat Jun 2 16:27:30 2012 +++ pkgsrc/geography/geos/buildlink3.mk Tue Sep 11 16:13:29 2018 @@ -1,10 +1,12 @@ -# $NetBSD: buildlink3.mk,v 1.11 2012/06/02 16:27:30 drochner Exp $ +# $NetBSD: buildlink3.mk,v 1.12 2018/09/11 16:13:29 gdt Exp $ BUILDLINK_TREE+= geos .if !defined(GEOS_BUILDLINK3_MK) GEOS_BUILDLINK3_MK:= +#USE_LANGUAGES+= c++11 + BUILDLINK_API_DEPENDS.geos+= geos>=2.2.3 BUILDLINK_ABI_DEPENDS.geos+= geos>=3.3.4 BUILDLINK_PKGSRCDIR.geos?= ../../geography/geos Index: pkgsrc/geography/geos/distinfo diff -u pkgsrc/geography/geos/distinfo:1.27 pkgsrc/geography/geos/distinfo:1.28 --- pkgsrc/geography/geos/distinfo:1.27 Thu Sep 28 00:24:41 2017 +++ pkgsrc/geography/geos/distinfo Tue Sep 11 16:13:29 2018 @@ -1,8 +1,8 @@ -$NetBSD: distinfo,v 1.27 2017/09/28 00:24:41 gdt Exp $ +$NetBSD: distinfo,v 1.28 2018/09/11 16:13:29 gdt Exp $ -SHA1 (geos-3.6.2.tar.bz2) = b9d0578c6b5308cf05a3dd8873802f9862c04291 -RMD160 (geos-3.6.2.tar.bz2) = 6efa217f1bfe5bb4a3de82e1899a97b3a8c90b9e -SHA512 (geos-3.6.2.tar.bz2) = 515d8700b8a28282678e481faee355e3a43d7b70160472a63335b8d7225d9ba10437be782378f18f31a15288118126d411a2d862f01ce35d27c96f6bc0a73016 -Size (geos-3.6.2.tar.bz2) = 2030705 bytes -SHA1 (patch-ae) = f4befa15f66a6e5b30dce57f0abb34af4c3264c8 -SHA1 (patch-capi_geos__ts__c.cpp) = 0c266de00722606bcb9637f21f5c3c458f12cb47 +SHA1 (geos-3.7.0.tar.bz2) = a42cfc1178784ebdf124c6537ee3158e5acac698 +RMD160 (geos-3.7.0.tar.bz2) = 3e3ea84b5b7e81f7e0c483bdbe3d7ad9417e2da9 +SHA512 (geos-3.7.0.tar.bz2) = fcca5e503efa32bb388376b2a06b9ca5c74fbcddba750cce6b3b4109eb2eb122058aead12b9462cdd881f425cd75d7241645ab344f25ce022bc0659954560742 +Size (geos-3.7.0.tar.bz2) = 2028814 bytes +SHA1 (patch-ae) = bcc9e39928dca6c3e78326c0bfb7dcf96e4bcf10 +SHA1 (patch-capi_geos__ts__c.cpp) = bde78fc0ef30e0d75ccba5f89c6f62d957783d03 Index: pkgsrc/geography/geos/patches/patch-ae diff -u pkgsrc/geography/geos/patches/patch-ae:1.5 pkgsrc/geography/geos/patches/patch-ae:1.6 --- pkgsrc/geography/geos/patches/patch-ae:1.5 Thu Sep 28 00:24:41 2017 +++ pkgsrc/geography/geos/patches/patch-ae Tue Sep 11 16:13:29 2018 @@ -1,33 +1,13 @@ -$NetBSD: patch-ae,v 1.5 2017/09/28 00:24:41 gdt Exp $ +$NetBSD: patch-ae,v 1.6 2018/09/11 16:13:29 gdt Exp $ TODO: explain what's in LDFLAGS. TODO: explain why --libs has -L in the first place (vs --ldflags). TODO: report upstream. ---- tools/geos-config.in.orig 2016-11-22 10:49:08.000000000 +0000 +--- tools/geos-config.in.orig 2018-08-19 10:49:14.000000000 +0000 +++ tools/geos-config.in -@@ -43,22 +43,22 @@ case $1 in - --libs) - # TODO: make an alias for --clibs - # see http://trac.osgeo.org/geos/ticket/497 -- echo -L${libdir} -lgeos -+ echo -L${libdir} @LDFLAGS@ -lgeos - ;; - --clibs) -- echo -L${libdir} -lgeos_c -+ echo -L${libdir} @LDFLAGS@ -lgeos_c - ;; - --cclibs) -- echo -L${libdir} -lgeos -+ echo -L${libdir} @LDFLAGS@ -lgeos - ;; - --static-clibs) -- echo -L${libdir} -lgeos_c -lgeos -lm -+ echo -L${libdir} @LDFLAGS@ -lgeos_c -lgeos -lm - ;; - --static-cclibs) -- echo -L${libdir} -lgeos -lm -+ echo -L${libdir} @LDFLAGS@ -lgeos -lm +@@ -58,7 +58,7 @@ case $1 in + echo -L${libdir} -lgeos -lm ;; --ldflags) - echo -L${libdir} Index: pkgsrc/geography/geos/patches/patch-capi_geos__ts__c.cpp diff -u pkgsrc/geography/geos/patches/patch-capi_geos__ts__c.cpp:1.1 pkgsrc/geography/geos/patches/patch-capi_geos__ts__c.cpp:1.2 --- pkgsrc/geography/geos/patches/patch-capi_geos__ts__c.cpp:1.1 Tue Sep 8 18:48:04 2015 +++ pkgsrc/geography/geos/patches/patch-capi_geos__ts__c.cpp Tue Sep 11 16:13:29 2018 @@ -1,4 +1,9 @@ -$NetBSD: patch-capi_geos__ts__c.cpp,v 1.1 2015/09/08 18:48:04 joerg Exp $ +$NetBSD: patch-capi_geos__ts__c.cpp,v 1.2 2018/09/11 16:13:29 gdt Exp $ + +\todo Document this patch. It appears to be that passing non-POD types +to variadic functions is UB. + +\todo File a bug upstream, if appropriate. --- capi/geos_ts_c.cpp.orig 2015-09-08 16:31:02.000000000 +0000 +++ capi/geos_ts_c.cpp --_----------=_1536682409214930--