Received: by mail.netbsd.org (Postfix, from userid 605) id F18D984DCB; Wed, 5 Dec 2018 19:01:43 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id DC0D384D27 for ; Wed, 5 Dec 2018 19:01:42 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id dykL_X2C8yuN for ; Wed, 5 Dec 2018 19:01:41 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id 1A10984C85 for ; Wed, 5 Dec 2018 19:01:41 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 097B9FAD6; Wed, 5 Dec 2018 19:01:41 +0000 (UTC) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_1544036501112690" MIME-Version: 1.0 Date: Wed, 5 Dec 2018 19:01:41 +0000 From: "Roland Illig" Subject: CVS commit: pkgsrc/regress/tools/files To: pkgsrc-changes@NetBSD.org Reply-To: rillig@netbsd.org X-Mailer: log_accum Message-Id: <20181205190141.097B9FAD6@cvs.NetBSD.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: pkgsrc-changes.NetBSD.org Precedence: bulk List-Unsubscribe: This is a multi-part message in MIME format. --_----------=_1544036501112690 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Module Name: pkgsrc Committed By: rillig Date: Wed Dec 5 19:01:40 UTC 2018 Modified Files: pkgsrc/regress/tools/files: sh-test.sh Log Message: regress/tools: clarify that only the NetBSD 7 shell exhibits this bug The test has been changed again to fail since making the test pass would mean this bug could later silently show up inside a large GNU configure script where it would be impossible to find. Therefore, when using pkgsrc on NetBSD 7, it is better to switch to another shell for doing pkgsrc work. The comment has been updated to be more accurate. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 pkgsrc/regress/tools/files/sh-test.sh Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. --_----------=_1544036501112690 Content-Disposition: inline Content-Length: 964 Content-Transfer-Encoding: binary Content-Type: text/x-diff; charset=us-ascii Modified files: Index: pkgsrc/regress/tools/files/sh-test.sh diff -u pkgsrc/regress/tools/files/sh-test.sh:1.2 pkgsrc/regress/tools/files/sh-test.sh:1.3 --- pkgsrc/regress/tools/files/sh-test.sh:1.2 Fri Nov 30 19:55:26 2018 +++ pkgsrc/regress/tools/files/sh-test.sh Wed Dec 5 19:01:40 2018 @@ -1,5 +1,5 @@ #! /bin/sh -# $NetBSD: sh-test.sh,v 1.2 2018/11/30 19:55:26 rillig Exp $ +# $NetBSD: sh-test.sh,v 1.3 2018/12/05 19:01:40 rillig Exp $ # set -e @@ -37,8 +37,8 @@ sh_assert_equals() { nl=" " -# This test fails with /bin/sh from 2018-11-08, see bin/53754. -if [ "`uname -s`" != "NetBSD" ]; then +# If this test fails because the result is "#define bindir \"", the +# tested shell may be from NetBSD 7.0, which is known to have this bug. +# Since NetBSD 8, this bug is fixed. See https://gnats.netbsd.org/43469. line="#define bindir \"/usr/bin\" /* bar */" sh_assert_equals "removing C comments" "#define bindir \"/usr/bin\" " "${line%%/\**}" -fi --_----------=_1544036501112690--