Received: by mail.netbsd.org (Postfix, from userid 605) id 8625A84D82; Wed, 18 Sep 2019 20:21:40 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 0C86984D5F for ; Wed, 18 Sep 2019 20:21:40 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id bovVBVdgdaSZ for ; Wed, 18 Sep 2019 20:21:39 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id 842B984D35 for ; Wed, 18 Sep 2019 20:21:39 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 7D8D8FBF4; Wed, 18 Sep 2019 20:21:39 +0000 (UTC) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_1568838099197700" MIME-Version: 1.0 Date: Wed, 18 Sep 2019 20:21:39 +0000 From: "Niclas Rosenvik" Subject: CVS commit: pkgsrc/www/netsurf To: pkgsrc-changes@NetBSD.org Reply-To: nros@netbsd.org X-Mailer: log_accum Message-Id: <20190918202139.7D8D8FBF4@cvs.NetBSD.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: pkgsrc-changes.NetBSD.org Precedence: bulk List-Unsubscribe: This is a multi-part message in MIME format. --_----------=_1568838099197700 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Module Name: pkgsrc Committed By: nros Date: Wed Sep 18 20:21:39 UTC 2019 Modified Files: pkgsrc/www/netsurf: distinfo Added Files: pkgsrc/www/netsurf/patches: patch-netsurf_frontends_gtk_download.c Log Message: Fix crash in netsurf when downloding files. Fix crash in netsurf when downloading files due to null pointer dereference. To generate a diff of this commit: cvs rdiff -u -r1.12 -r1.13 pkgsrc/www/netsurf/distinfo cvs rdiff -u -r0 -r1.1 \ pkgsrc/www/netsurf/patches/patch-netsurf_frontends_gtk_download.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. --_----------=_1568838099197700 Content-Disposition: inline Content-Length: 2094 Content-Transfer-Encoding: binary Content-Type: text/x-diff; charset=us-ascii Modified files: Index: pkgsrc/www/netsurf/distinfo diff -u pkgsrc/www/netsurf/distinfo:1.12 pkgsrc/www/netsurf/distinfo:1.13 --- pkgsrc/www/netsurf/distinfo:1.12 Thu Sep 12 15:53:02 2019 +++ pkgsrc/www/netsurf/distinfo Wed Sep 18 20:21:39 2019 @@ -1,8 +1,9 @@ -$NetBSD: distinfo,v 1.12 2019/09/12 15:53:02 nros Exp $ +$NetBSD: distinfo,v 1.13 2019/09/18 20:21:39 nros Exp $ SHA1 (netsurf-all-3.9.tar.gz) = 392aa7cf94b303228a00e6887c74e5763a81f3a4 RMD160 (netsurf-all-3.9.tar.gz) = 3f7aff04cfd253f2b18590830b0aa2fca0123b3c SHA512 (netsurf-all-3.9.tar.gz) = 3223b0a3bc9721ea1a5a81bbabdda11e1d0f63850074a5dea3ea8999e53c92f07228f58befbf10359c028965131426888a8b9595d6c3cd7a5cde33ca256cf987 Size (netsurf-all-3.9.tar.gz) = 8416458 bytes +SHA1 (patch-netsurf_frontends_gtk_download.c) = 25bbb146ed57ddfc943155b366cb73850e4ff0ac SHA1 (patch-netsurf_utils_config.h) = de48304e3484a883509ea3ad92658788f7869041 SHA1 (patch-nsgenbind_src_Makefile) = 9024fe193c532fefec83b86a8cf85f1bcffb614e Added files: Index: pkgsrc/www/netsurf/patches/patch-netsurf_frontends_gtk_download.c diff -u /dev/null pkgsrc/www/netsurf/patches/patch-netsurf_frontends_gtk_download.c:1.1 --- /dev/null Wed Sep 18 20:21:39 2019 +++ pkgsrc/www/netsurf/patches/patch-netsurf_frontends_gtk_download.c Wed Sep 18 20:21:39 2019 @@ -0,0 +1,22 @@ +$NetBSD: patch-netsurf_frontends_gtk_download.c,v 1.1 2019/09/18 20:21:39 nros Exp $ +* fix crash when downloading files (nullpointer dereference) +--- netsurf/frontends/gtk/download.c.orig 2019-07-17 15:37:00.000000000 +0000 ++++ netsurf/frontends/gtk/download.c +@@ -89,6 +89,8 @@ struct gui_download_window { + GError *error; + }; + ++bool nsgtk_download_FALSE = FALSE; ++ + typedef void (*nsgtk_download_selection_action)( + struct gui_download_window *dl, + void *user_data); +@@ -838,7 +840,7 @@ gui_download_window_create(download_cont + g_timeout_add( + UPDATE_RATE, + nsgtk_download_gsourcefunc__nsgtk_download_update, +- FALSE); ++ (gpointer) &nsgtk_download_FALSE); + } + + nsgtk_downloads_list = g_list_prepend(nsgtk_downloads_list, download); --_----------=_1568838099197700--