Received: by mail.netbsd.org (Postfix, from userid 605) id E300984E32; Thu, 12 Mar 2020 16:36:54 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 6A7C984DC2 for ; Thu, 12 Mar 2020 16:36:54 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id GDcNUpza1HUO for ; Thu, 12 Mar 2020 16:36:53 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id D377684D75 for ; Thu, 12 Mar 2020 16:36:53 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id D11B4FB27; Thu, 12 Mar 2020 16:36:53 +0000 (UTC) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_1584031013281640" MIME-Version: 1.0 Date: Thu, 12 Mar 2020 16:36:53 +0000 From: "Greg Troxel" Subject: CVS commit: pkgsrc/databases/mongodb3 To: pkgsrc-changes@NetBSD.org Reply-To: gdt@netbsd.org X-Mailer: log_accum Message-Id: <20200312163653.D11B4FB27@cvs.NetBSD.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: pkgsrc-changes.NetBSD.org Precedence: bulk List-Unsubscribe: This is a multi-part message in MIME format. --_----------=_1584031013281640 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Module Name: pkgsrc Committed By: gdt Date: Thu Mar 12 16:36:53 UTC 2020 Modified Files: pkgsrc/databases/mongodb3: distinfo pkgsrc/databases/mongodb3/patches: patch-src_third__party_wiredtiger_src_os__posix_os__fs.c Log Message: databases/mongodb3: Update patch comment Change text about the fdatasync issue based on information from Paul Ripke. To generate a diff of this commit: cvs rdiff -u -r1.7 -r1.8 pkgsrc/databases/mongodb3/distinfo cvs rdiff -u -r1.3 -r1.4 \ pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. --_----------=_1584031013281640 Content-Disposition: inline Content-Length: 3145 Content-Transfer-Encoding: binary Content-Type: text/x-diff; charset=us-ascii Modified files: Index: pkgsrc/databases/mongodb3/distinfo diff -u pkgsrc/databases/mongodb3/distinfo:1.7 pkgsrc/databases/mongodb3/distinfo:1.8 --- pkgsrc/databases/mongodb3/distinfo:1.7 Fri Mar 6 14:22:46 2020 +++ pkgsrc/databases/mongodb3/distinfo Thu Mar 12 16:36:53 2020 @@ -1,4 +1,4 @@ -$NetBSD: distinfo,v 1.7 2020/03/06 14:22:46 gdt Exp $ +$NetBSD: distinfo,v 1.8 2020/03/12 16:36:53 gdt Exp $ SHA1 (mongodb-src-r3.4.24.tar.gz) = 86909b211998f0cbc8104df774aecb3d00a01763 RMD160 (mongodb-src-r3.4.24.tar.gz) = f7e4bfe1e2bd046f1a6c0f2695762076ffee5ae5 @@ -27,4 +27,4 @@ SHA1 (patch-src_third__party_mozjs-38_pl SHA1 (patch-src_third__party_mozjs-38_platform_x86__64_netbsd_include_js-config.h) = 7ddbb4e3bf4126a1be2195acc82ff859e8130a01 SHA1 (patch-src_third__party_s2_base_port.h) = 892ce91b5aaa432f34e1e7c169b7fd6eea2a3e94 SHA1 (patch-src_third__party_wiredtiger_SConscript) = 71fd2326a4e95fec674326225bce5ccf5793aa5a -SHA1 (patch-src_third__party_wiredtiger_src_os__posix_os__fs.c) = a9a8655421e99f9f189b299643b55ad44c5469d7 +SHA1 (patch-src_third__party_wiredtiger_src_os__posix_os__fs.c) = c1f227a2e026c0c90f438384b71873fecf27cde5 Index: pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c diff -u pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c:1.3 pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c:1.4 --- pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c:1.3 Fri Mar 6 14:22:46 2020 +++ pkgsrc/databases/mongodb3/patches/patch-src_third__party_wiredtiger_src_os__posix_os__fs.c Thu Mar 12 16:36:53 2020 @@ -1,18 +1,13 @@ -$NetBSD: patch-src_third__party_wiredtiger_src_os__posix_os__fs.c,v 1.3 2020/03/06 14:22:46 gdt Exp $ +$NetBSD: patch-src_third__party_wiredtiger_src_os__posix_os__fs.c,v 1.4 2020/03/12 16:36:53 gdt Exp $ -Without this patch, the WT_PANIC_RET message happens, with errno EBADF. -The fdatasync() function is specified to fail if fd is not a valid file -descriptor that is open for writing. We believe that it is being called -on a directory, which is therefore invalid. On Linux, one can use -fdatasync() on non-writable file descriptors, but the Linux man page -acknowledges that this is non-standard behavior. +The fdatasync call is specified by POSIX, and the definition has changed: + https://pubs.opengroup.org/onlinepubs/009695399/functions/fdatasync.html + https://pubs.opengroup.org/onlinepubs/9699919799/functions/fdatasync.html -To work around this upstream bug, silently ignore fdatasync errno values -of EBADF. A better fix is likely to use fsync on directories instead. +NetBSD's fdatasync follows the earlier specification. For now, simply avoid +crashing on EBADF, at the possible expense of sync safety. -\todo Explore the fsync instead approach. - -\todo File upstream and add upstream bugtracker URL. +\todo Change NetBSD to follow the current standard. --- src/third_party/wiredtiger/src/os_posix/os_fs.c.orig 2020-01-08 16:30:41.000000000 +0000 +++ src/third_party/wiredtiger/src/os_posix/os_fs.c --_----------=_1584031013281640--