Received: by mail.netbsd.org (Postfix, from userid 605) id B6C0984D69; Sun, 15 Mar 2020 10:30:35 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 3EAC784D65 for ; Sun, 15 Mar 2020 10:30:35 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([127.0.0.1]) by localhost (mail.netbsd.org [127.0.0.1]) (amavisd-new, port 10025) with ESMTP id aRTtr2pk4rqu for ; Sun, 15 Mar 2020 10:30:34 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id A0F3184CF1 for ; Sun, 15 Mar 2020 10:30:34 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 9AED8FB27; Sun, 15 Mar 2020 10:30:34 +0000 (UTC) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_1584268234103940" MIME-Version: 1.0 Date: Sun, 15 Mar 2020 10:30:34 +0000 From: "Benny Siegert" Subject: CVS commit: pkgsrc/sysutils/py-borgbackup To: pkgsrc-changes@NetBSD.org Reply-To: bsiegert@netbsd.org X-Mailer: log_accum Message-Id: <20200315103034.9AED8FB27@cvs.NetBSD.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: pkgsrc-changes.NetBSD.org Precedence: bulk List-Unsubscribe: This is a multi-part message in MIME format. --_----------=_1584268234103940 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Module Name: pkgsrc Committed By: bsiegert Date: Sun Mar 15 10:30:34 UTC 2020 Modified Files: pkgsrc/sysutils/py-borgbackup: Makefile distinfo Log Message: Update py-borgbackup to 1.1.11. Pre-1.1.11 potential index corruption / data loss issue ------------------------------------------------------- A bug was discovered in our hashtable code, see issue #4829. The code is used for the client-side chunks cache and the server-side repo index. Although borg uses the hashtables very heavily, the index corruption did not happen too frequently, because it needed specific conditions to happen. Data loss required even more specific conditions, so it should be rare (and also detectable via borg check). You might be affected if borg crashed with / complained about: - AssertionError: Corrupted segment reference count - corrupted index or hints - ObjectNotFound: Object with key ... not found in repository ... - Index mismatch for key b'...'. (..., ...) != (-1, -1) - ValueError: stats_against: key contained in self but not in master_index. Advised procedure to fix any related issue in your indexes/caches: - install fixed borg code (on client AND server) - for all of your clients and repos remove the cache by: borg delete --cache-only YOURREPO (later, the cache will be re-built automatically) - for all your repos, rebuild the repo index by: borg check --repair YOURREPO This will also check all archives and detect if there is any data-loss issue. Affected branches / releases: fd06497 introduced the bug into 1.1-maint branch - it affects all borg 1.1.x since 1.1.0b4. fd06497 introduced the bug into master branch - it affects all borg 1.2.0 alpha releases. c5cd882 introduced the bug into 1.0-maint branch - it affects all borg 1.0.x since 1.0.11rc1. The bug was fixed by: 701159a fixes the bug in 1.1-maint branch - will be released with borg 1.1.11. fa63150 fixes the bug in master branch - will be released with borg 1.2.0a8. 7bb90b6 fixes the bug in 1.0-maint branch. Branch is EOL, no new release is planned as of now. To generate a diff of this commit: cvs rdiff -u -r1.25 -r1.26 pkgsrc/sysutils/py-borgbackup/Makefile cvs rdiff -u -r1.17 -r1.18 pkgsrc/sysutils/py-borgbackup/distinfo Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. --_----------=_1584268234103940 Content-Disposition: inline Content-Length: 1875 Content-Transfer-Encoding: binary Content-Type: text/x-diff; charset=us-ascii Modified files: Index: pkgsrc/sysutils/py-borgbackup/Makefile diff -u pkgsrc/sysutils/py-borgbackup/Makefile:1.25 pkgsrc/sysutils/py-borgbackup/Makefile:1.26 --- pkgsrc/sysutils/py-borgbackup/Makefile:1.25 Sat Jan 18 21:50:56 2020 +++ pkgsrc/sysutils/py-borgbackup/Makefile Sun Mar 15 10:30:34 2020 @@ -1,8 +1,7 @@ -# $NetBSD: Makefile,v 1.25 2020/01/18 21:50:56 jperkin Exp $ +# $NetBSD: Makefile,v 1.26 2020/03/15 10:30:34 bsiegert Exp $ -DISTNAME= borgbackup-1.1.10 +DISTNAME= borgbackup-1.1.11 PKGNAME= ${PYPKGPREFIX}-${DISTNAME} -PKGREVISION= 1 CATEGORIES= sysutils python MASTER_SITES= ${MASTER_SITE_PYPI:=b/borgbackup/} Index: pkgsrc/sysutils/py-borgbackup/distinfo diff -u pkgsrc/sysutils/py-borgbackup/distinfo:1.17 pkgsrc/sysutils/py-borgbackup/distinfo:1.18 --- pkgsrc/sysutils/py-borgbackup/distinfo:1.17 Wed Jan 1 18:21:49 2020 +++ pkgsrc/sysutils/py-borgbackup/distinfo Sun Mar 15 10:30:34 2020 @@ -1,7 +1,7 @@ -$NetBSD: distinfo,v 1.17 2020/01/01 18:21:49 bsiegert Exp $ +$NetBSD: distinfo,v 1.18 2020/03/15 10:30:34 bsiegert Exp $ -SHA1 (borgbackup-1.1.10.tar.gz) = 0e9a7ae059117ebb69009d55b5250f29bddf5e46 -RMD160 (borgbackup-1.1.10.tar.gz) = 4d02f9363b585a703c90854f22f8260cc596c84a -SHA512 (borgbackup-1.1.10.tar.gz) = 9315335208f10427e3105e10819817d15fd05171479252903bd51eaacb016bc3ff792d505b9203ce0b9b41ec350472bdb9a23b0128e7fe156aaa47c1608451c0 -Size (borgbackup-1.1.10.tar.gz) = 3610011 bytes +SHA1 (borgbackup-1.1.11.tar.gz) = 57a0cd49a31499b6d1307c671827e429c6dc2be8 +RMD160 (borgbackup-1.1.11.tar.gz) = 4956f0f74ceacab68fb16d583dbb99913371ef4f +SHA512 (borgbackup-1.1.11.tar.gz) = cf629f31d38d27ce6350670ff27b4937f2f30eddf9e0cd9209cd9d57a4ffa653f5a291ea1e1c79614dd2c08bcf5c50bc3e4e0f222e0d3cd1bbfb2d756b4a4573 +Size (borgbackup-1.1.11.tar.gz) = 3718055 bytes SHA1 (patch-src_borg_helpers.py) = 3c918f2f280406d16da0d8aba993b0e264508be2 --_----------=_1584268234103940--