Received: by mail.netbsd.org (Postfix, from userid 605) id D875084DA8; Sun, 19 Apr 2020 12:47:28 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 622A184D61 for ; Sun, 19 Apr 2020 12:47:28 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id MH3pIkmeexAv for ; Sun, 19 Apr 2020 12:47:28 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id B6D3084CD2 for ; Sun, 19 Apr 2020 12:47:27 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id B0899FB27; Sun, 19 Apr 2020 12:47:27 +0000 (UTC) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_158730044764430" MIME-Version: 1.0 Date: Sun, 19 Apr 2020 12:47:27 +0000 From: "Roland Illig" Subject: CVS commit: pkgsrc/pkgtools/check-portability/files To: pkgsrc-changes@NetBSD.org Reply-To: rillig@netbsd.org X-Mailer: log_accum Message-Id: <20200419124727.B0899FB27@cvs.NetBSD.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: pkgsrc-changes.NetBSD.org Precedence: bulk List-Unsubscribe: This is a multi-part message in MIME format. --_----------=_158730044764430 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Module Name: pkgsrc Committed By: rillig Date: Sun Apr 19 12:47:27 UTC 2020 Modified Files: pkgsrc/pkgtools/check-portability/files: check-portability.c Log Message: pkgtools/check-portability: make test == an error It had only been a warning before, due to a forgotten nerrors++. The check in mk/check/check-portability.awk already treats this case as an error. To generate a diff of this commit: cvs rdiff -u -r1.13 -r1.14 \ pkgsrc/pkgtools/check-portability/files/check-portability.c Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. --_----------=_158730044764430 Content-Disposition: inline Content-Length: 1256 Content-Transfer-Encoding: binary Content-Type: text/x-diff; charset=us-ascii Modified files: Index: pkgsrc/pkgtools/check-portability/files/check-portability.c diff -u pkgsrc/pkgtools/check-portability/files/check-portability.c:1.13 pkgsrc/pkgtools/check-portability/files/check-portability.c:1.14 --- pkgsrc/pkgtools/check-portability/files/check-portability.c:1.13 Sun Apr 19 12:05:14 2020 +++ pkgsrc/pkgtools/check-portability/files/check-portability.c Sun Apr 19 12:47:27 2020 @@ -1,4 +1,4 @@ -/* $NetBSD: check-portability.c,v 1.13 2020/04/19 12:05:14 rillig Exp $ */ +/* $NetBSD: check-portability.c,v 1.14 2020/04/19 12:47:27 rillig Exp $ */ /* Copyright (c) 2020 Roland Illig @@ -389,6 +389,7 @@ checkline_sh_dollar_random(cstr filename printf("%s:%zu:%zu: $RANDOM: %s\n", cstr_charptr(filename), lineno, idx + 1, cstr_charptr(line)); + // No nerrors++ since this is not critical. explain( W_dollar_random, "The variable $RANDOM is not required for a POSIX-conforming shell, and", @@ -437,6 +438,7 @@ checkline_sh_test_eqeq_action(cstr f1, c cstr_charptr(ad->filename), ad->lineno, (size_t) (f3.data - ad->line.data), cstr_charptr(ad->line)); + nerrors++; explain( W_test_eqeq, "The \"test\" command, as well as the \"[\" command, are not required to know", --_----------=_158730044764430--