Content-Transfer-Encoding: 7bit
Content-Type: multipart/mixed; boundary="_----------=_1591904320240000"
MIME-Version: 1.0
Date: Thu, 11 Jun 2020 19:38:40 +0000
From: "Roland Illig" <rillig@netbsd.org>
Subject: CVS commit: pkgsrc/mk
To: pkgsrc-changes@NetBSD.org
Reply-To: rillig@netbsd.org
Message-Id: <20200611193840.60D06FB27@cvs.NetBSD.org>
Sender: pkgsrc-changes-owner@NetBSD.org
Precedence: bulk

This is a multi-part message in MIME format.

--_----------=_1591904320240000
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
Content-Type: text/plain; charset="US-ASCII"

Module Name:	pkgsrc
Committed By:	rillig
Date:		Thu Jun 11 19:38:40 UTC 2020

Modified Files:
	pkgsrc/mk: subst.mk

Log Message:
mk/subst.mk: document the unspecified application order

To avoid bmake warnings because of duplicate class names, the :O:u
modifier had been added in r1.66 on 2020-03-21.  This had the side effect
that the subst classes are now applied in alphabetical order instead of
declaration order.

For this to actually matter, there must be a file that is affected by two
different subst classes and in which the substitutions depend on each
other or prevent each other.  Chances for that are pretty low.

The order is intentionally documented as being unspecified, to allow for
future modifications, just in case that a bmake variable modifier is
invented that filters for duplicates without requiring the duplicates to
be adjacent to each other.  In that situation, it would be nicer to
switch back to declaration order instead of alphabetical.


To generate a diff of this commit:
cvs rdiff -u -r1.97 -r1.98 pkgsrc/mk/subst.mk

Please note that diffs are not public domain; they are subject to the
copyright notices on the relevant files.


--_----------=_1591904320240000
Content-Disposition: inline
Content-Length: 801
Content-Transfer-Encoding: binary
Content-Type: text/x-diff; charset=us-ascii

Modified files:

Index: pkgsrc/mk/subst.mk
diff -u pkgsrc/mk/subst.mk:1.97 pkgsrc/mk/subst.mk:1.98
--- pkgsrc/mk/subst.mk:1.97	Thu Jun 11 19:27:56 2020
+++ pkgsrc/mk/subst.mk	Thu Jun 11 19:38:40 2020
@@ -1,4 +1,4 @@
-# $NetBSD: subst.mk,v 1.97 2020/06/11 19:27:56 rillig Exp $
+# $NetBSD: subst.mk,v 1.98 2020/06/11 19:38:40 rillig Exp $
 #
 # The subst framework replaces text in one or more files in the WRKSRC
 # directory. Packages can define several ``classes'' of replacements.
@@ -40,6 +40,7 @@
 # SUBST_CLASSES
 #	A list of class names.  When adding new classes to this list, be
 #	sure to append them (+=) instead of overriding them (=).
+#	The order in which the classes are applied is unspecified.
 #
 # SUBST_STAGE.<class>
 #	"stage" at which we do the text replacement. Should be one of


--_----------=_1591904320240000--