Received: by mail.netbsd.org (Postfix, from userid 605) id 5027584DE3; Mon, 5 Apr 2021 10:18:38 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 8BC2C84D81 for ; Mon, 5 Apr 2021 10:18:37 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id w4QxsV5cPz_v for ; Mon, 5 Apr 2021 10:18:37 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id CC09A84D0E for ; Mon, 5 Apr 2021 10:18:36 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id C906EFA95; Mon, 5 Apr 2021 10:18:36 +0000 (UTC) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_1617617916202800" MIME-Version: 1.0 Date: Mon, 5 Apr 2021 10:18:36 +0000 From: "Tobias Nygren" Subject: CVS commit: pkgsrc/sysutils/intel-backlight To: pkgsrc-changes@NetBSD.org Reply-To: tnn@netbsd.org X-Mailer: log_accum Message-Id: <20210405101836.C906EFA95@cvs.NetBSD.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: Precedence: bulk List-Unsubscribe: This is a multi-part message in MIME format. --_----------=_1617617916202800 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Module Name: pkgsrc Committed By: tnn Date: Mon Apr 5 10:18:36 UTC 2021 Modified Files: pkgsrc/sysutils/intel-backlight: Makefile Log Message: intel-backlight: don't set SETUID_ROOT_PERMS when UNPRIVILEGED Requested by nia@. In unprivileged installations the binary becomes setuid to the unprivileged user so it doesn't work even when ran as root via sudo, due to privilege dropping upon execution. XXX: Arguably this fix is wrong. It doesn't make sense to me that pkgsrc infrastructure uses mode 4511 in SETUID_ROOT_PERMS when UNPRIVILEGED. To generate a diff of this commit: cvs rdiff -u -r1.2 -r1.3 pkgsrc/sysutils/intel-backlight/Makefile Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. --_----------=_1617617916202800 Content-Disposition: inline Content-Length: 820 Content-Transfer-Encoding: binary Content-Type: text/x-diff; charset=us-ascii Modified files: Index: pkgsrc/sysutils/intel-backlight/Makefile diff -u pkgsrc/sysutils/intel-backlight/Makefile:1.2 pkgsrc/sysutils/intel-backlight/Makefile:1.3 --- pkgsrc/sysutils/intel-backlight/Makefile:1.2 Sun Apr 4 10:52:40 2021 +++ pkgsrc/sysutils/intel-backlight/Makefile Mon Apr 5 10:18:36 2021 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile,v 1.2 2021/04/04 10:52:40 tnn Exp $ +# $NetBSD: Makefile,v 1.3 2021/04/05 10:18:36 tnn Exp $ DISTNAME= intel_backlight_fbsd-20200418 PKGREVISION= 1 @@ -25,7 +25,11 @@ NOT_FOR_PLATFORM+= Darwin-*-* INSTALLATION_DIRS+= sbin INSTALLATION_DIRS+= ${PKGMANDIR}/man1 +.include "../../mk/bsd.prefs.mk" + +.if empty(UNPRIVILEGED:MM[yY][eE][sS]) SPECIAL_PERMS+= sbin/intel_backlight ${SETUID_ROOT_PERMS} +.endif do-install: ${INSTALL_PROGRAM} ${WRKSRC}/intel_backlight \ --_----------=_1617617916202800--