Received: from mail.netbsd.org (mail.netbsd.org [199.233.217.200]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (Client CN "mail.NetBSD.org", Issuer "mail.NetBSD.org CA" (not verified)) by mollari.NetBSD.org (Postfix) with ESMTPS id D26081A9239 for ; Sat, 13 Nov 2021 21:21:01 +0000 (UTC) Received: by mail.netbsd.org (Postfix, from userid 605) id 0518484D47; Sat, 13 Nov 2021 21:21:01 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 4120484D3F for ; Sat, 13 Nov 2021 21:21:00 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id X9gRuDQwswhj for ; Sat, 13 Nov 2021 21:20:59 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.NetBSD.org [IPv6:2001:470:a085:999:28c:faff:fe03:5984]) by mail.netbsd.org (Postfix) with ESMTP id A215784CE1 for ; Sat, 13 Nov 2021 21:20:59 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id 9BC43FAEC; Sat, 13 Nov 2021 21:20:59 +0000 (UTC) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_163683845994810" MIME-Version: 1.0 Date: Sat, 13 Nov 2021 21:20:59 +0000 From: "Roland Illig" Subject: CVS commit: pkgsrc/pkgtools/pkglint To: pkgsrc-changes@NetBSD.org Reply-To: rillig@netbsd.org X-Mailer: log_accum Message-Id: <20211113212059.9BC43FAEC@cvs.NetBSD.org> Sender: pkgsrc-changes-owner@NetBSD.org List-Id: Precedence: bulk List-Unsubscribe: This is a multi-part message in MIME format. --_----------=_163683845994810 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Module Name: pkgsrc Committed By: rillig Date: Sat Nov 13 21:20:59 UTC 2021 Modified Files: pkgsrc/pkgtools/pkglint: Makefile pkgsrc/pkgtools/pkglint/files: line.go package.go pkgsrc.go Log Message: pkgtools/pkglint: update to 21.3.3 Changes since 21.3.2: Explain warning about invalid symlink. Do not warn when a package uses MAKE_JOBS without adding it to BUILD_DEFS, since MAKE_JOBS is supposed to be a build-time only variable. To generate a diff of this commit: cvs rdiff -u -r1.702 -r1.703 pkgsrc/pkgtools/pkglint/Makefile cvs rdiff -u -r1.49 -r1.50 pkgsrc/pkgtools/pkglint/files/line.go cvs rdiff -u -r1.103 -r1.104 pkgsrc/pkgtools/pkglint/files/package.go cvs rdiff -u -r1.64 -r1.65 pkgsrc/pkgtools/pkglint/files/pkgsrc.go Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. --_----------=_163683845994810 Content-Disposition: inline Content-Length: 2515 Content-Transfer-Encoding: binary Content-Type: text/x-diff; charset=us-ascii Modified files: Index: pkgsrc/pkgtools/pkglint/Makefile diff -u pkgsrc/pkgtools/pkglint/Makefile:1.702 pkgsrc/pkgtools/pkglint/Makefile:1.703 --- pkgsrc/pkgtools/pkglint/Makefile:1.702 Fri Nov 5 20:02:47 2021 +++ pkgsrc/pkgtools/pkglint/Makefile Sat Nov 13 21:20:59 2021 @@ -1,7 +1,6 @@ -# $NetBSD: Makefile,v 1.702 2021/11/05 20:02:47 bsiegert Exp $ +# $NetBSD: Makefile,v 1.703 2021/11/13 21:20:59 rillig Exp $ -PKGNAME= pkglint-21.3.2 -PKGREVISION= 1 +PKGNAME= pkglint-21.3.3 CATEGORIES= pkgtools DISTNAME= tools MASTER_SITES= ${MASTER_SITE_GITHUB:=golang/} Index: pkgsrc/pkgtools/pkglint/files/line.go diff -u pkgsrc/pkgtools/pkglint/files/line.go:1.49 pkgsrc/pkgtools/pkglint/files/line.go:1.50 --- pkgsrc/pkgtools/pkglint/files/line.go:1.49 Sun Jun 6 07:41:34 2021 +++ pkgsrc/pkgtools/pkglint/files/line.go Sat Nov 13 21:20:59 2021 @@ -167,7 +167,7 @@ func (line *Line) Notef(format string, a G.Logger.Diag(line, Note, format, args...) } -func (line *Line) Explain(explanation ...string) { G.Logger.Explain(explanation...) } +func (*Line) Explain(explanation ...string) { G.Logger.Explain(explanation...) } func (line *Line) String() string { return sprintf("%s:%s: %s", line.Filename(), line.Linenos(), line.Text) Index: pkgsrc/pkgtools/pkglint/files/package.go diff -u pkgsrc/pkgtools/pkglint/files/package.go:1.103 pkgsrc/pkgtools/pkglint/files/package.go:1.104 --- pkgsrc/pkgtools/pkglint/files/package.go:1.103 Sat Aug 14 09:46:11 2021 +++ pkgsrc/pkgtools/pkglint/files/package.go Sat Nov 13 21:20:59 2021 @@ -1494,7 +1494,11 @@ func (pkg *Package) checkDirent(dirent C } case mode&os.ModeSymlink != 0: - NewLineWhole(dirent).Warnf("Invalid symlink name.") + line := NewLineWhole(dirent) + line.Warnf("Invalid symlink name.") + line.Explain( + "The only symlinks that pkglint ever expects are those to", + "WRKDIR, which are usually named 'work' or 'work.*'.") default: NewLineWhole(dirent).Errorf("Only files and directories are allowed in pkgsrc.") Index: pkgsrc/pkgtools/pkglint/files/pkgsrc.go diff -u pkgsrc/pkgtools/pkglint/files/pkgsrc.go:1.64 pkgsrc/pkgtools/pkglint/files/pkgsrc.go:1.65 --- pkgsrc/pkgtools/pkglint/files/pkgsrc.go:1.64 Sat Aug 14 15:11:30 2021 +++ pkgsrc/pkgtools/pkglint/files/pkgsrc.go Sat Nov 13 21:20:59 2021 @@ -881,6 +881,7 @@ func (src *Pkgsrc) loadDefaultBuildDefs( "FETCH_CMD", "FETCH_OUTPUT_ARGS", "FETCH_USING", + "MAKE_JOBS", "PKGSRC_RUN_TEST") // The following variables are used so often that not every --_----------=_163683845994810--