Received: from localhost (localhost [127.0.0.1]) by mail.netbsd.org (Postfix) with ESMTP id 6396984D62 for ; Fri, 22 Dec 2023 14:30:56 +0000 (UTC) X-Virus-Scanned: amavisd-new at netbsd.org Received: from mail.netbsd.org ([IPv6:::1]) by localhost (mail.netbsd.org [IPv6:::1]) (amavisd-new, port 10025) with ESMTP id DCgW1Ex7NDSU for ; Fri, 22 Dec 2023 14:30:55 +0000 (UTC) Received: from cvs.NetBSD.org (ivanova.netbsd.org [199.233.217.197]) by mail.netbsd.org (Postfix) with ESMTP id AC99684D4A for ; Fri, 22 Dec 2023 14:30:55 +0000 (UTC) Received: by cvs.NetBSD.org (Postfix, from userid 500) id A46B3FA42; Fri, 22 Dec 2023 14:30:55 +0000 (UTC) Content-Transfer-Encoding: 7bit Content-Type: multipart/mixed; boundary="_----------=_17032554552560" MIME-Version: 1.0 Date: Fri, 22 Dec 2023 14:30:55 +0000 From: "Dr. Thomas Orgis" Subject: CVS commit: pkgsrc/graphics/opencv To: pkgsrc-changes@NetBSD.org Approved: commit_and_comment Reply-To: thor@netbsd.org X-Mailer: log_accum Message-Id: <20231222143055.A46B3FA42@cvs.NetBSD.org> This is a multi-part message in MIME format. --_----------=_17032554552560 Content-Disposition: inline Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset="US-ASCII" Module Name: pkgsrc Committed By: thor Date: Fri Dec 22 14:30:55 UTC 2023 Modified Files: pkgsrc/graphics/opencv: Makefile.common Log Message: graphics/opencv: disable stupid extern "C" that broke NetBSD build For no good reason, perhaps for ancient LAPACK headers, the wrapper header puts the includes into extern "C". This causes some compilers to complain because LAPACK headers do C++ stuff if they see a C++ compiler and then add extern "C" themselves. To generate a diff of this commit: cvs rdiff -u -r1.18 -r1.19 pkgsrc/graphics/opencv/Makefile.common Please note that diffs are not public domain; they are subject to the copyright notices on the relevant files. --_----------=_17032554552560 Content-Disposition: inline Content-Length: 892 Content-Transfer-Encoding: binary Content-Type: text/x-diff; charset=us-ascii Modified files: Index: pkgsrc/graphics/opencv/Makefile.common diff -u pkgsrc/graphics/opencv/Makefile.common:1.18 pkgsrc/graphics/opencv/Makefile.common:1.19 --- pkgsrc/graphics/opencv/Makefile.common:1.18 Fri Dec 22 07:35:07 2023 +++ pkgsrc/graphics/opencv/Makefile.common Fri Dec 22 14:30:55 2023 @@ -1,4 +1,4 @@ -# $NetBSD: Makefile.common,v 1.18 2023/12/22 07:35:07 thor Exp $ +# $NetBSD: Makefile.common,v 1.19 2023/12/22 14:30:55 thor Exp $ # used by graphics/opencv/Makefile # used by graphics/opencv-contrib-face/Makefile # @@ -46,6 +46,7 @@ CMAKE_ARGS+= -DBLA_PKGCONFIG_BLAS=${BLA CMAKE_ARGS+= -DBLA_PKGCONFIG_LAPACK=${LAPACK_PC} CMAKE_ARGS+= -DBLA_PKGCONFIG_CBLAS=${CBLAS_PC} CMAKE_ARGS+= -DBLA_PKGCONFIG_LAPACKE=${LAPACKE_PC} +CMAKE_ARGS+= -DOPENCV_SKIP_LAPACK_EXTERN_C=ON BUILDLINK_TRANSFORM+= rm:-Werror=address BUILDLINK_TRANSFORM+= rm:-Werror=non-virtual-dtor --_----------=_17032554552560--