Mon Apr 7 17:34:51 2008 UTC ()
Add note about LOCALBASE


(joerg)
diff -r1.65 -r1.66 pkgsrc/pkgtools/pkglint/TODO
cvs diff -r1.65 -r1.66 pkgsrc/pkgtools/pkglint/Attic/TODO (expand / switch to unified diff)

--- pkgsrc/pkgtools/pkglint/Attic/TODO 2008/03/10 22:01:04 1.65
+++ pkgsrc/pkgtools/pkglint/Attic/TODO 2008/04/07 17:34:51 1.66
@@ -1,14 +1,14 @@ @@ -1,14 +1,14 @@
1$NetBSD: TODO,v 1.65 2008/03/10 22:01:04 tnn Exp $ 1$NetBSD: TODO,v 1.66 2008/04/07 17:34:51 joerg Exp $
2 2
3Please add your own entries at the bottom of this file. If possible, 3Please add your own entries at the bottom of this file. If possible,
4include the name of an example package where a warning should occur. 4include the name of an example package where a warning should occur.
5 5
6* fix false positive warnings 6* fix false positive warnings
7* warn about the use of ${WRKDIR:=...}, as this construct should only 7* warn about the use of ${WRKDIR:=...}, as this construct should only
8 be used with lists. 8 be used with lists.
9* record with each substring its source location to be able to make 9* record with each substring its source location to be able to make
10 even more precise diagnostics 10 even more precise diagnostics
11* Many of the checking routines need some context to provide better 11* Many of the checking routines need some context to provide better
12 warnings. For example, checkline_foo() may need to know what has 12 warnings. For example, checkline_foo() may need to know what has
13 happened in the file before that line. 13 happened in the file before that line.
14* Add checks for binary packages. See Debian/lintian for ideas. 14* Add checks for binary packages. See Debian/lintian for ideas.
@@ -22,26 +22,27 @@ include the name of an example package w @@ -22,26 +22,27 @@ include the name of an example package w
22 variables for use in other files. 22 variables for use in other files.
23* ${MACHINE_ARCH}-${LOWER_OPSYS}elf in PLISTs etc. is a NetBSD config.guess 23* ${MACHINE_ARCH}-${LOWER_OPSYS}elf in PLISTs etc. is a NetBSD config.guess
24 problem ==> use of ${APPEND_ELF} 24 problem ==> use of ${APPEND_ELF}
25* Packages including lang/python/extension.mk must follow the Python version 25* Packages including lang/python/extension.mk must follow the Python version
26 scheme. Enforcing PYPKGPREFIX for those is most likely a good idea. 26 scheme. Enforcing PYPKGPREFIX for those is most likely a good idea.
27* Check for parallel files/dirs whose names differ only in case. 27* Check for parallel files/dirs whose names differ only in case.
28* Check for license files that are completely unused. 28* Check for license files that are completely unused.
29* If a dependency depends on an option (in options.mk), it should also 29* If a dependency depends on an option (in options.mk), it should also
30 depend on the same option in the buildlink3.mk file. 30 depend on the same option in the buildlink3.mk file.
31* Complain about ${PKGSRC_COMPILER} == "sunpro", which should be 31* Complain about ${PKGSRC_COMPILER} == "sunpro", which should be
32 !empty(PKGSRC_COMPILER:Msunpro). 32 !empty(PKGSRC_COMPILER:Msunpro).
33* If USE_TOOLS has autoconf213, and the package does stuff like 33* If USE_TOOLS has autoconf213, and the package does stuff like
34 cd ${WRKSRC} && autoconf, then an incorrect warning is issued. 34 cd ${WRKSRC} && autoconf, then an incorrect warning is issued.
 35* LOCALBASE should not be used in normal Makefiles
35 36
36% 37%
37 38
38mail/mail-notification failed for Thomas, apparently because of an 39mail/mail-notification failed for Thomas, apparently because of an
39unexpressed dependency on hicolor-icon-theme. I don't know if it's 40unexpressed dependency on hicolor-icon-theme. I don't know if it's
40possible to add a way to notice that the PLIST contains hicolor files 41possible to add a way to notice that the PLIST contains hicolor files
41but that there's no dependency, or perhaps a list of mappings of sets of 42but that there's no dependency, or perhaps a list of mappings of sets of
42PLIST regexes to sets of required packages, or something. 43PLIST regexes to sets of required packages, or something.
43 44
44% 45%
45 46
46* don't complain about "procedure calls", like for pkg-build-options in 47* don't complain about "procedure calls", like for pkg-build-options in
47 the various buildlink3.mk files. 48 the various buildlink3.mk files.