Sun May 11 03:46:24 2008 UTC ()
Add a patch for CVE-2008-1558 to mplayer. This fixes a buffer overflow in
the RealRTSP SDP code which can be exploited to execute arbitrary code
remotely.


(tonnerre)
diff -r1.58 -r1.59 pkgsrc/multimedia/mplayer/Makefile
diff -r1.49 -r1.50 pkgsrc/multimedia/mplayer-share/distinfo
diff -r0 -r1.3 pkgsrc/multimedia/mplayer-share/patches/patch-al
cvs diff -r1.58 -r1.59 pkgsrc/multimedia/mplayer/Makefile (expand / switch to unified diff)

--- pkgsrc/multimedia/mplayer/Makefile 2008/04/28 14:32:11 1.58
+++ pkgsrc/multimedia/mplayer/Makefile 2008/05/11 03:46:24 1.59
@@ -1,17 +1,17 @@ @@ -1,17 +1,17 @@
1# $NetBSD: Makefile,v 1.58 2008/04/28 14:32:11 drochner Exp $ 1# $NetBSD: Makefile,v 1.59 2008/05/11 03:46:24 tonnerre Exp $
2 2
3PKGNAME= mplayer-${MPLAYER_PKG_VERSION} 3PKGNAME= mplayer-${MPLAYER_PKG_VERSION}
4PKGREVISION= 6 4PKGREVISION= 7
5 5
6COMMENT= Software-only MPEG-1/2/4 video decoder 6COMMENT= Software-only MPEG-1/2/4 video decoder
7 7
8PKG_DESTDIR_SUPPORT= user-destdir 8PKG_DESTDIR_SUPPORT= user-destdir
9 9
10.include "../../multimedia/mplayer-share/Makefile.common" 10.include "../../multimedia/mplayer-share/Makefile.common"
11 11
12CONFIGURE_ARGS+= --disable-mencoder 12CONFIGURE_ARGS+= --disable-mencoder
13CONFIGURE_ARGS+= --confdir=${PREFIX}/share/mplayer 13CONFIGURE_ARGS+= --confdir=${PREFIX}/share/mplayer
14 14
15# Solaris/x86 has Xv, but the header files live in /usr/X11R6, not 15# Solaris/x86 has Xv, but the header files live in /usr/X11R6, not
16# ${X11_BASE}, so we need to also look for headers in this path. 16# ${X11_BASE}, so we need to also look for headers in this path.
17.if ${OPSYS} == "SunOS" && ${MACHINE_ARCH} == "i386" 17.if ${OPSYS} == "SunOS" && ${MACHINE_ARCH} == "i386"
cvs diff -r1.49 -r1.50 pkgsrc/multimedia/mplayer-share/distinfo (expand / switch to unified diff)

--- pkgsrc/multimedia/mplayer-share/distinfo 2008/04/14 06:55:47 1.49
+++ pkgsrc/multimedia/mplayer-share/distinfo 2008/05/11 03:46:24 1.50
@@ -1,21 +1,22 @@ @@ -1,21 +1,22 @@
1$NetBSD: distinfo,v 1.49 2008/04/14 06:55:47 joerg Exp $ 1$NetBSD: distinfo,v 1.50 2008/05/11 03:46:24 tonnerre Exp $
2 2
3SHA1 (mplayer-1.0rc10/MPlayer-1.0rc2.tar.bz2) = e9b496f3527c552004ec6d01d6b43f196b43ce2d 3SHA1 (mplayer-1.0rc10/MPlayer-1.0rc2.tar.bz2) = e9b496f3527c552004ec6d01d6b43f196b43ce2d
4RMD160 (mplayer-1.0rc10/MPlayer-1.0rc2.tar.bz2) = 3b5cba1529856a177a5191e22f8dcc00b5a83c52 4RMD160 (mplayer-1.0rc10/MPlayer-1.0rc2.tar.bz2) = 3b5cba1529856a177a5191e22f8dcc00b5a83c52
5Size (mplayer-1.0rc10/MPlayer-1.0rc2.tar.bz2) = 9338201 bytes 5Size (mplayer-1.0rc10/MPlayer-1.0rc2.tar.bz2) = 9338201 bytes
6SHA1 (patch-aa) = 44e185164de7dbeb26cf51892e62a32517b9b7c4 6SHA1 (patch-aa) = 44e185164de7dbeb26cf51892e62a32517b9b7c4
7SHA1 (patch-ab) = 29bf59ecb3d283708ae1c5002d1fa71cac627cc9 7SHA1 (patch-ab) = 29bf59ecb3d283708ae1c5002d1fa71cac627cc9
8SHA1 (patch-ac) = 6d0de4bd41d9842ea1bf46e9fbe60bf6a943b913 8SHA1 (patch-ac) = 6d0de4bd41d9842ea1bf46e9fbe60bf6a943b913
9SHA1 (patch-ad) = d0b72eaa5e63d2cfd7828ea1a9973f1728c607b5 9SHA1 (patch-ad) = d0b72eaa5e63d2cfd7828ea1a9973f1728c607b5
10SHA1 (patch-ae) = 24ac251b3f8d7a94cf61dbe4c960ac76884649f9 10SHA1 (patch-ae) = 24ac251b3f8d7a94cf61dbe4c960ac76884649f9
11SHA1 (patch-af) = e8b6f2b914f9b8e9f12d92cb49b91b4381a46ce5 11SHA1 (patch-af) = e8b6f2b914f9b8e9f12d92cb49b91b4381a46ce5
12SHA1 (patch-ag) = b46d902d88e05d6f61a017e8a1be79fad5a1fa00 12SHA1 (patch-ag) = b46d902d88e05d6f61a017e8a1be79fad5a1fa00
13SHA1 (patch-ah) = 7aeb9f04d622fcad8c40dc9edbb0a58277fc622b 13SHA1 (patch-ah) = 7aeb9f04d622fcad8c40dc9edbb0a58277fc622b
14SHA1 (patch-ai) = ec79d6a1b0c2790ca826a91a48040c64632ac988 14SHA1 (patch-ai) = ec79d6a1b0c2790ca826a91a48040c64632ac988
15SHA1 (patch-aj) = 772d083dfa5eac789abfd5e925eeeba400bbc527 15SHA1 (patch-aj) = 772d083dfa5eac789abfd5e925eeeba400bbc527
16SHA1 (patch-ak) = 072b4391e5fde58f6b01bd43133f1d017fc14d58 16SHA1 (patch-ak) = 072b4391e5fde58f6b01bd43133f1d017fc14d58
 17SHA1 (patch-al) = 9538b10cf5b3802381d7aabc798676b3cb9ef00d
17SHA1 (patch-ba) = 2683c414fed3a4a6d3b4d47287f43d822339bd4e 18SHA1 (patch-ba) = 2683c414fed3a4a6d3b4d47287f43d822339bd4e
18SHA1 (patch-bb) = 26d000bcbc94b9139e6dbc79237fdb3a109c6057 19SHA1 (patch-bb) = 26d000bcbc94b9139e6dbc79237fdb3a109c6057
19SHA1 (patch-bc) = fd46ce3cd6d5f7525e210cf6d475b89573ca988d 20SHA1 (patch-bc) = fd46ce3cd6d5f7525e210cf6d475b89573ca988d
20SHA1 (patch-bd) = 9132118a143758b6c9e9dffb713f7dadd29ce3c3 21SHA1 (patch-bd) = 9132118a143758b6c9e9dffb713f7dadd29ce3c3
21SHA1 (patch-tc) = 89f802ff0ebfc14d6f2a4b17177915f66c9f9038 22SHA1 (patch-tc) = 89f802ff0ebfc14d6f2a4b17177915f66c9f9038
File Added: pkgsrc/multimedia/mplayer-share/patches/Attic/patch-al
$NetBSD: patch-al,v 1.3 2008/05/11 03:46:24 tonnerre Exp $

--- stream/realrtsp/sdpplin.c.orig	2007-10-07 21:49:25.000000000 +0200
+++ stream/realrtsp/sdpplin.c
@@ -330,7 +330,8 @@ sdpplin_t *sdpplin_parse(char *data) {
     
     if(filter(data,"a=StreamCount:integer;",&buf)) {
       desc->stream_count=(unsigned int)atoi(buf);
-      desc->stream=malloc(sizeof(sdpplin_stream_t*)*desc->stream_count);
+      desc->stream=calloc(desc->stream_count, sizeof(sdpplin_stream_t*));
+      if (!desc->stream) desc->stream_count = 0;
       handled=1;
       data=nl(data);
     }