Add patches "solving" the issue of bacula exposing passwords et cetera
through the command line parameters of various tools (CVE-2007-5626).


(tonnerre)

$NetBSD: patch-aa,v 1.1 2008/07/13 15:26:36 tonnerre Exp $

--- manual/tips.tex.orig	2007-01-15 10:37:15.000000000 +0100
+++ manual/tips.tex
@@ -598,6 +598,11 @@ setup procedure leaves the database open
 assign the user {\bf bacula} a userid and add it to your Director's
 configuration file in the appropriate Catalog resource. 
 
+If you use the make_catalog_backup script provided by Bacula, remember that
+you should take care when supplying passwords on the command line.  Read the
+\ilink{BackingUpBaculaSecurityConsiderations}{Backing Up Your Bacula
+Database - Security Considerations } for more information.
+
 \section{Creating Holiday Schedules}
 \label{holiday}
 \index[general]{Schedules!Creating Holiday }

$NetBSD: patch-ab,v 1.1 2008/07/13 15:26:36 tonnerre Exp $

--- manual/catmaintenance.tex.orig	2007-01-05 18:20:40.000000000 +0100
+++ manual/catmaintenance.tex
@@ -545,6 +545,8 @@ Job {
   Storage = DLTDrive
   Messages = Standard
   Pool = Default
+  # WARNING!!! Passing the password via the command line is insecure.
+  # see comments in make_catalog_backup for details.
   RunBeforeJob = "/home/kern/bacula/bin/make_catalog_backup"
   RunAfterJob  = "/home/kern/bacula/bin/delete_catalog_backup"
   Write Bootstrap = "/home/kern/bacula/working/BackupCatalog.bsr"
@@ -573,6 +575,33 @@ you to quickly recover the database back
 you do not have a bootstrap file, it is still possible to recover your
 database backup, but it will be more work and take longer. 
 
+
+\label{BackingUpBaculaSecurityConsiderations}
+\section{Security considerations}
+\index[general]{Backing Up Your Bacula Database - Security Considerations }
+\index[general]{Database!Backing Up Your Bacula Database - Security Considerations }
+
+We provide make_catalog_backup as an example of what can be used to backup
+your Bacula database.  We expect you to take security precautions relevant
+to your situation.  make_catalog_backup is designed to take a password on
+the command line.  This is fine on machines with only trusted users.  It is
+not acceptable on machines without trusted users.  Most database systems
+provide a alternative method, which does not place the password on the
+command line.
+
+The make_catalog_backup contains some warnings about how to use it. Please
+read those tips.
+
+To help you get started, we know PostgreSQL has a password file,
+\elink{
+.pgpass}{http://www.postgresql.org/docs/8.2/static/libpq-pgpass.html}, and
+we know MySQL has
+\elink{ .my.cnf}{http://dev.mysql.com/doc/refman/4.1/en/password-security.html}.
+
+Only you can decide what is appropriate for your situation. We have provided
+you with a starting point.  We hope it helps.
+
+
 \label{BackingUPOtherDBs}
 \section{Backing Up Third Party Databases}
 \index[general]{Backing Up Third Party Databases }

$NetBSD: patch-ac,v 1.1 2008/07/13 15:26:36 tonnerre Exp $

--- manual/pools.tex.orig	2007-01-05 18:20:41.000000000 +0100
+++ manual/pools.tex
@@ -235,6 +235,8 @@ Job {
   Messages = Standard
   Pool = Default
   # This creates an ASCII copy of the catalog
+  # WARNING!!! Passing the password via the command line is insecure.
+  # see comments in make_catalog_backup for details.
   RunBeforeJob = "/home/bacula/bin/make_catalog_backup bacula bacula"
   # This deletes the copy of the catalog
   RunAfterJob  = "/home/bacula/bin/delete_catalog_backup"

$NetBSD: patch-ad,v 1.1 2008/07/13 15:26:36 tonnerre Exp $

--- manual/postgresql.tex.orig	2007-01-05 18:20:41.000000000 +0100
+++ manual/postgresql.tex
@@ -200,6 +200,8 @@ password in place, these two lines shoul
 \begin{verbatim}
   dbname = bacula; user = bacula; password = "secret"
     ... and ...
+ # WARNING!!! Passing the password via the command line is insecure.
+ # see comments in make_catalog_backup for details.
   RunBeforeJob = "/etc/make_catalog_backup bacula bacula secret"
 \end{verbatim}
 \normalsize

$NetBSD: patch-ae,v 1.1 2008/07/13 15:26:36 tonnerre Exp $

--- manual/strategies.tex.orig	2007-01-15 10:37:15.000000000 +0100
+++ manual/strategies.tex
@@ -232,6 +232,8 @@ Job {
   Messages = Standard
   Pool = Default
  # This creates an ASCII copy of the catalog
+ # WARNING!!! Passing the password via the command line is insecure.
+ # see comments in make_catalog_backup for details.
   RunBeforeJob = "/usr/lib/bacula/make_catalog_backup -u bacula"
  # This deletes the copy of the catalog, and ejects the tape
   RunAfterJob  = "/etc/bacula/end_of_backup.sh"

$NetBSD: patch-ab,v 1.1 2008/07/13 15:26:36 tonnerre Exp $

--- src/cats/make_catalog_backup.in.orig	2007-04-24 17:36:15.000000000 +0200
+++ src/cats/make_catalog_backup.in
@@ -8,7 +8,11 @@
 #  $2 is the user name with which to access the database
 #     (default = bacula).
 #  $3 is the password with which to access the database or "" if no password
-#     (default "")
+#     (default ""). WARNING!!! Passing the password via the command line is 
+#     insecure and should not be used since any user can display the command 
+#     line arguments and the environment using ps.  Please consult your
+#     MySQL or PostgreSQL manual for secure methods of specifying the
+#     password.
 #  $4 is the host on which the database is located
 #     (default "")
 #
@@ -31,7 +35,7 @@ else
     else
       MYSQLHOST=""
     fi
-    ${BINDIR}/mysqldump -u $2$MYSQLPASSWORD$MYSQLHOST -f --opt $1 >$1.sql
+    ${BINDIR}/mysqldump -u ${2}${MYSQLPASSWORD}${MYSQLHOST} -f --opt $1 >$1.sql
   else			      
     if test xpostgresql = x@DB_TYPE@ ; then
       if test $# -gt 2; then

$NetBSD: patch-ak,v 1.3 2008/07/13 15:26:36 tonnerre Exp $

--- src/dird/bacula-dir.conf.in.orig	2007-05-27 21:30:39.000000000 +0200
+++ src/dird/bacula-dir.conf.in
@@ -61,6 +61,8 @@ Job {
   FileSet="Catalog"
   Schedule = "WeeklyCycleAfterBackup"
   # This creates an ASCII copy of the catalog
+  # WARNING!!! Passing the password via the command line is insecure.
+  # see comments in make_catalog_backup for details.
   RunBeforeJob = "@scriptdir@/make_catalog_backup bacula bacula"
   # This deletes the copy of the catalog
   RunAfterJob  = "@scriptdir@/delete_catalog_backup"