Sun Dec 14 18:46:58 2008 UTC ()

Changed one of the explanations to be more permissive. Fixed a
grammatical mistake in the same sentence.


(rillig)

diff -r1.794 -r1.795 pkgsrc/pkgtools/pkglint/files/pkglint.pl

--- pkgsrc/pkgtools/pkglint/files/Attic/pkglint.pl 2008/12/05 06:48:05 1.794
+++ pkgsrc/pkgtools/pkglint/files/Attic/pkglint.pl 2008/12/14 18:46:58 1.795

 @@ -1,15 +1,15 @@
 #! @PERL@
-# $NetBSD: pkglint.pl,v 1.794 2008/12/05 06:48:05 wiz Exp $
+# $NetBSD: pkglint.pl,v 1.795 2008/12/14 18:46:58 rillig Exp $
+#
 # pkglint - static analyzer and checker for pkgsrc packages
+#
 # Written by:
 #	Roland Illig <rillig@NetBSD.org>
+#
 # Based on work by:
 #	Hubert Feyrer <hubertf@NetBSD.org>
 #	Thorsten Frueauf <frueauf@NetBSD.org>
 #	Thomas Klausner <wiz@NetBSD.org>
 #	and others.
+#
 @@ -5061,28 +5061,28 @@ sub checkline_mk_vartype_basic($$$$$$$$)
 	} elsif ($type eq "Option") {
 		if ($value ne $value_novar) {
 			$opt_debug_unchecked and $line->log_debug("Unchecked option name \"${value}\".");
 		} elsif ($value_novar =~ m"^-?([a-z][-0-9a-z]*)$") {
 			my ($optname) = ($1);
 			if (!exists(get_pkg_options()->{$optname})) {
 				$line->log_warning("Unknown option \"${value}\".");
 				$line->explain_warning(
 "This option is not documented in the mk/defaults/options.description",
 "file. If this is not a typo, please think of a brief but precise",
-"description and ask on the tech-pkg\@NetBSD.org for inclusion in the",
+"description and either update that file yourself or ask on the",
-"database.");
+"tech-pkg\@NetBSD.org mailing list.");
+			}
 		} elsif ($value_novar =~ m"^-?([a-z][-0-9a-z_]*)$") {
 			my ($optname) = ($1);
 			$line->log_warning("Use of the underscore character in option names is deprecated.");
 		} else {
 			$line->log_error("\"${value}\" is not a valid option name.");
+		}
 	} elsif ($type eq "Pathlist") {