Sun Feb 15 14:41:40 2009 UTC ()
Fix build with latest libgpod, and depend on it. Bump PKGREVISION.

Patches from upstream, based on
http://lists.kde.org/?l=kde-commits&m=123341209907417&w=2


(wiz)
diff -r1.39 -r1.40 pkgsrc/graphics/kipi-plugins/Makefile
diff -r1.18 -r1.19 pkgsrc/graphics/kipi-plugins/distinfo
diff -r0 -r1.11 pkgsrc/graphics/kipi-plugins/patches/patch-aa
diff -r0 -r1.7 pkgsrc/graphics/kipi-plugins/patches/patch-ab
diff -r0 -r1.7 pkgsrc/graphics/kipi-plugins/patches/patch-ac

cvs diff -r1.39 -r1.40 pkgsrc/graphics/kipi-plugins/Makefile (expand / switch to unified diff)

--- pkgsrc/graphics/kipi-plugins/Makefile 2009/01/07 01:43:49 1.39
+++ pkgsrc/graphics/kipi-plugins/Makefile 2009/02/15 14:41:40 1.40
@@ -1,33 +1,37 @@ @@ -1,33 +1,37 @@
1# $NetBSD: Makefile,v 1.39 2009/01/07 01:43:49 gdt Exp $ 1# $NetBSD: Makefile,v 1.40 2009/02/15 14:41:40 wiz Exp $
2 2
3DISTNAME= kipi-plugins-0.1.7 3DISTNAME= kipi-plugins-0.1.7
4PKGREVISION= 1 4PKGREVISION= 2
5CATEGORIES= graphics 5CATEGORIES= graphics
6MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=kipi/} 6MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=kipi/}
7EXTRACT_SUFX= .tar.bz2 7EXTRACT_SUFX= .tar.bz2
8 8
9MAINTAINER= pkgsrc-users@NetBSD.org 9MAINTAINER= pkgsrc-users@NetBSD.org
10HOMEPAGE= http://www.kipi-plugins.org/drupal/ 10HOMEPAGE= http://www.kipi-plugins.org/drupal/
11COMMENT= Kipi (KDE Image Plugin Interface) plugins 11COMMENT= Kipi (KDE Image Plugin Interface) plugins
12 12
13PKG_DESTDIR_SUPPORT= user-destdir 13PKG_DESTDIR_SUPPORT= user-destdir
14 14
15USE_TOOLS+= gmake perl pkg-config msgfmt bash:run 15USE_TOOLS+= gmake perl pkg-config msgfmt bash:run
16USE_LANGUAGES= c c++ 16USE_LANGUAGES= c c++
17GNU_CONFIGURE= YES 17GNU_CONFIGURE= YES
18USE_LIBTOOL= YES 18USE_LIBTOOL= YES
19SHLIBTOOL_OVERRIDE= # empty 19SHLIBTOOL_OVERRIDE= # empty
20 20
21REPLACE_BASH= kipi-plugins/mpegencoder/images2mpg 21REPLACE_BASH= kipi-plugins/mpegencoder/images2mpg
22 22
23.include "../../meta-pkgs/kde3/kde3.mk" 23.include "../../meta-pkgs/kde3/kde3.mk"
 24BUILDLINK_API_DEPENDS.libgpod+= libgpod>=0.7.0
24.include "../../audio/libgpod/buildlink3.mk" 25.include "../../audio/libgpod/buildlink3.mk"
25.include "../../devel/libgphoto2/buildlink3.mk" 26.include "../../devel/libgphoto2/buildlink3.mk"
26.include "../../graphics/ImageMagick/buildlink3.mk" 27.include "../../graphics/ImageMagick/buildlink3.mk"
27BUILDLINK_API_DEPENDS.libkdcraw+= libkdcraw>=0.1.4 28BUILDLINK_API_DEPENDS.libkdcraw+= libkdcraw>=0.1.4
28.include "../../graphics/libkdcraw/buildlink3.mk" 29.include "../../graphics/libkdcraw/buildlink3.mk"
29.include "../../graphics/libkexiv2/buildlink3.mk" 30.include "../../graphics/libkexiv2/buildlink3.mk"
30.include "../../graphics/libkipi/buildlink3.mk" 31.include "../../graphics/libkipi/buildlink3.mk"
31.include "../../multimedia/mjpegtools/buildlink3.mk" 32.include "../../multimedia/mjpegtools/buildlink3.mk"
 33# gdk from gtk2 is needed for libgpod artwork support
 34BUILDLINK_API_DEPENDS.gtk2+= gtk2+>=2.10.0
 35.include "../../x11/gtk2/buildlink3.mk"
32.include "../../x11/kdelibs3/buildlink3.mk" 36.include "../../x11/kdelibs3/buildlink3.mk"
33.include "../../mk/bsd.pkg.mk" 37.include "../../mk/bsd.pkg.mk"

cvs diff -r1.18 -r1.19 pkgsrc/graphics/kipi-plugins/distinfo (expand / switch to unified diff)

--- pkgsrc/graphics/kipi-plugins/distinfo 2009/01/06 18:54:00 1.18
+++ pkgsrc/graphics/kipi-plugins/distinfo 2009/02/15 14:41:40 1.19
@@ -1,5 +1,8 @@ @@ -1,5 +1,8 @@
1$NetBSD: distinfo,v 1.18 2009/01/06 18:54:00 drochner Exp $ 1$NetBSD: distinfo,v 1.19 2009/02/15 14:41:40 wiz Exp $
2 2
3SHA1 (kipi-plugins-0.1.7.tar.bz2) = 520b6b9d36a8c5b8893c3a6b5a1a14f6b9cbd216 3SHA1 (kipi-plugins-0.1.7.tar.bz2) = 520b6b9d36a8c5b8893c3a6b5a1a14f6b9cbd216
4RMD160 (kipi-plugins-0.1.7.tar.bz2) = f66473c11e66f9e06aa6772c7952b640b565def9 4RMD160 (kipi-plugins-0.1.7.tar.bz2) = f66473c11e66f9e06aa6772c7952b640b565def9
5Size (kipi-plugins-0.1.7.tar.bz2) = 8836654 bytes 5Size (kipi-plugins-0.1.7.tar.bz2) = 8836654 bytes
 6SHA1 (patch-aa) = 02e5cb365c7fb4e24c7236b592af3d00eeab1fdf
 7SHA1 (patch-ab) = db8b5ecc602026d3d6dd39297311d693537b68ce
 8SHA1 (patch-ac) = 0022166061696e3db820c97be64e2780a63e8b4c

File Added: pkgsrc/graphics/kipi-plugins/patches/Attic/patch-aa
$NetBSD: patch-aa,v 1.11 2009/02/15 14:41:40 wiz Exp $

--- kipi-plugins/ipodexport/Makefile.in.orig	2008-12-13 11:20:38.000000000 +0000
+++ kipi-plugins/ipodexport/Makefile.in
@@ -384,6 +384,7 @@ xdg_menudir = @xdg_menudir@
 INCLUDES = $(KIPI_PLUGINS_COMMON_INCLUDE) \
               $(LIBKIPI_CFLAGS) \
               $(LIBGPOD_CFLAGS) \
+              $(GDK_CFLAGS) \
               $(all_includes)
 
 #>- METASOURCES = AUTO
@@ -396,7 +397,7 @@ kipiplugin_ipodexport_la_SOURCES = plugi
                                    imagelist.cpp
 
 kipiplugin_ipodexport_la_LIBADD = $(LIBKIPI_LIBS) $(LIB_KIO) $(LIB_KDEUI) $(LIB_KDECORE) $(LIB_QT)
-kipiplugin_ipodexport_la_LDFLAGS = -module $(KDE_PLUGIN) $(LIBGPOD_LIBS) $(all_libraries)
+kipiplugin_ipodexport_la_LDFLAGS = -module $(KDE_PLUGIN) $(LIBGPOD_LIBS) $(GDK_LIBS) $(all_libraries)
 kde_services_DATA = kipiplugin_ipodexport.desktop
 #>- all: all-am
 #>+ 1

File Added: pkgsrc/graphics/kipi-plugins/patches/Attic/patch-ab
$NetBSD: patch-ab,v 1.7 2009/02/15 14:41:40 wiz Exp $

--- kipi-plugins/ipodexport/ipodexportdialog.cpp.orig	2008-12-13 11:20:05.000000000 +0000
+++ kipi-plugins/ipodexport/ipodexportdialog.cpp
@@ -47,6 +47,10 @@
 #include <libkipi/imagedialog.h>
 #endif
 
+extern "C" {
+#include <gdk-pixbuf/gdk-pixbuf.h>
+}
+
 #define debug() kdDebug()
 
 using namespace IpodExport;
@@ -344,9 +348,13 @@ UploadDialog::ipodItemSelected( QListVie
         return;
 
     Itdb_Artwork *artwork = item->artwork();
-    Itdb_Thumb *thumb = itdb_artwork_get_thumb_by_type( artwork, ITDB_THUMB_PHOTO_SMALL );
+    GdkPixbuf *gpixbuf = NULL;
 
-    if( !thumb )
+    // First arg in itdb_artwork_get_pixbuf(...) is pointer to Itdb_Device struct,
+    // in kipiplugin-ipodexport it is m_itdb->device. i hope it _is_ initialiezed
+    gpixbuf = (GdkPixbuf*) itdb_artwork_get_pixbuf( m_itdb->device, artwork, -1, -1 );
+
+    if( !gpixbuf )
     {
         debug() << "no thumb was found" << endl;
         return;
@@ -361,6 +369,9 @@ UploadDialog::ipodItemSelected( QListVie
 //     QPixmap pix;
 //     pix.convertFromImage( image );
 //     m_ipodPreview->setPixmap( pix );
+
+    // memory release
+    gdk_pixbuf_unref ( gpixbuf );
 }
 
 void

File Added: pkgsrc/graphics/kipi-plugins/patches/Attic/patch-ac
$NetBSD: patch-ac,v 1.7 2009/02/15 14:41:40 wiz Exp $

--- kipi-plugins/configure.in.in.orig	2008-12-13 11:20:05.000000000 +0000
+++ kipi-plugins/configure.in.in
@@ -234,7 +234,7 @@ KIPI_PLUGIN_PRE([gpssync], [GPS Synchron
 KIPI_PLUGIN_PRE([htmlexport], [HTML Gallery], [xslt])
 #KIPI_PLUGIN_PRE([imagesgallery], [Images Gallery])      # ???
 KIPI_PLUGIN_PRE([imageviewer], [Viewer], [opengl])
-KIPI_PLUGIN_PRE([ipodexport], [iPod Export], [libgpod])
+KIPI_PLUGIN_PRE([ipodexport], [iPod Export], [libgpod] [gdk])
 KIPI_PLUGIN_PRE([jpeglossless], [JPEG Lossless]) # Does it depend on tiff?
 KIPI_PLUGIN_PRE([kameraklient], [Kamera Klient], [gphoto])
 KIPI_PLUGIN_PRE([metadataedit], [Metadata Editor])
@@ -329,7 +329,7 @@ have_libgpod=no
 if test "x$build_libgpod" != "xno"; then
     if test "$PKGCONFIGFOUND" = "yes" ; then
 
-        KDE_PKG_CHECK_MODULES(LIBGPOD, libgpod-1.0 >= 0.4.2 gobject-2.0, have_libgpod=yes,have_libgpod=no)
+        KDE_PKG_CHECK_MODULES(LIBGPOD, libgpod-1.0 >= 0.7.0 gobject-2.0, have_libgpod=yes,have_libgpod=no)
 
         if test "x$have_libgpod" = "xyes"; then
             AC_DEFINE(HAVE_LIBGPOD, 1, [have libgpod])
@@ -348,6 +348,35 @@ fi
 
 #------------------------------------------------------------------
 #
+# Check for GDK - ipod export plugin
+#
+#------------------------------------------------------------------
+
+have_gdk=no
+
+if test "x$build_libgpod" != "xno"; then
+    if test "$PKGCONFIGFOUND" = "yes" ; then
+
+        KDE_PKG_CHECK_MODULES(GDK, gdk-2.0 >= 2.10.0, have_gdk=yes,have_gdk=no)
+
+        if test "x$have_gdk" = "xyes"; then
+            AC_DEFINE(HAVE_GDK, 1, [have gdk])
+            ac_cppflags_save=$CPPFLAGS
+            ac_cflags_save=$CFLAGS
+            ac_ldflags_save=$LDFLAGS
+
+            CPPFLAGS="$CPPFLAGS $GDK_INCLUDES"
+            CFLAGS="$CFLAGS $GDK_CFLAGS"
+            LDFLAGS="$LDFLAGS $GDK_LIBS"
+        else
+            AC_MSG_WARN([GDK is required for the iPod export plugin.])
+        fi
+
+    fi
+fi
+
+#------------------------------------------------------------------
+#
 # Check for libkcal - iCalendar support library
 #
 #------------------------------------------------------------------