Tue Feb 16 10:06:55 2010 UTC ()
+ complain if LICENSE definition is missing


(wiz)
diff -r1.71 -r1.72 pkgsrc/pkgtools/pkglint/TODO
cvs diff -r1.71 -r1.72 pkgsrc/pkgtools/pkglint/Attic/TODO (expand / switch to unified diff)

--- pkgsrc/pkgtools/pkglint/Attic/TODO 2009/10/21 20:08:01 1.71
+++ pkgsrc/pkgtools/pkglint/Attic/TODO 2010/02/16 10:06:55 1.72
@@ -1,14 +1,14 @@ @@ -1,14 +1,14 @@
1$NetBSD: TODO,v 1.71 2009/10/21 20:08:01 tnn Exp $ 1$NetBSD: TODO,v 1.72 2010/02/16 10:06:55 wiz Exp $
2 2
3Please add your own entries at the bottom of this file. If possible, 3Please add your own entries at the bottom of this file. If possible,
4include the name of an example package where a warning should occur. 4include the name of an example package where a warning should occur.
5 5
6* fix false positive warnings 6* fix false positive warnings
7* warn about the use of ${WRKDIR:=...}, as this construct should only 7* warn about the use of ${WRKDIR:=...}, as this construct should only
8 be used with lists. 8 be used with lists.
9* record with each substring its source location to be able to make 9* record with each substring its source location to be able to make
10 even more precise diagnostics 10 even more precise diagnostics
11* Many of the checking routines need some context to provide better 11* Many of the checking routines need some context to provide better
12 warnings. For example, checkline_foo() may need to know what has 12 warnings. For example, checkline_foo() may need to know what has
13 happened in the file before that line. 13 happened in the file before that line.
14* Add checks for binary packages. See Debian/lintian for ideas. 14* Add checks for binary packages. See Debian/lintian for ideas.
@@ -24,26 +24,27 @@ include the name of an example package w @@ -24,26 +24,27 @@ include the name of an example package w
24 problem ==> use of ${APPEND_ELF} 24 problem ==> use of ${APPEND_ELF}
25* Packages including lang/python/extension.mk must follow the Python version 25* Packages including lang/python/extension.mk must follow the Python version
26 scheme. Enforcing PYPKGPREFIX for those is most likely a good idea. 26 scheme. Enforcing PYPKGPREFIX for those is most likely a good idea.
27* Check for parallel files/dirs whose names differ only in case. 27* Check for parallel files/dirs whose names differ only in case.
28* Check for license files that are completely unused. 28* Check for license files that are completely unused.
29* If a dependency depends on an option (in options.mk), it should also 29* If a dependency depends on an option (in options.mk), it should also
30 depend on the same option in the buildlink3.mk file. 30 depend on the same option in the buildlink3.mk file.
31* Complain about ${PKGSRC_COMPILER} == "sunpro", which should be 31* Complain about ${PKGSRC_COMPILER} == "sunpro", which should be
32 !empty(PKGSRC_COMPILER:Msunpro). 32 !empty(PKGSRC_COMPILER:Msunpro).
33* If USE_TOOLS has autoconf213, and the package does stuff like 33* If USE_TOOLS has autoconf213, and the package does stuff like
34 cd ${WRKSRC} && autoconf, then an incorrect warning is issued. 34 cd ${WRKSRC} && autoconf, then an incorrect warning is issued.
35* LOCALBASE should not be used in normal Makefiles 35* LOCALBASE should not be used in normal Makefiles
36* parse LICENSE expressions (make help topic=license) 36* parse LICENSE expressions (make help topic=license)
 37* complain if LICENSE definition is missing
37 38
38% 39%
39 40
40mail/mail-notification failed for Thomas, apparently because of an 41mail/mail-notification failed for Thomas, apparently because of an
41unexpressed dependency on hicolor-icon-theme. I don't know if it's 42unexpressed dependency on hicolor-icon-theme. I don't know if it's
42possible to add a way to notice that the PLIST contains hicolor files 43possible to add a way to notice that the PLIST contains hicolor files
43but that there's no dependency, or perhaps a list of mappings of sets of 44but that there's no dependency, or perhaps a list of mappings of sets of
44PLIST regexes to sets of required packages, or something. 45PLIST regexes to sets of required packages, or something.
45 46
46% 47%
47 48
48* don't complain about "procedure calls", like for pkg-build-options in 49* don't complain about "procedure calls", like for pkg-build-options in
49 the various buildlink3.mk files. 50 the various buildlink3.mk files.