pkgtools/gnome-packagekit: Stop detecting deprecation I originally was trying to patch set-but-not-used errors but then quickly found out that a new glib also introduced numerous breakages due to -Werror breaking on g_thread_init deprecation. Between the two problems I had already generated 10 patches with no end in site. Rather than continue, address the real issue and remove -Werror from this old package.

(marino)

 @@ -1,12 +1,15 @@
-$NetBSD: distinfo,v 1.4 2012/05/29 12:18:57 obache Exp $
+$NetBSD: distinfo,v 1.5 2012/12/15 09:36:21 marino Exp $
 SHA1 (gnome-packagekit-0.4.0.tar.gz) = 8a204535c4a219b8987af756db999ec4f3caa84e
 RMD160 (gnome-packagekit-0.4.0.tar.gz) = 9c1de792b00749ea54fe44d7287cf55228df4bdf
 Size (gnome-packagekit-0.4.0.tar.gz) = 2732798 bytes
 SHA1 (patch-aa) = e9b6d7a9d8034aad4e418b7c1e6cfe753e560c0a
 SHA1 (patch-ab) = 88522542563043b06358e98fa323eb94b9e34679
 SHA1 (patch-ac) = fb0b16340091eeede5b608645b5aa43a4ab50a9f
 SHA1 (patch-aclocal.m4) = 373799ca82cc0ed53c2fc320ed375162dd417ce8
 SHA1 (patch-ad) = db285ef99ef8822f6417522a908ef976304d18c2
 SHA1 (patch-ae) = 88fd8a4f3a739af9ce06b3ca60a95a7a6ccc1c83
 SHA1 (patch-configure) = 0b9e3b098ae84e559fdf74ce5c4945f8211a641d
 SHA1 (patch-configure.ac) = eb7de6a0a607803cfcf6dd7dcfaf86ad8b62a951
 SHA1 (patch-src_gpk-application.c) = 32ec24b11a222a8b77feff38373438779d46a288
 SHA1 (patch-src_gpk-update-viewer.c) = 20365e1f3101038b9864eda6dd5b1c0a66191bd1

$NetBSD: patch-aclocal.m4,v 1.1 2012/12/15 09:36:21 marino Exp $ * Disable -Werror for these reasons - Numerous g_thread_init deprecated errors - Numerous set-but-not-used error (gcc 4.6+) --- aclocal.m4.orig 2008-12-09 08:25:48.000000000 +0000 +++ aclocal.m4 @@ -546,9 +546,6 @@ AC_DEFUN([GNOME_COMPILE_WARNINGS],[ unset SAVE_CFLAGS done unset option - if test "$enable_compile_warnings" = "error" ; then - warning_flags="$warning_flags -Werror" - fi ;; *) AC_MSG_ERROR(Unknown argument '$enable_compile_warnings' to --enable-compile-warnings)

$NetBSD: patch-configure,v 1.1 2012/12/15 09:36:21 marino Exp $ * Disable -Werror for these reasons - Numerous g_thread_init deprecated errors - Numerous set-but-not-used error (gcc 4.6+) --- configure.orig 2008-12-09 08:25:54.000000000 +0000 +++ configure @@ -21043,9 +21043,6 @@ $as_echo "$has_option" >&6; } unset SAVE_CFLAGS done unset option - if test "$enable_compile_warnings" = "error" ; then - warning_flags="$warning_flags -Werror" - fi ;; *) { { $as_echo "$as_me:$LINENO: error: Unknown argument '$enable_compile_warnings' to --enable-compile-warnings" >&5 @@ -21574,7 +21571,7 @@ fi if test "$GCC" = "yes"; then - CPPFLAGS="$CPPFLAGS -Werror -Wcast-align -Wno-uninitialized" + CPPFLAGS="$CPPFLAGS -Wcast-align -Wno-uninitialized" CPPFLAGS="$CPPFLAGS -Wall -Wformat-security" # CPPFLAGS="$CPPFLAGS -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES" CPPFLAGS="$CPPFLAGS -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED"

$NetBSD: patch-configure.ac,v 1.1 2012/12/15 09:36:21 marino Exp $ * Disable -Werror for these reasons - Numerous g_thread_init deprecated errors - Numerous set-but-not-used error (gcc 4.6+) --- configure.ac.orig 2008-12-09 08:22:40.000000000 +0000 +++ configure.ac @@ -27,7 +27,7 @@ dnl ------------------------------------ dnl - Extra verbose warning switches dnl --------------------------------------------------------------------------- if test "$GCC" = "yes"; then - CPPFLAGS="$CPPFLAGS -Werror -Wcast-align -Wno-uninitialized" + CPPFLAGS="$CPPFLAGS -Wcast-align -Wno-uninitialized" CPPFLAGS="$CPPFLAGS -Wall -Wformat-security" # CPPFLAGS="$CPPFLAGS -DG_DISABLE_SINGLE_INCLUDES -DGTK_DISABLE_SINGLE_INCLUDES" CPPFLAGS="$CPPFLAGS -DG_DISABLE_DEPRECATED -DGTK_DISABLE_DEPRECATED -DGDK_DISABLE_DEPRECATED"