Mon Sep 2 10:28:44 2013 UTC ()

pkg_install-20130902: Fix 'pkg_add -f'.

Remove incorrect return value when in force mode, which was causing pkg_add
to exit with failure even though the operation completed successfully.  This
also fixes the case where 'pkg_add -uf' would leave an update in an
inconsistent state.


(jperkin)

diff -r1.197 -r1.198 pkgsrc/pkgtools/pkg_install/Makefile
diff -r1.104 -r1.105 pkgsrc/pkgtools/pkg_install/files/add/perform.c
diff -r1.165 -r1.166 pkgsrc/pkgtools/pkg_install/files/lib/version.h

--- pkgsrc/pkgtools/pkg_install/Makefile 2013/06/05 18:20:55 1.197
+++ pkgsrc/pkgtools/pkg_install/Makefile 2013/09/02 10:28:44 1.198

@@ -1,4 +1,4 @@
-# $NetBSD: Makefile,v 1.197 2013/06/05 18:20:55 riastradh Exp $
+# $NetBSD: Makefile,v 1.198 2013/09/02 10:28:44 jperkin Exp $
 
 # Notes to package maintainers:
 #
@@ -7,7 +7,6 @@
 # change in the pkg_* tools that pkgsrc relies on for proper operation.
 
 DISTNAME=		pkg_install-${VERSION}
-PKGREVISION=		1
 CATEGORIES=		pkgtools
 MASTER_SITES=		# empty
 DISTFILES=		# empty

--- pkgsrc/pkgtools/pkg_install/files/add/perform.c 2013/08/21 11:46:02 1.104
+++ pkgsrc/pkgtools/pkg_install/files/add/perform.c 2013/09/02 10:28:44 1.105

@@ -1,4 +1,4 @@
-/*	$NetBSD: perform.c,v 1.104 2013/08/21 11:46:02 jperkin Exp $	*/
+/*	$NetBSD: perform.c,v 1.105 2013/09/02 10:28:44 jperkin Exp $	*/
 #if HAVE_CONFIG_H
 #include "config.h"
 #endif
@@ -6,7 +6,7 @@
 #if HAVE_SYS_CDEFS_H
 #include <sys/cdefs.h>
 #endif
-__RCSID("$NetBSD: perform.c,v 1.104 2013/08/21 11:46:02 jperkin Exp $");
+__RCSID("$NetBSD: perform.c,v 1.105 2013/09/02 10:28:44 jperkin Exp $");
 
 /*-
  * Copyright (c) 2003 Grant Beattie <grant@NetBSD.org>
@@ -412,9 +412,6 @@
 		}
 		return 1;
 	}
-
-	if (Force)
-		return 1;
 
 	/* We can only arrive here for explicitly requested packages. */
 	if (!Automatic && is_automatic_installed(pkg->pkgname)) {

--- pkgsrc/pkgtools/pkg_install/files/lib/version.h 2013/01/31 10:25:30 1.165
+++ pkgsrc/pkgtools/pkg_install/files/lib/version.h 2013/09/02 10:28:44 1.166

@@ -1,4 +1,4 @@
-/*	$NetBSD: version.h,v 1.165 2013/01/31 10:25:30 wiz Exp $	*/
+/*	$NetBSD: version.h,v 1.166 2013/09/02 10:28:44 jperkin Exp $	*/
 
 /*
  * Copyright (c) 2001 Thomas Klausner.  All rights reserved.
@@ -27,6 +27,6 @@
 #ifndef _INST_LIB_VERSION_H_
 #define _INST_LIB_VERSION_H_
 
-#define PKGTOOLS_VERSION 20130131
+#define PKGTOOLS_VERSION 20130902
 
 #endif /* _INST_LIB_VERSION_H_ */