| @@ -1,15 +1,15 @@ | | | @@ -1,15 +1,15 @@ |
| 1 | #! @PERL@ | | 1 | #! @PERL@ |
| 2 | # $NetBSD: pkglint.pl,v 1.865 2014/03/02 09:41:31 obache Exp $ | | 2 | # $NetBSD: pkglint.pl,v 1.866 2014/03/03 05:18:23 obache Exp $ |
| 3 | # | | 3 | # |
| 4 | | | 4 | |
| 5 | # pkglint - static analyzer and checker for pkgsrc packages | | 5 | # pkglint - static analyzer and checker for pkgsrc packages |
| 6 | # | | 6 | # |
| 7 | # Written by: | | 7 | # Written by: |
| 8 | # Roland Illig <rillig@NetBSD.org> | | 8 | # Roland Illig <rillig@NetBSD.org> |
| 9 | # | | 9 | # |
| 10 | # Based on work by: | | 10 | # Based on work by: |
| 11 | # Hubert Feyrer <hubertf@NetBSD.org> | | 11 | # Hubert Feyrer <hubertf@NetBSD.org> |
| 12 | # Thorsten Frueauf <frueauf@NetBSD.org> | | 12 | # Thorsten Frueauf <frueauf@NetBSD.org> |
| 13 | # Thomas Klausner <wiz@NetBSD.org> | | 13 | # Thomas Klausner <wiz@NetBSD.org> |
| 14 | # and others. | | 14 | # and others. |
| 15 | # | | 15 | # |
| @@ -4281,27 +4281,27 @@ sub checkline_mk_vartype_basic($$$$$$$$) | | | @@ -4281,27 +4281,27 @@ sub checkline_mk_vartype_basic($$$$$$$$) |
| 4281 | "Usually, different packages using the same Makefile.common have", | | 4281 | "Usually, different packages using the same Makefile.common have", |
| 4282 | "different dependencies and will be bumped at different times (e.g. for", | | 4282 | "different dependencies and will be bumped at different times (e.g. for", |
| 4283 | "shlib major bumps) and thus the PKGREVISIONs must be in the separate", | | 4283 | "shlib major bumps) and thus the PKGREVISIONs must be in the separate", |
| 4284 | "Makefiles. There is no practical way of having this information in a", | | 4284 | "Makefiles. There is no practical way of having this information in a", |
| 4285 | "commonly used Makefile."); | | 4285 | "commonly used Makefile."); |
| 4286 | } | | 4286 | } |
| 4287 | }, | | 4287 | }, |
| 4288 | | | 4288 | |
| 4289 | PlatformTriple => sub { | | 4289 | PlatformTriple => sub { |
| 4290 | my $part = qr"(?:\[[^\]]+\]|[^-\[])+"; | | 4290 | my $part = qr"(?:\[[^\]]+\]|[^-\[])+"; |
| 4291 | if ($value =~ m"^(${part})-(${part})-(${part})$") { | | 4291 | if ($value =~ m"^(${part})-(${part})-(${part})$") { |
| 4292 | my ($opsys, $os_version, $arch) = ($1, $2, $3); | | 4292 | my ($opsys, $os_version, $arch) = ($1, $2, $3); |
| 4293 | | | 4293 | |
| 4294 | if ($opsys !~ m"^(?:\*|BSDOS|Cygwin|Darwin|DragonFly|FreeBSD|Haiku|HPUX|Interix|IRIX|Linux|NetBSD|OpenBSD|OSF1|SunOS)$") { | | 4294 | if ($opsys !~ m"^(?:\*|BSDOS|Cygwin|Darwin|DragonFly|FreeBSD|Haiku|HPUX|Interix|IRIX|Linux|NetBSD|OpenBSD|OSF1|QNX|SunOS)$") { |
| 4295 | $line->log_warning("Unknown operating system: ${opsys}"); | | 4295 | $line->log_warning("Unknown operating system: ${opsys}"); |
| 4296 | } | | 4296 | } |
| 4297 | # no check for $os_version | | 4297 | # no check for $os_version |
| 4298 | if ($arch !~ m"^(?:\*|i386|alpha|amd64|arc|arm|arm32|cobalt|convex|dreamcast|hpcmips|hpcsh|hppa|ia64|m68k|m88k|mips|mips64|mipsel|mipseb|mipsn32|ns32k|pc532|pmax|powerpc|rs6000|s390|sparc|sparc64|vax|x86_64)$") { | | 4298 | if ($arch !~ m"^(?:\*|i386|alpha|amd64|arc|arm|arm32|cobalt|convex|dreamcast|hpcmips|hpcsh|hppa|ia64|m68k|m88k|mips|mips64|mipsel|mipseb|mipsn32|ns32k|pc532|pmax|powerpc|rs6000|s390|sparc|sparc64|vax|x86_64)$") { |
| 4299 | $line->log_warning("Unknown hardware architecture: ${arch}"); | | 4299 | $line->log_warning("Unknown hardware architecture: ${arch}"); |
| 4300 | } | | 4300 | } |
| 4301 | | | 4301 | |
| 4302 | } else { | | 4302 | } else { |
| 4303 | $line->log_warning("\"${value}\" is not a valid platform triple."); | | 4303 | $line->log_warning("\"${value}\" is not a valid platform triple."); |
| 4304 | $line->explain_warning( | | 4304 | $line->explain_warning( |
| 4305 | "A platform triple has the form <OPSYS>-<OS_VERSION>-<MACHINE_ARCH>.", | | 4305 | "A platform triple has the form <OPSYS>-<OS_VERSION>-<MACHINE_ARCH>.", |
| 4306 | "Each of these components may be a shell globbing expression.", | | 4306 | "Each of these components may be a shell globbing expression.", |
| 4307 | "Examples: NetBSD-*-i386, *-*-*, Linux-*-*."); | | 4307 | "Examples: NetBSD-*-i386, *-*-*, Linux-*-*."); |