Sun Jul 27 20:45:10 2014 UTC ()
Properly handle the alt key in terminals.
Patch from: https://bugzilla.gnome.org/show_bug.cgi?id=663779
Fixes PR pkg/48806
(ahoka)
diff -r1.101 -r1.102 pkgsrc/x11/vte/Makefile
diff -r1.51 -r1.52 pkgsrc/x11/vte/distinfo
diff -r0 -r1.1 pkgsrc/x11/vte/patches/patch-altmeta
diff -r1.13 -r1.14 pkgsrc/x11/vte029/Makefile
diff -r1.2 -r1.3 pkgsrc/x11/vte029/distinfo
diff -r0 -r1.1 pkgsrc/x11/vte029/patches/patch-altmeta
--- pkgsrc/x11/vte/Makefile 2014/05/05 00:48:33 1.101
+++ pkgsrc/x11/vte/Makefile 2014/07/27 20:45:10 1.102
| @@ -1,19 +1,19 @@ | | | @@ -1,19 +1,19 @@ |
1 | # $NetBSD: Makefile,v 1.101 2014/05/05 00:48:33 ryoon Exp $ | | 1 | # $NetBSD: Makefile,v 1.102 2014/07/27 20:45:10 ahoka Exp $ |
2 | # | | 2 | # |
3 | | | 3 | |
4 | .include "Makefile.common" | | 4 | .include "Makefile.common" |
5 | | | 5 | |
6 | PKGREVISION= 14 | | 6 | PKGREVISION= 15 |
7 | CATEGORIES= x11 | | 7 | CATEGORIES= x11 |
8 | | | 8 | |
9 | MAINTAINER= pkgsrc-users@NetBSD.org | | 9 | MAINTAINER= pkgsrc-users@NetBSD.org |
10 | HOMEPAGE= http://www.gnome.org/ | | 10 | HOMEPAGE= http://www.gnome.org/ |
11 | COMMENT= Terminal widget with improved accessibility and I18N support | | 11 | COMMENT= Terminal widget with improved accessibility and I18N support |
12 | LICENSE= gnu-lgpl-v2 | | 12 | LICENSE= gnu-lgpl-v2 |
13 | | | 13 | |
14 | USE_PKGLOCALEDIR= yes | | 14 | USE_PKGLOCALEDIR= yes |
15 | USE_LIBTOOL= yes | | 15 | USE_LIBTOOL= yes |
16 | GNU_CONFIGURE= yes | | 16 | GNU_CONFIGURE= yes |
17 | USE_TOOLS+= gmake intltool msgfmt pkg-config | | 17 | USE_TOOLS+= gmake intltool msgfmt pkg-config |
18 | | | 18 | |
19 | CONFIGURE_ARGS+= --disable-python | | 19 | CONFIGURE_ARGS+= --disable-python |
--- pkgsrc/x11/vte/distinfo 2013/12/16 19:51:14 1.51
+++ pkgsrc/x11/vte/distinfo 2014/07/27 20:45:10 1.52
| @@ -1,11 +1,12 @@ | | | @@ -1,11 +1,12 @@ |
1 | $NetBSD: distinfo,v 1.51 2013/12/16 19:51:14 asau Exp $ | | 1 | $NetBSD: distinfo,v 1.52 2014/07/27 20:45:10 ahoka Exp $ |
2 | | | 2 | |
3 | SHA1 (vte-0.28.1.tar.bz2) = 9867f84c6be65ff485d8a1a3c41a359709b6f84c | | 3 | SHA1 (vte-0.28.1.tar.bz2) = 9867f84c6be65ff485d8a1a3c41a359709b6f84c |
4 | RMD160 (vte-0.28.1.tar.bz2) = e0748777f5a57266762b3dd88f7a10b143e412d9 | | 4 | RMD160 (vte-0.28.1.tar.bz2) = e0748777f5a57266762b3dd88f7a10b143e412d9 |
5 | Size (vte-0.28.1.tar.bz2) = 1341147 bytes | | 5 | Size (vte-0.28.1.tar.bz2) = 1341147 bytes |
6 | SHA1 (patch-aa) = 6b722ecbbd9face7152feca39f1d323870d2a69a | | 6 | SHA1 (patch-aa) = 6b722ecbbd9face7152feca39f1d323870d2a69a |
7 | SHA1 (patch-ab) = 217a8722d09b1854e869c49af69731ffed92f61c | | 7 | SHA1 (patch-ab) = 217a8722d09b1854e869c49af69731ffed92f61c |
8 | SHA1 (patch-ac) = 3b357bf9d1bca93c24f5b09dae1adec82323be0d | | 8 | SHA1 (patch-ac) = 3b357bf9d1bca93c24f5b09dae1adec82323be0d |
9 | SHA1 (patch-af) = 69ea7e022f6c495c3c9af681d05644b9d70e7bdc | | 9 | SHA1 (patch-af) = 69ea7e022f6c495c3c9af681d05644b9d70e7bdc |
10 | SHA1 (patch-ah) = 28cee2661439d7d6f1959ebf3c7d1b7b3fe0a764 | | 10 | SHA1 (patch-ah) = 28cee2661439d7d6f1959ebf3c7d1b7b3fe0a764 |
11 | SHA1 (patch-ai) = 4c365d1d05faa2d9bd0f8f21d500a72605f092d9 | | 11 | SHA1 (patch-ai) = 4c365d1d05faa2d9bd0f8f21d500a72605f092d9 |
| | | 12 | SHA1 (patch-altmeta) = 2ff444350c473630a9040c2747859ba7a3a7e30b |
From 180dcc578e13c6096e277fb853e7162db640f207 Mon Sep 17 00:00:00 2001
From: Alexandre Rostovtsev <tetromino@gentoo.org>
Date: Tue, 15 Nov 2011 03:06:40 -0500
Subject: [PATCH] Map both gdk's Meta and Alt to vte's Meta for >=gtk+-3.2.2
compatibility
Also, since VTE_META_MASK is now a mask with multiple bits set, code that
compares gdk key modifiers to VTE_META_MASK by numerical equality is no
longer guaranteed to work. Therefore, for such comparisons a new function,
vte_keymap_fixup_modifiers, is introduced; it ensures that if any bits
matching matching VTE_META_MASK are set, then all are set.
https://bugzilla.gnome.org/show_bug.cgi?id=663779
---
src/keymap.c | 15 +++++++++++++--
src/keymap.h | 2 +-
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/src/keymap.c b/src/keymap.c
index 9a21669..95b4c5b 100644
--- src/keymap.c
+++ src/keymap.c
@@ -990,6 +990,17 @@ static const struct _vte_keymap_group {
{GDK_KEY (F35), _vte_keymap_GDK_F35},
};
+/* Restrict modifiers to the specified mask and ensure that VTE_META_MASK,
+ * despite being a compound mask, is treated as indivisible. */
+GdkModifierType
+_vte_keymap_fixup_modifiers(GdkModifierType modifiers,
+ GdkModifierType mask)
+{
+ if (modifiers & VTE_META_MASK)
+ modifiers |= VTE_META_MASK;
+ return modifiers & mask;
+}
+
/* Map the specified keyval/modifier setup, dependent on the mode, to either
* a literal string or a capability name. */
void
@@ -1104,7 +1115,7 @@ _vte_keymap_map(guint keyval,
} else {
fkey_mode = fkey_default;
}
- modifiers &= (GDK_SHIFT_MASK | GDK_CONTROL_MASK | VTE_META_MASK | VTE_NUMLOCK_MASK);
+ modifiers = _vte_keymap_fixup_modifiers(modifiers, GDK_SHIFT_MASK | GDK_CONTROL_MASK | VTE_META_MASK | VTE_NUMLOCK_MASK);
/* Search for the conditions. */
for (i = 0; entries[i].normal_length || entries[i].special[0]; i++)
@@ -1375,7 +1386,7 @@ _vte_keymap_key_add_key_modifiers(guint keyval,
return;
}
- switch (modifiers & significant_modifiers) {
+ switch (_vte_keymap_fixup_modifiers(modifiers, significant_modifiers)) {
case 0:
modifier = 0;
break;
diff --git a/src/keymap.h b/src/keymap.h
index 243e22e..21d9b8e 100644
--- src/keymap.h
+++ src/keymap.h
@@ -27,7 +27,7 @@
G_BEGIN_DECLS
-#define VTE_META_MASK GDK_META_MASK
+#define VTE_META_MASK (GDK_META_MASK | GDK_MOD1_MASK)
#define VTE_NUMLOCK_MASK GDK_MOD2_MASK
/* Map the specified keyval/modifier setup, dependent on the mode, to either
--
1.7.8.rc3
--- pkgsrc/x11/vte029/Makefile 2014/05/05 00:48:33 1.13
+++ pkgsrc/x11/vte029/Makefile 2014/07/27 20:45:10 1.14
| @@ -1,19 +1,19 @@ | | | @@ -1,19 +1,19 @@ |
1 | # $NetBSD: Makefile,v 1.13 2014/05/05 00:48:33 ryoon Exp $ | | 1 | # $NetBSD: Makefile,v 1.14 2014/07/27 20:45:10 ahoka Exp $ |
2 | # | | 2 | # |
3 | | | 3 | |
4 | .include "Makefile.common" | | 4 | .include "Makefile.common" |
5 | | | 5 | |
6 | PKGREVISION= 11 | | 6 | PKGREVISION= 12 |
7 | CATEGORIES= x11 | | 7 | CATEGORIES= x11 |
8 | | | 8 | |
9 | MAINTAINER= pkgsrc-users@NetBSD.org | | 9 | MAINTAINER= pkgsrc-users@NetBSD.org |
10 | HOMEPAGE= http://www.gnome.org/ | | 10 | HOMEPAGE= http://www.gnome.org/ |
11 | COMMENT= Terminal widget with improved accessibility and I18N support | | 11 | COMMENT= Terminal widget with improved accessibility and I18N support |
12 | LICENSE= gnu-lgpl-v2 | | 12 | LICENSE= gnu-lgpl-v2 |
13 | | | 13 | |
14 | USE_PKGLOCALEDIR= yes | | 14 | USE_PKGLOCALEDIR= yes |
15 | USE_LIBTOOL= yes | | 15 | USE_LIBTOOL= yes |
16 | GNU_CONFIGURE= yes | | 16 | GNU_CONFIGURE= yes |
17 | USE_TOOLS+= automake gmake intltool msgfmt pkg-config | | 17 | USE_TOOLS+= automake gmake intltool msgfmt pkg-config |
18 | | | 18 | |
19 | CONFIGURE_ARGS+= --disable-python | | 19 | CONFIGURE_ARGS+= --disable-python |
--- pkgsrc/x11/vte029/distinfo 2013/01/26 22:25:00 1.2
+++ pkgsrc/x11/vte029/distinfo 2014/07/27 20:45:10 1.3
| @@ -1,14 +1,15 @@ | | | @@ -1,14 +1,15 @@ |
1 | $NetBSD: distinfo,v 1.2 2013/01/26 22:25:00 wiz Exp $ | | 1 | $NetBSD: distinfo,v 1.3 2014/07/27 20:45:10 ahoka Exp $ |
2 | | | 2 | |
3 | SHA1 (vte-0.32.2.tar.xz) = a58569a99ac06a240bdda3ec7353f2626145852d | | 3 | SHA1 (vte-0.32.2.tar.xz) = a58569a99ac06a240bdda3ec7353f2626145852d |
4 | RMD160 (vte-0.32.2.tar.xz) = 4892fca462a0baf3c97564a9d8cead7b35f75d4c | | 4 | RMD160 (vte-0.32.2.tar.xz) = 4892fca462a0baf3c97564a9d8cead7b35f75d4c |
5 | Size (vte-0.32.2.tar.xz) = 978692 bytes | | 5 | Size (vte-0.32.2.tar.xz) = 978692 bytes |
6 | SHA1 (patch-aa) = 6b722ecbbd9face7152feca39f1d323870d2a69a | | 6 | SHA1 (patch-aa) = 6b722ecbbd9face7152feca39f1d323870d2a69a |
7 | SHA1 (patch-ab) = 217a8722d09b1854e869c49af69731ffed92f61c | | 7 | SHA1 (patch-ab) = 217a8722d09b1854e869c49af69731ffed92f61c |
8 | SHA1 (patch-ac) = 3b357bf9d1bca93c24f5b09dae1adec82323be0d | | 8 | SHA1 (patch-ac) = 3b357bf9d1bca93c24f5b09dae1adec82323be0d |
9 | SHA1 (patch-af) = 69ea7e022f6c495c3c9af681d05644b9d70e7bdc | | 9 | SHA1 (patch-af) = 69ea7e022f6c495c3c9af681d05644b9d70e7bdc |
10 | SHA1 (patch-ah) = 28cee2661439d7d6f1959ebf3c7d1b7b3fe0a764 | | 10 | SHA1 (patch-ah) = 28cee2661439d7d6f1959ebf3c7d1b7b3fe0a764 |
11 | SHA1 (patch-ai) = 986dd7c2a5778c9c35100901cfaa25acd0cbdc32 | | 11 | SHA1 (patch-ai) = 986dd7c2a5778c9c35100901cfaa25acd0cbdc32 |
| | | 12 | SHA1 (patch-altmeta) = 2ff444350c473630a9040c2747859ba7a3a7e30b |
12 | SHA1 (patch-configure.in) = 569e21e10900d4e1737836ea2e5c5f22cb8b3025 | | 13 | SHA1 (patch-configure.in) = 569e21e10900d4e1737836ea2e5c5f22cb8b3025 |
13 | SHA1 (patch-gnome-pty-helper_Makefile.am) = d1964c774d192290eade04d7dee88b90ec05d59e | | 14 | SHA1 (patch-gnome-pty-helper_Makefile.am) = d1964c774d192290eade04d7dee88b90ec05d59e |
14 | SHA1 (patch-gnome-pty-helper_configure.in) = 05fa680d29587405d9ea7b3be75b85a467200d89 | | 15 | SHA1 (patch-gnome-pty-helper_configure.in) = 05fa680d29587405d9ea7b3be75b85a467200d89 |
From 180dcc578e13c6096e277fb853e7162db640f207 Mon Sep 17 00:00:00 2001
From: Alexandre Rostovtsev <tetromino@gentoo.org>
Date: Tue, 15 Nov 2011 03:06:40 -0500
Subject: [PATCH] Map both gdk's Meta and Alt to vte's Meta for >=gtk+-3.2.2
compatibility
Also, since VTE_META_MASK is now a mask with multiple bits set, code that
compares gdk key modifiers to VTE_META_MASK by numerical equality is no
longer guaranteed to work. Therefore, for such comparisons a new function,
vte_keymap_fixup_modifiers, is introduced; it ensures that if any bits
matching matching VTE_META_MASK are set, then all are set.
https://bugzilla.gnome.org/show_bug.cgi?id=663779
---
src/keymap.c | 15 +++++++++++++--
src/keymap.h | 2 +-
2 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/src/keymap.c b/src/keymap.c
index 9a21669..95b4c5b 100644
--- src/keymap.c
+++ src/keymap.c
@@ -990,6 +990,17 @@ static const struct _vte_keymap_group {
{GDK_KEY (F35), _vte_keymap_GDK_F35},
};
+/* Restrict modifiers to the specified mask and ensure that VTE_META_MASK,
+ * despite being a compound mask, is treated as indivisible. */
+GdkModifierType
+_vte_keymap_fixup_modifiers(GdkModifierType modifiers,
+ GdkModifierType mask)
+{
+ if (modifiers & VTE_META_MASK)
+ modifiers |= VTE_META_MASK;
+ return modifiers & mask;
+}
+
/* Map the specified keyval/modifier setup, dependent on the mode, to either
* a literal string or a capability name. */
void
@@ -1104,7 +1115,7 @@ _vte_keymap_map(guint keyval,
} else {
fkey_mode = fkey_default;
}
- modifiers &= (GDK_SHIFT_MASK | GDK_CONTROL_MASK | VTE_META_MASK | VTE_NUMLOCK_MASK);
+ modifiers = _vte_keymap_fixup_modifiers(modifiers, GDK_SHIFT_MASK | GDK_CONTROL_MASK | VTE_META_MASK | VTE_NUMLOCK_MASK);
/* Search for the conditions. */
for (i = 0; entries[i].normal_length || entries[i].special[0]; i++)
@@ -1375,7 +1386,7 @@ _vte_keymap_key_add_key_modifiers(guint keyval,
return;
}
- switch (modifiers & significant_modifiers) {
+ switch (_vte_keymap_fixup_modifiers(modifiers, significant_modifiers)) {
case 0:
modifier = 0;
break;
diff --git a/src/keymap.h b/src/keymap.h
index 243e22e..21d9b8e 100644
--- src/keymap.h
+++ src/keymap.h
@@ -27,7 +27,7 @@
G_BEGIN_DECLS
-#define VTE_META_MASK GDK_META_MASK
+#define VTE_META_MASK (GDK_META_MASK | GDK_MOD1_MASK)
#define VTE_NUMLOCK_MASK GDK_MOD2_MASK
/* Map the specified keyval/modifier setup, dependent on the mode, to either
--
1.7.8.rc3