Mon Sep 8 08:44:54 2014 UTC ()
Add a comment explaining why we need to force --with-libiconv=gnu for
the ICONV_TYPE=gnu case.  Suggested by wiz.


(jperkin)
diff -r1.38 -r1.39 pkgsrc/devel/glib2/Makefile.common

cvs diff -r1.38 -r1.39 pkgsrc/devel/glib2/Makefile.common (expand / switch to context diff)
--- pkgsrc/devel/glib2/Makefile.common 2014/09/08 08:33:59 1.38
+++ pkgsrc/devel/glib2/Makefile.common 2014/09/08 08:44:54 1.39
@@ -1,4 +1,4 @@
-# $NetBSD: Makefile.common,v 1.38 2014/09/08 08:33:59 jperkin Exp $
+# $NetBSD: Makefile.common,v 1.39 2014/09/08 08:44:54 jperkin Exp $
 #
 # used by devel/glib2/Makefile
 # used by devel/gdbus-codegen/Makefile
@@ -40,6 +40,9 @@
 # Avoid unnecessary autotools invocation.
 CONFIGURE_ARGS+=	--disable-maintainer-mode
 
+# When ICONV_TYPE=gnu ensure we explicitly use the GNU version, to avoid
+# conflicts between iconv.h from converters/libiconv and builtin libiconv
+# which may be non-GNU.
 CONFIGURE_ARGS.gnu-iconv=	--with-libiconv=gnu
 
 CONFIGURE_ENV+=		PERL_PATH=${PERL5:Q}