Wed Oct 8 19:19:43 2014 UTC ()
Cleaned up the TODO list; the license check has been implemented.


(rillig)
diff -r1.78 -r1.79 pkgsrc/pkgtools/pkglint/TODO
cvs diff -r1.78 -r1.79 pkgsrc/pkgtools/pkglint/Attic/TODO (expand / switch to unified diff)

--- pkgsrc/pkgtools/pkglint/Attic/TODO 2013/10/12 18:09:59 1.78
+++ pkgsrc/pkgtools/pkglint/Attic/TODO 2014/10/08 19:19:43 1.79
@@ -1,14 +1,14 @@ @@ -1,14 +1,14 @@
1$NetBSD: TODO,v 1.78 2013/10/12 18:09:59 rillig Exp $ 1$NetBSD: TODO,v 1.79 2014/10/08 19:19:43 rillig Exp $
2 2
3Please add your own entries at the bottom of this file. If possible, 3Please add your own entries at the bottom of this file. If possible,
4include the name of an example package where a warning should occur. 4include the name of an example package where a warning should occur.
5 5
6* When you understand some behavior of the code, document it by 6* When you understand some behavior of the code, document it by
7 adding automated tests to pkglint.t! 7 adding automated tests to pkglint.t!
8* warn about the use of ${WRKDIR:=...}, as this construct should only 8* warn about the use of ${WRKDIR:=...}, as this construct should only
9 be used with lists. 9 be used with lists.
10* Add checks for binary packages. See Debian/lintian for ideas. 10* Add checks for binary packages. See Debian/lintian for ideas.
11* Of the user-defined variables, some may be used at load-time and some 11* Of the user-defined variables, some may be used at load-time and some
12 don't. Find out how pkglint can distinguish them. 12 don't. Find out how pkglint can distinguish them.
13* Make sure that no variable is modified at load-time after it has been 13* Make sure that no variable is modified at load-time after it has been
14 used once. This should at least flag BUILD_DEFS in bsd.pkg.mk. 14 used once. This should at least flag BUILD_DEFS in bsd.pkg.mk.
@@ -19,31 +19,21 @@ include the name of an example package w @@ -19,31 +19,21 @@ include the name of an example package w
19* ${MACHINE_ARCH}-${LOWER_OPSYS}elf in PLISTs etc. is a NetBSD config.guess 19* ${MACHINE_ARCH}-${LOWER_OPSYS}elf in PLISTs etc. is a NetBSD config.guess
20 problem ==> use of ${APPEND_ELF} 20 problem ==> use of ${APPEND_ELF}
21* Packages including lang/python/extension.mk must follow the Python version 21* Packages including lang/python/extension.mk must follow the Python version
22 scheme. Enforcing PYPKGPREFIX for those is most likely a good idea. 22 scheme. Enforcing PYPKGPREFIX for those is most likely a good idea.
23* Check for parallel files/dirs whose names differ only in case. 23* Check for parallel files/dirs whose names differ only in case.
24* Check for license files that are completely unused. 24* Check for license files that are completely unused.
25* If a dependency depends on an option (in options.mk), it should also 25* If a dependency depends on an option (in options.mk), it should also
26 depend on the same option in the buildlink3.mk file. 26 depend on the same option in the buildlink3.mk file.
27* Complain about ${PKGSRC_COMPILER} == "sunpro", which should be 27* Complain about ${PKGSRC_COMPILER} == "sunpro", which should be
28 !empty(PKGSRC_COMPILER:Msunpro). 28 !empty(PKGSRC_COMPILER:Msunpro).
29* If USE_TOOLS has autoconf213, and the package does stuff like 29* If USE_TOOLS has autoconf213, and the package does stuff like
30 cd ${WRKSRC} && autoconf, then an incorrect warning is issued. 30 cd ${WRKSRC} && autoconf, then an incorrect warning is issued.
31* LOCALBASE should not be used in normal Makefiles 31* LOCALBASE should not be used in normal Makefiles
32* complain if LICENSE definition is missing 
33* don't complain about "procedure calls", like for pkg-build-options in 32* don't complain about "procedure calls", like for pkg-build-options in
34 the various buildlink3.mk files. 33 the various buildlink3.mk files.
35 34* if package A conflicts with B, then B should also conflict with A.
36% 
37 
38if package A conflicts with B, then B should also conflict with A. 
39 
40% 
41 
42* When pkglint runs on a case-insensitive filesystem, it should still 35* When pkglint runs on a case-insensitive filesystem, it should still
43 point out problems that only occur on case-sensitive filesystems. For 36 point out problems that only occur on case-sensitive filesystems. For
44 example, devel/p5-Net-LDAP and devel/p5-Net-ldap should be considered 37 example, devel/p5-Net-LDAP and devel/p5-Net-ldap should be considered
45 different paths. 38 different paths.
46 
47% 
48 
49* Warn about using REPLACE_PYTHON without including application.mk. 39* Warn about using REPLACE_PYTHON without including application.mk.