Tue Mar 31 15:40:03 2015 UTC ()
Dereferencing va_list is not portable and broken when using a
non-pointer type.


(joerg)
diff -r1.5 -r1.6 pkgsrc/games/ufoai/distinfo
diff -r0 -r1.1 pkgsrc/games/ufoai/patches/patch-src_common_msg.c
diff -r0 -r1.1 pkgsrc/games/ufoai/patches/patch-src_common_netpack.c
cvs diff -r1.5 -r1.6 pkgsrc/games/ufoai/distinfo (expand / switch to unified diff)

--- pkgsrc/games/ufoai/distinfo 2011/04/05 11:32:46 1.5
+++ pkgsrc/games/ufoai/distinfo 2015/03/31 15:40:03 1.6
@@ -1,14 +1,16 @@ @@ -1,14 +1,16 @@
1$NetBSD: distinfo,v 1.5 2011/04/05 11:32:46 wiz Exp $ 1$NetBSD: distinfo,v 1.6 2015/03/31 15:40:03 joerg Exp $
2 2
3SHA1 (ufoai-2.2.1-data.tar) = eb071333478bd6860179e12d8655301980f87d60 3SHA1 (ufoai-2.2.1-data.tar) = eb071333478bd6860179e12d8655301980f87d60
4RMD160 (ufoai-2.2.1-data.tar) = af91dd473f59c73e705181759059bd37ba215f62 4RMD160 (ufoai-2.2.1-data.tar) = af91dd473f59c73e705181759059bd37ba215f62
5Size (ufoai-2.2.1-data.tar) = 390502400 bytes 5Size (ufoai-2.2.1-data.tar) = 390502400 bytes
6SHA1 (ufoai-2.2.1-mappack.tar.bz2) = c7e3bcccdbbb125659eb9d5423bf421f649e75a6 6SHA1 (ufoai-2.2.1-mappack.tar.bz2) = c7e3bcccdbbb125659eb9d5423bf421f649e75a6
7RMD160 (ufoai-2.2.1-mappack.tar.bz2) = b8254b2497e7d830c4b839ce37884d86ee4a738d 7RMD160 (ufoai-2.2.1-mappack.tar.bz2) = b8254b2497e7d830c4b839ce37884d86ee4a738d
8Size (ufoai-2.2.1-mappack.tar.bz2) = 72880186 bytes 8Size (ufoai-2.2.1-mappack.tar.bz2) = 72880186 bytes
9SHA1 (ufoai-2.2.1-source.tar.bz2) = 6ad1b8c357fdbbe9a31839b3bf8de46ad17a40eb 9SHA1 (ufoai-2.2.1-source.tar.bz2) = 6ad1b8c357fdbbe9a31839b3bf8de46ad17a40eb
10RMD160 (ufoai-2.2.1-source.tar.bz2) = 980405a5d38bcbb5ae2cea4e25c54374c7dd8e99 10RMD160 (ufoai-2.2.1-source.tar.bz2) = 980405a5d38bcbb5ae2cea4e25c54374c7dd8e99
11Size (ufoai-2.2.1-source.tar.bz2) = 7640531 bytes 11Size (ufoai-2.2.1-source.tar.bz2) = 7640531 bytes
12SHA1 (patch-aa) = 2b196e8d94a1848b42212f32c90a259e56440382 12SHA1 (patch-aa) = 2b196e8d94a1848b42212f32c90a259e56440382
13SHA1 (patch-ab) = 0d02436454b3dbd85b8027fcf321714be8bf05a2 13SHA1 (patch-ab) = 0d02436454b3dbd85b8027fcf321714be8bf05a2
14SHA1 (patch-ac) = 29069a06c2442060734e32162a9b561c19be8739 14SHA1 (patch-ac) = 29069a06c2442060734e32162a9b561c19be8739
 15SHA1 (patch-src_common_msg.c) = 6554364b9bdfa1040f44240da362c5c68c6d98cb
 16SHA1 (patch-src_common_netpack.c) = 88fc5a66e1e9e9006b43df262190e5e1cfbfd734
File Added: pkgsrc/games/ufoai/patches/patch-src_common_msg.c
$NetBSD: patch-src_common_msg.c,v 1.1 2015/03/31 15:40:03 joerg Exp $

--- src/common/msg.c.orig	2015-03-26 15:32:50.000000000 +0000
+++ src/common/msg.c
@@ -316,9 +316,6 @@ void MSG_V_WriteFormat (sizebuf_t * sb, 
 			Com_Error(ERR_DROP, "WriteFormat: Unknown type!");
 		}
 	}
-	/* Too many arguments for the given format; too few cause crash above */
-	if (!ap)
-		Com_Error(ERR_DROP, "WriteFormat: Too many arguments!");
 }
 
 /**
@@ -662,9 +659,6 @@ void MSG_V_ReadFormat (sizebuf_t * msg_r
 			Com_Error(ERR_DROP, "ReadFormat: Unknown type!");
 		}
 	}
-	/* Too many arguments for the given format; too few cause crash above */
-	if (!ap)
-		Com_Error(ERR_DROP, "ReadFormat: Too many arguments!");
 }
 
 /**
File Added: pkgsrc/games/ufoai/patches/patch-src_common_netpack.c
$NetBSD: patch-src_common_netpack.c,v 1.1 2015/03/31 15:40:03 joerg Exp $

--- src/common/netpack.c.orig	2015-03-26 15:39:22.000000000 +0000
+++ src/common/netpack.c
@@ -189,9 +189,6 @@ void NET_V_WriteFormat (struct dbuffer *
 			Com_Error(ERR_DROP, "WriteFormat: Unknown type!");
 		}
 	}
-	/* Too many arguments for the given format; too few cause crash above */
-	if (!ap)
-		Com_Error(ERR_DROP, "WriteFormat: Too many arguments!");
 }
 
 /**
@@ -470,9 +467,6 @@ void NET_V_ReadFormat (struct dbuffer *b
 			Com_Error(ERR_DROP, "ReadFormat: Unknown type!");
 		}
 	}
-	/* Too many arguments for the given format; too few cause crash above */
-	if (!ap)
-		Com_Error(ERR_DROP, "ReadFormat: Too many arguments!");
 }
 
 /**