Tue Mar 26 16:12:28 2019 UTC ()
lang/python27: Add comments about NIS detection

The logic to determine inclusion of NIS PLIST entries is confusing.
Add comments to explain some and question some.

This is a comment-only change.


(gdt)
diff -r1.77 -r1.78 pkgsrc/lang/python27/Makefile
cvs diff -r1.77 -r1.78 pkgsrc/lang/python27/Makefile (expand / switch to unified diff)

--- pkgsrc/lang/python27/Makefile 2019/03/05 12:43:40 1.77
+++ pkgsrc/lang/python27/Makefile 2019/03/26 16:12:28 1.78
@@ -1,14 +1,14 @@ @@ -1,14 +1,14 @@
1# $NetBSD: Makefile,v 1.77 2019/03/05 12:43:40 adam Exp $ 1# $NetBSD: Makefile,v 1.78 2019/03/26 16:12:28 gdt Exp $
2 2
3.include "dist.mk" 3.include "dist.mk"
4 4
5PKGNAME= python27-${PY_DISTVERSION} 5PKGNAME= python27-${PY_DISTVERSION}
6CATEGORIES= lang python 6CATEGORIES= lang python
7 7
8MAINTAINER= pkgsrc-users@NetBSD.org 8MAINTAINER= pkgsrc-users@NetBSD.org
9HOMEPAGE= https://www.python.org/ 9HOMEPAGE= https://www.python.org/
10COMMENT= Interpreted, interactive, object-oriented programming language 10COMMENT= Interpreted, interactive, object-oriented programming language
11LICENSE= python-software-foundation 11LICENSE= python-software-foundation
12 12
13DEPENDS= mozilla-rootcerts>=1.0.20150804nb1:../../security/mozilla-rootcerts 13DEPENDS= mozilla-rootcerts>=1.0.20150804nb1:../../security/mozilla-rootcerts
14 14
@@ -94,36 +94,43 @@ PLIST.extra-so= yes @@ -94,36 +94,43 @@ PLIST.extra-so= yes
94 94
95# For Xcode 5 we need to search the SDK path for headers, otherwise certain 95# For Xcode 5 we need to search the SDK path for headers, otherwise certain
96# modules will not be built. 96# modules will not be built.
97.if ${OPSYS} == "Darwin" 97.if ${OPSYS} == "Darwin"
98. if exists(${OSX_SDK_PATH}/usr/include) 98. if exists(${OSX_SDK_PATH}/usr/include)
99CFLAGS+= -I${OSX_SDK_PATH:Q}/usr/include 99CFLAGS+= -I${OSX_SDK_PATH:Q}/usr/include
100. endif 100. endif
101. if exists(${OSX_SDK_PATH}/System/Library/Frameworks/QuickTime.framework) 101. if exists(${OSX_SDK_PATH}/System/Library/Frameworks/QuickTime.framework)
102PLIST.qt= yes 102PLIST.qt= yes
103. endif 103. endif
104.endif 104.endif
105 105
106.if ${OPSYS} == "IRIX" 106.if ${OPSYS} == "IRIX"
 107# Assume that IRIX (and IRIX alone) does not support a libpython.so.
 108# Assume that 32-bit IRIX has NIS and 64-bit IRIX does not.
107. if ${ABI} == "64" 109. if ${ABI} == "64"
108PLIST.no-nis= yes 110PLIST.no-nis= yes
109. else 111. else
110PLIST.nis= yes 112PLIST.nis= yes
111. endif 113. endif
112.else 114.else
113PLIST.dll= yes 115PLIST.dll= yes
 116# Determine if lib-dynload/nis.so (PLIST.nis) or
 117# lib-dynload/nis-failed.so (PLIST.no-nis) will be built.
114. if ${OPSYS} == "MirBSD" || "${OS_VARIANT}" == "chromeos" 118. if ${OPSYS} == "MirBSD" || "${OS_VARIANT}" == "chromeos"
115# neither nis nor no-nis 119# neither nis nor no-nis
116. elif ${OPSYS} != "NetBSD" || exists(/usr/bin/ypcat) 120. elif ${OPSYS} != "NetBSD" || exists(/usr/bin/ypcat)
 121# \todo Explain the "!= NetBSD"; that seems to declare that any
 122# remaining system other than NetBSD will have NIS, even if ypcat is
 123# missing.
117PLIST.nis= yes 124PLIST.nis= yes
118. else 125. else
119PLIST.no-nis= yes 126PLIST.no-nis= yes
120. endif 127. endif
121.endif 128.endif
122 129
123# configure complains about buggy getaddrinfo() 130# configure complains about buggy getaddrinfo()
124CONFIGURE_ARGS.OSF1+= --disable-ipv6 131CONFIGURE_ARGS.OSF1+= --disable-ipv6
125 132
126PLIST_SUBST+= PY_VER_SUFFIX=${PY_VER_SUFFIX:Q} 133PLIST_SUBST+= PY_VER_SUFFIX=${PY_VER_SUFFIX:Q}
127 134
128TEST_TARGET= test 135TEST_TARGET= test
129INSTALL_TARGET= altinstall 136INSTALL_TARGET= altinstall