Thu Apr 23 19:32:53 2020 UTC ()
mk/subst.mk: don't recommend {pre,do,post}-patch

These often lead to broken patches, unless the patches are generated very
cautiously. Because of this, pkglint already warns about this.


(rillig)
diff -r1.83 -r1.84 pkgsrc/mk/subst.mk

cvs diff -r1.83 -r1.84 pkgsrc/mk/subst.mk (expand / switch to unified diff)

--- pkgsrc/mk/subst.mk 2020/04/23 19:30:29 1.83
+++ pkgsrc/mk/subst.mk 2020/04/23 19:32:53 1.84
@@ -1,14 +1,14 @@ @@ -1,14 +1,14 @@
1# $NetBSD: subst.mk,v 1.83 2020/04/23 19:30:29 rillig Exp $ 1# $NetBSD: subst.mk,v 1.84 2020/04/23 19:32:53 rillig Exp $
2# 2#
3# The subst framework replaces text in one or more files in the WRKSRC 3# The subst framework replaces text in one or more files in the WRKSRC
4# directory. Packages can define several ``classes'' of replacements. 4# directory. Packages can define several ``classes'' of replacements.
5# Each such class defines: 5# Each such class defines:
6# 6#
7# - in which stage of the build process the replacement happens 7# - in which stage of the build process the replacement happens
8# - which files are affected by the replacement 8# - which files are affected by the replacement
9# - which text or pattern is replaced by which replacement text 9# - which text or pattern is replaced by which replacement text
10# 10#
11# A typical example is: 11# A typical example is:
12# 12#
13# SUBST_CLASSES+= prefix 13# SUBST_CLASSES+= prefix
14# SUBST_STAGE.prefix= pre-configure 14# SUBST_STAGE.prefix= pre-configure
@@ -26,27 +26,27 @@ @@ -26,27 +26,27 @@
26# don't have any effect. 26# don't have any effect.
27# 27#
28# For backwards compatibility this defaults to "yes", but it 28# For backwards compatibility this defaults to "yes", but it
29# should rather be set to "no". 29# should rather be set to "no".
30# 30#
31# Package-settable variables: 31# Package-settable variables:
32# 32#
33# SUBST_CLASSES 33# SUBST_CLASSES
34# A list of class names. When adding new classes to this list, be 34# A list of class names. When adding new classes to this list, be
35# sure to append them (+=) instead of overriding them (=). 35# sure to append them (+=) instead of overriding them (=).
36# 36#
37# SUBST_STAGE.<class> 37# SUBST_STAGE.<class>
38# "stage" at which we do the text replacement. Should be one of 38# "stage" at which we do the text replacement. Should be one of
39# {pre,do,post}-{extract,patch,configure,build,install}. 39# {pre,do,post}-{extract,configure,build,install}.
40# 40#
41# SUBST_MESSAGE.<class> 41# SUBST_MESSAGE.<class>
42# The message to display before doing the substitution. 42# The message to display before doing the substitution.
43# 43#
44# SUBST_FILES.<class> 44# SUBST_FILES.<class>
45# A list of file patterns on which to run the substitution; 45# A list of file patterns on which to run the substitution;
46# the filenames are either absolute or relative to ${WRKSRC}. 46# the filenames are either absolute or relative to ${WRKSRC}.
47# 47#
48# Starting with 2020Q1, it is an error if any of these patterns 48# Starting with 2020Q1, it is an error if any of these patterns
49# has no effect at all, to catch typos and outdated definitions. 49# has no effect at all, to catch typos and outdated definitions.
50# To prevent this, see SUBST_NOOP_OK.<class> below. 50# To prevent this, see SUBST_NOOP_OK.<class> below.
51# 51#
52# In most cases the filename patterns are given directly. 52# In most cases the filename patterns are given directly.