Wed May 13 13:49:09 2020 UTC ()
Pullup ticket #6193 - requested by nia
graphics/openjpeg: security fix
Revisions pulled up:
- graphics/openjpeg/Makefile 1.21
- graphics/openjpeg/distinfo 1.18
- graphics/openjpeg/patches/patch-src_lib_openjp2_j2k.c 1.1
- graphics/openjpeg/patches/patch-src_lib_openjp2_tcd.c 1.1
---
Module Name: pkgsrc
Committed By: nia
Date: Tue May 12 10:44:46 UTC 2020
Modified Files:
pkgsrc/graphics/openjpeg: Makefile distinfo
Added Files:
pkgsrc/graphics/openjpeg/patches: patch-src_lib_openjp2_j2k.c
patch-src_lib_openjp2_tcd.c
Log Message:
openjpeg: Cherrypick fixes for the following CVEs from upstream:
https://nvd.nist.gov/vuln/detail/CVE-2020-6851 - out-of-bounds-write
https://nvd.nist.gov/vuln/detail/CVE-2020-8112 - heap-overflow
Please make releases for your software. :/
Bump PKGREVISION
(bsiegert)
diff -r1.20 -r1.20.2.1 pkgsrc/graphics/openjpeg/Makefile
diff -r1.17 -r1.17.2.1 pkgsrc/graphics/openjpeg/distinfo
diff -r0 -r1.1.2.2 pkgsrc/graphics/openjpeg/patches/patch-src_lib_openjp2_j2k.c
diff -r0 -r1.1.2.2 pkgsrc/graphics/openjpeg/patches/patch-src_lib_openjp2_tcd.c
--- pkgsrc/graphics/openjpeg/Makefile 2020/01/26 17:31:22 1.20
+++ pkgsrc/graphics/openjpeg/Makefile 2020/05/13 13:49:08 1.20.2.1
| @@ -1,17 +1,17 @@ | | | @@ -1,17 +1,17 @@ |
1 | # $NetBSD: Makefile,v 1.20 2020/01/26 17:31:22 rillig Exp $ | | 1 | # $NetBSD: Makefile,v 1.20.2.1 2020/05/13 13:49:08 bsiegert Exp $ |
2 | | | 2 | |
3 | DISTNAME= openjpeg-2.3.1 | | 3 | DISTNAME= openjpeg-2.3.1 |
4 | PKGREVISION= 2 | | 4 | PKGREVISION= 3 |
5 | CATEGORIES= graphics | | 5 | CATEGORIES= graphics |
6 | MASTER_SITES= ${MASTER_SITE_GITHUB:=uclouvain/} | | 6 | MASTER_SITES= ${MASTER_SITE_GITHUB:=uclouvain/} |
7 | GITHUB_TAG= v${PKGVERSION_NOREV} | | 7 | GITHUB_TAG= v${PKGVERSION_NOREV} |
8 | | | 8 | |
9 | MAINTAINER= pkgsrc-users@NetBSD.org | | 9 | MAINTAINER= pkgsrc-users@NetBSD.org |
10 | HOMEPAGE= https://www.openjpeg.org/ | | 10 | HOMEPAGE= https://www.openjpeg.org/ |
11 | COMMENT= JPEG 2000 library | | 11 | COMMENT= JPEG 2000 library |
12 | LICENSE= 2-clause-bsd | | 12 | LICENSE= 2-clause-bsd |
13 | | | 13 | |
14 | USE_CMAKE= yes | | 14 | USE_CMAKE= yes |
15 | USE_LANGUAGES= c99 c++ | | 15 | USE_LANGUAGES= c99 c++ |
16 | CMAKE_ARGS+= -DOPENJPEG_INSTALL_MAN_DIR=${PKGMANDIR} | | 16 | CMAKE_ARGS+= -DOPENJPEG_INSTALL_MAN_DIR=${PKGMANDIR} |
17 | | | 17 | |
--- pkgsrc/graphics/openjpeg/distinfo 2020/01/07 20:19:45 1.17
+++ pkgsrc/graphics/openjpeg/distinfo 2020/05/13 13:49:08 1.17.2.1
| @@ -1,12 +1,14 @@ | | | @@ -1,12 +1,14 @@ |
1 | $NetBSD: distinfo,v 1.17 2020/01/07 20:19:45 sevan Exp $ | | 1 | $NetBSD: distinfo,v 1.17.2.1 2020/05/13 13:49:08 bsiegert Exp $ |
2 | | | 2 | |
3 | SHA1 (openjpeg-2.3.1.tar.gz) = 38321fa9730252039ad0b7f247a160a8164f5871 | | 3 | SHA1 (openjpeg-2.3.1.tar.gz) = 38321fa9730252039ad0b7f247a160a8164f5871 |
4 | RMD160 (openjpeg-2.3.1.tar.gz) = 31b75aa70f5d26dd1b7e374a9e4b6be1842fefe7 | | 4 | RMD160 (openjpeg-2.3.1.tar.gz) = 31b75aa70f5d26dd1b7e374a9e4b6be1842fefe7 |
5 | SHA512 (openjpeg-2.3.1.tar.gz) = 339fbc899bddf2393d214df71ed5d6070a3a76b933b1e75576c8a0ae9dfcc4adec40bdc544f599e4b8d0bc173e4e9e7352408497b5b3c9356985605830c26c03 | | 5 | SHA512 (openjpeg-2.3.1.tar.gz) = 339fbc899bddf2393d214df71ed5d6070a3a76b933b1e75576c8a0ae9dfcc4adec40bdc544f599e4b8d0bc173e4e9e7352408497b5b3c9356985605830c26c03 |
6 | Size (openjpeg-2.3.1.tar.gz) = 2214401 bytes | | 6 | Size (openjpeg-2.3.1.tar.gz) = 2214401 bytes |
7 | SHA1 (patch-CMakeLists.txt) = 3738946db63df4d623c6ce486bd22fa4d57336e2 | | 7 | SHA1 (patch-CMakeLists.txt) = 3738946db63df4d623c6ce486bd22fa4d57336e2 |
8 | SHA1 (patch-src_bin_jp2_CMakeLists.txt) = c9f709c23d6bab7a3c705640d66a00ec90ddabc7 | | 8 | SHA1 (patch-src_bin_jp2_CMakeLists.txt) = c9f709c23d6bab7a3c705640d66a00ec90ddabc7 |
9 | SHA1 (patch-src_bin_jp2_convertbmp.c) = bceb4a99820568386e48eb00ab13ab9987d1e86a | | 9 | SHA1 (patch-src_bin_jp2_convertbmp.c) = bceb4a99820568386e48eb00ab13ab9987d1e86a |
10 | SHA1 (patch-src_lib_openjp2_CMakeLists.txt) = d839121ec2d008e5d3e1676d3e7ac3642bc946f7 | | 10 | SHA1 (patch-src_lib_openjp2_CMakeLists.txt) = d839121ec2d008e5d3e1676d3e7ac3642bc946f7 |
| | | 11 | SHA1 (patch-src_lib_openjp2_j2k.c) = b342aa64c6583a8e4f79495412e5506f40a9023e |
11 | SHA1 (patch-src_lib_openjp2_opj__config__private.h.cmake.in) = fc0c170789dbe0a2ebc9dce0ef0d21aa6b2edd49 | | 12 | SHA1 (patch-src_lib_openjp2_opj__config__private.h.cmake.in) = fc0c170789dbe0a2ebc9dce0ef0d21aa6b2edd49 |
| | | 13 | SHA1 (patch-src_lib_openjp2_tcd.c) = da3354c101485f1b5f92f59d5f1be07a006e3056 |
12 | SHA1 (patch-src_lib_openmj2_t2.c) = a4ce0faa349f1a23453ef7632fbcc3af2d045337 | | 14 | SHA1 (patch-src_lib_openmj2_t2.c) = a4ce0faa349f1a23453ef7632fbcc3af2d045337 |
$NetBSD: patch-src_lib_openjp2_j2k.c,v 1.1.2.2 2020/05/13 13:49:08 bsiegert Exp $
CVE-2020-6851
https://github.com/uclouvain/openjpeg/commit/d7064fad0f8a2b485c4b520697e6741c6d94f5c5.patch
--- src/lib/openjp2/j2k.c.orig 2019-04-02 12:45:15.000000000 +0000
+++ src/lib/openjp2/j2k.c
@@ -9236,6 +9236,14 @@ static OPJ_BOOL opj_j2k_update_image_dim
l_img_comp = p_image->comps;
for (it_comp = 0; it_comp < p_image->numcomps; ++it_comp) {
OPJ_INT32 l_h, l_w;
+ if( p_image->x0 > (OPJ_UINT32)INT_MAX ||
+ p_image->y0 > (OPJ_UINT32)INT_MAX ||
+ p_image->x1 > (OPJ_UINT32)INT_MAX ||
+ p_image->y1 > (OPJ_UINT32)INT_MAX ) {
+ opj_event_msg(p_manager, EVT_ERROR,
+ "Image coordinates above INT_MAX are not supported\n");
+ return OPJ_FALSE;
+ }
l_img_comp->x0 = (OPJ_UINT32)opj_int_ceildiv((OPJ_INT32)p_image->x0,
(OPJ_INT32)l_img_comp->dx);
$NetBSD: patch-src_lib_openjp2_tcd.c,v 1.1.2.2 2020/05/13 13:49:08 bsiegert Exp $
CVE-2020-8112
https://github.com/uclouvain/openjpeg/commit/05f9b91e60debda0e83977e5e63b2e66486f7074.patch
--- src/lib/openjp2/tcd.c.orig 2019-04-02 12:45:15.000000000 +0000
+++ src/lib/openjp2/tcd.c
@@ -905,8 +905,24 @@ static INLINE OPJ_BOOL opj_tcd_init_tile
/* p. 64, B.6, ISO/IEC FDIS15444-1 : 2000 (18 august 2000) */
l_tl_prc_x_start = opj_int_floordivpow2(l_res->x0, (OPJ_INT32)l_pdx) << l_pdx;
l_tl_prc_y_start = opj_int_floordivpow2(l_res->y0, (OPJ_INT32)l_pdy) << l_pdy;
- l_br_prc_x_end = opj_int_ceildivpow2(l_res->x1, (OPJ_INT32)l_pdx) << l_pdx;
- l_br_prc_y_end = opj_int_ceildivpow2(l_res->y1, (OPJ_INT32)l_pdy) << l_pdy;
+ {
+ OPJ_UINT32 tmp = ((OPJ_UINT32)opj_int_ceildivpow2(l_res->x1,
+ (OPJ_INT32)l_pdx)) << l_pdx;
+ if (tmp > (OPJ_UINT32)INT_MAX) {
+ opj_event_msg(manager, EVT_ERROR, "Integer overflow\n");
+ return OPJ_FALSE;
+ }
+ l_br_prc_x_end = (OPJ_INT32)tmp;
+ }
+ {
+ OPJ_UINT32 tmp = ((OPJ_UINT32)opj_int_ceildivpow2(l_res->y1,
+ (OPJ_INT32)l_pdy)) << l_pdy;
+ if (tmp > (OPJ_UINT32)INT_MAX) {
+ opj_event_msg(manager, EVT_ERROR, "Integer overflow\n");
+ return OPJ_FALSE;
+ }
+ l_br_prc_y_end = (OPJ_INT32)tmp;
+ }
/*fprintf(stderr, "\t\t\tprc_x_start=%d, prc_y_start=%d, br_prc_x_end=%d, br_prc_y_end=%d \n", l_tl_prc_x_start, l_tl_prc_y_start, l_br_prc_x_end ,l_br_prc_y_end );*/
l_res->pw = (l_res->x0 == l_res->x1) ? 0U : (OPJ_UINT32)((