Thu Mar 25 23:53:13 2021 UTC ()
mpg123: update to 1.26.5 and use default optimization

This approaches a serious performance issue with 1.26.x when
resampling is used on certain platforms (observed on SPARC).
Floating point denormals crop up. This change approaches that
two-fold

1. Do not disable default optimization flags for GCC.
2. Update to 1.26.5 that contains code to avoid denormals.

The default flags are about code optimization (like -ffast-math),
not the target architecture, so should not affect portability.
They are also rather safe and tested as development of mpg123
always has them in place. This is how it is meant to be played;-)

Approved during freeze by wiz.


(thor)
diff -r1.56 -r1.57 pkgsrc/audio/mpg123/Makefile.common
diff -r1.55 -r1.56 pkgsrc/audio/mpg123/distinfo
cvs diff -r1.56 -r1.57 pkgsrc/audio/mpg123/Makefile.common (expand / switch to unified diff)

--- pkgsrc/audio/mpg123/Makefile.common 2021/01/03 15:06:00 1.56
+++ pkgsrc/audio/mpg123/Makefile.common 2021/03/25 23:53:13 1.57
@@ -1,37 +1,36 @@ @@ -1,37 +1,36 @@
1# $NetBSD: Makefile.common,v 1.56 2021/01/03 15:06:00 adam Exp $ 1# $NetBSD: Makefile.common,v 1.57 2021/03/25 23:53:13 thor Exp $
2# 2#
3# used by audio/mpg123-nas/Makefile 3# used by audio/mpg123-nas/Makefile
4# used by audio/mpg123-oss/Makefile 4# used by audio/mpg123-oss/Makefile
5# used by audio/mpg123-pulse/Makefile 5# used by audio/mpg123-pulse/Makefile
6# used by audio/mpg123-sun/Makefile 6# used by audio/mpg123-sun/Makefile
7 7
8DISTNAME= mpg123-1.26.4 8DISTNAME= mpg123-1.26.5
9PKGNAME?= ${DISTNAME:C/[[:alnum:]]*/&-${MPG123_MODULE}/} 9PKGNAME?= ${DISTNAME:C/[[:alnum:]]*/&-${MPG123_MODULE}/}
10CATEGORIES= audio 10CATEGORIES= audio
11MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=mpg123/} 11MASTER_SITES= ${MASTER_SITE_SOURCEFORGE:=mpg123/}
12EXTRACT_SUFX= .tar.bz2 12EXTRACT_SUFX= .tar.bz2
13 13
14MAINTAINER= martin@NetBSD.org 14MAINTAINER= martin@NetBSD.org
15HOMEPAGE= https://www.mpg123.org/ 15HOMEPAGE= https://www.mpg123.org/
16COMMENT?= Contains the ${MPG123_MODULE} module for mpg123 16COMMENT?= Contains the ${MPG123_MODULE} module for mpg123
17LICENSE= gnu-lgpl-v2.1 17LICENSE= gnu-lgpl-v2.1
18 18
19USE_LANGUAGES= c99 19USE_LANGUAGES= c99
20USE_LIBTOOL?= yes 20USE_LIBTOOL?= yes
21USE_TOOLS+= pkg-config gmake 21USE_TOOLS+= pkg-config gmake
22GNU_CONFIGURE?= yes 22GNU_CONFIGURE?= yes
23CONFIGURE_ARGS+= --enable-modules=yes 23CONFIGURE_ARGS+= --enable-modules=yes
24CONFIGURE_ARGS+= --with-optimization=0 # our CFLAGS are good enough 
25CONFIGURE_ENV+= BUILD_${MPG123_MODULE:tu}=yes 24CONFIGURE_ENV+= BUILD_${MPG123_MODULE:tu}=yes
26CONFIGURE_ENV+= MPG123_MODULE=${MPG123_MODULE:Q} 25CONFIGURE_ENV+= MPG123_MODULE=${MPG123_MODULE:Q}
27 26
28DISTINFO_FILE= ${.CURDIR}/../../audio/mpg123/distinfo 27DISTINFO_FILE= ${.CURDIR}/../../audio/mpg123/distinfo
29 28
30CPPFLAGS.SunOS+= -D_XOPEN_SOURCE=600 -D__EXTENSIONS__ 29CPPFLAGS.SunOS+= -D_XOPEN_SOURCE=600 -D__EXTENSIONS__
31 30
32.if !defined(MPG123_BUILDING_BASE) 31.if !defined(MPG123_BUILDING_BASE)
33INSTALLATION_DIRS+= lib/mpg123 32INSTALLATION_DIRS+= lib/mpg123
34LIBS+= -lmpg123 33LIBS+= -lmpg123
35BUILD_TARGET= src/libout123/modules/output_${MPG123_MODULE}.la 34BUILD_TARGET= src/libout123/modules/output_${MPG123_MODULE}.la
36PATCHDIR= ${.CURDIR}/../../audio/mpg123/patches 35PATCHDIR= ${.CURDIR}/../../audio/mpg123/patches
37do-install: 36do-install:
cvs diff -r1.55 -r1.56 pkgsrc/audio/mpg123/distinfo (expand / switch to unified diff)

--- pkgsrc/audio/mpg123/distinfo 2021/01/03 15:06:00 1.55
+++ pkgsrc/audio/mpg123/distinfo 2021/03/25 23:53:13 1.56
@@ -1,10 +1,10 @@ @@ -1,10 +1,10 @@
1$NetBSD: distinfo,v 1.55 2021/01/03 15:06:00 adam Exp $ 1$NetBSD: distinfo,v 1.56 2021/03/25 23:53:13 thor Exp $
2 2
3SHA1 (mpg123-1.26.4.tar.bz2) = d6f68d8defbb0622c677d29251a7e81df62cd32f 3SHA1 (mpg123-1.26.5.tar.bz2) = c4ed8d5b0c5400c28198e32b1175c8dac898e569
4RMD160 (mpg123-1.26.4.tar.bz2) = ad42a3d4376b993aafc641596233bbc1b8876d1f 4RMD160 (mpg123-1.26.5.tar.bz2) = 5b433e97f34d2ce5f347bc952671601aaea034bc
5SHA512 (mpg123-1.26.4.tar.bz2) = 425162227aafb99b8723428fe9bd403739a2dd68828b86a2cff7f9928a9f0ab3f67420e56c0abe7c9deeb94bce6c6acd59acaa0606ce24c01716465640564785 5SHA512 (mpg123-1.26.5.tar.bz2) = 0c2b3174c834e4bd459a3324b825d9bf9341a3486c0af815773b00cb007578cb718522ac4e983c7ad7e3bb5df9fdd342a03cb51345c41f68971145196ac04b7a
6Size (mpg123-1.26.4.tar.bz2) = 1050563 bytes 6Size (mpg123-1.26.5.tar.bz2) = 1051356 bytes
7SHA1 (patch-Makefile.in) = e1b529e9468994e25c2567df7e64a2905b0cf529 7SHA1 (patch-Makefile.in) = e1b529e9468994e25c2567df7e64a2905b0cf529
8SHA1 (patch-aa) = 4b2761219dd8fb92079d7f96872e56beb702696a 8SHA1 (patch-aa) = 4b2761219dd8fb92079d7f96872e56beb702696a
9SHA1 (patch-ad) = f07b637c3fc1d3ea0426013fc25bca8e3aecba56 9SHA1 (patch-ad) = f07b637c3fc1d3ea0426013fc25bca8e3aecba56
10SHA1 (patch-af) = ba9ccddda15f0e711675b1bbad72b082b34b15f5 10SHA1 (patch-af) = ba9ccddda15f0e711675b1bbad72b082b34b15f5