audio/rosegarden: legacy code fixups.

This fork of rosegarden is dead upstream but seemingly worth keeping
around, so do some maintenance.

Silence a bunch of compiler warnings (not all though). Avoid unsafe
use of tmpnam(). Avoid some uses of sprintf, including one triggering
a compiler warning about a static overflow. (Plenty more sprintf uses
remain though.) Use standard headers. Use ctype functions correctly.
Etc.

Also add patch comments. Fix some pkglint.

This is probably going to warrant a patchkit in the future.


(dholland)

$NetBSD: patch-editor_src_Dechord.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Ues standard headers.
Use ctype functions correctly.

--- editor/src/Dechord.c~	1997-02-24 21:43:40.000000000 +0000
+++ editor/src/Dechord.c
@@ -22,6 +22,8 @@
 		 yield single notes
 */
 
+#include <ctype.h>
+
 #include "Dechord.h"
 #ifdef USE_POSIX_REGEXP
 
@@ -170,7 +172,7 @@ Pitch NoteToPitch(char Note, ClefTag cur
   Pitch p;
   Begin("NoteToPitch");
 
-  Note = toupper((int)Note);
+  Note = toupper((unsigned char)Note);
   if((Note < 'A') && (Note > 'G')) Error("wrong note");
 
   p = Note - 'E' /* - 7 ?? */ + ClefPitchOffset(currentClef);
@@ -512,9 +514,9 @@ Chord* SpellChord(char ChordString[], Cl
   /* So the Find<x> functions will only see what is "after" the root,
      ie from "Cmaj7" we just want to see "maj7" */
 
-  while(isspace(subChordString[0])) subChordString++;
+  while(isspace((unsigned char)subChordString[0])) subChordString++;
 
-  if(isupper((int)RootNote[0])) {
+  if(isupper((unsigned char)RootNote[0])) {
 
     if(Regexec(GetAltBass, ChordString) == REG_MATCHED) { /* Get possible altered bass */
 #ifdef USE_POSIX_REGEXP

$NetBSD: patch-editor_src_Main.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Use standard headers.
Silence compiler warnings.
Call gethostname() correctly.
Don't use sprintf.

--- editor/src/Main.c.orig	2001-07-03 11:55:17.000000000 +0000
+++ editor/src/Main.c
@@ -17,8 +17,9 @@
 #include <X11/Xutil.h>
 #include <X11/cursorfont.h>
 
-#include <signal.h>
 #include <sys/types.h>
+#include <unistd.h>
+#include <signal.h>
 
 #ifdef HAVE_SPECIALIST_MALLOC_LIBRARY
 #include <malloc.h>
@@ -153,6 +154,10 @@ int ErrorXIO(Display *d)
 
 /* Handler for Toolkit errors, always fatal */
 
+static
+#if defined(__CLANG__) || defined(__GNUC__)
+__attribute__((__noreturn__))
+#endif
 void ErrorXt(char *msg)
 {
   Begin("ErrorXt");
@@ -283,12 +288,14 @@ void SetTitleBar(char **argv)
   title = (String)XtMalloc(200);
 
 #ifdef NO_GETHOSTNAME
-  sprintf(title, "%s", ApplicationName);
+  snprintf(title, 200, "%s", ApplicationName);
 #else
-  if (gethostname(machine, 99))
-    sprintf(title, "%s", ApplicationName);
-  else
-    sprintf(title, "%s  [%s]", ApplicationName, machine);
+  if (gethostname(machine, sizeof(machine)))
+    snprintf(title, 200, "%s", ApplicationName);
+  else {
+    machine[sizeof(machine) - 1] = '\0'; /* just in case */
+    snprintf(title, 200, "%s  [%s]", ApplicationName, machine);
+  }
 #endif
 
   XtSetArg(arg[0], XtNtitle,    (XtArgVal)title);

$NetBSD: patch-editor_src_MenuGroup.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Use standard headers.
Use ctype functions correctly.
Use scratch buffers that are large enough.
Don't use sprintf().

--- editor/src/MenuGroup.c~	1997-02-28 15:12:32.000000000 +0000
+++ editor/src/MenuGroup.c
@@ -6,6 +6,8 @@
 
 /* {{{ Includes */
 
+#include <ctype.h>
+
 #include "General.h"
 #include "Widgets.h"
 #include "Menu.h"
@@ -471,9 +473,9 @@ void GroupMenuTuplet(Widget w, XtPointer
 
       for (m = 0; choices[nch].description[m]; ++m) {
 	if (choices[nch].description[m] == ' ') {
-	  if (isupper(choices[nch].description[m+1])) {
+	  if (isupper((unsigned char)choices[nch].description[m+1])) {
 	    choices[nch].description[m+1] =
-	      tolower(choices[nch].description[m+1]);
+	      tolower((unsigned char)choices[nch].description[m+1]);
 	  }
 	}
       }
@@ -972,7 +974,7 @@ void GroupMenuInvert(Widget w, XtPointer
   Dimension      w1;
   XPoint         op;
   String         temp;
-  char           title[32];
+  char           title[64];
   int            i, result = -1;
 
   MajorStaveRec *mstave  = (MajorStaveRec *)stave;
@@ -997,9 +999,9 @@ void GroupMenuInvert(Widget w, XtPointer
 				tPane, MediumShade);
 
   switch(scope) {
-  case 1:  sprintf(title, "Invert Area around pitch");          break;
-  case 2:  sprintf(title, "Invert Rest of Staff around pitch"); break;
-  default: sprintf(title, "Invert Whole Piece around pitch");   break;
+  case 1:  snprintf(title, sizeof(title), "Invert Area around pitch");          break;
+  case 2:  snprintf(title, sizeof(title), "Invert Rest of Staff around pitch"); break;
+  default: snprintf(title, sizeof(title), "Invert Whole Piece around pitch");   break;
   }
 
   tLabel     = YCreateLabel(title, tTopBox);

$NetBSD: patch-editor_src_MenuTools.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Use standard headers.
Don't use tmpnam().
Don't use sprintf().
Use ctype functions correctly.

--- editor/src/MenuTools.c.orig	1997-09-22 20:20:07.000000000 +0000
+++ editor/src/MenuTools.c
@@ -13,6 +13,8 @@
 #include "Menu.h"
 #include "StaveEdit.h"
 
+#include <sys/stat.h>
+#include <ctype.h>		/* for isdigit */
 #include <unistd.h>		/* for unlink */
 
 #include <Yawn.h>
@@ -28,7 +30,10 @@ void SequenceAcknowledgeCallback(IL_Retu
 {
   Begin("SequenceCompleteCallback");
 
-  if (filename) (void)unlink(filename);	/* can't do anything about failure */
+  if (filename) {
+    (void)unlink(filename);	/* can't do anything about failure */
+    XtFree(filename);
+  }
 
   StaveBusy(False);
 
@@ -68,12 +73,17 @@ void SequenceAcknowledgeCallback(IL_Retu
 
 void FileMenuSequence(Widget w, XtPointer a, XtPointer b)
 {
+  char namebuf[PATH_MAX];
+  struct stat buf;
+  int fd;
   int len;
   String name;
   String sname;
   Begin("FileMenuSequence");
 
-  if (!(filename = tmpnam(NULL))) {
+  strcpy(namebuf, "/tmp/rosegarden.XXXXXXXX");
+  fd = mkstemp(namebuf);
+  if (fd < 0 || (filename = XtNewString(namebuf)) == NULL) {
     IssueMenuComplaint("Sorry, I couldn't get a temporary file name.");
     End;
   }
@@ -83,17 +93,24 @@ void FileMenuSequence(Widget w, XtPointe
   name = (String)XtMalloc(len + 25);
 
   if (len > 13 && !strcmp(sname + len - 12, " (temporary)")) {
-    sprintf(name, "%s", sname);
+    snprintf(name, len + 25, "%s", sname);
   } else {
-    sprintf(name, "%s (temporary)", sname);
+    snprintf(name, len + 25, "%s (temporary)", sname);
   }
 
   if (MidiWriteStave(stave, filename, name) == Failed) {
     XtFree(name);
+    close(fd);
     End;
   }
 
   XtFree(name);
+  if (fstat(fd, &buf) < 0 || buf.st_size == 0) {
+    IssueMenuComplaint("Sorry, something went wrong with the temporary file.");
+    close(fd);
+    End;
+  }
+  close(fd);
 
   StaveBusy(True);
   IL_RequestService(ILS_SEQUENCE_SERVICE, SequenceAcknowledgeCallback,
@@ -271,7 +288,7 @@ void FileMenuFollowILCallback(String chu
 
   IL_AcknowledgeRequest(ILS_FOLLOW_SERVICE, IL_SERVICE_OK);
 
-  if (!isdigit(chunk[0]) && chunk[0] != '-') {
+  if (!isdigit((unsigned char)chunk[0]) && chunk[0] != '-') {
 
     if (!strcmp(chunk, ILS_FOLLOW_UNLOCK)) {
 

$NetBSD: patch-editor_src_Rechord.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Use standard headers.
Use ctype functions correctly.

--- editor/src/Rechord.c~	2001-06-29 16:31:01.000000000 +0000
+++ editor/src/Rechord.c
@@ -2,6 +2,8 @@
 /* Mild attempt at chord naming */
 /* G. Laurent, 09/96 */
 
+#include <ctype.h>
+
 #include "Rechord.h"
 
 #ifdef DEBUG
@@ -824,7 +826,7 @@ char* Rechord(Chord chord) {
   }
   else {
     /* There's only one note in the chord, use lower case to name it */
-    holdShortest[0] = (char)tolower((int)holdShortest[0]);
+    holdShortest[0] = tolower((unsigned char)holdShortest[0]);
   }
 
   chordName = malloc(strlen(holdShortest) + 1);

$NetBSD: patch-lists_include_Lists.h,v 1.1 2022/01/01 09:20:41 dholland Exp $

Avoid UB:
  - declare a suitable return type for a function returning a truth value

--- lists/include/Lists.h~	2002-03-22 22:31:52.000000000 +0000
+++ lists/include/Lists.h
@@ -84,7 +84,7 @@ extern List    LIST_Split       (List a)
 				             /* should already have second, */
 				             /* 'cos it was the passed arg) */
 
-extern List	LIST_IsWithin	(List who, List start, List end);
+extern int	LIST_IsWithin	(List who, List start, List end);
 					    /* is `who' a part of list */
 					    /* *** Deemus		*/
 

$NetBSD: patch-lists_src_Lists.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Silence compiler warnings.
Avoid UB:
  - declare a suitable return type for a function returning a truth value
  - source files must end with a newline

--- lists/src/Lists.c~	2002-03-22 22:24:07.000000000 +0000
+++ lists/src/Lists.c
@@ -218,7 +218,7 @@ List LIST_Split(List a)
 
 // ***
 /* Check if given element is a part of list chunk */
-List LIST_IsWithin (List who, List start, List end)
+int LIST_IsWithin (List who, List start, List end)
 {
   Begin ("LIST_IsWithin");
   
@@ -234,4 +234,4 @@ List LIST_IsWithin (List who, List start
   
   Return (0);
 }
-// *** Deemus
\ No newline at end of file
+// *** Deemus

$NetBSD: patch-sequencer_src_EventListWindow.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Silence compiler warnings.

--- sequencer/src/EventListWindow.c~	1997-06-14 15:17:36.000000000 +0000
+++ sequencer/src/EventListWindow.c
@@ -284,7 +284,7 @@ void
 Midi_DeviceMenuCB(Widget w, XtPointer a, XtPointer b)
 {
   ELWindowList ThisWindow = (ELWindowList)a;
-  int i = (int)b;
+  int i = (int)(intptr_t)b;
 
   BEGIN("Midi_DeviceMenuCB");
 

$NetBSD: patch-sequencer_src_Main.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Silence compiler warnings.

--- sequencer/src/Main.c~	1997-10-16 21:46:59.000000000 +0000
+++ sequencer/src/Main.c
@@ -301,6 +301,10 @@ RETURN_INT(-1);			/* no return is fatal 
 /* Midi_ErrorXt: Handler for Toolkit errors, always fatal */
 /**********************************************************/
 
+static
+#if defined(__CLANG__) || defined(__GNUC__)
+__attribute__((__noreturn__))
+#endif
 void Midi_ErrorXt(char *msg)
 {
 BEGIN("Midi_ErrorXt");

$NetBSD: patch-sequencer_src_Menu.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Use standard headers.
Don't use tmpnam().

--- sequencer/src/Menu.c.orig	1997-10-21 21:19:40.000000000 +0000
+++ sequencer/src/Menu.c
@@ -3,9 +3,11 @@
  */
 
 #include <ILClient.h>
-/*#include <sys/types.h>
+#include <sys/types.h>
+#include <sys/stat.h>
 #include <sys/wait.h>
-#include <unistd.h>*/
+/*#include <unistd.h>*/
+#include <limits.h>
 #include "Globals.h"
 
 #include "Types.h"
@@ -251,6 +253,10 @@ END;
 	
 void Midi_NotateCB(Widget w, XtPointer a, XtPointer b)
 {
+	char tempname[PATH_MAX];
+	struct stat buf;
+	int fd;
+
 BEGIN("Midi_NotateCB");
 
 	w = Midi_GetShellWidget(w);
@@ -264,14 +270,25 @@ BEGIN("Midi_NotateCB");
 		END;
 	}
 
-	if (!(MIDItempFileName = XtNewString(tmpnam(NULL))))
+	strcpy(tempname, "/tmp/rosegarden.XXXXXXXX");
+	fd = mkstemp(tempname);
+	if (fd < 0 || (MIDItempFileName = XtNewString(tmpnam(NULL))) == NULL)
 	{
+		close(fd);
 		YQuery(topLevel, "Sorry, I couldn't get a temporary file name.",
 		       1, 0, 0, "Continue", NULL);
 		END;
 	}
 	
 	Midi_SaveFile(MIDItempFileName);
+	if (fstat(fd, &buf) < 0 || buf.st_size == 0)
+	{
+		close(fd);
+		YQuery(topLevel, "Sorry, something went wrong with the temporary file.",
+		       1, 0, 0, "Continue", NULL);
+		END;
+	}
+	close(fd);
 
 	IL_RequestService(ILS_EDIT_SERVICE, Midi_NotateAckCB, MIDItempFileName, strlen(MIDItempFileName) + 1);
 

$NetBSD: patch-sequencer_src_MidiSetupDlgs.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Silence compiler warnings.

--- sequencer/src/MidiSetupDlgs.c~	1997-10-07 21:28:58.000000000 +0000
+++ sequencer/src/MidiSetupDlgs.c
@@ -91,7 +91,7 @@ Midi_ChangesAllTracksCB(Widget w, XtPoin
 /* ELWindowList ThisWindow = (ELWindowList)a; */
 BEGIN("Midi_ChangesAllTracksCB");
 
-     MenuSelection  = (int)b;
+     MenuSelection  = (int)(intptr_t)b;
 
 END;
 }

$NetBSD: patch-sequencer_src_PianoRoll.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Silence compiler warnings.

--- sequencer/src/PianoRoll.c~	1997-05-18 11:57:17.000000000 +0000
+++ sequencer/src/PianoRoll.c
@@ -414,7 +414,7 @@ BEGIN("Midi_PianoRollScrollbarScrollCB")
 
     Zoom = ParentWindow->Zoom;
     if (!ParentWindow) END;
-    Pos = (int)CBdata;
+    Pos = (int)(intptr_t)CBdata;
 
     YGetValue(ParentWindow->Scrollbar, XtNlength, &Length);
 

$NetBSD: patch-topbox_src_Main.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Silence compiler warnings.

--- topbox/src/Main.c~	1999-09-21 13:34:29.000000000 +0000
+++ topbox/src/Main.c
@@ -131,6 +131,10 @@ int ErrorXIO(Display *d)
 
 /* Handler for Toolkit errors, always fatal */
 
+static
+#if defined(__CLANG__) || defined(__GNUC__)
+__attribute__((__noreturn__))
+#endif
 void ErrorXt(char *msg)
 {
   Begin("ErrorXt");

$NetBSD: patch-yawn_src_YFile.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Silence compiler warnings.

--- yawn/src/YFile.c~	1996-12-22 21:53:24.000000000 +0000
+++ yawn/src/YFile.c
@@ -740,7 +740,7 @@ Boolean FileSetFileNameList(void)
 
   } else {
 
-    XawListChange(fileList, filecall, filecount, mwd > 300 ? mwd+6 : 300, True);
+    XawListChange(fileList, (const char **)filecall, filecount, mwd > 300 ? mwd+6 : 300, True);
   }
 
   XawListUnhighlight(fileList);
@@ -1256,7 +1256,7 @@ void FileName(Widget w, XtPointer a, XtP
 
 void FileFilter(Widget w, XtPointer a, XtPointer b)
 {
-  int answer = (int)b;
+  int answer = (int)(intptr_t)b;
 
   FilterSuffix = fileFilterOptions[0] ? answer == 0 : False;
   GlobDots     = fileFilterOptions[0] ? answer >  1 : answer > 0;

$NetBSD: patch-yawn_src_YOptionMenu.c,v 1.1 2022/01/01 09:20:41 dholland Exp $

Silence compiler warnings.

--- yawn/src/YOptionMenu.c~	1996-07-18 21:03:25.000000000 +0000
+++ yawn/src/YOptionMenu.c
@@ -48,7 +48,7 @@ void _YOptionMenuCallback(Widget w, XtPo
 	XtVaSetValues(optionMenus[i].button, XtNlabel, elt->label, NULL);
 	if (optionMenus[i].callback) {
 	  optionMenus[i].callback(optionMenus[i].button,
-				  optionMenus[i].client_data, (XtPointer)j);
+				  optionMenus[i].client_data, (XtPointer)(intptr_t)j);
 	}
 
 	End;