Wed Nov 30 21:12:28 2022 UTC ()
geography/qgis: Require C++17 and re-do gmake explanation

C++17 is clearly required, from reading qgis's cmake files.

Upstream qestioned that gmake is required, so document the failures
with BSD make.


(gdt)
diff -r1.159 -r1.160 pkgsrc/geography/qgis/Makefile
cvs diff -r1.159 -r1.160 pkgsrc/geography/qgis/Makefile (expand / switch to unified diff)

--- pkgsrc/geography/qgis/Makefile 2022/11/28 14:25:31 1.159
+++ pkgsrc/geography/qgis/Makefile 2022/11/30 21:12:28 1.160
@@ -1,41 +1,40 @@ @@ -1,41 +1,40 @@
1# $NetBSD: Makefile,v 1.159 2022/11/28 14:25:31 gdt Exp $ 1# $NetBSD: Makefile,v 1.160 2022/11/30 21:12:28 gdt Exp $
2 2
3# This is intentionally 3.28 Long Term Release. Please do not update 3# This is intentionally 3.28 Long Term Release. Please do not update
4# to later branches, and instead discuss whether/how we want multiple 4# to later branches, and instead discuss whether/how we want multiple
5# versions. 5# versions.
6DISTNAME= qgis-3.28.1 6DISTNAME= qgis-3.28.1
7CATEGORIES= geography 7CATEGORIES= geography
8MASTER_SITES= https://qgis.org/downloads/ 8MASTER_SITES= https://qgis.org/downloads/
9EXTRACT_SUFX= .tar.bz2 9EXTRACT_SUFX= .tar.bz2
10 10
11MAINTAINER= gdt@NetBSD.org 11MAINTAINER= gdt@NetBSD.org
12#MAINTAINER+= brook@nmsu.edu 12#MAINTAINER+= brook@nmsu.edu
13#MAINTAINER+= bouyer@NetBSD.orrg 13#MAINTAINER+= bouyer@NetBSD.orrg
14HOMEPAGE= http://www.qgis.org/ 14HOMEPAGE= http://www.qgis.org/
15COMMENT= Geographic Information System (GIS) 15COMMENT= Geographic Information System (GIS)
16LICENSE= gnu-gpl-v2 16LICENSE= gnu-gpl-v2
17 17
18USE_CMAKE= yes 18USE_CMAKE= yes
19USE_LANGUAGES= c c++11 fortran77 19USE_LANGUAGES= c c++17 fortran77
20USE_LIBTOOL= yes 20USE_LIBTOOL= yes
21USE_PKGLOCALEDIR= yes 21USE_PKGLOCALEDIR= yes
22USE_TOOLS+= cmake bison flex perl pkg-config 22USE_TOOLS+= cmake bison flex perl pkg-config
23# Due to gmake spaces in filenames, we must use gmake. An example is 23# Building 3.28.1 fails with BSD make. One issue seem to be a
24# "resources/function_help/json/Date and Time". 24# difference of opinion about quoting of $, with gmake wanting
25# Further, gmake expects files that contain a $ such as "$area" to 25# "$$area" vs bmake perhaps wanting "$$$$area". Another is filenames
26# appear, unsurprisingly, as "$$area" on the RHS of dependency rules. 26# with spaces, which are \-quoted in Makefiles, but bmake sees them as
27# NetBSD make, expects "$$$$area". While cmake 3.17 produced 27# separate files.
28# "$$area", cmake 3.18 produces "$$$$area", perhaps only on NetBSD. 
29USE_TOOLS+= gmake 28USE_TOOLS+= gmake
30 29
31PLIST_SRC= PLIST 30PLIST_SRC= PLIST
32 31
33DEPENDS+= qca2-qt5-ossl-[0-9]*:../../security/qca2-qt5-ossl 32DEPENDS+= qca2-qt5-ossl-[0-9]*:../../security/qca2-qt5-ossl
34# This is needed to find qca2. 33# This is needed to find qca2.
35CMAKE_PREFIX_PATH+= ${QTDIR} 34CMAKE_PREFIX_PATH+= ${QTDIR}
36 35
37# This could be used if we want to build pdf doc, which is currently false 36# This could be used if we want to build pdf doc, which is currently false
38#BUILD_DEPENDS+= txt2tags-[0-9]*:../../wip/txt2tags 37#BUILD_DEPENDS+= txt2tags-[0-9]*:../../wip/txt2tags
39 38
40# Disable building of QGIS.app 39# Disable building of QGIS.app
41# (XXX For now, we might want to find a way to do this later.) 40# (XXX For now, we might want to find a way to do this later.)