tests/libevent: fix Clang build

No idea why GCC did not complain about this as well.

(rillig)

libevent: remove remaining CONSTCOND comments

Since lint1/tree.c 1.202 from 2021-01-31, lint no longer needs the
/*CONSTCOND*/ for do-while-0 "loops".

The comments from this commit were in do-while-0 loops that do not
follow the canonical form, therefore the previous commit did not catch
them.  Some of them have a trailing semicolon (which defies the whole
purpose of the do-while-0 loop), some are missing the space between
'while (0)', some start in column 1 instead of 9.

This reduces the local modifications, compared to the upstream code.

No functional change.

(rillig)

libevent: remove unnecessary CONSTCOND comments

Since lint1/tree.c 1.202 from 2021-01-31, lint no longer needs the
/*CONSTCOND*/ for do-while-0 "loops".

This reduces the local modifications.

No functional change.

(rillig)

lint: use distinct struct tags for type_t in lint1 and lint2

Having two similar but still different definitions of 'struct type' is
unnecessarily confusing.  Exchange this confusion for 8 lines of
straight-forward preprocessing code.

(rillig)

lint: prepare renaming of 'struct type'

It's confusing to have the same struct tag in both lint1 and lint2, with
mostly the same members, but also some differences.  Before actually
changing this, I reviewed all occurrences of the word 'type' in the
code.

No functional change.

(rillig)

Build the netbsd32_syscall module if mips64.
Don't build the linux_syscall module if mips*

(simonb)

update gdtoa info

(christos)

Add support for running individual test cases under isolation.

(gson)

'no merit' is a strong statement

(nia)

Fix a wrong description in previous.
MD drivers can support 20 or 24 bits formats even under current MI layer's
constraints.
http://mail-index.netbsd.org/source-changes-d/2021/03/12/msg013255.html

(isaki)

switch HAVE_GCC=9 to gcc.old.

(mrg)

merge GCC 9.3 into gcc.old.

(mrg)

merge GCC 9.3 into gcc.old.

(mrg)

lint: fix initialization with brace-enclosed string literal

C99 allows this form in 6.7.8p14 and p15.

The previous lint tests did not cover the case of an array at the top
level of the object to be initialized, they only covered the error cases
(d_c99_init.c, variables 'prefixed_message' and 'message_with_suffix').

Lint is now more generous than strictly required by C99, but since GCC
and Clang already cover the case of 'message_with_suffix', this is ok.

The test d_init_array_using_string.c was wrong before in rejecting the
initializer for 'extra_braces'.  I had tested that Clang generated a
warning for this, but I had not inspected its warning carefully enough.
Clang had not warned about the extra braces but only about a type
mismatch since I tested on a platform where wchar_t was 16 bit.

(rillig)

tests/lint: demonstrate wrong warning when initializing a string

(rillig)

lint: fix wrong warning about uninitialized _Complex variable

Seen in divxc3.c.

(rillig)

tests/lint: demonstrate wrong lint warning about complex variables

(rillig)

Avoid duplicate directory traversals when building Elftoolchain sources.

(jkoshy)

lint: quote placeholders in messages for unused variables

(rillig)

lint: do not warn about pointer conversion to or from incomplete type

This cuts down the warnings in a NetBSD release build by about 38,000.

(rillig)

lint: clean up the check for pointer conversions

No functional change.

(rillig)

lint: for structs and unions, include incompleteness in the type name

This mainly helps to assess the situation where lint warns that a
pointer cast "may be troublesome", see msg_247.exp.

(rillig)

tests/lint: document where the 38,000 lint warnings come from

(rillig)

new file(1)

(christos)

merge local changes between 5.39 and 5.40 and add magic entries from HEAD.

(christos)

tests/lint: test bit-shift amount equal to the type's width

(rillig)

lint: clean up handling of preprocessing output lines

No functional change.

(rillig)

Don't use a shell pattern to copy files, copy them explicitly. When running
as non-root, [at]*.mk matches archive.mk which we already copied. This was
copied as 444 and trying to overwrite it gives EACCES.

(christos)

lint: in code from included files, print stack trace

Previously, the standard NetBSD build generated several lint warnings in
lhash.h from OpenSSL, without providing any hint as to which file
actually included that header.  In cases like these, lint now interprets
the line number information in the preprocessor output from GCC to
reconstruct the exact include path to the file in question.

The program check-expect.lua had to be rewritten almost completely since
it assumed that all diagnostics would come from the main file.  In all
existing tests, this was true, but these tests did not cover all cases
that occurred in practice.  Now it records the complete location of the
diagnostic instead of just the line number.

(rillig)

Update Elftoolchain 'common/elfdefinitions.h' to upstream r3943.

(jkoshy)

tests/lint: refine comment and function name in test for pointer cast

In a typical NetBSD build, there are about 100,000 lint warnings.  About
50,000 of them are warning 247.  About 38,000 of these are from OpenSSL
and may be fixed by now.

(rillig)

lint: don't warn about cast between pointers to compatible structs

(rillig)

tests/lint: add test for struct pointer cast

(rillig)

new services and protocols

(christos)

refresh with latest

(christos)

update comment about the 'quirk' in we_mca_init_hook() - actually that is
just interrupt enable bit, so not a quirk at all; NFCI

info passed by Valery Ushakov from a guy running https://www.os2museum.com/wp/

(jdolecek)

Ticket #1245

(martin)

Pull up following revision(s) (requested by christos in ticket #1245):

crypto/external/bsd/openssl/lib/libcrypto/arch/sparc/modes.inc: file removal
crypto/external/bsd/openssl/dist/crypto/modes/gcm128.c: revision 1.12

Disable again the assembly version of gcm_ghash_4bit for the 32 bit sparc
since it uses ldx/stx.

Do not pretend we have GHASH asm code

(martin)

Do not pretend we have GHASH asm code

(martin)

Add usr/include/elfdefinitions.h and usr/include/sys/elfdefinitions.h

(martin)

Disable again the assembly version of gcm_ghash_4bit for the 32 bit sparc
since it uses ldx/stx.

(christos)

Redo r1.288: traverse the complete imported Elftoolchain tree during a build.

(jkoshy)

bozohttpd: fix argument type for functions from <ctype.h>

Found by the recently added check to lint (message 342).

ok mrg@

(rillig)

bozohttpd-small: fix typo in SRCS, fix targets dependall and lint

The additional ':' after 'main.c' had no effect on the compilation since
the suffix is removed when computing the list of object files.  The ':'
excluded main.c from the dependency computation and from lint.

By defining CPPFLAGS instead of CFLAGS, the default "-O2" steps in
again, and the proper flags are passed to lint, which did not work
before at all because it could not find an included file.

(rillig)

bozohttpd-small: fix error handling for unifdef

The second of the '$$?' was spelled only '$?'.  At the time where this
shell expression was evaluated, it had already been overwritten by the
preceding command '['.

(rillig)

Sort includes.

(simonb)

tc_init(): KASSERT that the timecounter hasn't previously been
initialised by checking the tc_next field.  Prevents nastly endless
loops in the timecounter code.

(simonb)

Traverse the Elftoolchain 'common' module before
the rest of the imported hierarchy.

(jkoshy)

Ensure that the 'libelf' directory is traversed before 'libdwarf'.

(jkoshy)

Update usage message to reflect reality.

(simonb)

Add a # to a %x printf format to get some 0x hex number prefixes.

(simonb)

audiocfg(1): add examples

(nia)

Revert the change to not build and install /usr/lib/dtrace/drti.o; this
is used by the ruby30-base package when compiled with the dtrace option
(enabled by default).

Problem found by ryoon@.

(simonb)

Update for pkgsrc README.html transition

(nia)

bump libevent

(christos)

new libevent

(christos)

fix incorrect version

(christos)

Merge local changes from libevent 2.1.8 and 2.1.12

(christos)

Basic dtrace trap support.

Mostly from FreeBSD.

(simonb)

Use NAL (nop-and-link) to get the current PC.

(simonb)

lint: sync comment with reality after renaming several functions

No functional change.

(rillig)

Remove sentence that has not been true since netbsd-6.

ioctl(RNDADDDATA) is not the only way to raise the entropy estimate;
privileged writes to /dev/random have the same effect.

(riastradh)

Clarify wording further based on private feedback.

(riastradh)

lint: for shift in C99 mode, do not warn about difference to pre-C90

C99 is too far away from traditional C to make this warning useful.
There are 3 different situations in which this warning is generated:

For '1 << (unsigned char)1', the result type is 'unsigned int' in
traditional C.  The result type is unsigned because at least 1 of the
operators is unsigned, and it is 'unsigned int' because the usual
arithmetic promotions are applied.

For '1 >> (long)1', as well as for '1 << (long)1', the result type is
'long' in traditional C since the usual arithmetic promotions are
applied.

Omitting this warning in C99 mode reduces the amount of lint warnings in
a typical NetBSD release build by approximately 6800 of 107000 total.

(rillig)

lint: test what happens for 'int << double'

I just wanted to see whether typeok_shift would be reached in this case,
to ensure that is_uinteger applies as expected.  It does.

(rillig)

lint: reduce indentation of typeok_shift

No functional change.

(rillig)

lint: add details to warning about too large shift amount

The previous message 'shift greater than size of object' was too short
to give reasonable hints, especially when the expressions involve
typedefs or macros.

(rillig)

lint: fix wrong warning about losing accuracy when converting to _Bool

(rillig)

Attempt to unbreak the build by reverting r1.288.

(jkoshy)

tests/lint: demonstrate wrong warning about losing accuracy

(rillig)

Traverse the complete imported Elftoolchain tree during a build.

(jkoshy)

Mirror upstream build steps: traverse 'common' before traversing 'lib'.

(jkoshy)

Prepare for <elfdefinitions.h> and <sys/elfdefinitions.h> to be installed
into ${DESTDIR}/usr/include.

(jkoshy)

Sync with upstream r3943.

(jkoshy)

Add files present in upstream revision r3943.

(jkoshy)

Ticket #1669

(martin)

Pull up following revision(s) (requested by simonb in ticket #1669):

bin/ps/print.c: revision 1.133

Fix the column width calculation for the lstart column if an empty
column header is specified.

Fixes bug pointed out by Ted Spradley in
https://mail-index.netbsd.org/netbsd-users/2021/04/05/msg026808.html .

(martin)

Tickets #1241 - #1244

(martin)

Pull up following revision(s) (requested by simonb in ticket #1244):

bin/ps/print.c: revision 1.133

Fix the column width calculation for the lstart column if an empty
column header is specified.

Fixes bug pointed out by Ted Spradley in
https://mail-index.netbsd.org/netbsd-users/2021/04/05/msg026808.html .

(martin)

Pull up the following, requested by kre in ticket #1243:

external/public-domain/tz/dist/Makefile        up to 1.1.1.30
external/public-domain/tz/dist/NEWS            up to 1.1.1.34
external/public-domain/tz/dist/TZDATA_VERSION  up to 1.24
external/public-domain/tz/dist/africa          up to 1.1.1.25
external/public-domain/tz/dist/asia            up to 1.1.1.28
external/public-domain/tz/dist/australasia      up to 1.1.1.21
external/public-domain/tz/dist/backward        up to 1.1.1.12
external/public-domain/tz/dist/backzone        up to 1.1.1.20
external/public-domain/tz/dist/etcetera        up to 1.1.1.5
external/public-domain/tz/dist/europe          up to 1.1.1.30
external/public-domain/tz/dist/leap-seconds.list up to 1.1.1.15
external/public-domain/tz/dist/leapseconds      up to 1.1.1.18
external/public-domain/tz/dist/leapseconds.awk  up to 1.1.1.12
external/public-domain/tz/dist/northamerica    up to 1.1.1.27
external/public-domain/tz/dist/theory.html      up to 1.1.1.12
external/public-domain/tz/dist/version          up to 1.1.1.21
external/public-domain/tz/dist/ziguard.awk      up to 1.1.1.6
external/public-domain/tz/dist/zone.tab        up to 1.1.1.19
external/public-domain/tz/dist/zone1970.tab    up to 1.1.1.21
doc/3RDPARTY apply patch

Import tzdata2020f from ftp://ftp.iana.org/tz/releases/tzdata2020f.tar.gz

Release 2020f - 2020-12-29 00:17:46 -0800

    No changes to tzdata, just to a part of the build procedure
    not used on NetBSD

Release 2020e - 2020-12-22 15:14:34 -0800

    Volgograd switched to Moscow time on 2020-12-27 at 02:00.

    Correct many pre-1986 transitions, fixing entries originally
    derived from Shanks.  The fixes include changes to:
      Australia, Bahamas, Bermuda, Belize, Ghana, Israel and Palestine,
      Kenya and adjacent, Nigeria and adjacent, Seychelles, Vanuatu

    Australia/Currie has been moved to the 'backward' file and its
    corrected data moved to the 'backzone' file.

    To better match legislation in Turks and Caicos, the 2015 shift to
    year-round observance of -04 is now modeled as AST throughout before
    returning to Eastern Time with US DST in 2018, rather than as
    maintaining EDT until 2015-11-01.

(martin)

Pull up following revision(s) (requested by kre in ticket #1242):

bin/sh/input.c: revision 1.72
bin/sh/exec.c: revision 1.55

PR bin/55979

This fixes the MSAN detected reference to an unitialised variable
(an unitialised field in a struct) which happens when a command is
not found after a PATH search.
Aside from skipping some known to be going to fail exec*() calls
in some cases, the setting of the relevant field is irrelevant,
so this problem makes no practical difference to the shell, or any
shell script.

XXX (maybe) pullup -9

PR bin/55979

Correctly handle (ie: ignore completely) \0 chars (nuls) in the
shell command input stream (script, dot file, or stdin).
Previously nul chars were ignored correctly in the line in which
they occurred, but would cause trailing chars of that line to reappear
as the start of the following line.  If there was just one \0 skipped,
this would generally result in an extra \n in the sh input, which in
most cases has no effect.  With multiple \0's in a single line, more
of the end of that line was duplicated into the following one.  This
usually manifested as a weird "command not found" error.

Note that any \0 chars in the sh input make the script non-conforming,
so fixing this is not crucial (no \0's should really ever be seen) but
it was an obvious bug in the code, which was attempting to ignore nul
chars (as do many other shells), so let it be fixed.

XXX pullup -9

(martin)

Pull up following revision(s) (requested by isaki in ticket #1241):

sys/dev/audio/audiobell.c: revision 1.4

Fix and improve the buffer length calculation to avoid zero length
even if blk_ms is small.

This fixes PR kern/56059.

(martin)

The location arg of db_disasm() is a db_addr_t, not a vaddr_t.

(simonb)

Remove duplicate db_disasm() prototype.

(simonb)

Include <ddb/db_interface.h> to get ddb's db_disasm() prototype.

(simonb)

Fix a typo, remove a useless blank line.

(simonb)

Revert rev 1.278 which tried to call ctfmerge only once - this has
caused kernels with embedded symbol tables to explode in size.

(simonb)

- dedup code
- add a safe_strftime() to handle error cases

(christos)

lint: move check for strict bool mode into separate file

No functional change.

(rillig)

If we're going to print a number in hex, at least put a 0x in front of
it so we can cut'n'paste it into gdb directly.  This has only annoyed
me for 25 or so years...

Wrap a long long while here.

(simonb)

sizeof(*var) instead of sizeof(type)

(simonb)

sizeof(*var) instead of sizeof(type)
Call kmem_free() with size of data being freed.

(simonb)

Clarify security model of rndctl -S files.

(riastradh)

sizeof(*var) instead of sizeof(type)

(christos)

Implement nvmm_vcpu::stop, a race-free exit from nvmm_vcpu_run() without
signals. This introduces a new kernel and userland NVMM version indicating
this support.

Patch by Kamil Rytarowski <kamil@netbsd.org> and committed on his request.

This is the missing libnvmm part I forgot to include in the origional commit.

(reinoud)

Call kmem_free() with the size of the thing we are freeing.  Fixes panic
when unloading the ktrace module on MIPS.

(simonb)

Check the CTF magic number in an endian friendly way (and don't use
magic numbers to check the magic number!).

(simonb)

Define the CTF ELF section header magic number.

(simonb)

Fix the column width calculation for the lstart column if an empty
column header is specified.

Fixes bug pointed out by Ted Spradley in
https://mail-index.netbsd.org/netbsd-users/2021/04/05/msg026808.html .

(simonb)

We only need -Wno-format-y2k for print.c .

(simonb)

Fix ATF failures, sorry.

(knakahara)

make: reduce verbosity of the -dv debug logging for standard cases

The verbosity was already removed from LogBeforeApply, now it is
consistent between LogBeforeApply and LogAfterApply.

(rillig)

tests/libcurses: fix names of over-the-wire data types

The test 'mvscanw' reported that it would send '%s' as 'numeric', which
was rather suspicious.

(rillig)

tests/libcurses: clean up table of input functions

The previous "table" was an insult to any reader.  It was unsorted,
listed the functions shuffled, and was not even formatted consistently.

No functional change.

(rillig)

tests/libcurses: don't waste time calling strlen needlessly

(rillig)

audiosearch(): Remove a stray CFARG_LOCATORS tag.

(thorpej)

Since there is a -t option, and the option itself is documented, there
doesn't seem to be any reason to exclude ``t'' from the usage summary.

(pgoyette)

Don't use /usr/bin/time (it is not portable)

(christos)

Fix build w/o options SUN4V.

(nakayama)

make: in debug log, add space between scope and variable name

Without this space, the debug log looked more like line noise, even
though the only punctuation was a single innocent ':'.  From a make
user's perspective, the variable name is a word of its own and should
not be visually glued to its namespace.

(rillig)

make: omit unnecessary details from -dv debug log

When an expression is based on a defined variable, it does not matter
whether the evaluation mode is "eval" or "eval-defined", therefore omit
these details to reduce confusion.

(rillig)

make: be more verbose in -dv debug logging

The previous log output was too brief to be understandable.  Give more
hints by describing each part of the expression when evaluating a
modifier.  Distinguish between parse-only mode and eval mode since in
parse-only mode most of the details are irrelevant.

(rillig)

make: clean up debug logging for ':M' and ':N'

Using square brackets as quotes was confusing since patterns can contain
square brackets themselves.

The debug logging for VarMatch was a bit too detailed.  Having the
"before" and "after" states is enough for all practically relevant
cases.

(rillig)

sun4v: Ignore spurious ldc CTRL/ACK/VERS messages (do not reset the connection anymore). Fixes occationals stalls when vdsk uses the ldc service. Observed on both T2000 and T5 host systems

(palle)

bind: remove unnecessary local modifications

No functional change.

(rillig)

bind: remove non-canonical redundant CONSTCOND comments

Since lint1/tree.c 1.202 from 2021-01-31, lint no longer needs the
/*CONSTCOND*/ for do-while-0 "loops".

No functional change.

(rillig)

bind: remove unnecessary CONSTCOND comments

Since lint1/tree.c 1.202 from 2021-01-31, lint no longer needs the
/*CONSTCOND*/ for do-while-0 "loops".

No functional change.

(rillig)

bind: remove obsolete local modifications

The duplicate include has been added upstream, further up in the file.

Since lint1/tree.c 1.202 from 2021-01-31, lint no longer needs the
/*CONSTCOND*/ for do-while-0 "loops".

(rillig)

bind: remove workaround for bugs in lint

The bugs have been fixed in lint1/init.c 1.179 from 2021-03-30.

(rillig)

Some QED instructions are included in MIPS32 and MIPS64 instruction sets.
Update a few comments.

(simonb)

Fix cut'n'paste typo - OP_CVM_DMUL is dmul, not baddu.

(simonb)

Tidy up NOP disassembly, handle "pause" as well.

(simonb)

s/nitems/__arraycount/

(yamaguchi)

Include opt_inet.h for INET6

(yamaguchi)

gcc/gas also emits "or ...,zero" as well as "addu/daddu ...,zero" for a
"move" pseudo instruction.  Disassemble the "or" case as a "move" too.

(simonb)

Allow disassembly in XKSEG for LP64 kernels.  Can now x/i on modules
with an N64 kernel.

(simonb)

For bc{0,1,2}{t,f} check for the TRUE value not the MASK value (even
though they're the same).

(simonb)

Move the ctfmerge call from SYSTEM_LD_TAIL (used by both STAGE1 and STAGE2)
to SYSTEM_LD_TAIL_STAGE2 only.  ctfmerge is slow enough that just calling
it once is enough.

(simonb)

Don't call strncmp() where the length arg is the size of a pointer
instead of the max string length.  Switch to strcmp() - both strings
are known nul-terminated.

Thanks tnn@ (and clang!).

(simonb)

lint: inline macro in check for <ctype.h> functions

No functional change.

(rillig)

lint: warn about for wrong type cast in argument to ctype.h functions

The argument to most of the functions from <ctype.h> "shall either be
representable as an 'unsigned char' or shall equal the value of the
macro EOF".

When confronted with the infamous warning 'array subscript has type
char', there are enough programmers who don't know the background of
that warning and thus fix it in a wrong way.  Neither GCC nor Clang
explain its warning to target these programmers.

Both GCC and Clang warn about 'array subscript has type char', but they
ignore the other requirements of the <ctype.h> functions, even though
these are in the C standard library.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94182
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95177
https://stackoverflow.com/a/60696378

(rillig)

lint: warn about for wrong type cast in argument to ctype.h functions

The argument to most of the functions from <ctype.h> "shall either be
representable as an 'unsigned char' or shall equal the value of the
macro EOF".

When confronted with the infamous warning 'array subscript has type
char', there are enough programmers who don't know the background of
that warning and thus fix it in a wrong way.  Neither GCC nor Clang
explain its warning to target these programmers.

Both GCC and Clang warn about 'array subscript has type char', but they
ignore the other requirements of the <ctype.h> functions, even though
these are in the C standard library.

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=94182
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=95177
https://stackoverflow.com/a/60696378

(rillig)

tests/lint: one comment per expected diagnostic

This makes it possible to check for diagnostics that contain commas.

(rillig)

config_match() -> config_probe().  It's a little over-loaded here because
we're mixing direct and indirect in the same place, but that will be
addresed at a later time.

(thorpej)