sys/ktrace.h: fix off-by-one error in snprintb for ktrace flags

(rillig)

error: disable lint's strict bool mode when building with Clang

The Clang preprocessor does not mark sections from system headers.
Lint's strict bool mode relies on these markers to allow the functions
from <ctype.h> to be used as 'bool', even though their declared return
type is 'int'. Without these markers, lint complains that the "right
operand of '&&' must be bool, not 'int'". Until this is fixed in lint,
disable strict bool mode.

(rillig)

lint: in C23 mode, allow storage classes in compound literals

(rillig)

lint: add details to message about too many initializers

(rillig)

lint: sync grammar rule names with C11 and C23

(rillig)

lint: sort grammar rules according to the order they appear in C23

(rillig)

lint: in C23 mode, support the nullptr constant

(rillig)

lint: in C23 mode, support the keywords 'bool', 'false' and 'true'

(rillig)

tests/lint: show that in C23 mode, bool is not yet defined

The tests in C11 and C23 mode look the same right now but will change
soon.

The warnings in the C11 test disappeared because after the first error,
warnings about unused variables are suppressed by check_variable_usage,
as they are often wrong.

(rillig)

lint: increase debug logging for declarations

All changes to the global variable 'dcs' are tracked now, to help
identify the cause of the failing tests in expr_sizeof and
gcc_attribute_aligned.

While here, test more invalid type combinations in typedefs.

(rillig)

mktemp.3: mkdtemp is no longer nonstandard

Reported by Aleksey Cheusov on tech-userlevel.

(rillig)

tests/lint: fix supposedly platform-independent type definitions

No idea where I got the previous type definitions from.  The typedef
names looked just too convincing to actually check the underlying types.

(rillig)

tests/lint: skip test for sizeof struct on 32-bit platforms

Even though the test only uses fixed-size types, lint's computed size of
the resulting struct differs between i386 (80) and x86_64 (112).  Both
are wrong, probably due to the unrelated struct declaration above, as
already mentioned in the comments.

(rillig)

lint: measure the alignment in bytes, not bits

While measuring the alignment in bits makes sense when building a struct
type with bit-fields, in all other places it is more confusing than
helpful.

The only visible change is that in debug mode, the format of type sizes
and alignment changed.  Since the size of all complete types is a
multiple of a byte (as defined in the C standard), sizes and alignments
are reported in bytes as well.  Only while a struct is being built, the
type size may include an additional '+x' for the bits of a bit-field.

(rillig)

tests/lint: demonstrate wrong struct size calculation

(rillig)

parsedate.3: resolve contradictory values for 'next'

(rillig)

lint: make 'offsetof(t, array-member)' a constant expression

The macro 'offsetof(t, m)' already expanded to a constant expression for
scalar members but not for arrays.  This was because the macro expanded
to '(size_t)(((t *)0)->m)', which lint internally represents as
'addr(indir(ptr(0) + offset(m)))', and build_address simplifies
'addr(indir(x))' to 'x' if the types match.  The types only match for
scalar types though, but not for arrays.

When build_address happens, the type information is incomplete,
therefore 'offsetof(t, array)' has to be simplified at a later point.

(rillig)

tests/lint: test large enum constants and offsetof with array members

(rillig)

lint: fix size of struct with large alignment

Lint now successfully passes all compile-time assertions in the amd64
kernel that deal with struct sizes.

(rillig)

sys/cdefs.h: pass __aligned to lint

Lint could parse _Alignas and __attribute__((__aligned__(4))) previously
but simply ignored them. Since today, they affect the layout of struct
and union.

(rillig)

lint: support _Alignas and __attribute__((__aligned(4)))

(rillig)

lint: fix warning about out-of-bounds bit-field value

(rillig)

lint: demonstrate wrong warning about out-of-range bit-field

(rillig)

time.3: clarify that *tloc is always set if tloc != NULL

(rillig)

setmode.3: fix typos

(rillig)

execve.2: fix typo in markup

(rillig)

tests/cd9660: add debug info to the file list

(rillig)

make: don't reallocate memory after evaluating an expression

When an expression is evaluated, the resulting text is short-lived in
almost all cases.  In particular, the compaction neither affects the
target names nor the global variable values, which are the prime
candidates for permanent memory usage.

(rillig)

tests/cd9660: replace compressed blob with readable hexdump

This test is skipped in most circumstances because it creates a file
whose apparent size is 4.5 GB.  It's an ISO 9660 image though,
containing mostly null bytes.  Nevertheless, tmpfs doesn't allow such a
big file to be created, so this test is skipped in settings where /tmp
is on a tmpfs.

If the test is run, the ISO image is uncompressed, which takes several
minutes.  Replace bzip2 with direct file creation from a hex dump of
that disk image, which is easier to inspect manually and also faster by
about 3 magnitudes.

(rillig)

tests: replace deprecated '-s eq:...' with '-s exit:...'

(rillig)

make: fix comment about forcing a use-after-free

The previous expression didn't cause any bug, as the modifier
':@VAR@loop@' changed the value of the expression, thus making the
expression independent from the variable value.

Instead, the variable needs to be deleted from within an indirect
modifier, and that modifier needs to evaluate to an empty string, thus
doing nothing and preserving the original expression value.

(rillig)

make: clean up, test .NOPATH

Trim down the comments in the archive module, as they mainly repeated
the code.  Trim down the binary code size in the archive module, as it
is rarely used.

In Var_Parse, delay two variable assignments until they are actually
needed.

(rillig)

tests/make: test detection of static library files

(rillig)

make: simplify freeing of lists

(rillig)

lint: converting a null pointer to another pointer type is not narrowing

(rillig)

lint: add query for conversion from void pointer to other pointer

(rillig)

mips: fix syntax error in LDBL_MAX (since 2011)

(rillig)

BUILDING: fix typo

(rillig)

dri: disable lint

(rillig)

make: in parallel mode, print the directory in which a job failed

When multiple targets run in parallel, the "stopped in" line may be
several lines away from the "Failed target" line, making them hard to
correlate.

(rillig)

gallium: disable lint

(rillig)

tests/cp: clean up

Replace the deprecated "eq:0" with "exit:0", remove redundant "-o empty"
and "-e empty".

(rillig)

tests/cat: clean up

Multiple arguments to atf_set are joined by spaces, there's no need for
an extra space.

The exit status on success must be 0, so don't ignore it.

Remove the unnecessary shell wrapper, as no redirection is going on.

(rillig)

CHANGES: fix typo

(rillig)

makefs: fix out-of-bounds fsnode count in fsnode_sort

Found by running './makefs img.dat cd9660'.

While here, apply more KNF.

(rillig)

make: clean up comments, code and tests

(rillig)

make: trim down code for parsing the :gmtime and :localtime modifiers

The :gmtime and :localtime modifiers are not used often and thus are not
time-critical. Exchange the custom code that parses an integer from a
substring for an additional memory allocation.

Thanks sjg@ for suggesting to avoid the custom parsing code.

(rillig)

libntf: make MKREPRO timestamp compatible with NetBSD 10

In NetBSD 10, make(1) cannot handle :gmtime arguments that are
expressions, resulting in the error message "Unknown modifier '1'".

(rillig)

make: fix out-of-bounds read when evaluating :gmtime and :localtime

The function TryParseTime takes a pointer to a string, but the LazyBuf
returns a Substring, which is not guaranteed to be null-terminated or
delimited.  In TryParseTime, calling strtoul on the Substring read past
the end of the substring.

Noticed in the NetBSD build in libntp, where the :gmtime modifier is
used in two places with the same timestamp value, of which the first was
evaluated correctly and the second wasn't.

The bug was introduced in var.c 1.1050 from 2023-05-09, when the
argument of the :gmtime and :localtime modifiers was allowed to be an
expression instead of an integer constant.

(rillig)

UPDATING: remove not-so-recent entries

(rillig)

{usr.,}{s,}bin: replace LINT_SUPPORTED with the standard NOLINT

While here, re-enable lint in those cases where lint was skipped due to
a bug in interpreting abstract types, which was fixed in cgram.y 1.469
from 2023-08-02.

(rillig)

build.sh: fix typos in usage message

(rillig)

make: provide more context information for parse/evaluate errors

(rillig)

libntp: clean up MKREPRO_TIMESTAMP handling

NetBSD's make has built-in support for formatting timestamps, so use
that instead of relying on an external tool.  The month name is still
always in the C locale, and possible errors are reported in the affected
line, due to the ':=' assignment operator.

Without the ':=' assignment operator, the intermediate variable would
not be necessary, but in that case, make's error handling is broken and
unspecific.

(rillig)

tests/lint: show how to trigger message 207

(rillig)

make: make string matching platform-independent

Previously, whether the character range '[a-辰]' matched, depended on the
signedness of the plain 'char' type.  Since make operates on byte
strings and does not support UTF-8 or other multi-byte character
encodings, this edge case is not expected to occur in practice.

No change in the unit tests as this edge case is not covered by tests.

(rillig)

make: add debug logging for .if and .for lines in -dp mode

This helps track down in which line a condition is evaluated.

(rillig)

tests/fmtcheck: show that fmtcheck does not support "%2$s"

(rillig)

lint: clean up and speed up the check for snprintb

(rillig)

lint: in snprintb, warn about all escaped characters in descriptions

(rillig)

ed: fix inconsistency in comment

(rillig)

snprintb.3: provide examples for hexadecimal character escapes

Suggested by uwe@, in reaction to the previous commit, which preferred
octal in the examples. Hexadecimal escapes are more familiar to most
programmers, and the chance of mistaking \x14 for decimal 14 is less
than the chance of mistaking octal \014 for decimal 14.

(rillig)

sparc: fix typos and omissions in PSTATE_BITS and ECC_AFR_BITS

Fixes PR 57869.

(rillig)

snprintb: reject empty bit descriptions and wrongly placed defaults

(rillig)

snprintb.3: clean up formatting and wording, prefer octal in examples

Using hexadecimal character escapes requires separate string literals if
the description starts with one of the letters A-F; octal character
escapes have at most 3 digits, reducing ambiguity.

(rillig)

snprintb: reject combinations of 'f' with ':' as well as 'F' with '='

These combinations would lead to garbled output.

(rillig)

snprintb: reject empty descriptions

In cases where the snprintb output is garbled, it is not trustworthy, so
make sure the mistakes in the bitfmt are fixed early.

(rillig)

flex.1: fix single-bit error in contributor name

(rillig)

sparc/fpsetround: fix the nearby signed integer overflow as well

Same as for sparc64 a few days ago.

(rillig)

tests/make: pass PATH onto child processes

This fixes the tests on some Cygwin variant where the shell does not
initialize the PATH environment variable when it's missing.

(rillig)

tests/make: remove test for overly long chdir argument

On Cygwin, the path '/././..././' is normalized before being passed to
the child 'make' process. Since overly long pathnames are not required
to be supported on all platforms, remove the test.

(rillig)

make: remove unreachable code in handling .for loops

(rillig)

make: exit immediately after reading a null byte from a makefile

The chance of other garbage bytes in such a file is just too high.

(rillig)

tests/snprintb_m: test null-terminated output in error case

While here, clean up the buffer handling for the visualized array
content in case of a failed test.

(rillig)

snprintb: remove redundant memset in kernel mode

The provided buffer is already null-terminated by finish_buffer, even in
error cases, there is no need to repeat the same work.

(rillig)

lint: merge function call operators 'CALL' and 'ICALL'

(rillig)

lint: document which fields are not reset when starting a new type

Setting all visible fields to their null value seemed as if the whole
object were reset.

(rillig)

lint: in the query about implicit conversions, ignore casts

(rillig)

lint: add query for implicit integer-to-floating conversion

(rillig)

lint: do not convert array subscripts from size_t to ptrdiff_t

The C standards do not specify a fixed type for an array subscript, it
just has to be an integer type.  Previously, query 4 fired for the
ubiquitous expression 'ptr[sz]' when sz had type 'size_t'.

The test platform_ilp32_long is unaffected by this change, as the
integer constant 0x80000000 has type 'unsigned int', while size_t is
'unsigned long' on those platforms, and even though the types 'unsigned
int' and 'unsigned long' have the same value space, there's still a
conversion, at least for now.

(rillig)

lint: reword messages about array subscripts to sound more natural

(rillig)

lint: clean up

(rillig)

lint: fix wording of warning about bit-field initializer

(rillig)

moused: remove undocumented and unused option 'C'

(rillig)

lint: clean up

(rillig)

lint: add missing assignment to $$ in grammar

Byacc and Bison both provide this assignment for all actions, whether
default or not, but the wording in POSIX doesn't guarantee this.

(rillig)

lint: clean up; extend overflow test

(rillig)

lint: don't use 'long' in diagnostics

The size of 'long' differs between 64-bit and 32-bit platforms.
Eliminate this possible platform-dependency.

(rillig)

tools/Makefile: clean up TOOLDIR validation

At the point where tools/Makefile is loaded, TOOLDIR doesn't have to
exist yet, it will be created later.  Remove the redundant quotes from
the .error messages.

(rillig)

apei: fix typos in comments and snprintb bitfmt

(rillig)

apei: fix typos in comments

(rillig)

t_strptime: fix typo in test description

(rillig)

libm/s_logl: suppress lint warnings

Seen on sparc64.

(rillig)

lint: fix warnings about loss of accuracy on bit-field operations

(rillig)

tests/lint: demonstrate wrong warnings about lossy bit field operations

(rillig)

lint: rename snprintb 'directives' to 'conversions'

This aligns the terminology with the snprintf function.

(rillig)

snprintb: mark the end of the buffer if the buffer is too small

This avoids confusion in case the buffer ends with an incomplete number.

(rillig)

sparc64/fpsetround: avoid shifting into the sign bit

Lint had warned about the constant expression '0x03 << 30' but not about
the structurally equal nonconstant expression '(rnd_dir & 0x03) << 30'.

No binary change.

(rillig)

lint: keep invalid arguments in function calls

Previously, arguments of incomplete type or 'void' cleared all arguments
of the function call expression, requiring extra checks in later checks.

Invalid function calls are now exported to the .ln files, but that's
irrelevant in practice as these invalid function calls make lint1 fail,
after which xlint removes the .ln file.

(rillig)

stat: don't allow numeric formatting flags on strings

Calling snprintf with "%+s" invokes undefined behavior.

(rillig)

tests/stat: test the left-aligned and right-aligned 'S' format

(rillig)

stat: fix lint warning about constant argument to '!'

No binary change.

(rillig)

tests/lint: ensure that lint correctly decays array parameter types

(rillig)

lint: trim down the check for snprintb formats

(rillig)

tests/lint: extend test for previously wrong warning about bit-fields

(rillig)

lint: fix warning about loss of conversion for unsigned bit-fields

Since decl.c 1.180 from 2021-05-02.

(rillig)

tests/lint: demonstrate wrong warning when comparing a bit-field

Since decl.c 1.180 from 2021-05-02, which allowed arbitrary integer
types to be used as the underlying type for bit-fields in GCC mode.

(rillig)

lint: add details to the message about integer overflow

Having only the operator was too unspecific to be actionable, so add the
actual numbers and the data type.

(rillig)

kdump: keep the comment with its corresponding code

No binary change.

(rillig)

postinstall: fix parameter order in usage message

(rillig)

compiler_rt: allow signed bit shifts for __negv

Standard C defines '1 << 31' as undefined behavior, but
https://gcc.gnu.org/onlinedocs/gcc/Integers-implementation.html allows
it for GCC.

(rillig)

sparc: fix snprintb formats for SFSR_BITS

(rillig)

lsi64854reg: fix snprintb formats DDMACSR_BITS and PDMACSR_BITS

(rillig)

powerpc/hid: fix snprintb format for HID0_970_BITMASK_U

(rillig)

sparc/sbusreg: fix snprintb format for SBUS_AFSR_BITS

(rillig)

sparc/vmereg: fix snprintb format VMEBUS_AFSR_BITS

(rillig)

lint: clean up tree matcher for snprintb calls

(rillig)

lint: saturate signed integer overflow

In array address calculations, this prevents a 'array subscript cannot
be negative' for large array subscripts.

(rillig)

lint: fix integer overflow detection

Previously, an unsigned operation that had a negative result went
undetected in a few cases. Now, all results that are not representable
by their type are considered overflows.

The implementation of signed shift-right had been wrong for a few
commits.

(rillig)

lint: clean up check for overflow in integer constants

(rillig)

lint: detect more cases of integer overflow in constant expressions

For unsigned integers, detect when 'a + b' wraps around.

(rillig)

lint: split integer overflow check into separate functions

The checks for unsigned and signed integers differ for each operator, so
there's no point having both parts in the same function.

(rillig)

tests/lint: enable test for integer overflow in array index

(rillig)

lint: remove wrong warning about overflow in unary '-' for unsigned

(rillig)

lint: fix integer overflow in integer overflow check

(rillig)

tests/lint: test integer overflow when folding constants

The test is still incomplete, yet it has discovered several bugs that
are worth fixing.

(rillig)

lint: in check for integer overflow, sort operators

(rillig)

lint: fix excessive overflow warning after division by zero

(rillig)

tests/lint: demonstrate integer overflow on lp64 platforms

(rillig)

tests/lint: test check for out-of-bounds array index

(rillig)

lint: merge duplicate code for checking array index

(rillig)

lint: inline accessor macros for tnode_t

(rillig)

lint: inline accessor macros for type_t

(rillig)

lint: clean up comments, use typedefs

(rillig)

lint: internally store case label values in order of appearance

(rillig)

lint: remove unneeded checks for left and right operands

(rillig)

lint: use fewer struct keywords

(rillig)

postinstall: fix endless loop (since 2024-03-07)

(rillig)

cpuctl: fix i386 bit descriptions for CPUID_SEF_FLAGS1

warning: non-printing character '\31' in description
    'BUS_LOCK_DETECT""b\31' [363]

(rillig)

ifconfig: fix agr status

Previously, when the interface was collecting, its status was reported
as '<COLLECTING,DISTRIBUTING>', even when it was not distributing.

sbin/ifconfig/agr.c(170): warning: 'b\0DISTRIBUTING\0' overlaps earlier
    'b\0COLLECTING\0' on bit 0 [376]

(rillig)

tests/make: clean up test for local scope variables

Use the same style of quotes for both kinds of variables.  To make the
variable values more easily comparable, write them to a single line.
Add the output to the 'expect' lines.

(rillig)

snprintb: shrink code size, both in source and binary

(rillig)

snprintb: error out on unknown new-style formatting directive

(rillig)

lint: clean up string parsing and snprintb check

(rillig)

lint: warn about escaped snprintb directive

Repurpose message 362, as the previous version was redundant since null
bytes in old-style formats are already covered by message 371 (bit
position out of range) and 377 (redundant '\0' at the end).

(rillig)

lint: fix warning about "empty" single-letter snprintb descriptions

(rillig)

lint: check for unreachable bits and fields in snprintb formats

While here, clean up a few existing checks.

(rillig)

lint: check snprintb formats for overlapping bits and fields

(rillig)

lint: remove custom wrappers around <ctype.h> functions

(rillig)

lint: fix misleading initializer for string iterator

The field 'start' marks the start of the previous matching character,
not the current iterator position.

No binary change.

(rillig)

lint: test format strings from snprintb calls

The functions snprintb and snprintb_m are specific to NetBSD, and their
format strings are tricky to get correct.  Provide some assistance in
catching the most common mistakes.

(rillig)

lint: test format strings from snprintb calls

The functions snprintb and snprintb_m are specific to NetBSD, and their
format strings are tricky to get correct.  Provide some assistance in
catching the most common mistakes.

(rillig)

make: fix type mismatch in lint's strict bool mode (since today)

(rillig)

make: remove test variant for NO_REGEX

The compile-time toggle was removed in var.c 1.1099 from 2024-02-07.

(rillig)

tests/lint: remove redundant documentation

(rillig)

lint: fix type error in strict bool mode (since yesterday)

(rillig)

lint1: remove redundant type table for integer constant suffixes

(rillig)

snprintb.3: fix typo

(rillig)

parsedate.y: remove outdated comment

The number of shift/reduce conflicts has grown to 16.

(rillig)

tests/snprintb: clean up tests

Always write the value to be formatted in hexadecimal, to make it easily
distinguishable from the buffer size and maximum line length.

Use consistent wording in the comments of the test cases. Be stricter
about mistakes in a format.

Fix some wrong numbers in the snprintb_m tests for limited line length.

(rillig)

snprintb: clean up

Use consistent data types for buffer positions and lengths, to avoid
type casts.

(rillig)

snprintb: allow non-ASCII descriptions on all platforms

Previously, these descriptions were only allowed on platforms where
plain 'char' is unsigned. On platforms where plain 'char' is signed,
they invoked undefined behavior or terminated the output early.

(rillig)

snprintb: always null-terminate output

Always null-terminate the output in the buffer, even in error cases. The
wording in the manual page has been promising this since 2008. For
snprintb_m, ensure that the output is terminated with two null
characters, to gracefully handle situations in which the caller does not
check whether snprintb returned an error.

If the buffer size is zero, allow the buffer to be a null pointer,
analogous to snprintf.

Fix an out-of-bounds memory read if the bitfmt ends with a '*' directive
(since today).

In the tests, merge the helper functions for snprintb, snprintb_m, as
they were similar enough.

Fix a few 'line_max exceeded' tests, ensuring that they output a '#'
marker, and that the 'complete' tests don't.

(rillig)

snprintb: error out on out-of-bounds bit shifts

Previously, these invoked undefined behavior, now they lead to an early
return. An example of out-of-bounds bit number is in SCZ_PCICTRL_BITS.
Bit fields that extend beyond the msb are still allowed.

Allow 'f' and 'F' to have fields that are 64 bits wide. This only makes
sense when the field starts at bit 0.

Remove the unused 'val_len', it was only needed before snprintb.c 1.20.

(rillig)

tests/snprintb: test '=' and '*' directives that can never match

(rillig)

snprintb.3: sync examples with reality

(rillig)

snprintb_m: limit length of generated strings

The manual page promises that the 'max' argument limits the length of
the generated strings, so don't generate any strings that are longer
than that limit. Mark incomplete strings with a trailing '#' to make
them easily recognizable.

(rillig)

tests/snprintb: fix out-of-bounds memory read (since 2024-02-16)

Before t_snprintb.c 1.20, the buffer size was required to be greater
than zero. Allowing the buffer size to be zero led to buf[-1] being
checked. On amd64, that byte happened to be 0, on i386 it didn't.

Fixes PR lib/57951.

(rillig)

snprintb: fix how named bit-fields are split into multiple lines

(rillig)

tests/snprintb: add more tests, especially for snprintb_m

(rillig)

mman.h: fix snprintb description for alignment 2^60

(rillig)

snprintb: convert macros to local functions

Let the compiler decide whether to inline the functions; allow stepping
through the code in a debugger.

(rillig)

snprintb: do not modify bufsize when producing multiple lines

(rillig)

snprintb: eliminate two local variables, allow zero-size buffer

Like snprintf, the buffer size may be zero. Unlike snprintf, the buffer
must not be NULL.

(rillig)

snprintb: use size_t for buffer sizes and positions

(rillig)

snprintb: fix integer overflow when writing past a small buffer

Previously, snprintb returned -1 in this case, assuming that the
snprintf used in FMTSTR validates against an overly large buffer size.

(rillig)

snprintb: use unsigned integers for parsing the bitfmt

(rillig)

tests/snprintb: fix test for 8-bit field value

The previous version tested the behavior on a platform with signed
'char' before the portability fix.

(rillig)

snprintb: fix '=' and ':' for 8-bit values on platforms with signed char

Previously, '=' and ':' worked only on platforms where plain 'char' is
unsigned. On platforms where plain 'char' is signed, only 7-bit values
worked.

(rillig)

snprintb: eliminate a few local variables

(rillig)

snprintb: rename local variables

The single-letter variables 't', 's', 'l' and 'c' were too hard to
decipher.

The variable 'f_len' was used for two independent purposes.

Use a narrow scope for some variables, to avoid having to keep track of
22 individual variables at the same time.

No binary change.

(rillig)

snprintb: clean up

Remove redundant parentheses and casts.

Indent statement-like macros consistently, use separate lines for each
statement, add parentheses to macro definitions.

Remove CONSTCOND comments as lint doesn't need them anymore.

No binary change.

(rillig)

tests/snprintb: clean up existing tests, add more tests

Due to the check that any bytes beyond the expected output must be
unmodified, there's no need anymore to explicitly write the "ZZZ" at the
end of the expected output. While here, remove the redundant trailing
"\0".

Add more tests to cover possible situations where an out-of-bounds write
may have occurred. In some cases, the line length specified in
snprintb_m is exceeded.

(rillig)

snprintb: fix string termination (since today)

In the previous commit, I had accidentally only run the tests for
snprintb_m but not those for snprintb, thereby missing a newly
introduced bug that would not null-terminate the resulting strings.

Add more tests to cover similar situations in which the buffer is too
small to contain the complete output.

(rillig)

snprintb: rename buflen to bufsize, following the wording in snprintf

(rillig)

snprintb: fix out-of-bounds write

(rillig)

tests/libutil/snprintb_m: add tests for small line length

(rillig)

lint: clean up variable names, parameter order, comments

No functional change.

(rillig)

lint: clean up redundant braces

No functional change.

(rillig)

lint: clean up comments, add debug output for Bison

(rillig)

tests/lint: sync test for integer constant type on ILP32 platforms

The test was broken since lex.c 1.214 from today.

(rillig)

lint: use consistent variable names, reduce code for reading a byte

No functional change.

(rillig)

lint: unify rules for determining the type of an integer constant

Previously, in traditional C mode, large decimal numbers were treated as
unsigned, which disagreed with the book from 1978.

(rillig)

make: remove redundant comments

No functional change.

(rillig)

make: remove unneeded conditional-compilation toggles

The toggles INCLUDES, LIBRARIES, POSIX, SYSVINCLUDE, SYSVVARSUB,
GMAKEEXPORT and SUNSHCMD are no longer needed, they were unconditionally
set.

The toggle NO_REGEX was configurable from the command line, but
disabling it would result in various error messages about the unknown
':C' modifier.

OK sjg@.

(rillig)

lint: tab-align message numbers in err.c

By replacing block comments with end-of-line comments, the comments take
up less space and thus no longer require to be indented by 6 spaces.

The messages and their comments are used in 3 places: the manual page
lint.7, the err-msgs.h header for debug mode, and check-msgs.lua to
verify that the comments above the message IDs correspond to the actual
messages.

No functional change.

(rillig)

lint.7: remove implementation details from message list

From a user's perspective, it's irrelevant whether a lint message is
generated using '%s' or '%.*s'; same for the integer widths, as they are
platform-dependent.

(rillig)

lint: make function call arguments directly accessible

Previously, the arguments of a function call expression were arranged in
a linear tree structure, from right to left.  To allow easier access to
the arguments, store them in an array instead.

(rillig)

make: do not evaluate indirect modifiers in parse-only mode

Discovered by sjg.

(rillig)

make: in parse-only mode, don't evaluate modifiers

Previously, the ':S', ':ts', ':tA' and ':from=to' modifiers were
evaluated in parse-only mode, unnecessarily.  This is only noticeable
when an indirect modifier is evaluated in parse-only mode, which is
another bug that will be fixed in a follow-up commit.

(rillig)