Link [ NetBSD | NetBSD OpenGrok source search | PR fulltext-search | Summary of daily snapshot builds | history of daily build result | pkgsrc commit viewer ]


   
        usage: [branch:branch] [user:user] [path@revision] keyword [... [-excludekeyword [...]]] (e.g. branch:MAIN sys/arch/arm, if_wm.c@1.234 )




switch to index mode

recent branches: MAIN (9m)  netbsd-8 (5d)  netbsd-10 (5d)  netbsd-9 (11d)  thorpej-ifq (175d)  thorpej-altq-separation (178d) 

2024-05-10 03:39:28 UTC Now

2018-02-15 14:52:41 UTC netbsd-6-0 commitmail json YAML

2018-02-15 14:51:44 UTC netbsd-6-0 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1529):
sys/netipsec/xform_ipip.c: revision 1.44 via patch

PR/52161: Ryota Ozaki: Fix AH tunnel ipsec for ipv6. Compute plen right,
don't forget to subtract the ipv6 header length.

(martin)

2018-02-15 14:50:58 UTC netbsd-6-1 commitmail json YAML

2018-02-15 14:50:17 UTC netbsd-6-1 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1529):
sys/netipsec/xform_ipip.c: revision 1.44 via patch

PR/52161: Ryota Ozaki: Fix AH tunnel ipsec for ipv6. Compute plen right,
don't forget to subtract the ipv6 header length.

(martin)

2018-02-15 14:49:41 UTC netbsd-6 commitmail json YAML

2018-02-15 14:49:00 UTC netbsd-6 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1529):
sys/netipsec/xform_ipip.c: revision 1.44 via patch

PR/52161: Ryota Ozaki: Fix AH tunnel ipsec for ipv6. Compute plen right,
don't forget to subtract the ipv6 header length.

(martin)

2018-02-15 14:43:52 UTC netbsd-7-0 commitmail json YAML

2018-02-15 14:43:12 UTC netbsd-7-0 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1567):
sys/netipsec/xform_ipip.c: revision 1.44
PR/52161: Ryota Ozaki: Fix AH tunnel ipsec for ipv6. Compute plen right,
don't forget to subtract the ipv6 header length.

(martin)

2018-02-15 14:42:44 UTC netbsd-7-1 commitmail json YAML

2018-02-15 14:41:57 UTC netbsd-7-1 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1567):
sys/netipsec/xform_ipip.c: revision 1.44
PR/52161: Ryota Ozaki: Fix AH tunnel ipsec for ipv6. Compute plen right,
don't forget to subtract the ipv6 header length.

(martin)

2018-02-15 14:40:59 UTC netbsd-7 commitmail json YAML

2018-02-15 14:39:43 UTC netbsd-7 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1567):
sys/netipsec/xform_ipip.c: revision 1.44
PR/52161: Ryota Ozaki: Fix AH tunnel ipsec for ipv6. Compute plen right,
don't forget to subtract the ipv6 header length.

(martin)

2018-02-15 14:29:45 UTC netbsd-8 commitmail json YAML

2018-02-15 14:28:38 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #551):
sys/netipsec/xform_ipip.c: revision 1.56-1.63

Fix use-after-free. There is a path where the mbuf gets pulled up without
a proper mtod afterwards:

218    ipo = mtod(m, struct ip *);
281    m = m_pullup(m, hlen);
232    ipo->ip_src.s_addr

Found by Mootja.

Meanwhile it seems to me that 'ipo' should be set to NULL if the inner
packet is IPv6, but I'll revisit that later.
As I said in my last commit in this file, ipo should be set to NULL;
otherwise the 'local address spoofing' check below is always wrong on
IPv6.

Style and remove dead code.

dedup

Fix the IPIP_STAT_IBYTES stats; we did m_adj(m, iphlen) which substracted
iphlen, so no need to re-substract it again.

Remove broken MROUTING code, rename ipo->ip4, and simplify.

(martin)

2018-02-15 13:51:32 UTC MAIN commitmail json YAML

2018-02-15 12:40:12 UTC MAIN commitmail json YAML

Style a bit, and if we don't know the pad-filling policy use
SADB_X_EXT_PZERO by default.

There doesn't seem to be a sanity check in the keysock API to make sure
this place is never reached, and it's better to fill in with zeros than
not filling in at all (and leaking uninitialized mbuf data).

(maxv)

2018-02-15 10:41:51 UTC MAIN commitmail json YAML

Remove broken MROUTING code, rename ipo->ip4, and simplify.

(maxv)

2018-02-15 10:28:50 UTC MAIN commitmail json YAML

Fix the IPIP_STAT_IBYTES stats; we did m_adj(m, iphlen) which substracted
iphlen, so no need to re-substract it again.

(maxv)

2018-02-15 10:21:39 UTC MAIN commitmail json YAML

2018-02-15 10:09:54 UTC MAIN commitmail json YAML

2018-02-15 10:04:43 UTC MAIN commitmail json YAML

Style and remove dead code.

(maxv)

2018-02-15 09:23:47 UTC MAIN commitmail json YAML

Fix buffer overflow on sending an IPv6 packet with large options

If an IPv6 packet has large options, a necessary space for evacuation can
exceed the expected size (ah_pool_item_size). Give up using the pool_cache
if it happens.

Pointed out by maxv@

(ozaki-r)

2018-02-15 09:17:37 UTC MAIN commitmail json YAML

Commonalize error paths (NFC)

(ozaki-r)

2018-02-15 08:38:01 UTC MAIN commitmail json YAML

2018-02-15 08:27:25 UTC netbsd-8 commitmail json YAML

2018-02-15 08:26:37 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by hannken in ticket #550):
sbin/fsck_ffs/pass1.c: revision 1.58
Treat an inode with "mode == 0" and "blocks != 0" as partially allocated
and clear it as ffs_newvnode() tests for "blocks == 0".

(martin)

2018-02-15 08:12:02 UTC netbsd-6-0 commitmail json YAML

2018-02-15 08:11:25 UTC netbsd-6-0 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1530):
sys/netipsec/xform_ah.c: revision 1.80-1.81 via patch

Fix use-after-free, 'ah' may not be valid after m_makewritable and
ah_massage_headers.

Make sure the Authentication Header fits the mbuf chain, otherwise panic.

(martin)

2018-02-15 08:10:07 UTC netbsd-6-1 commitmail json YAML

2018-02-15 08:09:30 UTC netbsd-6-1 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1530):
sys/netipsec/xform_ah.c: revision 1.80-1.81 via patch

Fix use-after-free, 'ah' may not be valid after m_makewritable and
ah_massage_headers.

Make sure the Authentication Header fits the mbuf chain, otherwise panic.

(martin)

2018-02-15 08:08:58 UTC netbsd-6 commitmail json YAML

2018-02-15 08:08:19 UTC netbsd-6 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1530):
sys/netipsec/xform_ah.c: revision 1.80-1.81 via patch

Fix use-after-free, 'ah' may not be valid after m_makewritable and
ah_massage_headers.

Make sure the Authentication Header fits the mbuf chain, otherwise panic.

(martin)

2018-02-15 08:06:53 UTC netbsd-7-0 commitmail json YAML

2018-02-15 08:06:15 UTC netbsd-7-0 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1568):
sys/netipsec/xform_ah.c: revision 1.80-1.81 via patch

Fix use-after-free, 'ah' may not be valid after m_makewritable and
ah_massage_headers.

Make sure the Authentication Header fits the mbuf chain, otherwise panic.

(martin)

2018-02-15 08:05:41 UTC netbsd-7-1 commitmail json YAML

2018-02-15 08:05:01 UTC netbsd-7-1 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1568):
sys/netipsec/xform_ah.c: revision 1.80-1.81 via patch

Fix use-after-free, 'ah' may not be valid after m_makewritable and
ah_massage_headers.

Make sure the Authentication Header fits the mbuf chain, otherwise panic.

(martin)

2018-02-15 08:04:07 UTC netbsd-7 commitmail json YAML

2018-02-15 08:03:08 UTC netbsd-7 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1568):
sys/netipsec/xform_ah.c: revision 1.80-1.81 via patch

Fix use-after-free, 'ah' may not be valid after m_makewritable and
ah_massage_headers.

Make sure the Authentication Header fits the mbuf chain, otherwise panic.

(martin)

2018-02-15 07:59:23 UTC netbsd-8 commitmail json YAML

2018-02-15 07:58:04 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #549):
sys/netipsec/xform_ah.c: revision 1.80-1.81 via patch

Fix use-after-free, 'ah' may not be valid after m_makewritable and
ah_massage_headers.

Make sure the Authentication Header fits the mbuf chain, otherwise panic.

(martin)

2018-02-15 07:52:17 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by uwe in ticket #548):

sys/dev/i2c/files.i2c: revision 1.84 (via patch)

Delete 'define dbcool {}' line commented out in previous.  It's bogus
and the gcc6 correctly complains about that when it compiles ioconf.c
PR toolchain/53023

(martin)

2018-02-15 07:38:46 UTC MAIN commitmail json YAML

Make sure the Authentication Header fits the mbuf chain, otherwise panic.

(maxv)

2018-02-15 07:16:05 UTC MAIN commitmail json YAML

Fix use-after-free, 'ah' may not be valid after m_makewritable and
ah_massage_headers.

(maxv)

2018-02-15 04:27:24 UTC MAIN commitmail json YAML

Fix kernel panic (assertion failure) on receiving an IPv6 packet with large options

If an IPv6 packet has large options, a necessary space for evacuation can
exceed the expected size (ah_pool_item_size). Give up using the pool_cache
if it happens.

Pointed out by maxv@

(ozaki-r)

2018-02-15 04:24:32 UTC MAIN commitmail json YAML

Don't relook up an SP/SA in opencrpyto callbacks

We don't need to do so because we have a reference to it. And also
relooking-up one there may return an sp/sav that has different
parameters from an original one.

(ozaki-r)

2018-02-14 20:10:17 UTC MAIN commitmail json YAML

Adjust Allwinner emac(4) drivers to be compatible with root on NFS.

(jakllsch)

2018-02-14 19:09:09 UTC MAIN commitmail json YAML

Adjust comment; sun4i_emac is also used on sun5i.

(jakllsch)

2018-02-14 18:28:43 UTC MAIN commitmail json YAML

Remove dead code.

From David Binderman in PR kern/53029

(maya)

2018-02-14 17:43:09 UTC MAIN commitmail json YAML

Revert functional changes in previous, at expense of strict KNF conformance.

(jakllsch)

2018-02-14 16:45:24 UTC MAIN commitmail json YAML

join lines where they fit.

(christos)

2018-02-14 16:07:55 UTC MAIN commitmail json YAML

Don't invoke UB.

Heads up by John D. Baker.

(maya)

2018-02-14 14:28:40 UTC MAIN commitmail json YAML

Style, and remove unused prototypes and functions.

(maxv)

2018-02-14 14:19:53 UTC MAIN commitmail json YAML

Remove m_checkalignment(), unused. This eliminates a reference to
m_getptr().

(maxv)

2018-02-14 14:15:53 UTC MAIN commitmail json YAML

Remove IFF_STATICARP, we don't support this, and the code is useless in its
current form.

ok ozaki-r@

(maxv)

2018-02-14 14:04:48 UTC MAIN commitmail json YAML

Cosmetic - consistently use #define<SPACE>

(uwe)

2018-02-14 12:56:00 UTC MAIN commitmail json YAML

Fix a bug that RX and TX may stall on heavy load on wm(4) like ixgbe.c:r1.121.

wm_rxeof() and wm_txeof() have loop limit and the function returns true
if a packet still exists.

XXX need pullup-8

(knakahara)

2018-02-14 12:47:43 UTC MAIN commitmail json YAML

Fix broken dig and host commands

OpenSSL 1.1 does not have GOST support, so restrict GOST support to 1.0.

(ryoon)

2018-02-14 10:38:29 UTC MAIN commitmail json YAML

Fix a bug that RX may stall on heavy load on ixg(4). ixgbe_rxeof() has loop
limit and the function returns true if a packet are still in the RX ring.
ixgbe_handle_que() didn't check the return value. Check the return vaule
and issue a softint.

This bug is derived from FreeBSD and ixv(4) has no this bug.

XXX pullup-8

(msaitoh)

2018-02-14 10:13:26 UTC MAIN commitmail json YAML

Sort some lists. Use EXIT STATUS instead of RETURN VALUES.

(wiz)

2018-02-14 09:13:04 UTC MAIN commitmail json YAML

2018-02-14 08:59:23 UTC MAIN commitmail json YAML

Fix mbuf leaks on error paths

Pointed out by maxv@

(ozaki-r)

2018-02-14 06:52:41 UTC MAIN commitmail json YAML

Use .Cm instead of .Li, same as arp.8.

(maxv)

2018-02-14 05:29:39 UTC MAIN commitmail json YAML

Re-make ip6_nexthdr global, it will be used in soon-to-be-added code...

(maxv)

2018-02-14 05:24:44 UTC MAIN commitmail json YAML

Revert my two last changes in this file. They are apparently causing
problems with racoon, I'll investigate this later.

(maxv)

2018-02-14 03:56:26 UTC MAIN commitmail json YAML

2018-02-14 03:37:39 UTC MAIN commitmail json YAML

need -lrt for shm_{open,close}

(christos)

2018-02-14 02:12:36 UTC MAIN commitmail json YAML

depend on librt for shm_{open,close}

(christos)

2018-02-14 02:12:07 UTC MAIN commitmail json YAML

Asan needs bits and pieces of ubsan now; go figure.

(christos)

2018-02-14 02:11:22 UTC MAIN commitmail json YAML

our __csa_atexit does not like NULL dso; use atexit(3) instead.

(christos)

2018-02-14 02:10:32 UTC MAIN commitmail json YAML

2018-02-14 02:10:06 UTC MAIN commitmail json YAML

2018-02-13 22:35:47 UTC MAIN commitmail json YAML

Provide SHAR384 flavors: The OpenSSL SHA512_Final implementation is re-used
to implement SHA384_Final, but does the right thing by checking the internally
kept digest size. The NetBSD libc implementation provides two entry points
that write a different size digest, so if we use the SHA512_Final from here
we end up overwriting memory.

(christos)

2018-02-13 22:32:10 UTC MAIN commitmail json YAML

Provide the means to use the libc sha2 internally instead of the openssl
implementation; this does not really matter since their structs are larger
than ours, but it helps when we want to verify that we are not using any
of the openssl code.

(christos)

2018-02-13 22:29:14 UTC MAIN commitmail json YAML

Add a (void *) cast to make things compile with our own sha2 header

(christos)

2018-02-13 19:37:31 UTC MAIN commitmail json YAML

Avoid unused variable warning

(sjg)

2018-02-13 17:39:38 UTC MAIN commitmail json YAML

2018-02-13 15:21:59 UTC MAIN commitmail json YAML

Make the arpresolve branch more readable, fix typo, fix XXX (which I
added), add missing pserialize_read_exit (which I forgot).

(maxv)

2018-02-13 14:50:28 UTC MAIN commitmail json YAML

Mmh. Add a missing check: if ARP was disabled on the interface, don't
process ARP packets. Otherwise the kernel will add ARP entries even if

ifconfig wm0 -arp

was entered.

(maxv)

2018-02-13 13:19:30 UTC MAIN commitmail json YAML

Delete 'define dbcool {}' line commented out in previous.  It's bogus
and the gcc6 correctly complains about that when it compiles ioconf.c

PR toolchain/53023

(uwe)

2018-02-13 11:20:08 UTC MAIN commitmail json YAML

Treat an inode with "mode == 0" and "blocks != 0" as partially allocated
and clear it as ffs_newvnode() tests for "blocks == 0".

(hannken)

2018-02-13 10:50:38 UTC MAIN commitmail json YAML

Remove KERNEL_LOCK around the MPLS code. It's not needed, since we're only
touching the tag of the mbuf - the tag belongs only to the mbuf, and the
mbuf is not shared.

ok knakahara@

(maxv)

2018-02-13 10:47:41 UTC MAIN commitmail json YAML

Be tougher:

* In arpintr(), don't allow IEEE1394 packets on non-IEEE1394 interfaces.

* In revarpinput(), kick IEEE1394 packets right away. They are not
  supported.

(maxv)

2018-02-13 10:31:01 UTC MAIN commitmail json YAML

Same change as rev1.258, but this time in revarpinput: use m_pullup.

(maxv)

2018-02-13 10:20:50 UTC MAIN commitmail json YAML

Minor stylistic changes, and use C99 types.

(maxv)

2018-02-13 10:17:04 UTC MAIN commitmail json YAML

Adapt to ar_tha() changes in if_arp.h rev1.31.

(martin)

2018-02-13 10:05:05 UTC MAIN commitmail json YAML

Replace dead code by KASSERT.

(maxv)

2018-02-13 10:02:12 UTC MAIN commitmail json YAML

2018-02-13 09:51:33 UTC MAIN commitmail json YAML

Fix copy & pasto (dsa code vs. rsa code) in previous, fixes PR lib/53012
and recentish sshfs test failures.

(martin)

2018-02-13 09:50:36 UTC MAIN commitmail json YAML

use -fno-delete-null-pointer-checks for kernels.

(mrg)

2018-02-13 09:26:18 UTC MAIN commitmail json YAML

Put time_second and time_uptime in different cache lines, probably saves
us some false sharing.

(maxv)

2018-02-13 08:51:38 UTC MAIN commitmail json YAML

Don't force ARPHRD_IEEE1394 on IEEE1394 interfaces. If it's not there, then
kick the packet. And do this earlier.

(maxv)

2018-02-13 08:43:26 UTC MAIN commitmail json YAML

Define ar_* as inlined functions, not as macros. Makes it easier to
understand why ARPHRD_IEEE1394 needs to be handled with care - it doesn't
have ar_tha.

(maxv)

2018-02-13 08:20:12 UTC MAIN commitmail json YAML

Use only one label, clearer.

(maxv)

2018-02-13 07:51:24 UTC MAIN commitmail json YAML

Fix three things in arpintr():

* mtod can't return NULL.

* It is wrong to kick the packet if m->m_len < arplen. While this check
  always returns false for native Ethernet interfaces, it may not if the
  frame is encapsulated in EtherIP/L2TP. Use m_pullup instead.

* Remove XXX, it is fine. Reduce the indentation level afterwards.

(maxv)

2018-02-13 07:44:25 UTC MAIN commitmail json YAML

Style, no functional change.

(maxv)

2018-02-13 07:21:19 UTC MAIN commitmail json YAML

Disable the 'define dbcool {}' line - it's not needed, and causes
problems with config(1) and gcc6.  See PR toolchain/530223 for more
info.

(pgoyette)

2018-02-13 06:44:13 UTC MAIN commitmail json YAML

Remove double declaration; 'ddb_regs' is already declared as a macro
in db_machdep.h if MULTIPROCESSOR is on, and the macro has higher
priority.

Don't declare 'ddb_regs' locally in this case, because it is misleading.
Part of PR/52964.

(maxv)

2018-02-13 04:36:00 UTC MAIN commitmail json YAML

note that openssl and GCC may upset your builds.

(mrg)

2018-02-13 04:11:28 UTC MAIN commitmail json YAML

2018-02-13 04:10:41 UTC MAIN commitmail json YAML

Fix NULL pointer dereference via ddb_regs

ddb_regs can be *ddb_regp (see db_machdep.h) so ddb_regp should be NULL-ed
after dereference to ddb_regs.

Also dbreg should be restored to ddb_regp because ddb_regp can be changed
by db_mach_cpu during db_trap.

Fix PR 52964
Helped by nonaka@

(ozaki-r)

2018-02-13 01:05:18 UTC MAIN commitmail json YAML

Unconditionally print the trap like we do for amdt64 (Dimitris Karagkasidis)

(christos)

2018-02-13 00:34:11 UTC MAIN commitmail json YAML

2018-02-12 23:11:00 UTC MAIN commitmail json YAML

Add a new option CISS_NO_INTERRUPT_HACK for driving ciss(4) by callouts.
This is intended as workaround for certain Xen issues with dom0 kernels
and will likely want to have a high HZ value as well for decent
performance.

(joerg)

2018-02-12 22:31:04 UTC MAIN commitmail json YAML

Fix __siglongjmp14().

Fixes SIGINT causing ksh to "longjmp botch", presumably due to incorrect
magic number.
cvs: ----------------------------------------------------------------------

(jakllsch)

2018-02-12 22:18:36 UTC MAIN commitmail json YAML

Simplify and make the GCC check more precise at the same time.

(joerg)

2018-02-12 21:38:09 UTC MAIN commitmail json YAML

Do not treat .info as warning for -W

Reported by: lwhsu at FreeBSD.org

(sjg)

2018-02-12 20:47:09 UTC MAIN commitmail json YAML

Fix building with MKGCC=no

(adam)

2018-02-12 20:43:17 UTC MAIN commitmail json YAML

2018-02-12 20:32:59 UTC netbsd-8 commitmail json YAML

2018-02-12 18:44:38 UTC netbsd-7-0 commitmail json YAML

2018-02-12 18:44:28 UTC netbsd-7-1 commitmail json YAML

2018-02-12 18:44:14 UTC netbsd-7 commitmail json YAML

1548, 1551, 1552

(snj)

2018-02-12 18:42:20 UTC netbsd-7 commitmail json YAML

Pull up following revision(s) (requested by mrg in ticket #1552):
sys/arch/sparc/sparc/timer.c: 1.33-1.34
sys/arch/sparc/sparc/timer_sun4m.c: 1.31
sys/arch/sparc/sparc/timerreg.h: 1.10
fix time goes backwards problems on sparc.
there are a few things here:
- there's a race between reading the limit register (which clears
  the interrupt and the limit bit) and increasing the latest offset.
  this can happen easily if an interrupt comes between the read and
  the call to tickle_tc() that increases the offset (i obverved this
  actually happening.)
- in early boot, sometimes the counter can cycle twice before the
  tickle happens.
to handle these issues, add two workarounds:
- if the limit bit isn't set, but the counter value is less than
  the previous value, and the offset hasn't changed, use the same
  fixup as if the limit bit was set.  this handles the first case
  above.
- add a hard-workaround for never allowing returning a smaller
  value (except during 32 bit overflow): if the result is less than
  the last result, add fixups until it does (or until it would
  overflow.)
the first workaround fixes general run-time issues, and the second
fixes issues only seen during boot.
also expand some comments in timer_sun4m.c and re-enable the sun4m
sub-microsecond tmr_ustolim4m() support (but it's always called with
at least 'tick' microseconds, so the end result is the same.)
--
fix hang at 4B microseconds (1h12 or so), and simplify part of the previous

(snj)

2018-02-12 18:42:18 UTC netbsd-7-1 commitmail json YAML

Pull up following revision(s) (requested by mrg in ticket #1552):
sys/arch/sparc/sparc/timer.c: 1.33-1.34
sys/arch/sparc/sparc/timer_sun4m.c: 1.31
sys/arch/sparc/sparc/timerreg.h: 1.10
fix time goes backwards problems on sparc.
there are a few things here:
- there's a race between reading the limit register (which clears
  the interrupt and the limit bit) and increasing the latest offset.
  this can happen easily if an interrupt comes between the read and
  the call to tickle_tc() that increases the offset (i obverved this
  actually happening.)
- in early boot, sometimes the counter can cycle twice before the
  tickle happens.
to handle these issues, add two workarounds:
- if the limit bit isn't set, but the counter value is less than
  the previous value, and the offset hasn't changed, use the same
  fixup as if the limit bit was set.  this handles the first case
  above.
- add a hard-workaround for never allowing returning a smaller
  value (except during 32 bit overflow): if the result is less than
  the last result, add fixups until it does (or until it would
  overflow.)
the first workaround fixes general run-time issues, and the second
fixes issues only seen during boot.
also expand some comments in timer_sun4m.c and re-enable the sun4m
sub-microsecond tmr_ustolim4m() support (but it's always called with
at least 'tick' microseconds, so the end result is the same.)
--
fix hang at 4B microseconds (1h12 or so), and simplify part of the previous

(snj)

2018-02-12 18:42:16 UTC netbsd-7-0 commitmail json YAML

Pull up following revision(s) (requested by mrg in ticket #1552):
sys/arch/sparc/sparc/timer.c: 1.33-1.34
sys/arch/sparc/sparc/timer_sun4m.c: 1.31
sys/arch/sparc/sparc/timerreg.h: 1.10
fix time goes backwards problems on sparc.
there are a few things here:
- there's a race between reading the limit register (which clears
  the interrupt and the limit bit) and increasing the latest offset.
  this can happen easily if an interrupt comes between the read and
  the call to tickle_tc() that increases the offset (i obverved this
  actually happening.)
- in early boot, sometimes the counter can cycle twice before the
  tickle happens.
to handle these issues, add two workarounds:
- if the limit bit isn't set, but the counter value is less than
  the previous value, and the offset hasn't changed, use the same
  fixup as if the limit bit was set.  this handles the first case
  above.
- add a hard-workaround for never allowing returning a smaller
  value (except during 32 bit overflow): if the result is less than
  the last result, add fixups until it does (or until it would
  overflow.)
the first workaround fixes general run-time issues, and the second
fixes issues only seen during boot.
also expand some comments in timer_sun4m.c and re-enable the sun4m
sub-microsecond tmr_ustolim4m() support (but it's always called with
at least 'tick' microseconds, so the end result is the same.)
--
fix hang at 4B microseconds (1h12 or so), and simplify part of the previous

(snj)

2018-02-12 18:37:51 UTC netbsd-7 commitmail json YAML

Pull up following revision(s) (requested by ozaki-r in ticket #1551):
sys/netinet6/ip6_forward.c: 1.89-1.90 via patch
Fix use-after-free of mbuf by ip6flow_create
This fixes recent failures of some ATF tests such as t_ipsec_tunnel_odd.
--
Fix use-after-free of mbuf by ip6flow_create (one more)

(snj)

2018-02-12 18:37:50 UTC netbsd-7-1 commitmail json YAML

Pull up following revision(s) (requested by ozaki-r in ticket #1551):
sys/netinet6/ip6_forward.c: 1.89-1.90 via patch
Fix use-after-free of mbuf by ip6flow_create
This fixes recent failures of some ATF tests such as t_ipsec_tunnel_odd.
--
Fix use-after-free of mbuf by ip6flow_create (one more)

(snj)

2018-02-12 18:37:48 UTC netbsd-7-0 commitmail json YAML

Pull up following revision(s) (requested by ozaki-r in ticket #1551):
sys/netinet6/ip6_forward.c: 1.89-1.90 via patch
Fix use-after-free of mbuf by ip6flow_create
This fixes recent failures of some ATF tests such as t_ipsec_tunnel_odd.
--
Fix use-after-free of mbuf by ip6flow_create (one more)

(snj)

2018-02-12 18:30:22 UTC netbsd-7 commitmail json YAML

Pull up following revision(s) (requested by christos in ticket #1548):
external/bsd/blacklist/bin/blacklistd.c: 1.35
external/bsd/blacklist/bin/state.c: 1.19
restore rules after the database is open, add error message to prevent
silent failure in the future. (Kurt Lidl)

(snj)

2018-02-12 18:23:29 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #547):
sys/netinet/ip_input.c: 1.366
Disable ip_allowsrcrt and ip_forwsrcrt. Enabling them by default was a
completely dumb idea, because they have security implications.
By sending an IPv4 packet containing an LSRR option, an attacker will
cause the system to forward the packet to another IPv4 address - and
this way he white-washes the source of the packet.
It is also possible for an attacker to reach hidden networks: if a server
has a public address, and a private one on an internal network (network
which has several internal machines connected), the attacker can send a
packet with:
        source = 0.0.0.0
        destination = public address of the server
        LSRR first address = address of a machine on the internal network
And the packet will be forwarded, by the server, to the internal machine,
in some cases even with the internal IP address of the server as a source.

(snj)

2018-02-12 18:19:12 UTC MAIN commitmail json YAML

Keep a pointer to the interface of the multicast membership, because the
multicast element itself might go away in in_delmulti (but the interface
can't because we hold the lock). From ozaki-r@

(christos)

2018-02-12 18:18:00 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #546):
sys/net/if_mpls.c: 1.31-1.33
sys/netmpls/mpls_ttl.c: 1.9-1.11
Style, and fix several bugs:
- ip4_check(), mpls_unlabel_inet() and mpls_unlabel_inet6() perform
  pullups, so we need to pass the updated pointers back
- in mpls_lse() the route is not always freed
Looks a little better now.
--
Kick MPLS packets earlier.
--
Several changes:
* Declare TRIM_LABEL as a function.
* In mpls_unlabel_inet, copy the label locally. It's not incorrect to
  keep a pointer on the mbuf, but it's bug-friendly.
* In mpls_label_inetX, fix the length check. Meanwhile add an XXX: we
  just want to make sure that m_copydata won't fail, but if we were
  guaranteed that m has M_PKTHDR set, we could simply check the length
  against m->m_pkthdr.len.
--
Style in MPLS.
--
Add XXX.

(snj)

2018-02-12 17:04:58 UTC MAIN commitmail json YAML

Another missing NULL-check.

(maxv)

2018-02-12 17:01:22 UTC MAIN commitmail json YAML

m_free -> m_freem, otherwise leak

(maxv)

2018-02-12 16:58:01 UTC MAIN commitmail json YAML

NULL-check after M_DONTWAIT.

(maxv)

2018-02-12 16:01:35 UTC MAIN commitmail json YAML

Add a KASSERT; we expect *from to be a single mbuf (not chained).

(maxv)

2018-02-12 15:38:14 UTC MAIN commitmail json YAML

Use m_freem instead of m_free. Otherwise we're leaking the next mbufs in
the chain.

(maxv)

2018-02-12 12:52:13 UTC MAIN commitmail json YAML

Replace bcopy -> memcpy when it is obvious that the areas don't overlap.
Rearrange ip6_splithdr() for clarity.

(maxv)

2018-02-12 12:17:38 UTC MAIN commitmail json YAML

Fix typo, and add a comment about MPLS.

(maxv)

2018-02-12 11:14:15 UTC MAIN commitmail json YAML

Complete previous by complteley removing the _DIAGASSERT from memmove -
the accidental left over from previous fired on all legitimate calls
and caused PR bin/52986 and PR lib/52987.

(martin)

2018-02-12 10:37:51 UTC MAIN commitmail json YAML

note GCC 6.4 import.

(mrg)

2018-02-12 09:31:06 UTC MAIN commitmail json YAML

Don't rebase the pointers. 'm' is only allowed to become NULL (which
means 'processed').

(maxv)

2018-02-12 08:22:27 UTC MAIN commitmail json YAML

2018-02-12 08:13:08 UTC MAIN commitmail json YAML

2018-02-12 08:08:28 UTC MAIN commitmail json YAML

Remove the 'm' argument from syn_cache_respond(); all it does with it is
freeing it, so free in the caller instead.

(maxv)

2018-02-12 08:03:42 UTC MAIN commitmail json YAML

Remove this multicast check. Multicast packets are already dropped at
the beginning of the function.

(maxv)

2018-02-12 05:40:25 UTC netbsd-8 commitmail json YAML

2018-02-12 04:05:07 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by christos in ticket #545):
sbin/gpt/backup.c: 1.17-1.18
sbin/gpt/biosboot.c: 1.29-1.30
sbin/gpt/gpt.c: 1.71-1.73
sbin/gpt/gpt.h: 1.36
sbin/gpt/restore.c: 1.17
sbin/gpt/show.c: 1.40-1.41
sys/dev/dkwedge/dkwedge_gpt.c: 1.19-1.20
PR/52522: Piotr Meyer: Don't NUL terminate the gpt label name.
--
- make sure that the utf16 string is padded with 0's where needed.
- since the utf16 string is not 0 terminated, pass the size of the string.
--
use __arraycount
--
PR/52522: ent_name is not necessarily 0 terminated, so check bounds.
--
use arraycount.

(snj)

2018-02-12 02:15:32 UTC MAIN commitmail json YAML

2018-02-12 00:57:48 UTC netbsd-8 commitmail json YAML

2018-02-12 00:21:07 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by christos in ticket #544):
sys/rump/dev/lib/libucom/UCOM.ioconf: 1.6
should be umodeswitch!

(snj)

2018-02-12 00:20:01 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by christos in ticket #543):
external/gpl2/xcvs/dist/src/rsh-client.c: 1.3
Fix for CVE-2017-12836; (cvs command injection) from MirBSD.

(snj)

2018-02-11 21:56:20 UTC netbsd-8 commitmail json YAML

2018-02-11 21:52:54 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by christos in ticket #542):
usr.sbin/ypserv/ypserv/ypserv_proc.c: 1.18
PR/47615: Dr. W. Stukenbrock: Always zero out the result structs in the
svc procs to avoid returning stale request data to the client.

(snj)

2018-02-11 21:48:41 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by maya in ticket #541):
sys/external/bsd/drm2/dist/drm/nouveau/core/engine/device/nouveau_engine_device_nve0.c: 1.3
PR/53006: stackfield: Please support NVIDIA GT730 to kernel

(snj)

2018-02-11 21:46:25 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by ozaki-r in ticket #539):
sys/netinet/in.c: 1.217
Don't call lltable_purge_entries from in_if_down if ARP isn't enabled
Reported by bouyer@

(snj)

2018-02-11 21:29:18 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by bouyer in ticket #537):
sys/dev/sdmmc/sdmmc_mem.c: revision 1.64
Fix uninitialized variable use:
if there is an error, or if we are using a SPI controller,
sdmmc_mem_send_op_cond() doens't assign a value to *ocrp,
but it is used unconditionally in sdmmc_mem_enable() to see if we can switch
to low voltage.
In sdmmc_mem_send_op_cond(), if the new ocr is not returned by the
card for whatever reason, set *ocrp to the orig value.

(snj)

2018-02-11 21:17:35 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by ozaki-r in ticket #536):
distrib/sets/lists/base/shl.mi: 1.825
distrib/sets/lists/comp/mi: 1.2168-1.2169
distrib/sets/lists/comp/shl.mi: 1.310
distrib/sets/lists/debug/mi: 1.234
distrib/sets/lists/debug/shl.mi: 1.188
distrib/sets/lists/man/mi: 1.1570
distrib/sets/lists/tests/mi: 1.772
etc/mtree/NetBSD.dist.tests: 1.150
share/man/man4/Makefile: 1.650
share/man/man4/ipsec.4: 1.42-1.43
share/man/man4/ipsecif.4: 1.1-1.5
sys/arch/amd64/conf/ALL: 1.77
sys/arch/amd64/conf/GENERIC: 1.480
sys/conf/files: 1.1191
sys/net/Makefile: 1.34
sys/net/files.net: 1.14
sys/net/if.c: 1.404
sys/net/if.h: 1.248
sys/net/if_gif.c: 1.135
sys/net/if_ipsec.c: 1.1-1.3
sys/net/if_ipsec.h: 1.1
sys/net/if_l2tp.c: 1.16
sys/net/if_types.h: 1.28
sys/netinet/in.c: 1.214
sys/netinet/in.h: 1.103
sys/netinet/in_gif.c: 1.92
sys/netinet/ip_var.h: 1.122
sys/netinet6/in6.c: 1.257
sys/netinet6/in6.h: 1.88
sys/netinet6/in6_gif.c: 1.90
sys/netinet6/ip6_var.h: 1.75
sys/netipsec/Makefile: 1.6
sys/netipsec/files.netipsec: 1.13
sys/netipsec/ipsec.h: 1.62
sys/netipsec/ipsecif.c: 1.1
sys/netipsec/ipsecif.h: 1.1
sys/netipsec/key.c: 1.246-1.247
sys/netipsec/key.h: 1.34
sys/rump/net/Makefile.rumpnetcomp: 1.20
sys/rump/net/lib/libipsec/IPSEC.ioconf: 1.1
sys/rump/net/lib/libipsec/Makefile: 1.1
sys/rump/net/lib/libipsec/ipsec_component.c: 1.1
tests/net/Makefile: 1.34
tests/net/if_ipsec/Makefile: 1.1
tests/net/if_ipsec/t_ipsec.sh: 1.1-1.2
Don't touch an SP without a reference to it
unify processing to check nesting count for some tunnel protocols.
add ipsec(4) interface, which is used for route-based VPN.
man and ATF are added later, please see man for details.
reviewed by christos@n.o, joerg@n.o and ozaki-r@n.o, thanks.
https://mail-index.netbsd.org/tech-net/2017/12/18/msg006557.html
ipsec(4) interface supports rump now.
add ipsec(4) interface ATF.
add ipsec(4) interface man as ipsecif.4.
add ipsec(4) interface to amd64/GENERIC and amd64/ALL configs.
apply in{,6}_tunnel_validate() to gif(4).
Spell IPsec that way. Simplify macro usage. Sort SEE ALSO. Bump
date for previous.
Improve wording and macro use.
Some parts are not clear to me, so someone with knowledge of ipsecif(4)
should improve this some more.
Improve ipsecif.4. Default port ipsec(4) NAT-T is tested now.
pointed out by wiz@n.o and suggested by ozaki-r@n.o, thanks.
Change the prefix of test names to ipsecif_ to distinguish from tests for ipsec(4)
New sentence, new line. Remove empty macro.
Fix PR kern/52920. Pointed out by David Binderman, thanks.
Improve wording, and put a new drawing, from me and Kengo Nakahara.
apply a little more #ifdef INET/INET6.  fixes !INET6 builds.

(snj)

2018-02-11 18:58:45 UTC MAIN commitmail json YAML

Wrap PowerPC #pragma goop in #if __GNUC_PREREQ__(6,0).
Our older GCC warns/errors on it.

(jakllsch)

2018-02-11 16:45:35 UTC MAIN commitmail json YAML

Add obsolete lines for the gcc-5 and openssl-1.0 lines for systems that have
installed gcc-6 and openssl-1.1. Requested by wiz@

(christos)

2018-02-11 15:56:25 UTC MAIN commitmail json YAML

PR/53008: Henning Petersen: Fix missing brace inside comment.

(christos)

2018-02-11 15:52:59 UTC MAIN commitmail json YAML

2018-02-11 14:17:24 UTC MAIN commitmail json YAML

Add missing comma.

(wiz)

2018-02-11 14:17:17 UTC MAIN commitmail json YAML

2018-02-11 14:15:14 UTC MAIN commitmail json YAML

2018-02-11 13:50:15 UTC MAIN commitmail json YAML

Use bools with bool. NFCI.

From Henning Petersen in PR toolchain/53009.
(I completed for the rest of the function. Similar code exists in GCC trunk.)

(maya)

2018-02-11 13:31:17 UTC MAIN commitmail json YAML

2018-02-11 13:30:55 UTC MAIN commitmail json YAML

Remove useless macros. Sort errors.

(wiz)

2018-02-11 13:28:50 UTC MAIN commitmail json YAML

Remove useless macro.

(wiz)

2018-02-11 13:28:26 UTC MAIN commitmail json YAML

Remove Tn. Remove trailing whitespace. Remove useless Pp.

(wiz)

2018-02-11 09:39:37 UTC MAIN commitmail json YAML

2018-02-11 08:27:18 UTC MAIN commitmail json YAML

Style, and reduce the diff between i386 and amd64. No functional change.

(maxv)

2018-02-11 03:44:53 UTC MAIN commitmail json YAML

switch amd64 to gcc-6. Thanks mrg for all the work!

(christos)

2018-02-11 02:51:58 UTC MAIN commitmail json YAML

more volatile to appease gcc.

(christos)

2018-02-11 02:12:29 UTC MAIN commitmail json YAML

2018-02-11 00:25:12 UTC MAIN commitmail json YAML

2018-02-11 00:01:12 UTC MAIN commitmail json YAML

introduce a inline function to set a value to zero while
hiding this fact from GCC.  this allows the PPC code that
writes to address zero to actually work rather than cause
GCC to emit an explicit "trap" instruction, which in early
boot means hang on my pegasosII.  use this in oae_init()
for both rfid->rfi and also setting the jump-to-zero trap.

found with a lot of debugging, but GCC 6's new warning
-Wnull-dereference found it when i was informed of its
existence.  unfortunately, there are dozens of other
violations in our kernel today so simply enabling that
option for everything is not a good idea, but is a goal.

(mrg)

2018-02-10 23:46:44 UTC MAIN commitmail json YAML

2018-02-10 23:39:29 UTC MAIN commitmail json YAML

Convert to full recursive attr/die lookup instead of one level since gcc 6
creates indirect attributes that point to indirect attributes. The code is
smaller this way too :-)

(christos)

2018-02-10 19:34:34 UTC MAIN commitmail json YAML

We need authentication || encryption even when we are not building
kerberos. They are needed for telnet_net_write() which is used in libtelnet.

(christos)

2018-02-10 16:16:28 UTC MAIN commitmail json YAML

2018-02-10 13:29:55 UTC MAIN commitmail json YAML

2018-02-10 11:50:39 UTC MAIN commitmail json YAML

Do for i386 what was done for amd64 (but in a more KNF conformant way...)

(kre)

2018-02-10 08:54:22 UTC MAIN commitmail json YAML

Add a note, to say that basically the recent FreeBSD binaries can't be
expected to work, and that we keep compat_freebsd only for tw_cli.

(maxv)

2018-02-10 08:17:00 UTC MAIN commitmail json YAML

If the socket wants a ESP-over-UDP packet, and the packet is incorrect,
stop processing it instead of giving it to udp4_sendup. It just doesn't
make any sense not to drop it.

I was already telling myself this the other day when I visited this place,
but I just saw PR/36782 (11 years old) that suggests the exact same thing,
so fix it.

Now, udp4_espinudp always frees the mbuf, and is made void. The packet is
not processed any further afterwards.

(maxv)

2018-02-10 07:59:54 UTC MAIN commitmail json YAML

Remove the last reference to IPSEC_ESP. This option was deleted in
2013.

(maxv)

2018-02-10 06:22:22 UTC MAIN commitmail json YAML

2018-02-10 05:51:06 UTC MAIN commitmail json YAML

2018-02-10 04:26:35 UTC netbsd-6 commitmail json YAML

2018-02-10 04:26:15 UTC netbsd-6-1 commitmail json YAML

2018-02-10 04:25:59 UTC netbsd-6-0 commitmail json YAML

2018-02-10 04:25:38 UTC netbsd-6 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1527):
sys/dist/pf/net/pf.c: revision 1.78 via patch
Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
is unsigned too. That's not the expected behavior, the original code
wanted a signed comparison.
It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.
This bug was reported 8 years ago by Lucio Albornoz in PR/44059.

(snj)

2018-02-10 04:25:36 UTC netbsd-6-1 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1527):
sys/dist/pf/net/pf.c: revision 1.78 via patch
Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
is unsigned too. That's not the expected behavior, the original code
wanted a signed comparison.
It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.
This bug was reported 8 years ago by Lucio Albornoz in PR/44059.

(snj)

2018-02-10 04:25:34 UTC netbsd-6-0 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1527):
sys/dist/pf/net/pf.c: revision 1.78 via patch
Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
is unsigned too. That's not the expected behavior, the original code
wanted a signed comparison.
It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.
This bug was reported 8 years ago by Lucio Albornoz in PR/44059.

(snj)

2018-02-10 04:22:50 UTC netbsd-7 commitmail json YAML

2018-02-10 04:22:31 UTC netbsd-7-1 commitmail json YAML

2018-02-10 04:22:10 UTC netbsd-7-0 commitmail json YAML

2018-02-10 04:21:19 UTC netbsd-7 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1565):
sys/dist/pf/net/pf.c: revision 1.78 via patch
Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
is unsigned too. That's not the expected behavior, the original code
wanted a signed comparison.
It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.
This bug was reported 8 years ago by Lucio Albornoz in PR/44059.

(snj)

2018-02-10 04:21:17 UTC netbsd-7-1 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1565):
sys/dist/pf/net/pf.c: revision 1.78 via patch
Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
is unsigned too. That's not the expected behavior, the original code
wanted a signed comparison.
It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.
This bug was reported 8 years ago by Lucio Albornoz in PR/44059.

(snj)

2018-02-10 04:21:15 UTC netbsd-7-0 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #1565):
sys/dist/pf/net/pf.c: revision 1.78 via patch
Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
is unsigned too. That's not the expected behavior, the original code
wanted a signed comparison.
It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.
This bug was reported 8 years ago by Lucio Albornoz in PR/44059.

(snj)

2018-02-10 04:13:26 UTC netbsd-8 commitmail json YAML

2018-02-10 04:12:17 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by maxv in ticket #540):
sys/dist/pf/net/pf.c: 1.77-1.78
PR/52682: David Binderman: Fix wrong assignment (in the !__NetBSD__ code)
Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
is unsigned too. That's not the expected behavior, the original code
wanted a signed comparison.
It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.
This bug was reported 8 years ago by Lucio Albornoz in PR/44059.

(snj)

2018-02-10 03:55:59 UTC MAIN commitmail json YAML

make it compile without MULTIPROCESSOR (xen?)

(christos)

2018-02-09 23:22:13 UTC MAIN commitmail json YAML

fix BN_to_integer to get rid of  __UNCONST. Trick question:
How many BN_to_integer implementations does Heimdal contain (I only fixed 2).

(christos)

2018-02-09 22:46:19 UTC MAIN commitmail json YAML

Use the magic FILESBUILD variable so that it builds with BUILD/UPDATE unset.
Why again FILESBUILD is not the default and needs to be set?

(christos)

2018-02-09 22:08:28 UTC MAIN commitmail json YAML

Explain what may seem to be a non-sensical assignment, but isn't.

closes PR 53000

(jakllsch)

2018-02-09 21:25:04 UTC MAIN commitmail json YAML

Oh, what is this. Fix a remotely-triggerable integer overflow: the way we
define TCPOLEN_SACK makes it unsigned, and the comparison in the while()
is unsigned too. That's not the expected behavior, the original code
wanted a signed comparison.

It's pretty easy to make 'hlen' go negative and trigger a buffer overflow.

This bug was reported 8 years ago by Lucio Albornoz in PR/44059.

(maxv)

2018-02-09 18:45:55 UTC MAIN commitmail json YAML

Disable XSAVEOPT, until it is clear what's wrong with it (PR/52966).

(maxv)

2018-02-09 18:31:52 UTC MAIN commitmail json YAML

2018-02-09 17:14:26 UTC MAIN commitmail json YAML

update nsd, fix typo for acpica

(christos)