Define new tests for CPU Debug Registers in t_ptrace_wait{,3,4,6,id,pid}

Rename dbregs1 to dbregs_print
Rename dbregs[2345] to dbregs_preserve_dr[0123]

Add new tests dbregs_preserve_dr[0123]_yield.

dbregs_preserve_dr0_yield:
    Verify that setting DR0 is preserved across ptrace(2) calls with
    scheduler yield

dbregs_preserve_dr1_yield:
    Verify that setting DR1 is preserved across ptrace(2) calls with
    scheduler yield

dbregs_preserve_dr2_yield:
    Verify that setting DR2 is preserved across ptrace(2) calls with
    scheduler yield

dbregs_preserve_dr3_yield:
    Verify that setting DR3 is preserved across ptrace(2) calls with
    scheduler yield

Add new tests dbregs_preserve_dr[0123]_continued.

dbregs_preserve_dr0_continued:
    Verify that setting DR0 is preserved across ptrace(2) calls and with
    continued child

dbregs_preserve_dr1_continued:
    Verify that setting DR1 is preserved across ptrace(2) calls and with
    continued child

dbregs_preserve_dr2_continued:
    Verify that setting DR2 is preserved across ptrace(2) calls and with
    continued child

dbregs_preserve_dr3_continued:
    Verify that setting DR3 is preserved across ptrace(2) calls and with
    continued child

Use more meaningful names for these tests as they are MD specific and
testing precise functionality. Also there will be a growing number of
tests in this category and prefixing everything with plain dbregs and
trailing with a number cannot be verbose.

Sponsored by <The NetBSD Foundation>

(kamil)

regen mips64

(christos)

regen mips64

(christos)

change license since much of the actual acceleration code was adapted from
pm3_accel.c

(macallan)

build pm3_exa

(macallan)

add crude but working EXA support for Permedia 3

(macallan)

provide a tree like display with -d, from FreeBSD

(christos)

fix test lib/librumphijack/t_sh/runscript
(handle F_DUPFD_CLOEXEC that the shell is now using)

(christos)

Add unwind action type and constants

(christos)

switch m68k to new binutils and gdb

(christos)

regen m68k

(christos)

regen m68k

(christos)

Fix crashdump on machines with EXTENDED_MEMORY.

PR port-x68k/51663 from Rin Okuyama.

(tsutsui)

Update ixg(4) and ixv(4) up to FreeBSD r294578:
- Fixup SFP module insertion on the 82599 when insertion happens after
  the system is booted and running. Add PHY detection logic to
  ixgbe_handle_mod() and add locking to ixgbe_handle_msf() as well.
  FreeBSD r293334.
- Fix ix advertise value after media change. When ifconfig sets media then the
  values displayed by the advertise_speed value are invalidated.
  Fix this by setting the bits correctly including setting advertise to 0 for
  media = auto. FreeBSD r294578.
- Some others (e.g. LRO(not used by NetBSD)).

(msaitoh)

Fix ix{gbe,v}_set_sysctlvalue().

(msaitoh)

Add ixgbe_osdep.c.

(msaitoh)

- Add missing pmf_device_deregister() in ixgbe_detach()
- Remove extra newline from an sysctl description.
- Fix dmesg output when the number of PCIe lane can't get.

(msaitoh)

Update ixg(4) and ixv(4) up to FreeBSD r292674:
- Add X552 SFP+ and X550T single port.
- Bug fixes.

(msaitoh)

Update ixg(4) and ixv(4) up to FreeBSD r289238:
- Add support for sysctl knobs to live tune the per interrupt rx/tx packet
  processing limits in ixgbe(4)
- Some others (netmap, etc.)

(msaitoh)

Update ixg(4) and ixv(4) up to FreeBSD r285590:
- Fix igxbe SRIOV VF (if_ixv) initialization bugs.  The MAC address for
  an if_ixv instance can now set at creation time, and the receive ring
  tail pointer is correctly initialized (previously, things still worked
  because the receive ring tail pointer was being fixed up as a side
  effect of other activity).

(msaitoh)

Update ixg(4) and ixv(4) up to FreeBSD r283881:
- SRIOV support (not enabled because NetBSD doesn't support it).

(msaitoh)

Add new tests dbregs[2345] in MD arch/amd64/ t_ptrace_wait{,3,4,6,id,pid}

dbregs2:
    Verify that setting DR0 is preserved across ptrace(2) calls

dbregs3:
    Verify that setting DR1 is preserved across ptrace(2) calls

dbregs4:
    Verify that setting DR2 is preserved across ptrace(2) calls

dbregs5:
    Verify that setting DR3 is preserved across ptrace(2) calls

These tests are deliberately fine-grained as they are expected to penetrate
precisely each functional aspect of CPU Debug Registers on amd64 one after
another.

These tests (and MI ones) might be generated or merged with helper
functions, however in order to copy-and-paste them out of a test-suite and
quickly port to other platform (in order to compare results) it's useful to
keep them as stand-alone as they are.

Code from these tests might be shared with other ports in future, for the
same reason keep them currently as they are.

Sponsored by <The NetBSD Foundation>

(kamil)

fix typo. ping6 deadline option is not "-w" but "-X".

(knakahara)

Refactor location of amd64-specific ATF tests to new dir kernel/arch/amd64

Rename
- tests/kernel/t_ptrace_amd64_wait.c
to
- tests/kernel/arch/amd64/t_ptrace_wait.c
and adapt appropriate files accordingly.

New directory will be used for more amd64-specific tests, verifying the
MD parts of the kernel.

Remove old entries from distrib/sets/lists as they were added a while ago.

Sponsored by <The NetBSD Foundation>

(kamil)

fix accidentally if_pppoe atf failure depends on cpu workload.

(knakahara)

Respect MKSHARE=no.

(riastradh)

Mark lvm and npf shlibs as such.

(riastradh)

cvslatest(1) is unconditional, doesn't use cvs(1).

(riastradh)

print-ip6.c is needed even with MKINET6=no.

Provides print_ip6 used by various other objects, with different
definitions depending on #ifdef INET6.

(riastradh)

fix: ifp->if_obytes and ifp->if_omcasts are not counted up for packets which is sent later.

pointed out by ozaki-r@n.o, thanks.

(knakahara)

Fix !amd64 sets

Sponsored by <The NetBS Foundation>

(kamil)

CID 1396598, CID 1396634: Fix null pointer dereferences

(ozaki-r)

Add t_ptrace_amd64_wait{,3,4,6,id,pid} tests

Sponsored by <The NetBSD Foundation>

(kamil)

Add new test file t_ptrace_amd64_wait.c and refactor t_ptrace_*wait* tests

Clone t_ptrace_wait.c to t_ptrace_amd64_wait.c and put common parts to
t_ptrace_wait.h.

The t_ptrace_amd64_wait.c file is dedicated to hold amd64-specific tests
for the ptrace(2) interface.

Add new basic test dbreg1 in t_ptrace_amd64_wait{,3,4,6,id,pid}:
    Verify plain PT_GETDBREGS with printing Debug Registers

Fix evbarm64-aarch64 issue pointed by <christos>, kill1 and kill2 tests
must be defined without PT_STEP guards.

Sponsored by <The NetBSD Foundation>

(kamil)

n dl_iterate_phdr return the path not the name.

(christos)

on NetBSD we don't have llvm_symbolizer, so try addr2line...

(christos)

use the right sysctl to find the main binary name. We don't really need
this since our dl_iterate_phdr DTRT's for objmain, but...

(christos)

CID 1396620: Null pointer dereferences

(mlelstv)

- Change vcache_reclaim() to always call VOP_INACTIVE() before VOP_RECLAIM().
  When called from vrecycle() or vgone() there is a window where the refcount
  is greater than zero and another thread could get and release a reference
  that would miss VOP_INACTIVE() as the refcount doesn't drop to zero.

  Adjust test fs/puffs/t_basic:  test VOP_INACTIVE count being greater zero.

- Make vrecycle() more robust by checking v_usecount first and preventing
  further references across vn_lock().  Fixes a deadlock where one thread
  starts unmount, second thread locks a directory and allocates a vnode
  and first thread tries to vrecycle() the directory.
  First thread holds vfs_busy and wants vnode, second thread holds vnode
  and wants vfs_busy.

- With these fixes in place change cleanvnode() to use vget()/vrecycle()
  to reclaim the vnode.

(hannken)

Instead of using a function to resolve symbols that should be supplied by
the dynamic linker itself, use a version script that exposes them. From joerg@

(christos)

Regen.

(msaitoh)

- Add more Intel 10G devices
- indent

(msaitoh)

Add forgotten ixgbe_x550.c and ixgbe_x550.h.

(msaitoh)

Update ixg(4) and ixv(4) up to FreeBSD r282299:
- Add support for X55x.
- ADD EEE support (not tested).
- Add WOL support (not tested).
- Add suspend/resume support (not testd).
- Add LPLU support (not tested).
- Add DMA Coalescing (note verified).
- Not tested well for sysctls.
- Fix ixgbe_set_advertise() a bit. At least, FreeBSD r294578 is required
  to work hw.ixg0.advertise_speed sysctl correctly.

(msaitoh)

ixv.h is no more.

(msaitoh)

Update ixg(4) and ixv(4) up to FreeBSD r280197:
- Add support for 82599_QSFP_SF_QP and X540T1.
- Add partial support for X55x. It's required to sync with FreeBSD r282299
  to support X55x.
- Bugfixes.

(msaitoh)

s/netbds32_copyout_statvfs/netbsd32_copyout_statvfs/

(mrg)

support Tx multiqueue for 82574(aka e1000e for VMware and QEMU).

(knakahara)

fix two races between set_ip_addrs and clear_ip_addrs race.

    (1) if set_ip_addrs and clear_ip_addrs run parallel, they can parallel call
        IN_ADDRHASH_WRITER_REMOVE to the same ifa.
    (2) if set_ip_addrs's workqueue is separated from clear_ip_addrs's one,
        the workers can run in reverse order of enqueued.

(knakahara)

fix CID 1396600: Null pointer dereferences

(knakahara)

extend the pmap_activate/pmap_deactivate UVMHIST logs to include the
pid, lid, and either l_name or p_comm.

(mrg)

document new UVMHIST_MAPHIST_SIZE and UVMHIST_PDHIST_SIZE options.

(mrg)

allow the sizes of the maphist and pdhist to be set in the config
file via UVMHIST_MAPHIST_SIZE and UVMHIST_PDHIST_SIZE.

(mrg)

fix the output of ddb's "show uvmexp" and also print the
reserve_pagedaemon, reserve_kernel, and zeropages values.

(mrg)

orrect the text for fileassoc_table_run() - it takes two parameters.

(pgoyette)

Add new tests kill[12] in t_ptrace_wait{,3,4,6,id,pid}

New tests verify that PT_CONTINUE with SIGKILL is equivalent to PT_KILL.

kill1:
    Verify that PT_CONTINUE with SIGKILL terminates child

kill2:
    Verify that PT_KILL terminates child

Sponsored by <The NetBSD Foundation>

(kamil)

add missing newline in comment

(christos)

Emulate the standard symbol search order in dlsym() i.e. resolve weak or
not found symbols that are in the dynamic linker list of exported symbols
from the dynamic linker itself.

(christos)

grr. usec is also os_time_t :-(

(christos)

Extra "buf->map = NULL;"s in ixgbe_txeof() were removed in FreeBSD r282299.
This was fixed in NetBSD's ixgbe.c rev. 1.28. Remove our comment.

(msaitoh)

Fix panic on destroying an interface with IPv6 addresses obtained with RA

nd6_purge depends on that IPv6 addresses are purged. If addresses remain,
pfxlist_onlink_check called from nd6_purge dereferences a dangling pointer
(ia->ia6_ndpr) that is freed before calling pfxlist_onlink_check. Fix it by
removing addresses before calling nd6_purge, which is the original behavior
that was changed by in6.c,v 1.203 and in6_ifattach.c,v 1.99.

Note that it seems the issue occurs because of a hack that forcibly destroys
prefix list entries of a given interface in nd6_purge. We should tackle the
hack in the future.

Fix PR kern/51467

(ozaki-r)

Don't call virtio_enqueue_abort when virtio_enqueue_reserve fails.
Pointed out by uwe@

(christos)

Build gallium with -pthread if we're building the radeon driver. It uses a
thread, so without this the driver doesn't load and nothing works. ok mrg

(dholland)

PR 51672 David Binderman: M_CSUM_TCPv6, not 2x M_CSUM_TCPv4.
(from context it's quite clear that's what's supposed to be here)

(dholland)

Fix the "typical usage" example for enqueuing a request - if
bus_dmamap_load(9) fails, we shouldn't call bus_dmamap_unload(9).

(uwe)

Add new tests dbregs[12] in t_ptrace_wait{,3,4,6,id,pid}

dbregs1:
    Verify plain PT_GETDBREGS call without further steps

dbregs2:
    Verify PT_GETDBREGS and PT_SETDBREGS calls without changing regs

These tests are to be used to verify CPU Debug Register accessors in the
ptrace(2) interface.

Additionally fix also fpregs2 test to really call PT_SETFPREGS.

Sponsored by <The NetBSD Foundation>

(kamil)

vioif_start() - do not call virtio_enqueue_abort() after error from
virtio_enqueue_reserve(), as it's already done by the latter, so we
ended up with a kind of "double free" that messed up out free list of
vq_entry's.

This is even documented in a "typical usage" comment in virtio.c (and
those quotes are not intended to be sarcastic).

PR 51132 - virtio net device stuck for UDP burst transmission

(uwe)

Add more tests for PT_STEP step[234] in t_ptrace_wait{,3,4,6,id,pid}

step2:
    Verify PT_STEP called twice

step3:
    Verify PT_STEP called three times

step4:
    Verify PT_STEP called four times

The purpose of these tests is to assert that PT_STEP can be called more
than once and it sill works.

Sponsored by <The NetBSD Foundation>

(kamil)

PR/51673: Carsten Kunze: curses: standend() does not turn off A_BOLD;
according the X/Open it needs to turn off all attributes.

(christos)

sqlite3-3.15.2 out.

(wiz)

Sync with HEAD

(skrll)

Ensure the softc lock is not held in ucom_shutdown as the call to ucom_dtr
can sleep.

(skrll)

reference count adapter mutex possibly shared by multiple channels.

fix error in atapibusdetach, when a child device cannot be detached,
keep atapibus instance alive.

(mlelstv)

Add new test step1 in t_prace_wait{,3,4,6,id,pid} under PT_STEP guards

step1:
  Verify single PT_STEP call.

This function is calculating happy numbers just to consume CPU cycles for
the test purpose.

PT_STEP raises SIGTRAP to by caught by a debugger.

Sponsored by <The NetBSD Foundation>

(kamil)

Mark a variable __diagused as it is only ever used in a KASSERT

(martin)

If we are inserting spaces to account for a tab, move the x position of the
cursor, otherwise this is a no-op (Carsten Kunze)

(christos)

New sentence, new line.
Use more/better formatting.
Fix a typo.

(wiz)

Provide a man page for the disk driver subroutines (dksubr).

(mlelstv)

Extend dkdriver interface with a d_firstopen function. This is called
by dk_open() for the first opener and mirrors the use of the d_lastclose
callback.

Bump kernel version for the interface change.

(mlelstv)

Fix vlan check bug in ixv_setup_vlan_support().

(msaitoh)

Calculate CPU usage (pcpu) once per process if it is required. This change
significantly improves performance for slow machines when output is sorted
by pcpu.

ok martin

(rin)

for donlist{,_sysctl}:
- obtain log_ccpu = log(ccpu) rather than ccpu itself
- use common default values and warn users appropriately when errors occur
ok martin

(rin)

KNF
ok martin

(rin)

Use redirection instead of pipeline

This is a workaround for PR bin/51667.

(ozaki-r)

fix build of ixv enabled NO_PCI_MSI_MSIX option.

(knakahara)

fix build of amd64/i386 with NO_PCI_MSI_MSIX option.

(knakahara)

fix non-DIAG builds.

(mrg)

FreeBSD r280181 made new file ix_txrx.c and moved ixgbe.c and ixv's common
code into it. Before sync with whole of them, just move ixgbe.c and ixv.c's
common code into ix_txrx.c from ixgbe.c. In this commit, only ixgbe.c is split
into the device dependent part and the common part. ixv.c isn't change to make
this commit no functional change. To use ixv.c with ix_txrx.c, it's required
to modify the common part's API and functions themselves.

This commit is done to make the next change easy to understand.

(msaitoh)

Don't check parent capabilities when a parent interface hasn't been
assigned.

(joerg)

Do not attempt to pass -llinfo to route.

llinfo was removed, and the command fails because of it.

(maya)

switch vax to new binutils and gdb.

(christos)

regen for vax

(christos)

regen for vax

(christos)

fix printf formats for time_t

(christos)

Add accessors for available x86 Debug Registers

There are 8 Debug Registers on i386 (available at least since 80386) and 16
on AMD64. Currently DR4 and DR5 are reserved on both cpu-families and
DR9-DR15 are still reserved on AMD64. Therefore add accessors for DR0-DR3,
DR6-DR7 for all ports.

Debug Registers x86:
* DR0-DR3  Debug Address Registers
* DR4-DR5  Reserved
* DR6      Debug Status Register
* DR7      Debug Control Register
* DR8-DR15 Reserved

Access the registers is available only from a kernel (ring 0) as there is
needed top protected access. For this reason there is need to use special
XEN functions to get and set the registers in the XEN3 kernels.

XEN specific functions as defined in NetBSD:
- HYPERVISOR_get_debugreg()
- HYPERVISOR_set_debugreg()

This code extends the existing rdr6() and ldr6() accessor for additional:
- rdr0() & ldr0()
- rdr1() & ldr1()
- rdr2() & ldr2()
- rdr3() & ldr3()
- rdr7() & ldr7()

Traditionally accessors for DR6 were passing vaddr_t argument, while it's
appropriate type for DR0-DR3, DR6-DR7 should be using u_long, however it's
not a big deal. The resulting functionality should be equivalent so stick
to this convention and use the vaddr_t type for all DR accessors.

There was already a function defined for rdr6() in XEN, but it had a nit on
AMD64 as it was casting HYPERVISOR_get_debugreg() to u_int (32-bit on
AMD64), truncating result. It still works for DR6, but for the sake of
simplicity always return full 64-bit value.

New accessors duplicate functionality of the dr0() function available on
i386 within the KSTACK_CHECK_DR0 option. dr0() is a specialized layer with
logic to set appropriate types of interrupts, now accessors are designed to
pass verbatim values from user-land (with simple sanity checks in the
kernel). At the moment there are no plans to make possible to coexist
KSTACK_CHECK_DR0 with debug registers for user applications (debuggers).

    options KSTACK_CHECK_DR0
    Detect kernel stack overflow using DR0 register.  This option uses DR0
    register exclusively so you can't use DR0 register for other purpose
    (e.g., hardware breakpoint) if you turn this on.

The KSTACK_CHECK_DR0 functionality was designed for i386 and never ported
to amd64.

Code tested on i386 and amd64 with kernels: GENERIC, XEN3_DOMU, XEN3_DOM0.

Sponsored by <The NetBSD Foundation>

(kamil)

Fix rdr6() function on amd64

According to the AMD64 SysV ABI the first returned value is passed in RAX,
not in RDI. Actually RDI is used for the first argument passed to a
function.

So far this function was dead code, it will be used for a ptrace(2)
feature to support CPU watchpoints.

The rdr6() function reads state of the DR6 register and returns its value.

Sponsored by <The NetBSD Foundation>

(kamil)

spaces to tabs

(maya)

More of previous.

(dholland)

fix comment about initialization-time calls; ok joerg

(dholland)

PCI MSI/MSI-X manipulation stub functions are not provided as weak alias.

(nonaka)

mention PAX_SEGVGUARD dependency on FILEASSOC

(christos)

Mention fileassoc dependencies

(christos)

size routine returns -1 on error, not an error code.

(mlelstv)

+librumpnet_vlan.so.0.0.debug

(njoly)

Fix NetBSD keyword expansion.

(njoly)

regen

(skrll)

Add an axe(4) from FreeBSD

(skrll)

Trailing whitespace

(skrll)

Add: PCB process control block

(kamil)

Skip dumping if no bus is used

(ozaki-r)

Add basic tests for vlan(4)

(ozaki-r)

Rumpify vlan(4)

(ozaki-r)

Print integers as hex with %#x rather than with plain %x

# if used with o, x or X specifiers the value is preceeded with 0, 0x or 0X
respectively for values different than zero.

Noted by <christos>

Sponsored by <The NetBSD Foundation>

(kamil)

Set path for includes_HEADERS.  Change suggested by christos@.

(jnemeth)

1.6 was the first amd64 release. (although it didn't really work too well
before -5)

(dholland)

Note that really old compat is only useful for running 32-bit binaries.

XXX: someone please indicate what the oldest possible extant x86_64
binaries are; I can't find an authoritative source.

(dholland)

fileassoc is used by PaX as well as veriexec - update note accordingly.

(dholland)

sort iwm* before iwn*

(dholland)

The compat options should all be in one block.

(dholland)

PR/51652: Sevan Janiyan: makefs dies due to segmentation fault
Don't dereference NULL when running out of nodes during rename.

(christos)

Fix several printf(3)-like functions usage with printing integers

Integers as hex shall no be printed with PRIx8, but with plain "x".

Pointed by <christos>

Sponsored by <The NetBSD Foundation>

(kamil)

Add a missing newline in help message.

(tsutsui)

regen

(skrll)

Add an axe(4) device from OpenBSD

(skrll)

Remove this comment and allow the beginning of .data to be mapped with
large pages. The issue is fixed, the lapic va is dynamically allocated
now.

(maxv)

Move the virtual address of the LAPIC page out of the data segment on amd64
and i386. The old design was error-prone, and it didn't allow us to map the
data segment with large pages.

Now, the VA is allocated dynamically in the pmap bootstrap code, and entered
manually later. We go from using &local_apic to using *local_apic_va, and we
therefore need one more level of indirection in the asm code.

Discussed on tech-kern.

(maxv)

cast to register_t because not all 'struct reg' members are the right type.

(christos)

Remove #ifdef NETBSD_MSI_OR_MSIX to be simple. ixv(4) isn't attached if
__HAVE_PCI_MSI_MSIX isn't set because MSI-X must be used.

(msaitoh)

+#include "opt_usb.h"

(skrll)

+__KERNEL_RCSID

(skrll)

Don't always define UGENSA_DEBUG

(skrll)

Sort opt_* #includes

(skrll)

Remove UZCOM_DEBUG

(skrll)

KNF a little

(maxv)

"#ifdef __HAVE_PCI_MSI_MSIX" workaround is not required any more.

see sys/dev/pci/pci_stub.c r1.6

(knakahara)

provide all PCI MSI/MSI-X manipulation stub functions.

"#ifdef __HAVE_PCI_MSI_MSIX" workaround such as nvme_pci(4) is not required
any more.
    http://mail-index.netbsd.org/source-changes/2016/09/17/msg077799.html

(knakahara)

Initialize the module map limits in amd64, not x86.

For the record: normally we could enable this code on Xen, since the
bootstrap layout is globally the same. But there appears to be an issue
in xen_locore, since any kenter in the area after kern_end triggers a
KASSERT because the va is already busy.

(maxv)

Share rump_server start/stop and interface creation/destruction functions

The common functions store socks of rump_servers, interfaces of rump_servers
and buses that intefaces connect and allow to destroy them with common
functions without specifying which socks, interfaces and buses we should
destroy.

This change reduces lots of similar setup/cleanup codes.

(ozaki-r)

Add $DEBUG and remove a unused function

(ozaki-r)