Sprinkle __predict_false() in the RX path.

(msaitoh)

PR lib/56388

Regen addstr2.chk after fix for the line-hash bug in libcurses.

Now, all t_curses tests successfully pass on all platforms I have tried.

Thanks blymn@ for kind advice!

(rin)

PR lib/56388

For __newwin() and __resizewin(), the line hash was calculated as if
HAVE_WCHAR is disabled.

Fix this bug by refactoring __hash_line() function, which calculates
the line hash by an appropriate method.

(rin)

fix various typos in comments.

(andvar)

tests/make: test modifier ':S' with replacement '&'

Before 2020-08-30, OpenBSD make incorrectly copied the anchors '^' and
'$' to the replacement string.  Just guard against this possible bug.

(rillig)

fix typos in word "segment" and two additional typos in if_tl.c.

(andvar)

make: fix typos in comments

(rillig)

libldap: fix undefined behavior in ldap_int_tls_connect

The function isdigit must not be called with 'char' as argument.

https://bugs.openldap.org/show_bug.cgi?id=9668

(rillig)

libipsec: fix undefined behavior when calling isprint

(rillig)

Always autogen fileio.h.

Bump CURSES_LIB_MAJOR.CURSES_LIB_MINOR to 9.0 belatedly.

(rin)

Instead of requiring drivers to be explicit about their device memory
mapping requirements, move this decision into the fdt layer. This
introduces a new MD function, fdtbus_bus_tag_create, which is responsible
for returning per-node bus_space handles.

(jmcneill)

Make no diff to upstream

(ryoon)

Clamp zfs nlinks at UINT32_MAX (nlink_t max) instead of (much) smaller
16-bit LINK_MAX until we bump LINK_MAX.  Fixes fts(3) problems with
"rm -rf" on zfs directories with > 32766 subdirectories.

Thanks mlelstv@ and mrg@ for helping debug this.

(simonb)

Style fixes most for __CTRACE().

(rin)

Unifdef DEBUG for CTRACE().

(rin)

Expand __CTRACE() to __nothing #ifndef DEBUG.

Remove most of #ifdef DEBUG around __CTRACE() calls.

No binary changes, except for line numbers for assert().

(rin)

Fix old-style definition: curses_version() --> curses_version(void)

(rin)

Fix old-style definition: use_default_colors() --> use_default_colors(void)

(rin)

regen.

(mrg)

the CPU ident and AMD both say this is "R2 Graphics", not R3.

(mrg)

tests/stdio: use standard ATF tools for verifying the test output

In case of a test failure, this outputs a diff between the actual and
expected files.

Even with the smaller buffer size LMAX, the fully buffered test fails.
It does so after printing numbers up to 12773, which together take 65532
bytes.  The next number, 12774, would cross the 65536 boundary, but
instead of that number, 12710730 was written.

(rillig)

tests/stdio: wrap test command with atf_check

Previously, the test output was:

FAILED: Test case body returned a non-ok exit code, but this is
    not allowed

In many cases, the test now succeeds, but in some cases it fails:

h_testnumbers: bad line "1287185
", expected 12774

h_testnumbers: bad line "6186889
", expected 6154889

(rillig)

tests/stdio: on test failure, print more details

On amd64, the test stdio_intr_iofbf fails:

stdout: numbers.in...iw.ir.ir. OK
stderr: h_testnumbers: bad line 3914889

This information is not enough to get a complete picture of the
situation, so provide more details.

(rillig)

lint: remove source code references from internal error message

The additional strings that are provided with the error message are
distinctive enough.

(rillig)

lint: extract function for reading a single line from a .ln file

No functional change.

(rillig)

tests/lint: document placement of lint comments

(rillig)

tests/lint: clean up test for misplaced lint comments

A varargs comment that appears in the function body is already covered
by varargs_bad_body.  Cleaning up this test makes sure that the warning
is indeed triggered by the comment in the parameters declaration.

(rillig)

lint: reduce number of ifdef names

No functional change.

(rillig)

lint: hide irrelevant type information from lint2

No functional change.

(rillig)

lint: do not warn about comparison 'unsigned <= 0'

Seen in scanners generated by Flex, and about 50 occurrences in the
NetBSD src and xsrc tree, all of which are not suspicious of being bugs.

(rillig)

Move SOB to offensive acronyms.

(alnsn)

tests/lint: test comparison of 'unsigned <= 0'

(rillig)

lint: suppress remaining lint warnings in generated scan.c

Warning 162 about 'unsigned <= 0' feels too ambitious, it may be
restricted to the clearly wrong 'unsigned < 0' in the future.

Warnings 192 and 214 are a result of the strict bool check, but the
error messages are suppressed, which makes it hard to see why lint says
the local variable were unused and the function would not return a
value.

Warning 307 about unused static variables is OK for generated code.

(rillig)

lint: fix some more lint warnings

The only remaining warnings are in scan.c, which is a generated Flex
scanner.

No functional change.

(rillig)

lint: fix lint warnings

(rillig)

lint: clean up CPPFLAGS for xlint

In 1995, the file mem.c was in ../lint1.  In 2002, these files were
moved to ../common instead.

(rillig)

lint: generate date of lint.7 from err.c

(rillig)

Remove unused arm_fdt_memory_dump

(jmcneill)

lint.7: document removed messages

Having just an empty string as the message was confusing.

(rillig)

Now, ctx_flush() never fails. So, make this function void.

(rin)

README: use https for man.NetBSD.org

(rillig)

pmap_enter_pv(): At the moment, this function is always called with
pmap_initialized. So, convert test for this condition to KASSERT.

(rin)

pmap_enter_pv(): No need to initialize npv to NULL.

No functional changes intended.

(rin)

pmap_testout(): Use pmap_{protect,remove}() for va to (va + PAGE_SIZE),
instead of (va + 1).

No functional changes for the current implementation. Also, this affects
only when the function is manually called from DDB on DEBUG kernel.

(rin)

Don't use __FBSDID, similar to kern/kobj.c, kern/misc.c, kern/sysevent.c

(mlelstv)

tests/lint: document the fixed assertion failure for struct

The change to cgram.y 1.328 from 2021-07-15 didn't fix the crash on
purpose, it was merely a side effect.  The grammar rule that probably
fixed this was that the error handling now skips to the next T_SEMI,
which it didn't do before.

(rillig)

Ticket #1342

(martin)

Pull up following revision(s) (requested by tsutsui in ticket #1342):

sys/arch/mips/mips/trap.c: revision 1.250
sys/arch/mips/mips/trap.c: revision 1.251

Add missing newline to a diagnostic printf.

Comment out the diagnostic message in the TLB_MOD handler that's logged if
pmap_tlb_update_addr() indicates that the VA+ASID was not found in the TLB.

It's a harmless race condition that can happen for legitimate reasons (e.g.
a TLB miss in an interrupt handler that evicts the entry from the TLB).

See discussion:
    http://mail-index.netbsd.org/port-mips/2020/03/07/msg000927.html

(martin)

osnet: fix lint warning about empty declaration

proc_bkpt.c(32): warning: empty declaration [0]

Use the same definition as in libarchive.

(rillig)

if (cond) panic() or Debugger() in #ifdef DIAGNOSTIC ---> KASSERT(!cond)

There is no regression observed during a full ATF run.

(rin)

avoid xnack, and -fp32-denormals, and +fp64-denormals options for
amdgpu / radeonsi driver.  these options don't work with llvm 13,
and generate warnings for all GL apps.

mesa 21 has entirely different code here.

(mrg)

make sure PCI_IOC_DRVNAMEONBUS doesn't access NULL pointers.

hopefully fixes PR#55744.  it's not entirely clear why this does
not affect most systems, as there's usually some PCI devices that
do not have attached drivers, eg:

006:00:0: AMD Family17h/7xh Reserved SPP (non-essential instrumentation, subclass 0x00)

on my system i'm testing on.

XXX: pullup-8, pullup-9.

(mrg)

tests/lint: provide more background information on signed '>>'

(rillig)

tests/lint: test error handling when reading .ln files

(rillig)

re(4): misc chip revision support changes
* remove impossible-to-match chip revision cases
* bring support for modern chips in line with FreeBSD and OpenBSD
  * adds support for RTL8168GU

Addresses PR kern/56312.

(jakllsch)

lint: reduce complexity of reading a function call

No functional change.

(rillig)

lint: inline local variables in outtype

No functional change.

(rillig)

lint: condense code for writing to a lint library

Same as in lint1.

No functional change.

(rillig)

Ignore mouse packets properly even if wsmouse(4) isn't configured.

The internal state of wskbd(4) could be mangled if mouse (which was
connected behind keyboard) was enabled by unexpected keyboard reset.
This could happen on the INSTALL kernel (no wsmouse(4) on it).

Based on a patch from moveccr, with several tweaks by me.

(tsutsui)

tests/lint: test old-style functions in a lint library

To really qualify as old-style, a function must not declare a return
type in its definition.

(rillig)

tests/lint: test writing of a lint library

The code for that is almost the same as in lint1, but only almost.

(rillig)

lint: make initialization of the basic types table simpler

No functional change.

(rillig)

tests/lint: test emitting format strings

(rillig)

lint: clean up outfstrg, which writes format strings

Most characters don't need outqchar, a simple outchar is often enough.

Since '\0' is not a digit, there is no need to check for that.

No functional change.

(rillig)

lint: move outqchar from common to lint1

(rillig)

lint: trim down the code for writing the output files

The output buffer is only needed in a single file, so unexport it.

When calling outname, the chances for the name being null are close to
zero, therefore omit the caller information.

(rillig)

Style. No binary changes.

Also, remove old #if-0'ed code block copied from oea (and therefore
will never be enabled).

(rin)

lint: use 'char' as type for passing characters to functions

No functional change.

(rillig)

lint: remove _Complex from tspec_name

That type is only used in the parser; the expression trees use FCOMPLEX,
DCOMPLEX or LCOMPLEX instead.

Sort the typeinfo definitions according to their order in tspec_t.  Do
not add _Complex there since it is not needed.  This means that NOTSPEC
and COMPLEX would both trigger an internal error.

(rillig)

lint: remove duplicate code in tspec_name

No functional change.

(rillig)

lint: reduce indentation in tdeferr

No functional change.

(rillig)

Fix build without DEBUG.

(rin)

lint: use unsigned integers for size calculations

No change for type definitions that are smaller than 128 MB.  For larger
types, integer overflow might occur, just like before.

(rillig)

Fix several styles and formats.

(tsutsui)

Use C99 designated initializer.

(tsutsui)

Use proper macro for device register addresses.

(tsutsui)

lint: remove redundant and duplicate code

(rillig)

Use fdt_iommu instead of calling appledart directly from applepcie

(jmcneill)

Add facility for registering iommus.

(jmcneill)

lint: spell out abbreviations in comments

No functional change.

(rillig)

lint: split declare_local into smaller functions

(rillig)

lint: remove unnecessary includes

The type definitions used to depend on the host's platform
characteristics once, which required <limits.h>.

(rillig)

lint: sort operators in typeok_op according to ops.def

Well, except for INIT, FARG, RETURN.  These are listed at the very
bottom of the operators table but still behave much like ASSIGN.

No functional change.

(rillig)

lint: extract typeok_point and typeok_arrow from typeok_op

No functional change.

(rillig)

lint: clean up switch statement in typeok_op

In the old times where typeok_op was inlined into typeok, it was
necessary to write the complicated if-not-return-break.  Not anymore.

No functional change.

(rillig)

lint: make typeok_quest simpler

No functional change.

(rillig)

Fix typo to correctly initialize call_once2_pic_profile.

(rin)

Use MI subr_disk_mbr.c for proper MBR and bi-endian supprot.

No special MD handling in previous.  Briefly tested on gxemul 0.6.3.

(tsutsui)

Use C99 designated initializer.

(tsutsui)

Fix inverted logic in OpenSSH SSHFP DNS record verification

(ryoon)

Cosmetic fixes. No functional changes intended.
- Reorganize logic to reduce indent levels significantly.
- Use ``for'' rather than ``while''.

(rin)

Fix typos in comments and add missing KERNEL_RCSID

(gutteridge)

lint: set the return type of __builtin_*_overflow to bool, not int

Needed for inetd.c in strict bool mode.

(rillig)

tests/lint: test GCC builtins for overflow in strict bool mode

Seen in inetd.c.

(rillig)

s/existant/existent/ in comments and messages, plus few more similar fixes.

(andvar)

lint: extract build_name_call from build_name

This reduces the indentation, providing enough space to write out the
full diagnostic in the code.  It also prepares for supporting GCC
builtins like __builtin_add_overflow, which return _Bool instead of int.

No functional change.

(rillig)

s/opions/options/

(andvar)

fix typos in comments, mainly s/extention/extension/ and s/sufficent/sufficient/

(andvar)

inetd: remove redundant tests before calling isspace

(rillig)

Only define ACPI_QUIET_BOOT for kernel builds

(jmcneill)

inetd: remove redundant null check before free

No functional change.

(rillig)

inetd: prepare for lint's strict bool mode

Lint's strict bool mode considers bool incompatible with the other
scalar types.  This makes the type of expressions more visible in the
code.  In particular, conditions of the form '!strcmp(...)' are no
longer allowed, they have to be written as 'strcmp(...) == 0'.

The operator '!' cannot be used with sep->se_wait since that has type
pid_t, not bool.

No change to the resulting binary.

(rillig)

inetd: normalize indentation and alignment in comments

(rillig)

switch smu to common fan control code

(macallan)

Ignore mouse packets to avoid unexpected data handled as keyboard input.

Patch from moveccr.

(tsutsui)

Try to refactor this in order to correct some of the memory issues
reported by Christian Holler.

(christos)

Suppress table loading messages if AB_QUIET or AB_SILENT flags are set.

(jmcneill)

add some more functions to namespace.h; add missing RCSIDs

(christos)

Tickets #1339 - #1341

(martin)

Pull up following revision(s) (requested by manu in ticket #1341):

sys/arch/x86/x86/pmap.c: revision 1.410

Make pat_init() a NOOP on XENPV; it causes a trap with Xen 4.15

(martin)

Pull up following revision(s) (requested by mrg in ticket #1340):

sys/dev/usb/ehci.c: revision 1.286

add missing newline and fix conditional for askroot/single user
hand over delay message.  PR#56366.

(martin)

Ticket #1693

(martin)

Pull up following revision(s) (requested by andvar in ticket #1693):

sys/dev/pci/if_vte.c: revision 1.32

Restore original MDC speed control register value after MAC reset, if
it wasn't default. Fixes PR port-i386/53494.

ok riastradh

(martin)

Pull up following revision(s) (requested by andvar in ticket #1339):

sys/dev/pci/if_vte.c: revision 1.32

Restore original MDC speed control register value after MAC reset, if
it wasn't default. Fixes PR port-i386/53494.

ok riastradh

(martin)

Save the discard_multidesc state to not to forget the state by exiting rxeof().

(msaitoh)

Rename variable. No functional change.

(msaitoh)

revert "make ahcisata(4) work on rk3399 (rockpro64)" from 23-06-2021.

this problem is known to affect more than AHCI, and a more general
solution has been commited now.

(mrg)

rk3399 pcie: pay attention to the "bus-scan-delay-ms" property.

our existing pinebookpro DTS, but not the other rk3399 ones, have
this property set to "1000" (it's the same in linux 5.14 DTS.)

as there are already static 100ms + upto 1000ms, count how many
are done, and only delay more to complete one second.

this allows reverting this device-specific change:

  http://mail-index.netbsd.org/source-changes/2021/06/23/msg130402.html

and makes other sorts of storage cards more likely to work as well.

tested on rockpro64.

XXX:  consider moving dts setting into rk3399.dtsi.

ok jmcneill jak

inspired by https://gitlab.manjaro.org/manjaro-arm/packages/core/linux/-/blob/master/0013-rk3399-rp64-pcie-Reimplement-rockchip-PCIe-bus-scan-delay.patch

(mrg)

regen.

(mrg)

add a whole bunch of radeon devices.

now all the radeons i have are here (and dozens i don't :)

(mrg)

apple: derive CPU speed from mpidr_el1

According to https://github.com/AsahiLinux/docs/wiki/HW%3AARM-System-Registers,
MPIDR_EL1 Aff2 determines whether a core is an efficiency or performance
core. Replace the compat data table with code that uses the aff2 value
for fake DMIPS/MHz value, to hopefully maintain compatibility with future
cores.

(jmcneill)

lint: split check_expr_misc into separate functions

No functional change.

(rillig)

lint: split check_assign_types_compatible into separate functions

No functional change.

(rillig)

tests/lint: test messages 183 and 187

(rillig)

lint: align tests for message 259, clarify its purpose

(rillig)

lint: fix unintended warning for converting long long to signed char

(rillig)

tests/lint: demonstrate unintended prototype warning for signed char

(rillig)

lint: move a condition into should_warn_about_prototype_conversion

No functional change.

(rillig)

lint: clean up should_warn_about_prototype_conversion

(rillig)

bump libssh

(christos)

New OpenSSH

(christos)

Merge our changes from OpenSSH-8.6 to OpenSSH-8.7

(christos)

Add missing NULL check for __pmap_pv_alloc() (== pool_get() with
PR_NOWAIT) in __pmap_pv_enter().

Then, handle this failure in pmap_enter(); return ENOMEM if
PMAP_CANFAIL, and panic otherwise.

(rin)

PR port-sh3/56381

pmap_enter() returns ENOMEM if __pmap_pte_alloc() fails and PMAP_CANFAIL
flag is specified. In this case, remove pv via __pmap_pv_remove() if it is
added to p-v map list via __pmap_pv_enter().

Otherwise, pmap becomes an inconsistent state, which results in an infinite
loop in pmap_page_protect(), as reported in the PR.

Also, KASSERT's are added for sure, in order to detect the infinite loops.

Great thanks to chs@ for finding out this bug!!

(rin)

lint: fix typo in assertion

(rillig)

make: rename for_var_len to ExprLen

The text ${VAR} is not a variable, it's a variable expression.

No functional change.

(rillig)

make: inline strchr call, make ForLoop_SubstBody clearer

In ForLoop_SubstBody, GCC already merged the common subexpressions p[1]
and p[-1], but that was difficult to see for humans as well.

No functional change.

(rillig)

make: remove optimization for single-letter .for variables

Most .for loops have a single iteration variable.  For these loops, the
difference between the optimized and the unoptimized versions of the
code is negligible.

Remove the optimization since the comment for explaining it was almost
larger than the code itself.

(rillig)

Make the scheduler aware of the differences between efficiency and
performance cores.

(jmcneill)

tests/make: fix test directive-for-if

The additional lines 'VAR1' and 'VAR3' were supposed to be there from
the beginning.  I somehow managed to commit an inconsistent state of the
.mk and the .exp file.

(rillig)

Install IPI handler with non-NULL context.

A side effect of interrupt handlers with NULL context when using armpic
is that the interrupt handler is only called from interrupt context, not
when lowering spl!

(jmcneill)

fix few typos in comments.

(andvar)

s/optons/options/

(andvar)

lint: remove array creation from expr_derive_type

It is only used for creating string types.  The creation of other array
types happens in add_array.

This is a preparation to make all stored types const.

No functional change.

(rillig)

fix warnings

(christos)

conditional build fix.

(mlelstv)

PR port-arm/56264

Register all PICs when bcmicu1 is attached, in order to avoid calling
pic_add() from cpu_hatch(), which blocks for aarch64 kernel on RPI3.
This prevented MP kernel to boot due to KASSERT failure as described
in the PR.

This is a kind of a workaround; the real fix should be to

(a) reorganize cpu_hatch() for aarch64 and arm:
http://mail-index.netbsd.org/port-arm/2021/06/21/msg007320.html

(b) or change MI abstraction of ``MP ready'':
http://mail-index.netbsd.org/port-arm/2021/06/22/msg007327.html

However, still, this fix does not bring about any penalty, and it is
not good to leave RPI3 broken for months...

Tested on RPI3 (aarch64 MP, armv7hf MP) as well as RPI1 (armv6hf UP).

(rin)

lint: remove unnecessary switch statement

The switch statement covers only the few structural types, there is no
need to list all integer types as well.

No functional change.

(rillig)

lint: reduce verbose switch statement to table lookup

No functional change.

(rillig)

inetd: fix Clang build

error: implicit conversion changes signedness: 'service_type' to 'int'

(rillig)

tests/lint: add cross-references to message 297

The check for lossy integer conversions is already implemented, it's
just not activated in the default NetBSD build.

(rillig)

lint: extract condition for message 259 into separate function

No functional change.

(rillig)

tests/lint: add test for prototype conversions in C90

The purpose of warning 259 is to find function calls that differ in the
ABI.  The warning's original purpose was not to warn about lossy
conversions, that's just a side effect.

Warning 259 had been implemented before C99 was published, which is more
than 20 years ago.  In the meantime, almost all code has migrated to
using function prototypes.  With the default lint flags from NetBSD's
<sys.mk>, it would rather make sense to focus on lossy conversions now.

To prepare for potentially upcoming differences in lint's C90 and C99
modes, clone the test now as far as possible.  The test for C90 mode is
smaller than for C99 mode, since 'long long' was not available back
then.

(rillig)