pkgtools/url2pkg: document PY_TEST_FLAGS to prevent pkglint warning

(rillig)

doc: Updated pkgtools/url2pkg to 23.3.1

(rillig)

pkgtools/url2pkg: use deterministic filesystem lookups

Some filesystems return the filenames in unsorted order, so sort each
result of a 'glob' call. Reported by Adam Ciarcinski.

When looking for candidates for a package in the pkgsrc tree, only
consider directories that contain a Makefile. One of the url2pkg tests
looks for pkglint, and while a 'cvs update' is running, there is an old
entry 'devel/pkglint' in the filesystem that made the test fail.

(rillig)

doc: Updated pkgtools/pkglint to 23.4.2

(rillig)

pkgtools/pkglint: update to 23.4.2

Changes since 23.4.1:

Fixed the wrong suggestion that list variables or variables of an
unknown type could be compared using `${LIST} == word` instead of
`${LIST:Mword}`.

Fixed the wrong warning when a value is appended using `+=` to a
variable of unknown type.

(rillig)

doc: Updated pkgtools/pkglint to 23.4.1

(rillig)

pkgtools/pkglint: update to 23.4.1

Changes since 23.4.0:

Add riscv32 as a known hardware architecture.

Don't suggest a runtime dependency instead of TOOL_DEPENDS.

(rillig)

foomatic*-filters: fix pkglint warning about MANINSTALL

(rillig)

pkgtools/pkglint: update to 23.4.0

Changes since 23.3.0 from 2024-01-12:

Add riscv64 to the list of known hardware architectures.

Suggest removing parentheses around complete conditions.

Warn about duplicate DESCR files, except when one of the packages is in
pkgsrc-wip and the other is in main pkgsrc.

Fix crash when parsing '.ifndef VAR'.

(rillig)

doc: Removed chat/sirc and time/projclock

(rillig)

time/projclock: remove broken package

Using the package unconditionally results in 'No such file or
directory'.

https://mail-index.netbsd.org/pkgsrc-users/2024/01/14/msg038787.html

(rillig)

chat/sirc: remove broken package

The package doesn't support destdir builds, which had been enabled for
years now.

https://mail-index.netbsd.org/pkgsrc-users/2024/01/14/msg038786.html

(rillig)

mk/check-files: actually enable CHECK_FILES_STRICT

The files in ERROR_DIR must not start with a dot, or they are simply
ignored.

No change in the default configuration, since CHECK_FILES_STRICT
defaults to no.

(rillig)

mk/check-files: allow detection of packages that install outside PREFIX

An example package that does this is textproc/p5-Publican, many other
packages are fine.

(rillig)

mk/check-file: use common filename prefix in WRKDIR

(rillig)

mk/check-files: fix indentation of backslashes after ${RUN}

In 2008, when ${_PKG_SILENT}${_PKG_DEBUG} was replaced with the shorter
${RUN}, the backslashes were accidentally moved away from their
canonical position.

(rillig)

mk/check-files: clean up redundant 'defined' and variable alignment

(rillig)

mk/check-files: avoid leaning toothpicks syndrome

In the :C modifiers, there is no reason to use '/' as delimiter when the
search pattern or the replacement contains a literal '/' as well, which
then has to be escaped as '\/'.

While here, add two more variables to show-all-check-files, as pkglint
started warning about them.

(rillig)

mk/check-files: fail more gracefully on typos in MAKE_DIRS_PERMS

Previously, building a package that had the wrong number of words in
MAKE_DIRS_PERMS failed with "can't shift that many", which didn't give a
hint at the underlying problem.  Now it fails immediately, pointing to
the line in check-files.mk that loops over MAKE_DIRS_PERMS and
OWN_DIRS_PERMS.

(rillig)

mk/check: clean up check-fakehome and check-files

(rillig)

mk/check: remove documentation that was never implemented

(rillig)

lang/perl5: fix typo in documentation about PERL5_PACKLIST

(rillig)

lang/perl5: add show-all-perl5-packlist target for debugging

(rillig)

mk/buildlink3: remove documentation about PKG_PHASE

The PKG_PHASE variable was removed with the addition of
mk/bsd.pkg.barrier.mk 1.1 from 2006-07-05.

(rillig)

textproc/p5-Publican: fix destdir references in .packlist

The .packlist file that is installed as part of this package is
completely wrong, as it lists files in '/etc' and '/usr/share' that are
not part of this package.

Bump PKGREVISION.

(rillig)

pkgtools/url2pkg: omit lowercase Perl dependencies, sort dependencies

(rillig)

pkgtools/url2pkg: test Perl module with several dependencies

(rillig)

pkgtools/url2pkg: fix license_default line in generated makefile

Previously, url2pkg generated a 'license_default=...' line in the
package Makefile, which was confusing. That line was supposed to be a
special url2pkg command, not a makefile variable.

Discovered by gdt@ while packaging devel/p5-Devel-Entropy.

(rillig)

doc: Updated pkgtools/url2pkg to 23.3.0

(rillig)

pkgtools/url2pkg: update to 23.3.0

Changes since 23.2.1:

For Perl and Python packages, use TOOL_DEPENDS instead of BUILD_DEPENDS
for the build-time dependencies.

For Perl modules that use Module::Build, don't add a redundant
dependency to p5-Module-Build.

(rillig)

pkgtools/url2pkg: skip p5-Module-Build for Module::Build Perl packages

That dependency is added implicitly whenever PERL5_MODULE_TYPE is
Module::Build.

Suggested by gdt@.

(rillig)

url2pkg: use TOOL_DEPENDS for Perl and Python modules

Suggested by gdt@.

(rillig)

devel/rt-pgsql: bump revision due to fixed references to stale destdir

(rillig)

devel/rt-mysql: fix references to stale destdir, bump revision

(rillig)

print/p5-PostScript: fix references to stale destdir, bump revision

(rillig)

security/mit-krb5: remove unknown configure option

(rillig)

devel/p5-constant-def: remove references to stale destdir

Bump PKGREVISION.

(rillig)

devel/p5-DynaLoader-Functions: fix references to stale destdir

Bump PKGREVISION.

(rillig)

databases/gnats: fix reference to temporary destdir, bump revision

(rillig)

wm/fvwm-themes: remove references to destdir, bump revision

(rillig)

math/fftw: skip check for unknown configure options

The package has 3 configure script, and the top-level configure script
knows all of --disable-fortran, --enable-shared and --enable-threads.

(rillig)

wm/amiwm: fix references to temporary destdir, bunp revision

(rillig)

lang/rust: remove references to build-time DESTDIR

When the package is installed, the temporary DESTDIR directory doesn't
exist anymore, so there's no point referring to it.

Bump PKGREVISION.

(rillig)

doc/CHANGES-2023: clean up wrong entries, assisted by pkglint

(rillig)

doc: Updated pkgtools/pkglint to 23.3.0

(rillig)

pkgtools/pkglint: update to 23.3.0

Changes since 23.2.5:

Do not warn about Meson packages that only use Python as a build-time
tool.

Warn about pkgsrc-wip packages that are missing COMMIT_MSG.

Ignore errors when resolving the username of the current user. This can
happen on systems where the user database uses NIS. In case of an error,
assume that the user is neither maintainer nor owner of any package.

Mark variables from expressions in .info, .warning and .error as used.

Remove the word 'please' from the diagnostics, as the diagnostics are
intended to help the package author, not some unrelated third-party
person.

(rillig)

lang/kotlin: fix build on platforms that are missing pax

(rillig)

audio/cddbd: remove references to temporary DESTDIR

Detected by building with CHECK_WRKREF=destdir.

While here, remove MESSAGE as the motd is not essential to this package.

Bump PKGREVISION.

(rillig)

mk/check-wrkref: allow to disallow DESTDIR in the binary package

When a package is built, it first gets installed into DESTDIR, which is
somewhere below WRKDIR.  From there, a binary package is created, which
is then installed via pkg_add.  After this step, the value of DESTDIR is
no longer relevant, thus there is no reason to refer to that directory
from the final binary package.

This new check is not enabled by default, to allow for an opt-in testing
phase first.

(rillig)

games/ufoai: fix stray DESTDIR in binaries

(rillig)

pkgtools/pkglint: update to 23.2.5

Changes since 23.2.4:

For Python packages that do not support Python 2, warn that egg.mk is
deprecated and should be replaced with wheel.mk.  Provide detailed
migration instructions.

(rillig)

textproc/cjose: fix CVS keyword expansion in patch file

(rillig)

lintpkgsrc, regress: update references to pkglint files

The source code of pkglint is no longer stored in pkgsrc itself.

(rillig)

lintpkgsrc: fix typo in usage message

(rillig)

mk/curses: don't search for makefiles outside the pkgsrc directory

(rillig)

doc: Updated pkgtools/pkglint to 23.2.4

(rillig)

pkgtools/pkglint: update to 23.2.4

Changes since 23.2.3:

Do not warn about buildlink3 identifiers that are only known when the
package includes a buildlink3.mk file from the infrastructure.

(rillig)

doc: Updated pkgtools/pkglint to 23.2.3

(rillig)

pkgtools/pkglint: update to 23.2.3

Changes since 23.2.2:

Warn about platform-specific variables in parameterized variables,
except for OPSYS-specific variables in conditions for that particular
operating system.

Allow the tilde character in lists of Go modules.

Use correct plural form in messages about invalid characters.

(rillig)

doc: Updated pkgtools/pkglint to 23.2.2

(rillig)

pkgtools/pkglint: update to 23.2.2

Changes since 23.2.1:

Do not wrongly warn when adding a tool that is only available on
${OPSYS} to CONFIGURE_ENV.${OPSYS}.

Use proper capitalization for 'makefile' in a few places, when referring
to the general file format instead of a file named exactly 'Makefile'.

(rillig)

doc: Updated pkgtools/pkglint to 23.2.1

(rillig)

pkgtools/pkglint: update to 23.2.1

Changes since 23.2.0:

Warn about language features that are listed in USE_LANGUAGES but rather
belong in USE_CC_FEATURES or USE_CXX_FEATURES.

Check each addition to GITHUB_SUBMODULES to have the correct number of
words.

(rillig)

url2pkg: clean and extract after adjusting the package

The first 'bmake extract' is done only to look at the files from the
package, to determine the dependencies.  In that stage, the package
cannot be built successfully.  To make the whole workflow less
surprising, install the auto-detected dependencies before leaving the
rest of the work to the human package maintainer.  This means that
running url2pkg produces more output and may take significantly more
time, but that time would be spent anyway later, so it's a net win.

Suggested by gdt@.

(rillig)

doc: Updated pkgtools/url2pkg to 23.2.0

(rillig)

url2pkg: update to 23.2.0

Changes since 23.1.1:

Resolve dependencies from Python modules in more cases.  Suggested by
Greg Troxel for py-slixmpp.

(rillig)

url2pkg: add test for Python dependencies from py-slixmpp

(rillig)

url2pkg: fix test

(rillig)

doc/guide: sync binary package creation with reality

For many years now, binary packages have been created before installing
them.

(rillig)

doc: Updated pkgtools/pkglint to 23.2.0

(rillig)

pkgtools/pkglint: update to 23.2.0

Changes since 23.1.13:

Warn about attempts to set CONFIGURE_ARGS that are already handled by
mk/configure/gnu-configure.mk.

Warn about possible incomplete expressions that are missing the initial
'$'.

(rillig)

doc/CHANGES: fix broken entries

(rillig)

doc: Updated pkgtools/pkglint to 23.1.12

(rillig)

pkgtools/pkglint: update to 23.1.12

Changes since 23.1.11:

No longer warn about the expression ${VAR:=:${VAR2}}. Previously,
pkglint warned that the ':' did not start a new expression modifier.

(rillig)

doc: Updated pkgtools/pkglint to 23.1.11

(rillig)

pkgtools/pkglint: update to 23.1.11

Changes since 23.1.10:

Warn about packages that append to BUILD_DEPENDS, as in all practical
cases, TOOL_DEPENDS should be used instead.

(rillig)

mk/github: use lowercase variable names in .for loop

There is no need to test that the items of a .for loop are '!empty'.

Use lowercase and short names for the .for loop variables, as these
variables are local to the loop.

(rillig)

mk/check-interpreter: add cross-reference to documentation

(rillig)

doc: Updated pkgtools/pkglint to 23.1.10

(rillig)

pkgtools/pkglint: update to 23.1.10

Changes since 23.1.9:

Don't warn about variables that are being appended to, as long as their
names ends with 'S', such as GITHUB_SUBMODULES.

(rillig)

mk/bsd.builtin.mk: add keywords for 'make help'

(rillig)

mk/help.awk: clean up comments

(rillig)

doc/pkgsrc.*: regen

(rillig)

doc/guide: move the PREFER section to the user's guide and rewrite it

The variables PREFER_PKGSRC and PREFER_NATIVE are user-settable,
therefore it was confusing to see them documented only in the developer
part.

Rewrite the whole section to sync with reality since neither of these
variables is tested for the word "no".

(rillig)

doc: Updated pkgtools/pkglint to 23.1.9

(rillig)

pkgtools/pkglint: update to 23.1.9

Changes since 23.1.8:

Warn when REQD variables defined using '=' instead of '+=', even before
bsd.prefs.mk has been included, for consistency and simplicity.

In packages that define PLIST_SRC, don't check for duplicates.

(rillig)

doc: Updated pkgtools/pkglint to 23.1.8

(rillig)

pkgtools/pkglint: update to 23.1.8

Changes since 23.1.7:

Warn if GCC_REQD is defined using '=' instead of the usual '+=', to
avoid accidentally overwriting previous values.

(rillig)

doc: Updated pkgtools/pkglint to 23.1.7

(rillig)

pkgtools/pkglint: update to 23.1.7

Changes since 23.1.0:

No functional changes.

Instead of having two copies of the code, install the package by
downloading the releases from GitHub.

Reduce the build-time dependencies by delivering pre-generated parser
code.

(rillig)

doc: Updated pkgtools/url2pkg to 23.1.0

(rillig)

url2pkg: update to 23.1.0

Changes since 22.4.0:

Be more user-friendly when being passed a URL without version number.

(rillig)

doc/guide: reduce indentation in <programlisting>

(rillig)

devel/lld: remove sentence about "this document" from DESCR

(rillig)

remove unused package option nghttp2-asio

(rillig)

nghttp2: remove unused package option

(rillig)

nghttp2: remove unknown configure options

(rillig)

libxslt: remove unknown configure option

(rillig)

libxml2: remove unknown configure option

(rillig)

devel/intellij-ue-bin: remove unnecessary backslash from comment

(rillig)

mk/subst.mk: clean up documentation

(rillig)

pkglint: add missing files from previous commit

(rillig)

doc: Updated pkgtools/pkglint to 23.1.0

(rillig)

Update pkgtools/pkglint to 23.1.0

Changes since 22.4.1:

In makefiles outside pkgsrc, don't require the first line to contain the
CVS Id.

When simplifying conditions, correctly handle the edge case that a
single-word value may evaluate numerically to zero.

In dependency lines, parse '#' signs correctly.

In error messages about malformed patch files, use the correct plural
form.

(rillig)

mk/tools: replace '!empty' conditions with '==' or '!='

Main work done by running 'pkglint -F --only "simpler" --only
"simplified" *.mk', with manual improvements afterwards:

* Removed several redundant ':U' modifiers, as pkglint doesn't know the
  exact order in which the infrastructure files include each other.

* Removed redundant 'defined(X11_TYPE)' and the corresponding comment.

(rillig)

mk/check-wrkref: unclutter the documentation

(rillig)

doc: Updated pkgtools/pkglint to 22.4.1

(rillig)

pkgtools/pkglint: Update to 22.4.1

Changes since 22.4.0:

Allow pkglint to be run outside the pkgsrc top directory, in order to
allow individual makefiles to be formatted and checked as well. The many
pkgsrc-specific checks don't apply in this case. This mode is
experimental, there are still crashes to be expected.

Fix a crash for syntactically invalid conditions in '.if'.

Fix parsing of dependency lines that contain an escaped '#', which is
used for switching to another shell using a '.SHELL: ...' line.

(rillig)

regress: remove tests for Haskell PLIST generation

The structure of the Haskell PLIST files has changed in the meantime, so
the tests fail.  Adjusting the tests to the new file structure would be
harder than rewriting them from scratch.

(rillig)

pkgtools/pkglint: update to 22.4.0

Changes since 22.3.2:

Numeric comparisons of _PYTHON_VERSION generate an error since that
variable can have the value 'none', which is not numeric.  Furthermore,
the variable is from the internal namespace and thus should not be used
by packages at all.

Warnings about COMPILER_RPATH_FLAG no longer suggest different and
conflicting replacements.

Cleanup: Handling of doc/CHANGES was moved to changes.go, and since
go1.19.4, comments are formatted differently.

(rillig)

cwrappers.mk: remove redundant modifier

In a variable that has exactly one word, there cannot be duplicate
words, so ':u' (only keep unique words) is a no-op.

(rillig)

doc: Updated pkgtools/url2pkg to 22.4.0

(rillig)

pkgtools/url2pkg: update to 22.4.0

Changes since 22.2.1:

In packages that use CMake, no longer set USE_CMAKE=yes but instead
include the build.mk file.

(rillig)

CHANGES-2022: fix simple syntax errors

(rillig)

doc: Updated pkgtools/pkglint to 22.3.2

(rillig)

pkgtools/pkglint: update to 22.3.2

Changes since 22.3.1:

Complain about conditions of the form '_PYTHON_VERSION < 38', as they
lead to 'Malformed conditional' when _PYTHON_VERSION is 'none' instead
of a number.

(rillig)

doc: Updated pkgtools/pkglint to 22.3.1

(rillig)

pkgtools/pkglint: Update to 22.3.1

Changes since 22.3.0:

In doc/CHANGES files, check for typos in month and day of the dates.

In conditions for YesNo variables, suggest to replace the modifier
':M[yY][eE][sS]' with a simpler comparison.

pkg/2022/11/16/msg026992.html">https://mail-index.netbsd.org/tech-pkg/2022/11/16/msg026992.html

(rillig)

guide: document how to test yes/no variables

pkg/2022/11/16/msg026992.html">https://mail-index.netbsd.org/tech-pkg/2022/11/16/msg026992.html

(rillig)

pkgtools/pkglint: fix check for package option groups

(rillig)

doc: Updated pkgtools/pkglint to 22.3.0

(rillig)

pkgtools/pkglint: update to 22.3.0

Changes since 22.2.7:

Pkglint no longer wrongly warns about package options from optional or
required option groups. Fixes PR 57038.

(rillig)

doc: Updated pkgtools/lintpkgsrc to 2022.09.29

(rillig)

lintpkgsrc: fix search path for mk.conf

The variable MAKECONF has the highest precedence, not the lowest one.

Bump version.

(rillig)

doc: Updated pkgtools/lintpkgsrc to 2022.09.14

(rillig)

pkgtools/lintpkgsrc: ignore exit status from running pkg_info

In case of multi-versioned packages like Python modules, lintpkgsrc
queries the wrong installed packages.

Bump version.

https://mail-index.netbsd.org/pkgsrc-users/2022/09/13/msg036186.html

(rillig)

pkgtools/distlint: add early prototype implementation

Do not enable the package yet as it is still under active development
and lacking proper documentation.

(rillig)

pkgtools/url2pkg: make distutils.version.LooseVersion more complete

For the benefit of wip/py-torch.

(rillig)

pkgtools/url2pkg: clean up Globals.pkgsrc_license

Having a nested function accessing nonlocal variables was more
complicated to understand than the straight-forward copy-and-paste code.

(rillig)

doc: Updated pkgtools/url2pkg to 22.2.1

(rillig)

pkgtools/url2pkg: add support for distutils.errors

Needed for geography/py-maxmindb.

(rillig)

pkgtools/url2pkg: fix line ends

(rillig)

pkgtools/url2pkg: support Python with setuptools.command.test

Needed for www/py-pook 1.0.2.

(rillig)

pkgtools/distlint: add initial draft document, no package yet

(rillig)

lintpkgsrc: fix location of mk.conf

The effective location of mk.conf is not stored in a variable, and there
are several locations where it could be. Noticed by adam@.

(rillig)

doc: Updated pkgtools/pkglint to 22.2.6

(rillig)

pkgtools/pkglint: update to 22.2.6

Changes since 22.2.5:

A makefile that adds a _VARGROUPS section is partly considered part of
the infrastructure. It may define and use variables from its own
namespace. For example, devel/cmake/build.mk adds _VARGROUPS+=cmake,
thereby reserving the namespace '_CMAKE_*' for itself.

Dependencies in BUILDLINK_API_DEPENDS and BUILDLINK_ABI_DEPENDS that
contain unresolved variable expressions are no longer marked as
redundant. They were marked as redundant before because '$', when
interpreted as a package version, was smaller than 0.0.

(rillig)

lintpkgsrc: cleanup: extract 'make show-vars' into subroutine

(rillig)

lintpkgsrc: fix parse-guessing of Apache modules

When lintpkgsrc parses the package makefile of an Apache module, it
includes mk/apache.mk, and that file defines APACHE_PKG_PREFIX, thereby
hiding the fallback value from $default_vars.

(rillig)

lintpkgsrc: fix handling of Apache modules

(rillig)

lintpkgsrc: fix warning about bogus PKGREVISION for Git packages

(Since a few days.)

(rillig)

lintpkgsrc: clean up style

(rillig)

lintpkgsrc: cleanup: replace '|| fail' with 'or fail'

(rillig)

lintpkgsrc: remove special rule for RESTRICTED

There's no point in saving the fixed value 'NO_BIN_ON_FTP' in the
variable 'RESTRICTED'. The purpose of that code was unclear, as all
packages that define NO_BIN_ON_FTP also define RESTRICTED.

(rillig)

lintpkgsrc: normalize package name for Apache Web Server modules

(rillig)

cmake/build.mk: add _VARGROUPS section

This allows to run 'make show-all-cmake' in those packages that include
this file.

Sort 'test' and 'install' chronologically.

(rillig)

doc: Updated pkgtools/pkglint to 22.2.5

(rillig)

pkgtools/pkglint: update to 22.2.5

Changes since 22.2.4:

Makefiles in wip/mk may use internal variables (starting with '_'), just
like their counterparts in main mk/.

Package versions containing letters are now parsed like in pkg_install.

(rillig)

subversion: remove unknown configure option '--with-neon'

(rillig)

lintpkgsrc: fix default value of LOCALBASE

LOCALBASE is not related to PKGSRCDIR in any way.

(rillig)

lintpkgsrc: cleanup: remove redundant punctuation around declarations

(rillig)

lintpkgsrc: prefer clarity over brevity in usage message

(rillig)

lintpkgsrc: cleanup: untangle parsing of .include directives

(rillig)

lintpkgsrc: cleanup: reduce syntactical verbosity

(rillig)

lintpkgsrc: add error handling for files and subprocesses

(rillig)

lintpkgsrc: cleanup: reduce indentation of parse_makefile_pkgsrc

(rillig)

lintpkgsrc: cleanup: condense guess-parsing of PKGNAME

(rillig)

lintpkgsrc: fix parse-guessing of pkgsrc-wip packages using an SCM

(rillig)

lintpkgsrc: eliminate common subexpression when parsing package

(rillig)

lintpkgsrc: fix loading of package data; condense loading of categories

(rillig)

lintpkgsrc: cleanup: move loading and storing of package data together

(rillig)

lintpkgsrc: cleanup: rename PkgDb to PkgData

The previous name could be confused with the pkgdb directory that holds
information about the currently installed packages.

(rillig)

lintpkgsrc: improve PKGNAME guessing for PHP, Python, Ruby packages

(rillig)

lintpkgsrc: fix PKGNAME guessing for Lua packages

Previously, the guessed PKGNAME of devel/lua-busted was '-busted-2.0.0',
now it is 'lua-busted-2.0.0'.

(rillig)

lintpkgsrc: cleanup: condense invalid_version

(rillig)

lintpkgsrc: cleanup: condense package_globmatch

(rillig)

lintpkgsrc: cleanup: rename subroutine

Scanning the distfiles is not the main action.

(rillig)

lintpkgsrc: don't chdir unnecessarily

Previously, combining the options '-u' and '-E relative-path' did not
work.

(rillig)

lintpkgsrc: split remove_distfiles into manageable pieces

(rillig)

lintpkgsrc: clean up loading distfiles for installed package

(rillig)

lintpkgsrc: separate loading distinfo from checking distinfo

While here, change the message for checksum mismatch, once again. No
other functional change.

(rillig)

lintpkgsrc: clean up stylistically

(rillig)

lintpkgsrc: clean up code for listing required packages

(rillig)

lintpkgsrc: remove preformatted manual page

Having the preformatted manual page checked in into version control
doesn't make sense. Replacing the placeholders is an ugly hack and leads
to ugly line breaks. If the preformatted manual page is needed, the
better approach is to render it at build time, after the placeholders
have been replaced.

(rillig)

lintpkgsrc: accept duplicate strings from brace expansion, for now

Having duplicate expanded strings is not as bad as having missed
alternatives, it's only a question of performance.

(rillig)

lintpkgsrc: demonstrate another bug in brace expansion

(rillig)

lintpkgsrc: fix brace expansion for empty alternatives

(rillig)

lintpkgsrc: fix handling of 0 in brace expansions

(rillig)

lintpkgsrc: extract brace expansion, document its various bugs

(rillig)

lintpkgsrc: properly clean up after chdir

When running 'lintpkgsrc -I tmp/lp-85 -yro', lintpkgsrc couldn't find
the cache file due to the intermediate chdir($pkgdistdir).

(rillig)

lintpkgsrc: clean up variable names and verbose/debug log messages

(rillig)

lintpkgsrc: clean up debug logging

(rillig)

doc: Updated pkgtools/lintpkgsrc to 2022.08.13

(rillig)

lintpkgsrc: update to 2022.08.13

Changes since 2022.08.12:

In package makefiles, the ':U' modifier is evaluated more correctly than
before, handling the values '' and '0' correctly.

Running 'lintpkgsrc --help' produces a clean usage message.

Distinfo files are checked more strictly than before.

Running 'lintpkgsrc -D .' does not produce Perl warnings anymore when
falling back to running bmake to determine the PKGNAME.

When parsing package makefiles, the debug log for evaluating
conditionals is easier to read.

(rillig)

lintpkgsrc: fix expansion of the ':U' modifier

In Perl, 0 is falsy, but in bmake, the modifier ':U' only cares about
undefined vs. defined.

(rillig)

lintpkgsrc: clean up the output of running 'lintpkgsrc --help'

(rillig)

lintpkgsrc: make distinfo parsing stricter

There are no distinfo files anymore in which the filename starts with
'./', so remove that check.

Complain about invalid distinfo lines. This flags a few pkgsrc-wip
packages, but none in main pkgsrc.

Extract load_distinfo into a separate subroutine, improve local variable
names.

Document that only the first distinfo algorithm (currently BLAKE2s) is
ever checked.

(rillig)

lintpkgsrc: cleanup: rename cache subroutines to be more expressive

It was easily possible to confuse scan_pkgsrc_makefiles with
load_pkgsrc_makefiles, so rename the latter to load_pkgdb_from_cache.

(rillig)

lintpkgsrc: remove extra code for determining the pkg_install version

There is no apparent reason for this code. Lintpkgsrc could already
parse the version of pkg_install, by falling back to running bmake.

When run in debug mode, 'lintpkgsrc -D .' failed because lintpkgsrc used
a wrong regular expression instead of just calling dirname. While here,
fix the variable name 'pkgsrcdir' to simply 'pkgdir', as the previous
name was highly confusing.

(rillig)

lintpkgsrc: clean up evaluation of conditions in makefiles

Having a variable named 'false' was confusing. Having a stack of
if-states in which 0 means true and 1 means false was even more
confusing. Using these magic numbers in the debug log without any
explanation was misleading.

The code, as well as the debug log, now uses the strings 'not_yet',
'active' and 'done' for the state of the conditionals. While it still
requires a bit of thought to read the debug log, it's at least possible
now.

(rillig)

lintpkgsrc: cleanup: reduce line noise

(rillig)

doc: Updated pkgtools/lintpkgsrc to 2022.08.12

(rillig)

lintpkgsrc: update to 2022.08.13

Changes since 2022.08.10:

Improve parsing of conditions, continuation lines, comments in
makefiles.

Replace hard-coded paths to /etc/mk.conf and /usr/pkg with the proper
paths that correspond to the pkgsrc installation.

If pkglint is run with unknown or invalid options, exit with an error
status.

(rillig)

lintpkgsrc: fix parsing of modifiers in makefiles

(rillig)

lintpkgsrc: fix parsing of comments in makefile lines

(rillig)

lintpkgsrc: fix parsing of continuation lines in makefiles

(rillig)

lintpkgsrc: clean up subroutine names, test conditionals

(rillig)

lintpkgsrc: clean up Pkgs type

(rillig)

lintpkgsrc: use proper exit status when showing usage

(rillig)

lintpkgsrc: cleanup: remove unused conf_sysconfdir

It has been replaced with conf_makeconf.

(rillig)