Whitespace

(skrll)

lint: rename pqinf_t to qual_ptr and clean up code

The 'inf' from the type name meant 'information' and was redundant. Each
object of that type represents a single pointer level, which made the
documentation about 'pointers' a bit confusing.

The members of struct qual_ptr are now in the canonical reading order,
which is 'const volatile pointer'.

No functional change.

(rillig)

lint: only accept assignment-expression in _Generic

That's what C11 says.

(rillig)

avoid triggering conflict indicator warnings

(cjep)

note on Darwin/Mac

(cjep)

Fix PR lib/55931
Only reset outcol if we actually emit a \n as cursor_down may not may
not put the cursor at the start of the next line.

(blymn)

Since there's a bit of code that is conditionally compiled based on
USBVERBOSE, we need to include the opt_usbverbose.h header to get any
possible definition of this macro.

XXX Note that this code will NOT get included in the loadable module
XXX for USBVERBOSE.

(pgoyette)

lint: consistently use 'opt' as suffix

This corresponds to the usage in the C standards, where 'opt' is used as
a subscripted suffix.

No functional change.

(rillig)

lint: remove redundant '{ $$ = $1; }' from the grammar

In some cases the redundant code had been spelled out, in others it had
been left out.  Be consistent.

(rillig)

lint: reorder grammar rules from big to small

No functional change.

(rillig)

lint: fix parsing of _Generic selection expressions

Previously, lint accepted comma-expressions where only
assignment-expressions are allowed.

This change does not make a difference in practice though since lint is
usually only run on source code that properly compiles.  Nevertheless,
rather be precise and accurate since the grammar might some day be
reused on less reliable input.

(rillig)

lint: fix type comparison in _Generic selection expressions

In the newly added test comma_expression, there were two distinct type
objects for the tspec DOUBLE.

(rillig)

lint: fix result type of _Generic expressions

(rillig)

tests/lint: add test for _Generic with incompatible return types

(rillig)

tests/lint: fix selection of the .exp-ln file

Since t_integration.sh 1.58 from today, the expected .ln output was not
detected anymore.  Changes to the file format would have gone unnoticed.

(rillig)

tests/lint: remove list of test names from t_integration

By convention, each *.c file in the source directory is a test case.

There is no need to list them individually and redundantly.

There is also no need to group the tests for the individual messages.
This ensures that each test is run in the regular builds.  Previously,
the test all_messages stopped after the first failure.

(rillig)

lint: require C11 for _Generic

This does not have any effect in practice since the option -g
(originally meant for GCC extensions to the C standards) implicitly
allows all features from C11, since err.c 1.111 from 2021-04-14.

Since the default lint flags for NetBSD builds include the option -g,
this allows all C11 features.

Currently it is not possible to say "allow GNU extensions but not C11".

(rillig)

lint: sort and rename grammar rules for generic selection

No functional change.

(rillig)

lint: fix option -Ac11, add test for _Generic

Previously, selecting the option -Ac11 allowed features from C11 but at
the same time prohibited 'long long', which was added in C99.  This was
caused by the option -s, which is interpreted as "allow features from
C90, but no later".

The test for _Generic, which has been added in C11, demonstrates that
the current implementation is broken.  Lint currently thinks that the
return type of a _Generic selection is the type of the expression, but
it really is the type of the selected expression.  In the current tests,
this is always 'const char *', but C11 does not require that the types
of a generic selection are compatible.

(rillig)

lint: fix uninitialized variable for declaration after statement

(rillig)

lint: proof-read the C grammar, remove unnecessary %type

After the fix from the previous commit (a missing assignment to $$ in an
error case), make sure that there are no other bugs of the same kind, by
manually checking that each rule with a %type assigns $$ in each and
every case.  There is one more instance in block_item_list, but that
does not lead to a crash since it affects only a boolean variable, not a
pointer.

It should not be necessary to check for this class of bugs manually, but
neither BSD yacc nor GNU Bison provide any warning option to help with
this scenario.  They should have remarked that the %type for
type_attribute is never used, since that is easy to detect.  They should
have also warned that the rule for block_item_list does not mention $$
at all.

Detecting the bug from the previous commit would probably be too much to
ask since it involves control flow analysis in the C code.  In this
particular case, it would have been necessary to visit each possible
branch from the 'if' statement and ensure that there is a $$ on the
left-hand side of an assignment.

While here, note down several small inconsistencies in the grammar that
should be fixed in follow-up commits.

(rillig)

Fix SSP build

(christos)

lint: fix undefined behavior after syntax error 'unnamed member'

There should really be a linter or other check that guards against
forgetting to assign a value to '$$'.

(rillig)

PR 55325: unify both pvo pools (for managed and unmanaged pages).
Analyzis by rin, fix suggested by chs.

(martin)

tests/lint: fix list of files to be installed

(rillig)

tests/lint: allow skipping individual tests

Depending on the platform, some tests do not make sense or produce
platform-dependent results.  Allow these tests to be marked as such.

For example, the test lex_integer.c only works on 64-bit platforms.
Therefore it is disabled on i386 for now since it prints different
warnings there.  Even better would be a "lint1-only-on-lpi32" toggle,
but that would need detection of 'sizeof(int)' at runtime.

(rillig)

tests/lint: rename expected .ln file to .exp-ln

This way, the hack for suffixes is no longer needed.

(rillig)

factor out the ktrace printing into their own functions.

(christos)

lint: fix typo in comment for target platform definitions

(rillig)

lint: fix type of pqinf.p_pcnt

A counter that can either be 0 or 1 and is never incremented is not
really a counter, it's a flag.

No functional change.

(rillig)

drm: Release fence after use.

May plug the dreaded radeon kmem memory leak.

XXX pullup-9

(riastradh)

Use more SMALL binaries and reduce diffs between sun2 and sun3.

(tsutsui)

Fix typo in comment

(skrll)

Fix 32-bit build.

(jmcneill)

move pad to GENERIC.common

(nia)

ARMADILLO-IOT-G3 kernel was gone; it is now supported by GENERIC.

(rin)

Set VMSWAP_DEFAULT_PLAINTEXT for hpcarm and hpcmips, that suffer from
slow CPU as well as memory shortage.

For hpcsh, this option is already enabled by std.sh3.

(rin)

Add pad(4) to arm kernels

(nia)

Oops, revert unintentional part of the previous.

(rin)

Set VMSWAP_DEFAULT_PLAINTEXT for Explora 450 (IBM_PPC403).
(slow CPU & memory shortage)

(rin)

Check if /tmp is writable to see whether the rootdev is already mounted.

Creating a dummy /tmp/root_writable file and after mountroot and
checking it on the second installation could be problematic if
users retry to installation after reboot without reinstalling miniroot.
Taken from amiga.

(tsutsui)

Remove an obsolete comment.

(tsutsui)

Don't try to add swap on miniroot.

(tsutsui)

ensure defined(HAVE_GCC) before use of ${HAVE_GCC}

(tnn)

Ticket #1686

(martin)

Pull up following revision(s) (requested by tsutsui in ticket #1686):

distrib/sun3/miniroot/Makefile: revision 1.50
distrib/miniroot/install.sub: revision 1.61
distrib/miniroot/install.sub: revision 1.62 (patch)
distrib/sun2/miniroot/Makefile: revision 1.40

Replace RELEASE and VERSION strings proplery.
sun2 and sun3 don't use MI src/distrib/miniroot/list so this should
have been sync'ed with it.

http://cvsweb.netbsd.org/bsdweb.cgi/src/distrib/miniroot/list#rev1.36
> Use proper release version strings ("9.1" rather than "91") in banners.
>
> Also define and use "MACHINE" variable to describe port names
> (no uname(1) or sysctl(8) in miniroot binary list by default).

Should be pulled up to netbsd-9.

Remove netstat(1) calls to print resolver info on upgrade using miniroot.
netstat(1) was removed from miniroot 25 years ago.
http://cvsweb.netbsd.org/bsdweb.cgi/src/distrib/miniroot/list#rev1.5

The modules and rescue sets are also required on upgrade.
Should be pulled up to netbsd-9 and netbsd-8.

(martin)

sun4v: update TODO file with current sun4v progress

(palle)

sun4v: vdsk - restart the ldc state machine when the ldc endpoint resets the link or a DATA/NACK/DRING_DATA message is received. These changes make the driver more robust. In a ldom with Solaris 11.4 SRU30 as primary domain (T5 host system) frequent resets and NACK messages are observed.

(palle)

Ticket #1310

(martin)

Pull up following revision(s) (requested by tsutsui in ticket #1310):

distrib/sun3/miniroot/Makefile: revision 1.50
distrib/miniroot/install.sub: revision 1.61
distrib/miniroot/install.sub: revision 1.62
distrib/sun2/miniroot/Makefile: revision 1.40

Replace RELEASE and VERSION strings proplery.
sun2 and sun3 don't use MI src/distrib/miniroot/list so this should
have been sync'ed with it.

http://cvsweb.netbsd.org/bsdweb.cgi/src/distrib/miniroot/list#rev1.36
> Use proper release version strings ("9.1" rather than "91") in banners.
>
> Also define and use "MACHINE" variable to describe port names
> (no uname(1) or sysctl(8) in miniroot binary list by default).

Should be pulled up to netbsd-9.

Remove netstat(1) calls to print resolver info on upgrade using miniroot.
netstat(1) was removed from miniroot 25 years ago.
http://cvsweb.netbsd.org/bsdweb.cgi/src/distrib/miniroot/list#rev1.5

The modules and rescue sets are also required on upgrade.
Should be pulled up to netbsd-9 and netbsd-8.

(martin)

Tweak how the IRQ description strings are generated to enable additional
duplicated code re-factoring.

(thorpej)

make: prevent newline injection in .for loops

When a value of a .for loop contained a literal newline, such as from
the expression ${.newline}, that newline was passed verbatim to the
"expanded current body" of the .for loop.  There it was interpreted as a
literal newline, which ended the current line and started a new one.
This resulted in several syntax errors.

In cases like these, print a more precise error message.

(rillig)

tests/make: demonstrate newline injection in .for loop

(rillig)

Reduce code duplication among platforms that use the i82378 SIO to
route PCI interrupts to the ISA PIC by refactoring it into a new
sio_pirq_intr_map() function.

(thorpej)

Remove pointless warning.

(thorpej)

Define macros to desribe the PIRQ_RTCTRL register(s).

(thorpej)

fdt "/reserved-memory" node should be handled

(ryo)

PR/56095 SOPINE Clusterboard unable to transmit network data

Add allwinner,tx-delay-ps = <500> using the diff supplied by tnn@

(skrll)

- Use the default implementations of attach_hook(), make_tag(), and
  decompose_tag().
- In lca_bus_maxdevs(), only allow devices 0-15 on bus #0.
- Re-factor some duplicated code into lca_make_type0addr().

(thorpej)

- Use the default implementations of attach_hook(), make_tag(), and
  decompose_tag().
- In ttwoga_make_type0addr(), assert that we have an IDSEL in our range,
  and otherwise always succeed.
- In ttwoga_bus_maxdevs(), allow only devices 0-9 on bus #0.

(thorpej)

Use the default implementation of attach_hook().

(thorpej)

Use the default implementation of attach_hook().

(thorpej)

Use the default implementations of attach_hook(), bus_maxdevs(),
make_tag(), and decompose_tag().

(thorpej)

Make the following PCI chipset functions optional:
- attach_hook()
- bus_maxdevs()
- make_tag()
- decompose_tag()
...and provide a default implementation for each.

(thorpej)

From the "Should have been done years ago" department, add some macros
describing the format of PCI Type 0 and Type 1 Configuration Cycle
addresses.

(thorpej)

tests/make: test .for loop over a variable named '$'

It's an impractical edge case, nevertheless it's accepted by make.

(rillig)

make: sprinkle const

(rillig)

clarify some comments about what the "send callback" is.

(mrg)

turn off ohcidebug by default.  none of the other HCs do this.

next up:  options to set these by default

(mrg)

update a couple of lists of drivers that have had a few changes

(mrg)

Deal with a scenario where:
- DMA map has a boundary constraint.
- Caller asks us to map a buffer that's exactly the same size as the
  boundary constraint, but is not page-aligned.

This results in the size being larger than the boundary constraint after
page-rounding, and and vmem_xalloc() fires a KASSERT for it.  This is
easy to trigger by running fsck.

We handle this by detecting the condition and creating an extra DMA
segment for it the spill-over.

(thorpej)

Fix printf format for size_t

(martin)

iwm(4): Disentangle attach.

Don't attach a half-baked interface and then detach it and then
reattach it after mountroot when we can read firmware; just defer
attaching the interface altogether until mountroot.

Likely fixes some panics I've seen every now and then at boot with
iwm(4).

(riastradh)

ucom(4): Fix earlier mistake causing pipes not to be closed.

In revision 1.123, mrg@ changed what he thought was a double-close,
but was actually abort&close (as is appropriate) to just abort (which
is not enough -- leaks the pipe).  This restores the abort&close.

The original `bug' was found by code inspection, whereas this bug was
found by asserting in usb_subr.c that no pipes are open on device
disconnection after detach; the asserts actually triggered with
several ucom(4) devices, and no longer trigger with this change.

XXX pullup-9

(riastradh)

Call check_siginfo() in compression loop to provide SIGINFO compression
progress.
Suggested by mrg@.

(simonb)

Make sure we don't use wide char routines when DISABLE_WCHAR is in
effect.

(blymn)

boot1.c: remove a comment that's no longer relevant/correct

In r. 1.13, a check of the return value in fd was removed, and a comment
about this ("...so keep going") added. Then in r. 1.19, the fd return
value check was reinstated (as the true underlying errno could be masked
by the fstat() call), so there is no "keep going" happening anymore.

(gutteridge)

When printing memory size, don't promote to next unit size unless it is at
two digits.

(jmcneill)

fix typo

(jmcneill)

Fix buffer size for alignment adjusted block I/O reads.

(jmcneill)

nbmacppc-fixcoff did not cross-build correctly on OpenBSD because
fixcoff.c had its own definition of htobe16. The toolchain
already handles this. Now builds on OpenBSD. Checked on NetBSD, Darwin &
Linux.

Discussed with uwe@

(cjep)

build gdbserver only when we build gdb (from adam)

(christos)

Remove an unused #define.

(simonb)

restore(8): Mark fail_dirtmp __dead to fix clang build.

(riastradh)

lint1: add bug report for internal GCC compiler error

(rillig)

make ahcisata(4) work on rk3399 (rockpro64)

on rk3399, a marvell 9230 ahci sata card consistently takes between
1213 and 1216 milliseconds, the ahci spec says this should complete
in 1000 or fewer.

add a "pcie-reset-ms" uint32 property that ahcisata defaults to 1000
if not set, and the rockchip platform code sets to 2000.

ok @jmcneill

(mrg)

print_banner: Print memory size like x86 does

(jmcneill)

efiboot: Use EFI_BLOCK_IO_PROTOCOL if EFI_DISK_IO_PROTOCOL is missing

UEFI spec says that firmware should automatically add EFI_DISK_IO_PROTOCOL
for all produced EFI_BLOCK_IO_PROTOCOL interfaces. Unfortunately U-Boot
doesn't do this, so fallback to block I/O if disk I/O is not there.

(jmcneill)

efiboot (x86): add ASCII art

(nia)

Document sh3* lint hack for gcc 9

(martin)

Hack to avoid gcc 9 internal compiler error for sh3.

(martin)

efirng: fix va_num arg to uefi_call_wrapper for GetRNG calls

As far as I can tell this param isn't actually used, but it is supposed to
be the number of arguments passed to the called method.

(jmcneill)

Update the check files to account for fixes to addstr.c

(blymn)

Rework the fix for lib/56224.
Move the scroll check to _cursesi_addwchar
Perform the scroll check before updating the cursor location when
processing \n.

(blymn)

Fix slk test and check files due to libcurses slk changes.

(blymn)

Fix how the slk are drawn by making sure we use ins_wchar in the
bottom left of the screen to avoid a scroll because this may cause
an ERR if scrollok is false.

(blymn)

Fix the debug output to stop spamming out the aline for row 0, we
may not be working on that row so the output is pointless.

(blymn)

Ammend ticket #1301

(martin)

Fix pullup #1302 by adapting the changes to this branch
(there was a misunderstanding in the ticket handling)

(martin)

boot.8: minor grammar tweaks

(gutteridge)

mbr.8: fix a typo

(gutteridge)

efiboot: Add readahead support.

Reading data through libsa file-systems ends up breaking block I/O
accesses into very small (512-byte or 2048-byte) accesses. This can be
very inefficient, and causes Ampere eMAG w/ BMC image direction to take
_minutes_ to load the install image and kernel. So slow in fact that
the default watchdog timeout will fire before it finishes.

So, when loading big files, optimistically read ahead up to 64KB of data.
Brings the time to boot the install ISO down to around 40 seconds -- still
not ideal but way better than before.

(jmcneill)

make: fix grammar in error message for malformed conditional

(rillig)

make: clean up comments in cond.c

(rillig)

make: use simpler upper bound for length in Buf_AddInt

No functional change.

(rillig)

use a single printf call for readability

(nia)

biosboot: Add ASCII art.

(nia)

efiboot: Add ASCII art.

(nia)

make: replace macro is_shell_metachar with inline function

No functional change.

(rillig)

make: use more practical data type in RegexReplace

While size_t is most appropriate for array indexes, make needs to be
compatible with C90, which does not support the %zu printf conversion.
To avoid type casts, use a simple unsigned int here, which is more than
enough for storing a single decimal digit.

No functional change.

(rillig)

make: extract RegexReplace from ModifyWord_SubstRegex

No functional change.

(rillig)

make: move all labels in ModifyWord_SubstRegex to the same level

No functional change.

(rillig)

Tickets #1685 and #1684

(martin)

Apply patch, requested by mrg in ticket #1684 (no corresponding
change in HEAD, oabi has been removed):

compat/arm/oabi/bsd.oabi.mk (apply patch)

Fix PR 50192.

(martin)

Tickets #1296 - #1309

(martin)

Apply patch, requested by mrg in ticket #1309 (no corresponding
change in HEAD, oabi has been removed):

compat/arm/oabi/bsd.oabi.mk (apply patch)

Fix PR 50192.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1308):

sys/arch/amd64/conf/GENERIC: revision 1.581

Enable tpm @ acpi (now that it can match TPM 1.2 devices, which are not,
as the comment implies, experimental).

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1307):

sys/arch/amd64/amd64/db_disasm.c: revision 1.28
sys/arch/i386/i386/db_disasm.c: revision 1.49

ddb/amd64: Don't go out of the way to detect invalid addresses.

db_disasm had logic to detect invalid addresses before trying to
disassemble them.  But when disassembling a null instruction address,
the logic to detect invalid addresses itself tried to dereference an
invalid address.

db_get_value can already handle this situation gracefully, so there is
no need for this faulty fault-avoidance logic.

Fixes double-fault in ddb on calling null function pointers.  With
any luck, this should make diagnosing such bugs easier in the future!

ddb/i386: Don't go out of the way to detect invalid addresses.
db_read_bytes already does this better (but didn't at the time this
check was originally added back in 1998).  Not sure if this code had
the same mistake as the amd64 code causing it to trip over its own
shoelaces, but there should be no need for it here.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1306):

sys/dev/usb/umass.c: revision 1.185
sys/dev/usb/umass_scsipi.c: revision 1.68

umass(4): Use an empty function callback, not null pointer.

This stupid bug, with an `XXX Broken!' comment right above, has been
preventing NetBSD from suspend/resume with a USB drive plugged in for
longer than I want to even think about admitting.  *sigh*
umass(4): Assert that we got a cb up front.

Avoids jump to zero waaaaaaay down the line where we've forgotten why
we wanted to jump into oblivion.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1305):

sys/dev/ic/nvmevar.h: revision 1.22
sys/dev/ic/nvme.c: revision 1.56
sys/dev/ic/nvme.c: revision 1.57
sys/dev/pci/nvme_pci.c: revision 1.30

nvme(4): Add suspend/resume, derived from OpenBSD.

nvme(4): Move disestablishment of admin q interrupt to nvme_detach.

Nothing re-established this after suspend/resume, so attempting
suspend/resume/suspend would crash, and presumably we would miss
interrupts after resume.  This keeps the establish/disestablish more
symmetric in attach/detach.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1304):

sys/dev/ldvar.h: revision 1.35
sys/dev/ld.c: revision 1.112

ld(4): Block requests while suspended until resumed.

Otherwise nothing stops us from continuing to feed I/O to the disk
controller when it expects that the queues are quiesced as it pokes
registers to change its power states.  Fixes resume during disk
activity on my T480 with nvme.

(martin)

make: reduce indentation in ModifyWord_SubstRegex for ':C'

No functional change.

(rillig)

Pull up following revision(s) (requested by riastradh in ticket #1303):

sys/arch/x86/pci/dwiic_pci.c: revision 1.5 (patch)

dwiic(4): Attribute output correctly and relegate to debug-level.

Tidy up a little while here.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1302):

sys/dev/usb/ualea.c: revision 1.13

ualea(4): Null suspend/resume handler.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1301):

sys/dev/usb/xhci.c: revision 1.140
sys/dev/usb/xhci.c: revision 1.141
sys/dev/usb/xhci.c: revision 1.143
sys/dev/usb/xhcivar.h: revision 1.18
sys/dev/usb/xhcivar.h: revision 1.19
sys/dev/usb/xhcireg.h: revision 1.19
sys/dev/usb/xhci.c: revision 1.139

xhci(4): Draft suspend/resume.

Work almost entirely done and tested by maya@ based on xhci 1.2 spec;
tidied up and tweaked by me.

Not sure about issuing Stop Endpoint commands or ensuring the Command
Ring is in the Stopped or Idle state, but this seems to work as is,
so it's already an improvement over what we had before which was no
xhci suspend/resume at all.

In particular, it's not clear to us:
- if we don't have any pending USB activity whether we need to issue
  the Stop Endpoints or quiesce the command ring; but
- if we do have any pending USB activity whether issuing Stop
  Endpoint is enough or whether we also need to do anything to
  synchronize with other software logic to quiesce it too.

xhci(4): Block commands and issue Stop Endpoint on suspend.

xhci: Fix logic in waiting for command queue access.
_Either_ an existing command in progress, _or_ an existing suspend in
progress that is not done by us, should block us; the logic I wrote
previously erroneously blocked only if both conditions happened at
the same time.

Should fix issue reported by Andrius V in the PR kern/56050 followup
discussion.

xhci(4): Wait USB_RESUME_WAIT ms, not 20 ms.
Better to use the named constant, and although the spec says 20 ms is
enough, apparently for some devices it's not.

(martin)

make: eliminate local variable in Substring_Words

No functional change.

(rillig)

Pull up following revision(s) (requested by riastradh in ticket #1300):

sys/external/bsd/drm2/dist/drm/i915/i915_drv.h: revision 1.33 (patch)

i915drmkms: Fix LOCKDEBUG panic and potential deadlock.

This path is taken with a spin lock held, and possibly even in
interrupt context, where taking vmobjlock is not kosher, but we are
guaranteed to have the queue populated and unchanging.

XXX pullup-9

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1299):

sys/kern/kern_ksyms.c: revision 1.90
sys/kern/kern_ksyms.c: revision 1.91
sys/kern/kern_ksyms.c: revision 1.92
sys/kern/kern_ksyms.c: revision 1.93
sys/kern/kern_ksyms.c: revision 1.94
sys/kern/kern_ksyms.c: revision 1.95
sys/kern/kern_ksyms.c: revision 1.96
sys/kern/kern_ksyms.c: revision 1.97

ksyms(4): Fix ksymsread synchronization.

Fixes crash on concurrent update and read of /dev/ksyms.
XXX Unclear why we have to skip sd_gone entries here -- it seems like
they should be preserved until ksymsclose.
ksyms(4): Modify ksyms_symtabs only at IPL_HIGH.

This limits the opportunities for ddb to witness an inconsistent
state of the symbol table list.
ksyms(4): Don't skip symbol tables that are soon to be freed.

They will not actually be freed until /dev/ksyms is closed, so
continued access to them remains kosher.
Revert "ksyms(4): Don't skip symbol tables that are soon to be freed."

Apparently the equality kassert this restored doesn't work; to be
analyzed.

Fix regression introduced in rev 1.90
in which the last element of ksyms_symtabs is skipped by mistake.

ksyms(4): Fix race in ksymsread iteration.
TAILQ_NEXT(ksyms_last_snapshot) might change while we are iterating,
but ksyms_last_snapshot itself cannot, so invert the loop structure.

Discussed with rin@.

ksyms(4): Don't skip symbol tables that are soon to be freed, take 2.

They will not actually be freed until /dev/ksyms is closed, so
continued access to them remains kosher.
The previous change was busted because of an off-by-one error in a
previous previous change's iteration over the symtabs; that error has
since been corrected.

ksyms(4): Allow multiple concurrent opens of /dev/ksyms.

First one takes a snapshot; others all agree with the snapshot.
Previously this code path was just broken (could fail horribly if
modules were unloaded after one of the opens is closed), so I just
blocked it off in an earlier commit, but that broke crash(8).  So
let's continue allowing multiple opens seeing the same snapshot, but
without the horrible bugs.

(martin)

Pull up following revision(s) (requested by riastradh in ticket #1298):

lib/libc/gen/setjmp.3: revision 1.18

Clarify what happens when you longjmp(..., 0).

Derived from C99 7.13.2.1 `The longjmp function'.

(martin)

Apply patch, requested by christos in ticket #1297:

external/bsd/libarchive/dist/cat/test/test_0.c up to 1.2
external/bsd/libarchive/dist/cpio/test/test_basic.c up to 1.2
external/bsd/libarchive/dist/cpio/test/test_format_newc.c up to 1.3
external/bsd/libarchive/dist/libarchive/archive_read.c up to 1.2
external/bsd/libarchive/dist/libarchive/archive_read_disk_posix.c up to 1.2
external/bsd/libarchive/dist/libarchive/archive_read_open_filename.c up to 1.2
external/bsd/libarchive/dist/libarchive/archive_read_support_format_xar.c up to 1.2
external/bsd/libarchive/dist/libarchive/archive_write_disk_posix.c up to 1.6
external/bsd/libarchive/dist/libarchive/test/test_acl_platform_nfs4.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_acl_platform_posix1e.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_compat_zip.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_fuzz.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_extract.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_gtar_sparse.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_7075_utf8_paths.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_comment_stored.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_extra_padding.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_high_compression.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_jar.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_mac_metadata.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_malformed.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_msdos.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_nested.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_nofiletype.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_padded.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_sfx.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_with_invalid_traditional_eocd.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_format_zip_zip64.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_pax_truncated.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_read_truncated_filter.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_sparse_basic.c up to 1.3
external/bsd/libarchive/dist/libarchive/test/test_write_disk.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_write_disk_secure.c up to 1.4
external/bsd/libarchive/dist/libarchive/test/test_write_format_cpio_empty.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_write_format_shar_empty.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_write_format_tar.c up to 1.2
external/bsd/libarchive/dist/libarchive/test/test_write_format_tar_sparse.c up to 1.2
external/bsd/libarchive/dist/tar/write.c up to 1.3
external/bsd/libarchive/dist/tar/test/test_basic.c up to 1.2
external/bsd/libarchive/dist/tar/test/test_copy.c up to 1.3
external/bsd/libarchive/dist/tar/test/test_option_C_upper.c up to 1.2
external/bsd/libarchive/dist/tar/test/test_option_s.c up to 1.2
external/bsd/libarchive/dist/test_utils/test_common.h up to 1.2
external/bsd/libarchive/dist/test_utils/test_main.c up to 1.2

PR 56257: sync libarchive with -current (leaving out changes not relevant
for this branch).

(martin)

Regen for ticket #1685

(martin)

Pull up following revision(s) (requested by dholland in ticket #1685):

sys/sys/namei.src: revision 1.59 (via patch)
sys/kern/vfs_vnops.c: revision 1.215
sys/kern/vfs_lookup.c: revision 1.226

Add a new namei flag NONEXCLHACK for open with O_CREAT and not O_EXCL.
This case needs to be distinguished from the other CREATE operations
because it is supposed to successfully return (and open) the target if
it exists. In the case where that target is the root, or a mount
point, such that there's no parent dir, "real" CREATE operations fail,
but O_CREAT without O_EXCL needs to succeed.

So (a) add the flag, (b) test for it in namei in the situation
described above, (c) set it in open under the appropriate
circumstances, and (d) because this can result in namei returning
ni_dvp of NULL, cope with that case.

Should get into -9 and maybe even -8, because it was prompted by
issues with 3rd-party code. The use of a flag (vs. adding an
additional nameiop, which would be more appropriate) was deliberate to
make the patch small and noninvasive.

(martin)

Regen for ticket #1296

(martin)

Pull up following revision(s) (requested by dholland in ticket #1296):

sys/sys/namei.src: revision 1.59 (via patch)
sys/kern/vfs_vnops.c: revision 1.215
sys/kern/vfs_lookup.c: revision 1.226

Add a new namei flag NONEXCLHACK for open with O_CREAT and not O_EXCL.
This case needs to be distinguished from the other CREATE operations
because it is supposed to successfully return (and open) the target if
it exists. In the case where that target is the root, or a mount
point, such that there's no parent dir, "real" CREATE operations fail,
but O_CREAT without O_EXCL needs to succeed.

So (a) add the flag, (b) test for it in namei in the situation
described above, (c) set it in open under the appropriate
circumstances, and (d) because this can result in namei returning
ni_dvp of NULL, cope with that case.

Should get into -9 and maybe even -8, because it was prompted by
issues with 3rd-party code. The use of a flag (vs. adding an
additional nameiop, which would be more appropriate) was deliberate to
make the patch small and noninvasive.

(martin)

efiboot: Use disk I/O protocol for block device access.

EFI_DISK_IO_PROTOCOL is a simplified interface to block devices. Use this
instead of EFI_BLOCK_IO_PROTOCOL for accessing block devices to simplify
the code -- we no longer need to worry about the underlying media's block
I/O size and alignment requirements.

(jmcneill)

make: document ParseDependencyOp

(rillig)

make: document where to find tests for the dependency lines

(rillig)

make: extract ParseDependencySources from ParseDependency

No functional change.

(rillig)

make: fix documentation for ParseModifierPart

(rillig)

tests/make: remove unnecessary -dL from moderrs.mk

It was only needed for the test for unmatched subexpressions in the
modifier ':C'.  That test has been moved to varmod-subst-regex.mk.

(rillig)

tests/make: move and extend test for unmatched '\1' in ':C'

This test lived together with a few unrelated tests in moderrs.mk, it is
better placed in varmod-subst-regex.mk though.

While here, extend, document and explain the test since its purpose was
not obvious from reading the code alone.

(rillig)

lagg: fix typo

(yamaguchi)

Do not report unmatched regex subexpressions

It is not always an error for a subexpression to have not matched,
since the regex library can/does not convey how many matches are
expected, only report an error if opts.strict (-dL)

Reviewed by: christos

(sjg)

fix proplib deprecation

(christos)

fix proplib deprecation

(christos)

fix proplib deprecation

(christos)

fix proplib deprecation

(christos)

fix proplib deprecation

(christos)

fix proplib deprecation

(christos)

fix proplib deprecation

(christos)

fix proplib deprecation

(christos)

fix proplib deprecation

(christos)

fix proplib deprecation

(christos)

fix proplib deprecation

(christos)