revert previous, do it differently and explain why.

(christos)

Don't include fdtvar.h directly here.

(thorpej)

Revert most of previous -- some consumers of this file still have
ACPI-specific requirements.

(thorpej)

ia->ia_cookie -> devhandle_to_of(device_handle(self))

(thorpej)

No need to include smuiicvar.h.

(thorpej)

Adapt the smu driver to the new i2c device enumeration method.  While
here, collapse the "smuiic" driver into the base "smu" driver; it was
superfluous given how the rest of the "smu" driver is structured.

(thorpej)

fix casts and types to make it compile with clang

(christos)

make this compile again under clang:
- factor out duplicated code
- add casts
- plug memory leak

(christos)

make xt_error() dead for the benefit of clang

(christos)

Use __noreturn__ instead of noreturn because <stdnoreturn.h> #defines
noreturn _Noreturn and this gives clang a heartache.

(christos)

fix clang build (on_signal is dead)

(christos)

ossaudio: Set handle on OSSv4 mixer devices

(nia)

libossaudio: Various OSSv4 fixes to allow reference programs to compile

- Define various new AFMT_*. These are not returned as supported
  formats by SNDCTL_DSP_GETFMTS, because it would be very silly to
  have Vorbis in the kernel.

- Implement PLAYTGT and RECSRC. For each NetBSD audio device
  we only return one playback and recording source, "primary".

- Return preferred channel configuration in capabilities.
  Either DSP_CH_STEREO, DSP_CH_MONO, or DSP_CH_MULTI
  depending on the current hardware format.

- SNDCTL_DSP_HALT_* simply flushes the audio device.

(nia)

Do not allow editing of start/size/fs-type for partitions that
are already carved in stone (e.g. defined in an outer MBR while we are
editing the inner disklabel).

(martin)

Keep MSDOS partition size and subtype consistent - some u-boot are picky.

(martin)

For FS_MSDOS report the MBR type as fs_sub_type.

(martin)

Ticket #1270

(martin)

Pull up following revision(s) (requested by dolecek in ticket #1270):

sys/dev/pci/siisata_pci.c: revision 1.21

disable MSI for SiI3124 - interrupts don't seem to work on this old board
when MSI is enabled, maybe because it's behind a PCI bridge

PR kern/55115 by John D. Baker

(martin)

Adapt the pmu driver to the new i2c device enumeration mechanism.  This
follows the OpenFirmware bindings for the most part, but has the i2c
addresses of children shifted left one bit as it would appear on the
wire (for the r/w bit).

(thorpej)

Adapt the Keywest i2c controller driver to the new i2c device enumeration
mechanism.  We need to provide our own enumeration callback because these
controllers do not use the standard OpenFirmware bindings.

The Keywest controller supports 2 physical i2c busses on a single controller,
so we logically split it up that way now, rather than encoding the channel in
in the i2c address as was done previously.

Different systems have different I2C device tree topologies.

Some systems use a scheme like this:

/u3@0,f8000000/i2c@f8001000/temp-monitor@98
/u3@0,f8000000/i2c@f8001000/fan@15e

Here, we see the channel encoded in bit #8 of the address.

Other systems use a scheme like this:

/ht@0,f2000000/pci@4000,0,0/mac-io@7/i2c@18000/i2c-bus@0
/ht@0,f2000000/pci@4000,0,0/mac-io@7/i2c@18000/i2c-bus@0/codec@8c

/u4@0,f8000000/i2c@f8001000/i2c-bus@1
/u4@0,f8000000/i2c@f8001000/i2c-bus@1/temp-monitor@94

Here, a separate device tree node represents the channel.
Note that in BOTH cases, the I2C address of the devices are
shifted left by 1 (as it would be on the wire to leave room
for the read/write bit).

(thorpej)

Disable again initfini; breaks some archs and not worth dealing with when
we have both gcc's active in the tree.

(christos)

ia->ia_cookie -> devhandle_to_of(device_handle(self))

(thorpej)

ia->ia_cookie -> devhandle_to_of(device_handle(self))

(thorpej)

There are no more consumers of i2c attach args "cookie" and "cookietype",
so garbage-collect them.

(thorpej)

Rather than using the "cookie" from the i2c_attach_args, use the
device handle that's already associated with our device_t.

(thorpej)

Use device_enumerate_children() to eliminate all of the ACPI-specific
code and most of the FDT-specific code from the iicmux driver.

(thorpej)

aiomixer: bound the drawn area to the screen size, rather than replacing it

(nia)

aiomixer: do not adjust class widget pad height, draw to end of screen

ncurses refuses to paint pads if the height argument extends beyond
the bounds of the screen. it's probably not good for our curses either.

libcurses wresize() refuses to resize a pad beyond the bounds of the
screen even if it was created with a larger size. this is probably
a bug.

found by uwe

(nia)

- Add an optional bus number to i2cbus_attach_args, and a corresponding
  optional "bus" locator to the i2cbus interface attribute.
- Add a iicbus_print_multi() routine, which is like iicbus_print(),
  but also prints the bus number.
- Use these new features in the iicmux driver rather than winging it.

(thorpej)

Also include terminfo for platforms with static libraries (e.g. sun2). From uwe/nia.

(cjep)

aiomixer: fix background banding with slightly older libcurses

reported by uwe

(nia)

KNF

(skrll)

KNG

(skrll)

aiomixer: try to make sure the first pane is always "outputs"

In QEMU with an ac97 audio device, "inputs" is the first pane,
which is significantly less important especially when you don't
have input in QEMU most of the time.

(nia)

aiomixer: Fix sorting of ac97 controls

(nia)

doc: imported aiomixer

(nia)

mention gdb hack discovered by rin.

(christos)

PR/56153: Rin Okuyama: alpha miscompiles malloca() macro.

(christos)

Children of the "cuda" i2c controller don't appear in the OF device tree,
so we need to supply our own "i2c-enumerate-devices" method.

(thorpej)

iic_print_direct(): In the "not configured" case, parenthetically print
the first element of the compat list, if we got a compat list.

(thorpej)

Ticket #1269

(martin)

Pull up following revision(s) (requested by rin in ticket #1269):

etc/etc.mac68k/ttys: revision 1.21

Turn on constty instead of ttyE0 as done for majority of other ports
in order to make both framebuffer and serial consoles happy.

Also, change TERM from vt220 to vt100 for console and constty
in accordance with other ports.

(martin)

Turn on constty instead of ttyE0 as done for majority of other ports
in order to make both framebuffer and serial consoles happy.

Also, change TERM from vt220 to vt100 for console and constty
in accordance with other ports.

(rin)

Add missing aiomixer.debug to fix debug build.

XXX
I *really* hope someone(TM) invent better replacement of
distrib/sets/lists...

(rin)

Catch up with this commit:

http://www.nerv.org/netbsd/?q=id:20210507T165558Z.d4aba9e0e053181f2a98ee4ee43012b50949921b

by which per slot tcs_used flag was obsoleted.

No need to initialize __BIT(0) of sc_slots_used here; it is zero anyway
before calling tcattach().

(rin)

avoid accessing stack garbage.

on arm64eb resuming vi(1) would often crash.  in makech(), the 'csp'
variable is either set to current window data, or a local stack
variable's address '&blank'.  the window data has many lines of info
stored, and 'csp++' is used per line here.  unfortunately, a case
existed where 'csp++' operated on csp initialised from '&blank' which
eventually crashes when, on my display with 160 columns and 'csp + 155'
exceeds the mapped stack and crashes.

match the '!_cursesi_screen->curwin' conditional that initialises csp,
and avoid csp++ here.  assert() that csp != &blank in both places that
modify csp.

thanks to jdc@ and mlelstv@.

XXX: possibly also should avoid the putch() here as well.

(mrg)

Update the i2c mux code for the new enumeration methods.

(thorpej)

Use pci_compatible_match().

(thorpej)

More symbol sanitizing.

(thorpej)

enable initfini-array since all platforms support it.

(christos)

Static'ify more symbols.

(thorpej)

hook up aiomixer

(nia)

aiomixer: display the unit type for value controls

(nia)

Ticket #1678

(martin)

aiomixer: use standout for headings, avoid banding in header

fixed a minor rendering problem when compiled against ncurses.

based mostly on feedback from uwe.

(nia)

Pull up following revision(s) (requested by mrg in ticket #1678):

bin/pax/options.c: revision 1.119
usr.bin/config/scan.l: revision 1.32
usr.bin/make/main.c: revision 1.274
bin/pax/extern.h: revision 1.60
usr.bin/config/defs.h: revision 1.106
usr.bin/make/make.h: revision 1.105
sbin/newfs_udf/udf_create.c: revision 1.27 (patch)
sbin/newfs_udf/newfs_udf.h: revision 1.7 (patch)
usr.bin/config/main.c: revision 1.100
usr.sbin/installboot/Makefile: revisions 1.53,1.54 (patch)
usr.sbin/installboot/installboot.h: revision 1.41 (patch)
usr.sbin/installboot/machines.c: revisisons 1.41,1.42 (patch)

Avoid depending on common symbols.

(martin)

Liberally sprinkle static around to get more symbols out of the
global namespace.  A small bit of const poisoning in the TC code.

(thorpej)

A small bit of const poisoning.

(thorpej)

import aiomixer from git into usr.bin.

aiomixer is a graphical (curses-based) mixer for NetBSD audio.

(nia)

More test notes from using build.sh against non NetBSD platforms.

(cjep)

For GCC10, add -Wno-unused-result for alloca(0) here and there.

(rin)

Don't free things twice (Kengo Nakahara)

(christos)

Track the number of cdev and bdev opens and fail dm_detach()
on open devices unless detach is forced.

PR kern/54969 (Disk cache is no longer flushed on shutdown)

(hannken)

Make sure the unit number of device-mapper devices matches their minor number.

(hannken)

Print the error value of ixgbe_reset_hw() for debugging.

(msaitoh)

PR/56148: Andreas Gustafsson: lib/libc/stdio/t_printf:snprintf_float test
randomly fails.
Add checks to all places where lshift is called because it can return NULL

(christos)

PR port-mvme68k/56146

Build wrtvid as tools.

(rin)

Unhook elf2bb and txlt as they are built as tools.

(rin)

Update with information from recent testing of different Linux variants
on AWS. Also FreeBSD 13.

(cjep)

avoid GCC-10 warnings.

(mrg)

do not clear destination address if there is no saved address
and add initialization of saved_hisaddr for safety

0.0.0.0 was sometimes configured to destination address when
ipcp close was occurred before ipcp tlu.
Following messages will be appeared when the issue is encountered and
debug for pppoe(4) is enabled.

tc-so:[    1.890005] pppoe0: ipcp close(starting)
(snip)
tc-so:[    1.890005] pppoe0: ipcp_open(): no IP interface

(yamaguchi)

Added m_freem for safety

pointed out by knakahara@, thanks.

(yamaguchi)

Added missing waiting for DAD completion

(yamaguchi)

Fix GENERIC64 build

(jmcneill)

disable MSI for SiI3124 - interrupts don't seem to work on this old board
when MSI is enabled, maybe because it's behind a PCI bridge

PR kern/55115 by John D. Baker

(jdolecek)

Ticket #1268

(martin)

Pull up following revision(s) (requested by nia in ticket #1268):

sys/dev/audio/audio.c: revision 1.95

audio: Only score hardware formats by channel count at count<=2

Scoring by channel count makes sense when you are using hardware that
supports mono and stereo formats. However, if your hardware also supports
surround formats, defaulting to those might be confusing. So, don't
prefer them.

Problem reported and fix tested by tcmart14 with a 2015 model Macbook Pro.

(martin)

Remove unneeded Makefile dependency for things which have long since
used opt_*.h headers.

(thorpej)

Remove unused dot_conv() function.

(thorpej)

Disable preemption around the main work of badaddr_read() and delay();
they both use "current CPU" resources.

(thorpej)

Make scb_strat() static.

(thorpej)

PR/56147: Miroslav Lichvar: Avoid memory leak if strdup fails.

(christos)

Add loadfile_machdep.h for riscv

(jmcneill)

evbarm: Add support for Allwinner V3s SoCs.

(jmcneill)

Add support for Allwinner V3s, from Rui-Xiang Guo.

(jmcneill)

don't assume host BUFSIZ is sufficent.  small BUFSIZ leads to
always happens errors in the testsuite.  switch all these buffers
to be 4KiB sized.  reported by embr <git@liclac.eu>

(mrg)

include <stdint.h>.  bozo_unconst() uses uintptr_t defined here.
from embr <git@liclac.eu>.

(mrg)

Sprinkle some static.

(simonb)

The watchdog setup code isn't used (yet), so don't compile in the
octeon_nmi_stack that it uses either.

(simonb)

Decorate cpu_info_list with __read_mostly; it's never modified once
all the CPUs are attached.

(thorpej)

Moar static.

(thorpej)

Add a linker script for the kernel.  The main difference vs the
standard built-in for "ld -N" is to actually process the
.data.cacheline_aligned and .data.read_mostly sections correctly.

(thorpej)

prekern: add warnings upon problems collecting entropy

As submitted on port-amd64@ (part 3/3)

Tested on NetBSD/amd64.

(khorben)

prekern: do not choke on bad entropy files

As submitted on port-amd64@ (part 2/3)

Tested on NetBSD/amd64.

(khorben)

prekern: add support for warning messages

As submitted on port-amd64@ (part 1/3)

Tested on NetBSD/amd64.

(khorben)

tests/lint: make test for message 118 platform-independent

(rillig)

Set VERSIONMACHINE to ${MACHINE} instead of evbarm (oops)

(jmcneill)

Fix code example (from RVP)

(christos)

Fix incorrect structure name (Rocky Hotas)

(christos)

libXaw: fix Clang build

--- Pixmap.pico ---
error: unknown warning option '-Wno-discarded-qualifiers'; did you mean
'-Wno-ignored-qualifiers'? [-Werror,-Wunknown-warning-option]

(rillig)

compiler_rt: build .a.syms files as part of dependall

The previous target 'all' is a top-level target intended to be specified
by the user.  During the regular build, 'dependall' is used instead of
'all'.  The target 'realall' is common to those two.

(rillig)

bind: remove unnecessary CONSTCOND

Lint does not need this anymore, since 2021-01-31.

(rillig)

bind: fix Clang build

I had already fixed this on 2021-03-27, but the fix was accidentally
reverted on 2021-04-29 when updating to bind 9.16.15.

(rillig)

Always expose pmap_tlb_update_addr now that all current PMAP_HWPAGEWALKERs
(arm) users provide the required functions.

(skrll)

Provide pte_{value,valid_p}

(skrll)

lint: fix assertion failure when promoting a bit-field larger than int

(rillig)

tests/lint: demonstrate assertion failure "len == size_in_bits(INT)"

Seen on sparc64 in hdtoa.c:341 since sparc64 is one of the platforms
that has 128-bit long double and defines struct ieee_ext.ext_frach:48
based on uint64_t, which is a GCC extension.  Plain C99 only allows
_Bool, signed int and unsigned int as base type for bit-fields.

(rillig)

Sort __HAVE_ #defines.  NFCI.

(skrll)

Remove unnecssary brackets.  Same binary before and after.

(skrll)

bcm2838_pcie: match brcm,bcm2711-pcie

(tnn)

Add links for the other functions documented in arc4random(3).

(simonb)

genet(4): Add support for rnd(9).

(rin)

Remove duplicate #ifdef block.

(fcambus)

ticket #1677

(bouyer)

Pull up following revision(s) (requested by martin in ticket #1677):
sys/kern/kern_exec.c: revision 1.505 via patch
Fix copy&pasto in handling of POSIX_SPAWN_RESETIDS in posix_spawn(3)

(bouyer)

ticket #1265

(bouyer)

Pull up following revision(s) (requested by martin in ticket #1265):
sys/kern/kern_exec.c: revision 1.505 via patch
Fix copy&pasto in handling of POSIX_SPAWN_RESETIDS in posix_spawn(3)

(bouyer)

Tickets #1266 and #1267

(martin)

Pull up following revision(s) (requested by hannken in ticket #1267):

sys/miscfs/fdesc/fdesc_vnops.c: revision 1.135

Make sure fdesc_lookup() never returns VNON vnodes.
Should fix PR kern/56130 (fdescfs create nodes with wrong major number)

(martin)

Pull up following revision(s) (requested by rin in ticket #1266):

external/gpl3/binutils/dist/bfd/elf32-ppc.c: revision 1.16
external/gpl3/binutils/dist/bfd/elf64-ppc.c: revision 1.16

Fix regression where ld(1) is trapped into infinite loop when
linking binary whose text does not fit within R_PPC_REL24.

Reported upstream as Bug 27755:
https://sourceware.org/bugzilla/show_bug.cgi?id=27755

This problem was introduced to binutils-2-31-1 for our tree.
netbsd-9 is affected, while netbsd-8 is not.

(martin)

Remove duplicate lines.

(nakayama)

Whitespace police.

(simonb)

lint: undefine macros for defining keywords after use

No functional change.

(rillig)

if_wm: do not return a void value from a void function

This is a GCC extension.

(rillig)

lint: remove redundancy when defining classic keywords

No functional change.

(rillig)

lint: reduce redundancy when defining GCC attributes

This macro would have prevented the unintended inconsistency in the
attribute 'pcs' (for ARM).

No functional change.  The generated code is the same, except for the
line numbers in lint_assert.

(rillig)

lint: allow variables to be named 'pcs'

(rillig)

tests/lint: demonstrate bug in the lexer for GCC attributes

(rillig)

lint: fix parsing of __typeof__ after statement in ({ ... })

Since C99, declarations and statements can be freely mixed, and GCC
supported this even before 1999.

(rillig)

tests/lint: remove outdated comment

The test d_gcc_extension is already activated in line 121.

(rillig)

lint: fix compiler warning about signedness mismatch

No functional change.

(rillig)

lint: allow large integer types for bit-fields in GCC mode

These types are explicitly allowed by GCC.

I'm not sure which of the flags -g and -p should be stronger.  That is,
if both -g and -p are given, should 'unsigned char' be allowed as a
bit-field type since -g would allow it, or should it be warned about
since -p warns about it?  For now, continue to warn about these.

(rillig)

lint: extract check_bit_field_type from declare_bit_field

No functional change.

(rillig)

tests/lint: fix test for GCC bit-field types

The whole purpose of this test is to try the message about invalid
bit-field types in GCC mode.  Therefore, use the default lint1-flags
that include -g.

(rillig)

audio: Only score hardware formats by channel count at count<=2

Scoring by channel count makes sense when you are using hardware that
supports mono and stereo formats. However, if your hardware also supports
surround formats, defaulting to those might be confusing. So, don't
prefer them.

Problem reported and fix tested by tcmart14 with a 2015 model Macbook Pro.

(nia)

tests/lint: add test for bit-field types in GCC mode

(rillig)

lint: on request, keep the preprocessor output

Previously, the simplest way of getting the preprocessed translation
unit was to run lint with the additional flag -V, which outputs the
command line of the C preprocessor, among other things.  That command
line does not include the proper quoting though, so it cannot be used
verbatim as a shell command if the command line contains spaces such as
in -Du64="unsigned long long".

In the common situation where lint is run via a Makefile, the option -V
had to be added in the Makefile itself since there is no make variable
for additional user-settable lint flags.  This is not straight-forward
enough.

Adding another command line option for this purpose would reduce the
remaining namespace for options.  Most of the 52 letters are already
used up.

To make this situation as simple as possible, preserve the output of the
C preprocessor depending on an environment variable.

(rillig)

lint: sort GCC attributes alphabetically in the grammar

No functional change.

(rillig)

tests/lint: demonstrate missing support for __packed __aligned

(rillig)

sys/conf/lint.mk: fix order of command line options

The option -o must come before the first filename.

Now it is possible to lint kern_exec.c at least.  The next failure is in
netbsd32_machdep.c:

netbsd32_machdep.c(395): error: illegal bit-field size: 255 [36]

That line in netbsd32_process_read_fpregs reads:

__CTASSERT(sizeof(*regs) == sizeof(struct save87));

This is probably a bug in lint.  The struct save87 contains 3 uint16_t,
followed by a union containing a uint64_t, followed by a packed struct
with size 10.  The combination of packed and padding is suspicious.

(rillig)

sys/conf/lint.mk: allow GCC extensions in the kernel

The syntax errors due to the __asm statements are now gone.  The file
kern_exec.c only produces a few warnings now.  But after running that
file through lint1, the main lint complains about wrong usage.  This is
due to this call:

${LINT} ... -i $< -o $@

The main lint has never supported -o after the first filename, so it
complains.  It would have been helpful if lint had given any hint as to
which option was invalid.  Anyway, the next step is to reorder the
arguments.  As it is now, the code can never have worked.

(rillig)

sys/conf/lint.mk: a small step for linting the kernel

Due to the missing path, the following commands had failed:

$ cd src/sys/arch/amd64/compile/GENERIC
$ nbmake-amd64-lint kern_exec.ln
nbmake: don't know how to make kern/kern_exec.c. Stop

After fixing the path, "make kern_exec.ln" fails with:

sys/kern/kern_exec.c(65): error: syntax error '"' [249]

The affected line contains:

__KERNEL_RCSID(0, "...");

The macro __KERNEL_RCSID expands to __asm("some strings").  Since
KERNLINTFLAGS is missing the -g, lint does not recognize __asm as
keyword and tries to parse it as an identifier instead, expecting a
variable or function declaration.

(rillig)

implement fo_restart hook for kqueue descriptors, so that close(2)
on the descriptor won't block indefinitely if other thread is currently
blocked on the same kqueue in kevent(2)

done similarily to pipes and sockets, i.e. using flag on the potentially
shared kqueue structure hooked off file_t - this is somewhat suboptimal
if the application dup(2)ped the descriptor, but this should be rare
enough to not really matter

usually this causes the kevent(2) to end up returning EBADF since
on the syscall restart the descriptor is not there anymore; if
dup(2)ped the kevent(2) call can continue successfully if the closed
kqueue descriptor was other than the one used for the kevent(2)
call

PR kern/46248 by Julian Fagir

(jdolecek)

Add RISC-V 64-bit support.

(jmcneill)

countmail: remove outdated comments

Using the shell builtin 'read' command was necessarily slow because it
is specified to read a single byte at a time.

(rillig)

games: remove trailing whitespace in *.c and *.h

(rillig)

fish: remove trailing whitespace

(rillig)

fish: use arc4random_uniform for drawing random numbers

Thanks nia@ for the hint.

(rillig)

Add test for POSIX_SPAWN_RESETIDS flag

(martin)

Ticket #1264

(martin)

Pull up following revision(s) (requested by nia in ticket #1264):

external/cddl/osnet/dist/cmd/zfs/zfs.8: revision 1.2
external/cddl/osnet/dist/cmd/zpool/zpool.8: revision 1.2

zfs: Fix up references to FreeBSD

(martin)

Fix copy&pasto in handling of POSIX_SPAWN_RESETIDS in posix_spawn(3)

(martin)

gcc-11.1.0 is out.

(wiz)

fish: remove modulo bias from random number generation

It probably doesn't matter in practice, but omitting this piece of code
always looks like an oversight.

(rillig)