Link [ NetBSD | NetBSD OpenGrok source search | PR fulltext-search | Summary of daily snapshot builds | history of daily build result | pkgsrc commit viewer ]


   
        usage: [branch:branch] [user:user] [path@revision] keyword [... [-excludekeyword [...]]] (e.g. branch:MAIN sys/arch/arm, if_wm.c@1.234 )




switch to index mode

recent branches: MAIN (1h)  netbsd-8 (5d)  netbsd-10 (6d)  netbsd-9 (12d)  thorpej-ifq (176d)  thorpej-altq-separation (178d) 

2024-05-10 16:17:39 UTC Now

2021-03-22 17:15:17 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by nia in ticket #1232),
all via patch and adpated to netbsd-9:

share/man/man4/pci.4: revision 1.111
share/man/man4/pci.4: revision 1.112
share/man/man4/pci.4: revision 1.113
share/man/man4/pci.4: revision 1.114
share/man/man4/pci.4: revision 1.115
share/man/man4/pci.4: revision 1.116

add ena(4)
Put cross-references in a useful place, copying usb(4)
Caught a few drivers in the list that no longer exist this way.
Be less redundant in the DESCRIPTION
cross-reference pci(9)
add rtsx(4)
s/Disk and tape/Storage/g, more relevant cross-references

(martin)

2021-03-22 16:51:24 UTC MAIN commitmail json YAML

tests/lint: explain wrong type mismatch in compound literal

When a pointer to a compound literal is used as an initializer, lint
reports a wrong type mismatch.  The details of what happens are now
documented, which allows this problem to be fixed properly.

(rillig)

2021-03-22 16:47:13 UTC thorpej-cfargs commitmail json YAML

2021-03-22 16:23:46 UTC thorpej-cfargs commitmail json YAML

Audit CFARG_IATTR in config_found() calls, and remove it in situations
where the interface attribute is not ambiguous.

(thorpej)

2021-03-22 15:29:43 UTC MAIN commitmail json YAML

lint: use precise type information in message about type mismatch

While here, reword the message, avoiding operators and parentheses.

Since 2021-01-02, providing the precise type name is as easy as the
broad type classification (just replace tspec_name with type_name), and
it's definitely more useful to the human readers.

(rillig)

2021-03-22 15:12:24 UTC MAIN commitmail json YAML

bind: fix workaround for bug in lint

The previous attempt resulted in a 'syntax error'.

(rillig)

2021-03-22 15:05:00 UTC MAIN commitmail json YAML

lint: demonstrate bug in assignment of compound literal

Seen in external/mpl/bind/dist/lib/dns/rbtdb.c, update_rrsetstats.

(rillig)

2021-03-22 14:50:30 UTC thorpej-cfargs commitmail json YAML

No need to define interface attributes separately from the devices
that carry them if they are specific to that device; just declare the
interface on the device directly.

(thorpej)

2021-03-22 14:39:14 UTC thorpej-cfargs commitmail json YAML

sbp does not need its own (unused) interface attribute; it already
carries the "scsi" interface attribute.

(thorpej)

2021-03-22 14:11:02 UTC MAIN commitmail json YAML

Remove -DHAVE_STRCASECMP from CPPFLAGS that is defined in dix-config.h.

(tsutsui)

2021-03-22 14:10:06 UTC MAIN commitmail json YAML

Explicitly include dix-config.h for HAVE_foo definitions referred in os.h.

(tsutsui)

2021-03-22 03:28:55 UTC MAIN commitmail json YAML

2021-03-22 03:06:01 UTC thorpej-cfargs commitmail json YAML

mainbus does not need to carry the "pcibus" interface attribute; PCI
busses do not attach to mainbus, they attach to cpc@mainbus, and cpc
already carries the "pcibus" interface attribute.

(thorpej)

2021-03-22 02:01:02 UTC thorpej-cfargs commitmail json YAML

2021-03-22 01:36:10 UTC MAIN commitmail json YAML

Brush up previous, or make things more similar to x86:

- Prevent pic_name from appearing vmstat(1) twice.
- Restore "irq" in interrupt id fields of intrctl(8).

For these purposes,

- Add is_evname member to struct intr_source.
- Bump size of is_source to INTRIDBUF, and rename it to is_intrid for clarity.

Now, outputs from vmstat(1) and intrctl(8) are like:

----
$ vmstat -ev
...
openpic irq 39                                3967  26 intr
...
$ intrctl list
interrupt id  CPU0  device name(s)
...
openpic irq 39 3967* wdc1
...
----

(rin)

2021-03-22 00:09:06 UTC MAIN commitmail json YAML

New sentence, new line.

(wiz)

2021-03-21 23:41:52 UTC MAIN commitmail json YAML

2021-03-21 23:29:36 UTC MAIN commitmail json YAML

note that ttyaction.[35] first appeared in netbsd 1.3.

(mrg)

2021-03-21 23:03:33 UTC MAIN commitmail json YAML

make: fix typos in documentation of ModChain

(rillig)

2021-03-21 21:26:00 UTC MAIN commitmail json YAML

Use standard section names, sort, use more macros.

(wiz)

2021-03-21 21:09:16 UTC thorpej-cfargs commitmail json YAML

Give config_found() the same variadic arguments treatment as
config_search().  This commit only adds the CFARG_EOL sentinel
to the existing config_found() calls.  Conversion of config_found_sm_loc()
and config_found_ia() call sites will be in subsequent commits.

(thorpej)

2021-03-21 20:45:00 UTC MAIN commitmail json YAML

lint: prefix error messages with 'error:'

This makes it easier to find these errors in the build logs.

(rillig)

2021-03-21 20:30:19 UTC MAIN commitmail json YAML

lint: remove redundant prototypes

No functional change.

(rillig)

2021-03-21 20:18:45 UTC MAIN commitmail json YAML

lint: adjust type in documentation of add_array

No functional change.

(rillig)

2021-03-21 20:08:21 UTC MAIN commitmail json YAML

2021-03-21 19:39:01 UTC MAIN commitmail json YAML

tests/lint: add test for reachability of non-constant conditions

(rillig)

2021-03-21 19:18:37 UTC MAIN commitmail json YAML

tests/lint: add test for reachability of nested 'if' statements

(rillig)

2021-03-21 19:14:41 UTC MAIN commitmail json YAML

2021-03-21 19:08:10 UTC MAIN commitmail json YAML

lint: invert 'rchflag', call it warn_about_unreachable instead

No functional change.

(rillig)

2021-03-21 19:06:19 UTC thorpej-cfargs commitmail json YAML

In "rescan" routines, always pass locators and the interface attribute
straight through to config_search().  Also, for devices that carry only
one interface attribute, no need to do an ifattr_match(), because
rescan_with_cfdata() will have already validated that the parent is
eligible, which includes an interface attribute check.

(thorpej)

2021-03-21 18:58:34 UTC MAIN commitmail json YAML

lint: reduce number of places where 'reached' is set

When determining the reachability of a statement, the idea was that
whenever 'reached' was set to false, 'rchflg' (the abbreviation for "do
not warn about unreachable statements") would be reset as well.

In some (trivial) cases, this was done, but many more interesting cases
simply forgot to set this second variable.  To prevent this in the
future, encapsulate this in a simple helper function.

Now even if a statement is reachable, 'rchflg' gets reset.  This does
not hurt since as long as the current statement is reachable, the value
of 'rchflg' does not matter.

No functional change.  There would be quite a big functional change
though if check_statement_reachable were to reset 'rchflg' instead of
'reached', as the comment already suggests.  In that case, with the
current code, many legitimate warnings about unreachable statements
would be skipped, especially those involving 'if' statements, since
these didn't reset 'rchflg' properly before.

(rillig)

2021-03-21 18:03:32 UTC thorpej-cfargs commitmail json YAML

Remove a now-unused variable.

(thorpej)

2021-03-21 17:58:40 UTC thorpej-cfargs commitmail json YAML

In config_search(), we already asserted that either an interface
attribute is not specified, or the specified attribute is carried
by the parent.

Add an additional assertion: That an interface attribute is specified
or that the parent has fewer than 2 interface attributes (i.e. lack of
interface attribute specification would be ambiguous).

Yes, "fewer than 2".  Zero interface attributes doesn't really make sense,
because a device cannot then be a parent of another device by definition.
But cfparent_match() would already catch this situation gracefully, and
there is obviously no ambiguity when a device has no interface attributes.

(thorpej)

2021-03-21 17:35:49 UTC thorpej-cfargs commitmail json YAML

CFARG_IATTR usage audit:

If a device carries only one interface attribute, there is no need
to specify it when calling config_search(); that specification is
meant only to disambiguate which interface attribute (which is a
proxy for "what kind of attach args are being used") is having
children attached.  cfparent_match() will take care of ensuring that
any potential children can attach to one of the parent's iterface
attributes, and if the parent only carries one, no disambiguation is
necessary.

(thorpej)

2021-03-21 16:58:07 UTC MAIN commitmail json YAML

use a pipe instead of sched_yield()

(christos)

2021-03-21 16:36:32 UTC MAIN commitmail json YAML

PR/56066: Jessica Clarke: Add tests for calling {_,}longjmp with a zero value.

(christos)

2021-03-21 16:32:00 UTC thorpej-cfargs commitmail json YAML

eumb does not need to carry the "mainbus" interface attribute.

(thorpej)

2021-03-21 16:21:35 UTC MAIN commitmail json YAML

revert the unintentional whitespace changes

(christos)

2021-03-21 16:12:37 UTC MAIN commitmail json YAML

Remove some obsolete information and add some more recent additions from
the nslookup.1 page in the distribution. Consider replacing this man page
with the one from the distribution, since this manual page describes options
available only in the original implemementation. On the other hand, this
man page is mdoc, not man... (Takahiro Kambe)

(christos)

2021-03-21 15:44:57 UTC MAIN commitmail json YAML

2021-03-21 15:34:13 UTC MAIN commitmail json YAML

2021-03-21 15:24:56 UTC MAIN commitmail json YAML

2021-03-21 14:49:21 UTC MAIN commitmail json YAML

2021-03-21 14:36:59 UTC MAIN commitmail json YAML

2021-03-21 14:12:46 UTC MAIN commitmail json YAML

tests/lint: sync redundant documentation in test for strict bool mode

(rillig)

2021-03-21 14:09:41 UTC MAIN commitmail json YAML

tests/lint: add tests for reachability of statements

Right now, reachability is only implemented for loops, but not for
selection statements.

(rillig)

2021-03-21 13:10:58 UTC MAIN commitmail json YAML

lint: add missing space when adding a new test case

(rillig)

2021-03-21 13:03:42 UTC MAIN commitmail json YAML

lint: rename c_rchif to c_reached_end_of_then

No functional change.

(rillig)

2021-03-21 12:19:37 UTC MAIN commitmail json YAML

tests/lint: demonstrate bug in endless loop detection

(rillig)

2021-03-21 12:10:27 UTC MAIN commitmail json YAML

lint: document why an unreachable statement is set to reachable

No functional change.

(rillig)

2021-03-21 12:08:34 UTC MAIN commitmail json YAML

lint: rename c_cont to c_continue

No functional change.

(rillig)

2021-03-21 12:06:10 UTC MAIN commitmail json YAML

lint: document the precise meaning of control_statement.c_break

No functional change.

(rillig)

2021-03-21 12:03:56 UTC MAIN commitmail json YAML

lint: rename i_infinite to i_maybe_endless

Not every loop that has 'while (1)' is an endless loop.  It may still
contain a 'return' somewhere.

(rillig)

2021-03-21 11:55:59 UTC MAIN commitmail json YAML

2021-03-21 11:48:04 UTC MAIN commitmail json YAML

2021-03-21 11:38:24 UTC MAIN commitmail json YAML

lint: remove redundant braces in doreturn

No functional change.

(rillig)

2021-03-21 10:50:08 UTC MAIN commitmail json YAML

audioctl.1: describe foibles

(nia)

2021-03-21 10:43:08 UTC MAIN commitmail json YAML

tests/lint: clarify that a brace-enclosed initializer needs an expr

(rillig)

2021-03-21 10:30:28 UTC MAIN commitmail json YAML

lint: rename d_fargs, d_fdpos and d_fpsyms to be less abbreviated

No functional change.

(rillig)

2021-03-21 10:25:40 UTC MAIN commitmail json YAML

2021-03-21 10:21:07 UTC MAIN commitmail json YAML

lint: rename d_rdcsym to d_redeclared_symbol

No functional change.

(rillig)

2021-03-21 10:16:12 UTC MAIN commitmail json YAML

lint: inline local variable in declarator_1_struct_union

No functional change.

(rillig)

2021-03-21 10:08:02 UTC MAIN commitmail json YAML

lint: rename clst to case_labels

No functional change.

(rillig)

2021-03-21 09:54:02 UTC MAIN commitmail json YAML

lint: rename declspecs to declaration_specifiers, just as in C99

No functional change.

(rillig)

2021-03-21 09:49:34 UTC MAIN commitmail json YAML

lint: rename grammar rule 'data_def' to 'top_level_declaration'

No functional change.

(rillig)

2021-03-21 09:22:35 UTC MAIN commitmail json YAML

lint: remove redundant '%prec' declarations from the grammar

No change to the generated binary.

(rillig)

2021-03-21 09:08:40 UTC MAIN commitmail json YAML

2021-03-21 09:00:55 UTC MAIN commitmail json YAML

-DKERNEL_BASE_VOFFSET= has annoyed me for the last time...

Introduce KERNEL_VOFFSET_RUNTIME which prevents the addition of
-DKERNEL_BASE_VOFFSET= to the command line and use it on the
__HAVE_GENERIC_START kernels which do runtime calculation of the
offset.

(skrll)

2021-03-21 08:55:59 UTC MAIN commitmail json YAML

lint: rename token T_XOR to T_BITXOR

For symmetry with the operator, which is named BITXOR.

No functional change.

(rillig)

2021-03-21 08:52:05 UTC MAIN commitmail json YAML

lint: in debug output, use uniform file location references

This makes it easy to click on the location in the IDE instead of having
to manually parse the location and navigate to it.

No functional change outside debug mode.

(rillig)

2021-03-21 08:46:26 UTC MAIN commitmail json YAML

lint: remove redundant operator information from the grammar

Several tokens can only ever map to a single operator and thus do not
need to encode the operator.  Indeed, they already encoded it as NOOP,
and it was not used by any grammar rule.

No functional change.

(rillig)

2021-03-21 07:32:44 UTC MAIN commitmail json YAML

Adjust the kernel virtual address space so that KASAN will map the kernel
seperately from managed kernel virtual memory and not map the unused space
between the two.

(skrll)

2021-03-21 07:17:12 UTC MAIN commitmail json YAML

2021-03-21 07:09:54 UTC MAIN commitmail json YAML

Remove the unnecessary invalidation code in arm_efirt_md_map_range.

pmapboot_enter will panic if any overlapping mappings existed before and
a full TLB invalidate was done as part of turning the MMU on in locore.

(skrll)

2021-03-20 23:50:16 UTC thorpej-cfargs commitmail json YAML

There is no need to have the "pcibus" interface attribute on mainbus;
PCI bus instances to not attach there.

(thorpej)

2021-03-20 22:10:17 UTC MAIN commitmail json YAML

seq.c: replace non-standard `\e` with standard compliant `\x1B`

(cheusov)

2021-03-20 21:08:10 UTC MAIN commitmail json YAML

lint: clean up new_name_node

No functional change.

(rillig)

2021-03-20 20:56:58 UTC MAIN commitmail json YAML

lint: move getopname over to tree.c

Except for the one use in print_tnode, the name of the operator is only
used in tree.c.

No functional change.

(rillig)

2021-03-20 20:49:43 UTC thorpej-cfargs commitmail json YAML

2021-03-20 20:47:53 UTC thorpej-cfargs commitmail json YAML

No need to pass the parent softc down to the indirect submatch routine;
it's available from the parent device_t there.

(thorpej)

2021-03-20 20:39:35 UTC MAIN commitmail json YAML

lint: remove redundant operator properties table

It's enough to have modtab, which describes the properties of the
various operators.  There is no need to have a second table imods that
holds the same content.  Rather make modtab constant as well.

The only possible functional change is that the names of the internal
operators 'no-op', '++', '--', 'real', 'imag' and 'case' may appear in
diagnostics, where previously lint invoked undefined behavior by passing
a null pointer for a '%s' conversion specifier.

(rillig)

2021-03-20 20:15:37 UTC MAIN commitmail json YAML

lint: fix argument names and table headings for operator definitions

The abbreviations in the table of operator properties had been wrong
since ops.def 1.10 from 2021-01-12, when strict bool mode was added.  In
an earlier working draft, I had named that column 'takes_others' instead
of 'requires_bool', that's where the 'o' came from.

The names of the macro arguments had been wrong since op.h 1.11 from
2021-01-09, when the order of the columns changed and the macros were
not adjusted accordingly.  Since all the properties of the operator
table are uniform, this didn't result in any bugs, it was just confusing
for human readers.

Clang-tidy suggests to enclose the macro arguments in oper.c in
parentheses but that is not possible since the arguments are either
empty or 1, and the syntactical ambiguity of the '+ 0' being either a
unary or a binary operator is needed here.

No change to the resulting binary.

(rillig)

2021-03-20 19:33:42 UTC thorpej-cfargs commitmail json YAML

The proliferation if config_search_*() and config_found_*() combinations
is a little absurd, so begin to tidy this up:

- Introduce a new cfarg_t enumerated type, that defines the types of
  tag-value variadic arguments that can be passed to the various
  config_*() functions (CFARG_SUBMATCH, CFARG_IATTR, and CFARG_LOCATORS,
  for now, plus a CFARG_EOL sentinel).
- Collapse config_search_*() into config_search() that takes these
  variadic arguments.
- Convert all call sites of config_search_*() to the new signature.
  Noticed several incorrect usages along the way, which will be
  audited in a future commit.

(thorpej)

2021-03-20 19:33:25 UTC MAIN commitmail json YAML

lint: make lint's own code pass the strict bool mode

No functional change.

(rillig)

2021-03-20 19:24:57 UTC MAIN commitmail json YAML

lint: use macro for initializing keywords table

Since today, lint's strict bool mode requires initializers to have the
correct type.  The flags in kwtab are of type bool and were initialized
with an int, for brevity.  Keep the brevity and do the conversion from
int to bool in a macro.

By defining several macros for the different kinds of keywords, reduce
the clutter of having 2 additional zeroes per line.  The macros also
remove the redundancy and thereby the possible inconsistency of filling
the wrong fields since these depend on the token type.

No functional change.  The only change to the binary is due to the
changed line numbers in the calls to lint_assert.

(rillig)

2021-03-20 18:59:00 UTC MAIN commitmail json YAML

lint: use macro for encoding type information

In lint's strict bool mode, initialization must be of the correct type.
This affects the bool fields in ttab_t, which are initialized with int.
To keep the code brief, preserve these ints and let a macro do the
actual work of converting them to bool.

No change to the generated binary.

(rillig)

2021-03-20 18:38:25 UTC MAIN commitmail json YAML

lint: inline access to type properties in check_bad_enum_operation

No functional change.

(rillig)

2021-03-20 17:18:50 UTC MAIN commitmail json YAML

lint: in strict bool mode, check initialization as well

C99 6.7.8p11 says for initialization that "the same type constraints and
conversions as for simple assignments apply", so actually apply them.
(I had just forgotten this "operator" when I first implemented strict
bool mode.)

(rillig)

2021-03-20 17:08:08 UTC MAIN commitmail json YAML

tests/lint: test initialization in strict bool mode

I somehow forgot to list INIT as one of the operators in
is_assignment_bool_or_other.

(rillig)

2021-03-20 16:16:32 UTC MAIN commitmail json YAML

lint: rename ftflg to seen_fallthrough

One less abbreviation to remember when reading the code.

No functional change.

(rillig)

2021-03-20 16:11:12 UTC MAIN commitmail json YAML

lint: make the calls to clear_warning_flags stand out less

Even though clear_warning_flags and its companions are implemented as
macros, they act like ordinary functions.  Do not distract the reader by
using uppercase names for them.

No functional change.

(rillig)

2021-03-20 15:30:58 UTC MAIN commitmail json YAML

lint: clean up grammar for declaration after statement

No functional change.

(rillig)

2021-03-20 15:28:07 UTC MAIN commitmail json YAML

lint: fix check for declaration after statement in pre-C99 mode

The new code may not be the most beautiful, but it fixes all bugs that
occurred while testing message 327.  The grammar rules are taken from
C99 6.8.2, so it's no surprise they work well.

(rillig)

2021-03-20 14:30:50 UTC MAIN commitmail json YAML

Make pmapboot_enter panic if anything goes wrong and any mappings overlap
rather than only doing it in locore.S

(skrll)

2021-03-20 14:27:47 UTC MAIN commitmail json YAML

cmp.c: use C99 strtoll(3) instead of legacy strtoq(3)

(cheusov)

2021-03-20 14:17:56 UTC MAIN commitmail json YAML

lint: properly name C99 in message about declaration after statement

Now that C99 has been released and published, there is no reason anymore
to refer to it as C9X.

(rillig)

2021-03-20 14:13:51 UTC MAIN commitmail json YAML

tests/lint: add test for declaration after statement

(rillig)

2021-03-20 13:53:28 UTC MAIN commitmail json YAML

lint: use proper boolean literals instead of 0/1

The code in the C grammar is generated by yacc and is not checked by
lint's strict bool mode, therefore the replacement was done manually.

No change to the resulting change.

(rillig)

2021-03-20 13:25:31 UTC MAIN commitmail json YAML

lint: update comment on setasm for C99

No functional change.

(rillig)

2021-03-20 13:22:06 UTC MAIN commitmail json YAML

lint: reduce indentation and braces in merge_type_specifiers

No functional change.

(rillig)

2021-03-20 13:06:05 UTC MAIN commitmail json YAML

lint: extract adjusting of the storage class into separate function

No functional change.

(rillig)

2021-03-20 13:00:43 UTC MAIN commitmail json YAML

lint: document the struct for declarations more precisely

No functional change.

(rillig)

2021-03-20 11:33:50 UTC MAIN commitmail json YAML

lint: remove unnecessary '%prec T_COMMA' from grammar

My previous commit message was wrong in saying that the '%prec' was
necessary.  It is not necessary.

Most probably I misspelled the name of the grammar rule as opt_comma
instead of comma_opt, which would lead to the same number of conflicts
in the grammar plus a warning, but no build failure.

(rillig)

2021-03-20 11:24:49 UTC MAIN commitmail json YAML

lint: join grammar rules for initialization

The '%prec T_COMMA' is necessary to avoid lots of parse errors in the
lint1 unit tests.  Curiously, further down in the grammar, for compound
literals, the '%prec T_COMMA' is not necessary, even though the context
looks very similar.

No functional change.

(rillig)

2021-03-20 11:05:16 UTC MAIN commitmail json YAML

lint: fix grammar for initialization

Previously, the grammar syntactically accepted the following code:

int var = .member = 12345;

The designation '.member =' can only be used with brace-enclosed
initializers.

(rillig)

2021-03-20 10:32:43 UTC MAIN commitmail json YAML

lint: align rule names in grammar with C99

No functional change.

(rillig)

2021-03-20 08:59:46 UTC MAIN commitmail json YAML

tests/lint: add more tests for initialization, based on C99 6.7.8

(rillig)

2021-03-20 08:54:27 UTC MAIN commitmail json YAML

lint: fix assertion failure after error in designation

In d_c99_init.c, the initialization of array_with_designator failed.
The designator '.member' from that initialization was not cleaned up
before starting the next initialization.

(rillig)

2021-03-20 08:16:30 UTC MAIN commitmail json YAML

lint: replace segmentation fault with assertion failure

(rillig)

2021-03-20 06:48:23 UTC MAIN commitmail json YAML

Don't mark EFI runtime pages LX_BLKPAG_OS_READ | LX_BLKPAG_OS_WRITE as
these bits are only used by the current pmap fault code and these are
wired pages which will never fault.

(skrll)

2021-03-20 05:58:23 UTC MAIN commitmail json YAML

Apply the

earlyconsgetc: return -1 instead of 0 because we will never produce input

fix to all copies.

(skrll)

2021-03-20 04:56:52 UTC MAIN commitmail json YAML

Fix and improve the buffer length calculation to avoid zero length
even if blk_ms is small.
This fixes PR kern/56059.

(isaki)

2021-03-19 18:17:46 UTC MAIN commitmail json YAML

lint: improve debug loggin for initialization

(rillig)

2021-03-19 17:40:37 UTC MAIN commitmail json YAML

tests/lint: add comma to struct initialization

This places the error marker one line up, where it is expected.

(rillig)

2021-03-19 17:37:57 UTC MAIN commitmail json YAML

lint: rename designator_pop_name to designator_shift_name

The entries are removed from the beginning, not from the end.

No functional change.

(rillig)

2021-03-19 10:23:34 UTC MAIN commitmail json YAML

earlyconsgetc: return -1 instead of 0 because we will never produce input

(jmcneill)

2021-03-19 08:23:39 UTC MAIN commitmail json YAML

lint: use standard form of statement macro for debug_node

No functional change.

(rillig)

2021-03-19 08:21:26 UTC MAIN commitmail json YAML

2021-03-19 08:19:25 UTC MAIN commitmail json YAML

lint: rename tsize to type_size_in_bits

The shorter name size_in_bits was already taken by the function-like
macro with argument type tspec_t.

No functional change.

(rillig)

2021-03-19 08:01:58 UTC MAIN commitmail json YAML

tests/lint: add test for incompatible pointer types in return

(rillig)

2021-03-19 07:54:13 UTC MAIN commitmail json YAML

lint: add reminder that C99 does not allow '{}' in initializer

No functional change.

(rillig)

2021-03-19 07:51:33 UTC MAIN commitmail json YAML

Support pmap_growkernel and KASAN shadow mapping of the new KVA.

Neither mips nor ppc booke actually use pmap_growkernel (at present).

Thanks to rin@ for testing a similar patch on ppc booke.

(skrll)

2021-03-19 01:02:53 UTC MAIN commitmail json YAML

2021-03-19 00:55:02 UTC MAIN commitmail json YAML

lint: rename push_member and pop_member

These two functions are supposed to model the designator that is used
for initializing structs and arrays.  The implementation is still buggy
and does not work at all for C99 designators with multiple names, see
d_init_pop_member.c.

For now, just rename the functions to head in the right direction.

No functional change.

(rillig)

2021-03-19 00:44:09 UTC MAIN commitmail json YAML

Sprinkle a few more \n's and the end of some debug printfs.

(simonb)

2021-03-19 00:39:17 UTC MAIN commitmail json YAML

lint: extend documentation about initialization

No functional change.

(rillig)

2021-03-19 00:19:32 UTC MAIN commitmail json YAML

lint: split initstack_pop_item into separate functions

No functional change.

(rillig)

2021-03-19 00:08:13 UTC MAIN commitmail json YAML

lint: improve debug logging in initstack_push

No functional change outside debug mode.

(rillig)

2021-03-18 23:45:20 UTC MAIN commitmail json YAML

lint: split initstack_push into smaller functions

No functional change.

(rillig)

2021-03-18 23:37:31 UTC MAIN commitmail json YAML

lint: clean up control flow in initstack_push

No functional change.

(rillig)

2021-03-18 23:23:40 UTC MAIN commitmail json YAML

lint: extract extend_if_array_of_unknown_size from initstack_push

No functional change.

(rillig)

2021-03-18 23:18:36 UTC MAIN commitmail json YAML

Add PTRACE_ILLEGAL_ASM using the MIPS32r6/MIPS64r6 backwards and
forwards compatible "sigrie" instruction to generate a Reserved
Instruction trap.

(simonb)

2021-03-18 22:51:32 UTC MAIN commitmail json YAML

lint: replace undefined behavior during initialization with assertion

This only affects code that is already rejected by the compiler.

(rillig)

2021-03-18 22:08:05 UTC MAIN commitmail json YAML

lint: improve debug logging during initialization

No functional change outside debug mode.

(rillig)

2021-03-18 22:05:33 UTC MAIN commitmail json YAML

lint: make the debug log for nodes more readable

The operator NAME has the name 'name', therefore no special case is
needed.

Having the words 'with type' in the message makes the message easier to
find from the debug log.  Given that the operator name is used unquoted,
the log message 'name: int value=111' was nearly impossible to find in
the code.

Replace the '()' with an actual word, to avoid any confusion about
whether the type name might be a function type without prototype.

Reduce the amount of '=' signs, instead use commas to separate the
properties of the node.

No functional change outside debug mode.

(rillig)

2021-03-18 21:56:35 UTC MAIN commitmail json YAML

lint: rename operator 'const' to 'constant'

The previous name could be too easily confused with the type qualifier
'const'.  The operator name is mainly used in the debug log, only
occasionally in the output.  Since 'constant' is not a "real" operator,
it probably doesn't occur in messages at all.

(rillig)

2021-03-18 21:26:56 UTC MAIN commitmail json YAML

lint: reword message about type mismatch in initialization

Using parentheses for quotes is unusual, furthermore the previous
message didn't follow proper grammar rules, sacrificing clarity for
brevity.

(rillig)

2021-03-18 21:20:21 UTC MAIN commitmail json YAML

tests/lint: add test for type mismatch in initialization

Copied and adapted from d_c99_init.c.

(rillig)

2021-03-18 20:58:02 UTC MAIN commitmail json YAML

tests/lint: warning 210 has type information by now

(rillig)

2021-03-18 20:55:58 UTC MAIN commitmail json YAML

lint: reduce debug logging for initialization, update documentation

No functional change outside debug mode.

(rillig)

2021-03-18 20:22:50 UTC MAIN commitmail json YAML

lint: document how initialization works, improve debug logging

No functional change outside debug mode.

(rillig)

2021-03-18 20:20:55 UTC MAIN commitmail json YAML

2021-03-18 20:02:19 UTC MAIN commitmail json YAML

2021-03-18 19:47:41 UTC MAIN commitmail json YAML

join.c: print usage after warning "illegal option..." as it was originally intended

(cheusov)

2021-03-18 19:41:54 UTC MAIN commitmail json YAML

join.c: explicitly convert -1 to u_long in order to fix compiler warnings

(cheusov)

2021-03-18 19:34:05 UTC MAIN commitmail json YAML

ipcs.c: do not #include sys/inttypes.h header which is not necessary

(cheusov)

2021-03-18 18:24:14 UTC MAIN commitmail json YAML

find: use POSIX strtoll(3) instead of legacy strtoq(3)

(cheusov)

2021-03-18 18:21:18 UTC MAIN commitmail json YAML

find: use POSIX type uint32_t instead of u_int32_t

(cheusov)

2021-03-18 18:12:35 UTC MAIN commitmail json YAML

2021-03-18 14:58:44 UTC MAIN commitmail json YAML

lint: document the initialization of an object in more detail

This will help fixing the bugs that are currently demonstrated in
msg_168.c and d_struct_init_nested.c.

(rillig)

2021-03-18 14:05:38 UTC MAIN commitmail json YAML

restore flags-as-bitmask, just in case another function is passing its
flags here.

(nia)

2021-03-18 14:01:18 UTC MAIN commitmail json YAML

ts2timo(9): refactor TIMER_ABSTIME handling

- only use *start for output of the original time.
  for clarity purposes, use the temporary variable for everything else.
- add a check for integer underflow

Reported-by: syzbot+17b5072d5ed262a966d3@syzkaller.appspotmail.com

(nia)

2021-03-18 13:45:15 UTC MAIN commitmail json YAML

revert previous

(nia)

2021-03-18 12:37:51 UTC MAIN commitmail json YAML

ts2timo(9): further deobfuscation.

we want to check against NULL, so use it, rather than some random value on
the stack

(nia)

2021-03-18 11:53:16 UTC MAIN commitmail json YAML

ts2timo(9): refactor for clarity

- 'flags' is not a boolean...
- actually, it is, but it should simply be named "absolute".
- convert tests for if (flags) to if (flags != TIMER_RELTIME)
- hoist function calls out of if expressions (requested by uwe)

still needs fixing:

- need to check for overflow before timespecsub.

(nia)

2021-03-18 01:50:12 UTC MAIN commitmail json YAML

LIR_HV priority should be lower than softint.

(nonaka)

2021-03-18 01:49:09 UTC MAIN commitmail json YAML

simplify expression, daemon is an array can't be NULL.

(christos)

2021-03-17 15:45:31 UTC MAIN commitmail json YAML

lint: add debug logging for C99-style initialization of arrays

No functional change outside debug mode.

(rillig)

2021-03-17 15:37:42 UTC MAIN commitmail json YAML

lint: move debug logging for the designator to the top of the code

The debugging code is needed by the soon-to-be-added proper handling of
array subscript initializers such as '.member[123].member = 12345'.

No functional change.

(rillig)

2021-03-17 15:26:20 UTC MAIN commitmail json YAML

Improve URL consistency

Replace netbsd.org in URL with NetBSD.org and add www. to URL of web server.

(ryoon)

2021-03-17 15:02:27 UTC MAIN commitmail json YAML

Fixes "FatalError re-entered, aborting" error when Xservers get SIGSEGV.

Handle a new DEVICE_ABORT mode perperly in deviceProc funtions.
Also don't exit via FatalError() on an unknown mode because it looks
upstream assumes DDX deviceProc functions don't treat it fatal:
https://gitlab.freedesktop.org/xorg/xserver/-/commit/9f79e93b6b3416055d08a0e8f9f16d5fd0649e36

(tsutsui)

2021-03-17 14:58:16 UTC MAIN commitmail json YAML

Make this distinguishable with native PCI interrupt.

(rin)

2021-03-17 14:50:11 UTC MAIN commitmail json YAML

2021-03-17 14:10:29 UTC MAIN commitmail json YAML

pci(4): many more drivers

(nia)

2021-03-17 13:42:03 UTC MAIN commitmail json YAML

add ale(4) and bge(4) to pci.4

(nia)

2021-03-17 13:12:33 UTC MAIN commitmail json YAML

2021-03-17 11:05:37 UTC MAIN commitmail json YAML

Handle gas/gcc generating a break/trap 6 for integer overflow and
break/trap 7 for integer divide by zero and setting the SIGFPE
si_code of FPE_INTOVF or FPE_INTDIV respectively.  The break/trap
6/7 seems to have existed since the early days of MIPS but not
well documented anywhere.

Fixes ATF lib/libc/gen/t_siginfo::sigfpe_int .

(simonb)

2021-03-17 08:13:29 UTC MAIN commitmail json YAML

Remove superfluous article.

(wiz)

2021-03-17 08:04:39 UTC MAIN commitmail json YAML

Clarify use of open flags in open(2).

(Avoid using values of three that are equal to four.)

(dholland)

2021-03-17 02:24:06 UTC MAIN commitmail json YAML

lint: clean up documentation of dinfo_t

No functional change.

(rillig)

2021-03-17 02:18:03 UTC MAIN commitmail json YAML

lint: rename dinfo_t members to be more expressive

While here, sync redundant but diverging comments, split
multi-assignments and initialize the members in declaration order.

No functional change.

(rillig)

2021-03-17 01:53:21 UTC MAIN commitmail json YAML

lint: move to_int_constant from the grammar to decl.c

This way, the code is covered by running 'make lint'.  The code from the
grammar is not covered, therefore it still uses int instead of bool in a
few places.

Inline the comparison functions for uint64_t.  These functions didn't
add any clarity to the code.

No functional change.

(rillig)

2021-03-17 01:38:31 UTC MAIN commitmail json YAML

lint: move main part of idecl over to decl.c and rename it

No functional change.

(rillig)

2021-03-17 01:22:55 UTC MAIN commitmail json YAML

lint: replace a call to LERROR with lint_assert

No functional change.

(rillig)

2021-03-17 01:19:50 UTC MAIN commitmail json YAML

lint: rename 'toicon' to 'to_int_constant'

No functional change.

(rillig)

2021-03-17 01:15:31 UTC MAIN commitmail json YAML

2021-03-17 01:07:33 UTC MAIN commitmail json YAML

lint: rename 'parn' to 'paren' in the grammar

No functional change.

(rillig)

2021-03-16 23:39:41 UTC MAIN commitmail json YAML

2021-03-16 23:18:49 UTC MAIN commitmail json YAML

tests/lint: add test for message 139 about division by zero

(rillig)

2021-03-16 23:12:30 UTC MAIN commitmail json YAML

tests/lint: add test for message 128 about incompatible pointers

(rillig)

2021-03-16 20:11:30 UTC MAIN commitmail json YAML

sun4v: update TODO - update status after hacking on ldom virtual network interfaces

(palle)

2021-03-16 16:21:27 UTC MAIN commitmail json YAML

make: fix documentation for ModChain

The outer ModChain can be interrupted by an inner ModChain, but it
continues to exist.

No functional change.

(rillig)

2021-03-16 08:16:53 UTC MAIN commitmail json YAML

2021-03-16 07:34:44 UTC MAIN commitmail json YAML

Disassemble TEQ correctly.

XXX: May be others that use this format?

(simonb)

2021-03-16 07:00:38 UTC MAIN commitmail json YAML

Fix l2tp(4) ioctl type. Pointed out by yamaguchi@n.o, thanks.

XXX pullup-[89]

(knakahara)

2021-03-15 20:18:21 UTC MAIN commitmail json YAML

2021-03-15 20:17:04 UTC MAIN commitmail json YAML

2021-03-15 20:15:36 UTC MAIN commitmail json YAML

2021-03-15 20:00:51 UTC MAIN commitmail json YAML

make: rename ApplyModifiersState to ModChain

The new name accurately describes the structural element that holds such
properties as the separator character and whether the expression value
is considered a single word.  The old name ApplyModifiersState was too
long and was meant as a placeholder anyway, when I introduced it in
var.c 1.236 from 2020-07-03.

(rillig)

2021-03-15 19:48:52 UTC MAIN commitmail json YAML

2021-03-15 19:15:05 UTC MAIN commitmail json YAML

make: improve documentation of ApplyModifiersState

No functional change.

(rillig)

2021-03-15 19:02:57 UTC MAIN commitmail json YAML

make: document an example for a 'chain of modifiers'

No functional change.

(rillig)

2021-03-15 18:56:38 UTC MAIN commitmail json YAML

make: fix double varname expansion in the variable modifier '::='

This is an edge case that doesn't occur in practice since pretty much
nobody dares to use variable names that contain an actual '$' in their
name.  This is not about the fairly common VAR.${param} (as written in
the makefile), but instead about the variable whose name is literally
'VAR.${param}'.

The test demonstrates that after the fix, the variable name is taken
exactly as-is for the simple assignment modifier '::='.  There are no
such tests for the modifiers '::+=', '::!=' and '::?=', but that's ok.
The code in ApplyModifier_Assign would look assymetrical and suspicious
enough if one of these modifiers would expand its variable name and the
others wouldn't.

(rillig)

2021-03-15 18:46:05 UTC MAIN commitmail json YAML

tests/make: demonstrate that the modifier '::=' expands the varname

(rillig)

2021-03-15 18:44:05 UTC MAIN commitmail json YAML

sun4v: vnet - cleanup of debug code (no functional changes)

(palle)

2021-03-15 18:21:51 UTC MAIN commitmail json YAML

Use inline cross-references.

(nia)

2021-03-15 18:13:54 UTC MAIN commitmail json YAML

- 32 bit mips uses oabi, don't force it to n32.
- compile assembly code with soft-float to kill linker warnings

(christos)

2021-03-15 17:54:50 UTC MAIN commitmail json YAML

tests/make: convert varmod-loop to parse-time

In case of unexpected failures, this provides the line number of the
'.error' directive.

(rillig)

2021-03-15 17:11:08 UTC MAIN commitmail json YAML

2021-03-15 16:51:14 UTC MAIN commitmail json YAML

make: clean up documentation of ApplyModifiersState

No functional change.

(rillig)