Link [ NetBSD | NetBSD OpenGrok source search | PR fulltext-search | Summary of daily snapshot builds | history of daily build result | pkgsrc commit viewer ]


   
        usage: [branch:branch] [user:user] [path@revision] keyword [... [-excludekeyword [...]]] (e.g. branch:MAIN sys/arch/arm, if_wm.c@1.234 )




switch to index mode

recent branches: MAIN (3h)  netbsd-8 (5d)  netbsd-10 (6d)  netbsd-9 (12d)  thorpej-ifq (176d)  thorpej-altq-separation (178d) 

2024-05-10 18:11:38 UTC Now

2021-02-20 09:40:43 UTC MAIN commitmail json YAML

lint: reproduce the crash from ckgetopt.c 1.2

The intention of the getopt check was to analyze only those while loops
whose condition consists of the usual getopt call.  For all other while
loops, ck.while_level was intended to stay at 0.

This was not the case in ckgetopt.c 1.2 and has been fixed in ckgetopt.c
1.3.  The code did not document the intended invariants though, which it
should have done.  This will be done in a follow-up commit.

(rillig)

2021-02-20 09:36:31 UTC MAIN commitmail json YAML

2021-02-20 09:31:51 UTC MAIN commitmail json YAML

2021-02-20 09:17:13 UTC MAIN commitmail json YAML

patch(1): use PATH_MAX for the size of rejname

via freebsd, openbsd

(nia)

2021-02-20 08:59:24 UTC MAIN commitmail json YAML

patch(1): add test cases for various backup file formats

(nia)

2021-02-20 03:25:36 UTC MAIN commitmail json YAML

2021-02-20 03:22:14 UTC MAIN commitmail json YAML

2021-02-20 02:47:21 UTC MAIN commitmail json YAML

Revert the MIPS __eprol change.  Unintended fallout that doesn't appear
easy to fix so far.

(simonb)

2021-02-20 01:57:54 UTC MAIN commitmail json YAML

Query real-mode? at startup and cache the result.

(thorpej)

2021-02-20 01:43:04 UTC MAIN commitmail json YAML

libisc needs libssl now

(christos)

2021-02-20 01:18:03 UTC MAIN commitmail json YAML

Prevent crashing when options are NULL in libc while linting
    src/lib/libc/posix1e/acl_from_text.c

(christos)

2021-02-19 23:25:26 UTC MAIN commitmail json YAML

lint: remove gcov results on "make clean"

(rillig)

2021-02-19 23:22:19 UTC MAIN commitmail json YAML

lint: shorten code in check-msgs.lua

No functional change.

(rillig)

2021-02-19 22:35:42 UTC MAIN commitmail json YAML

lint: rename storage class constants to be more expressive

No functional change.

(rillig)

2021-02-19 22:27:49 UTC MAIN commitmail json YAML

2021-02-19 22:20:18 UTC MAIN commitmail json YAML

2021-02-19 22:16:12 UTC MAIN commitmail json YAML

2021-02-19 21:35:44 UTC MAIN commitmail json YAML

lint: replace cryptic sym.s_rimpl with expressive name

No functional change.

(rillig)

2021-02-19 18:36:50 UTC MAIN commitmail json YAML

PR kern/55272: do not skip this test on single cpu machines - it is not
the only test causing the watchdog starvation and we better find and
fix the real issue.

(martin)

2021-02-19 18:10:51 UTC MAIN commitmail json YAML

Update some #ifdef PMAC_G5 for previous change that I missed before.

(thorpej)

2021-02-19 18:05:42 UTC MAIN commitmail json YAML

Fix the previously differently.

(thorpej)

2021-02-19 18:03:21 UTC MAIN commitmail json YAML

ofwreal_incharge does not need to be global.

(thorpej)

2021-02-19 18:02:45 UTC MAIN commitmail json YAML

Put back accidental removal of "ofwreal_incharge".

(thorpej)

2021-02-19 17:58:43 UTC MAIN commitmail json YAML

Avoid an unused variable warning for the not-building-macppc case.

(thorpej)

2021-02-19 17:50:39 UTC netbsd-8 commitmail json YAML

2021-02-19 17:49:19 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by knakahara in ticket #1657):

sys/arch/x86/x86/intr.c: revision 1.154 (via patch)

Fix x86's pci_intr_disestablish clean up routine.  Pointed out by t-kusaba@IIJ, thanks.

Fix panic on x86 by the following code.

====================
    sc_ih = pci_intr_establish_xname(sc_pc, ...);
    pci_intr_disestablish(sc_pc, sc_ih);
    sc_ih = pci_intr_establish(sc_pc, ...);
====================

ena(4) do such processing when ifconfig down/up.

XXX pullup-8,9

(martin)

2021-02-19 17:48:17 UTC netbsd-9 commitmail json YAML

2021-02-19 17:47:13 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by knakahara in ticket #1209):

sys/arch/x86/x86/intr.c: revision 1.154 (via patch)

Fix x86's pci_intr_disestablish clean up routine.  Pointed out by t-kusaba@IIJ, thanks.

Fix panic on x86 by the following code.

====================
    sc_ih = pci_intr_establish_xname(sc_pc, ...);
    pci_intr_disestablish(sc_pc, sc_ih);
    sc_ih = pci_intr_establish(sc_pc, ...);
====================

ena(4) do such processing when ifconfig down/up.

XXX pullup-8,9

(martin)

2021-02-19 17:46:53 UTC MAIN commitmail json YAML

patch: make '-V none' work in the expected way

Internally the code confuses the concept of "the user doesn't want
a backup file" and "the user hasn't defined a type of backup file".

Introduce a new "undefined" backup type to serve the purpose "none"
previously did, and make "none" not generate backup files, as expected.

http://mail-index.netbsd.org/tech-userlevel/2021/02/19/msg012901.html

XXX pullup?

(nia)

2021-02-19 17:41:19 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by mlelstv in ticket #1208):

external/gpl2/grep/dist/lib/regex.c: revision 1.3

Moving pointers could fail if realloc() allocates a new memory region
where the difference between old and new address exceeds an int. Use
ptrdiff_t for calculations instead.

(martin)

2021-02-19 17:09:35 UTC MAIN commitmail json YAML

update the date for bind

(christos)

2021-02-19 17:08:22 UTC MAIN commitmail json YAML

2021-02-19 17:06:26 UTC MAIN commitmail json YAML

2021-02-19 16:42:24 UTC MAIN commitmail json YAML

2021-02-19 15:43:56 UTC MAIN commitmail json YAML

it's spelled struct tcphdr, not struct tcp_hdr

(jakllsch)

2021-02-19 14:52:00 UTC MAIN commitmail json YAML

- Make ALIGNED_POINTER use __alignof(t) instead of sizeof(t). This is more
  correct because it works with non-primitive types and provides the ABI
  alignment for the type the compiler will use.
- Remove all the *_HDR_ALIGNMENT macros and asserts
- Replace POINTER_ALIGNED_P with ACCESSIBLE_POINTER which is identical to
  ALIGNED_POINTER, but returns that the pointer is always aligned if the
  CPU supports unaligned accesses.
[ as proposed in tech-kern ]

(christos)

2021-02-19 14:44:29 UTC MAIN commitmail json YAML

lint: fix build in tools mode

(rillig)

2021-02-19 13:20:44 UTC MAIN commitmail json YAML

When turning off swap during reboot we have to lock with LK_RETRY
as regular files got reclaimed during unmount.

Adresses PR kern/54969 (Disk cache is no longer flushed on shutdown)

(hannken)

2021-02-19 12:28:57 UTC MAIN commitmail json YAML

2021-02-19 11:39:11 UTC MAIN commitmail json YAML

videoctl: remove unnecessary code for unknown option -h

The generated binary stays the same.

(rillig)

2021-02-19 08:57:56 UTC MAIN commitmail json YAML

Add missing 'q' modifier for the write command.

(msaitoh)

2021-02-19 08:33:02 UTC MAIN commitmail json YAML

Remove the incorrect register shuffle - we pass SYS___syscall as the
syscall number in v0 and pass all the original __syscall() args in their
original slots/regs.

(simonb)

2021-02-19 05:34:37 UTC MAIN commitmail json YAML

Fix x86's pci_intr_disestablish clean up routine.  Pointed out by t-kusaba@IIJ, thanks.

Fix panic on x86 by the following code.
====================
    sc_ih = pci_intr_establish_xname(sc_pc, ...);
    pci_intr_disestablish(sc_pc, sc_ih);
    sc_ih = pci_intr_establish(sc_pc, ...);
====================
ena(4) do such processing when ifconfig down/up.

XXX pullup-8,9

(knakahara)

2021-02-19 05:23:53 UTC MAIN commitmail json YAML

2021-02-19 05:21:39 UTC MAIN commitmail json YAML

Shuffle around a couple of things that aren't particularly OEA-specific:

- Early bootstrap console initialization moves to ofw_machdep.c, and
  is called a bit earlier, from ofw_bootstrap().

- Decoding the "translations" property from /chosen/mmu is specified
  in the general OpenFirmware PowerPC bindings, and is not specific to
  any particular PowerPC flavor.  It's now decoded a bit earlier in
  ofw_bootstrap().

The *interpretation* of the mode field of a translation is, however,
implementation-specific, so that remains in ofwoea_machdep.c.

(thorpej)

2021-02-19 03:42:02 UTC MAIN commitmail json YAML

Provide an __eprol symbol in TEXT_START_SYMBOLS.  MIPS overrides
TEXT_START_SYMBOLS so it misses out on the default definition of
this that does provide an __eprol symbol.  Fixes linking of profiled
binaries.

OK: christos@

(simonb)

2021-02-19 03:28:53 UTC MAIN commitmail json YAML

It is not VirtualBo give some more space.

(christos)

2021-02-19 02:18:10 UTC MAIN commitmail json YAML

2021-02-19 02:15:58 UTC MAIN commitmail json YAML

Penalize TSC on VirtualBox because it is not accurate enough.

(christos)

2021-02-19 02:15:24 UTC MAIN commitmail json YAML

2021-02-18 20:37:02 UTC MAIN commitmail json YAML

Revert previous... somehow the register names aren't available apparently

(skrll)

2021-02-18 18:31:22 UTC MAIN commitmail json YAML

Add an ofw_bootstrap() function, called during early bootstrap from
ofwinit() to perform additional early initialization in C code.  Use
this to get the memory config while we're still running in the OpenFirmware
client environment, rather than waiting until we've started fiddling with
the system state.

(thorpej)

2021-02-18 18:27:24 UTC MAIN commitmail json YAML

Add examples (Fernando Apestegu�a at FreeBSD)

(christos)

2021-02-18 18:06:02 UTC MAIN commitmail json YAML

Remove the "original line"
Fix lint comment

(christos)

2021-02-18 18:02:09 UTC MAIN commitmail json YAML

New sentence, new line.

(wiz)

2021-02-18 17:58:51 UTC MAIN commitmail json YAML

Add support for password protected zip files (Alex Kozlov)
Also some KNF

(christos)

2021-02-18 17:56:04 UTC MAIN commitmail json YAML

- use if_initialize() and if_register() instead of if_attach()
- add IFEF_MPSAFE to if_extflags

pointed out by msaitoh@, thanks

(ryo)

2021-02-18 17:05:52 UTC MAIN commitmail json YAML

Build with linux/glibc (Alex Kozlov)

(christos)

2021-02-18 17:04:39 UTC MAIN commitmail json YAML

mention zipx, from Alex Kozlov

(christos)

2021-02-18 16:29:12 UTC MAIN commitmail json YAML

- Tidy up some comments.
- Use correct stack frame linkage everywhere so that if something goes
  wrong, we can get a meaningful back trace.
- Use an additional layer of indirection so that, when we're very
  early in bootstrap, we can just call OpenFirmware directly, rather
  than using our trampoline that saves/restores kernel state.
- Carve out a space for ofwinit() to call into C code to do additional
  initialization.  (This is not done yet.)

(thorpej)

2021-02-18 15:13:38 UTC MAIN commitmail json YAML

PR bin/55973:

fix routing message triggered one shot interface update.

(kardel)

2021-02-18 12:54:03 UTC MAIN commitmail json YAML

In the compat setitimer(2) calls, don't validate which timer is being
used since dosetitimer() does this anyway.  The compat functions hadn't
been updated since ITIMER_MONOTONIC was introduced, so they reported
that that ITIMER_MONOTONIC timer was invalid.

(simonb)

2021-02-18 12:28:02 UTC MAIN commitmail json YAML

Add an abicalls version of asm mcount prologue.  XXX not tested because
profiled programs fail to link, but fixes build.  Thanks dholland@ for
help analysing this.

While here, rename _KERN_MCOUNT to _MIPS_ASM_MCOUNT - it's not kernel
specific.

(simonb)

2021-02-18 11:23:15 UTC MAIN commitmail json YAML

revert previous; user reports of panics under load

(jmcneill)

2021-02-17 23:51:04 UTC MAIN commitmail json YAML

Document that rewinddir(3) might either reopen or just lseek the dir.

(Currently it depends on the underlying directory, but documenting the
exact details seems inadvisable.)

Also, Someone(TM) should check if POSIX permits this or if we ought to
improve the implementation.

(dholland)

2021-02-17 23:39:46 UTC MAIN commitmail json YAML

Fix some typos/malapropisms in directory(3).

(dholland)

2021-02-17 23:21:47 UTC MAIN commitmail json YAML

Document the register state on entry per the OpenFirmware PowerPC CPU
bindings.  Ensure we save off %r6 and %r7 before calling any other
functions.

(thorpej)

2021-02-17 22:55:20 UTC MAIN commitmail json YAML

Merge EINVAL descriptions; replace Xr to itself with Nm.

(wiz)

2021-02-17 22:32:04 UTC MAIN commitmail json YAML

- pass the alignment instead of the mask (as Roy asked and to match the
  other macro)
- use alignof to determine that alignment and CTASSERT what we expect
- remove unused macros

(christos)

2021-02-17 21:09:39 UTC MAIN commitmail json YAML

2021-02-17 17:43:09 UTC MAIN commitmail json YAML

Document more EINVAL cases for fsync_range.

Corresponds to previous code fix.

(dholland)

2021-02-17 17:39:08 UTC MAIN commitmail json YAML

Don't allow callers of fsync_range() to trigger UB in the kernel.

(also prohibit syncing ranges at start offsets less than zero)

(dholland)

2021-02-17 12:37:33 UTC MAIN commitmail json YAML

Attach this only if the parent device has playback capability.

(isaki)

2021-02-17 09:56:53 UTC netbsd-8 commitmail json YAML

2021-02-17 09:55:20 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by mrg in ticket #1656):

external/mit/xorg/bin/xterm/Makefile: revision 1.20 (patch)

add new files for xterm 366.

(martin)

2021-02-17 09:52:36 UTC netbsd-9 commitmail json YAML

2021-02-17 09:50:20 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by mrg in ticket #1207):

external/mit/xorg/bin/xterm/Makefile: revision 1.20

add new files for xterm 366.

(martin)

2021-02-17 09:48:40 UTC netbsd-8 commitmail json YAML

xsrc/external/mit/xterm/dist/COPYING@1.1.1.1.4.2 / diff / nxr@1.1.1.1.4.2
xsrc/external/mit/xterm/dist/INSTALL@1.1.1.10.2.1 / diff / nxr@1.1.1.10.2.1
xsrc/external/mit/xterm/dist/Imakefile@1.1.1.9.2.1 / diff / nxr@1.1.1.9.2.1
xsrc/external/mit/xterm/dist/MANIFEST@1.1.1.14.2.1 / diff / nxr@1.1.1.14.2.1
xsrc/external/mit/xterm/dist/Makefile.in@1.1.1.11.2.1 / diff / nxr@1.1.1.11.2.1
xsrc/external/mit/xterm/dist/NEWS@1.1.1.1.2.1 / diff / nxr@1.1.1.1.2.1
xsrc/external/mit/xterm/dist/THANKS@1.1.1.7.2.1 / diff / nxr@1.1.1.7.2.1
xsrc/external/mit/xterm/dist/TekPrsTbl.c@1.1.1.1.24.1 / diff / nxr@1.1.1.1.24.1
xsrc/external/mit/xterm/dist/Tekproc.c@1.1.1.12.2.1 / diff / nxr@1.1.1.12.2.1
xsrc/external/mit/xterm/dist/UXTerm.ad@1.1.1.2.16.1 / diff / nxr@1.1.1.2.16.1
xsrc/external/mit/xterm/dist/VTPrsTbl.c@1.1.1.8.2.1 / diff / nxr@1.1.1.8.2.1
xsrc/external/mit/xterm/dist/VTparse.def@1.1.1.7.8.1 / diff / nxr@1.1.1.7.8.1
xsrc/external/mit/xterm/dist/VTparse.h@1.1.1.9.2.1 / diff / nxr@1.1.1.9.2.1
xsrc/external/mit/xterm/dist/XTerm.ad@1.9.2.1 / diff / nxr@1.9.2.1
xsrc/external/mit/xterm/dist/aclocal.m4@1.1.1.12.2.1 / diff / nxr@1.1.1.12.2.1
xsrc/external/mit/xterm/dist/button.c@1.1.1.14.2.1 / diff / nxr@1.1.1.14.2.1
xsrc/external/mit/xterm/dist/cachedGCs.c@1.1.1.9.2.1 / diff / nxr@1.1.1.9.2.1
xsrc/external/mit/xterm/dist/charclass.c@1.1.1.4.8.1 / diff / nxr@1.1.1.4.8.1
xsrc/external/mit/xterm/dist/charclass.h@1.1.1.1.24.1 / diff / nxr@1.1.1.1.24.1
xsrc/external/mit/xterm/dist/charproc.c@1.1.1.13.2.1 / diff / nxr@1.1.1.13.2.1
      :
(more 119 files)
Pull up the following

xsrc/external/mit/xterm/dist/package/debian/xterm-dev.lintian-overrides up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/freebsd/distinfo up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/freebsd/pkg-message.wchar up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/pkgsrc/Makefile up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/pkgsrc/DESCR    up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/pkgsrc/distinfo up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/pkgsrc/PLIST    up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/pkgsrc/options.mk up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/closest-rgb.pl  up to 1.1.1.2
xsrc/external/mit/xterm/dist/vttests/query-status.pl up to 1.1.1.2
xsrc/external/mit/xterm/dist/vttests/modify-keys.pl  up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/mouse-codes    up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/other-sgr.sh    up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/print-vt-chars.pl up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/query-dynamic.pl up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/query-xres.pl  up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/report-sgr.pl  up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/sgrPushPop.pl  up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/sgrPushPop2.pl  up to 1.1.1.1
xsrc/external/mit/xterm/dist/COPYING                up to 1.1.1.1
xsrc/external/mit/xterm/dist/gen-charsets.pl        up to 1.1.1.1
xsrc/external/mit/xterm/include/Tekparse.hin        delete
xsrc/external/mit/xterm/include/VTparse.hin          delete
xsrc/external/mit/xterm/dist/INSTALL                up to 1.1.1.12
xsrc/external/mit/xterm/dist/Imakefile              up to 1.1.1.10
xsrc/external/mit/xterm/dist/MANIFEST                up to 1.1.1.16
xsrc/external/mit/xterm/dist/Makefile.in            up to 1.1.1.13
xsrc/external/mit/xterm/dist/NEWS                    up to 1.1.1.3
xsrc/external/mit/xterm/dist/THANKS                  up to 1.1.1.9
xsrc/external/mit/xterm/dist/TekPrsTbl.c            up to 1.1.1.2
xsrc/external/mit/xterm/dist/Tekproc.c              up to 1.1.1.14
xsrc/external/mit/xterm/dist/UXTerm.ad              up to 1.1.1.3
xsrc/external/mit/xterm/dist/VTPrsTbl.c              up to 1.1.1.9
xsrc/external/mit/xterm/dist/VTparse.def            up to 1.1.1.8
xsrc/external/mit/xterm/dist/VTparse.h              up to 1.1.1.10
xsrc/external/mit/xterm/dist/XTerm.ad                up to 1.11
xsrc/external/mit/xterm/dist/aclocal.m4              up to 1.1.1.14
xsrc/external/mit/xterm/dist/button.c                up to 1.1.1.16
xsrc/external/mit/xterm/dist/cachedGCs.c            up to 1.1.1.11
xsrc/external/mit/xterm/dist/charclass.c            up to 1.1.1.6
xsrc/external/mit/xterm/dist/charclass.h            up to 1.1.1.3
xsrc/external/mit/xterm/dist/charproc.c              up to 1.1.1.15
xsrc/external/mit/xterm/dist/charsets.c              up to 1.1.1.6
xsrc/external/mit/xterm/dist/config.guess            up to 1.1.1.12
xsrc/external/mit/xterm/dist/config.sub              up to 1.1.1.12
xsrc/external/mit/xterm/dist/configure              up to 1.1.1.14
xsrc/external/mit/xterm/dist/configure.in            up to 1.1.1.13
xsrc/external/mit/xterm/dist/ctlseqs.ms              up to 1.1.1.15
xsrc/external/mit/xterm/dist/ctlseqs.txt            up to 1.1.1.15
xsrc/external/mit/xterm/dist/cursor.c                up to 1.1.1.9
xsrc/external/mit/xterm/dist/data.c                  up to 1.1.1.7
xsrc/external/mit/xterm/dist/data.h                  up to 1.1.1.10
xsrc/external/mit/xterm/dist/df-install.in          up to 1.1.1.3
xsrc/external/mit/xterm/dist/doublechr.c            up to 1.1.1.9
xsrc/external/mit/xterm/dist/error.h                up to 1.1.1.6
xsrc/external/mit/xterm/dist/fontutils.c            up to 1.8
xsrc/external/mit/xterm/dist/fontutils.h            up to 1.1.1.10
xsrc/external/mit/xterm/dist/graphics.c              up to 1.1.1.6
xsrc/external/mit/xterm/dist/graphics_regis.c        up to 1.1.1.5
xsrc/external/mit/xterm/dist/graphics_sixel.c        up to 1.1.1.4
xsrc/external/mit/xterm/dist/html.c                  up to 1.1.1.3
xsrc/external/mit/xterm/dist/input.c                up to 1.1.1.13
xsrc/external/mit/xterm/dist/keysym2ucs.c            up to 1.1.1.3
xsrc/external/mit/xterm/dist/koi8rxterm              up to 1.1.1.3
xsrc/external/mit/xterm/dist/koi8rxterm.man          up to 1.1.1.3
xsrc/external/mit/xterm/dist/linedata.c              up to 1.6
xsrc/external/mit/xterm/dist/main.c                  up to 1.1.1.13
xsrc/external/mit/xterm/dist/main.h                  up to 1.1.1.6
xsrc/external/mit/xterm/dist/menu.c                  up to 1.1.1.13
xsrc/external/mit/xterm/dist/menu.h                  up to 1.1.1.12
xsrc/external/mit/xterm/dist/minstall.in            up to 1.1.1.5
xsrc/external/mit/xterm/dist/misc.c                  up to 1.17
xsrc/external/mit/xterm/dist/plink.sh                up to 1.1.1.5
xsrc/external/mit/xterm/dist/print.c                up to 1.1.1.11
xsrc/external/mit/xterm/dist/ptydata.c              up to 1.1.1.9
xsrc/external/mit/xterm/dist/ptyx.h                  up to 1.15
xsrc/external/mit/xterm/dist/resize.c                up to 1.1.1.9
xsrc/external/mit/xterm/dist/resize.man              up to 1.1.1.5
xsrc/external/mit/xterm/dist/run-tic.sh              up to 1.1.1.3
xsrc/external/mit/xterm/dist/screen.c                up to 1.1.1.12
xsrc/external/mit/xterm/dist/scrollback.c            up to 1.6
xsrc/external/mit/xterm/dist/scrollbar.c            up to 1.1.1.11
xsrc/external/mit/xterm/dist/svg.c                  up to 1.1.1.2
xsrc/external/mit/xterm/dist/tabs.c                  up to 1.1.1.6
xsrc/external/mit/xterm/dist/termcap                up to 1.1.1.6
xsrc/external/mit/xterm/dist/terminfo                up to 1.1.1.7
xsrc/external/mit/xterm/dist/testxmc.c              up to 1.1.1.7
xsrc/external/mit/xterm/dist/trace.c                up to 1.1.1.13
xsrc/external/mit/xterm/dist/trace.h                up to 1.1.1.13
xsrc/external/mit/xterm/dist/util.c                  up to 1.1.1.13
xsrc/external/mit/xterm/dist/uxterm                  up to 1.1.1.3
xsrc/external/mit/xterm/dist/uxterm.desktop          up to 1.1.1.5
xsrc/external/mit/xterm/dist/uxterm.man              up to 1.1.1.3
xsrc/external/mit/xterm/dist/version.c              up to 1.1.1.5
xsrc/external/mit/xterm/dist/version.h              up to 1.1.1.16
xsrc/external/mit/xterm/dist/vms.c                  up to 1.1.1.4
xsrc/external/mit/xterm/dist/wcwidth.c              up to 1.1.1.6
xsrc/external/mit/xterm/dist/wcwidth.h              up to 1.1.1.2
xsrc/external/mit/xterm/dist/xcharmouse.h            up to 1.1.1.5
xsrc/external/mit/xterm/dist/xstrings.c              up to 1.1.1.10
xsrc/external/mit/xterm/dist/xstrings.h              up to 1.1.1.6
xsrc/external/mit/xterm/dist/xterm.appdata.xml      up to 1.1.1.3
xsrc/external/mit/xterm/dist/xterm.dat              up to 1.1.1.3
xsrc/external/mit/xterm/dist/xterm.h                up to 1.3
xsrc/external/mit/xterm/dist/xterm.log.html          up to 1.1.1.16
xsrc/external/mit/xterm/dist/xterm.man              up to 1.17
xsrc/external/mit/xterm/dist/xterm_io.h              up to 1.1.1.7
xsrc/external/mit/xterm/dist/xtermcap.c              up to 1.1.1.9
xsrc/external/mit/xterm/dist/xtermcfg.hin            up to 1.1.1.13
xsrc/external/mit/xterm/dist/xutf8.c                up to 1.1.1.6
xsrc/external/mit/xterm/dist/icons/filled-xterm.svg  up to 1.1.1.2
xsrc/external/mit/xterm/dist/icons/mini.xterm.svg    up to 1.1.1.2
xsrc/external/mit/xterm/dist/icons/terminal_48x48.svg up to 1.1.1.2
xsrc/external/mit/xterm/dist/icons/xterm-color.svg  up to 1.1.1.2
xsrc/external/mit/xterm/dist/icons/xterm.svg        up to 1.1.1.2
xsrc/external/mit/xterm/dist/package/xterm.spec      up to 1.1.1.11
xsrc/external/mit/xterm/dist/package/debian/changelog up to 1.1.1.11
xsrc/external/mit/xterm/dist/package/debian/compat  up to 1.1.1.2
xsrc/external/mit/xterm/dist/package/debian/control  up to 1.1.1.5
xsrc/external/mit/xterm/dist/package/debian/copyright up to 1.1.1.7
xsrc/external/mit/xterm/dist/package/debian/rules    up to 1.1.1.8
xsrc/external/mit/xterm/dist/package/debian/watch    up to 1.1.1.2
xsrc/external/mit/xterm/dist/package/debian/xterm-dev.docs up to 1.1.1.2
xsrc/external/mit/xterm/dist/package/debian/xterm-dev.menu up to 1.1.1.2
xsrc/external/mit/xterm/dist/package/freebsd/Makefile up to 1.1.1.7
xsrc/external/mit/xterm/dist/package/freebsd/pkg-descr up to 1.1.1.2
xsrc/external/mit/xterm/dist/unicode/convmap.pl      up to 1.1.1.3
xsrc/external/mit/xterm/dist/unicode/keysym.map      up to 1.1.1.3
xsrc/external/mit/xterm/dist/vttests/256colors.pl    up to 1.1.1.4
xsrc/external/mit/xterm/dist/vttests/256colors2.pl  up to 1.1.1.6
xsrc/external/mit/xterm/dist/vttests/88colors.pl    up to 1.1.1.4
xsrc/external/mit/xterm/dist/vttests/88colors2.pl    up to 1.1.1.6
xsrc/external/mit/xterm/dist/vttests/dynamic.pl      up to 1.1.1.4
xsrc/external/mit/xterm/dist/vttests/paste64.pl      up to 1.1.1.5
xsrc/external/mit/xterm/dist/vttests/query-color.pl  up to 1.1.1.4
xsrc/external/mit/xterm/dist/vttests/query-fonts.pl  up to 1.1.1.3
xsrc/external/mit/xterm/dist/vttests/resize.pl      up to 1.1.1.5
xsrc/external/mit/xterm/dist/vttests/tcapquery.pl    up to 1.1.1.6
xsrc/external/mit/xterm/include/xtermcfg.h          up to 1.15

Import Xterm 366, changes too numerous to list, main fix is for CVE-2021-27135:
* correct upper-limit for selection buffer, accounting for combining
  characters

(martin)

2021-02-17 09:45:01 UTC netbsd-9 commitmail json YAML

xsrc/external/mit/xterm/dist/COPYING@1.1.1.1.2.2 / diff / nxr@1.1.1.1.2.2
xsrc/external/mit/xterm/dist/INSTALL@1.1.1.11.2.1 / diff / nxr@1.1.1.11.2.1
xsrc/external/mit/xterm/dist/Imakefile@1.1.1.9.4.1 / diff / nxr@1.1.1.9.4.1
xsrc/external/mit/xterm/dist/MANIFEST@1.1.1.15.2.1 / diff / nxr@1.1.1.15.2.1
xsrc/external/mit/xterm/dist/Makefile.in@1.1.1.12.2.1 / diff / nxr@1.1.1.12.2.1
xsrc/external/mit/xterm/dist/NEWS@1.1.1.2.2.1 / diff / nxr@1.1.1.2.2.1
xsrc/external/mit/xterm/dist/THANKS@1.1.1.8.2.1 / diff / nxr@1.1.1.8.2.1
xsrc/external/mit/xterm/dist/TekPrsTbl.c@1.1.1.1.26.1 / diff / nxr@1.1.1.1.26.1
xsrc/external/mit/xterm/dist/Tekproc.c@1.1.1.13.2.1 / diff / nxr@1.1.1.13.2.1
xsrc/external/mit/xterm/dist/UXTerm.ad@1.1.1.2.18.1 / diff / nxr@1.1.1.2.18.1
xsrc/external/mit/xterm/dist/VTPrsTbl.c@1.1.1.8.4.1 / diff / nxr@1.1.1.8.4.1
xsrc/external/mit/xterm/dist/VTparse.def@1.1.1.7.10.1 / diff / nxr@1.1.1.7.10.1
xsrc/external/mit/xterm/dist/VTparse.h@1.1.1.9.4.1 / diff / nxr@1.1.1.9.4.1
xsrc/external/mit/xterm/dist/XTerm.ad@1.10.2.1 / diff / nxr@1.10.2.1
xsrc/external/mit/xterm/dist/aclocal.m4@1.1.1.13.2.1 / diff / nxr@1.1.1.13.2.1
xsrc/external/mit/xterm/dist/button.c@1.1.1.15.2.1 / diff / nxr@1.1.1.15.2.1
xsrc/external/mit/xterm/dist/cachedGCs.c@1.1.1.10.2.1 / diff / nxr@1.1.1.10.2.1
xsrc/external/mit/xterm/dist/charclass.c@1.1.1.5.2.1 / diff / nxr@1.1.1.5.2.1
xsrc/external/mit/xterm/dist/charclass.h@1.1.1.2.2.1 / diff / nxr@1.1.1.2.2.1
xsrc/external/mit/xterm/dist/charproc.c@1.1.1.14.2.1 / diff / nxr@1.1.1.14.2.1
      :
(more 110 files)
Pull up the following

xsrc/external/mit/xterm/dist/package/debian/xterm-dev.lintian-overrides up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/freebsd/distinfo up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/freebsd/pkg-message.wchar up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/pkgsrc/Makefile up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/pkgsrc/DESCR    up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/pkgsrc/distinfo up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/pkgsrc/PLIST    up to 1.1.1.1
xsrc/external/mit/xterm/dist/package/pkgsrc/options.mk up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/modify-keys.pl  up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/mouse-codes    up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/other-sgr.sh    up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/print-vt-chars.pl up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/query-dynamic.pl up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/query-xres.pl  up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/report-sgr.pl  up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/sgrPushPop.pl  up to 1.1.1.1
xsrc/external/mit/xterm/dist/vttests/sgrPushPop2.pl  up to 1.1.1.1
xsrc/external/mit/xterm/dist/COPYING                up to 1.1.1.1
xsrc/external/mit/xterm/dist/gen-charsets.pl        up to 1.1.1.1
xsrc/external/mit/xterm/dist/INSTALL                up to 1.1.1.12
xsrc/external/mit/xterm/dist/Imakefile              up to 1.1.1.10
xsrc/external/mit/xterm/dist/MANIFEST                up to 1.1.1.16
xsrc/external/mit/xterm/dist/Makefile.in            up to 1.1.1.13
xsrc/external/mit/xterm/dist/NEWS                    up to 1.1.1.3
xsrc/external/mit/xterm/dist/THANKS                  up to 1.1.1.9
xsrc/external/mit/xterm/dist/TekPrsTbl.c            up to 1.1.1.2
xsrc/external/mit/xterm/dist/Tekproc.c              up to 1.1.1.14
xsrc/external/mit/xterm/dist/UXTerm.ad              up to 1.1.1.3
xsrc/external/mit/xterm/dist/VTPrsTbl.c              up to 1.1.1.9
xsrc/external/mit/xterm/dist/VTparse.def            up to 1.1.1.8
xsrc/external/mit/xterm/dist/VTparse.h              up to 1.1.1.10
xsrc/external/mit/xterm/dist/XTerm.ad                up to 1.11
xsrc/external/mit/xterm/dist/aclocal.m4              up to 1.1.1.14
xsrc/external/mit/xterm/dist/button.c                up to 1.1.1.16
xsrc/external/mit/xterm/dist/cachedGCs.c            up to 1.1.1.11
xsrc/external/mit/xterm/dist/charclass.c            up to 1.1.1.6
xsrc/external/mit/xterm/dist/charclass.h            up to 1.1.1.3
xsrc/external/mit/xterm/dist/charproc.c              up to 1.1.1.15
xsrc/external/mit/xterm/dist/charsets.c              up to 1.1.1.6
xsrc/external/mit/xterm/dist/config.guess            up to 1.1.1.12
xsrc/external/mit/xterm/dist/config.sub              up to 1.1.1.12
xsrc/external/mit/xterm/dist/configure              up to 1.1.1.14
xsrc/external/mit/xterm/dist/configure.in            up to 1.1.1.13
xsrc/external/mit/xterm/dist/ctlseqs.ms              up to 1.1.1.15
xsrc/external/mit/xterm/dist/ctlseqs.txt            up to 1.1.1.15
xsrc/external/mit/xterm/dist/cursor.c                up to 1.1.1.9
xsrc/external/mit/xterm/dist/data.c                  up to 1.1.1.7
xsrc/external/mit/xterm/dist/data.h                  up to 1.1.1.10
xsrc/external/mit/xterm/dist/df-install.in          up to 1.1.1.3
xsrc/external/mit/xterm/dist/doublechr.c            up to 1.1.1.9
xsrc/external/mit/xterm/dist/error.h                up to 1.1.1.6
xsrc/external/mit/xterm/dist/fontutils.c            up to 1.8
xsrc/external/mit/xterm/dist/fontutils.h            up to 1.1.1.10
xsrc/external/mit/xterm/dist/graphics.c              up to 1.1.1.6
xsrc/external/mit/xterm/dist/graphics_regis.c        up to 1.1.1.5
xsrc/external/mit/xterm/dist/graphics_sixel.c        up to 1.1.1.4
xsrc/external/mit/xterm/dist/html.c                  up to 1.1.1.3
xsrc/external/mit/xterm/dist/input.c                up to 1.1.1.13
xsrc/external/mit/xterm/dist/keysym2ucs.c            up to 1.1.1.3
xsrc/external/mit/xterm/dist/koi8rxterm              up to 1.1.1.3
xsrc/external/mit/xterm/dist/koi8rxterm.man          up to 1.1.1.3
xsrc/external/mit/xterm/dist/linedata.c              up to 1.6
xsrc/external/mit/xterm/dist/main.c                  up to 1.1.1.13
xsrc/external/mit/xterm/dist/main.h                  up to 1.1.1.6
xsrc/external/mit/xterm/dist/menu.c                  up to 1.1.1.13
xsrc/external/mit/xterm/dist/menu.h                  up to 1.1.1.12
xsrc/external/mit/xterm/dist/minstall.in            up to 1.1.1.5
xsrc/external/mit/xterm/dist/misc.c                  up to 1.17
xsrc/external/mit/xterm/dist/plink.sh                up to 1.1.1.5
xsrc/external/mit/xterm/dist/print.c                up to 1.1.1.11
xsrc/external/mit/xterm/dist/ptydata.c              up to 1.1.1.9
xsrc/external/mit/xterm/dist/ptyx.h                  up to 1.15
xsrc/external/mit/xterm/dist/resize.c                up to 1.1.1.9
xsrc/external/mit/xterm/dist/resize.man              up to 1.1.1.5
xsrc/external/mit/xterm/dist/run-tic.sh              up to 1.1.1.3
xsrc/external/mit/xterm/dist/screen.c                up to 1.1.1.12
xsrc/external/mit/xterm/dist/scrollback.c            up to 1.6
xsrc/external/mit/xterm/dist/scrollbar.c            up to 1.1.1.11
xsrc/external/mit/xterm/dist/svg.c                  up to 1.1.1.2
xsrc/external/mit/xterm/dist/tabs.c                  up to 1.1.1.6
xsrc/external/mit/xterm/dist/termcap                up to 1.1.1.6
xsrc/external/mit/xterm/dist/terminfo                up to 1.1.1.7
xsrc/external/mit/xterm/dist/testxmc.c              up to 1.1.1.7
xsrc/external/mit/xterm/dist/trace.c                up to 1.1.1.13
xsrc/external/mit/xterm/dist/trace.h                up to 1.1.1.13
xsrc/external/mit/xterm/dist/util.c                  up to 1.1.1.13
xsrc/external/mit/xterm/dist/uxterm                  up to 1.1.1.3
xsrc/external/mit/xterm/dist/uxterm.desktop          up to 1.1.1.5
xsrc/external/mit/xterm/dist/uxterm.man              up to 1.1.1.3
xsrc/external/mit/xterm/dist/version.c              up to 1.1.1.5
xsrc/external/mit/xterm/dist/version.h              up to 1.1.1.16
xsrc/external/mit/xterm/dist/vms.c                  up to 1.1.1.4
xsrc/external/mit/xterm/dist/wcwidth.c              up to 1.1.1.6
xsrc/external/mit/xterm/dist/xcharmouse.h            up to 1.1.1.5
xsrc/external/mit/xterm/dist/xstrings.c              up to 1.1.1.10
xsrc/external/mit/xterm/dist/xterm.appdata.xml      up to 1.1.1.3
xsrc/external/mit/xterm/dist/xterm.dat              up to 1.1.1.3
xsrc/external/mit/xterm/dist/xterm.h                up to 1.3
xsrc/external/mit/xterm/dist/xterm.log.html          up to 1.1.1.16
xsrc/external/mit/xterm/dist/xterm.man              up to 1.17
xsrc/external/mit/xterm/dist/xterm_io.h              up to 1.1.1.7
xsrc/external/mit/xterm/dist/xtermcap.c              up to 1.1.1.9
xsrc/external/mit/xterm/dist/xtermcfg.hin            up to 1.1.1.13
xsrc/external/mit/xterm/dist/xutf8.c                up to 1.1.1.6
xsrc/external/mit/xterm/dist/icons/filled-xterm.svg  up to 1.1.1.2
xsrc/external/mit/xterm/dist/icons/mini.xterm.svg    up to 1.1.1.2
xsrc/external/mit/xterm/dist/icons/terminal_48x48.svg up to 1.1.1.2
xsrc/external/mit/xterm/dist/icons/xterm-color.svg  up to 1.1.1.2
xsrc/external/mit/xterm/dist/icons/xterm.svg        up to 1.1.1.2
xsrc/external/mit/xterm/dist/package/xterm.spec      up to 1.1.1.11
xsrc/external/mit/xterm/dist/package/debian/changelog up to 1.1.1.11
xsrc/external/mit/xterm/dist/package/debian/compat  up to 1.1.1.2
xsrc/external/mit/xterm/dist/package/debian/control  up to 1.1.1.5
xsrc/external/mit/xterm/dist/package/debian/copyright up to 1.1.1.7
xsrc/external/mit/xterm/dist/package/debian/rules    up to 1.1.1.8
xsrc/external/mit/xterm/dist/package/debian/watch    up to 1.1.1.2
xsrc/external/mit/xterm/dist/package/freebsd/Makefile up to 1.1.1.7
xsrc/external/mit/xterm/dist/package/freebsd/pkg-descr up to 1.1.1.2
xsrc/external/mit/xterm/dist/unicode/convmap.pl      up to 1.1.1.3
xsrc/external/mit/xterm/dist/unicode/keysym.map      up to 1.1.1.3
xsrc/external/mit/xterm/dist/vttests/256colors2.pl  up to 1.1.1.6
xsrc/external/mit/xterm/dist/vttests/88colors2.pl    up to 1.1.1.6
xsrc/external/mit/xterm/dist/vttests/closest-rgb.pl  up to 1.1.1.2
xsrc/external/mit/xterm/dist/vttests/dynamic.pl      up to 1.1.1.4
xsrc/external/mit/xterm/dist/vttests/paste64.pl      up to 1.1.1.5
xsrc/external/mit/xterm/dist/vttests/query-color.pl  up to 1.1.1.4
xsrc/external/mit/xterm/dist/vttests/query-fonts.pl  up to 1.1.1.3
xsrc/external/mit/xterm/dist/vttests/query-status.pl up to 1.1.1.2
xsrc/external/mit/xterm/dist/vttests/tcapquery.pl    up to 1.1.1.6
xsrc/external/mit/xterm/include/xtermcfg.h          up to 1.15

Import Xterm 366, changes too numerous to list, main fix is for CVE-2021-27135:
* correct upper-limit for selection buffer, accounting for combining
  characters

(martin)

2021-02-17 09:36:10 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by oster in ticket #1655):

sys/dev/raidframe/rf_reconstruct.c: revision 1.125

Fix a long long-standing off-by-one error in computing lastPSID.

SUsPerPU is only really supported for a value of 1, and since the
first PSID is 0, the last will be numStripe-1.  Also update the
setting of pending_writes to reflect the change to lastPSID.

Needs pullups to -8 and -9.

(martin)

2021-02-17 09:34:20 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by oster in ticket #1206):

sys/dev/raidframe/rf_reconstruct.c: revision 1.125

Fix a long long-standing off-by-one error in computing lastPSID.

SUsPerPU is only really supported for a value of 1, and since the
first PSID is 0, the last will be numStripe-1.  Also update the
setting of pending_writes to reflect the change to lastPSID.

Needs pullups to -8 and -9.

(martin)

2021-02-17 08:49:55 UTC MAIN commitmail json YAML

Revert "distrib/amd64/cdroms: honor CDBOOTOPTIONS when installing EFI bootloader"

https://mail-index.netbsd.org/current-users/2021/02/17/msg040358.html
I think this change had unexpected side effects and needs further review

(dbj)

2021-02-17 08:19:06 UTC MAIN commitmail json YAML

2021-02-17 08:18:39 UTC MAIN commitmail json YAML

Use the PCI_MAPREG_TYPE macro.  Same binary after change.

(skrll)

2021-02-17 08:15:43 UTC MAIN commitmail json YAML

In 64 bit architectures, WM_EVENT_COUNTER is enabled by default.

No objection from tech-kern@n.o and tech-net@n.o.

ok'ed by msaitoh@n.o.

(knakahara)

2021-02-17 08:10:34 UTC MAIN commitmail json YAML

wm(4) use atomic_{load,store}_relaxed for evcnt 64 bit counter.

ok'ed by msaitoh@n.o.

(knakahara)

2021-02-17 08:09:22 UTC MAIN commitmail json YAML

Use the register name and not its number in _PROF_CPLOAD.

"yes please!" from simon@

(skrll)

2021-02-17 06:54:23 UTC MAIN commitmail json YAML

Trailing whitespace. *snigger*

(skrll)

2021-02-17 06:33:48 UTC MAIN commitmail json YAML

x86/tsc: fix double space in warning about TSC going backwards

(rillig)

2021-02-17 06:30:57 UTC MAIN commitmail json YAML

Expose more descriptor items as device properties.

(mlelstv)

2021-02-17 06:25:11 UTC MAIN commitmail json YAML

2021-02-17 03:06:07 UTC MAIN commitmail json YAML

remove -DOPT_* from here (now in xtermcfg.h).

restore comment lost in rev 1.18.

(mrg)

2021-02-17 03:03:28 UTC MAIN commitmail json YAML

define OPT_SIXEL_GRAPHICS here like everything else, rather than
than Makefile.  (OPT_GRAPHICS is already defined here.)

(mrg)

2021-02-16 22:12:50 UTC MAIN commitmail json YAML

pic: avoid pic_do_pending_ints if pic_mark_pending_* has never been called

(jmcneill)

2021-02-16 19:46:15 UTC MAIN commitmail json YAML

make: clean up VarAdd, Var_Delete, Var_ReexportVars

No functional change.

(rillig)

2021-02-16 19:43:09 UTC MAIN commitmail json YAML

make: document the bad state in which the test varcmd.mk is

(rillig)

2021-02-16 19:01:18 UTC MAIN commitmail json YAML

make: test exporting a variable that itself depends on a subprocess

When the point that "isn't going to end well" is reached, the stacktrace
is quite long but still reasonable:

main
main_ReadFiles
ReadAllMakefiles
ReadMakefile directive-export.mk
Parse_File
ParseLine # line 3 has: _!= :;:
ParseVarassign
Parse_DoVar
VarAssign_Eval
VarAssign_EvalShell # because of the '!='
Cmd_Exec :;:
Var_ReexportVars # before starting the subprocess
ExportVar EMPTY_SHELL
ExportVarEnv # was only marked for export
Var_Subst ${EMPTY_SHELL} # to get the value to export
VarSubstExpr ${EMPTY_SHELL}
Var_Parse ${EMPTY_SHELL}
Var_Subst ${:sh} # since EMPTY_SHELL= ${:sh}
VarSubstExpr ${:sh}
Var_Parse ${:sh}
ApplyModifiers
ApplySingleModifier :sh
ApplyModifier
ApplyModifier_SunShell :sh
Cmd_Exec "" # empty command
Var_ReexportVars
ExportVar EMPTY_SHELL
ExportVarEnv # skipping this edge case

(rillig)

2021-02-16 18:12:46 UTC MAIN commitmail json YAML

make: clarify what .export ${:U} means

(rillig)

2021-02-16 18:02:19 UTC MAIN commitmail json YAML

make: demonstrate inconsistency in .undef of an exported variable

(rillig)

2021-02-16 17:41:23 UTC MAIN commitmail json YAML

make: clean up and update comments in var.c

During the refactorings of the last months, several comments have become
outdated, some are now redundant since the code is as clear as the
comment, and some code benefits from a bit of explanation.

(rillig)

2021-02-16 16:33:40 UTC MAIN commitmail json YAML

make: use bit-shift expressions for VarFlags constants

These are easier to read than hex constants.

There was no need to skip bits 2 and 3 (there were no constants for 0x04
and 0x08).  Close this gap, to avoid confusing future readers.  Keep the
relative order of the flags since that affects the debug output of -dv.

No functional change.

(rillig)

2021-02-16 16:28:41 UTC MAIN commitmail json YAML

make: rename constants for VarFlags

The old prefix was "VAR_" and this prefix is used for several other
constants as well, which made it ambiguous.

(rillig)

2021-02-16 16:14:27 UTC MAIN commitmail json YAML

make: sync comment about duplicated code with reality

There are only very few places in var.c that contain really duplicate
code anymore.

There is still lots of _almost_ duplicate, for example the code for
parsing variable modifiers.  It differs subtly in behavior:

*  The modifiers ':M' and ':N' use '$$' to escape a '$' sign, while
    almost all other modifiers use '\$' for this purpose.

*  The modifiers ':M', ':N', ':S', ':@' and several others parse
    balanced parentheses and braces, allowing '(' to '}' to match.
    The modifiers ':D' and ':U' only treat the end character special but
    not the other 3 of '(){}'.

*  When parsing the modifier ':S' but not evaluating it, the code for
    nested variable expressions is parsed differently from when it is in
    evaluation mode (VARE_WANTRES).  This applies to an outer ':S'
    modifier and an inner ':D' or ':M' modifier.

Since these inconsistencies affect the behavior in edge cases and some
users of make might depend on it, they cannot be fixed by
behavior-preserving refactorings.

(rillig)

2021-02-16 15:30:26 UTC MAIN commitmail json YAML

PR bin/55979

Correctly handle (ie: ignore completely) \0 chars (nuls) in the
shell command input stream (script, dot file, or stdin).

Previously nul chars were ignored correctly in the line in which
they occurred, but would cause trailing chars of that line to reappear
as the start of the following line.  If there was just one \0 skipped,
this would generally result in an extra \n in the sh input, which in
most cases has no effect.  With multiple \0's in a single line, more
of the end of that line was duplicated into the following one.  This
usually manifested as a weird "command not found" error.

Note that any \0 chars in the sh input make the script non-conforming,
so fixing this is not crucial (no \0's should really ever be seen) but
it was an obvious bug in the code, which was attempting to ignore nul
chars (as do many other shells), so let it be fixed.

XXX pullup -9

(kre)

2021-02-16 15:30:12 UTC MAIN commitmail json YAML

PR bin/55979

This fixes the MSAN detected reference to an unitialised variable
(an unitialised field in a struct) which happens when a command is
not found after a PATH search.

Aside from skipping some known to be going to fail exec*() calls
in some cases, the setting of the relevant field is irrelevant,
so this problem makes no practical difference to the shell, or any
shell script.

XXX (maybe) pullup -9

(kre)

2021-02-16 15:06:30 UTC MAIN commitmail json YAML

2021-02-16 14:47:20 UTC MAIN commitmail json YAML

In netbsd32___mount50() zero out the native fs_args union before use so
we don't pass stack garbage to the lower layers in the MNT_GETARGS case.

Fixes random errors like "Bad address" from "mount -vv" with nfs mounts.

(simonb)

2021-02-16 14:44:26 UTC MAIN commitmail json YAML

Correct floating-point terminology.

Might want to harmonize the printf(3) and wprintf(3) descriptions of
`%a'.

(riastradh)

2021-02-16 10:58:33 UTC MAIN commitmail json YAML

I forgot to add the needed conf files for the mipssim virtio addition

(reinoud)

2021-02-16 10:22:52 UTC MAIN commitmail json YAML

One more time: backout arp header alignment, now that the alignment
asserted has been aligned to reality.
Also remove unused ARP_HDR_ALIGNED_P macro. Pointed out by roy.

(martin)

2021-02-16 10:20:56 UTC MAIN commitmail json YAML

ARP headers only need 2 byte alignment - pointed out by roy.

(martin)

2021-02-16 10:02:42 UTC MAIN commitmail json YAML

Enable "/etc/zfs/exports" from "zfs share" in rc.d/mountd and rc.d/mountall.

(hannken)

2021-02-16 10:01:55 UTC MAIN commitmail json YAML

2021-02-16 10:00:27 UTC MAIN commitmail json YAML

Add support for multiple exports files. This will be useful for example for
ZFS, where we have an automatically generated /etc/zfs/exports file, which
should not be edited directly.

(hannken)

2021-02-16 09:58:35 UTC MAIN commitmail json YAML

Split get_exportlist() into get_exportlist() and get_exportlist_one()
in preparation to support multiple input files.

No functional change intended.

(hannken)

2021-02-16 09:56:32 UTC MAIN commitmail json YAML

Reorganize uvm_swap_shutdown() a bit, make sure the vnode gets
locked and referenced across the call to swap_off() and finally
use it from vfs_unmountall1() to remove swap after unmounting
the last file system.

Adresses PR kern/54969 (Disk cache is no longer flushed on shutdown)

(hannken)

2021-02-16 09:54:17 UTC MAIN commitmail json YAML

Use the right uid / gid for nobody:nobody like FreeBSD does.

Prevents null pointer dereferences when ZFS replaces this
illegal (according to IS_EPHEMERAL()) id with another
illegal id in operation zfs_fuid_create_cred() and
finally zfs_log_create() dereferences fuidp being NULL.

Adresses PR misc/55042 (Panic when creating a directory on a NFS served ZFS)

(hannken)

2021-02-16 09:46:24 UTC MAIN commitmail json YAML

PR bin/55979

Add a sh ATF test to demonstrate a bug in the way that \0 characters
are dropped from scripts.  This test will eventually be extended to
test other potential sh script input related issues.

When initially committed, this test should fail.  It should succeed
when the fix for the PR is committed (soon).

Nb: this tests only the \0 related issues from the PR, the MSAN
detected uninitialised variable (struct field) can only be detected
by MSAN, as it has no visible impact on the operation of the shell
when running on any real (or even emulated) hardware.
(It will, however, also be fixed).

(kre)

2021-02-16 07:27:12 UTC MAIN commitmail json YAML

Provide a pic_set_priority_psw in the case that __HAVE_PIC_SET_PRIORITY
is not defined.

(skrll)

2021-02-16 06:06:58 UTC MAIN commitmail json YAML

Working kernel profiling for n32/n64:
- Different MCOUNT and _KERN_MCOUNT macros for n32/n64.
- Don't profile mipsXX_lwp_trampoline().
- Allow a few new instructions in the stub fixups.

(simonb)

2021-02-16 05:44:14 UTC MAIN commitmail json YAML

Undo previous backout: alignment is needed here.
The reason for the previous backout was a misunderstanding (POINTER_ALIGNED_P
was broken, but the assertion fired even after it got fixed).

(martin)

2021-02-16 05:11:27 UTC MAIN commitmail json YAML

Add no-profiled attribute for splhigh_noprof() and splx_noprof().

(simonb)

2021-02-15 23:46:46 UTC MAIN commitmail json YAML

distrib/sets/fmt-list: document how to sort by directory first

In lists/base/mi, the directory ./libdata/firmware contains several
subdirectories for which the entries do not look aligned right now, even
after normalizing the alignment.

This is because the indentation for a directory is not determined
globally for all directory entries from the complete file, but instead
for each group of items, after sorting, that have the same directory.
This results in several entries having only a single item per group,
such as ./libdata/firmware/nouveau, and this single item is obviously
consistently indented since all of its 1 lines are already indented to
the same depth.

One possible solution for this is to sort the entries in another order,
keeping all entries from a directory together.  This allows to quickly
see all entries from a certain directory, but on the other hand, when
adding a new directory plus some entries, the directory has to be listed
far away from its entries.  (This would be done automatically by
fmt-list though, which weakens this argument a bit.)

Another possible solution for this is to first determine the indentation
for all entries from each directory, no matter how far these entries are
apart, and then indent these entries to the common indentation.  This
may or may not help since there will still be single entries between
groups of differently indented entries.

Writing down the intuitive rules for how to align the entries properly
is a nontrivial task.  See pkglint/varalignblock, which is around 650
lines of code, plus around 4000 lines of test code.

No functional change.

(rillig)

2021-02-15 23:27:03 UTC MAIN commitmail json YAML

Fix a long long-standing off-by-one error in computing lastPSID.

SUsPerPU is only really supported for a value of 1, and since the
first PSID is 0, the last will be numStripe-1.  Also update the
setting of pending_writes to reflect the change to lastPSID.

Needs pullups to -8 and -9.

(oster)

2021-02-15 23:00:03 UTC MAIN commitmail json YAML

distrib/sets/list-fmt: sort commented entries like regular entries

Seen in lists/modules/ad.aarch64, among others.  These lines are not
intended as comments but as regular entries that just happen to be
commented out.

This is the same as how pkglint treats commented variable assignments,
which take part in aligning blocks of variable assignments even though
they are syntactically comments.

(rillig)

2021-02-15 22:39:46 UTC MAIN commitmail json YAML

2021-02-15 19:49:17 UTC MAIN commitmail json YAML

Undo previous; POINTER_ALIGNED_P was broken.

(christos)

2021-02-15 19:46:53 UTC MAIN commitmail json YAML

the fourth time is the charm

(christos)

2021-02-15 19:19:30 UTC MAIN commitmail json YAML

put back alignment (reported by martin@)

(christos)

2021-02-15 18:33:29 UTC MAIN commitmail json YAML

Fix pointer aligned macro to match the original (thanks @mlelstv)

(christos)

2021-02-15 18:23:32 UTC MAIN commitmail json YAML

2021-02-15 18:21:14 UTC MAIN commitmail json YAML

make: rename ExprStatus to ExprDefined

The type describes the definedness of an expression, not a general
status, therefore the new name is more precise.

The constants are renamed as well since their prefix 'VES' does not
match the type name anymore, it was correct 3 days ago when the type was
still named VarExprStatus.  The name VES_NONE was misleading since
'none' does not describe its actual effect.  That name came from the
time when the status was a bit set, and 'none' simply meant 'none of the
bits are set'.

The names used in debug logging will be renamed in a follow-up commit,
to demonstrate that the changes in this commit indeed have no functional
change, especially not the change from '!=' to '==' in line 4304.

No functional change.

(rillig)

2021-02-15 17:59:09 UTC MAIN commitmail json YAML

make: update comments for Expr, amending the previous commit

(rillig)

2021-02-15 17:46:36 UTC MAIN commitmail json YAML

interrupt: enable interrupts before running soft intr handlers. To avoid
stack usage going out of control, only do this at ci_intr_depth==0.

(jmcneill)

2021-02-15 17:44:09 UTC MAIN commitmail json YAML

make: split parameters for evaluating variable expressions

The details of how variable expressions are evaluated is controlled by
several parameters: startc and endc differ for $(VAR) and ${VAR}, the
value of the expression can be interpreted as a single big word, and
when joining several words (such as with ':M' or ':S'), there may be a
custom word separator (defined with ':ts*').

The scope of half of these parameters is the whole variable expression,
the other half of the parameters are reset after each chain of indirect
modifiers.  To make this distinction obvious in the code, extract Expr
from ApplyModifiersState.  Previously, these details were hidden in how
parameters are passed and restored among ApplyModifiersIndirect and
ApplyModifiers.

The changes in the individual ApplyModifier functions are numerous but
straight-forward.  They mostly replace 'st' with 'expr'.

The changes in ApplyModifiers and ApplyModifiersIndirect are more
subtle.  The value of the expression is no longer passed around but is
stored in a fixed location, in Expr, which makes it easier to reason
about memory management.

The code in ApplyModifiers after 'cleanup' looks quite different but
preserves the existing behavior.  Expr_SetValueRefer is nothing else
than the combination of FStr_Done followed by FStr_InitRefer.  Storing
exprStatus back at the end was responsible for passing the definedness
of the expression after applying the indirect modifiers back to the
outer ApplyModifiersState.  The same effect is now achieved by having
Expr.status with a wider scope.

No functional change.

(rillig)

2021-02-15 16:32:07 UTC MAIN commitmail json YAML

splx: use pic_set_priority_psw in interrupts disabled case to skip a few
more daif accesses.

(jmcneill)

2021-02-15 16:04:01 UTC MAIN commitmail json YAML

splx: restore priority even if interrupts are disabled

(jmcneill)

2021-02-15 15:55:51 UTC MAIN commitmail json YAML

Simplify to avoid copy based on the size of the source.

(joerg)

2021-02-15 15:53:49 UTC MAIN commitmail json YAML

Fix reversed test (thanks mlelstv)

(christos)

2021-02-15 15:42:58 UTC MAIN commitmail json YAML

splx: only dispatch hard interrupts if interrupts are enabled

(jmcneill)

2021-02-15 15:38:43 UTC MAIN commitmail json YAML

2021-02-15 15:36:53 UTC MAIN commitmail json YAML

Remove FreeBSD portions that are not relevant to our implementation (pointed
out by joerg@)

(christos)

2021-02-15 15:07:48 UTC MAIN commitmail json YAML

splx: only dispatch softints if interrupts are enabled

(jmcneill)

2021-02-15 14:38:06 UTC MAIN commitmail json YAML

2021-02-15 14:35:04 UTC MAIN commitmail json YAML

2021-02-15 13:39:18 UTC MAIN commitmail json YAML

Fix my copy-and-paste bug in rev1.160.
This fixes recording sample dropout.

(isaki)

2021-02-15 13:03:52 UTC MAIN commitmail json YAML

pic: reduce the number of daif accesses in pic_do_pending_ints

The caller has already provided daif state. No need to keep updating
daif via pic_set_priority if it's already in the state we need (interrupts
disabled).

(jmcneill)

2021-02-15 10:13:45 UTC MAIN commitmail json YAML

Fix the build.
Maybe there should be a ICMP6_HDR_ALIGNMENT, but for now there is
only IP6_HDR_ALIGNMENT.

(martin)

2021-02-15 09:29:57 UTC MAIN commitmail json YAML

Don't compare int against size_t .. since mbuf lengths should never
be negative, cast it from int to size_t (rather than the other way
around).  Hopefully fix build.

(kre)

2021-02-15 07:58:19 UTC MAIN commitmail json YAML

2021-02-15 07:42:35 UTC MAIN commitmail json YAML

make: fix typo in comment

(rillig)

2021-02-15 07:40:18 UTC MAIN commitmail json YAML

lint: remove redundant comment

That comment was useful when there was no function is_null_pointer.
Back then, the code for testing a null pointer was written in-line,
which made it really hard to see what's going on.  This is no longer the
case.

(rillig)

2021-02-15 07:36:40 UTC MAIN commitmail json YAML

lint: extract typeok_colon_pointer from typeok_colon

The subtype information is now only accessed if both operands are
actually pointers.

No functional change.

(rillig)

2021-02-15 07:18:20 UTC MAIN commitmail json YAML

tests/lint: fix comments in test for message 124

(rillig)

2021-02-15 07:06:27 UTC MAIN commitmail json YAML

tests/libcurses: fix error handling for non-system errors

These errors are unrelated to errno.  The scanf family of functions also
does not set errno.

(rillig)

2021-02-15 06:46:01 UTC MAIN commitmail json YAML

make: clean up code and comments around ModifyWord

In ModifyWords, there is no "passed string" anymore since that function
now directly operates on the expression value.

While here, improve the documentation of ModifyWordsCallback and rename
it to ModifyWordProc, focusing on its purpose instead of where it is
used.

(rillig)

2021-02-15 03:41:01 UTC MAIN commitmail json YAML

Fix build failure for options GATEWAY.

(knakahara)

2021-02-15 00:44:09 UTC MAIN commitmail json YAML

remove _ prefix from args

(christos)

2021-02-14 22:48:17 UTC MAIN commitmail json YAML

make: clean up memory management in evaluation of expressions

The condition "st->newValue.str != val" in ApplySingleModifier made the
memory management look more complicated than it really was.  Freeing an
object based on another object's value is harder to understand than
necessary.

To fix this, the "current value" of the expression is now stored in
ApplyModifiersState, and it gets updated in-place by the ApplyModifier
functions.  This reduces the number of parameters for the ApplyModifier
functions.

Accessing the current value of the expression is now more verbose than
before (st->value.str instead of the simple val).  To compensate for
this verbosity, ApplyModifiersIndirect is now much easier to understand
since there is no extra "current value" floating around.

There is still room for improvement.  In ApplyModifiers, passing an FStr
in and returning another (or possibly the same) makes it difficult to
understand memory management.  Adding a separate Expr type that outlives
the ApplyModifiersState will make this easier, in a follow-up commit.

(rillig)

2021-02-14 21:54:42 UTC MAIN commitmail json YAML

make: reduce redundant code around ModifyWords

The result of ModifyWords had been passed to Expr_SetValueOwn in all
cases.  The last argument to ModifyWords had always been st->sep.

(rillig)

2021-02-14 21:32:58 UTC MAIN commitmail json YAML

make: clean up FStr and MFStr memory in cleanup mode

(rillig)

2021-02-14 20:58:35 UTC MAIN commitmail json YAML

2021-02-14 20:30:31 UTC MAIN commitmail json YAML

sun4v: update TODO with status of verified systems(T2000, T5 and qemu)

(palle)

2021-02-14 20:22:30 UTC MAIN commitmail json YAML

make: print error about failed shell command before overwriting variable

Memory management of the value of variable expressions is currently more
complicated than necessary.  It is the responsibility of ApplyModifiers,
even though conceptually the value belongs to an expression, so it
should rather be in Expr.  Right now, this is an alias for
ApplyModifiersState, but that will change soon.

When that is done, there will no longer be a "current value" and a "new
value", only a single "value" of an expression.  At that point, before
Expr_SetValueOwn will overwrite the old value with the output of the
shell command, the error message needs to refer to the latter.

(rillig)

2021-02-14 20:16:18 UTC MAIN commitmail json YAML

2021-02-14 19:47:17 UTC MAIN commitmail json YAML

if_arp: Just KASSERT that arphrd is aligned

While here improve readability of checking ARP IEEE1394 matches interface.

(roy)

2021-02-14 19:35:38 UTC MAIN commitmail json YAML

if_ether: revert prior alignment checks

Apparently not needed as our drivers ensure this.

(roy)

2021-02-14 19:33:29 UTC MAIN commitmail json YAML

if_gre: Remove alignment checks in favour copying to stack

Makes the code a lot simpler, idea from dyoung@

(roy)

2021-02-14 18:59:36 UTC MAIN commitmail json YAML

make: clean up ValidShortVarname

The switch statement was hard to read, especially the "break" that
needed a comment since it was effectively a "continue".

(rillig)

2021-02-14 18:55:51 UTC MAIN commitmail json YAML

make: clean up ParseVarnameShort

Single-character short variable expressions such as $V neither have a
starting character nor an ending character.  The only interesting
character forms the complete variable name.

No functional change.

(rillig)

2021-02-14 18:45:44 UTC MAIN commitmail json YAML

Add KERNEL_DIR to /etc/release

"Sure, why not" from xtos!

(pgoyette)

2021-02-14 18:21:31 UTC MAIN commitmail json YAML

make: rename VarExprStatus to ExprStatus

It is only used in var.c so there is no need to use a prefix.

(rillig)

2021-02-14 17:47:33 UTC MAIN commitmail json YAML

make: add test for indirect ':U' modifier

Unlike ':ts' and ':tW', the effects of ':U' are visible even after the
modifiers from the nested expression have been applied.  These subtle
details, like many others, are not documented in the manual page.

(rillig)

2021-02-14 17:27:25 UTC MAIN commitmail json YAML

make: revert part of previous commit

That code was not ready yet.

(rillig)

2021-02-14 17:24:47 UTC MAIN commitmail json YAML

make: update line numbers in expected test output

The documentation from the previous commit added a few lines.

(rillig)

2021-02-14 17:22:37 UTC MAIN commitmail json YAML

make: document since when indirect modifiers are supported

(rillig)

2021-02-14 16:12:46 UTC MAIN commitmail json YAML

make: add more tests for edge cases in evaluating variable expressions

As a preparation for refactoring the code around variable expressions,
there need to be a few tests for indirect variable modifiers since these
were not covered before.

Indirect modifiers may include ':ts' and ':tW', which change the
interpretation of the variable expression in small details.  The scope
of these changes is limited to the indirect modifier, any evaluations
outside this indirect modifier are unaffected.

The changes to the .exp file are mostly line number changes, plus a
demonstration of a newly found bug, where an expression is evaluated
successfully despite producing a parse error.

(rillig)

2021-02-14 14:05:03 UTC MAIN commitmail json YAML

if_bnx.c: fix misleading indentation

suggested by rillig@

(jakllsch)

2021-02-14 13:53:28 UTC MAIN commitmail json YAML

make: add functions for assigning the value of an expression

The plan is to have only the "current value" of the expression as a
member, not the "new value".  To do this consistently and get the memory
management right, there must be a single place (or two) where the value
of the expression is updated.

No functional change.

(rillig)

2021-02-14 13:46:01 UTC MAIN commitmail json YAML

make: rename ApplyModifiersState_Define to Expr_Define

The type name ApplyModifiersState was only intended as a working draft,
its name is too long and its scope a little too narrow.

Applying the modifiers is the main part of evaluating a variable
expression, and the scope of that type will be extended to parsing the
name of the expression as well.  This will hopefully reduce the number
of parameters, which is currently at 14.

No functional change.

(rillig)

2021-02-14 13:24:45 UTC MAIN commitmail json YAML

make: fix TMPDIR in unit-tests

Combining the assignment operator ':=' with the variable modifier ':U'
on the same variable does not work as intended.  At the point where the
':U' is evaluated, the variable is guaranteed to be defined because the
code in VarAssign_EvalSubst says so.

(rillig)

2021-02-14 12:35:27 UTC MAIN commitmail json YAML

make: condense the code for parsing :S and :C modifiers

No functional change.

(rillig)

2021-02-14 12:24:53 UTC MAIN commitmail json YAML

make: rearrange some comments to make them easier to spot

(rillig)

2021-02-14 12:16:13 UTC MAIN commitmail json YAML

make: document purpose of stepping back in the parser

In ApplyModifier_Assign there was no need to compute the delimiter from
st->startc since that has already be done at that point.

(rillig)

2021-02-14 12:14:37 UTC MAIN commitmail json YAML

make: add test for ::= modifier enclosed in parentheses

(rillig)

2021-02-14 11:21:37 UTC MAIN commitmail json YAML

tests/libcurses: document the history about tab bugs in addch/addstr

Verified by installing all versions of libcurses from 2012 to 2021 and
running a simple test program on them:

#include <stdio.h>
#include <curses.h>

int
main(int argc, char **argv)
{
int xstr, ystr, xch, ych;

initscr();

addstr("\t");
xstr = getcurx(stdscr);
addstr("\n");
ystr = getcury(stdscr);

addch('\t');
xch = getcurx(stdscr);
addch('\n');
ych = getcury(stdscr);

endwin();

fprintf(stderr, "%s\t%d,%d\t%d,%d\n",
    argv[1], ystr, xstr, ych, xch);
}

Some selected outputs:

...
2016.11.24.14.49.08 1,0 2,8
2016.11.28.18.25.26    1,8 2,8
...
2019.05.12.02.29.00 1,8 2,8
2019.05.20.22.17.41 1,8 2,16
...
2021.02.13.10.37.00 1,8 2,16
2021.02.13.14.30.37 1,8 2,8

(rillig)

2021-02-14 03:41:13 UTC MAIN commitmail json YAML

Add missing curlwp_bindx() corresponding to curlwp_bind().
Pointed out by riastradh@.

(isaki)

2021-02-14 01:27:33 UTC MAIN commitmail json YAML

Adjust test cases to hit the fudge case after the changes in nbperf
itself.

(joerg)

2021-02-13 22:19:47 UTC MAIN commitmail json YAML

2021-02-13 19:23:11 UTC MAIN commitmail json YAML

tests/libcurses: protect against short writes

The previous code only errored out if a write failed completely.  If it
was partially written, the program continued without writing the rest of
it.

Extract the common code into a few functions that write raw data to the
parent process.

(rillig)

2021-02-13 18:24:11 UTC MAIN commitmail json YAML

tests/libcurses: remove unused code in linter

(rillig)

2021-02-13 18:13:54 UTC MAIN commitmail json YAML

No assignment is needed here.

the loop in pmap_page_remove() always removes the first pv,
and since the list is managed by _pmap_remove_pv(), pp->pp_pv.pv_next always points to the first.

(ryo)

2021-02-13 16:43:12 UTC MAIN commitmail json YAML

tests/libcurses: use ASCII only in terminfo description

(rillig)

2021-02-13 16:38:02 UTC MAIN commitmail json YAML

tests/libcurses: split terminfo entry over more lines

This provides space to see each capability on its own, instead of having
to search them in the blob of text.

(rillig)

2021-02-13 16:33:30 UTC MAIN commitmail json YAML

2021-02-13 15:42:15 UTC MAIN commitmail json YAML

Add aprint_*() newlines for viadrmums(4) attach

>From Andrius V in kern/55884

(jakllsch)

2021-02-13 15:31:36 UTC MAIN commitmail json YAML

PR 55991: when extending the marked partition (typically: the NetBSD root
partition) round the new size up to current alignment.

This may lead to a slightly smaller than initialy planned last partition
(depending on order added) if the disk size is odd or the partitioning
scheme needs some internal space (like GPT) - but it avoids gaps elsewhere
due to alignement.

Ideally we would pin all other partitions in a first pass and then let
the partitioning backend pick the full available size for the extended
partition, but this should be good enough.

(martin)

2021-02-13 14:30:37 UTC MAIN commitmail json YAML

libcurses: fix wrong tab width for addch

In sysinst, the installation screen is indented with tabs.  Sysinst uses
msgc, which brings its own text layout engine.  This engine does not use
addbytes but addch.  In addch, the x position for each tab was advanced
twice as much as needed.  The menu items were thus not indented by 8
spaces but by 16, which caused an ugly line break in the German
translation.

This bug largely went unnoticed because most other applications use
addbytes instead, which worked fine all the time.  It had been
introduced somewhere between NetBSD 8.0 and NetBSD 9.0.

The code around this bug used aliased variables for win->curx and
win->cury a lot.  Getting this right is difficult and needs a thorough
test suite.  Even though libcurses has 201 tests, that is not nearly
enough to cover all the relations between the various functions in
libcurses that call each other, crossing API boundaries from internal
to external, doing character conversions on the way and juggling around
4 different types of characters (char, wchar_t, chtype, cchar_t).

The simplest fix was to remove all this aliasing, while keeping the
API the same.  If _cursesi_waddbytes is not considered part of the API,
it would be possible to replace px with win->curx in all places, same
for py and win->cury.

The complicated code with the aliasing may have been meant for
performance reasons, but it's hard to see any advantage if both points
of truth need to be synchronized all the time.

Libcurses can be built in 2 modes: with wide character support or
without (-DDISABLE_WCHAR).  The test suite only covers the variant with
wide characters.  The single-byte variant has to be tested manually.
Running sysinst with the single-byte libcurses produces the correct
layout.

(rillig)

2021-02-13 13:00:16 UTC MAIN commitmail json YAML

2021-02-13 10:37:00 UTC MAIN commitmail json YAML

curses.h: proofread, indent a bit more consistently

(rillig)