tests/libcurses: fix reading from the parent process

In case of a short read, processing the incomplete data invoked
undefined behavior.

(rillig)

tests/libcurses: fix child process handling

The child process needs to be properly controlled by the parent process.
Otherwise it is not possible to get code coverage data from it using
gcov since that requires the child process to exit normally.  Previously
the child process had been killed because its parent had exited.

(rillig)

tests/libcurses: fix error messages

(rillig)

tests/libcurses: "fix" test mvwin

The test mvwin previously expected an endless stream of bytes, by
comparing the actual output with /dev/zero.  This didn't make sense as
the curses output does not contain '\0' in any of the test cases.

Compare with /dev/null instead.  This is as wrong as before, but the
curses test framework currently ignores this situation, as for many
other test cases.  See the numerous "Excess" messages in atf-run.log.

(rillig)

tests/libcurses: remove undocumented, unused command line option

The option -T has the same effect as the removed option -p.

(rillig)

tests/libcurses: remove include path from usage message

The option has been removed a few minutes ago.

(rillig)

tests/libcurses: clean up remaining include guard, comments

No functional change.

(rillig)

tests/libcurses: clean up inclusion guards, function declarations

No functional change.

(rillig)

tests/libcurses: remove include path handling

All include commands in the current test suite use relative paths.
Instead of a fixed include path, interpret the included filename
relative to the including file.

(rillig)

if_arp: Ensure that arphdr is aligned

(roy)

tests/libcurses: align comments

(rillig)

tests/libcurses: fix misleading usage documentation

The check-files are not config files.

(rillig)

if_ether: Ensure that ether_header is aligned

(roy)

tests/libcurses: fix pipe handling in the parent process

The parent process, like the child process, needs only 2 of the 4 pipe
ends.

In verbose mode (now at testlang_parse.y:1151 and :1154), both ends of the
pipe_from_slave were examined.  This looked like a typo and has been fixed
to those pipe ends that are relevant to the parent process.

(rillig)

tests/libcurses: fix pipe handling in child process

The child process only ever needs 2 ends of the pipes: one for reading
the commands, one for writing back the results.

(rillig)

tests/libcurses: add test for addbytes

(rillig)

Document EINVAL for invalid flags given to fsync_range().

(dholland)

tests/libcurses: fix warnings for missing environment variables

(rillig)

Improve readability of this file by adding register prefixes.

(thorpej)

Revert bnx(4) to INTx interrupts.

Should fix PR kern/55974.

This driver does not yet do the special MSI and MSI-X setup that the
chip apparently requires.

(jakllsch)

- Don't change to the OFW stack in C code; instead, switch to the OFW
  stack in the openfirmware() wrapper itself.  Inspired by a similar
  change in OpenBSD designed to appease clang.
- The OF_*() entry firmware interfaces use several global resources;
  protect those global resources with a __cpu_simple_lock_t.
- Make ofbcopy() static -- it's no longer referenced outside openfirm.c

(thorpej)

Call cpu_model_init() after clearing the MSR.

(thorpej)

Add some comments to help visually track the nested #ifdef blocks in
ofwoea_batinit().

(thorpej)

No need for a prototype of ofbcopy() here.

(thorpej)

UART_RFIFO_REG should be masked before passing to cn_check_magic(). there is any data in other than the lower 8 bits.

(ryo)

tests/libcurses: format misleading do-while loop

(rillig)

tests/libcurses: remove wrong comments

(rillig)

tests/libcurses: remove excess empty lines

(rillig)

tests/libcurses: query function arguments in consistent order

(rillig)

if_gre: Ensure that gre_h is aligned

(roy)

entropy: Only print consolidation warning of AB_DEBUG.

The previous fix for PR kern/55458 changed printf to log(LOG_DEBUG, ...) with
the intent of hiding the message unless 'boot -x'. But this did not actually
suppress the message to console as log(LOG_DEBUG, ...) will print to console
if syslogd is not running yet.

So instead, just check for AB_DEBUG flag directly in boothowto, and only
printf the message if it is set.

(jmcneill)

tests/libcurses: don't access args directly

By providing declarative syntax for accessing the arguments, the
unnecessarily detailed boilerplate code is hidden.  This allows easy
inspection by tools and humans, to check for typos and other mistakes.

(rillig)

tests/libcurses: replace ARG_CHTYPE_STRING with ARG_CHTYPE

All uses of the previous macro did not treat the argument as a string or
array of chtype, but as a single chtype.  It's strange that the previous
code arbitrarily split the access to the argument by first storing it as
a pointer and then dereferencing it.

No functional change.

(rillig)

tests/libcurses: add shortcut macros for SCREEN and unsigned int

(rillig)

tests/libcurses: remove redundant comments

There is nothing surprising about call2, call3 or call4.

(rillig)

tests/libcurses: reduce boilerplate in function dispatcher

No functional change.  The generated code for GCC 9.3 on NetBSD 9.99.80
x86_64 is exactly the same as before.

(rillig)

regen for va_copy() check cross-compile soft fail

(lukem)

configure: soft-fail cross-compile check for va_copy()

Be consistent with other AC_RUN_IFELSE() checks and change the va_copy()
checks to soft-fail (instead of hard fail) when cross-compiling.

(lukem)

Reset serial terminal to default state at boot.

UEFI may leave the serial console in an undesireable state (incorrect
foreground and background colour, etc) when exiting. Send ANSI escape
sequences when setting up the early console attachments to turn off
character attributes and erase from the cursor to the end of the screen.

(jmcneill)

Add HOTP and TOTP

(leot)

tests/libcurses: reduce boilerplate in function dispatcher

This makes the code more declarative and easier to reason about.

The generated code stays exactly the same.

(rillig)

rnd(4): Consistently call it the `global pool'.

The `ready pool' is a term I used in a draft that I never committed.

(riastradh)

remove unused/useless #ifdef block

(macallan)

Tickets #1652 - #1654

(martin)

Pull up following revision(s) (requested by tsutsui in ticket #1654):

sys/arch/x68k/x68k/machdep.c: revision 1.204

Restore fixes for PR/51663 lost in r1.195 (uvm_hotplug(9) merge).

The kernel crashdump and savecore(8) on NetBSD/x68k have been broken
(even without EXTNEDED_MEMORY) since NetBSD 8.0. Oops.

Should be pulled up to netbsd-9 and netbsd-8.

(martin)

Tickets #1203 - #1205

(martin)

Pull up following revision(s) (requested by tsutsui in ticket #1205):

sys/arch/x68k/x68k/machdep.c: revision 1.204

Restore fixes for PR/51663 lost in r1.195 (uvm_hotplug(9) merge).

The kernel crashdump and savecore(8) on NetBSD/x68k have been broken
(even without EXTNEDED_MEMORY) since NetBSD 8.0. Oops.

Should be pulled up to netbsd-9 and netbsd-8.

(martin)

Pull up following revision(s) (requested by ryoon in ticket #1653):

sys/fs/msdosfs/msdosfs_vfsops.c: revision 1.136

Enable to mount Raspberry Pi Pico's USB mass storage partition
Fix PR kern/55985.

O.k. by thorpej@.
Pull-up to netbsd-8 and netbsd-9.

(martin)

Pull up following revision(s) (requested by ryoon in ticket #1204):

sys/fs/msdosfs/msdosfs_vfsops.c: revision 1.136

Enable to mount Raspberry Pi Pico's USB mass storage partition
Fix PR kern/55985.

O.k. by thorpej@.
Pull-up to netbsd-8 and netbsd-9.

(martin)

Pull up following revision(s) (requested by ryoon in ticket #1652):

sys/dev/scsipi/cd.c: revision 1.350
sys/dev/scsipi/sd.c: revision 1.331

PR 55986: Ryo Onodera: DK_BUSY must have mask as second argument. Make cd.c
consistent by also using __BIT()

(martin)

Pull up following revision(s) (requested by ryoon in ticket #1203):

sys/dev/scsipi/cd.c: revision 1.350
sys/dev/scsipi/sd.c: revision 1.331

PR 55986: Ryo Onodera: DK_BUSY must have mask as second argument. Make cd.c
consistent by also using __BIT()

(martin)

add new files for xterm 366.

(mrg)

merge xterm-366.  this includes the fix for CVE-2021-27135.

(note that testing so far has not revealed this problem on netbsd,
though i have not heard about pkgsrc x11 users.)

(mrg)

clean up issues detected by address sanitizer (just some memory
leaks that only apply to the library version.)

XXX: the handling of hr_file and its variants is more crappy
again - the prior clean up is slightly less clean now, but at
least it does not leak memory.

XXX2: cgi-bin test hangs with address sanitizer.  don't know
why yet..

(mrg)

changes in bozohttpd 20210210:
o  fix various NULL derefs from malformed headers.  mostly from
  <emily@ingalls.rocks>.

(mrg)

include "opt_gprof.h" so that _PROF_PROLOGUE works properly in ENTRY() macro in *.S files

(ryo)

Fix a message for NMI.

Maybe the "keyboard NMI" message was derived from hp300 but
on X68030 NMI is triggered by the NMI button, and there is no
parity check.

(tsutsui)

Enable to mount Raspberry Pi Pico's USB mass storage partition

Fix PR kern/55985.
O.k. by thorpej@.

Pull-up to netbsd-8 and netbsd-9.

(ryoon)

Ticket #1651

(martin)

Pull up following revision(s) (requested by ginsbach in ticket #1651):

usr.bin/nl/nl.c: revision 1.13
usr.bin/nl/nl.c: revision 1.14
usr.bin/nl/nl.c: revision 1.15

nl(1): remove superfluous exit

Remove exit(3) call missed when errors were converted to errx(3).

nl: fix -d delim parsing for POSIX
POSIX specifies it is possible to specify a one delimiter character.
Fix the logic so that both one and two character delimiters are accepted.

PR/55891 supress displaying separator when numbers supressed

Fix based on patch provided by Kobayashi Takashi. This brings nl(1) further
in to POSIX compliance. Verified behavior with classic SysV nl(1) and GNU
nl(1). There could still be edge cases here not specified by POSIX.

(martin)

Ticket #1202

(martin)

Pull up following revision(s) (requested by ginsbach in ticket #1202):

usr.bin/nl/nl.c: revision 1.13
usr.bin/nl/nl.c: revision 1.14
usr.bin/nl/nl.c: revision 1.15

nl(1): remove superfluous exit

Remove exit(3) call missed when errors were converted to errx(3).

nl: fix -d delim parsing for POSIX
POSIX specifies it is possible to specify a one delimiter character.
Fix the logic so that both one and two character delimiters are accepted.

PR/55891 supress displaying separator when numbers supressed

Fix based on patch provided by Kobayashi Takashi. This brings nl(1) further
in to POSIX compliance. Verified behavior with classic SysV nl(1) and GNU
nl(1). There could still be edge cases here not specified by POSIX.

(martin)

PR/55986: Ryo Onodera: DK_BUSY must have mask as second argument. Make cd.c
consistent by also using __BIT()

(christos)

Oh...the name of the mcount call was different between gcc and llvm.
gcc calls it as "_mconut", llvm calls as "__mcount".

Change the main name of mcount to "mcount()", and created "_mcount" and "__mcount" entries
to work regardless of which compiler the object was created with.

(ryo)

add support kernel profiling on aarch64

- add MCOUNT_ENTER, MCOUNT_EXIT macro
- __mcount() function should be aligned
- add "-fno-optimize-sibling-calls" option when PROF. for accurate profiling, it is better to suppress the tail call.

(ryo)

On MIPS use a helper function to work out the current PC and then
call stacktrace_subr() directly for displaying a stacktrace with
db_stacktrace() and friends.

(simonb)

Allow for MD code to use a different function than db_stack_trace_print()
to be used with db_stacktrace() and friends by pre-defining the
db_stacktrace_print macro.

(simonb)

>From Cy Schubert:

ipfilter: Use the softn (NAT softc) host map size in ip_nat6
calculation. The ipfilter NAT table host map size is a tunable
that defaults to a macro value defined at build time. HOSTMAP_SIZE
is saved in softn (the ipnat softc) at initialization. It can be
tuned (changed) at runtime using the ipf -T command. If the
hostmap_size tunable is adjusted the calculation to determine where
to put new entries in the table was incorrect. Use the tunable in
the NAT softc instead of the static build time value.

(christos)

tests/libcurses: add missing space after control flow keywords

(rillig)

tests/libcurses: replace remaining strcasecmp with strcmp

There is no reason to write special functions in a different case than
the canonical one, just like for the regular curses functions.

(rillig)

tests/libcurses: fix spelling of the special call to DRAIN

(rillig)

tests/libcurses: compare function names case-sensitive

There is absolutely no reason to write function names in upper case or
mixed case.

(rillig)

tests/libcurses: fix scanf parameter for unsigned int

(rillig)

fix build without MULTIPROCESSOR

(ryo)

Zero interrupt handles upon allocation.

Might prevent detach-time bugs.

(jakllsch)

Avoid an extra daif read when dispatching interrupts by using
ENABLE_INTERRUPT() / DISABLE_INTERRUPT() instead of cpsie() / cpsid() macros.

(jakllsch)

Remove a macro that has never been used.

(simonb)

Trailing whitespace, remove extra blank line.

(simonb)

Update function name in a comment.

(isaki)

Protect also audioopen() and audiobellopen() from audiodetach() with
psref(9), as well as others(audioread, audiowrite, etc..).
- Rename audio_file_enter to audio_sc_acquire_fromfile, audio_file_exit
  to audio_sc_release, for clarify.  These are the reference counter for
  this sc.
- Introduce audio_sc_acquire_foropen for audio{,bell}open.
- audio_open needs to examine sc_dying again before inserting it into
  sc_files, in order to keep sc_files consistency.
The race between audiodetach and audioopen is pointed out by riastradh@.
Thank you for many advices.

(isaki)

Make Raspberry PI 3 Model A+ use bwfm config for Model B+

* It works for me.

* It's what linux-firmware does.
  https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/commit/?id=923bfa68a1c97929652f029da699495f4ce43f14

(yamt)

Try improving readability in wrt negations.

Use Nx.  Remove trailing whitespace.  Fix some typos.

(wiz)

Change the lock conditions to call audio_unlink().
This can remove a different copy of audio_exlock_enter() in audio_unlink()
and can use normal one.  Also, in audiodetach(), this can set the exlock
at more natual order (before calling audio_unlink()).
No noticeable functional changes are intended.
Thanks for comments, riastradh@.

(isaki)

Document in poll(2) that poll first appeared in NetBSD in NetBSD 1.3.

(dholland)

typo in previous.

(dholland)

Rework the text of poll(2) for clarity. Bump date.

(dholland)

tests/libcurses: fix off-by-one error in line numbers in diagnostics

I had broken this in testlang_parse.y 1.22 from 2021-02-07, when I
extracted the common 'eol' from the statements.  Extracting 'eol' had
the effect that the action for the statement was run before the line
number increased.

Now the line numbers in the diagnostics are the same again as before.

For lines that end with a backslash, the reported line number is the one
from the last of these lines, not the first one, also as before.  This
feature is not used by any of the current tests though.

(rillig)

Don't define a label twice.

(joerg)

tests/libcurses: use consistent indentation for grammar rules

(rillig)

tests/libcurses: extract functions 'input' and 'noinput' from grammar

(rillig)

tests/libcurses: indent grammar functions consistently

(rillig)

tests/libcurses: declare %type in grammar

It looks as if the original author just didn't know how to declare the
type of non-terminals.  The explicit types in the '$' expressions were
all consistent.

No functional change.

(rillig)

tests/libcurses: extract function 'delay_millis' from the grammar

(rillig)

tests/libcurses: move function 'check' out of the grammar section

This removes the inconsistent indentation.

(rillig)

tests/libcurses: fix typo in license text

(rillig)

Use the same naming scheme for install images as we use for the ISO images.

(martin)

tests/libcurses: remove unused token DRAIN

There is a special function named 'DRAIN', but not a statement.  The
function name does not need its own token.

(rillig)

tests/libcurses: fix sentinel for execl

For systems where NULL is defined as a simple 0 or 0L.

(rillig)

tests/libcurses: on errors, print nonprintable characters as well

(rillig)

Fix typo in comment.

(wiz)

Trailing whitespace

(skrll)

clarify what happens when kill(-1, ...) does nothing

(nia)

Comment out HZ=512.  This was only intended to be enabled for profiling.

(simonb)

Correct the comment at the top of these config files identifying what
they run on.

(simonb)

tests/libcurses: fix undefined behavior in test addch

The libcurses framework is not strictly typed and thus provides plenty
of ways to shoot yourself in the foot.  It's a waste of time debugging
things that a proper programming language can easily prevent.

The function addch expects an argument of type 'chtype'.  Passing a
"double-quoted" string does not match this, as 'chtype' is completely
different from a plain 'char'.  Instead, functions taking a 'chtype'
must be passed a `backtick-quoted` string.

(rillig)

curses_screen.3: fix typo

(rillig)

tests/libcurses: use a single message style for diagnostics

Previously, there were several concurring styles:

$msg in line %zu of file %s
$msg line %zu of file %s
%s, %zu: $msg

All these are now replaced with "%s:%zu: $msg".

(rillig)

Optimize hardware priority updates.

In gicv3_set_priority, read the current priority mask and only update it
if we are lowering the priority. The hardware priority filter is raised
only after taking an interrupt. This makes splfoo/splx without an interrupt
in between considerably cheaper as PMR writes are relatively expensive
compared to reads.

While here, avoid an extra daif read when dispatching interrupts by using
ENABLE_INTERRUPT() / DISABLE_INTERRUPT() instead of cpsie() / cpsid() macros.

(jmcneill)

Use ENABLE_INTERRUPT() / DISABLE_INTERRUPT() instead of cpsie()/cpsid() in
places where we don't care about the cpsie() return value.

(jmcneill)

Add ENABLE_INTERRUPT() / DISABLE_INTERRUPT() macros for compatibility
with aarch64.

(jmcneill)

Use reg_daif{set,clr}_write directly instead of daif_{en,dis}able for
ENABLE_INTERRUPT() and DISABLE_INTERRUPT() macros, to avoid an unnecessary
reg_daif_read().

(jmcneill)

tests/libcurses: make grammar for test cases conflict-free

No functional change.

(rillig)

tests/libcurses: fix grammar for arrays

Previously, commas were completely ignored by the grammar.  Erroring out
on invalid characters made some of the tests fail since the comma was
not recognized anymore.  Add it back, but only for defining arrays.  It
would have been possible to leave out the commas or make them optional,
but since the current tests do not make use of that, keep the grammar as
strict as possible.

Fix an unclosed string literal in a test.  This had been wrongly
accepted before by the grammar.

(rillig)

tests/libcurses: do not allow control characters in paths

(rillig)

tests/libcurses: error out on trying to parse /dev/zero

Be strict when parsing the tests.  Any unknown character is an error.
This avoids an endless loop when running "./director /dev/zero".  There
is no point in silently ignoring other invalid characters as well, as
this would only leave potential test writers in an unclear state,
without any benefit.

(rillig)

tests/libcurses: fix documentation of call[234]

The function getyx is not a function but a macro.  It does not return
int, but void.  Since these changes destroy the simplicity of the
example, combining a regular return value and pass-by-reference return
values, I rewrote the whole section and added more examples.

(rillig)

tests/libcurses: require keywords to be lowercase, except for OK and ERR

There is no need to write the keywords in upper case or mixed case.  The
only case where a keyword did not have the canonical form yet was a
single lowercase 'ok' in the test case 'innstr'.

(rillig)

tests/libcurses: add missing semicolon in grammar

(rillig)

tests/libcurses: fix typo in comment

(rillig)

tests/libcurses: fix expected test output

The test framework doesn't check the files strictly, it only checks
whether the expected output is a prefix of the actual output, or vice
versa.  This allows several deviations to pass unnoticed, which is
wrong.

(rillig)

tests/libcurses: add const to some function parameters

(rillig)

poll.2: fix typo in manual page

(rillig)

tests/libcurses: simplify code for writing to the .exp file

If a write(2) returns less than 1, it must be an error.

(rillig)

tests/libcurses: actually compare the stream to an absolute path

Up to now, the test command "compare /dev/null" was a no-op since the
command was only parsed but not run at all.  Now run it.

This makes the test mvwin fail.  That test will have to be fixed.

Comparing to /dev/null is certainly possible and may make sense,
comparing to /dev/zero is nonsense since the actual stream can never be
endless.  Some tests do that nevertheless, for whatever reason.

In order to have the expected test output closer to the curses commands
that cause it, it may be a good idea to add another command
'compare_str' that would work independently of an external file and at
the same time allow the expected output to be commented and explained.
This is not possible right now since the .chk files are read exactly
as-is.

(rillig)

Ticket #1198

(martin)

Pull up following revision(s) (requested by jdolecek in ticket #1198):

lib/libc/stdio/fread.c: revision 1.24 (via patch)

for unbuffered I/O arrange for the destination buffer to be filled in one
go, instead of triggering long series of 1 byte read(2)s; this speeds up
fread() several order of magnitudes for this case, directly proportional
to the size of the supplied buffer
change adapted from OpenBSD rev. 1.19

fixes PR lib/55808 by Roland Illig

(martin)

tests/libcurses: use more common abbreviations for tokens

(rillig)

tests/libcurses: use standard indentation for grammar rule 'arg'

(rillig)

tests/libcurses: extract grammar rule 'arg'

(rillig)

make: fix typo in comment in test

(rillig)

Note Emulate3Buttons support for X68k Xorg based monolithic server.

(tsutsui)

Build mouseEmu3btn.c for added Emulate3Buttons support.

(tsutsui)

Add "Emulate3Buttons" support to the X68k Xorg based monolithic server.

Based on "Emulate3Buttons" functions in the xf86-input-mouse driver,
with various refactoring and cleanups:
- rewrite a magic three-dimensional array for a finate state machine
  with proper named structures etc.
- separate 3 button emulation functions from other stuff

See my post on port-x68k@ (and tech-x11@) for more details:
https://mail-index.netbsd.org/port-x68k/2021/02/05/msg000074.html

(tsutsui)

Fix entry for ticket #1191

(martin)

Apply additional patch, requested by jdolecek in ticket #1191:

sys/kern/kern_event.c 1.110-1.115 (via patch)

Fix merge botch for the EV_ONESHOT branch.

(martin)

Remove dumb middle button emulation code from the ms(4) driver.

Also fix leftover comments (derived from the original Sun's "firm_event"
implementation as seen in sys/dev/sun/ms.c) to sync with reality on x68k.

The current implementation the ms(4) driver just checks whether
two (left/right) buttons are changed in the same packet.
This means it cannot handle a release event correctly if two
buttons pressed simultaneously are released in the different timing.

The middle button emulation should be handled in application layer
as other Xservers do, and I'll import Emulate3Buttons support for the
X68k Xorg based monolithic server.

See my post on port-x68k@ for details:
https://mail-index.netbsd.org/port-x68k/2021/02/05/msg000074.html

(tsutsui)

restore change from rev 1.23 "Avoid undefined behavior in fread(3)", mistakely
removed as part __SNBF optimization

(jdolecek)

Restore fixes for PR/51663 lost in r1.195 (uvm_hotplug(9) merge).

The kernel crashdump and savecore(8) on NetBSD/x68k have been broken
(even without EXTNEDED_MEMORY) since NetBSD 8.0. Oops.

Should be pulled up to netbsd-9 and netbsd-8.

(tsutsui)

Rename argument "bootspec" to avoid shadowing a global

(martin)

tests/libcurses: error out if called with too many arguments

This helps against users who try to add more options after the first
non-option argument and wonder why these options are silently ignored.

(rillig)

Ticket #1650

(martin)

Pull up following revision(s) (requested by tsutsui in ticket #1650):

usr.sbin/isibootd/isibootd.c: revision 1.4

Fix "Cannot allocate memory" failure on amd64.
BIOCGBLEN ioctl of bpf(4) requires u_int, not size_t.

The problem is reported by Kenji Aoyama.
Should be pulled up to netbsd-9 and netbsd-8.

(martin)

Ticket #1200

(martin)

Pull up following revision(s) (requested by tsutsui in ticket #1200):

usr.sbin/isibootd/isibootd.c: revision 1.4

Fix "Cannot allocate memory" failure on amd64.
BIOCGBLEN ioctl of bpf(4) requires u_int, not size_t.

The problem is reported by Kenji Aoyama.
Should be pulled up to netbsd-9 and netbsd-8.

(martin)

tests/libcurses: document another bug in the test director

(rillig)

tests/libcurses: fix usage of director

(rillig)

tests/libcurses: demonstrate more bugs in addch

(rillig)

tests/libcurses: fail on syntax errors in test files

Previously, a syntax error in a test file made the test pass, which was
outright dangerous.

(rillig)

tests/libcurses: use a single indentation style in the test grammar

The grammar rule 'args' has been left as-is since it needs to be split
into 'args' and 'arg' first, to avoid the redundancy.

The braces in "if (create_check_file)" were misleading.  It's strange that
GCC didn't reject this.

(rillig)

tests/libcurses: clean up test case grammar for statements

Previously, each statement ended with 'eol'.  This was unnecessarily
verbose since the 'eol' is not really part of the statement, it's part
of a line.

No functional change.

(rillig)

tests/libcurses: fix name of grammar rule

A list of assignments is not a statement, it's several statements.

No functional change.

(rillig)

tests/libcurses: unary minus doesn't make sense on bool expressions

No functional change since -1 is as non-zero as 1.

(rillig)

tests/libcurses: allow end-of-line comments in data lines as well

This makes it possible to write small remarks directly in the affected
line, which not only makes for a clean visual appearance but also shows
up prominently in "cvs annotate" or "git blame", showing when such a
remark has been modified.

(rillig)

tests/libcurses: indent lexer code consistently

Several of the braces were misaligned.  For the simple keywords, there
is no need to write these braces at all, they only made the code look
more complicated than it really is.

I stumbled upon this because syntax errors in the test cases currently
let the test case succeed instead of fail, which is another ingredient
for unreliable tests, besides the loose output matching.

(rillig)

Allow MSIX and MSI for interrupt type

(ryoon)

Check for programming errors in _bus_dmamap_load_buffer

(skrll)

pretty print

(skrll)

Consistently use %#x, etc

(skrll)

In virtio_alloc_vq change BUS_DMA_NOWAIT to BUS_DMA_WAITOK.  It's always
called from attach routines.

(skrll)

Trailing whitespace

(skrll)

xhci_pci.c: reimplement XHCI_DISABLE_MSI and XHCI_DISABLE_MSIX

(dbj)

libcurses: demonstrate bug in addch that doubles tab indentation

When adding "\t" via addch, win.curx advances by twice the spaces as
intended.  This bug was introduced somewhere between NetBSD 8.0 and 9.0.

Adding "\t" via addstr does not have this bug.

This bug causes the installation menu of sysinst to be have its menu
items indented by 16 characters instead of only 8.  This in turn
produces an ugly line break in the German translation.

The test framework for libcurses is not well integrated into ATF.
Whenever the expected output is longer than the actual output, or vice
versa, the test passes nevertheless.  This makes it necessary to
constantly look into atf-run.log to see whether the actual output is
indeed equal to the expected output, which is crucial, especially for
telling the difference between addstr and addnstr.

Reusing the .chk files for several tests is not a good idea either.  For
example, addstr and waddstr are supposed to produce the same result for
ASCII-only text, so it was tempting to use the same file.  But waddstr
seems to have a bug (maybe undefined behavior), at least waddstr returns
ERR in one case where it shouldn't.  This means that currently the
expected output (acknowledging the bug) must be different.

The "expected" test output in waddstr.chk looks completely broken, but
that's exactly what the test produces right now.

(rillig)

Drop acorn32 entry, fixed.

(joerg)

Modernize acorn32 boot code to work directly with LLVM's assembler.

(joerg)

make: sync comment for ApplyModifier_Assign with reality

In compat mode, empty shell commands are handled correctly since at
least 1993.

In jobs mode, empty shell commands are handled correctly since at least
job.c 1.93 from 2005-06-16.

The only place where empty shell commands led to problems was in
Cmd_Exec, but that has nothing to do with the example from the comment.
See var-op-shell.mk for more details.

(rillig)

use __builtin_assume_aligned() on places where the memset() or memcpy()
parameters are known to be PAGE_SIZE-aligned, so compiler doesn't need
to emit atrocious alignment check code when inlining them

this particularly improves pmap_zero_page() and pmap_copy_page(),
which are now reduced to only 'rep stosq', and close to what a hand-written
assembly would do

Note: on CPUs supporting ERMS, 'rep stosb' would still be slightly faster, but
this is a solid stop-gap improvement

suggested by Mateusz Guzik in:
http://mail-index.netbsd.org/tech-kern/2020/07/19/msg026620.html

(jdolecek)

Expose devhandle_t to standalone programs (fixes sparc* build etc)

(christos)

libcurses: fix typos in introduction to the curses test framework

(rillig)

libcurses: fix spelling in comment

(rillig)

Run all make tests as unprileged user - makes checking permission issues
a lot easier.

(martin)

Avoid test failures when more than one user run them.

Use a private  TMPDIR
a subdir of .OBJDIR if using it
otherwise /tmp/uid${.MAKE.UID}

(sjg)

tools: allow MKCROSSGDB to work when not building gcc

(dbj)

Wrap some definite-only-in-kernel-environment prototypees in _KERNEL.

(thorpej)