lint: demonstrate wrong 124 due to bug in is_typeok_eq

(rillig)

lint: fix local variable names in check_pointer_comparison

(rillig)

lint: clean up typeok_eq and check_pointer_comparison

Since typeok_eq does not issue any diagnostics, prefix it with "is_".

By convention, the variable rt aliases rn->tn_type->t_tspec.  Make it
obvious that in check_pointer_comparison, rt corresponds to the subtype
of the pointer.

(rillig)

lint: document bug in typeok_eq

Since rt is an alias for rn->tn_type->t_tspec, it cannot be PTR and VOID
at the same time.  This makes the condition unsatisfiable.  Removing
that part of the code didn't show any change in behavior, as expected.

It may even be that fixing this obvious bug doesn't show any change in
behavior since that function is only used in a single place and
check_pointer_comparison performs its own checks before issuing any
warning.

At least the test cases added to msg_124.c all run as expected.

(rillig)

lint: fix build on Cygwin

Cygwin does not conform to C99, which says that MB_CUR_MAX has type
size_t.

Instead, Cygwin defines it as type int.  This leads to compile errors
because comparing signed with unsigned expressions is surprising in C.

(rillig)

lint: expand abbreviations in lexer function names

No functional change.

(rillig)

lint: improve introduction of test d_c99_bool_strict_syshdr

(rillig)

lint: explain why !finite(x) is not allowed in strict bool mode

(rillig)

avoid using 'extern <func|data>;' inside a .c file, but instead
use header files and ensure definitions are not duplicated or
are technically (if not in codegen) wrong.

(mrg)

Use temperature sensors as rnd(9) sources.

(rin)

Add rnd(9) support.

(rin)

Add rnd(9) support.

(rin)

Add rnd(9) support.

(rin)

Switch to if_percpuq_enqueue() from if_input().

(rin)

Add a comment explaining why bus_space_write_8 is limited to virtio.

(christos)

lint: update data types in comments from int to bool

(rillig)

fix the build

(christos)

fix the build

(christos)

lint: apply strict bool mode to lex.c

There are 2 remaining expressions:

In line 244, !(kw->kw_deco & deco) is a bitwise and.  This is already
allowed for enums, it needs to be allowed for arbitrary integer
expressions as well.  This covers the many places where plain integers
are used for bit fields, together with #define.  This pattern is not as
typesafe as using enums, still it is common practice.

In line 769, the expression !finite(f) is a legitimate use of a function
that has return type int for traditional reasons.  It's the same as for
ferror.

There are several other functions like unlink, open or strcmp that have
return type int as well, but with a different meaning.  It is not yet
clear what the best way is to handle these different meanings.  Having
to write finite(f) == 0 in strict bool mode doesn't look idiomatic, on
the other hand, !strcmp(s1, s2) is exactly the pattern that strict bool
mode wants to avoid.

(rillig)

lint: fix error message for relaxed bool operations in system headers

In strict mode, allowing 1 as bool constant expression is probably not
needed in practice since most comparisons are != 0 instead of == 0.

Furthermore, in the expression (flags & 0x0002) == true, comparing with
true is misleading since the '==' operator can never evaluate to true in
this case.

(rillig)

Add __HAVE_BUS_SPACE_8

(jmcneill)

lint: fix two wrong error messages in strict bool mode

The strict bool mode gets complicated because for system headers the
rules need to be relaxed since they cannot be changed easily, often not at all.

Still, if lint validates a program in strict bool mode, that program
must run with equal behavior regarding boolean expressions even on a
pre-C99 platform.

(rillig)

Provide a generic bus_space_write_8 function that is bi-endian.

(christos)

Fix building in the _STANDALONE case.

(thorpej)

Document via __HAVE_BUS_SPACE_8 platforms that implement bus_space_*_8

(christos)

Remove cargo-culted '#if 0' code that was designed to produce a
compile-time error if any of the bus_space_*_8 functions was used,
but was documented that it produces a link-time error.

(christos)

lint: extend test for strict bool mode and system headers

(rillig)

lint: clean up comments and variable names in lex.c

(rillig)

lint: move lexer code from scan.l to lex.c

Previously, the generated scan.c was not included when running "make
lint".  Similarly, cgram.c is still not included.

(rillig)

threadpool(9): Fix synchronization between cancel and dispatch.

- threadpool_cancel_job_async tried to prevent
  threadpool_dispatcher_thread from taking the job by setting
  job->job_thread = NULL and then removing the job from the queue.

- But threadpool_cancel_job_async didn't notice job->job_thread is
  null until after it also removes the job from the queue =>
  double-remove, *boom*.

The solution is to teach threadpool_dispatcher_thread to wait until
it has acquired the job lock to test whether job->job_thread is still
valid before it decides to remove the job from the queue.

Fixes PR kern/55948.

XXX pullup-9

(riastradh)

Remove leftover of #undef statements.

These should have been removed in rev 1.55 back in 2010:
https://mail-index.netbsd.org/source-changes/2010/12/20/msg016105.html
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/arch/news68k/news68k/locore.s.diff?r1=1.54&r2=1.55

(tsutsui)

Fix "no output of xdpyinfo(1) on redirect or pipe" problem.

XF86cleanup() in libXxf86dga invoked via atexit(3)
(or __attribute__((__destructor__)) in NetBSD xsrc)
calls _exit(2) directly so fflush(3) via normal exit(3)
is not called.  Analyzed by rin@, ryo@, and soda@:
https://mail-index.netbsd.org/tech-x11/2021/01/20/msg002192.html

Should be pulled up to netbsd-9.

XXX1: The original XF86cleanup() is not async-signale-safe.
XXX2: XF86DGAGetVideo() implicitly overrides signal handlers.

(tsutsui)

Ticket #1186

(martin)

Pull up following revision(s) (requested by jmcneill in ticket #1186):

sys/dev/pci/if_ena.c: revision 1.27

PR kern/55942: destroyed ena(4) evcnts cause panic

Fix event counter teardown code. From KUSABA Takeshi

(martin)

vcaudio: don't advertise CAPTURE when all functions return EINVAL

(nia)

make(1): split Dir_FindFile into separate functions

(rillig)

make(1): rename local variable in FindCmds

(rillig)

fit in 80 columns

(jmcneill)

make(1): remove the remaining beasts from the comments

(rillig)

make(1): improve variable names when parsing directives

(rillig)

kern/55942: destroyed ena(4) evcnts cause panic

Fix event counter teardown code. From KUSABA Takeshi <t-kusaba@iij.ad.jp>

(jmcneill)

make(1): extend comments in dir.c

(rillig)

make(1): rename Dir_AddDir, reorder parameters of SearchPath_ToFlags

(rillig)

make(1): extract SearchPath_ExpandMiddle from SearchPath_Expand

(rillig)

make(1): split local variable in SearchPath_Expand

(rillig)

make(1): rename parameter of SearchPath_Expand

(rillig)

make(1): rename Dir_Expand to SearchPath_Expand

The main subject of this function is the search path.  In this search
path the pattern is expanded.

(rillig)

make(1): fix unit tests for dash and bash 5.1

(rillig)

make(1): remove outdated comment from test

It was fixed in var.c 1.472 from 2020-08-25.

(rillig)

for the busypage test, replace atf_tc_expect_fail() with atf_tc_skip()
because atf apparently has no way to expect a test program to crash.
fixes PR 55945.

(chs)

make(1): fix test for .INCLUDEDFROMFILE

The test did not test the intended variable before.

If the implementation of the .INCLUDEDFROMFILE had been wrong before,
the test would have succeeded nevertheless since it tested whether the
variable named "include-main.mk" was defined, which was obviously never
the case since that's the value of the variable, not the name.

(rillig)

make(1): remove "warning" from missing closing parenthesis

This only affects the diagnostics for parse errors that involve a
missing closing parenthesis.  Whether or not this is a parse error is
still the same.

It may look redundant to pass both the CondParser and the parsing
position pp to the functions, but that's necessary since during parsing,
not every code path updates the main parsing position immediately.

(rillig)

make(1): replace warning + error with just an error in conditionals

Before, there was a "warning" for comparing strings using '<', which was
wrong.  That warning was then followed by an error, after parsing the
whole conditional.  This was only because it was easier to implement.

Replace the warning with an actual error.  This only affects
conditionals in .if lines, the conditionals in the :? modifier such as
${"A" < "B":?smaller:greater} still print 2 errors.

(rillig)

make(1): fix debug output for comparison operators in conditionals

This produces fewer warnings than before, but these were edge cases that
probably didn't matter in practice.  The "Malformaed conditional" is
still generated, the set of accepted conditionals is still the same.

(rillig)

make(1): document wrong debug output in evaluation of conditionals

(rillig)

make(1): add tests for string literals in .ifdef

(rillig)

make(1): reformat CondParser_StringExpr

(rillig)

introduce a putchar() based implementation of cursor() in order to avoid
framebuffer reads
quite a speedup on arm64 / genfb

(macallan)

Remove dependency on bus_space_write_8() for i386 and instead implement it as
two bus_space_write_4()'s as allowed in the spec.

(reinoud)

remove stray debug #define DEBUG

(jdolecek)

adjust kq_check() (enabled with DEBUG) to new reality - it's now perfectly
normal to have kq_count bigger than number of the linked entries
on the kqueue

PR kern/50094, problem pointed out by Chuck Silvers

(jdolecek)

Add SRTP (Secure Real-time Transport Protocol)

(kamil)

Add RTP (Real-time Transport Protocol)

(kamil)

Add PBX (private branch exchange)

(kamil)

add vcaudio (intentionally this time)

gives working audio output on rpi3 without needing to run a 32-bit image.

(nia)

entropy: Reduce `no seed from bootloader' message to debug level.

This does not necessarily indicate a problem -- only x86 and arm pass
a seed from the bootloader anyway -- so it makes for an always-on
warning on some platforms, including all rump kernels, which is not
helpful.

(riastradh)

Quote minus.

(wiz)

Use Nm instead of xref to itself. Fix typo.

(wiz)

Add a manual page for strlist(9).

(thorpej)

Allow this to be built for the strlist.c unit tests.

(thorpej)

Add a generic set of routines for interacting with OpenFirmware-style
string lists.

(thorpej)

make(1): merge duplicate code in Parse_MainName

(rillig)

make(1): extract CondParser_StringExpr from CondParser_String

(rillig)

make(1): demonstrate parse error without error message in conditional

(rillig)

make(1): add test case for bare word containing quotes

(rillig)

make(1): make CondParser_String simpler

No functional change.

(rillig)

make(1): add more tests for edge cases in conditionals

(rillig)

make(1): fix Coverity annotation

FStr is not an allocated data type.

(rillig)

PRIxXXXX (etc) definitions should not include the %

Will fix anything this ends up breaking later.

(kre)

Use PRIxBUSSIZE to print a bus_size_t value.

(martin)

remove accidental additions

(nia)

add a commented out compat_ossaudio wherever there's compat_linux

requested by mrg

(nia)

remove "no options" for compat_ossaudio now it's disabled by default

(nia)

Use .set noreorder and use reg names.

atf- lib/libc/sys/t_mprotect mprotect_mremap_exec is a bit happier now.

(simonb)

make(1): add more tests for tokens in conditionals

(rillig)

fix free_all_endpoints() to not try calling free_pipe() when no endpoints
are allocated; this can happen during config_detach() after attach fails

Reported-by: syzbot+6e8a4c978358ecead03e@syzkaller.appspotmail.com
Reported-by: syzbot+b25ba25b57561144ac6e@syzkaller.appspotmail.com

(jdolecek)

Remove the virtio child driver finalisation check KASSERT that, while it
should never trigger, a possible bug in a child driver shouldn't have to panic
the kernel. Instead report the internal error.

(reinoud)

fix a race in kqueue_scan() - when multiple threads check the same
kqueue, it could happen other thread seen empty kqueue while kevent
was being checked for re-firing and re-queued

make sure to keep retrying if there are outstanding kevents even
if no kevent is found on first pass through the queue, and only
drop the KN_QUEUED flag and kq_count when actually completely done
with the kevent

change is inspired by the FreeBSD in-flux handling, but without
introducing the reference counting

PR kern/50094 by Christof Meerwald

(jdolecek)

COMPAT_OSSAUDIO no longer exists; remove dangling reference

(pgoyette)

Add VirtIO PCI v1.0 attachments and fix the drivers affected.

The vioif, ld, scsi, viornd and viomb devices were adjusted when needed and
tested both in legacy 0.9 and v1.0 attachments trough PCI on amd64, sparc64,
aarch64 and aarch64-eb. ACPI/FDT attachments also tested on
aarch64/aarch64-eb.

Known issues

* viomb on aarch64 works only with ACPI/FDT attachment but not with PCI
  attachment. PCI and ACPI/FDT attachment works on aarch64-eb.

* virtio on sparc64 attaches but is it not functioning though not a
  regression.

(reinoud)

Sync with OpenBSD if_rge.c r1.4

"""
Change users of IFQ_SET_MAXLEN() and IFQ_IS_EMPTY() to use the "new" API.
"""

(jakllsch)

Consistently use ACPI_SIG_SSDT

(skrll)

remove compat_ossaudio from kernel modules

this is only useful with compat_linux and gets autoloaded when
compat_linux is loaded, so there's no reason to bake it into kernels
any more.

(nia)

if_tap was made mpsafe in revision 1.102

(nia)

The max number of queue(pair) is not 7 but 8. Inspired by DPDK.

(msaitoh)

do not enable kernel OSS compat in configs without compat_linux

perhaps kernel OSS compat can be merged into compat_linux to avoid
further confusion

(nia)

Fix previous; of_search_compatible returns the sentinel when there is no
match, so we need to test ->data for NULL, not the return value.

(jmcneill)

update comment to match new reality

(jmcneill)

make(1): extract DetermineKindOfConditional from Cond_EvalLine

(rillig)

make(1): remove struct If from evaluation of conditionals

The variant of the .if directive can be stored in the CondParser
directly, instead of pointing to a struct If.

The type CondParser may have to be renamed since the condition is not
only parsed, it is evaluated as well.

No functional change.

(rillig)

make(1): remove do-not-format markers from comments

These markers had been used inconsistently.  Furthermore the source code
had not been formatted automatically before 2020 at all, otherwise there
wouldn't have been any trailing whitespace left.

(rillig)

make(1): add test for unsupported relational string comparisons

(rillig)

make(1): distinguish between tokens and results in conditionals

No functional change.

(rillig)

make(1): update references to the renamed CondParser functions

(rillig)

make(1): condense code for parsing and evaluating conditionals

(rillig)

make(1): add error handling for edge case in malformed conditions

(rillig)

make(1): demonstrate missing error handling for malformed conditions

(rillig)

make(1): fix possible return values for CondParser_Term

The invalid return values didn't do any harm since CondParser_Factor and
CondParser_Expr passed them through, and CondParser_Eval carefully
checks for TOK_TRUE or TOK_FALSE and treats everything else as an error.

No change in observable behavior since there is no debug logging in that
part of the code.

(rillig)

make(1): demonstrate wrong return value in CondParser_Term

(rillig)

of_compatible() is a hokey API (returning -1 for no match) and nothing
here relies on its reverse-index return value semantics, so just use
of_match_compat_data() instead.

(thorpej)

Use device_compatible_entry / of_search_compatible() for the child
nodes rather than using of_compatible() to match against different
sets of compatible strings.

(thorpej)

Fix syntax error

(wiz)

make(1): normalize shell error messages in tests

Newly supported is bash, which outputs "bash: line 123".

(rillig)

make(1): fix tests for :gmtime and :localtime for 32-bit time_t

The comparison operator had accidentally been '!=' instead of '=='.

While here, proofread the documentation and add references for where the
32-bit time_t is defined on Linux and FreeBSD.

(rillig)

Add note about enabling TPM and rnd(4) source.

(riastradh)

The read/write/send/recv system calls return ssize_t because -1 is
returned on error.  Therefore we must restrict the lengths of any
buffers to NETBSD32_SSIZE_MAX with compat32 to avoid garbage return
values.

Fixes ATF lib/libc/sys/t_write:write_err.

(simonb)

Use device_compatible_entry / of_search_compatible() to match the clock
type rather than calling of_compatible() on different sets of compatible
strings.

(thorpej)

KNF consistency: No parentheses are needed around the return value.

(simonb)

Whitespace nits.

(simonb)

Also print mmap return value and error code #ifdef DEBUG_MMAP.

(simonb)

Use device_compatible_entry / of_search_compatible() for the GICv3
quirk table.

(thorpej)

Use device_compatible_entry / of_search_compatible() rather than
matching against multiple sets of compatibility strings.

(thorpej)

Use device_compatible_entry / of_search_compatible() rather than
matching against multiple sets of compatinbility strings.

(thorpej)

Use device_compatible_entry / of_search_compatible() rather than matching
against multiple sets of compatibility strings.

(thorpej)

Fix a comment

(jmcneill)

s/u_intN_t/uintN_t/

(simonb)

lint: clean up code (mostly comments)

(rillig)

lint: clean up member names of control_structure and comments

(rillig)

lint: flatten check_global_variable_size

(rillig)

lint: rename grammar rule lorange

It looked too much like an orange.

(rillig)

lint: rename grammar rules to align with C99 6.7.6

(rillig)

lint: fix precedence of __builtin_offsetof

A previous version of the C grammar contained TBUILTIN_SIZEOF in this
place, which had two typos.  Therefore it was handled as a separate
token that was otherwise ignored.  Curiously, bison didn't warn about
this obvious inconsistency.

(rillig)

lint: sort tokens in grammar

(rillig)

lint: rename T_SOU to T_STRUCT_OR_UNION

This abbreviation occurred too seldom to be used.

(rillig)

lint: don't treat restrict and _Thread_local as volatile anymore

(rillig)

lint: fix assertion failure for restrict and _Thread_local

(rillig)

lint: add more test cases for duplicate type qualifiers

(rillig)

lint: align token names with the wording from C99

(rillig)

lint: remove redundant operators from lexer

Several tokens correspond to exactly one operator.  For these tokens,
the operator is never accessed, therefore it is confusing to associate
it with the token.

(rillig)

lint: replace abort with lint_assert

(rillig)

lint: expand abbreviations in function names

(rillig)

lint: rename T_ELLIPSE to T_ELLIPSIS

The 3 dots have nothing to do with geometry.

(rillig)

lint: rename T_STROP to T_MEMBACC

The 'STR' was misleading since it is the abbreviation for 'string' in
many other programs.  Member access not only happens in structs, it also
happens in unions.

(rillig)

NetBSD 9.99.78 -- signature of device_compatible_match() changed.

(thorpej)

Change the device_compatible_match() function to only perform the match.
Introduce a device_compatible_lookup() function to return an entry based
on the same matching criteria (a'la of_search_compatible()).

Update iic_compatible_match() to reflect the above change, and introduce
iic_compatible_lookup().  This pattern is less awkward to use.

(thorpej)

Trailing whitespace

(skrll)

Fix ixg(4) Rx interrupt stall when Rx buffers are exhausted.

Current ixgbe_rxeof() implementation calls ixgbe_refresh_mbufs()(and
ixgbe_getjcl()) after ixgbe_rx_input()(and if_percpuq_enqueue()).
And ixg(4) uses its own m_ext structure.  That causes Rx interrupt
stall when Rx buffers are exhausted.  e.g. TCP iperf3 with large
windows size.  Furthermore, Rx descriptor problem has occurred
after stoppping the load.

To fix that problem, ixgbe_rxeof() must call ixgbe_getjcl() before
ixgbe_rx_input(), and must discard the new packet when ixgbe_getjcl()
fails.

By the way, ixg(4) should use MCLGET() instead of own m_ext structure.

ok'ed by msaitoh@n.o, thanks.

(knakahara)