Link [ NetBSD | NetBSD OpenGrok source search | PR fulltext-search | Summary of daily snapshot builds | history of daily build result | pkgsrc commit viewer ]


   
        usage: [branch:branch] [user:user] [path@revision] keyword [... [-excludekeyword [...]]] (e.g. branch:MAIN sys/arch/arm, if_wm.c@1.234 )




switch to index mode

recent branches: MAIN (50m)  netbsd-8 (5d)  netbsd-10 (5d)  netbsd-9 (11d)  thorpej-ifq (175d)  thorpej-altq-separation (178d) 

2024-05-10 04:20:38 UTC Now

2020-11-28 14:08:38 UTC MAIN commitmail json YAML

make(1): move test for recursive variable to cond-func-empty

Previously, the documentation of that test was much too short to explain
all the effects that happened in the bug situation from 2020-06-28 until
2020-07-02.

(rillig)

2020-11-28 14:02:30 UTC MAIN commitmail json YAML

2020-11-28 14:02:09 UTC MAIN commitmail json YAML

Add a hook for MD specific info to print in the "ver" command. Use this
to print the value of the current execution level in bootaa64.

(jmcneill)

2020-11-28 13:05:58 UTC MAIN commitmail json YAML

Make sure the kernel set is selected, even if extracting parts of it
manually.

(jmcneill)

2020-11-28 10:28:53 UTC MAIN commitmail json YAML

make(1): rename parameter in meta_needed and meta_create

It conflicts with the global variable in dir.c when make is built in
all-in-one mode.

(rillig)

2020-11-28 10:25:45 UTC MAIN commitmail json YAML

make(1): fix local variable name in meta_create

(rillig)

2020-11-28 10:09:28 UTC MAIN commitmail json YAML

make(1): rename local variable in ModifyWord_Root

The name 'dot' conflicted with the global variable from dir.c when make
was compiled in all-in-one mode.

(rillig)

2020-11-28 10:07:26 UTC MAIN commitmail json YAML

make(1): rename local variable in ModifyWord_Suffix

It conflicted with 'dot' from dir.c.

(rillig)

2020-11-28 10:05:49 UTC MAIN commitmail json YAML

make(1): rename local variable in ParseFindKeyword

It conflicts with the global 'cur'.

(rillig)

2020-11-28 10:00:25 UTC MAIN commitmail json YAML

make(1): rename local variable in Cmd_Exec

It conflicts with the global fds in job.c.

(rillig)

2020-11-28 09:45:01 UTC MAIN commitmail json YAML

make(1): allow multiple RCS IDs in all-in-one mode

(rillig)

2020-11-28 08:41:53 UTC MAIN commitmail json YAML

make(1): add multiple-inclusion guard for trace.h

Needed for all-in-one mode since this header is included 3 times.

(rillig)

2020-11-28 08:40:05 UTC MAIN commitmail json YAML

make(1): rename conflicting global variables called 'error'

When compiling make in all-in-one mode, these variable names conflict.
They could have been merged into a single variable, but that would have
required to make it a global variable for the other modules as well.
The parse module has a similar variable called 'fatals'.  All these can
possibly be merged into a single variable, but not now.

(rillig)

2020-11-28 08:31:41 UTC MAIN commitmail json YAML

make(1): rename global variables in job.c

When compiling make in all-in-one mode, the variable name nfds conflicts
with the local variable name nfds in meta_compat_parent.

The variable name jobfds was misleading.  It has nothing to do with file
descriptors, it's just an array of jobs.

(rillig)

2020-11-28 05:16:07 UTC MAIN commitmail json YAML

Try to shrink ramdiskbin binary.

-Os
-rwxr-xr-x  1 tsutsui  wheel  1371212 Nov 28 14:09 obj.dreamcast/ramdiskbin*

-Os -fno-unwind-tables
-rwxr-xr-x  1 tsutsui  wheel  1366000 Nov 28 14:10 obj.dreamcast/ramdiskbin*

-Os -fno-unwind-tables -DNDEBUG
-rwxr-xr-x  1 tsutsui  wheel  1359700 Nov 28 14:11 obj.dreamcast/ramdiskbin*

(tsutsui)

2020-11-27 22:32:43 UTC MAIN commitmail json YAML

uvm_mremap: reference the appropriate backing object.

The previous approach was appropriate for anonymous
memory and device objects, which continue to work in
the same way.

OK: chs@
Fixes: PR 55237

(yhardy)

2020-11-27 20:11:33 UTC MAIN commitmail json YAML

ipi: Membar audit.

(riastradh)

2020-11-27 20:10:25 UTC MAIN commitmail json YAML

tprof: Use percpu rather than a MAXCPUS-element array.

(riastradh)

2020-11-27 17:01:18 UTC MAIN commitmail json YAML

2020-11-27 16:58:33 UTC MAIN commitmail json YAML

src/sys/external/bsd/acpica/dist/compiler/aslcompiler.l@1.18 / diff / nxr@1.18
src/sys/external/bsd/acpica/dist/compiler/aslload.c@1.20 / diff / nxr@1.20
src/sys/external/bsd/acpica/dist/compiler/aslopcodes.c@1.13 / diff / nxr@1.13
src/sys/external/bsd/acpica/dist/compiler/aslprepkg.c@1.14 / diff / nxr@1.14
src/sys/external/bsd/acpica/dist/compiler/aslutils.c@1.27 / diff / nxr@1.27
src/sys/external/bsd/acpica/dist/compiler/aslxref.c@1.20 / diff / nxr@1.20
src/sys/external/bsd/acpica/dist/debugger/dbexec.c@1.18 / diff / nxr@1.18
src/sys/external/bsd/acpica/dist/debugger/dbinput.c@1.23 / diff / nxr@1.23
src/sys/external/bsd/acpica/dist/debugger/dbmethod.c@1.16 / diff / nxr@1.16
src/sys/external/bsd/acpica/dist/disassembler/dmbuffer.c@1.13 / diff / nxr@1.13
src/sys/external/bsd/acpica/dist/disassembler/dmcstyle.c@1.12 / diff / nxr@1.12
src/sys/external/bsd/acpica/dist/events/evregion.c@1.12 / diff / nxr@1.12
src/sys/external/bsd/acpica/dist/events/evrgnini.c@1.17 / diff / nxr@1.17
src/sys/external/bsd/acpica/dist/include/acdebug.h@1.18 / diff / nxr@1.18
src/sys/external/bsd/acpica/dist/include/acexcep.h@1.14 / diff / nxr@1.14
src/sys/external/bsd/acpica/dist/include/acpixf.h@1.28 / diff / nxr@1.28
src/sys/external/bsd/acpica/dist/include/actbl1.h@1.16 / diff / nxr@1.16
src/sys/external/bsd/acpica/dist/include/actypes.h@1.23 / diff / nxr@1.23
src/sys/external/bsd/acpica/dist/namespace/nsrepair2.c@1.16 / diff / nxr@1.16
src/sys/external/bsd/acpica/dist/os_specific/service_layers/oslinuxtbl.c@1.13 / diff / nxr@1.13

merge conflicts

(christos)

2020-11-27 16:50:02 UTC MAIN commitmail json YAML

map enough space for both the page we write and the guard so that we make
sure we own the guard page before we set its protection to none. This fixes
random SEGVs where the page we set protection to none probably belonged to
the dynamic linker. Reported by gson@

(christos)

2020-11-27 16:42:00 UTC MAIN commitmail json YAML

Refine the documentation

Sort includes.
Correct the historical note, pipe first appeared in AT&T UNIX v3.
Document ENOMEM.

(kamil)

2020-11-27 15:37:06 UTC MAIN commitmail json YAML

delete trailing whitespace

(gson)

2020-11-27 14:43:57 UTC MAIN commitmail json YAML

make the order of the arguments in the PTYFS_FILENO macro consistent with
the order in the function calls. One of them was incorrect. Noticed by martin@

(christos)

2020-11-27 08:39:07 UTC MAIN commitmail json YAML

make(1): clean up after a successful .META test

(rillig)

2020-11-27 08:36:11 UTC MAIN commitmail json YAML

make(1): add very basic test about meta mode

This test is just meant to cover the existing code, it still needs to be
cleaned up to serve as a tutorial and to highlight the really
interesting points.

(rillig)

2020-11-27 08:18:14 UTC MAIN commitmail json YAML

make(1): inline meta_file_t for printCMD

This struct had only been necessary as long as printCMD was a callback
to Lst_ForEach or Lst_ForEachUntil.

(rillig)

2020-11-27 08:07:27 UTC MAIN commitmail json YAML

make(1): inline Lst_ForEachUntil in meta mode

This means no more unnecessary void pointers in function signatures and
no more abstraction level at checking a single element of a list.  In
most cases it is more appropriate to define a function that operates on
the list as a whole, thereby hiding implementation details like the
ListNode from the caller.

(rillig)

2020-11-27 07:11:49 UTC MAIN commitmail json YAML

cpu_hatched_p does necessary memory barrier so remove membar_consumer
calls from before cpu_hatched_p calls.

(skrll)

2020-11-27 03:37:11 UTC MAIN commitmail json YAML

Fix missing disable of kpreempt while getting interface address

(yamaguchi)

2020-11-26 23:13:55 UTC MAIN commitmail json YAML

fix typo in manual page for strchrnul(3)

(rillig)

2020-11-26 22:51:35 UTC MAIN commitmail json YAML

src/external/bsd/elftoolchain/dist/libdwarf/dwarf.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_comp_dir.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_const_value_string.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_dataref.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_flag.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_location_expr.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_name.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_producer.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_ref_address.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_reference.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_signed_const.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_string.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_AT_targ_address.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_arange.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_die_to_debug.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_directory_decl.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_expr_addr.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_expr_gen.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_fde_inst.3@1.4 / diff / nxr@1.4
src/external/bsd/elftoolchain/dist/libdwarf/dwarf_add_file_decl.3@1.4 / diff / nxr@1.4
      :
(more 106 files)
Sync libdwarf's manual pages with upstream.

(jkoshy)

2020-11-26 21:52:00 UTC MAIN commitmail json YAML

2020-11-26 21:01:47 UTC MAIN commitmail json YAML

Restore an overlooked 'Id' line.

(jkoshy)

2020-11-26 20:50:45 UTC MAIN commitmail json YAML

make the max text size the same as the max data size

(christos)

2020-11-26 12:56:35 UTC MAIN commitmail json YAML

2020-11-26 12:53:03 UTC MAIN commitmail json YAML

Fix build and improve error handling

(skrll)

2020-11-26 08:37:54 UTC MAIN commitmail json YAML

Style around setting the physical memory limit.  NFCI.

(skrll)

2020-11-26 08:29:17 UTC MAIN commitmail json YAML

2020-11-26 08:25:01 UTC MAIN commitmail json YAML

Mark KASAN shadow pages as LX_BLKPAG_ATTR_NORMAL_WB.  NFC as this is zero,
but someone might change it one day.

(skrll)

2020-11-26 02:06:01 UTC MAIN commitmail json YAML

Add missing newlines to ACL prints in tunefs; from Jan Schaumann in PR 55824.

(dholland)

2020-11-25 21:40:22 UTC MAIN commitmail json YAML

Simplify default motd text and include donation link.

(riastradh)

2020-11-25 21:08:59 UTC MAIN commitmail json YAML

Define LMSG outside the MAXTSIZ check so it also exists in non-MAXTSIZ kernels.

(wiz)

2020-11-25 21:02:35 UTC MAIN commitmail json YAML

Add support for message-based interrupts.

(jmcneill)

2020-11-25 20:59:20 UTC MAIN commitmail json YAML

Fix off-by-one when printing the range of SPIs in a GICv2m frame

(jmcneill)

2020-11-25 19:50:06 UTC MAIN commitmail json YAML

Fix comment.  Spotted by jmcneill@

(skrll)

2020-11-25 18:11:00 UTC MAIN commitmail json YAML

2020-11-25 16:42:53 UTC MAIN commitmail json YAML

2020-11-25 16:41:39 UTC MAIN commitmail json YAML

Fix ldap: ldap_sasl_bind_s() doens't like a NULL struct berval *, pass
a pointer to a zero'd struct instead.
While there use LDAP_SASL_SIMPLE instead of NULL for mechanism,
and check return of ldap_set_option().

(bouyer)

2020-11-25 15:31:15 UTC MAIN commitmail json YAML

2020-11-25 15:14:04 UTC MAIN commitmail json YAML

Create wd0 and wd1 device node for G1IDE kernel.

(tsutsui)

2020-11-25 14:15:41 UTC MAIN commitmail json YAML

2020-11-25 10:57:11 UTC MAIN commitmail json YAML

Fix address advancing for i386 and other 32-bit platforms.
Makes racoon grok IPv6 addresses again on these platforms.

(kardel)

2020-11-25 10:44:53 UTC MAIN commitmail json YAML

add KASSERT(!cpu_softintr_p());

pointed out by knakahara@n.o., thanks.

(yamaguchi)

2020-11-25 10:42:35 UTC MAIN commitmail json YAML

Fix to reconnect after PADT received

(yamaguchi)

2020-11-25 10:39:47 UTC MAIN commitmail json YAML

add a logging function used at debugging pppoe(4)

(yamaguchi)

2020-11-25 10:38:10 UTC MAIN commitmail json YAML

fix to remove trailing garbage

(yamaguchi)

2020-11-25 10:37:04 UTC MAIN commitmail json YAML

stop callout even when the state is in PPPOE_STATE_INITIAL

(yamaguchi)

2020-11-25 10:35:07 UTC MAIN commitmail json YAML

Use a state of IPCP and IPv6CP to wait for connection established

(yamaguchi)

2020-11-25 10:32:54 UTC MAIN commitmail json YAML

add -dd option for reference of the parameter about control protocols

reviewed by knakahara@n.o.

(yamaguchi)

2020-11-25 10:30:51 UTC MAIN commitmail json YAML

Add commands to refer params of control protocols in if_spppsubr.c

reviewed by knakahara@n.o.

(yamaguchi)

2020-11-25 10:27:18 UTC MAIN commitmail json YAML

Reconnect when a down event caused by tlf caught

(yamaguchi)

2020-11-25 10:25:22 UTC MAIN commitmail json YAML

Move code related to module to bottom

(yamaguchi)

2020-11-25 10:23:33 UTC MAIN commitmail json YAML

Reconnect lcp after authentication or network phase finish

(yamaguchi)

2020-11-25 10:18:50 UTC MAIN commitmail json YAML

Close lcp when the lower layer down if the interface is passive or on-demand

reivewed by knakahara@n.o.

(yamaguchi)

2020-11-25 10:12:04 UTC MAIN commitmail json YAML

Update ip addresses in the workqueue for control protocols

reviewed by knakahara@n.o.

(yamaguchi)

2020-11-25 10:08:22 UTC MAIN commitmail json YAML

Add the id check for TERM_ACK

(yamaguchi)

2020-11-25 10:05:40 UTC MAIN commitmail json YAML

remove double newlines

(yamaguchi)

2020-11-25 10:03:39 UTC MAIN commitmail json YAML

change function name(RCR => parse_confreq)

reviewed by knakahara@n.o.

(yamaguchi)

2020-11-25 09:59:52 UTC MAIN commitmail json YAML

Add a function to initialize parameters

(yamaguchi)

2020-11-25 09:57:26 UTC MAIN commitmail json YAML

Remove unused and unimplemented code related to CP_QUAL

(yamaguchi)

2020-11-25 09:55:02 UTC MAIN commitmail json YAML

Simplify commonly used functions

reviewed by knakahara@n.o.

(yamaguchi)

2020-11-25 09:46:05 UTC MAIN commitmail json YAML

implement auth protocols on the state-machine of control protocols

reviewed by knakahara@n.o.

(yamaguchi)

2020-11-25 09:41:20 UTC MAIN commitmail json YAML

Insert an entry after initialization

(yamaguchi)

2020-11-25 09:38:39 UTC MAIN commitmail json YAML

call if_down() in workqueue instead of callout(9)

(yamaguchi)

2020-11-25 09:35:24 UTC MAIN commitmail json YAML

Change a state of control protocol in thread context

reviewed by knakahara@n.o.

(yamaguchi)

2020-11-25 09:30:49 UTC MAIN commitmail json YAML

Add a function for RXJ event

(yamaguchi)

2020-11-25 09:26:34 UTC MAIN commitmail json YAML

Add a function for RTR and RTA event

(yamaguchi)

2020-11-25 09:21:53 UTC MAIN commitmail json YAML

Add a function for RCA and RCN event

(yamaguchi)

2020-11-25 09:18:45 UTC MAIN commitmail json YAML

2020-11-25 09:16:20 UTC MAIN commitmail json YAML

Refactoring functions for RCR and RCN

(yamaguchi)

2020-11-25 09:12:50 UTC MAIN commitmail json YAML

Add a structure for params related to control protocols

(yamaguchi)

2020-11-25 09:09:24 UTC MAIN commitmail json YAML

remove variable names in function declaration

(yamaguchi)

2020-11-25 05:18:39 UTC MAIN commitmail json YAML

`best_diff' should be kept to a positive number

(ryo)

2020-11-25 00:50:44 UTC MAIN commitmail json YAML

2020-11-25 00:32:18 UTC MAIN commitmail json YAML

access(2) does not work for root, so skip objdir-writable

(sjg)

2020-11-24 23:31:56 UTC MAIN commitmail json YAML

Improve detection of NS vs S views of priorities.

For PMR, write a 0 to bit7 and see if it sticks. This is only possible from
NS EL1 if we have a non-secure view of ICC_PMR_EL1.

For int priorities (GICD/GICR interfaces and LPIs), assume that the
GICD_CTLR.DS bit is telling us the truth.

RK3399 is special here when using the vendor bootloader, so keep the
auto-detection from the previous commit but limit the scope to only run
on RK3399 SOCs.

(jmcneill)

2020-11-24 23:13:09 UTC MAIN commitmail json YAML

make(1): indent some functions in make.c with tabs instead of spaces

(rillig)

2020-11-24 22:58:54 UTC MAIN commitmail json YAML

make(1): remove void pointers from MakeBuildParent

(rillig)

2020-11-24 22:55:24 UTC MAIN commitmail json YAML

make(1): inline Lst_ForEachUntil in Make_Update

(rillig)

2020-11-24 22:50:38 UTC MAIN commitmail json YAML

make(1): remove void pointers from MakeBuildChild

(rillig)

2020-11-24 22:45:24 UTC MAIN commitmail json YAML

make(1): inline Lst_ForEachUntil in MakeStartJobs

(rillig)

2020-11-24 22:32:18 UTC MAIN commitmail json YAML

make(1): inline Lst_ForEachUntil in MakeBuildChild

This prepares for removing the void pointers from the function
signature.

(rillig)

2020-11-24 21:42:28 UTC MAIN commitmail json YAML

make(1): rename local variable in ApplyModifier_Assign

(rillig)

2020-11-24 20:17:17 UTC MAIN commitmail json YAML

make(1): indent make.h with tabs instead of spaces

(rillig)

2020-11-24 19:52:06 UTC MAIN commitmail json YAML

make(1): fix indentation for short expressions in main.c

(rillig)

2020-11-24 19:46:29 UTC MAIN commitmail json YAML

make(1): indent list functions with tabs instead of spaces

(rillig)

2020-11-24 19:33:13 UTC MAIN commitmail json YAML

make(1): add high-level API for GNode.made

Having an enum whose constants must be ordered in a certain way may be
unexpected to casual readers.  Hide this implementation detail in
separate functions.

(rillig)

2020-11-24 19:04:42 UTC MAIN commitmail json YAML

make(1): fix error handling for .BEGIN dependency in -k mode

(rillig)

2020-11-24 19:02:59 UTC MAIN commitmail json YAML

2020-11-24 18:17:45 UTC MAIN commitmail json YAML

make(1): fix error handling for dependency of .END in -k mode

Fix one bug, find 4 new ones.  All these bugs have been around since
2005-05-08, when dependencies on the .BEGIN, .END and .INTERRUPT nodes
were implemented.  Before that, checking gn->made == ERROR was
appropriate, but adding the dependencies made ABORTED a new possible
error value from Compat_Make.

(rillig)

2020-11-24 17:59:42 UTC MAIN commitmail json YAML

2020-11-24 17:42:31 UTC MAIN commitmail json YAML

make(1): document the enum GNodeMade

Given only the state names and their individual documentation, it is
hard to see the full picture.  To make this easier, provide typical
examples of the ways that a GNode takes through these states.

(rillig)

2020-11-24 16:38:31 UTC MAIN commitmail json YAML

PR/55821: tar can not extract base.tgz anymore (./dev/pts and mounted ptyfs)
Allow chown/chmod at the root of ptyfs.

(christos)

2020-11-24 16:28:44 UTC MAIN commitmail json YAML

make(1): move documentation about the result of Compat_Make

(rillig)

2020-11-24 16:17:04 UTC MAIN commitmail json YAML

PR/55816: Martin Husemann: widen cfunit to 24 bits so that it fits the
largest minor number which is 20 bits. Welcome to 2x2x19.

(christos)

2020-11-24 15:59:18 UTC MAIN commitmail json YAML

make(1): fix missing "Stop." after failed .END node in -k mode

(rillig)

2020-11-24 15:36:51 UTC MAIN commitmail json YAML

2020-11-24 07:46:46 UTC MAIN commitmail json YAML

Add a comment to clarify the selected drivers to disable in the example

(kim)

2020-11-24 06:36:36 UTC MAIN commitmail json YAML

2020-11-24 00:48:39 UTC MAIN commitmail json YAML

- Print CPUID 0x8000008 %ebx on Intel, too. Intel now supports WBNOINVD.
- Print CPUID leaf 7 subleaf 1.

(msaitoh)

2020-11-24 00:46:28 UTC MAIN commitmail json YAML

Add some definitions from the latest Intel SDM:

- Add CPUID leaf 7 %edx bit 23 "KL" (Key Locker).
- Add CPUID leaf 7 subleaf 1 %eax bit 5 "AVX512_BF16".

(msaitoh)

2020-11-23 23:44:03 UTC MAIN commitmail json YAML

make(1): remove redundant null check from meta_needed

The result of bmake_realloc can never be NULL.

(rillig)

2020-11-23 23:41:11 UTC MAIN commitmail json YAML

2020-11-23 23:00:36 UTC MAIN commitmail json YAML

make(1): indent remaining functions in dir.c with tabs

(rillig)

2020-11-23 22:57:56 UTC MAIN commitmail json YAML

make(1): extract ResolveMovedDepends from ResolveFullName

(rillig)

2020-11-23 22:31:04 UTC MAIN commitmail json YAML

make(1): extract ResolveFullName from Dir_UpdateMTime

(rillig)

2020-11-23 22:14:54 UTC MAIN commitmail json YAML

make(1): in Dir_Expand, don't re-use local variables

While here, add a few remarks from a previous attempt at flattening
the function.

(rillig)

2020-11-23 22:05:58 UTC MAIN commitmail json YAML

make(1): update the deactivated code in Dir_FindFile

While here, reduce the scope of the variable ln.

(rillig)

2020-11-23 21:48:42 UTC MAIN commitmail json YAML

make(1): indent Dir_Expand with tabs instead of spaces

(rillig)

2020-11-23 21:45:30 UTC MAIN commitmail json YAML

make(1): flatten Dir_Expand

While here, leave comments in all places where unexpected edge cases
might have hidden.

(rillig)

2020-11-23 20:52:59 UTC MAIN commitmail json YAML

2020-11-23 20:41:20 UTC MAIN commitmail json YAML

2020-11-23 20:21:35 UTC MAIN commitmail json YAML

make(1): indent dir.c using tabs instead of spaces

Except for Dir_Expand and Dir_UpdateMTime, which are nested too deeply
to use tabs right now.  They first have to be split into separate
functions.

(rillig)

2020-11-23 20:05:31 UTC MAIN commitmail json YAML

make(1): indent cond.c with tabs instead of spaces

(rillig)

2020-11-23 19:35:10 UTC MAIN commitmail json YAML

make(1): indent compat.c with tabs instead of spaces

(rillig)

2020-11-23 19:27:20 UTC MAIN commitmail json YAML

make(1): split Compat_Make into smaller functions

(rillig)

2020-11-23 19:14:24 UTC MAIN commitmail json YAML

make(1): extract DebugFailedTarget from Compat_RunCommand

(rillig)

2020-11-23 19:07:12 UTC MAIN commitmail json YAML

make(1): indent buf.c with tabs instead of spaces

(rillig)

2020-11-23 19:02:54 UTC MAIN commitmail json YAML

make(1): indent arch.c with tabs instead of spaces

(rillig)

2020-11-23 18:24:05 UTC MAIN commitmail json YAML

make(1): migrate CachedDir.files from HashTable to HashSet

(rillig)

2020-11-23 18:07:10 UTC MAIN commitmail json YAML

make(1): add HashSet type

This makes the code for handling suffixes simpler since it doesn't need
the clumsy API of HashTable_CreateEntry anymore.

(rillig)

2020-11-23 17:59:21 UTC MAIN commitmail json YAML

make(1): use tabs for indentation in hash.h and hash.c

(rillig)

2020-11-23 16:01:59 UTC MAIN commitmail json YAML

make(1): make output of test opt-debug-graph1 consistent

The output from the directory cache made the regular NetBSD build fail
because the pathname to the working directory differs, thus affecting
the spacing.

This time, document why the directory cache needs to be excluded from
the output.

(rillig)

2020-11-23 15:00:32 UTC MAIN commitmail json YAML

2020-11-23 14:47:12 UTC MAIN commitmail json YAML

2020-11-23 14:13:39 UTC MAIN commitmail json YAML

2020-11-23 14:04:28 UTC MAIN commitmail json YAML

make(1): make control flow simpler in FindThem

(rillig)

2020-11-23 13:52:27 UTC MAIN commitmail json YAML

make(1): fix DEBUG_SRC logging in FindThem

The node is also removed from the list if it is neither found in the
nodes nor in the file system.  The logging did not reflect this.

(rillig)

2020-11-23 12:41:47 UTC MAIN commitmail json YAML

Add /dev/pts as standard mountpoint for a ptyfs.

(martin)

2020-11-23 12:15:39 UTC MAIN commitmail json YAML

Sort spleen also in builtin_fonts[].
No functional changes.

(rin)

2020-11-23 06:46:38 UTC MAIN commitmail json YAML

Sort headers. No binary changes.

(rin)

2020-11-23 06:39:54 UTC MAIN commitmail json YAML

Add missing __KERNEL_RCSID().

(rin)

2020-11-23 06:29:54 UTC MAIN commitmail json YAML

2020-11-23 06:29:32 UTC MAIN commitmail json YAML

Remove stray white space. No binary changes.

(rin)

2020-11-23 06:24:35 UTC MAIN commitmail json YAML

Support EARLYCONS and VERBOSE_INIT_ARM for Raspberry Pi Zero W, for
which mini UART should be used instead of PL011 UART.

(rin)

2020-11-23 06:21:07 UTC MAIN commitmail json YAML

Factor out bcm283x_aux_platform_early_putchar() from
bcm{2837,2711}_platform_early_putchar(), for which output goes to
AUX UART (aka mini UART).

No functional changes.

(rin)

2020-11-23 00:52:53 UTC MAIN commitmail json YAML

Restore correct functioning of SIOCATMARK by removing the previous
change that was done to fix poll(POLLPRI | POLLRDBAND) and instead
add a separate flag to track when poll() should indicate that a
MSG_OOB byte is available.  Re-fixes PR 54435 properly.

(chs)

2020-11-22 23:45:20 UTC MAIN commitmail json YAML

2020-11-22 22:58:43 UTC MAIN commitmail json YAML

make(1): add high-level API for CandidateSearcher

This avoids passing invisible void pointers around in Lst_Append.  It
also provides a convenient place to document what it means to "add a
candidate to the searcher".

(rillig)

2020-11-22 22:27:19 UTC MAIN commitmail json YAML

make(1): add CandidateSearcher to resolve transformation rules

Having a simple list of candidates is not enough.  It is currently
possible to construct endless loops with huge memory usage, as
demonstrated in suff-transform-endless.mk.

To fix this, a straight-forward idea is to remember which candidates
have already been searched and to not search them again.

This also fixes a small inconsistency in the code.  Most parameters had
been named slst (the s came from a time when Candidate was named Src),
except for Suff_FindDeps, where the variable was named srcs.  The
confusing thing about this was that the name srcs is used throughout the
file for a different purpose.  Only in FindThem there were two
parameters of the same type, which made this even more confusing.

(rillig)

2020-11-22 21:37:09 UTC MAIN commitmail json YAML

make(1): fix confusing command output in test suff-transform-endless

(rillig)

2020-11-22 21:34:34 UTC MAIN commitmail json YAML

2020-11-22 20:36:17 UTC MAIN commitmail json YAML

2020-11-22 20:29:54 UTC MAIN commitmail json YAML

make(1): add debug logging for setting and resetting the main target

The suffix code still doesn't behave as expected.  Make sure that at
least setting the main target works as expected.  It does, and the added
debug logging provides further hints for debugging the suffix handling
code.

(rillig)

2020-11-22 20:17:39 UTC MAIN commitmail json YAML

Fix interrupt priorities on N1 SDP.

The GICv3 architecture specification is not clear on the NS view of
priority registers, and there doesn't seem to be any consistency in how
these are implemented in both real and emulated environments.

The previous fix for this issue was meant to detect what we thought at the
time was a bug on the Rockchip RK3399. At that time the theory was somehow
EL1 has a secure view of the hardware, and this is causing us to have the
wrong view of IPRIORITYRn based on IHI0069F section 4.8.6 "Software
accesses of interrupt priority". But it turns out that this is not the
full picture. While I was able to confirm that yes, we do have secure
access to the GIC on RK3399 from EL1, the view of IPRIORITYRn differs
depending on whether you are using the Rockchip TF-A as included with
https://github.com/ayufan-rock64/linux-u-boot (shifted view), or mainline
TF-A from pkgsrc (unshifted view).

So to detect this quirk, we need three things: A method to detect if we
have S access to GIC registers, a method to see how many PMR bits are
implemented, and a method to see how many IPRIORITYRn bits are implemented.

To detect S access, we can try to toggle GICD_CTRL.EnableGrp1S. This bit
is either RES0 (security extensions not implemented), RAZ/WI (non-secure
access in two security state systems) or RW (secure access in two security
state systems).

To read the number of PMR and IPRIORITYRn bits supported, we can write all
1s to the register fields and read them back.

For the RK3399 (Rockchip TF-A) quirk, we assume a shifted view of
IPRIORITYRn if we have detected S accesses, and the PMR and IPRIORITYRn
values differ. The S access test is required because some real hardware
implementations (Ampere eMAG) were observed to report different PMR and
IPRIORITYRn masks, but present an unshifted view of IPRIORITYRn.

During testing, I also discovered that QEMU 5.1 requires this shifted view
workaround as well -- as far as I can tell, this is a QEMU bug. We can't
detect it the same way as RK3399 because security is disabled in the
emulated GIC, and the PMR and IPRIORITYRn tests both return 0xff! So now
if the GICv3 driver sees this configuration, it assumes that the shifted
view is required.

Honestly, this feature is so poorly documented that maybe it is better to
give up on HW priorities and preemption and use a single flat model like
Linux and FreeBSD does.

Tested on Arm N1 SDP, ROCKpro64 (RK3399) with Rockchip and pkgsrc TF-A,
Pinebook Pro (RK3399), Lenovo HR330A (Ampere eMAG), QEMU 5.1 (gic-version=3),
AWS EC2 a1.medium (Graviton).

(jmcneill)

2020-11-22 20:01:46 UTC MAIN commitmail json YAML

make(1): add remark to add a "reasonable way" to format time_t 0

(rillig)

2020-11-22 19:53:48 UTC MAIN commitmail json YAML

Add GICD_CTRL_EnableGrp1S definition.

(jmcneill)

2020-11-22 19:37:28 UTC MAIN commitmail json YAML

2020-11-22 19:14:25 UTC MAIN commitmail json YAML

make(1): use canonical character comparison in ParseDoDependencyTargets

(rillig)

2020-11-22 18:44:10 UTC MAIN commitmail json YAML

make(1): make configuration of export tests simpler

The configuration section of unit-tests/Makefile is already complicated
enough to read, due to the excessive use of regular expressions.
Therefore, to keep the structuring elements at a minimum, inline the
.for loop.

(rillig)

2020-11-22 18:25:44 UTC MAIN commitmail json YAML

make(1): add more output to test for -dg1

Previously, the variables section had been omitted.  This was because
the variables had been output in hashcode order until 2020-10-18, and
because some of the variable values are specific to the test environment
or the individual run (MACHINE_ARCH, MAKE.PPID).

(rillig)

2020-11-22 18:13:52 UTC MAIN commitmail json YAML

make(1): rename local variable in UpdateTargets

(rillig)

2020-11-22 17:20:15 UTC MAIN commitmail json YAML

make(1): extract FindDepsLib from FindDepsRegularKnown

(rillig)

2020-11-22 12:05:20 UTC MAIN commitmail json YAML

make(1): rename Candidate.pref to prefix

The new name nicely matches the .PREFIX variable.

(rillig)

2020-11-22 12:00:27 UTC MAIN commitmail json YAML

make(1): improve documentation of Candidate fields

(rillig)

2020-11-22 11:50:31 UTC MAIN commitmail json YAML

make(1): extract ExpandMember from FindDepsArchive

(rillig)

2020-11-22 11:46:50 UTC MAIN commitmail json YAML

make(1): extract ExpandAllChildren from FindDepsArchive

(rillig)

2020-11-22 11:30:02 UTC MAIN commitmail json YAML

make(1): extract string handling from Suffix_GetSuffix

Finding a suffix of a string is not the job of the Suffix type.

(rillig)

2020-11-22 11:26:50 UTC MAIN commitmail json YAML

make(1): rename StrIsPrefix to StrTrimPrefix

Only functions returning Boolean should have the word Is in their name.

(rillig)

2020-11-22 11:15:43 UTC MAIN commitmail json YAML

make(1): fix C99-ism in Suffix_GetSuffix

(rillig)

2020-11-22 11:11:43 UTC MAIN commitmail json YAML

make(1): fix type of local variable in FindDepsRegular

The compiler cannot check these since all lists and list nodes are
aliases to each other.

Maybe it's time to add type-generic lists to the code, to delegate these
checks to the compiler.

(rillig)

2020-11-22 11:05:49 UTC MAIN commitmail json YAML

make(1): document the type of the .DEFAULT node

It is marked intentionally as a transformation node, even though this
seems counterintuitive at first.

(rillig)

2020-11-22 10:48:11 UTC MAIN commitmail json YAML

make(1): renumber the flags in GNodeType

In plain C, bit 31 of an enum is not guaranteed to play well with binary
operators.  Bit 23 was unused until now, so shift them all down.

The order of the bits is only used in Targ_PrintType.

(rillig)

2020-11-22 10:27:56 UTC MAIN commitmail json YAML

make(1): add comment about missing unit test for .MAIN in suffixes

(rillig)

2020-11-22 10:24:52 UTC MAIN commitmail json YAML

make(1): remove last occurrences of Src

(rillig)

2020-11-22 10:22:23 UTC MAIN commitmail json YAML

make(1): clean up comment about single-suffix inference rules

(rillig)

2020-11-22 10:11:23 UTC MAIN commitmail json YAML

make(1): merge functions for suffix handling

The names of the functions AddSources and AddLevel were not as precise
and guiding as possible.  Merging them into a single function makes the
code indented a little more, but on the other hand provides a function
with an easy to grasp purpose.

(rillig)

2020-11-22 09:56:01 UTC MAIN commitmail json YAML

make(1): clean up comments for Suff_AddInclude and Suff_AddLib

(rillig)

2020-11-22 09:48:58 UTC MAIN commitmail json YAML

make(1): document possible bug in UpdateTarget in suffix handling

(rillig)

2020-11-22 09:46:37 UTC MAIN commitmail json YAML

make(1): rename type SrcList to CandidateList

The variable names will be renamed in a follow-up commit, as necessary.

(rillig)

2020-11-22 09:30:22 UTC MAIN commitmail json YAML

make(1): rename type Src to Candidate

In all this code about sources, targets, parents and children, it's been
way too difficult to decide whether each word 'src' meant a source as
opposed to target, or just a possible source on its own.

(rillig)

2020-11-22 03:57:19 UTC MAIN commitmail json YAML

2020-11-22 03:55:33 UTC MAIN commitmail json YAML

2020-11-21 23:51:28 UTC MAIN commitmail json YAML

make(1): remove module name from local functions in Suff module

The module name doesn't provide any useful information.  More often than
not, it creates a wrong impression of a very specific function name; the
function name has to be expressive enough even without the module name.
The word Suff may have even be misleading since not all of the functions
in this module affect suffixes, some also simply work on strings.

Module boundaries are marked by function names of the form Module_Func.
Therefore, local function names don't need to start with the module
name.

Rename the FindDeps functions to list their hierarchical position in the
function name, from broad to narrow.

(rillig)

2020-11-21 23:25:30 UTC MAIN commitmail json YAML

make(1): remove redundant null check in SuffFindCmds

Src.suff is never null.  It is initialized in the constructor and then
never modified again.  It cannot be marked as const though because memory
allocation and initialization are separated in SrcNew.

(rillig)

2020-11-21 23:09:07 UTC MAIN commitmail json YAML

make(1): clean up Suffix_GetSuffix

This eliminates the unspecific variable names p1 and p2 and furthermore
ensures that there is never a pointer that points out of bounds.

The code could have used memcmp or strncmp as well, but since the
suffixes are usuall very short, there is no benefit over a direct loop
comparing individual characters.

(rillig)

2020-11-21 23:00:02 UTC MAIN commitmail json YAML

Add missing FONT_SPLEEN6x12 option.

(rin)

2020-11-21 22:59:19 UTC MAIN commitmail json YAML

Sort spleen by size, instead of character code.
No functional changes.

(rin)

2020-11-21 22:37:11 UTC MAIN commitmail json YAML

2020-11-21 22:00:34 UTC MAIN commitmail json YAML

make(1): fix indentation in SuffixList_Insert

(rillig)

2020-11-21 21:54:42 UTC MAIN commitmail json YAML

2020-11-21 21:41:27 UTC MAIN commitmail json YAML

make(1): capture more output from test deptgt-suffixes

This will have an effect with the next commit.

(rillig)

2020-11-21 21:27:09 UTC MAIN commitmail json YAML

2020-11-21 21:25:34 UTC MAIN commitmail json YAML

2020-11-21 21:23:49 UTC MAIN commitmail json YAML

2020-11-21 21:08:33 UTC MAIN commitmail json YAML

2020-11-21 21:07:38 UTC MAIN commitmail json YAML

2020-11-21 21:04:25 UTC MAIN commitmail json YAML

Sync '_elftc.h' with the upstream elftoolchain project.

(jkoshy)

2020-11-21 21:01:16 UTC MAIN commitmail json YAML