sqlite: do not build without multithreading support

at least a few pkgsrc packages avoid base sqlite because it fails
this check, and it's probably a surprising performance penalty for
unsuspecting users

(nia)

make(1): add test for comparison of large integers

(rillig)

make(1): add test for function argument with unbalanced braces

(rillig)

make(1): document what the directive ".if A&B" means

(rillig)

make(1): clean up FuncExists

(rillig)

make(1): add test demonstrating the :D modifier with := assignments

(rillig)

make(1): clean up code related to VarEvalFlags

Mention VARE_WANTRES before VARE_UNDEFERR since the latter depends on
the former.

In ApplyModifier_Assign, VARE_KEEP_DOLLAR doesn't have to be removed
from eflags since ParseModifierPart does this already.

In EvalUndefined, testing for VARE_WANTRES is redundant if VARE_UNDEFERR
is already set.

(rillig)

make(1): clean up VarEvalFlags in the calls to Var_Parse and Var_Subst

There are only 3 flags, and some combinations don't even make sense.

VARE_UNDEFERR only makes sense if combined with VARE_WANTRES.  If the
latter is not set, the variable expressions are only parsed, without
asking whether they are defined or not.  Therefore, VARE_UNDEFERR cannot
have any effect in that case.

VARE_KEEP_DOLLAR is actively ignored by ParseModifierPart.  In cases
where VARE_WANTRES is not set, this means that VARE_NONE can be passed,
which is easier to grasp than any bitset operations.  This also gets rid
of a few type casts from enum to unsigned int that were necessary to
pass WARNS=6.

(rillig)

make(1): rename local variable in VarSubstNested

(rillig)

make(1): reorder branches in Var_Subst

This way, '$$' is handled first, followed by '$', followed by everything
else.  This is easier to follow than first '$$' then not '$' and finally
'$'.

(rillig)

make(1): extract VarSubstNested from Var_Subst

Each of these functions now fits on a moderately large screen.

(rillig)

make(1): add test demonstrating how ':=' and ':@var@' interact

(rillig)

catman(8) is a past thing

(kamil)

make(1): rename VARE_ASSIGN to VARE_KEEP_DOLLAR

The other flags in VarEvalFlags already describe their effects, not the
place where they are used.  It's more important to know the effect.

Only a single unit test had to be adjusted.  This probably means that
there are too few tests where the special effects of VARE_KEEP_DOLLAR
come into play.  It could also mean that the effects are so simple and
obvious that they don't need any debug log, but that's not the case.

(rillig)

Move the html9/psref* files from comp-sys-catman to comp-sys-htmlman

(kamil)

make(1): add test for expanding variable expressions

(rillig)

grep 3.5 is out for a while.

(wiz)

Stop mentioning the support for cat pages

(kamil)

make(1): fix documentation of preserveUndefined

Since it is a global variable and not a VarEvalFlags, it affects nested
subexpressions as well, and there is no way to escape it.

(rillig)

make(1): use strict typing in conditions of the form !var

(rillig)

Remove the MKCATPAGES remnants

(kamil)

Remove the support for MKCATPAGES

It was optional since 1999 and disabled by default since 2012.

Proposed on tech-userlevel@.

(kamil)

make(1): reformat main.c more closely to share/misc/style

(rillig)

make(1): remove redundant comment from main_ReadFiles

The code has become so simple that it made the comment redundant.

(rillig)

Ignore PNP0001 (EISA interrupt controller) and PNP0C02 (motherboard
resources) when enumerating devices.

(jmcneill)

make(1): fix bug description of using := with undefined variable

In 1993, the variable names could not refer to other variables yet.
This has been made possible on 2000-05-11, when the "cool magic" was
added that allows assigning to VAR.${param}.

(rillig)

make(1): add test for edge case in resolving undefined variables

(rillig)

make(1): rename init_machine to InitVarMachine

For consistency with the other Init functions.

(rillig)

make(1): move usage further to the top

This avoids a forward declaration.

(rillig)

make(1): move documentation from main to the phase functions

(rillig)

make(1): split main into manageable pieces

The purpose of a main function is to give a high-level overview about the
whole program.  270 lines of code with lots of tricky details did not serve this
purpose.  Split the code into functions corresponding to the phases.

(rillig)

make(1): indent main consistently

(rillig)

make(1): inline ReadMakefileSucceeded into ReadFirstDefaultMakefile

This gets rid of a few void pointers and an unused function parameter.

(rillig)

make(1): inline Lst_ForEachUntil in ReadBuiltinRules

The list of expanded filenames for sys.mk is freed in the end, but not
the filenames themselves, as these are still needed.

(rillig)

make(1): document inefficient cache lookup in DirMatchFiles

(rillig)

make(1): clean up Make_ExpandUse

The targets need to be copied to the 'examine' queue, not because the
targets list would be modified but because the queue is modified and the
targets list should not be affected by that.

(rillig)

make(1): fix type of have_token in MakeStartJobs

(rillig)

make(1): inline MakeCheckOrder into IsWaitingForOrder

This gets rid of a few void pointers and an unnecessary and unused
function parameter.

The variable name "bn" may have meant "before", but that was not
obvious.  The new name "ogn" nicely matches the ".ORDER" in the debug
message.

(rillig)

make(1): inline MakeAddChild into ExamineLater

This gets rid of a few void pointers and unspecific variable names like
"l" for the list that should have rather been called "examine" all the
time.

Add quotes around placeholders in debug messages.  Especially for targets
like "all" the message had been syntactically misleading.

(rillig)

make(1): inline MakeFindChild into PretendAllChildrenAreMade

This gets rid of a few void pointers and some function calls.  The
documentation of MakeFindChild essentially repeated what the code does,
and the redundant parts of it have been removed.

(rillig)

make(1): extract PretendAllChildrenAreMade from Make_ExpandUse

(rillig)

make(1): fix debug output in out-of-date for cohorts (since 2003-11-14)

Before, a wrong cause for being out-of-date was printed in the debug log,
for optional cohorts.  This was caused by having the same conditions
duplicated in the code, instead of putting them in a separate function.

Now the optional cohort is correctly identified as using the '::'
dependency operator.

(rillig)

make(1): add test for wrong debug message in GNode_IsOODate

(rillig)

Fix register usage

(skrll)

make(1): extract condition from GNode_IsOODate into separate function

(rillig)

make(1): change return type of Dir_MTime to void

Only some callers actually needed the updated time, and because of the
many branches, it was difficult to see that the return value was indeed
gn->mtime all the time.

(rillig)

make(1): change return type of Arch_MTime to void

This makes it easier to prove that Dir_MTime always returns gn->mtime,
without looking at the implementation of Arch_UpdateMTime.

(rillig)

make(1): change return type of Arch_MemberMTime to void

This makes it easier to prove that Dir_MTime always returns gn->mtime,
without looking at the implementation of Arch_UpdateMemberMTime.

(rillig)

make(1): clean up comments in Make_Recheck

(rillig)

PR 55338: re-enable threxec test for more test coverage.

(martin)

make(1): use common indentation style for else

(rillig)

Ticket #1127

(martin)

Pull up following revision(s) (requested by kamil in ticket #1127):

sys/compat/linux/common/linux_socket.c: revision 1.151

Fix compat with Linux programs that use longer namelen for sockets

Linux is less strict than NetBSD and permits namelen to be larger
than valid struct sockaddr_in*.  If this is the case, truncate the value
to the correct size, so that NetBSD networking does not return an error.

Reviewed by kamil

(martin)

make(1): rename Make_OODate to GNode_IsOODate

It doesn't matter which of the make modules is in charge of determining
whether a node is out-of-date.  Therefore, remove the module name from
the function name.

(rillig)

make(1): rename Make_TimeStamp to GNode_UpdateYoungestChild

(rillig)

Fix a typo

(skrll)

Remove unnecessary local labels

(skrll)

Use correct instruction to load address of exception_userexit into RA

(skrll)

Fix typo; s/__LP64/_LP64/

(rin)

make(1): split ReadMakefiles into separate functions

This keeps the indentation of the code small.

It also reduces the possible confusion about the two similar branches in
that function that differ in a small but important detail:
ReadAllMakefiles reads all the makefiles while ReadFirstDefaultMakefile
stops after the first existing makefile.

(rillig)

make(1): inline strncmp in Parse_IsVar

The usual compilers don't do this themselves.

(rillig)

make(1): add newly added test to file list

(rillig)

make(1): add more tests for parsing .MAKEFLAGS lines

(rillig)

make(1): fix unrealistic memory leak in Main_ParseArgLine

It's unlikely that anyone ever defines an environment variable named
".MAKE" and then runs make with the -e option, which would make the
environment variable stronger than the built-in global variable.

(rillig)

make(1): add remarks for missing command line options in MAKEFLAGS

(rillig)

make(1): parse the internal option -J strictly

(rillig)

make(1): merge duplicate code in is_relpath

(rillig)

make(1): clean up overview comment in main.c

(rillig)

make(1): fix type mismatch between int and PrintVarsMode

(rillig)

make(1): rename list node to ln

That's the name that is used for list nodes outside lst.c, and there is
no reason to use a different name in the implementation of lists.  Sure,
the "l" of the name "ln" is redundant, but it's still shorter than
"node", and the latter sounds too similar to GNode.

(rillig)

make(1): remove unused JOB_IGNDOTS

It had been used in 1993 at least, don't know when it was finally
removed.

(rillig)

syslogd: in die(), don't call die() again recursively.

Particularly not for something as immaterial as close failing.

PR 55795

(dholland)

make(1): format source code in JobStart and JobDoOutput

(rillig)

make(1): fix indentation in JobExec

(rillig)

make(1): clean up debug output for running jobs

There is no remote anymore, therefore mentioning locally is redundant.
It was a bad idea anyway to build format strings that work with parts of
words.

(rillig)

make(1): rename Src.children to numChildren

There are several other types that have a field named 'children' that is
a list.  To avoid confusion, rename this one to differentiate them.

(rillig)

make(1): clean up local variable names in suffix handling

The file suff.c defines both Src and Suff, which makes the variable name
s ambiguous.

The word 'target' is ambiguous as well since it could mean a GNode or the
target suffix of a transformation.  Therefore, make the variable names
longer but more precise.

The comment about the nil return and the beanhead had been outdated
already in 1993.  There is no nil return anywhere nearby.  The longer
variable names make the rest of the comment redundant.

(rillig)

make(1): replace strstr in ParseMaybeSubMake with optimized code

This code is called for each command that is parsed.  Calling strstr with
4 strings that all start with the same character is unnecessary work.
Therefore, replace strstr with manually optimized code.  Neither GCC
5.5.0 nor GCC 10 inlines strncmp like this, otherwise I would have used
that.

Change in behavior: previously, a${MAKE}b would not be considered to be a
sub-make command, which is probably correct but does not occur in
practice.  The check for non-alphanumeric characters around the found
string was probably meant only for the plain word "make".

(rillig)

make(1): add test for OP_SUBMAKE

(rillig)

make(1): clean up spacing in fallback implementation of vsnprintf

(rillig)

make(1): fix type mismatch between int and VarExportFlags

(rillig)

make(1): remove redundant empty lines from parse.c

(rillig)

make(1): clean up parse.c

The generated code stays exactly the same.  The only changes will be the
line numbers of assertions.  To preserve them, the removed lines have
been filled up with comments and will be removed in the follow-up commit.

(rillig)

fix arm test

(christos)

make(1): remove trailing whitespace

(rillig)

make(1): fix type mismatch between int and VarSetFlags

(rillig)

make(1): fix inconsistent indentation after #ifdef

Combining #ifdef with regular if-then-else calls for trouble.

(rillig)

make(1): fix type of Job.suspended

(rillig)

make(1): clean up Make_OODate and Make_Run

(rillig)

add minimal 'configure' script that finds the versions, and
doesn't end up with an empty version in the .pc file.

pointed out by Michael Scholz in private email.

(mrg)

make(1): clean up Buf_AddEscaped in .for loops

All this dance of determining the needed escape characters before
iterating, saving them upfront, evaluating them later using complicated
boolean expressions was not necessary at all.  All that is needed is a
simple NeedsEscapes, called at just the right time.

(rillig)

make(1): use proper enum constant instead of 0 for CachedStatsFlags

(rillig)

make(1): clean up CondParser_Comparison

(rillig)

make(1): reword condition in CondParser_String

The parentheses were confusing for human readers.

The compiler doesn't really care about the wording of the condition, GCC
5 on amd64 generates non-obvious but nice code anyway, replacing the
logical or with a logical and.

(rillig)

make(1): fix type mismatch between Boolean and Token

Even though the C boolean and Token are encoded the same, the code should
still distinguish them, for the benefit of human readers.

(rillig)

make(1): fix type mismatch in If_Eval

No practical consequences since TOK_FALSE == 0 and TOK_TRUE == 1.

(rillig)

make(1): clean up JobStart

Initialize the fields in declaration order.
Initialize Job.flags in a single assignment.

(rillig)

make(1): add test for job command flags

(rillig)

libepoxy: Only require egl on ports with egl support.

Reported by martin.

(nia)

make the buffer fit any 32 bit number.

(christos)

PR/55794: Jan Schaumann: Eliminate unchecked malloc

(christos)

Use lower case for hex constants

(skrll)

make(1): add test for parse error in function defined()

(rillig)

make(1): add test for parse error in condition using empty()

(rillig)

make(1): clean up Compat_Make

(rillig)

make(1): clean up Compat_RunCommand

(rillig)

make(1): replace switch with if-else chain in Compat_RunCommand

(rillig)

make(1): make API of Buf_Init simpler

In most cases, the caller doesn't want to specify the exact number of
preallocated bytes.

(rillig)

make(1): clean up Arch_LibOODate

(rillig)

make(1): fix indentation in JobPrintCommand

(rillig)

make(1): document duplicate code in arch.c

(rillig)

make(1): fix function names in archive debug output

(rillig)

make(1): fix out-of-bounds pointer in ArchStatMember (since 1993-03-21)

(rillig)

make(1): reduce indentation in ArchStatMember

(rillig)

make(1): replace hashed with cached in comments

The hash table is just an implementation detail, not worth to be
mentioned in comments.

(rillig)

make(1): fix access to undefined memory (since 1994-03-18)

This bug was added in arch.c 1.6, "Do extended-name archives".

(rillig)

make(1): clean up ArchStatMember

Whether an archive entry is hashed or not is completely irrelevant.  The
interesting thing is whether it ends up in a cache.

(rillig)

make(1): document the relation between VARE_ASSIGN and preserveUndefined

(rillig)

make(1): properly handle errors for malformed archive target names

Error messages don't belong on stdout.

(rillig)

make(1): rename local variable in Arch_ParseArchive

(rillig)

make(1): rename parameter of ArchSVR4Entry

It cannot be made a const string, so rather document it clearly that the
string is modified.

(rillig)

make(1): remove unused macro definitions from arch.c

These definitions have originally been added in arch.c 1.27 on
1998-05-21.  Even back then they had been unused, at least they had not
been used directly.  Since macros are expanded at their use site, there
could have been an indirect use, but that is not the case anymore.

(rillig)

make(1): fix archive handling

It's no wonder that nobody is using the archive handling of make.  The
archives created by GNU binutils cannot be processed using make since the
format of the archive names has changed.  GNU binutils appends a slash to
the member names.  Support that format from now on.

Add more debugging output in ArchFindMember.  Since nobody uses this part
of make, it doesn't hurt that the debug output is now very verbose.

In Arch_Touch and Arch_TouchLib, move the snprintf to where it belongs.
There's no point modifying a local variable just to throw it away
afterwards.

(rillig)

make(1): extract ArchiveMember_HasName from ArchFindMember

Comparing a string to a space-padded string is complicated enough to be
extracted to a separate function.

The behavior changes a little bit.  Before, when searching for an archive
member with a short name (one that is space-padded in the archive), that
member was not searched using the AR_EFMT1 archive format.  This doesn't
matter in practice though since no regular archive member has a name
starting with "#1/".

(rillig)

make(1): clean up comments in arch.c

(rillig)

Whitespace

(skrll)

Indent and annotate FP registers much like the general registers

(skrll)

make(1): add pp_skip_hspace to skip horizontal whitespace during parsing

(rillig)

Note if a register is Caller / Callee saved

(skrll)

make(1): document InitDefSysIncPath

(rillig)

make(1): omit redundant bitwise or in Compat_Make

(rillig)

make(1): clean up code stylistically

* Replace character literal 0 with '\0'.
* Replace pointer literal 0 with NULL.
* Remove redundant parentheses.
* Parentheses in multi-line conditions are not redundant at the
  beginning of a line.
* Replace a few !ptr with ptr == NULL.
* Replace a few ptr with ptr != NULL.
* Replace (expr & mask) == 0 with !(expr & mask).
* Remove redundant braces for blocks in cases where the generated code
  stays the same.  (Assertions further down in the code would get
  different line numbers.)
* Rename parameters in CondParser_String to reflect the data flow.
* Replace #ifdef notdef with #if 0.

The generated code stays exactly the same, at least with GCC 5.5.0 on
NetBSD 8.0 amd64 using the default configuration.

(rillig)

Fix the use of the contiguous bit by checking the output address as well.

(skrll)

In pmap_devmap_bootstrap only set pmap_devmap_bootstrap_done if there
is an entry and ALL of the entries have been done.  The entry required
for EARLYCONS might not be the first/only one...

(skrll)

Print the devmap we're using in the debug output

(skrll)

make(1): fix references to Var_SetWithFlags in tests

(rillig)

make(1): rename Var_Set_with_flags to Var_SetWithFlags

Now that the function is exported from the var module, it should stick
to the naming conventions for public functions.

(rillig)

make(1): rename VarSet_Flags to VarSetFlags

Most other types don't have an underscore as well.

(rillig)

make(1): rename Arch_MemMTime to Arch_MemberMTime

The abbreviation Mem was ambiguous, it could have meant memory as well.

(rillig)

make(1): rename getBoolean and s2Boolean

(rillig)

make(1): fix comment of Error

(rillig)

make(1): clean up Cmd_Exec stylistically

(rillig)

make(1): merge duplicate code for skipping horizontal whitespace

(rillig)

make(1): move name of inline functions to the beginning of the line

(rillig)

make(1): rename dieQuietly to shouldDieQuietly

It was too confusing to have a function named die that doesn't actually
die.  Plus, the return type int didn't give any clue about what the
function actually returns.

(rillig)

make(1): document DEBUG_LINT

(rillig)

make(1): sort and renumber debug flags

(rillig)

make(1): fix typo from previous commit

(rillig)

make(1): fix wrong condition in mkTempFile (since 2020-10-31)

The wrong negation had been added in main.c 1.414 from 2020-10-31.
Found by GCC 10, which complained about a potential null pointer
dereference in line 2188.

(rillig)

make(1): fix tests directive-ifmake and varcmd with custom boolean

When make is compiled with -DUSE_UCHAR_BOOLEAN, these tests failed.
Merge duplicate code and don't depend on the actual value of TRUE when
evaluating conditions.

(rillig)

make(1): fix indentation in test directive-ifmake

(rillig)

make(1): document progname

(rillig)

make(1): clean up comments in make.h

(rillig)

Minimize the installer for crunched install media

(martin)

Bump ramdisk size slightly

(martin)

Bump ramdisk size slightly

(martin)

PR/55789: Ruslan Nikolaev: New rump drivers

(christos)

PR/55777: Ruslan Nikolaev: Move the unp_sysctl_create to uipc_usrreq.c to
facilitate splitting rump modules and does not require a dummy function.

(christos)

Fix copy & pasted copyright comments.

(martin)

make(1): rename local variable in Var_Parse

(rillig)

make(1): format source code of a few functions in var.c

(rillig)

make(1): update and clean up documentation of Var_Parse

(rillig)

make(1): fix parameter name in ApplyModifiersIndirect and ApplyModifiers

The variable must be properly initialized before these functions are
called.

(rillig)

make(1): clean up ParseVarnameLong

A parameter named pp is usually used as the parsing position, which is
updated upon successful return.  Not so in ParseVarnameLong, where it
was updated in the unsuccessful branch only.

To avoid confusion, rename it to out_FALSE_pp, which is a longer name
but expresses more clearly what actually happens.

(rillig)

make(1): extract EvalUndefined from ParseVarnameLong

(rillig)

Fix typo

(martin)

Print the program name in error messages.

(christos)

make(1): extract FindLocalLegacyVar from Var_Parse

(rillig)

make(1): replace '(' and ')' with neutral '\0' in Var_Parse

The only possible values for extramodifiers are "H:" and "T:", therefore
parsing is independent of startc and endc.  Use '\0' instead of '(' and
')' to remove any possible confusion about how '{' and '}' would be
handled.

(rillig)

make(1): clean up documentation for Var_Subst

(rillig)

make(1): add test for legacy local variables @F, @D

(rillig)

+SMR

(dholland)

make(1): remove redundant parentheses from sizeof operator

The parentheses are only needed if the argument is a type, not an
expression.

(rillig)

Cherry-pick Xorg version independent changes from xorg-server.

Reorganize CPPFLAGS.

(tsutsui)