make(1): add tests for generating the ... command indirectly

(rillig)

make(1): add GNode_Path to access the path of a GNode

(rillig)

make(1): refactor JobDeleteTarget

Splitting the many conditions into separate pieces makes the code more
understandable.

(rillig)

make(1): add test for deleting targets using .DELETE_ON_ERROR

(rillig)

make(1): inline macro STATIC

It was a leftover from the remote code, which was removed on 2006-03-11.

(rillig)

make(1): convert result of JobStart from macros to enum

Right now the result is not used by any code.

(rillig)

make(1): convert abort reason macros to enum

(rillig)

make(1): invert condition in Job_CheckCommands, reduce indentation

(rillig)

make(1): reduce indentation in Job_CheckCommands

(rillig)

make(1): split and invert complex condition in Job_CheckCommands

(rillig)

make(1): inline error message

This saves a variable, and since bmake needs to adhere to C90, this
variable declaration prevents refactoring the code.

(rillig)

make(1): clean up API comment in job.c

(rillig)

make(1): print hash in debug log with fixed width

This way all the keys are nicely aligned in the debug log.

(rillig)

make(1): rename hash functions to identify the type name

This makes it easier to spot mismatches between the function name and
its first parameter, although the compiler should already catch most of
them.  Except for void pointers.

(rillig)

make(1): reduce duplicate code in VarFind

(rillig)

Temporarily disable NTFS for an internal test.

(martin)

make(1): clean up comments in hash.c

(rillig)

make(1): clean up hash table functions

(rillig)

make(1): refactor Hash_DeleteTable

(rillig)

make(1): refactor Hash_InitTable

First prepare all the data, then initialize the fields in declaration
order.

(rillig)

make(1): clean up RebuildTable for hash tables

The previous code used ++ and -- a lot, it also reused variables a lot
for different purposes.

(rillig)

Skip reading .MAKE.DEPENDFILE if set to
"/dev/null" or anything starting with "no".

Ref: https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=223564

(sjg)

make(1): add more details to DEBUG_SRC log

(rillig)

make(1): reduce amount of string hashing

In pkgsrc, running "bmake show-all" in pkgtools/pkglint called the hash
function 249130 times before, and only 115502 times after.

Still, a single call to Var_Set hashes the same string 3 times.

(rillig)

Unhook libglut (MesaGLUT) from the build.

The GL Utility Library was formerly a core part of most OpenGL
distributions.

Originally, this version of libglut was developed as part of Mesa (the
primary OpenGL implementation used in NetBSD) before it was mostly abandoned
and work moved to the freeglut fork. It provides a platform-neutral way of
creating OpenGL contexts, something that many other libraries can also do
today (e.g. SDL, glfw).

All users in pkgsrc have been switched to the freeglut fork and there are no
remaining users of this library in src. If having a GLUT implementation in
base turns out to be particularly useful outside of compatibility with
previous NetBSD versions, we can import freeglut (which, AFAIK, is also
ABI compatible with MesaGLUT).

(nia)

Normalize some machine dependent CPU frequenct sysctl variables.

This moves machdep.*.frequency.* to machdep.cpu.frequency.*.

This was proposed on tech-kern some time ago. The intention is to allow
third-party tools such as estd and conky to more easily and reliably
fetch or modify the current CPU frequency without iterating through
various machine-dependent variables to check their presence.

(nia)

make(1): clean up comments in .for handling

(rillig)

make(1): use complete words in error message for .for loop

(rillig)

make(1): extract code to see if a directive is a .for or .endfor

(rillig)

make(1): rename local variable in For_Eval

(rillig)

ptrace_Common is a module unto itself.  Don't use the ptrace module's
init/fini routines.

(pgoyette)

make(1): test funny character in .for variable names

(rillig)

make(1): reduce memory allocation in .for loops

It was not necessary to allocate a new buffer for each iteration of the
.for loop.

(rillig)

make(1): use Words instead of Vector for the .for items

This makes memory management a bit simpler and also more efficient.

(rillig)

make(1): remove unnecessary type ForVar

Now that the escaping information is computed just-in-time, the item of
a .for loops is a simple string with no additional information.
Therefore, unwrap the struct.

(rillig)

make(1): compute escaping flags for .for values when needed

Before, they were computed when parsing the .for line, which was
unnecessarily early.

(rillig)

make(1): add test for escaping parentheses and braces in .for loops

(rillig)

make(1): extract GetEscapes from For_Eval

(rillig)

make(1): extract SubstVarShort from ForIterate

(rillig)

make(1): extract SubstVarLong from ForIterate

(rillig)

make(1): remove obsolete comment from lst.h

(rillig)

make(1): remove unused strlist_t

(rillig)

make(1): use Vector instead of strlist_t for expanding .for loops

strlist_t combines a string with an unsigned int.  This unsigned int had
been the string length for variables and the escaping flags for values.
This is another case of using generic types where specific types would
give more guidance to the reader.

Defining the types ForVar and ForItem expresses the involved concepts
more directly.

This is the last use of strlist_t, which will be removed in a follow-up
commit.

(rillig)

make(1): replace PtrVector with Vector, which can contain any type

(rillig)

make(1): rename type Vector to PtrVector

This allows the name Vector to be used for a more generic vector type,
which will be added soon.

(rillig)

make(1): clean up code for handling .for loops

(rillig)

make(1): inline Lst_Copy in Make_ExpandUse

(rillig)

make(1): replace Dir_CopyDir with Dir_CopyDirSearchPath

Callback functions for the Lst functions do not belong in the public API
of a module.

(rillig)

make(1): clean up Dir_HasWildcards

(rillig)

make(1): add test for setting a variable in a GNode context

This edge case is probably not used widely.  The local variables of a
GNode should only ever be the predefined variables.

(rillig)

make(1): clean up DirLookupSubdir and DirLookupAbs

As with cp2, the variable names p1 and p2 are not expressive.

(rillig)

make(1): omit trailing space in debug output for expanding file patterns

(rillig)

make(1): clean up documentation of DirExpandInt, rename it

The code in that function is so trivial that there is no point in
writing this much redundant documentation.

(rillig)

Switch alpha to USE_XZ_SETS=no, i.e. using gzip for installation sets.

Ok'ed by martin@ in PR/55751.  Maybe worth to pullup to netbsd-9.

(tsutsui)

make(1): document pattern matching edge case in DirMatchFiles

(rillig)

make(1): refactor DirMatchFiles

Split the conditions since the comment only applies to one of them.
Use local variables for common subexpressions.

(rillig)

Mark a variable only used in an assert as __diagused.

(martin)

KASSERT -> KASSERTMSG

(skrll)

l2tp: call if_link_state_change rather then directly setting it.

This allows protocols to do their thing.

(roy)

l2tp: Revert prior

It proves I can't read comments and that if_initialize should not be used.

(roy)

make(1): clean up documentation of DirExpandCurly and Dir_Expand

(rillig)

make(1): document that the SearchPath of Dir_FindFile may be NULL

(rillig)

make(1): make Arch_FindLib simpler

(rillig)

Don't release the last reference to the "i2c-child-devices" dictionary in
the v210/v240 patches.
Fixes missing i2c devices there (pointed out by macallan@).
While here, add debug to show when we create the dictionary.

(jdc)

make(1): remove unused parameter from DirFindDot

(rillig)

make(1): rename parameter of DirLookup

The DirLookup functions work on "name", which may be a complete path,
and on "base" or "cp", which is the basename of the file.  Don't use
"name" for the basename, since that would be confusing.

(rillig)

make(1): remove unused parameters from DirLookup

(rillig)

make(1): only define OpenDirs_Done if necessary

(rillig)

Handle PG_PAGEOUT in uvm_anon_release() too.

(chs)

make(1): remove UNCONST from Dir_Expand

That code is called so seldom that one more memory allocation doesn't
hurt.  It needs a wildcard character in a dependency declaration, which
is rare in practice; see dep-wildcards.mk for an example.

(rillig)

Now that we are adding the thread in the bsd_kvm_ops target namespace,
make sure that the inferior's top namespace is that too.

(christos)

make(1): remove macros MIN and MAX

These macros typically evaluate one of their arguments twice.  Until
2020-08-31, they had not parenthesized their arguments properly.  They
are only used in a few places, therefore it doesn't hurt much to have
them expanded.

(rillig)

make(1): convert macros for debug flags into enum

(rillig)

When looking for available CD media, skip those that are already mounted.
When no medium with sets is found, show a new error message and return
to the source selection menu.
Rearrange all source option menus to have the proper set suffix
available (either .tgz or .tar.xz).

(martin)

Add support for automatically changing the CPU fan speed on the E250 in a
similar way to the SB1000/SB2000.
The fan control information was determined by experiment, as it's only
partially available in OFW.
Hardcode the missing information for E250 fan control into the driver
(it should be possible to support the E450 in future too).

(jdc)

Fix the logic around "parent is a subset and can be re-used" in
bus_dmatag_subregion.  Thanks to mrg@ for spotting the problem.

(skrll)

Remove extra parens

(roy)

libossaudio: return newfd here as we return retval elsewhere

(roy)

Add the new tests + check files, sort.

(martin)

Add E250 i2c devices missing from the OFW tree.
Normalise the spelling of "temperature".

(jdc)

file systems that are used as what spools?

(nia)

make(1): remove unused Lst_Find and Lst_FindFrom

(rillig)

make(1): inline Lst_Find in meta_oodate

(rillig)

make(1): clean up comments in list functions

(rillig)

make(1): make Lst_RemoveIf simpler in meta_oodate

Using Lst_Find and Lst_FindFrom to implement Lst_RemoveIf was a bad
idea.  It made the code much more complicated than necessary.  There is
no predefined Lst_RemoveIf, but that can be implemented easily.  By
inlining the list handling, path_match does not need void pointers
anymore.

Freeing the path from the missingFiles list had been implemented in a
surprisingly complicated way, intermangling it unnecessarily with the
list operations, even though these are completely independent.

(rillig)

make(1): inline ReadMakefileFailed, eliminating some void pointers

(rillig)

make(1): inline DirFindName

(rillig)

make(1): clean up code in lst.c

(rillig)

Fix compat with Linux programs that use longer namelen for sockets

Linux is less strict than NetBSD and permits namelen to be larger
than valid struct sockaddr_in*.  If this is the case, truncate the value
to the correct size, so that NetBSD networking does not return an error.

Reviewed by kamil

(mgorny)

Use BUS_DMA_WAITOK in ld_virtio_alloc_reqs which is called at attached
time...

(skrll)

Test the 64bit dma tag with BUS_DMA_TAG_VALID before using it.

(skrll)

make(1): refactor LstNodeNew

(rillig)

Fix DMA size reporting.  Previously it could report 64bit DMA when the tag
wasn't available (and it fell back to 32bit tag)

(skrll)

make(1): use consistent indentation in variable assignments

Initial work by "pkglint -F *.mk", manually adjusted in a few places.

(rillig)

make(1): indent directives like .info, .if, .for consistently

Done by "pkglint -F *.mk", no manual corrections.

(rillig)

make(1): use consistent RCS Id in test files

(rillig)

Use the 64bit DMA tag if its valid.

There appears to be a bug in virtio / ld_virtio and bounce buffers that
was triggered when the bus_dmatag_subregion code on arm64 was fixed to
correctly create a new tag for the 32bit tag vs the system (64bit) tag.
This change avoids the bug.

PR/55737: Apparent bug in evbarm64 DMA code causes filesystem corruption

(skrll)

Issue 64-bit versions of *XSAVE* for 64-bit amd64 programs

When calling FXSAVE, XSAVE, FXRSTOR, ... for 64-bit programs on amd64
use the 64-suffixed variant in order to include the complete FIP/FDP
registers in the x87 area.

The difference between the two variants is that the FXSAVE64 (new)
variant represents FIP/FDP as 64-bit fields (union fp_addr.fa_64),
while the legacy FXSAVE variant uses split fields: 32-bit offset,
16-bit segment and 16-bit reserved field (union fp_addr.fa_32).
The latter implies that the actual addresses are truncated to 32 bits
which is insufficient in modern programs.

The change is applied only to 64-bit programs on amd64.  Plain i386
and compat32 continue using plain FXSAVE.  Similarly, NVMM is not
changed as I am not familiar with that code.

This is a potentially breaking change.  However, I don't think it likely
to actually break anything because the data provided by the old variant
were not meaningful (because of the truncated pointer).

(mgorny)

Trailing whitespace

(skrll)

Add _UC_GREGS_* defines for all general registers

(skrll)

Provide _UC_REGS_* defines for all registers

(skrll)

Register the usr/share/gdb dir

(kamil)

Update the unwinder comment to better reflect ARM64

(skrll)

s/ARM/ARM64/ in comment

(skrll)

Install the NetBSD XML syscall definitions

(kamil)

make(1): clean up comments in cond.c

(rillig)

Add new tests and check files for libcurses from the Google Summoer of Code
project.

(blymn)

Merge in code from Google Summer of Code project which dramatically
increases the number of tests performed.

Thanks to Naman Jain <jnaman806@gmail.com> for his excellent work on
this GSoC project.

(blymn)

make(1): clean up code style in compat.c

(rillig)

make(1): remove redundant parameter from meta_name

(rillig)

make(1): clean up comments in buf.c

(rillig)

make(1): clean up code layout in arch.c

Combining #ifdef with else if is bad style.  Mixing spaces and tabs in
indentation is bad style as well.

The generated code stays exactly the same.

(rillig)

make(1): fix local variable name for determining the basename

(rillig)

make(1): clean up comments and braces in arch.c

(rillig)

make(1): make Arch_ParseArchive simpler

Neither '\0' nor ')' have ever been space characters.

(rillig)

make(1): remove lengthy comments from archive handling

The relevant information is already documented on OP_ARCHV, but only
since a few weeks.

(rillig)

make(1): don't modify GNode name while rebuilding the suffix graph

(rillig)

make(1): extend test suff-lookup.mk

This test ensures that FindSuffByName behaves correctly.

In order to convert some char pointers to const char pointers, there
needs to be FindSuffByNameLen, and to make sure that this function
actually uses the given length, this test has the suffixes ".sho" and
".short".  Without the proper string comparison in FindSuffByNameLen,
the suffix ".short" might be found when searching for ".sho".

(rillig)

make(1): improve local variable names in SuffFindThem

(rillig)

make(1): add test for looking up suffixes

(rillig)

support mmap()

(macallan)

make(1): improve variable names in SuffRebuildGraph

(rillig)

make(1): fix typos in comments

(rillig)

make(1): convert error level for Parse_Error to an enum

(rillig)

make(1): add test for dependencies of the form '%.o: %.c'

(rillig)

make(1): rename GNode.cmgn to youngestChild

The name is longer than before but also clearer.

(rillig)

make(1): add test for .END depending on another target

(rillig)

make(1): add test case in which .BEGIN depends on .END

Just for fun.

(rillig)

make(1): add test for the '::' dependency operator

(rillig)

Do not force bootselector MBR code for installs with only a single named
partition.

(martin)

Do not force alignment of the first partition by default (which is
treated special to skip the first track), unless an existing partition
table hints at it.

(martin)

make(1): negate OP_NOP and rename it to GNode_IsTarget

(rillig)

make(1): merge duplicate documentation for OP_NOP

(rillig)

make(1): only define TRUE and FALSE if necessary

For -DUSE_ENUM_BOOLEAN, the macros are not necessary.

(rillig)

make(1): allow compilation with Boolean implemented as char

(rillig)

Add missing prop_object_release() to the E250/E450 patches.
Use the recently added (in r1.2) functions for SPARCle i2c devices too.
Simplify adding "compatible" entries and handle cases where there is none.

(jdc)

make(1): add tests for the variable named ""

(rillig)

make(1): add test for variable name aliasing

(rillig)

make(1): rename Shell fields

Some of them should have been in an anonymous union, or should just kept
as separate fields.  There is only a small, fixed number of shells,
therefore it doesn't make sense to squeeze two completely separate
meanings into a single field just because that field happens to have a
fitting data type.

(rillig)

make(1): describe the Shell fields by topic

Describing each field in isolation does not help to understand how these
fields work together.

(rillig)

renice: Make usage match man page more.

(wiz)

Fix macro use, sort.

(wiz)

make(1): add field names in declaration of DEFSHELL_CUSTOM

(rillig)

make(1): remove unused null shell

(rillig)

make(1): add target-specific COPTS when generating cpre or casm

(rillig)

make(1): decorate shell declarations with field names

Without these names, the declarations were hard to read, even though
they were already grouped into lines.  This grouping was inconsistent
though and the many string literals were hard to tell apart.

(rillig)

Move E250 and E450 i2c patches from dev/pcfiic_ebus.c to sparc64/ofw_patch.c.
They are now co-located with the other OFW patch routines.
New i2c devices are created for E250/E450 and v210/v240, so create new
functions to avoid duplicate code.

(jdc)

make(1): add test for dollar in .MAKEFLAGS target

(rillig)

make(1): move tests from cond2.mk to varmod-ifelse.mk (fixup)

(rillig)

make(1): move tests from cond2.mk to varmod-ifelse.mk

(rillig)

make(1): move comment in Var_Set_with_flags

Until 2000-05-11, that comment was just above a VarFind call.  20 years
later, it is back again where it belongs.

(rillig)

Fix typo in comment.

(wiz)

Use MI acpi_intr_establish_irq instead of MD intr_establish

(jmcneill)

Add acpi_intr_establish_irq, which is like acpi_intr_establish except
it takes a struct acpi_irq * instead of ACPI_HANDLE. Useful if a device
has more than one IRQ resource (acpi_intr_establish always picks the
first).

(jmcneill)

ossaudio(3): Add an implementation of SNDCTL_CARDINFO

Correct some of the counts returned by SNDCTL_SYSINFO so this works.

(nia)

Ammend ticket #1118 and note release doc changes.

(martin)

Pull up following revision(s) (requested by maya in ticket #1118):

external/mit/xorg/lib/freetype/freetype/config/Makefile: revision 1.4

Build fixes for freetype 2.10.4

(martin)

Comment out (and fix typo in) dedication for 9.0 release

(martin)

make(1): convert JobState and JobFlags to enum types

Both GCC and Clang complained when JobFindPid had its parameter "status"
as an int.  Strangely both compilers complained about a comparison
between unsigned and signed int, even though enums are defined to be
int, not unsigned.

(rillig)

make(1): inline CondFindStrMatch into FuncMake

(rillig)

make(1): remove void pointers from addErrorCMD

(rillig)

make(1): add test for .ERROR_CMD in jobs mode

(rillig)

make(1): add test for MAKE_PRINT_VAR_ON_ERROR

(rillig)