make(1): clean up local variables in Parse_DoVar

The variable "line" was misnamed since it turned from the beginning of
the line to the variable name.  The variable "cp" was named too broadly.
Having two moving pointers in a single parsing function was too much.

Now p is the only moving pointer.  From it, the variable name and value
are extracted as the pointer flies by.  These more specific names make
the lower half of the function more readable since Var_Set(name, value)
sounds more correct and to the point than Var_Set(line, cp).

Memory management for the possibly expanded variable value is now
simpler as there may or may not be an expanded value, and that is freed
in every case.  No need for another Boolean variable called freeCp
anymore.  Distinguishing between the unexpanded value and the actual
value highlights the data flow.

Using const pointers is a step into the direction of having a parser
that operates on a read-only string.  Right now the string is destroyed
upon parsing.

(rillig)

make(1): fix out-of-bounds memory access in Parse_DoVar

When a line starts with "=value", this is interpreted as a variable
assignment, with an empty variable name.  In that case, there is no
"previous character" from the '='.  Accessing that character therefore
was an out-of-bounds read access.

If a whole file starts with "=value", instead of just a single line,
this out-of-bounds access can actually lead to a segmentation fault.
This depends on the memory allocator though.

(rillig)

make(1): only use the VARE_ASSIGN flag if necessary

When checking the right-hand side of a variable assignment for syntax
errors, it does not matter  whether a '$$' is expanded to '$' or kept as
'$$'.

(rillig)

Add missing __{BEGIN,END}_DECLS in order to catch up with
sanitizer_linux_libcdep.cc rev 1.17:

http://cvsweb.netbsd.org/bsdweb.cgi/src/external/gpl3/gcc/dist/libsanitizer/sanitizer_common/sanitizer_linux_libcdep.cc#rev1.17

Fix build with HAVE_GCC=9.

(rin)

make(1): add basic tests for the += assignment operator

(rillig)

Fix ramdisk overflow:

- switch to x_disklabel (drop non-native label support)
- switch to x_fsck_ffs and x_newfs (drop byte-swapped and Apple UFS support)
- switch to more

(rin)

Fix ramdisk overflow:

- switch to x_disklabel (drop non-native label support)
- switch to x_fsck_ffs and x_newfs (drop byte-swapped and Apple UFS support)
- switch to more

(rin)

Fix miniroot overflow by switching to x_fsck_ffs and x_newfs
(drop byte-swapped and Apple UFS support).

(rin)

make(1): add test for combining :sh with +=

(rillig)

make(1): make documentation of Error more precise

(rillig)

make(1): add another test for parsing :sh assignments

(rillig)

KNF

(skrll)

make(1): test another edge case for the :sh assignment

(rillig)

make(1): fix parsing of the :sh assignment operator modifier

(rillig)

make(1): add tests for parsing assignments, especially :sh

Luckily nobody uses the :sh variable assignment modifier since its
syntactical variant != is simpler.

(rillig)

Ensure event_thread stays in event loop upon creation.

(nat)

make(1): replace strcpy with memcpy in Hash_CreateEntry

The string length is already known, no need to recalculate it.

(rillig)

make(1): remove unnecessary code from Hash_DeleteEntry

This function is only called 2 times, and both callers pass valid
arguments.

(rillig)

autoconf: Blame devices holding up boot with config_pending.

Blame message requires `boot -x' (AB_DEBUG).

Fix ata so it doesn't mismatch config_pending_incr/decr devices.

(riastradh)

PR/55693: Andreas Gustafsson: factor(6) lists factors in wrong order
Sync with FreeBSD and change their -h (that printed hex) to -x because
we were already using -h.

(christos)

make(1): clean up hash table implementation

Having the hash function potentially redefined is a bit too much
flexibility.  If actually needed, this should be done using a patch, not
using the C preprocessor.

Converting the macro to a function made the control flow easier to
understand.  It also revealed that the variable p was unnecessary in
both Hash_FindEntry and Hash_CreateEntry.

(rillig)

make(1): clean up #include sections

(rillig)

make(1): remove dead store in ParseGetLine

GCC 5 didn't dare to optimize this by itself.

(rillig)

make(1): inline macro ISEQOPERATOR

The name of the macro was wrong.  These characters are not used in an
equality operator, it's an assignment operator.

(rillig)

make(1): use consistent pattern for parsing whitespace

The pp and cpp in the function names stand for "parsing position" and
"const parsing position".

(rillig)

make(1): add unit test for the Towers of Hanoi puzzle

(rillig)

PR 55384: detangle pm->ptstart from the "install" flag (selecting a
target partition). Instead introduce a new PTI_INSTALL_TARGET per partition
flag and deal with it in the partitioning backends.

Honour pm->ptstart when allocating new partitions - it is supposed to be
the first sector usable by NetBSD.

(martin)

- centralize number parsing code
- enable -g
- KNF

(christos)

bump libc for set_rpc_maxgrouplist

(christos)

bump for set_rpc_maxgrouplist

(christos)

add set_rpc_maxgrouplist

(christos)

Add set_rpc_maxgrouplist

(christos)

add set_rpc_maxgrouplist(3)

(christos)

New sentence, new line.

(wiz)

Add -A (noac) option to turn off the attribute cache. (Maciej W. Rozycki)

(christos)

Add a comment describing the rpb::rpb_vptb field.

(thorpej)

Provide an alternate delay function that uses the Qemu get-time hypercall.

(thorpej)

Qemu loads the kernel directly, and so there's no bootloader to provide
a "bootinfo" structure for us.  Qemu does, however, place a Linux kernel
parameter block at kernel_text[] - 0x6000 that contains Linux-style kernel
command line arguments.  So, add a prom_qemu_getenv() that allows us to
look for specific things passed along to the kernel from there, and use
them as follows:

- Support specifying the root device in the forms "root=/dev/wd0a",
  "root=wd0a", or "rootdev=wd0".
- Support SRM-like -flags ... in the form of "flags=AD".  In the case of
  Qemu, we also assume that no flags=... is the same as "flags=A", i.e.
  perform an auto-boot.

Also allow an alternate delay() function to be specified, if the platform
wishes to provide one.

(thorpej)

make(1): add test demonstrating the Towers of Hanoi puzzle

It's not the primary task of make to handle procedure calls with
parameters, combined with lexical scoping, therefore the code does not
look as straight-forward or clean as in other programming languages.  It
feels more like squeezing a programming problem from the imperative
world into the world of declarative dependencies.

A more idiomatic way of implementing this puzzle should be as a
dependency graph since that's both the natural structure of the puzzle
and the primary domain of make.  Something like having a main target
"hanoi-5" that depends on intermediate targets of the form
"move-1.2.3.4.5-_._._._._-_._._._._", each representing a single
configuration of the stacks.  These targets could be generated
dynamically.  A benefit of this implementation would be that the puzzle
could be resumed from an arbitrary configuration, just just from the
initial configuration.

(rillig)

make(1): demonstrate naive output filtering with csh in parallel mode

(rillig)

make(1): fix shell definition for csh

The bug has been there since at least 1993-03-21.  This is strong
evidence that nobody has ever used the csh in parallel mode.

(rillig)

make(1): demonstrate wrong output when using csh in parallel mode

(rillig)

make(1): refine test for printing commands using csh

(rillig)

make(1): inline Str_FindSubstring in JobOutput

(rillig)

make(1): inline Str_FindSubstring in ModifyWord_Subst

(rillig)

make(1): add tests for the various supported shells

(rillig)

Filter out the VUSECOUNT_GATE bit

(christos)

MMIO configuration space is in guest byte order. AArch64 BE is special,
as the guest starts in LE and we switch to BE after the kernel starts.
For this case, we need to byte swap all config space accesses.

(jmcneill)

make(1): replace backslash-newline with ordinary string literals

The character sequence backslash-newline is not mentioned in ISO C99.

(rillig)

make(1): allow to disable debug logging options

This is only intended for the unit tests, to selectively enable and
disable debug logging as needed.  Previously the tests for debug logging
required complicated postprocessing that was not obvious when looking at
the test .mk file alone, but was specified externally in
unit-tests/Makefile.

This is the simplest possible implementation.  Another variant would
have been to selectively disable individual debug logging options, but
that would have made the code more complicated.

The -dL option is not affected by -d0 since that is not really a debug
option, even if it is implemented as one.

(rillig)

make(1): extract ApplyModifier_Literal into separate function

(rillig)

make(1): extract ApplyModifier_Unique into separate function

(rillig)

make(1): in lint mode, reject modifiers without delimiter

The expression ${VAR:LPL} must now be written as ${VAR:L:P:L}.  The
manual page has never documented that some modifiers don't need to be
delimited by ':' and others need to.  That would have been unnecessarily
confusing anyway.

(rillig)

make(1): add test for variable modifiers without delimiter

(rillig)

make(1): ignore -env and -literal in assignments to .MAKE.EXPORTED

Previously, assigning the string "-env" to the variable .MAKE.EXPORTED
had the same effect as the .export-env directive.  This was only due to
a sloppy implementation, not by design.

For the string "-literal" and the directive .export-literal, the
situation was even worse since the actually executed code was a wild
mixture between .export and .export-literal that in the end exported the
expanded form of the variable.  Therefore there was no practical use
case of this implementation flaw.

(rillig)

make(1): do not export variable names starting with '-'

By convention, names of environment variables consist of uppercase
letters and underscores.  Most of them start with an uppercase letter.
In a few cases, the names also contain lowercase letters, such as in
http_proxy.

Variable names starting with a hyphen are confusing and might be
mistaken as command line options.  Therefore don't export these.

This also affects a few edge cases that don't occur in practice, such as
setting .MAKE.EXPORTED=-env or .MAKE.EXPORTED=-literal.  These had not
worked as expected anyway.

(rillig)

make(1): clean up confusing code in Var_Export

The generated code stays exactly the same.

(rillig)

make(1): format code in arch.c

(rillig)

Add missing __BEGIN_DECLS/__END_DECLS to force function declarations into
the "C" namespace.

(martin)

make(1): explain the purpose of the test make-exported

(rillig)

make(1): add test for .export-literal

(rillig)

make(1): add test for the -dF option

(rillig)

make(1): add test for the -df debug option

(rillig)

make(1): add test for the -dj debug option

(rillig)

make(1): add test for the -dl command line option

(rillig)

make(1): fix indentation of code for printing enum values

(rillig)

G/C

(skrll)

make(1): use hash table for looking up open directories by name

As long as there are less than 20 open directories, it's perfectly fine
to use a doubly-linked list for name lookup.  A singly linked list or
even an array list would have been better, but anyway.

When the number of directories rises above 1000, which happens with
dirdeps.mk, linear list lookup becomes too expensive, especially since
each list entry is compared using a strcmp call, in a callback function
that is not inlined.

Using a hash table is much more efficient than linear lookup.  While
here, abstract all operations regarding the openDirectories list into a
new data type that provides a simple and straight-forward API.  This
strongly typed API is especially important since the current
implementation of the list and hash table is weakly typed, using void *
for the actual data, and StringList and CachedDirList refer to the
exactly same type, they just have different names to help the human
readers but don't provide any type safety.

(rillig)

make(1): add test for repeating the :L variable modifier

(rillig)

make(1): add tests for parsing and exporting variables

Once again, there are a few surprises deeply hidden inside the edge
cases.

(rillig)

make(1): add test for the special .PATH target and variable

(rillig)

make(1): in ApplyModifier_To, update pp in each branch

Before, the parsing position was updated once at the beginning, which
didn't make sense.  Updating it in each branch allows to decide for its
appropriate value in each branch individually.

(rillig)

undo previous for 'r' and 'e' modifiers; they should no go further than
the last '/'.

(christos)

Build arm64.img for aarch64eb with a LE FFS, and include GENERIC64 in
release builds.

(jmcneill)

Revert rev 1.5:
http://cvsweb.netbsd.org/bsdweb.cgi/src/sys/dev/fdt/dw_apb_uart.c#rev1.5

The device is capable to recognize break signal actually.
Reset cnmagic from +++++ to default.

Pointed out by jakllsch. Thanks!

(rin)

Do not assume that _lwp_getprivate() returns unbiased private pointer

Cherry-pick and adapt:

>From 2a9ce60de98e53198047daaeeec3cf09ece4e693 Mon Sep 17 00:00:00 2001
From: Kamil Rytarowski <n54@gmx.com>
Date: Fri, 2 Oct 2020 16:13:09 +0200
Subject: [PATCH] [compiler-rt] [netbsd] Improve the portability of
ThreadSelfTlsTcb

Use __lwp_gettcb_fast() and __lwp_getprivate_fast(), as _lwp_getprivate()
can be a biased pointer and invalid for use in this function on all CPUs.

(kamil)

Slightly nicer default colors for various X11 apps

(nia)

xterm: Enable SIXEL graphics support.

could also enable REGIS, it will require -lm and i suppose isn't
a default upstream yet(?)

test with "-ti vt340".

(nia)

remove redundant $

(nia)

make(1): clean up documentation of Main_ParseArgLine

The previous documentation contained lots of irrelevant implementation
details.

(rillig)

make(1): add missing const for Parse_AddIncludeDir

(rillig)

make(1): clean up option handling

The test for argvalue == NULL for the individual options was unnecessary
since that is already done in the common part.

(rillig)

make(1): format code in MainParseArgs

(rillig)

make(1): extract handling of the -m option into separate function

(rillig)

make(1): extract option handling for -j/-J into separate functions

(rillig)

make(1): extract MainParseArgChdir into separate function

This removes the struct stat from MainParseArg.

(rillig)

make(1): extract MainParseArg into separate function

That part of the code is long enough and independent enough to get its
own function.  Having a struct stat in MainParseArgs just didn't feel
like a correct abstraction level.

(rillig)

make(1): remove redundant function prototypes

(rillig)

xeyes: Enable anti-aliasing with XRENDER

If you prefer the "classic" look, "xeyes +render"

(nia)

make(1): add note about "..." with duplicate shell commands

(rillig)

Reset the entries for drochner and dsl

i386 and amd64 are now maintained by core.

(kamil)

Remove

(kamil)

Drop TODO.ptrace

The remaining issues are mostly tracked in the ATF ptrace tests and GDB
or LLDB test-suite.

(kamil)

Drop TODO.sanitizers

The LLVM work is merged mostly to GCC.
The remaining work is not worth tracking here and is restricted mostly to
fixing bugs from various 'make check-*' targets in LLVM.

(kamil)

synaptics: Emulate scrolling when the middle button is held with TrackPoints

idea stolen from various other operating systems.

this configurable with a sysctl in case somebody wants to hold the middle
button, e.g.  with old window managers that close menus when a button is
released.

(nia)

erect a signpost for weary travellers

(nia)

comment was likely true in 2007 but no longer reflects the reality of hw

(nia)

Link librumpclient explicitly. Fix sun2, i.e., MKPIC=no build.

(rin)

Fix evbarmv5 build

(skrll)

KNF (and some newlines)

(skrll)

Fix build

(skrll)

KNF

(skrll)

fix build error with LLVM

(ryo)

Fix up the debug stuff for if_tap and if_vether

(pgoyette)

Fix off-by-one in channel count, from Mark Millard.

(jmcneill)

Add if_tap directory for DEBUG builds.

(roy)

Fix
% set x='a/b c/d.e'
% echo $x:q:h

(christos)

Be like other tests and speciy the binary name we install

(roy)

Add missing lint library

(christos)

Fix prior

(roy)

Improve a comment

(skrll)

Move el[01]_trap_exit into vectors.S where the callers exist

(skrll)

Set sc_fifolen=1 for the no fifo case

(jmcneill)

Add rump_open_tap

(roy)

tap(4): update the test so that we can open the tap to ping across a bridge

ping with tap closed to ensure it fails
ping with tap open to ensure it works

(roy)

add linux compatible /proc/cpuinfo

(ryo)

add some fields of ID_AA64ISAR1_EL1 definition (ARMv8.6)

(ryo)

Revert previous - test is a shell script, no debug info installed

(martin)

Add if_vether debug dir

(martin)

add missing new if_vether subdir.

(mrg)

make(1): extract ApplyModifier_Quote into separate function

(rillig)

make(1): remove redundant assertions in lst.c

These pointers are dereferenced shortly after the assertion, which
reliably leads to a SIGSEGV.

(rillig)

make(1): fix typos in test for the :L variable modifier

(rillig)

make(1): fix bug in evaluation of indirect variable modifiers

Since 2020-09-22, when indirect variable modifiers were applied to a
variable expression based on an undefined variable, these modifiers did
not change the state of a variable expression from undefined to defined.
The modifiers that do this are :D, :U, :L, :P.  Minimal example:

${VARNAME:${:UL}}

The :L modifier from the inner expression sets the value of the outer
expression to its variable name, in this case "VARNAME".  The outer
expression was not marked as being defined though, which resulted in a
"Malformed conditional" error.

In the commit from 2020-09-22, vardebug.exp had changed a lot, and I had
not inspected the change closely.  The important detail was in lines 56
and 60, where VAR_JUNK|VAR_KEEP changed into VEF_UNDEF, thereby losing
the VEF_DEF bit.

(rillig)

make(1): demonstrate bug in evaluation of indirect variable modifiers

Reported by sjg.

(rillig)

Add some KNF whitespace.

(simonb)

Collapse all CPU_CORTEXA<n> options into CPU_CORTEX and do runtime
detection instead of ifdefs where required.

(jmcneill)

vether(4): Add ATF tests based on the tap(4) tests.

(roy)

inet: Treat LINK_STATE_UNKNOWN as LINK_STATE_UP when changing

It's something we have always done.
it's really rare for anything to transition to UNKNOWN from either
UP or DOWN, but technically it is possible.

(roy)

make(1): rename ShortVarValue to UndefinedShortVarValue

(rillig)

make(1): add test for using the :D variable modifier as comment

(rillig)

make(1): remove unused assignments to local variables

These only became obvious once ApplyModifier had been extracted, which
shrank the source code of ApplyModifiers by about 100 lines.

Even GCC 5 had seen that they are redundant and had not generated any
code for them.

(rillig)

rumpify vether(4)

(roy)

make(1): extract ApplyModifier from ApplyModifiers

This allows a return, instead of a variable assignment followed by a
break, saving a few lines of source code.

The size of the resulting binary shrinks as well, even though the code
is essentially the same as before.

(rillig)

libtap: Improve comment

(roy)

make(1): fix test job-output-long-lines

The test failed on Linux since the test relied on the two child
processes interleaving each other.  This is not guaranteed to happen
though.

(rillig)

Fix RPI (armv6) build

(skrll)

Whitespace

(roy)

Fix build with clang.

(roy)

Apply patch provided by Izumi Tsutsui in PR 55382: make ext2 partitions
show up in the outer (MBR) partition table, needed for example on Cobalt
where firmware boots from that partition.

(martin)

PR 55381: try to deal with moved (but not yet saved) partitions when
calculating free space

(martin)

When reporting an error before daemonizing, prefix the error message
with the program name.

(gson)

xinstall: define MAKE_NATIVE so our make parts compile

(roy)

Add [-]eee and [-]vlan-hwfilter.

(msaitoh)

Log a message when a process blocks due to a lack of entropy.
Discussed on tech-kern.

(gson)

s/settng/setting/

(msaitoh)

s/implicitely/implicitly/

(msaitoh)

s/occurence/occurrence/

(msaitoh)

s/parition/partition/

(msaitoh)

Improve time keeping and host CPU usage when running in Qemu:
- clockattach(): Allow multiple calls when running in Qemu. Anything
  after this first one is ignored, but this gives us a change to use
  a clock source provided by the VM directly, rather than relying on
  a more expensive hardware emulation.
- Add cpu_initclocks_secondary(), to handle clock setup on secondary
  CPUs, if needed.
- Allow us to use the WTINT PALcode call in cpu_idle() to idle in a lower
  power state (Qemu's PALcode supports this).
- Use the Qemu per-cpu set-alarm-rel call as the hardclock interrupt
  source.  In Qemu environments, reduce hz to 50 (rather than the
  default 1024) to give the clock a snowball's chance when running on
  a host system with hz=100.  XXX We have to manually re-calculate
  tick and tickadj.  There should be MI code to do this for us.  Also
  in Qemu environments, let hardclock() drive the sched clock by setting
  schedhz=0.

(thorpej)

mcclock_init(): Only do our work if called on the primary CPU.

(thorpej)

If running in Qemu, don't report stray edge-triggered ISA interrupts.
Works around an issue I obvserved with serial console in Qemu.

(thorpej)

Add alpha_pal_wtint(), which invokes the WTINT PALcode call.

(thorpej)

Add a slow twiddle option.  This speeds up a pmax netboot by 15% and
is only 1% slower than no twiddle.

(simonb)

make(1): replace Lst_Open with direct iteration

(rillig)

make(1): replace += 1 with ++ and -= 1 with --

Just for visual consistency.  The generated code stays exactly the same.

(rillig)

make(1): migrate Make_ProcessWait from Lst_ForEachUntil to Lst_ForEach

(rillig)

make(1): remove the inline attribute from debug_printf

The code size overhead of a varargs function is much more than I had
expected.  Since GCC 5 didn't inline the function anyway and it is only
used in debug mode, there is no point keeping multiple copies of that
code around.

(rillig)

make(1): make debug logging simpler

This avoids referring to the debug_file variable in many places where
this implementation detail is not necessary.

(rillig)

make(1): extract logging from ApplyModifiers into separate functions

These two logging blocks are massive enough to disturb the reading flow
of the remaining code.

Even without these two blocks, ApplyModifiers is still 250 lines long,
which is quite much.

(rillig)

make(1): move variable modifier :sh into separate function

(rillig)