Note that opening and closing the tun/tap devices affects link state.

And how this influences Duplicate Address Detection.

(roy)

tun: Report link state based on if the interface has been opened or not

This mirrors tap(4).

(roy)

make(1): remove nonexistent function from header

(rillig)

bridge: When an interface joins then mark addresses on it as tentative

The exact flow is detatch addresses, join bridge and then mark detached
addresses as tentative.
This ensures that Duplicate Address Detection for the joining interface
are performed across all members of the bridge.

(roy)

make(1): fix type of Shell.noPLen

(rillig)

make(1): reduce line noise in Job_ParseShell

The generated code is exactly the same.

(rillig)

Wups, forgot to commit this with vether.

(roy)

make(1): fix indentation in Job_ParseShell

(rillig)

add -s option for 'power' command, this instructs the controller to save
the value so it persists resets/whatnot; the NVMe specification lists
this as optional, so this only works if the controller supports it

(jdolecek)

make(1): add test cases for the :range variable modifier

(rillig)

If there is no current partitioning manager assume we are editing the
current system and make target_already_root() return true.
Fixes various fallout when using sysinst post installation.

(martin)

Fix display of timezone selection menu

(martin)

print current power state and workload as separate values for
'nvmectl power nvme0'

(jdolecek)

make(1): fix punctuation and add paragraphs in config.h comments

(rillig)

make(1): in the Buffer functions, rename bp to buf

It's not necessary to emphasize on the pointerness of the variable since
that's obvious from the context.

(rillig)

de-quadruplicate, remove unused argument

(christos)

make(1): rename Buf_Size to Buf_Len

The new name better matches the field name Buffer.len as well as the
variables around the calls to this function.

(rillig)

show APSTA support status in identify

(jdolecek)

add definition of the bit indicating support for APSTA

(jdolecek)

make(1): prefer positive array index in Buf_AddByte

Ideally the condition for allocating more memory would have been
(old_len + 2 > bp->cap) since that's the actually intended wording.  But
GCC 5 neglected to generate good code for that on x86_64, so be it.

(rillig)

make(1): rename Buffer fields

It was confusing to have a function Buf_Size that returns buf->count
even though there is also buf->size.

(rillig)

make(1): replace direct access to Buffer fields with inline function

This way, renaming the fields of the buffer is restricted to only buf.h
and buf.c.

(rillig)

bridge(4): Note that the bridge does not allow assignment of IP addresses

Document using vether(4) instead to get the same effect.

(roy)

tap(4): Improve the description to differentiate from vether(4)

(roy)

Fix punctuation nit and add RCS Id.

(wiz)

vether: Add to kernel configurations

It's only enabled if the kernel enabled bridge AND tap.
Otherwise it's commented out.

(roy)

Note import of vether(4)

(roy)

tap: Report link state based on if the interface has been opened or not

While a nice addition, it does render tap(4) useless as a bridge(4)
endpoint. We now have vether(4) for use as bridge endpoint.

(roy)

vether: Implement a virtual ethernet interface

The vether interface simulates a normal Ethernet interface by encapsulating
standard network frames with an Ethernet header, specifically for use as
a member in a bridge(4).

To use vether the administrator needs to configure an address onto the
interface so that packets can be routed to it. An Ethernet header will
be prepended and, if the vether interface is a member of a bridge(4),
the frame will show up there.

Taken from OpenBSD.

(roy)

make(1): inline Lst_ForEachUntil in Make_ExpandUse

The tricky detail here is that the current node from the iteration is
removed if it is no longer needed.

The Lst_FindDatum that has been removed was both inefficient and
misleading since it could never return null, yet there was a null check
for it.  The callback API from Lst_ForEachUntil would have required to
define a custom struct for passing this parameter to the callback
function, in addition to the parent node.

Inlining the whole Lst_ForEach and passing the list node as a parameter
is much more obvious.

(rillig)

make(1): run tests with jemalloc debugging enabled

This protects against very simple memory allocation bugs such as
migrating Lst_ForEachUntil to Lst_ForEach without remembering that
Lst_ForEachUntil can handle the situation where the current list node is
removed from the list, but Lst_ForEach cannot.  This happens in
Make_ExpandUse, for example.

(rillig)

make(1): inline Lst_ForEachUntil when parsing dependency lines

This avoids a few operations on void pointers.

(rillig)

make(1): remove redundant null checks for the active targets

Before August 2020, the Lst library passed null pointers through.  This
was a confusing design pattern that has been removed since.  Now the Lst
functions fail fast on null pointers.

The 'targets' list is one of the few places where there is indeed an
optional list that may sometimes be null.  Back then, there was not
enough inline documentation to understand when the targets list was null
and when it wasn't.

Now that the documentation is there, the redundant and thereby
misleading null checks are no longer useful.

(rillig)

make(1): inline PrintNode

Having a separate function had only been necessary for Lst_ForEachUntil.

(rillig)

make(1): inline Lst_ForEachUntil in ParseDoDependency

(rillig)

Use HAVE_NVMM for nvmm headers

(jmcneill)

make(1): inline Lst_ForEachUntil in Targ_PrintNodes

Printing a node does not modify the structure of the node, therefore the
additional housekeeping of Lst_ForEachUntil is not needed here.

Inlining the callback function also removes a lot of pointer stuff that
is more difficult to read than necessary.

(rillig)

make(1): inline Lst_ForEachUntil in Compat_Make

This avoids the extra local function and a few conversions to void
pointers, to gain additional type safety.

The code in Compat_RunCommand does not modify gn->commands structurally,
therefore it does not need the extra complexity of Lst_ForEachUntil.  It
does have access to a list node to exactly this list.  This list node is
only used to set the command to NULL after processing it, not for
removing the node from the list.

(rillig)

make(1): rename local variable in MakeNodes

By convention, list nodes are named ln to distinguish them from GNodes,
which are called gn.

(rillig)

make(1): make parameter of Compat_RunCommand const

(rillig)

make(1): clean up comments in job.c and make.c

(rillig)

only look for cpunode.h on OCTEON.  that's the only direct
caller of *_kern_nonmaskable_intr().

(mrg)

Ticket #1610

(martin)

Pull up following revision(s) (requested by kardel in ticket #1610):

sys/dev/ic/ld_nvme.c: revision 1.24 (patch)
sys/dev/ic/nvme.c: revision 1.50 (patch)

PR kern/55674:
move name space availability check from ld_nvme.c:ld_nvme_attach()
to nvme.c:nvme_rescan().
this avoids allocation of ld(4) instances for every possible
name space, even if it is not usable. it also reduces the device
node flood generated from that strategy.

(martin)

Ticket #1094

(martin)

Pull up following revision(s) (requested by kardel in ticket #1094):

sys/dev/ic/ld_nvme.c: revision 1.24
sys/dev/ic/nvme.c: revision 1.50

PR kern/55674:
move name space availability check from ld_nvme.c:ld_nvme_attach()
to nvme.c:nvme_rescan().
this avoids allocation of ld(4) instances for every possible
name space, even if it is not usable. it also reduces the device
node flood generated from that strategy.

(martin)

make(1): fix CRLF line endings in unit tests

(rillig)

fix usr.bin/make build (which uses more warnings):

remove static only prototype TargPrintOnlySrc().
PrintOnlySources() does not return a value, make it void.

(mrg)

rump: Add weak alias for bridge_calc_link_state

(roy)

note GMP 6.2.0 is in -current.

(mrg)

bridge: Calculate link state as the best link state of any member

If any member is LINK_STATE_UP then it's LINK_STATE_UP.
Otherwise if any member is LINK_STATE_UNKNOWN then it's LINK_STATE_UNKNOWN.
Otherwise it's LINK_STATE_DOWN.

(roy)

mknative-gmp output for GMP 6.2.0.

(mrg)

merge gmp 6.2.0.

(mrg)

rump: Try to fix build

(roy)

ifconfig: We already have struct if_data in ifa_data.

So let's not bother with an ioctl we don't need.

(roy)

Implement cpu_intr_redistribute() for Tusnami/Titan systems.

(thorpej)

update slightly to enable 'native-gmp' target from tools/gmp to work.
call the awk script on 'config.log', which has (almost) the same output
as the stdout of ./configure, and automatically store it as 'srcs.mk'.

(mrg)

initial working version of native-gmp support.

does not use mknative.common yet, so always updates files and does
not mark them with NetBSD rcsid.  (not a regression from the manual
version at least.)

(mrg)

redo much of rev 1.45 and make the _KERNEL path look like it
used to before.

while it uses less total lines of code and looks less ugly,
the merged crash+ddb code here is less correct and harder to
follow for the kernel path.

(mrg)

tap: Remove media from this virtual interface

It serves no purpose at all.

(roy)

vlan: match the interface link state with that of the parent

Now addresses on a vlan will detach and undergo duplicate address
dectection on link state changes just as on a standard interface.

(roy)

net: Add a callback to ifnet to notify of link state changes

(roy)

Add HAVE_NVMM and use it to control the build of NVMM related components.
Defined to "yes" on amd64, "no" everywhere else.

(jmcneill)

make(1): revert migration from Lst_ForEachUntil to Lst_ForEach

There is a crucial difference between these functions, in that
Lst_ForEachUntil can cope with a few concurrent modifications while
iterating over the list.  This is something that Lst_ForEach doesn't do.

This difference led to a crash very early in NetBSD's build.sh.

(rillig)

make(1): inline and remove LstNode_Prev and LstNode_Next

These functions made the code larger than necessary.  The prev and next
fields are published intentionally since navigating in a doubly-linked
list is simple to do and there is no need to wrap this in a layer of
function calls, not even syntactically.  (On the execution level, the
function calls had been inlined anyway.)

(rillig)

make(1): inline Lst_ForEach in Targ_PrintGraph

(rillig)

make(1): replace a few Lst_ForEachUntil with simpler Lst_ForEach

(rillig)

make(1): inline Lst_ForEachUntil in Compat_Make

(rillig)

make(1): clean up obsolete comments about TARG constants

(rillig)

make(1): remove useless comment from TargFreeGN

GNode.fname is a const char *, therefore it cannot be freed anyway.

(rillig)

make(1): inline Targ_FindNodeImpl

The 3 callers of this function passed different flags, and these flags
led to code paths that almost did not overlap.

It's a bit strange that GCC 5 didn't get that, and even marking the
function as inline did not produce much smaller code, even though the
conditions inside that function were obviously constant.  Clang 9 did a
better job here.

But even for human readers, inlining the function and then throwing away
the dead code leads to much easier code.

This pattern of squeezing completely different code into a single
function has already occurred in a different part of make, though I
don't remember where exactly.

(rillig)

make(1): clean up API for finding and creating GNodes

The previous API had complicated rules for the cases in which the single
function returned NULL or what it did.  The flags for that function were
confusing since passing TARG_NOHASH would create a new node even though
TARG_CREATE was not included in that bit mask.

Splitting the function into 3 separate functions avoids this confusion.
It also reveals several places where the complicated API led to
unreachable code.  Such code has been removed.

(rillig)

make(1): add test for '::' dependency operator with .ALLTARGETS

(rillig)

make(1): replace Hash_FindEntry with Hash_FindValue in Targ_FindNode

(rillig)

make(1): add Hash_FindValue, for direct access to hash table data

(rillig)

RCSId police

(skrll)

Define isb(), dsb(option), and dmb(option)

Catch up with vchiq upstream to allow this.

(skrll)

net: Fix the setting of if_link_state

Link state changes are not dependant on the interface being up, but we also
need to guard against more link state changes being scheduled when the
interface is being detached.

We do this by clearing the link queue but keeping if_link_sheduled = true.
We can check for this in both if_link_state_change() and
if_link_state_change_work() to abort early as there is no point in doing
anything if the interface is being detached because if_down() is called
in if_detach() after the workqueue has been drained to the same overall
effect.

(roy)

Moving pointers could fail if realloc() allocates a new memory region
where the difference between old and new address exceeds an int. Use
ptrdiff_t for calculations instead.

(mlelstv)

Trailing whitespace

(skrll)

G/C arm/atomic.h

(skrll)

Expose the atomicvec vectors via EXPORT_OBJECT so ksyms(4) address
lookups can find them.

(simonb)

Use EXPORT for start and EXPORT_OBJECT for kernel_text instead of
by-hand exporting.  Using EXPORT_OBJECT for kernel_text also fixes
"bt/a" from DDB.

(simonb)

Add EXPORT_OBJECT - export definition of symbol of symbol type Object,
visible to ksyms(4) address search.

(simonb)

note mpfr needs a cleaning.

(mrg)

note mpc (1.2.0) and mpfr (4.1.0) have new versions and are also
updated to them.  note gmp has a new release (6.2.0).

(mrg)

updates for mpc 1.2.0.

(mrg)

updates for mpfr 4.0.1.

(mrg)

empty PATCHES is needed.  revert a local change that is wrong now.

(mrg)

merge mpfr 4.1.0

(mrg)

we don't have a patch version for a while now.

(mrg)

Use 'lr' instead of 'x30' in an instruction for clarity

(skrll)

Fix a comment

(skrll)

Whitespace consistency nit.

(simonb)

Including <ddb/db_access.h> once should be sufficient.

(simonb)

Support CPU interrupt affinity on Tsunami systems.

(thorpej)

Add support for CPU interrupt affinity for PCI interrupts:
- Keep a bitmap of eligible interrupt-handling CPUs in the pci_chipset_tag_t.
  If this bitmap is 0, then we assume that all PCI interrupts should be
  routed to the primary CPU.
- Add an optional PCI chipset callback for setting the CPU affinity of
  an interrupt.
- When an establishing an interrupt handler, select the CPU that will
  handle this irq using the following algorithm:
  ==> If the irq already has a CPU assignment, keep it.
  ==> Otherwise, find the CPU with the fewest registered handlers that
      is eligible from both a hardware (based on the pci_chipset_tag_t)
      and software (based on cpu_info::ci_schedstate.spc_flags) perspectives.
  ==> Fall back to the primary CPU failing all else.

(thorpej)

- Fix some bugs in previous, mainly related to indexing the correct
  interrupt queue.
- Make sure to update cpu_info::ci_nintrhand if an irq moves from
  one CPU to another.

(thorpej)

make(1): replace a few Lst_ForEachUntil with simpler Lst_ForEach

(rillig)

make(1): fix grammar and style in test dep-colon-bug-cross-file

(rillig)

make(1): remove redundant variable inLine from parse.c

This variable has served at least 27 years bringing unnecessary
redundancy to the code.  It was already redundant at 1993-03-21, when
the code was imported to NetBSD.

(rillig)

make(1): rename ParseFinishLine to FinishDependencyGroup

Even after 27 or more years, it's not too late to fix bad function
names.  This one for example does not finish a line but a dependency
group.

(rillig)

make(1): fix missing check for duplicate commands in Parse_File

(rillig)

make(1): add test for harmless bug in Parse_File

When there is a dependency group at the end of a top-level makefile,
this dependency group is not finished properly.  This allows to add
further commands to the targets of this dependency group, which was not
intended.

(rillig)

make(1): fix undefined behavior for .MAKEFLAGS: -f file

Since at least 1993-03-21, adding other makefiles in a .MAKEFILES
dependency has invoked undefined behavior because the command line
arguments were copied directly into the global makefiles variable,
without a proper strdup.  Shortly after that, the word list created by
Str_Words (formerly brk_string) was freed.

This applies to both the -f and the -v and -V options.  Luckily it is an
edge case to use these options in .MAKEFLAGS at all.

The -T option had already been fixed at 2000-12-30, but not the other
options.

(rillig)

make(1): inline Lst_ForEachUntil in ParseLine_ShellCommand

(rillig)

make(1): extract ParseLine_ShellCommand from Parse_File

Parsing a single shell command from a line does not belong in
Parse_File, its proper place is in Parse_Line.  Having the whole
detailed code inline in Parse_File is even more confusing.

(rillig)

make(1): rename variables cp2 to be more expressive

(rillig)

make(1): add test for make() function in conditions

(rillig)

make(1): declare strings for suff.c constant

(rillig)

make(1): extract parsing of the -dF option into separate function

(rillig)

make(1): extract InitVarTarget from main

(rillig)

make(1): in FindSuffByName, return the suffix instead of a list node

None of the callers was interested in the list node.

(rillig)

make(1): add test for deleting the suffixes during parsing

(rillig)

make(1): migrate suff.c from Lst_ForEachUntil to Lst_ForEach

(rillig)

make(1): convert int to size_t for string lengths

Just for formal reasons.  There is no practical scenario in which any
filename suffix would grow larger than a few kilocharacters.

(rillig)

make(1): don't use reserved names in type names

(rillig)

make(1): replace Lst_Find with FindSuffByName

(rillig)

make(1): add tags to some of the unnamed structs

The tags prevent the structs from accidentally becoming compatible
types.

While here, remove a few typedefs for structs that are single-purpose,
since there is no point in abstracting from the actual representation of
these types.

(rillig)

make(1): rename local variables in ParseFuncArg

(rillig)

make(1): inline ArchFindArchive into ArchStatMember

This avoids a few void pointers and unnecessary function calls.

(rillig)

make(1): make code in ArchSVR4Entry simpler

(rillig)

make(1): fix type of local variable in ParseModifierPart

Thanks, Clang-Tidy.

(rillig)

make(1): fix type of local variable in ApplyModifiers

Thanks, Clang-Tidy.

(rillig)

make(1): inline Lst_ForEach in MakeUnmark

By the way, the additional argument to Lst_ForEach was not used at all.

(rillig)

spelling fixes in sd.c comments

(jakllsch)

Add one more place to notify blocklistd

(christos)

Notify blacklistd about smtp auth failures (Jeff Rizzo)

(christos)

make(1): replace a few calls to Lst_Open with simple loops

This avoids relying on the internal iterator of the list, which is
supposed to be removed in the near future.

(rillig)

Add a newline

(skrll)

Add a function to copy AC-Name and Service-Name

(yamaguchi)

make(1): document details on why JobRun runs .END in compat mode

(rillig)

update test cases for AC-Name and Service-Name

(yamaguchi)

Clear AC-Name and Service-Name if params are not specified

(yamaguchi)

Add test cases for AC-Name and Service-Name

(yamaguchi)

make(1): document expansion of undefined variables in Var_Subst

>From reading the code alone, it is not obvious what effects this
innocent-looking code has.

(rillig)

make(1): add test for partial expansion of undefined variables

(rillig)

make(1): rename local variables in Var_Subst

The variable name "str" did not make it clear enough that the pointer is
constantly moving, to parse the given string.  The name "p" expresses
this more clearly.

(rillig)

make(1): fix build on Debian 9

lst.h:92:5: error: unknown type name 'uint8_t'

It had been broken since the previous commit on 2020-09-24 08:23:29.

(rillig)

Changes to make interrupt {,dis}establish MP-safe on Alpha:
- Protect all of the system interrupt linkage with the cpu_lock mutex.
- Re-order some of the stores to the SCB vector table to make it safe
  in the face of lockless interrupt dispatch.
- Add a framework for routing interrupts to specific CPUs.  Interrupts
  are still funneled only to the primary CPU, but that will change for
  some systems soon.  Ensure that interrupt handler lists are manipulated
  only on the CPUs that handle that specific interrupt source.  This required
  a re-factor of the alpha_shared_intr_*() family of functions.
- Enable __HAVE_INTR_CONTROL, although interrupt redistribution is still
  a no-op.
- Reduce code duplication in the Jenson direct-SCB interrupt handlers.

(thorpej)

lfs: Include lfs_debug.c only if DEBUG is enabled.

(riastradh)

fix *_bs_rm_4_swap(). it was only reading 2 bytes, not 4 bytes.

pointed out by skrll@ thanks.

(ryo)

Add the generated version file

(christos)

Add version.cc

(christos)

grab the gdbserver version

(christos)

As indicated at the top of the file, don't simply remove entries.  Instead
we need to mark them "obsolete" so they will get removed if already in the
$DESTDIR

(pgoyette)

Trailing whitespace

(skrll)

no need to swap pt.cmd.cdwXX at nvme_set_number_of_queues(). cmd.cdwXX will be swapped in nvme_pt_fill().

(ryo)

apply more _KERNEL and fix the amd64 (and probably more) build.

(mrg)

fix bugs in *_bs_rm_8_swap(). it was only reading 4 bytes, not 8 bytes.

(ryo)

need to swap on big endian machines.

"The ITS command queue uses a little endian memory order model." (GIC Architecture Specification)

(ryo)

make(1): make the API of the List partially public

Accessing the fields List.first, List.last, ListNode.prev, ListNode.next
and ListNode.datum in read-only mode should be more efficient than a
whole function call.

All modifications to the lists or their nodes must still happen via
function calls.

This change reduces the code size, makes the code faster to execute and
allows Lst_ForEach to be written inline without the visual overhead of
function calls.

(rillig)

fix build on non rmx or octeon systems.

(mrg)

make(1): remove redundant function prototypes in suff.c

(rillig)

Small fixes from knakahara:

- Check return value correctly in wm_lv_jumbo_workaround_ich8lan().
- Fix comment.

(msaitoh)