Define a UPAGES_MAX constant to size the a md_upte array in MIPS's
struct mdlwp.  This is exposed to userland, so we can't use something
based on PAGE_SIZE.

(simonb)

for jp keymap map also scan code 49 to right bracket to handle ARCHISS model

PR kern/55608 by Shinichi Doyashiki

(jdolecek)

make(1): add test for the .ALLTARGETS special variable

(rillig)

make(1): add test for the :L modifier

(rillig)

make(1): add test for the :D modifier

(rillig)

make(1): fix error message for ::!= modifier with shell error

It's just too easy to confuse st->val and val.

(rillig)

make(1): add test for ::!= modifier with shell error

(rillig)

make(1): move test for the ::= modifier to varmod-assign

(rillig)

Fix a typo in a comment

(leot)

Idiot typo, generated by an idiot, fixed by the same one.

(kre)

make(1): explain the varmod-assign test

I have no idea why I added the mod-assign-nested test.  It is completely
boring and doesn't provide any insight.

(rillig)

make(1): allow make to be compiled in C90 mode

Since the inline functions are the only C99 feature used by now, setting
USER_CFLAGS='-std=c90 -ansi -Dinline=' is enough for compiling make with
a C90 compiler.

(rillig)

make(1): fix obvious bugs in -DCLEANUP mode

The outdated type name FreeProc had been renamed to LstFreeProc.
Casting the function free to it is not necessary since the type of this
function is already exactly the correct type.  Anything else would be
undefined behavior anyway.

The uninitialized sufflist in Suff_ClearSuffixes was ok until now
because the Lst functions had silently skipped any calls with invalid
arguments.  This silent skipping is a good argument to have strict
argument validation since it detects these unintended control flows.

(rillig)

make(1): allow custom build options

(rillig)

turn on fortify since it is setgid (from scole_mail)

(christos)

make(1): distinguish enum flags and values in debugging mode

When printing an enum value in debugging mode, distinguish between
bitsets containing flags and ordinary enums that just contain different
values.

Make the macros in enum.h more uniform.  Provide a simple scheme for
defining the run-time type information of enums whose number of values
is a number with more than 2 bits set in the binary representation.
This case was not obvious before, and it was pure luck that the current
interesting enum types only had 3, 10 or 32 different values.

The type with the 32 different values actually only has 31 significant
bits since the enum constant OP_OPMASK is only used when querying the
enum, not for defining or describing the possible values.  For this
reason, it was unavoidable to refactor the rtti macros, to support even
this case.

(rillig)

make(1): demonstrate how the parser handles spaces in variable names

Not that anyone would need this feature, or that it was ever intended to
be used at all.  But it is there, and if someone ever wants to fix this
part of the parser, they should at least know about this behavior.

(rillig)

make(1): add test for variable assignment using the '=' operator

(rillig)

Sort correctly, pointed by wiz@. Thank you

(ryoon)

More debug

(skrll)

RR/54971: scole_mail: sockstat command output incorrect for normal
user As the PR hints, it is not enough to have kern.expose_address=1
to see kernel addresses, we also need to have the PK_KMEM bit set
which we achieve by installing sockstat setgid kmem and opening
and closing /dev/mem. (/usr/src/sys/kern/kern_proc.c:311). It is
unfortunate that we need to give the program more privilege, to
prove to the kernel that we have the privilege to see the data.

(christos)

KNF

(skrll)

KNF

(skrll)

Only expect the fmod test case to fail when using qemu's TCG CPU emulation,
and not under hardware virtualization such as qemu -accel nvmm.

(gson)

Style on config_finalize_register arguments - make consistent will all
other callers of config_finalize_register

(skrll)

Protect tegra124_cpu_init_cpufreq against being run more than once.

config_finalize will call all config_finalize_register functions until
all registered functions return 0.  rf_autoconfig currently returns 1
which means tegra124_cpu_init_cpufreq would get called multiple times.

(skrll)

Fix getrandom() tests.

Use sigaction() without SA_RESTART -- signal() implies SA_RESTART so
we never got the EINTR.

While here, reduce the timeout to something more reasonable so we
don't waste 20min of testbed time if anything goes wrong and the
one-second alarm doesn't fire.

(riastradh)

make(1): in debug mode, print GNode details in symbols

A string like OP_DEPENDS|OP_OPTIONAL|OP_PRECIOUS is much easier to read
and understand than the bit pattern 00000089.

The implementation in enum.h looks really bloated and ugly, but using
this API is as simple and natural as possible.  That's the trade-off.

In enum.h, I thought about choosing the numbers in the macros such that
it is always possible to combine two of them in order to reach an
arbitrary number, because of the "part1, part2" in the ENUM__SPEC macro.
The powers of 2 are not these numbers, as 7 cannot be expressed as the
sum of two of them.  Neither are the fibonacci numbers since 12 cannot
be expressed as the sum of 2 fibonacci numbers.  I tried to find a
general pattern to generate these minimal 2-sum numbers, but failed.

(rillig)

Do not split for AUTHORS

And bump date.

(ryoon)

Add a missing comma

And bump date

(ryoon)

Add COMPAT_90

And bump date.

(ryoon)

Add a missing comma

And bump date.

(ryoon)

Markup authors

And bump date.

(ryoon)

Link to i386/spic(4) instead of spic(4)

And bump date.

(ryoon)

Link to i386/pnpbios(4) instead of pnpbios(4)

And bump date.

(ryoon)

Link to i386/pnpbios(4) instead of pnpbios(4)

And bump date.

(ryoon)

Fix handling of IXGBE_REQUEST_TASK_NEED_ACKINTR again...

(msaitoh)

The admin workqueue can be used even if the interface is not up.
OK'd by thorpej@. Will fixes PR#55534 reported by Shinichi Doyashiki

(msaitoh)

Restore obsolete entries for make's modorder tests.

These tests were removed a week ago, but their set list entries were
removed rather than marked obsolete.

(riastradh)

Fix ixgbe_sfp_cage_full() on X550EM_A.

In ixgbe_handle_mod():

switch (hw->mac.type) {
case ixgbe_mac_82599EB:
cage_full = IXGBE_READ_REG(hw, IXGBE_ESDP) &
    IXGBE_ESDP_SDP2;
break;
case ixgbe_mac_X550EM_x:
case ixgbe_mac_X550EM_a:
cage_full = IXGBE_READ_REG(hw, IXGBE_ESDP) &
    IXGBE_ESDP_SDP0;
break;
default:
break;
}

so I had thought that IXGBE_ESDP_SDP0 bit is 1 on cage is full.
In reality, at least, X550EM_A's SFP+ cage is 0 on cage is full.
So invert the logic of ixgbe_sfp_cage_full() on X550EM_A

(msaitoh)

Backout previous,  commiter was dazed and confused

(martin)

Fix race in ixgbe_detach() to prevent panic on shutdown.

(msaitoh)

Add modorder* make unit test files

(martin)

Fix handling of IXGBE_REQUEST_TASK_NEED_ACKINTR in ixgbe_handle_admin().

(msaitoh)

afterboot.8: If it needs a disclaimer that most people shouldn't do it...

(nia)

uname -p, pointed out by various

(nia)

Keep the change check invariant intact. The previous code could miss
status updates by picking up a new status different from the tested
status. This left addresses in the DETACHED state although the
link status is already UP again.

addresses PR/kern 55538

(kardel)

afterboot.8: uname -p, pointed out by various people

(nia)

afterboot.8: Start the daemons after configuring wpa_supplicant.

(nia)

afterboot.8: Use wpa_* for everything WiFi, update links

reasoning: ifconfig scan is unreliable while wpa_supplicant is running

(nia)

Appease gcc when building with KASAN which gave this error before

error: stack usage might be unbounded [-Werror=stack-usage=]

(skrll)

Expect a failure to trap unaligned acesses only when running under
qemu's TCG CPU emulation, not when running under hardware virtualization
such as qemu -accel nvmm.

(gson)

s/ressource/resource/. No functional change.

(msaitoh)

s/ressource/resource/. Found by knakahara.

(msaitoh)

Remove extra PHY_RESET(sc) in the MII_TICK path because it's not requierd
to just restart autonego.

(msaitoh)

Don't do full initialization for autonego when just restarting autonego
because it's not required.

This change reduce extra initialization which include PHY_RESET() which
caused long delay(max 500ms).

(msaitoh)

make(1): remove redundant range restriction

re.re_nsub is at least 0, and (at least 0) + 1 cannot be 0.

(rillig)

Nix trailing whitespace.

(riastradh)

make(1): restructure code of the :ts modifier

Now there is one paragraph per case, as opposed to the highly condensed
code from before.

In the cases of :ts\n and :ts\t, the variables for number parsing are no
longer in the code path, which makes the code easier to understand for
humans.  Not sure what the compilers made out of it.

The assignment "base = 0" has gone since it was redundant.  An integer
that starts with 0 is always interpreted as octal by strtol, no matter
if the base is 8 or 0.

(rillig)

make(1): extend the documentation on the ApplyModifier functions

(rillig)

make(1): split code for parsing the :U modifier into digestible parts

The comment about "unescaped $'s that aren't before the delimiter" was
wrong, as the code didn't contain the "aren't before the delimiter"
part.  By splitting the code into paragraphs, the larger structure
becomes easily visible.  Having a few short comments in the right place
is more helpful than a big block of text.

(rillig)

make(1): add test for :U modifier

(rillig)

Man page typo fix.

(tpaul)

make(1): move test for .undef into separate file

(rillig)

make(1): make compat.c ready for WARNS=6

(rillig)

make(1): make ArchFindMember ready for WARNS=6

(rillig)

make(1): make ArchStatMember ready for WARNS=6

(rillig)

make(1): make Arch_MemMTime ready for WARNS=6

(rillig)

Initialize peers early on for error branch.

(riastradh)

make(1): make brk_string return size_t for the number of words

(rillig)

make(1): prepare str.c for WARNS=6

The next step is to make brk_string return size_t instead of int.

(rillig)

make(1): in archive test, use wildcard that matches more than 1 file

This is to make sure that the buffer used for "archive(member)" is
properly reset after each member.

(rillig)

Split getrandom tests into several cases to find out which ones hang.

(riastradh)

make(1): replace tricky malloc+realloc+strlen+snprintf with Buffer

The code for handling archives is not widely used.  Therefore it does
not need to be fast.  Clarity of the code is more important.  Therefore
replace the malloc + strlen + realloc + snprintf string processing with
the Buffer type, which removes a lot of redundancy.

In the wildcard loop, the "if (sz > nsz)" looked like a mistake.  Why
should it be useful to first allocate a large buffer and then resize it
to a smaller buffer, but still twice as large as necessary?

(rillig)

make(1): add test for wildcards in archive dependency

(rillig)

make(1): allow to run only selected tests via the command line

(rillig)

make(1): remove unused declarations from header files

(rillig)

make(1): remove parameter names from function prototypes

Thanks kre for noticing.

(rillig)

make(1): reverse order of the Lst_Find parameters

The other callbacks all have (function, param), only the Lst_Find had
(param, function), which was inconsistent.

(rillig)

make(1): define aliases for function types in list processing

This makes the prototypes of the functions clearer.

(rillig)

Adjust sp, not fp, to allocate a 32-byte temporary.

Costs another couple MOV instructions, but we can't skimp on this --
there's no red zone below sp for interrupts on arm, so we can't touch
anything there.  So just use fp to save sp and then adjust sp itself,
rather than using fp as a temporary register to point just below sp.

Should fix PR port-arm/55598 -- previously the ChaCha self-test
failed 33/10000 trials triggered by sysctl during running system;
with the patch it has failed 0/10000 trials.

(Presumably it happened more often at boot time, leading to 5/26
failures in the test bed, because we just enabled interrupts and some
devices are starting to deliver interrupts.)

(riastradh)

make(1): make navigating lists in debugging mode easier

Lst is an untyped list of pointers.  During debugging, it is often
necessary to inspect the content of the list.  To do this without manual
typecasting, add a few aliases for the LstNode.datum pointer, for
inspecting GNodes and strings.

(rillig)

Expand test to cover more failure cases.  Change from skipped to expect fail
in anticipation of working roll-forward code.

(perseant)

adjust the number of spaces to match the current df(1) output.
fix NetBSD PR/55600

TODO: it should not be dependent on the number of spaces.

(ryo)

make(1): move tests for the :tu and :_ modifiers into separate files

(rillig)

make(1): move tests for :hash :range :localtime into separate files

(rillig)

make(1): move tests for :H :E :R :T into separate files

(rillig)

make(1): move some of the SysV modifier tests into another file

(rillig)

make(1): add test for + commands with the -n command line option

(rillig)

make(1): add tests for the -i -k -v -V -W options

(rillig)

make(1): add tests for functions in .if conditions

(rillig)

make(1): add tests for numeric comparisons in .if directives

(rillig)

Link to i386/pnpbios(4) instead of pnpbios(4)

And bump date.

(ryoon)

make(1): remove another piece of code for circular lists

(rillig)

Expect failure only when running under qemu's TCG CPU emulation, not
when running under hardware virtualization such as qemu -accel nvmm.

(gson)

Provide separate functions to check for running under qemu in general
and for running under qemu's built-in TCG CPU emulation (as opposed to
hardware virtualization via NVMM or KVM).

(gson)

make(1): handle special case of a list containing null pointers

GNode.commands is the only place in make where a list can contain null
pointers.  That's unexpected, and memory management in CompatRunCommand
looks suspicous enough to warrant extensive documentation.

(rillig)

make(1): save a variable lookup when adding a read-only variable

(rillig)

Use a 16kB USPACE (and larger kernel stack) for LP64 kernels.  Invert
the logic for setting the USPACE size.  Define a desired USPACE size
(16kB for LP64, 8kB otherwise) then divide by PAGE_SIZE to get UPAGES.

Fixes random segmap lossage, since the uarea usually sits immediately
above the segmap for a process.  Thanks to mrg@, skrll@ and dholland@
for testing, debugging and general help tracking down this problem.

(simonb)

Fix editor mistake in previous.

(wiz)

make(1): fix assertion failure in debug output for read-only variables

(rillig)

make(1): add test for the newly added .SHELL variable

(rillig)

make(1): improve variable name in ApplyModifiers

The bare q was too unspecific.

(rillig)

make(1): use local variable in ApplyModifier_Path

Without this variable, it might seem as if st->newVal could become NULL
in some code paths.

(rillig)

make(1): add assertions for non-nullness of strings

Verified by manually inspecting all call sites.

(rillig)

make(1): use proper data type for GNode.type

Theoretically this should show the enum constant names when displaying
the field in the debugger.  This only happens for GNode.flags though,
but not for GNode.type.  Not sure what the exact cause is.

(rillig)

make(1): clean up code in buf.c

(rillig)

make(1): add test for the :P variable modifier

(rillig)

make(1): unroll loop in SuffFindArchiveDeps

The compiler had unrolled this loop anyway, and for humans it is more
readable as well.

The comments "must be first" and "must be second" came from a time when
the variables were stored in a linked list instead of a hash table.
Maybe this "must" was about performance back then.  Anyway, the tests
run fine with either order, and there is absolutely no evidence that the
order of these variables could have any effect.

(rillig)

make(1): use common MAX macro instead of self-defined

(rillig)

Improve debug messages.

(isaki)

Improve and update comments.

(isaki)

Style fixes.

(isaki)

Document the MIPs "mips machine {cpu,nmi,watch,unwatch}" commands.
Add commented out stubs for the mfcr and mtcr commands.

(simonb)

Add /v to show only valid TLBs.
Align tlb display nicely if > 100 TLBs.
Sort commands in the command dispatch function.

(simonb)

Use upper-case "CPU" consistently in all text except DDB command names.

(simonb)

make(1): migrate Lst_AtFront to Lst_PrependS

This makes Lst_AtFront unused, as well as LstInsertBefore.

(rillig)

make(1): replace Lst_Duplicate with Lst_CopyS

Lst_Duplicate would have passed through any null pointer, which was not
needed for make.  It was the last function that used Lst_AtEnd, which in
turn was the last function that used LstInsertAfter.  As a result, these
two functions have been removed.

(rillig)

make(1): make moving and copying lists simpler

Instead of the two-in-one Lst_Concat, having two separate functions is
easier to understand.  There is no need for a long API comment anymore
since the new functions have a single purpose that is accurately
described by their name.

The long comment inside Lst_Concat has been removed since it only
repeated the exact code, only in more words.

The comments in make.c about appending the cohorts had been wrong.  They
were not appended but prepended.  Once more, the function name expresses
everything that the comment said, making the comment redundant.  There
is no need to test whether the cohorts list is empty, doing nothing is
implied by the word All in Lst_PrependAllS.

(rillig)

make(1): make Lst_Prev stricter regarding null pointers

(rillig)

make(1): use Lst_OpenS in Arch_MemMTime

The field GNode.parents is guaranteed to be a valid list.

(rillig)

make(1): add test for expanding wildcards in directories

This test covers DirExpandInt.

(rillig)

make(1): clean up headers

Remove redundant headers that are already included by "make.h".
Make <assert.h> available to all compilation units that use "make.h".

(rillig)

bash says 'command not found'

(sjg)

make(1): try to set the variable named "" using the command line

Before 2020-08-22, the command line argument '=cmline-plain' triggered
undefined behavior, just like the assignment '=assigned' in the Makefile.

(rillig)

make(1): fix undefined behavior when assigning to variable ""

Using a programming language with built-in array bounds checks would
have prevented this bug, and many others as well.

(rillig)

make(1): try a bit harder to set the variable with the empty name

There is not only the != assignment operator, but a few others as well.
Especially the += operator is interesting since it has a different code
path.  But all is good.

(rillig)

Use TEST_MAKE to run unit-tests

This lets us take advantage of new features like ${.SHELL}

(sjg)

make(1): prevent assignment to the variable with the empty name

(rillig)

make(1): add test for assigning to the variable named ""

This has been possible at least since 2013, probably much longer.

(rillig)

make(1): use Lst_OpenS in make.c

The fields GNode.children, parents and iParents are guaranteed to be
valid lists.

(rillig)

make(1): use Lst_OpenS in Dir_SetPATH

Since dirSearchPath is initialized in Dir_Init, opening the list can
never fail.

(rillig)

make(1): replace segmentation fault with failed assertion

To reproduce: ./make -r -C unit-tests -f sh-dots.mk -j1

Without -j1, the test succeeds.

(rillig)

Add .SHELL as read-only variable

The .SHELL variable represents the shellPath used to run
scripts.

Reviewed by: rillig, christos

(sjg)

make(1): remove wrong comment about possible Y2038 problem

The "time" that is mentioned is not clock time but a sequence number.

(rillig)

make(1): remove unused variable jobServer

(rillig)

make(1): convert GNode type constants to enum

This allows debuggers to print symbolic names for the type flags.

The names of these constants need to be revised.  These flags probably
started as the 3 dependency operators (:, !, ::), and at that time, the
prefix OP_ made sense.  The other flags are not related to the type of
the dependency operator and could have been placed in GNode.flags as
well.

(rillig)

make(1): restructure GNode types and documentation

Having a numbered list above the type was not helpful since the numbers
didn't serve any purpose, they just consumed screen space.

Several of these list items didn't have an obvious relationship to the
struct fields.  It's better to have just a rough introduction as the
type level documentation, leaving the details to the individual fields.

Converting the types and flags and other constants into separate types
and defining them outside the struct leaves more space to see the
relationship of the struct fields.

Limiting the documentation of each field to a single line, as suggested
by the end-of-line comments, reduces clarity since several of the fields
need way more documentation to be properly understood.

(rillig)

make(1): fix indentation

(rillig)

make(1): fix documentation of Var_Parse

(rillig)

make(1): add test for deferred variable expansion in dependencies

(rillig)

#include <stdint.h> for uint8_t

(skrll)

make(1): extract percentage calculation out of Dir_PrintDirectories

(rillig)

make(1): declare unused argument in Arch_TouchLib in a simpler way

(rillig)

make(1): require argument of Lst_Member to be non-null

Since the lists don't contain null pointers, it doesn't make sense to
search for a null pointer.  All calls but one already had obviously
non-null arguments.  The one remaining call using targ->suff has been
guarded for now.

The code for Lst_Member became much simpler than before.  Partly because
the old code had an extra condition for circular lists, which are not
used by make.

(rillig)

Remove pte_zero_p and simply check against 0.

(skrll)

Remove the #if defined(__mips_n64) && PAGE_SIZE == 8192 and make the
check MI - all PTs are PAGE_SIZE aligned

(skrll)

Supress /bin/sh: in error for sh-dots

(sjg)

make(1): replace Lst_Datum with non-null guaranteeing Lst_DatumS

(rillig)

make(1): unexport Lst_InsertBefore and Lst_InsertAfter

(rillig)

make(1): add strict argument checks for Lst_InsertBefore

As with the other modifying operations on lists, the callers already
made sure that the arguments are valid.

(rillig)

Whitespace - line continutation alignment

(skrll)

make(1): convert Lst_Enqueue and Lst_Dequeue to nonnull variants

Except for once instance in parse.c, the usage pattern for Lst_Dequeue
was to first test whether the list is empty.  This pattern allowed the
implementation of Lst_Dequeue to become simpler since the null check is
not needed anymore.

The calls to Lst_Enqueue never pass an invalid list or a null pointer,
therefore making them strict was trivial.

(rillig)

make(1): remove wrong comment for Dir_Init

Neither the list nor the hash table modules have anything to do with
opening directories.

(rillig)

Trailing whitespace

(skrll)

make(1): allow the inconsistency with Lst_OpenS to be discovered

The -dL option is intended to find bugs in Makefiles and in make itself,
therefore enabling the consistency check is ok there.  Having this check
available by default increases the chances of the bug being found and
finally fixed.

(rillig)

make(1): replace two instances of Lst_AtFront with Lst_Prepend

In these cases, the list is guaranteed to be valid, therefore no
assertion is expected.

For comparison, the Lst_AtFront in dir.c needs to be kept since the path
may be null there.

(rillig)

make(1): convert remaining Lst_AtEnd to the stricter Lst_Append

The general-purpose list library that is included in make allows to call
Lst_AtEnd for invalid lists, silently ignoring this programming error.
This is a flexibility that make doesn't need.

Another unneeded "feature" is that list items can theoretically be null
pointers.  This doesn't make sense as well and is therefore not needed
by make.

These programming errors are now caught early by assertions.

(rillig)