Link [ NetBSD | NetBSD OpenGrok source search | PR fulltext-search | Summary of daily snapshot builds | history of daily build result | pkgsrc commit viewer ]


   
        usage: [branch:branch] [user:user] [path@revision] keyword [... [-excludekeyword [...]]] (e.g. branch:MAIN sys/arch/arm, if_wm.c@1.234 )




switch to index mode

recent branches: MAIN (3h)  netbsd-8 (5d)  netbsd-10 (5d)  netbsd-9 (11d)  thorpej-ifq (175d)  thorpej-altq-separation (178d) 

2024-05-10 02:36:15 UTC Now

2020-07-03 19:21:11 UTC MAIN commitmail json YAML

make(1): add expected test result for modmisc

(rillig)

2020-07-03 19:00:01 UTC MAIN commitmail json YAML

sync with mount.h, always use the structure size.

(christos)

2020-07-03 18:49:38 UTC MAIN commitmail json YAML

don't overallocate (follows similar change to compat/sys/statvfs.h)

(jdolecek)

2020-07-03 18:41:50 UTC MAIN commitmail json YAML

make(1): fix bug in :E modifier, introduced in r1.239 today

That case was not covered by the tests before.

(rillig)

2020-07-03 17:48:47 UTC MAIN commitmail json YAML

make(1): fix indentation in var.c

Fixing the indentation manually is a tedious task.  indent(1) was no help
since it has several bugs and is not flexible enough for the original
make code.

(rillig)

2020-07-03 17:22:14 UTC MAIN commitmail json YAML

2020-07-03 17:14:23 UTC MAIN commitmail json YAML

1 page is enough for memhook now since the merge of the rmind-uvmplock
branch and the removal of sys/arch/arm/arm32/mem.c

The last users of memhook don't care about number of CPUs or page colours.

(skrll)

2020-07-03 17:03:09 UTC MAIN commitmail json YAML

make(1): add Hash_ForEach to avoid duplicate code

(rillig)

2020-07-03 17:00:48 UTC MAIN commitmail json YAML

make(1): fix indentation and alignment

(rillig)

2020-07-03 16:23:03 UTC MAIN commitmail json YAML

2020-07-03 16:17:25 UTC MAIN commitmail json YAML

In cpu_uarea_{alloc,free}:

- My previous change in this file was not correct, kremove does not free
  the underlying PA, which caused a very slow leak under memory pressure.
  Rework to correctly free the PA.
- Add a second redzone, this time after the stack, to catch several stack
  overflows. The main concern is read overflows which leak the heap that
  follows the stack.
- UVM_KMF_WAITVA doesn't fail, so remove error check.
- Add KASSERTs.

(maxv)

2020-07-03 16:12:16 UTC MAIN commitmail json YAML

Enable trace-cmp.

(maxv)

2020-07-03 16:11:11 UTC MAIN commitmail json YAML

Sync trace-pc and trace-cmp.

(maxv)

2020-07-03 16:09:55 UTC MAIN commitmail json YAML

2020-07-03 16:07:52 UTC MAIN commitmail json YAML

2020-07-03 15:42:43 UTC MAIN commitmail json YAML

make(1): make code for the :E and :R modifiers simpler

(rillig)

2020-07-03 15:41:37 UTC MAIN commitmail json YAML

2020-07-03 15:33:01 UTC MAIN commitmail json YAML

make(1): add more tests for :H, :T and :E modifiers

(rillig)

2020-07-03 15:31:25 UTC MAIN commitmail json YAML

2020-07-03 15:24:31 UTC MAIN commitmail json YAML

make(1): clean up code for the :H and :T modifiers

(rillig)

2020-07-03 15:22:35 UTC MAIN commitmail json YAML

make(1): add test for :H and :T modifiers with several words

(rillig)

2020-07-03 14:59:17 UTC MAIN commitmail json YAML

2020-07-03 14:14:04 UTC MAIN commitmail json YAML

make(1): refactor ApplyModifiers

Previously, ApplyModifiers was 1200 lines long and pretty complicated.
Now each of the complicated modifiers has its own function, which reduces
the indentation and makes it possible to use early returns.

(rillig)

2020-07-03 14:08:53 UTC MAIN commitmail json YAML

don't overallocate (requested by maxv@)

(christos)

2020-07-03 12:53:27 UTC MAIN commitmail json YAML

unbreak build, put /var/db/dhcpcd into the set lists

(roy)

2020-07-03 12:39:54 UTC MAIN commitmail json YAML

Fix an argument passes to auixp_intr().
This is rest of rev 1.39 (split device_t/softc) in 2012.
Problem reported and tested by Riccardo Mottola.

(isaki)

2020-07-03 11:03:42 UTC MAIN commitmail json YAML

Add /var/db/dhcpcd back

(roy)

2020-07-03 10:47:29 UTC MAIN commitmail json YAML

Note import of dhcpcd-9.1.4

(roy)

2020-07-03 10:46:45 UTC MAIN commitmail json YAML

2020-07-03 10:19:18 UTC MAIN commitmail json YAML

Move db_reset_cmd prototype to db_machdep.h (forgot to commit this file)

(jmcneill)

2020-07-03 08:37:57 UTC MAIN commitmail json YAML

2020-07-03 08:19:20 UTC MAIN commitmail json YAML

Make this compile/work on 32-bit archs.  OK'ed my maxv

I thought about uintptr_t, but didn't change from Elf_Addr

(skrll)

2020-07-03 08:13:23 UTC MAIN commitmail json YAML

2020-07-03 08:02:56 UTC MAIN commitmail json YAML

2020-07-03 07:40:13 UTC MAIN commitmail json YAML

make(1): refactor Str_Match

- use shorter variable names to avoid line breaks
- eliminate c2 variable
- change return type to Boolean

(rillig)

2020-07-03 07:03:14 UTC MAIN commitmail json YAML

2020-07-03 06:49:26 UTC MAIN commitmail json YAML

Consistency...#define<tab>

(skrll)

2020-07-03 06:35:05 UTC MAIN commitmail json YAML

2020-07-03 06:33:39 UTC MAIN commitmail json YAML

Style and share a debug string

(skrll)

2020-07-03 06:30:02 UTC MAIN commitmail json YAML

make(1): clean up Str_Match

- removed unnecessary parentheses
- uniform test for end of string

(rillig)

2020-07-03 06:26:41 UTC MAIN commitmail json YAML

2020-07-03 06:25:23 UTC MAIN commitmail json YAML

make(1): clean up documentation of Str_Match

(rillig)

2020-07-03 06:22:48 UTC MAIN commitmail json YAML

2020-07-03 06:15:27 UTC MAIN commitmail json YAML

2020-07-03 06:13:00 UTC MAIN commitmail json YAML

Provide a db_reset_cmd prototype

(skrll)

2020-07-03 04:25:28 UTC MAIN commitmail json YAML

2020-07-03 03:59:18 UTC MAIN commitmail json YAML

2020-07-03 03:13:10 UTC MAIN commitmail json YAML

Verify that PR lib/55041 is no longer an issue.

(jruoho)

2020-07-03 02:51:13 UTC MAIN commitmail json YAML

Expect a timeout for evbarm-aarch64, as seen in the recent Qemu runs.

(jruoho)

2020-07-02 23:43:01 UTC MAIN commitmail json YAML

setcchar - don't lose combining marks to a typo.

We copy len wchars but set the length field to 1, instead of len.
From Naman Jain in PR lib/55443

(uwe)

2020-07-02 19:11:01 UTC MAIN commitmail json YAML

cgram(6): use standard cursor keys, use standard shuffle algorithm

The previous shuffle algorithm asked for 100 random numbers, on average.
The new algorithm asks exactly for 26 random numbers.

Curses predefines numeric constants for keys, and there is no apparent
reason not to use these standard keys for cursor movement.

(rillig)

2020-07-02 17:15:00 UTC MAIN commitmail json YAML

2020-07-02 16:52:34 UTC MAIN commitmail json YAML

make(1): fix unnecessary evaluation of variables in :@var@ modifier

(rillig)

2020-07-02 16:46:57 UTC MAIN commitmail json YAML

make(1): fix unnecessary evaluation for :S :C := modifiers

(rillig)

2020-07-02 16:37:56 UTC MAIN commitmail json YAML

make(1): demonstrate some more cases for unintended evaluation

(rillig)

2020-07-02 16:14:50 UTC MAIN commitmail json YAML

make(1): clean up code in var.c

- remove redundant parentheses in return statements
- add missing space after comma
- remove some redundant parentheses around comparisons
- use hexadecimal numbers for bit mask constants
- remove Var_GetTail and Var_GetHead, which had been unused for 19 years

(rillig)

2020-07-02 15:47:39 UTC MAIN commitmail json YAML

make(1): remove useless parameter from Var_Set

The enum corresponding to this int parameter is only defined in var.c,
which makes it impractical for the outside to set this parameter to
anything but 0.

On x86_64, this reduces the size of the resulting executable by 5 kB.

(rillig)

2020-07-02 15:26:21 UTC MAIN commitmail json YAML

make(1): use enum instead of #define for VarPattern flags

(rillig)

2020-07-02 15:14:38 UTC MAIN commitmail json YAML

make(1): add more type safety for enums

There are several types of flags for variables, and these cannot be
mixed.  To prevent accidental typos, these are defined in separate enum
types.  Clang warns about direct assignments between distinct types, but
not about mixing distinct types in binary expressions like A | B.  GCC
does not warn at all.

(rillig)

2020-07-02 14:04:01 UTC MAIN commitmail json YAML

src/external/bsd/kyua-cli/Makefile.inc@1.6 / diff / nxr@1.6
src/external/bsd/kyua-cli/dist/cli/cmd_report.hpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/cli/common.hpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/cli/main.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/engine/config.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/engine/metadata.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/engine/metadata.hpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/engine/testers.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/cmdline/commands_map.hpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/config/lua_module_test.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/config/nodes.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/config/parser.hpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/config/tree_test.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/format/formatter.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/logging/operations.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/process/child.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/process/child.hpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/process/child.ipp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/process/child_test.cpp@1.2 / diff / nxr@1.2
src/external/bsd/kyua-cli/dist/utils/process/fdstream.hpp@1.2 / diff / nxr@1.2
      :
(more 5 files)
kyua-cli: convert auto_ptr to unique_ptr

Update kyua-cli to C++11 and use unique_ptr instead of auto_ptr,
(with std::move() where appropriate), to avoid deprecated warning by g++ 8.

(I didn't change some of the code that could arguably be refactored
to use unique_ptr or shared_ptr instead of raw pointers
and therefore remove the special case destructor handling).

(lukem)

2020-07-02 14:02:04 UTC MAIN commitmail json YAML

Note import of dhcpcd-9.1.3

(roy)

2020-07-02 13:59:19 UTC MAIN commitmail json YAML

2020-07-02 13:56:10 UTC MAIN commitmail json YAML

lutok: auto_ptr replaced; remove build workaround

(lukem)

2020-07-02 13:54:19 UTC MAIN commitmail json YAML

lutok: use unique_ptr not auto_ptr

(lukem)

2020-07-02 13:04:47 UTC MAIN commitmail json YAML

Add support of ptrace(2) for COMPAT_NETBSD32.

Now, GDB for arm32 is usable for debugging 32bit applications.

OK ryo@

(rin)

2020-07-02 13:04:09 UTC MAIN commitmail json YAML

2020-07-02 13:01:11 UTC MAIN commitmail json YAML

pmap_procwr(): sync icache even if p != curproc. This fixes applications
like GDB for arm32, that rewrite text of other process.

Thanks to ryo@ for discussion.

(rin)

2020-07-02 12:59:31 UTC MAIN commitmail json YAML

Set uvmexp.ncolors appropriately, which is required for some CPU
models with VIPT icache.

Otherwise, alias in virtual address results in inconsistent results,
at least for applications that rewrite text of other process, e.g.,
GDB for arm32.

Also, this hopefully fixes other unexpected failures due to alias.

Confirmed that there's no observable regression in performance;
difference in ``time make -j8'' for GENERIC64 kernel on BCM2837
with and without setting uvmexp.ncolors is within 0.1%.

Thanks to ryo@ for discussion.

(rin)

2020-07-02 12:47:19 UTC MAIN commitmail json YAML

2020-07-02 12:45:27 UTC MAIN commitmail json YAML

2020-07-02 12:37:18 UTC MAIN commitmail json YAML

make(1): demonstrate another unintended variable evaluation

(rillig)

2020-07-02 12:34:30 UTC MAIN commitmail json YAML

make(1): fix edge case for evaluating unnecessary conditions

(rillig)

2020-07-02 11:49:48 UTC MAIN commitmail json YAML

Initialize ci_kfpu_spl earlier for secondary CPUs. From riastradh

(martin)

2020-07-02 11:10:48 UTC MAIN commitmail json YAML

2020-07-02 11:08:55 UTC MAIN commitmail json YAML

fix incomplete gnu/ deletion - PR misc/55444 by Jim Bernard

(jdolecek)

2020-07-02 10:36:58 UTC MAIN commitmail json YAML

make(1): demonstrate another unnecessary condition evaluation

(rillig)

2020-07-02 10:28:11 UTC MAIN commitmail json YAML

Fix typo; PMAP_OEA64_BRIDGE not PMAP_OEA_BRIDGE.
Tested on Power Mac G5.

(rin)

2020-07-02 10:22:28 UTC MAIN commitmail json YAML

Document OBJMACHINE_ARCH

(jmcneill)

2020-07-02 09:44:51 UTC MAIN commitmail json YAML

make(1): document the actual cause for "recursive variable"

That wrong error message had nothing to do with the .for loop, it was
only caused because the .for loop uses the :U modifier internally.

(rillig)

2020-07-02 09:07:25 UTC MAIN commitmail json YAML

loader.efi doesn't have source

(Untested fix)

(lukem)

2020-07-02 09:07:10 UTC MAIN commitmail json YAML

2020-07-02 09:02:04 UTC MAIN commitmail json YAML

2020-07-02 08:48:11 UTC MAIN commitmail json YAML

Makefile.minirootkmod don't have SRCS

(lukem)

2020-07-02 07:49:44 UTC MAIN commitmail json YAML

Remove pointless cast; dp is already uint32_t *.
No functional changes intended.

(rin)

2020-07-01 23:37:10 UTC MAIN commitmail json YAML

Correct SRCS; bsdstart.S not bsdstart.s.

Fix build with bsd.dep.mk rev 1.87, which requires more strict
filename matching.

Found by martin.

(rin)

2020-07-01 18:02:27 UTC MAIN commitmail json YAML

Fix parsing of nested variables during .for loop

Recent change to cond.c to avoid eval of unnecessary
terms had side effect on constructs like:

.for s in 1 2
.if defined(MAN$s) && !empty(MAN$s)
MAN+= ${MAN$s}
.endif
.endfor

resulting in MAN being flagged as recursive.

When Var_Parse encounters a variable within a variable name
we want to force it to be expanded.
But given the way get_mpt_arg calls Var_Parse we need to check
whether we actually started parsing a variable yet.

(sjg)

2020-07-01 17:57:14 UTC MAIN commitmail json YAML

revert, not working

(jdolecek)

2020-07-01 15:10:01 UTC MAIN commitmail json YAML

ignore interrupt when not expecting one, particularly don't invoke
the irqack in this case

seems cmdide doesn't honour WDCTL_IDS when executing polled commands,
and there is a race where the irqack call interferes with polled
command and causes a lockup

reported by Martin Husemann

(jdolecek)

2020-07-01 13:49:26 UTC MAIN commitmail json YAML

Add basic checks for magic symlink(7)'s. These include a case for PR lib/55361,
although it seems that realpath(3) has bigger problems with these symlinks.

(jruoho)

2020-07-01 12:19:45 UTC MAIN commitmail json YAML

When using show subcommand, display node ID (nid) in hexadecimal to match
the HD audio documentation. Diverge slightly by using 0xXX instead of XXh
format for consistency with the list subcommand.

(sborrill)

2020-07-01 09:58:29 UTC MAIN commitmail json YAML

Pass the requisite -msse options for i386.

(riastradh)

2020-07-01 08:25:44 UTC MAIN commitmail json YAML

Fix addition of C++ .cc source to SRCS

Fix assumption that all of the source files are .c, as some are .cc.

Not tested, based on similar change to
  external/gpl3/gcc/usr.bin/cc1plus/Makefile

(lukem)

2020-07-01 08:03:10 UTC MAIN commitmail json YAML

show clidr_el1 and ctr_el0.

(ryo)

2020-07-01 08:02:13 UTC MAIN commitmail json YAML

add workaround for Neoverse N1 erratum 1542419

(ryo)

2020-07-01 08:01:07 UTC MAIN commitmail json YAML

- On some systems with a different cache line size (and DIC,IDC) per CPU, trap "mrs Xt,ctr_el0" instruction
  to return the minimum cache line size of the system to userland.
- add CLIDR_EL1 and CTR_EL0 to struct aarch64_sysctl_cpu_id.

On most systems, cache line size is the same for all CPUs, so this mechanism won't be required.
Rather, this is primarily for errata support, which will be committed later.

(ryo)

2020-07-01 07:59:16 UTC MAIN commitmail json YAML

Switch the Icache sync operation to the necessary and sufficient one according to the CTR_EL0.DIC and CTR_EL0.IDC flags.

If CTR_EL0.DIC=1, Icache invalidation is not required.
If CTR_EL0.IDC=1, Dcache clean before Icache invalidation is not required.
CLIDR_EL1.LoC is 0, or CLIDR_EL1.LoUIS and CLIDR_EL1.LoUU are 0, Dcache clean is not required as well.

SEE ALSO ARMARM, "CTR_EL0 Cache Type Register", and "CLIDR_EL1 Cache Level ID Register"

(ryo)

2020-07-01 07:54:24 UTC MAIN commitmail json YAML

use ggc-none.c not ggc-none.o in SRCS

not tested, based on similar change to
external/gpl3/gcc/usr.bin/lto-wrapper/Makefile

(lukem)

2020-07-01 07:38:29 UTC MAIN commitmail json YAML

bsd.dep.mk: fix "make tags" (again)

[repeat revision 1.85]

Fix "make tags" to actually build a tags file:
- Use !commands() instead of !target(), so that the rule actually works
- Write to ${.OBJDIR}/tags for read-only source (don't know why ${.TARGET}
  isn't sufficient).
- Only match *.[cly] from ${.ALLSRCS} - just excluding *.h causes failures
  because of ${targ}: subdir-${targ} in bsd.subdir.mk.

Thanks to uwe@ for assistance.

(lukem)

2020-07-01 07:16:38 UTC MAIN commitmail json YAML

2020-07-01 06:31:18 UTC MAIN commitmail json YAML

Forbid gcc to whine about intended format truncation

(martin)

2020-07-01 05:37:25 UTC MAIN commitmail json YAML

Add basic tests for the rest of the mktemp(3) family of functions, including
a case for PR lib/55441.

(jruoho)

2020-07-01 02:57:02 UTC MAIN commitmail json YAML

hline, vline - don't lose attributes when using default character.

Make default (wide) and non-wide behavior match.  If the character
argument has (only) attributes set, use them with the default line
character.

In the wide case don't do the fallback in hline - it just calls
hline_set that needs to do it anyway.  Fix the latter to check the
wcwidth of the right character and avoid division by zero.

(uwe)

2020-07-01 02:14:41 UTC MAIN commitmail json YAML

Oops.  Fix y/x typo in the previous whline() fix for !HAVE_WCHAR.

(uwe)

2020-07-01 00:42:13 UTC MAIN commitmail json YAML

copystr is now in libkern; don't redefine it in rumpcopy.c.

Should fix build breakage from the copystr changes.

(riastradh)

2020-06-30 23:51:47 UTC MAIN commitmail json YAML

2020-06-30 23:06:02 UTC MAIN commitmail json YAML

Reallocate registers to avoid abusing callee-saves registers, v8-v15.

Forgot to consult the AAPCS before committing this before -- oops!

While here, take advantage of the 32 aarch64 simd registers to avoid
all stack spills.

(riastradh)

2020-06-30 21:53:39 UTC MAIN commitmail json YAML

Use `.arch_extension aes' for aese/aesmc/aesd/aesimc.

Unlike `.arch_extension crypto', this works with clang; both work
with gas, so we'll go with this.

Clang still can't handle aes_armv8_64.S yet -- it gets confused by
dup and mov on lanes, but this makes progress.

(riastradh)

2020-06-30 21:41:04 UTC MAIN commitmail json YAML

Use .p2align rather than .align.

Apparently on arm, .align is actually an alias for .p2align, taking a
power of two rather than a number of bytes, so aes_armv8_64.o was
bloated to 32KB with obscene alignment when it only needed to be
barely past 4KB.

Do the same for the x86 aes_ni_64.S -- even though .align takes a
number of bytes rather than a power of two on x86, let's just stay
away from the temptations of the evil .align directive.

(riastradh)

2020-06-30 21:27:18 UTC MAIN commitmail json YAML

Fix indentation in the copyright.
Make it match its siblings in other files.

(uwe)

2020-06-30 21:24:00 UTC MAIN commitmail json YAML

Tweak clang neon intrinsics so they build.

(this file is still a kludge)

(riastradh)

2020-06-30 21:22:19 UTC MAIN commitmail json YAML

New build.sh option: -c <compiler>

Could never remember what the incantation is to do a clang build, so
now it's just `build.sh -c clang'.

(riastradh)

2020-06-30 21:10:13 UTC MAIN commitmail json YAML

whline - save/restore the y coordinate too.
Reaching the right side of the screen can cause a line wrap.
Forgot to apply the fix to the !HAVE_WCHAR case.
PR lib/55434

(uwe)

2020-06-30 21:02:24 UTC MAIN commitmail json YAML

whline_set - save/restore the y coordinate too.
Reaching the right side of the screen can cause a line wrap.
PR lib/55434

(uwe)

2020-06-30 20:32:11 UTC MAIN commitmail json YAML

2020-06-30 19:02:42 UTC MAIN commitmail json YAML

If an error occurred in sme_refresh function, pass ENVSYS_SINVALID.
OK'd by pgoyette.

(msaitoh)

2020-06-30 18:50:55 UTC netbsd-8 commitmail json YAML

2020-06-30 18:50:05 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by kim in ticket #1564):

usr.bin/w/w.c: revision 1.86
usr.bin/w/w.c: revision 1.85

Compute a value for domain before comparing against it
Remove local domain always, not just when looking up addresses

(martin)

2020-06-30 18:49:17 UTC netbsd-9 commitmail json YAML

2020-06-30 18:48:00 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by kim in ticket #979):

usr.bin/w/w.c: revision 1.86
usr.bin/w/w.c: revision 1.85

Compute a value for domain before comparing against it
Remove local domain always, not just when looking up addresses

(martin)

2020-06-30 18:45:18 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by sborrill in ticket #978):

sys/dev/acpi/acpi_display.c: revision 1.18

Only need to set brightness if reading the initial state fails
to sync firmware and the driver. Avoids black screen at boot time.

Thanks to jmcneill@

(martin)

2020-06-30 18:41:08 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by kim in ticket #977):

usr.bin/cal/cal.c: revision 1.30

Use two-letter weekday abbreviations in the heading

This matches output from ncal (a.k.a. cal) as found in FreeBSD and
bsdmainutils. (Why had "T" been found more ambiguous than "S" already?)

(martin)

2020-06-30 18:39:38 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by ryo in ticket #976):

sys/arch/aarch64/aarch64/pmap.c: revision 1.79

Fix bug with incorrect range calculation when doing icache sync.

This is called by sysarch(ARM_SYNC_ICACHE) from aarch32 (compat_netbsd32) emul process.
pointed out by rin@, thanks.

XXX pullup-9

(martin)

2020-06-30 18:32:47 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #975):

external/mit/xf86-video-intel/dist/src/intel_module.c: revision 1.2

Use UXA (not SNA) by default on Intel Gen3/4/5 chipsets (except 915).

This works around PR/54995 (screen corruption on N455)
and PR/55198 (X freezes/hangs on 965GM).  Ok'ed by mrg@.

Should be pulled up to netbsd-9.

(martin)

2020-06-30 18:22:48 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by kim in ticket #974):

etc/mtree/special: revision 1.170

Fix /private/tmp mode to match etc/rc.d/perusertmp

(martin)

2020-06-30 18:20:54 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #973):

sys/arch/x68k/x68k/disksubr.c: revision 1.36

Use a sane default for size of partition a: rather than odd 0x1fffffff.

The latter one seems derived from 386BSD (and 4.4BSD),
but it could confuse sysinst as noted in PR/55187.

Sync with most other modern ports that use secperunit
as well as RAW_PART.

(martin)

2020-06-30 18:18:12 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by tsutsui in ticket #972):

distrib/atari/floppies/install/list: revision 1.23

Provide wdboot as a link of sdboot for Milan also in sysinst.

See the following commit log for details:
https://mail-index.netbsd.org/source-changes/2018/03/04/msg092779.html

(martin)

2020-06-30 17:58:55 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by jmcneill in ticket #971):

sys/arch/arm/dts/sun8i-h3-nanopi-m1.dts: revision 1.3

Enable audio codec

(martin)

2020-06-30 17:55:35 UTC netbsd-9 commitmail json YAML

Pull up following revision(s) (requested by jmcneill in ticket #970):

external/cddl/osnet/dist/uts/common/fs/zfs/vdev_disk.c: revision 1.17
external/cddl/osnet/dist/uts/common/fs/zfs/vdev_disk.c: revision 1.18

If calling d_minphys on the parent disk device, make sure we use the
parent disk device's dev_t. Fixes zfs on wedges on ld(4).
XXX pullup-9

Don't assume everything is a wedge and has a parent device. On non-wedges
this crashes.

Instead, just talk to the referenced device and rely on the dk driver
to pass requests correctly.

(martin)

2020-06-30 17:42:58 UTC netbsd-8 commitmail json YAML

2020-06-30 17:41:01 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by sborrill in ticket #1563):

sys/dev/acpi/acpi_display.c: revision 1.18

Only need to set brightness if reading the initial state fails
to sync firmware and the driver. Avoids black screen at boot time.

Thanks to jmcneill@

(martin)

2020-06-30 17:03:14 UTC MAIN commitmail json YAML

Limit aes_neon to cpu_cortex | aarch64.

We won't use it on any other systems, and it doesn't build without
NEON anyway.  Verified earmv7hf GENERIC, aarch64 GENERIC64, and
earmv6 RPI2 all build with this.

(riastradh)

2020-06-30 16:28:17 UTC MAIN commitmail json YAML

be one-shot by default, with room for circular

(maxv)

2020-06-30 16:22:56 UTC MAIN commitmail json YAML

2020-06-30 16:21:17 UTC MAIN commitmail json YAML

New sysctl node hw.aes_impl for selected AES implementation.

(riastradh)

2020-06-30 16:20:03 UTC MAIN commitmail json YAML

Make copystr() a MI C function, part of libkern and shared on all
architectures.

Notes:

- On alpha and ia64 the function is kept but gets renamed locally to avoid
  symbol collision. This is because on these two arches, I am not sure
  whether the ASM callers do not rely on fixed registers, so I prefer to
  keep the ASM body for now.
- On Vax, only the symbol is removed, because the body is used from other
  functions.
- On RISC-V, this change fixes a bug: copystr() was just a wrapper around
  strlcpy(), but strlcpy() makes the operation less safe (strlen on the
  source beyond its size).
- The kASan, kCSan and kMSan wrappers are removed, because now that
  copystr() is in C, the compiler transformations are applied to it,
  without the need for manual wrappers.

Could test on amd64 only, but should be fine.

(maxv)

2020-06-30 16:09:40 UTC MAIN commitmail json YAML

2020-06-30 15:15:12 UTC netbsd-8 commitmail json YAML

Pull up following revision(s) (requested by kim in ticket #1562):

etc/mtree/special: revision 1.170

Fix /private/tmp mode to match etc/rc.d/perusertmp

(martin)

2020-06-30 15:12:08 UTC netbsd-7 commitmail json YAML

2020-06-30 15:10:54 UTC netbsd-7 commitmail json YAML

Pull up following revision(s) (requested by kim in ticket #1737):

etc/mtree/special: revision 1.170

Fix /private/tmp mode to match etc/rc.d/perusertmp

(martin)

2020-06-30 15:02:55 UTC MAIN commitmail json YAML

Remove local domain always, not just when looking up addresses

(kim)

2020-06-30 14:57:25 UTC MAIN commitmail json YAML

Compute a value for domain before comparing against it

(kim)

2020-06-30 14:30:50 UTC MAIN commitmail json YAML

2020-06-30 13:14:21 UTC MAIN commitmail json YAML

Only need to set brightness if reading the initial state fails
to sync firmware and the driver. Avoids black screen at boot time.
Thanks to jmcneill@

(sborrill)

2020-06-30 12:35:50 UTC MAIN commitmail json YAML

2020-06-30 11:49:26 UTC MAIN commitmail json YAML

Skip a few more nodes, and enable this test for Qemu runs.

(jruoho)

2020-06-30 11:48:20 UTC MAIN commitmail json YAML

2020-06-30 07:37:32 UTC MAIN commitmail json YAML

www.lua.org uses https.

(mbalmer)

2020-06-30 06:25:15 UTC MAIN commitmail json YAML

NetBSD 6.99.69 welcomes you, and hopes you enjoy your new AES API.

(riastradh)

2020-06-30 05:19:19 UTC MAIN commitmail json YAML

Lua 5.4.0 is out

(sevan)

2020-06-30 04:17:31 UTC MAIN commitmail json YAML

Missed a spot -- one more 32-bit sign-compare issue.

(riastradh)

2020-06-30 04:15:46 UTC MAIN commitmail json YAML

Fix sign-compare issue on 32-bit systems.

Built fine on amd64, where all unsigned values are representable in
ssize_t, but I didn't try building on i386, where they're not.

(riastradh)

2020-06-30 04:14:56 UTC MAIN commitmail json YAML

2020-06-30 00:26:12 UTC MAIN commitmail json YAML

Note kernel AES rework.

(riastradh)

2020-06-29 23:58:44 UTC MAIN commitmail json YAML

2020-06-29 23:57:56 UTC MAIN commitmail json YAML

Provide hand-written AES NEON assembly for arm32.

gcc does a lousy job at compiling 128-bit NEON intrinsics on arm32;
hand-writing it made it about 12x faster, by avoiding a zillion loads
and stores to spill everything and the kitchen sink onto the stack.
(But gcc does fine on aarch64, presumably because it has twice as
many registers and doesn't have to deal with q2=d4/d5 overlapping.)

(riastradh)

2020-06-29 23:56:31 UTC MAIN commitmail json YAML

2020-06-29 23:54:06 UTC MAIN commitmail json YAML

2020-06-29 23:53:12 UTC MAIN commitmail json YAML

2020-06-29 23:51:35 UTC MAIN commitmail json YAML

2020-06-29 23:50:05 UTC MAIN commitmail json YAML

Split SSE2 logic into separate units.

Ensure that there are no paths into files compiled with -msse -msse2
at all except via fpu_kern_enter.

I didn't run into a practical problem with this, but let's not leave
a ticking time bomb for subsequent toolchain changes in case the mere
declaration of local __m128i variables causes trouble.

(riastradh)

2020-06-29 23:47:54 UTC MAIN commitmail json YAML

New SSE2-based bitsliced AES implementation.

This should work on essentially all x86 CPUs of the last two decades,
and may improve throughput over the portable C aes_ct implementation
from BearSSL by

(a) reducing the number of vector operations in sequence, and
(b) batching four rather than two blocks in parallel.

Derived from BearSSL'S aes_ct64 implementation adjusted so that where
aes_ct64 uses 64-bit q[0],...,q[7], aes_sse2 uses (q[0], q[4]), ...,
(q[3], q[7]), each tuple representing a pair of 64-bit quantities
stacked in a single 128-bit register.  This translation was done very
naively, and mostly reduces the cost of ShiftRows and data movement
without doing anything to address the S-box or (Inv)MixColumns, which
spread all 64-bit quantities across separate registers and ignore the
upper halves.

Unfortunately, SSE2 -- which is all that is guaranteed on all amd64
CPUs -- doesn't have PSHUFB, which would help out a lot more.  For
example, vpaes relies on that.  Perhaps there are enough CPUs out
there with PSHUFB but not AES-NI to make it worthwhile to import or
adapt vpaes too.

Note: This includes local definitions of various Intel compiler
intrinsics for gcc and clang in terms of their __builtin_* &c.,
because the necessary header files are not available during the
kernel build.  This is a kludge -- we should fix it properly; the
present approach is expedient but not ideal.

(riastradh)

2020-06-29 23:44:02 UTC MAIN commitmail json YAML

New cgd cipher adiantum.

Adiantum is a wide-block cipher, built out of AES, XChaCha12,
Poly1305, and NH, defined in

  Paul Crowley and Eric Biggers, `Adiantum: length-preserving
  encryption for entry-level processors', IACR Transactions on
  Symmetric Cryptology 2018(4), pp. 39--61.

Adiantum provides better security than a narrow-block cipher with CBC
or XTS, because every bit of each sector affects every other bit,
whereas with CBC each block of plaintext only affects the following
blocks of ciphertext in the disk sector, and with XTS each block of
plaintext only affects its own block of ciphertext and nothing else.

Adiantum generally provides much better performance than
constant-time AES-CBC or AES-XTS software do without hardware
support, and performance comparable to or better than the
variable-time (i.e., leaky) AES-CBC and AES-XTS software we had
before.  (Note: Adiantum also uses AES as a subroutine, but only once
per disk sector.  It takes only a small fraction of the time spent by
Adiantum, so there's relatively little performance impact to using
constant-time AES software over using variable-time AES software for
it.)

Adiantum naturally scales to essentially arbitrary disk sector sizes;
sizes >=1024-bytes take the most advantage of Adiantum's design for
performance, so 4096-byte sectors would be a natural choice if we
taught cgd to change the disk sector size.  (However, it's a
different cipher for each disk sector size, so it _must_ be a cgd
parameter.)

The paper presents a similar construction HPolyC.  The salient
difference is that HPolyC uses Poly1305 directly, whereas Adiantum
uses Poly1395(NH(...)).  NH is annoying because it requires a
1072-byte key, which means the test vectors are ginormous, and
changing keys is costly; HPolyC avoids these shortcomings by using
Poly1305 directly, but HPolyC is measurably slower, costing about
1.5x what Adiantum costs on 4096-byte sectors.

For the purposes of cgd, we will reuse each key for many messages,
and there will be very few keys in total (one per cgd volume) so --
except for the annoying verbosity of test vectors -- the tradeoff
weighs in the favour of Adiantum, especially if we teach cgd to do
>>512-byte sectors.

For now, everything that Adiantum needs beyond what's already in the
kernel is gathered into a single file, including NH, Poly1305, and
XChaCha12.  We can split those out -- and reuse them, and provide MD
tuned implementations, and so on -- as needed; this is just a first
pass to get Adiantum implemented for experimentation.

(riastradh)

2020-06-29 23:41:35 UTC MAIN commitmail json YAML

VIA AES: Batch AES-XTS computation into eight blocks at a time.

Experimental -- performance improvement is not clearly worth the
complexity.

(riastradh)

2020-06-29 23:40:28 UTC MAIN commitmail json YAML

uvm: Make sure swap encryption IV is 128-bit-aligned on stack.

Will help hardware-assisted AES.

(riastradh)

2020-06-29 23:39:31 UTC MAIN commitmail json YAML

2020-06-29 23:38:02 UTC MAIN commitmail json YAML

padlock(4): Remove legacy rijndael API use.

This doesn't actually need to compute AES -- it just needs the
standard AES key schedule, so use the BearSSL constant-time key
schedule implementation.

XXX Compile-tested only.
XXX The byte-order business here seems highly questionable.

(riastradh)

2020-06-29 23:36:59 UTC MAIN commitmail json YAML

Provide the standard AES key schedule.

Different AES implementations prefer different variations on it, but
some of them -- notably VIA -- require the standard key schedule to
be available and don't provide hardware support for computing it
themselves.  So adapt BearSSL's logic to generate the standard key
schedule (and decryption keys, with InvMixColumns), rather than the
bitsliced key schedule that BearSSL uses natively.

(riastradh)

2020-06-29 23:36:07 UTC MAIN commitmail json YAML

cgd(4): Align IVs on the stack.

This will make it easier for some hardware crypto support.

(riastradh)

2020-06-29 23:35:26 UTC MAIN commitmail json YAML

cgd(4): Print which key size is broken when a self-test fails.

Can be gleaned from the test index but this is a little quicker.

(riastradh)

2020-06-29 23:34:48 UTC MAIN commitmail json YAML

opencrypto: Switch from legacy rijndael API to new aes API.

While here, apply various rijndael->aes renames, reduce the size
of aesxcbc_ctx by 480 bytes, and convert some malloc->kmem.

Leave in the symbol enc_xform_rijndael128 for now, though, so this
doesn't break any kernel ABI.

(riastradh)

2020-06-29 23:33:46 UTC MAIN commitmail json YAML

uvm(9): Switch from legacy rijndael API to new aes API.

(riastradh)

2020-06-29 23:33:05 UTC MAIN commitmail json YAML

cgd(4): Switch from legacy rijndael API to new aes API.

(riastradh)

2020-06-29 23:32:24 UTC MAIN commitmail json YAML

glxsb(4): Remove rijndael dependency.

This doesn't actually seem to depend on it in any way.

XXX Compile-tested only.

(riastradh)

2020-06-29 23:31:42 UTC MAIN commitmail json YAML

2020-06-29 23:29:40 UTC MAIN commitmail json YAML

Add x86 AES-NI support.

Limited to amd64 for now.  In principle, AES-NI should work in 32-bit
mode, and there may even be some 32-bit-only CPUs that support
AES-NI, but that requires work to adapt the assembly.

(riastradh)

2020-06-29 23:27:52 UTC MAIN commitmail json YAML

Rework AES in kernel to finally address CVE-2005-1797.

1. Rip out old variable-time reference implementation.
2. Replace it by BearSSL's constant-time 32-bit logic.
  => Obtained from commit dda1f8a0c46e15b4a235163470ff700b2f13dcc5.
  => We could conditionally adopt the 64-bit logic too, which would
      likely give a modest performance boost on 64-bit platforms
      without AES-NI, but that's a bit more trouble.
3. Select the AES implementation at boot-time; allow an MD override.
  => Use self-tests to verify basic correctness at boot.
  => The implementation selection policy is rather rudimentary at
      the moment but it is isolated to one place so it's easy to
      change later on.

This (a) plugs a host of timing attacks on, e.g., cgd, and (b) paves
the way to take advantage of CPU support for AES -- both things we
should've done a decade ago.  Downside: Computing AES takes 2-3x the
CPU time.  But that's what hardware support will be coming for.

Rudimentary measurement of performance impact done by:

mount -t tmpfs tmpfs /tmp
dd if=/dev/zero of=/tmp/disk bs=1m count=512
vnconfig -cv vnd0 /tmp/disk
cgdconfig -s cgd0 /dev/vnd0 aes-cbc 256 < /dev/zero
dd if=/dev/rcgd0d of=/dev/null bs=64k
dd if=/dev/zero of=/dev/rcgd0d bs=64k

The AES-CBC encryption performance impact is closer to 3x because it
is inherently sequential; the AES-CBC decryption impact is closer to
2x because the bitsliced AES logic can process two blocks at once.

Discussed on tech-kern:

https://mail-index.NetBSD.org/tech-kern/2020/06/18/msg026505.html

(riastradh)

2020-06-29 23:22:27 UTC MAIN commitmail json YAML

2020-06-29 23:04:57 UTC MAIN commitmail json YAML

2020-06-29 22:50:11 UTC MAIN commitmail json YAML

Add quotes around command substitution in the example
so that it works regardless of IFS and buts.
Requested by kre@

(uwe)

2020-06-29 21:45:50 UTC MAIN commitmail json YAML

when using two linked requests for I/O (i.e. when backend doesn't support
INDIRECT segments), make sure to clear req_bp for both of them

fixes a misfired assertion in BLKIF_OP_FLUSH_DISKCACHE - PR port-xen/55431

(jdolecek)

2020-06-29 20:53:40 UTC MAIN commitmail json YAML

Avoid copyright issues and name the listed author as the copyright holder.

In a private email, Miloslav had agreed that if they had written the
test, then it can be licensed bsd-2-clause. I am going to assume this
is true as the file names Miloslav as the author.

This test was likely sent to tcsh (not netbsd) that had changed bug
report systems since.

(maya)

2020-06-29 17:09:33 UTC MAIN commitmail json YAML

Fix for last checkin, don't try use non-existent register from a (currently) dummy struct

(scole)

2020-06-29 14:22:11 UTC MAIN commitmail json YAML

Use -Wl,--no-fatal-warnings for the mktemp(3) test.

(jruoho)

2020-06-29 14:01:14 UTC MAIN commitmail json YAML

Use two-letter weekday abbreviations in the heading

This matches output from ncal (a.k.a. cal) as found in FreeBSD and
bsdmainutils. (Why had "T" been found more ambiguous than "S" already?)

(kim)

2020-06-29 09:57:46 UTC MAIN commitmail json YAML

Update Spleen wscons fonts to version 1.8.0, bringing the following
improvements:

- Improve ampersand character, making it more consistent with other
  sizes (5x8 version)

(fcambus)

2020-06-29 09:56:51 UTC MAIN commitmail json YAML

increase UPAGES (used for lwp kernel stack) for SVS so the the
amount of actually usable kernel stack is the same for SVS and
non-SVS kernels (currently 12 KiB)

discussed with maxv@, part of investigation for PR kern/S55402

(jdolecek)

2020-06-29 09:45:35 UTC MAIN commitmail json YAML

Update Spleen kernel fonts to version 1.8.0, bringing the following
improvements:

- Improve ampersand character, making it more consistent with other
  sizes (5x8 version)

(fcambus)

2020-06-29 09:24:07 UTC MAIN commitmail json YAML

Check the return value of iic_acquire_bus(). This function may fail.

One of the case is driver's detaching phase on shutdown. mutex_tryenter()
might fail and return with EBUSY. To avoid calling iic_release_bus() without
taking lock, check the return value of iic_acquire_bus().

(msaitoh)

2020-06-29 08:55:00 UTC MAIN commitmail json YAML

kyua-cli: fix build of .cpp files

Fix assignment of SRCS for C++ sources that use .cpp instead of .cc.

(lukem)

2020-06-29 08:34:17 UTC MAIN commitmail json YAML

Fix addition of C++ .cc source to SRCS

Fix assumption that all of the source files are .c, as some are .cc.

(lukem)

2020-06-29 08:30:42 UTC MAIN commitmail json YAML

use ggc-none.c not ggc-none.o in SRCS

(lukem)

2020-06-29 06:51:32 UTC MAIN commitmail json YAML

Remove evcnt(9) counter for tlbhit; there's no way to observe TLB hits
from kernel, and it just counted intersection b/w tlbmiss and tlbenter.

(rin)

2020-06-29 06:39:38 UTC MAIN commitmail json YAML

No longer depend on libl.

(rin)

2020-06-29 06:01:30 UTC MAIN commitmail json YAML

KNF. No functional change.

(msaitoh)

2020-06-29 01:37:27 UTC MAIN commitmail json YAML

Allow kernel to compile by preventing "error: stack usage is ..."
too-large errors.  What was there previously was not correct and this
will need to be revisited for debugger to ever become functional
anyway.

(scole)

2020-06-28 21:37:05 UTC MAIN commitmail json YAML

Remove Xr to extattr(2) which we don't have.

(wiz)

2020-06-28 18:23:01 UTC MAIN commitmail json YAML

2020-06-28 14:37:53 UTC MAIN commitmail json YAML

Fix struct entry size (thanks kre@)

(christos)

2020-06-28 14:26:19 UTC MAIN commitmail json YAML

Add font files for Spleen, which can be loaded into the wsfont pool
or a wscons display device using wsfontload(8).

For example, Spleen 16x32 can be loaded and enabled as follow:

wsfontload -N spleen-16x32 -w 16 -h 32 spleen-16x32.fnt
wsconsctl -dw font=spleen-16x32

(fcambus)

2020-06-28 13:33:06 UTC MAIN commitmail json YAML

Fix mm_md_kernacc() for 64 bit kernels (including n32):
- FAULT for any physical address less than start of cached XKPHY address.
- Pass any remaining physical address less then end of RAM.
- Pass any remaining physical address within the KEGS0 kernel address range.
Ignore all remaining addresses and fall back to uvm_kernacc() for checking
virtual address ranges.

Fixes pmap(1) (and probably other kmem grovellers).

(simonb)