indent: simplify handling of comments

No functional change.

(rillig)

indent: split printing of comments into smaller functions

No functional change.

(rillig)

Fix MKDEBUGLIB build by adding these installed files to the debug
set list.

XXX
One could argue that these files are not of any use, so why install
them?  I don't have a good argument either way, and this is (for
now) a simple work-around for PR bin/57455  Please feel free to
commit a different fix to avoid installing these files at all.

(pgoyette)

tests/indent: comments with trailing whitespace may fit in a single line

(rillig)

indent: condense code for writing tabs

No functional change.

(rillig)

indent: sort functions in call order

No functional change.

(rillig)

indent: compute indentation of 'case' labels on-demand

One less moving part to keep track of.

No functional change.

(rillig)

bsd.README: update to reality, sync from mk.conf(5)

Sync user variables from mk.conf(5), sorted.
(Arguably this could just refer to mk.conf(5)
or share/man/man5/mk.conf.5 and remove the copypasta.)

Document NOxxx overrides in own subsection.

Unexpand tabs, tweak after.

(lukem)

BUILDING: editorial

MKX11=yes wants MKINET6=yes

Change the width of the variable lists to 14n (from 15n)
so that when the lists are rendered and then left aligned,
the column is 16 characters (aka 2 tabs) which makes
copypasta to bsd.README easier.

(lukem)

mk.conf(5): editorial

MKDTB and MKPIE are .YorN.
MKX11=yes wants MKINET6=yes.
MKLINKLIB deserves a dash list (like bsd.README).

Expand per bsd.README: MKSTATICPIC, MKUNPRIVED,
MKX11, MKZFS, USE_LIBCSANITIZER, USE_SSP

Change the width of the variable lists to 14n (from 15n)
so that when the lists are rendered and then left aligned,
the column is 16 characters (aka 2 tabs) which makes
copypasta to bsd.README easier.

(lukem)

indent: in 'if (expr)', the parentheses do not form a cast expression

No functional change.  When stepping through the code in debug mode, it
was just too confusing that indent would log an 'unknown cast' in this
situation.

(rillig)

Fix previous comment fix, which broke a comment.

(martin)

We cannot handle input with precision != stride yet.
Drain input buffer for unhandled input.

(mlelstv)

tests/indent: add test for left-justifying declarations

(rillig)

indent: improve layout of debug output

(rillig)

indent: sync debug output with parser state

(rillig)

Un-comment the ident line

(pgoyette)

indent: clean up comments

(rillig)

indent: format own source code

(rillig)

indent: don't remove blank line after 'if (expr) {'

(rillig)

/etc/rc.d/sshd: Use default curve for ECDSA keygen, not NIST P-521.

The default is NIST P-256, which:

(a) has plenty of cryptanalytic security,
(b) performs better on essentially all platforms (smaller enough that
    even the advantage of the Mersenne prime structure of P-521 can't
    compete), and
(c) likely gets more scrutiny on implementations than P-521 since it's
    more widespread.

(riastradh)

/etc/rc.d/sshd: Stop generating DSA host keys by default.

If you want them you can generate them yourself, but in this day and
age (Monday and 2023, specifically) there's no reason to be using DSA
except for compatibility with ancient legacy software.

(riastradh)

indent: do not report broken lines, report configuration on stderr

(rillig)

indent: fix formatting of 'do' statements

(rillig)

indent: make heuristics for '*' pointer types simpler

Previously, a '}' token did not reset the state machine, but it should.

(rillig)

indent: fix trailing whitespace after comment

(rillig)

tests/indent: add tests for 'do-while' loops

(rillig)

indent: rename variables, clean up comments

No binary change.

(rillig)

indent: clean up handling of whitespace

No functional change.

(rillig)

indent: let the output routines keep track of the indentation

No functional change.

(rillig)

Make DEBUG_FFS_MOUNT compile again (with 64-bit ino_t).

(rin)

route: run workqueue kthreads with KERNEL_LOCK unless NET_MPSAFE

Without KERNEL_LOCK, rt_timer_work and rt_free_work can run in parallel
with other LWPs running in the network stack, which eventually results
in say use-after-free of a deleted route.

(ozaki-r)

- Fix clearing of EINT and other transient flags.

Patches from sc.dying in kern/56115:
- Set proper Max ESIT Payload value for interrupt/isoc endpoint context.
- Set proper Average TRB Length value.
- Not tested on superspeed/superspeedplus isochronous device.

- Add handling of some error paths for isochronous transfers.

(mlelstv)

ld.elf_so: Sprinkle more debug messages on dlopen and error.

PR pkg/57445

(riastradh)

indent: do not parse '&&&&&&&' as a single binary operator

(rillig)

indent: fix '*=' to be a binary operator, not a unary one

(rillig)

tests/indent: cover code in lexi.c

(rillig)

The ATF design is O(N^2) in the number of TCs in one TP, which on some
slower platforms causes the net/ipsec tests to take as much as 30% of
the total time to run all of the ATF tests.  Reduce the number of TCs
in various net/ipsec TPs by iterating over *_ALGORITHMS_MINIMUM rather
than *_ALGORITHMS.  Various of the net/ipsec tests already use the
smaller lists, so change the rest of them to do so as well.

(chs)

indent: remove read pointer from buffers that don't need it

The only buffer that needs a read pointer is the current input line in
'inp'.

No functional change.

(rillig)

indent: fix out-of-bounds read when reading a comment

(rillig)

BUILDING: update from canonical mk.conf(5)

Incorporate content and styles updates for mk.conf entries
from share/man/man5/mk.conf.5, which is the canonical
reference for mk.conf.

Add: BSDOBJDIR, BSDSRCDIR, EXTERNAL_TOOLCHAIN, MKDEBUGKERNEL,
MKDEBUGTOOLS, MKHTML, MKLINKLIB, MKOBJDIRS, TOOLCHAIN_MISSING,
NETBSDSRCDIR

It's for further study as to whether we just replace the
most of subsection "make" variables with a link to mk.conf(5).

Style:
- Add more .de macros per mk.conf.5.
- Order list items alphabetically. When multiple items are present
  in a list item, sort within the item first.
- More cross-references.

(lukem)

mk.conf(5): add more from BUILDING and bsd.README

Add from BUILDING or bsd.README:
BUILDINFO, BUILDSEED, EXTERNAL_TOOLCHAIN, MKCROSSGDB,
MKREPRO_TIMESTAMP, TOOLCHAIN_MISSING, X11SRCDIR

Clarify BUILDID.
Improve MKDEBUG, MKOBJ, MKX11, NETBSDSRCDIR, USETOOLS,
Consistent Note: formatting.

(lukem)

Avoid using uninitialized variable "symnum" when building with DEBUG
enabled by borrowing the rdbg_symname() macro from arch/x86_64.

(martin)

tests/indent: clean up comments

(rillig)

indent: remove trailing whitespace from README

(rillig)

indent: force at least one space after the colon of a label

(rillig)

indent: track the kind of '{' on the parser stack

(rillig)

llvm tool build: fix warning

-std=c++14 is for HOST_CXXFLAGS not HOST_CPPFLAGS.

Fixes: cc1: warning: command-line option '-std=c++14' is valid for C++/ObjC++ but not for C

(lukem)

indent: fix debug output of the parser symbol stack

Even though the stack always contains a stmt_list as first element,
print it nevertheless to avoid confusion about starting at index 1, and
to provide the full picture.

(rillig)

tools: revert use of <bsd.hostinit.mk>

tools/Makefile.host revision 1.35 changed from
  setting various NOxxx variables and .include <bsd.own.mk>
to
  .include <bsd.hostinit.mk>
which sets the same NOxxx variables, .include <bsd.init.mk>
which optionally .include ../Makefile.inc before .include <bsd.own.mk>.

This chnage caused build failures with HAVE_LLVM=yes, so revert rev 1.35.
(Maybe to do with the .include ../Makefile.inc. The tools/llvm* build is
tricky, and it's easier to revert this change than debug.)

(lukem)

Note kernel build lossage in an unsupported build configuration

(martin)

indent: ensure that the 'block init level' never goes negative

No functional change.

(rillig)

indent: rename struct field, for better symmetry

No binary change outside debug mode.

(rillig)

indent: fix indentation of initializers in compound expressions

(rillig)

indent: fix formatting of compound expressions, at least partially

(rillig)

lint: use separate lexer symbols for 'case' and 'default'

It's not strictly necessary since these tokens behave in the same way,
still, the code is more straight-forward when there are separate tokens.

(rillig)

indent: classify 'inline' as a modifier rather than a word

(rillig)

mesa: Remove massive kludge that worked around PR toolchain/50277.

Now that the underlying bug in ld.elf_so is fixed, the workaround is
causing harm.

XXX pullup-10

(riastradh)

indent: use separate lexer symbols for the different kinds of ':'

(rillig)

indent: handle the indentation of 'case' in a simpler way

(rillig)

indent: separate code for handling parentheses and brackets

Handling parentheses is more complicated than for brackets.

(rillig)

tools: use <bsd.hostinit.mk> where appropriate

bsd.hostinit.mk sets a bunch of NOxxx variables before
including bsd.init.mk (which includes bsd.own.mk),
so simplify instead of replicating the NOxxx setup
for host tools.

(lukem)

Fix interactions of initial-exec TLS model and dlopen

(1) If an initial-exec relocation was used for a non-local symbol
(i.e. the definition of the symbol is in a different DSO), the
computation of the static TLS offset used the wrong DSO.
This would effectively mean the wrong address was computed
(PR toolchain/50277, PR pkg/57445).

Fix this by forcing the computation of the correct DSO (the one defining
the symbol).

This code uses __UNCONST to avoid the vast interface changes for this
special case.

(2) If symbols from a DSO loaded via dlopen are used with both
global-dynamic/local-dynamic and initial-exec relocations AND
a initial-exec relocation was resolved first in a thread, a split brain
situation could exist where the dynamic relocations would use one memory
block (separate allocation) and the initial-exec relocations the static
per-thread TLS space.

(3) If the initial-exec relocation in (2) is seen after any thread has
already used a GD/LD allocation, bail out. Since IE relocations are used
only in the GOT, this will prevent the dlopen. This is a bit more
aggressive than necessary, but a full blown reference counting doesn't
seem to be justified.

(joerg)

indent: fix indentation of adjacent '{'

(rillig)

adapt to ${CC_WNO_STRINGOP_TRUNCATION}

(lukem)

adapt to ${CC_WNO_STRINGOP_OVERFLOW}

Use ${CC_WNO_STRINGOP_OVERFLOW} instead of
the older style more complex expressions.

Remove workarounds if they were only for gcc < 10.

(lukem)

adapt to ${CC_WNO_MAYBE_UNINITIALIZED}

Use ${CC_WNO_MAYBE_UNINITIALIZED} instead of
the older style more complex expressions.

Remove workarounds if they were for a specific
version of gcc < 10.

(lukem)

adapt to ${CC_WNO_IMPLICIT_FALLTHROUGH}

Use ${CC_WNO_IMPLICIT_FALLTHROUGH} instead of
the older style more complex expressions.

(lukem)

adapt to ${CC_WNO_FORMAT_TRUNCATION}

(lukem)

dhcp: remove gcc 8 workaround

(if it's needed, add it back using ${CC_WNO_FORMAT_OVERFLOW})

(lukem)

ipmon: remove duplicate warning suppression

(lukem)

adapt to ${CC_WNO_ADDRESS_OF_PACKED_MEMBER}

Simplify CWARNFLAGS to use ${CC_WNO_ADDRESS_OF_PACKED_MEMBER}
which works for both clang and gcc, and remove compiler-specific
equivalents.

(lukem)

bsd.*.mk: move MKSTRIPSYM default to bsd.own.mk

Add default for MKSTRIPSYM=yes to to bsd.own.mk _MKVARS.no.
Test ${MKSTRIPSYM} != "no".

(lukem)

indent: clean up handling of brace indentation

No functional change.

(rillig)

bsd.obj.mk: move MKHOSTOBJ to bsd.own.mk

Add default for MKHOSTOBJ=no to to bsd.own.mk _MKVARS.no.
Simplify bsd.obj.mk check.

(lukem)

bsd.dep.mk: move MKDEPINCLUDES to bsd.own.mk

Add default for MKDEPINCLUDES=no to to bsd.own.mk _MKVARS.no.
Simplify bsd.dep.mk check.

(lukem)

bsd.*.mk: move MKCLEAN* to bsd.own.mk

Move the defaults for MKCLEANSRC and MKCLEANVERIFY
from bsd.clean.mk to bsd.own.mk _MKVARS.yes.

(lukem)

mkvars.mk: sort MKEXTRAVARS and remove dupes

Sort MKEXTRAVARS.
Remove obsolete MKBFD.
Remove entries already in <bsd.own.mk> _MKVARS.no or _MKVARS.yes:
MKCOMPATTESTS MKDTC MKDYNAMICROOT MKFIRMWARE MKMANZ
MKRADEONFIRMWARE MKSLJIT MKSOFTFLOAT MKXORG_SERVER

Sorted output of comparing "before" and "after" is identical
besides those variables listed above.

(lukem)

lint: add query for static variables in functions

This query allows finding hidden global variables, as an easier-to-read
alternative to 'objdump -t'.

(rillig)

lint: loosen assertion that unary operators have only a single operand

(rillig)

fix various typos in comments and messages.

(andvar)

lint: use consistent and configurable stream for debug output

(rillig)

lint: provide more detailed types when operands do not match

(rillig)

fix typo xbase-obsolet -> xbase-obsolete.

(andvar)

Tickets #1635 - #1641

(martin)

Pull up following revision(s) (requested by andvar in ticket #1641):

external/apache2/mDNSResponder/dist/mDNSShared/PlatformCommon.c: revision 1.7
external/apache2/mDNSResponder/dist/mDNSPosix/PosixDaemon.c: revision 1.16

mdnsd(8): restore fixes for PR bin/46758, lost on resolving merge conflicts.

Original commit message from Roy Marples:
"Derive our primary interface and address by trying to connect to an
address in the TEST-NET-2 network as noted in RFC5737 instead of using
the 1.1.1.1 address. Also, use port 7 (echo) for better style.
Fixes PR bin/46758 thanks to Lloyd Parkes."

(martin)

Tickets #185 - #193

(martin)

Pull up following revision(s) (requested by andvar in ticket #193):

external/apache2/mDNSResponder/dist/mDNSShared/PlatformCommon.c: revision 1.7
external/apache2/mDNSResponder/dist/mDNSPosix/PosixDaemon.c: revision 1.16

mdnsd(8): restore fixes for PR bin/46758, lost on resolving merge conflicts.

Original commit message from Roy Marples:
"Derive our primary interface and address by trying to connect to an
address in the TEST-NET-2 network as noted in RFC5737 instead of using
the 1.1.1.1 address. Also, use port 7 (echo) for better style.
Fixes PR bin/46758 thanks to Lloyd Parkes."

(martin)

Pull up the following revisions, requested by kim in ticket #1640:

bin/date/Makefile                              up to 1.16
bin/date/date.1                                up to 1.54
bin/date/date.c                                up to 1.65

Add -R option for displaying time in RFC 5322 format, similar to GNU date.
Add -f option to set the time. From FreeBSD.

(martin)

Pull up following revision(s) (requested by kim in ticket #192):

bin/date/date.1: revision 1.52
bin/date/date.1: revision 1.53
bin/date/date.1: revision 1.54
bin/date/date.c: revision 1.64
bin/date/date.c: revision 1.65

Add -R option for displaying time in RFC 5322 format, similar to GNU date.

date(1): minor markup fixes

Add -R to usage

date(1): sync two [[[[[CC]yy]mm]dd]HH]MM[.SS] instances
The markup was the same (modulo Li vs Cm for the dot before the
seconds), but use the same source markup grouping/layout in both to
make this fact more obvious.

(martin)

Pull up following revision(s) (requested by sborrill in ticket #1639):

sys/dev/ipmi.c: revision 1.10

Ignore non-recoverable and critical limits smaller than the warning limits.
These are usually invalid.

Name the limit flags to make code more readable.

(martin)

Pull up following revision(s) (requested by sborrill in ticket #191):

sys/dev/ipmi.c: revision 1.10

Ignore non-recoverable and critical limits smaller than the warning limits.
These are usually invalid.

Name the limit flags to make code more readable.

(martin)

Pull up following revision(s) (requested by nat in ticket #190):

sys/external/bsd/drm2/i915drm/intelfb.c: revision 1.25

Use the offset in mmap calculations.
It fixes wsfb(4) when used with intelfb(4).

Ok riastradh@

(martin)

Ticket #1823

(martin)

Pull up following revision(s) (requested by abs in ticket #1823):

sys/arch/amiga/stand/loadbsd/loadbsd.c: revision 1.38
distrib/amiga/stand/loadbsd.uue: revision 1.4
sys/arch/amiga/stand/loadbsd/startit.s: revision 1.1
sys/arch/amiga/stand/loadbsd/Makefile: revision 1.5
sys/arch/amiga/stand/loadbsd/vmakefile: revision 1.1
sys/arch/amiga/stand/loadbsd/README: revision 1.6

Update loadbsd source and distribution binary to version 3.3.
- Loading the kernel to the highest priority memory segment is default now.
- New option -l to revert the to the previous behaviour of largest segment.
- New option -M to define a minimum size for the memory segment.
- Fixed some warnings and typos.
- Put assembler inline source into its own source text startit.s.
- Can be built with Bebbo's gcc6 Amiga port or with vbcc.

(martin)

Pull up following revision(s) (requested by abs in ticket #1638):

sys/arch/amiga/stand/loadbsd/loadbsd.c: revision 1.38
distrib/amiga/stand/loadbsd.uue: revision 1.4
sys/arch/amiga/stand/loadbsd/startit.s: revision 1.1
sys/arch/amiga/stand/loadbsd/Makefile: revision 1.5
sys/arch/amiga/stand/loadbsd/vmakefile: revision 1.1
sys/arch/amiga/stand/loadbsd/README: revision 1.6

Update loadbsd source and distribution binary to version 3.3.
- Loading the kernel to the highest priority memory segment is default now.
- New option -l to revert the to the previous behaviour of largest segment.
- New option -M to define a minimum size for the memory segment.
- Fixed some warnings and typos.
- Put assembler inline source into its own source text startit.s.
- Can be built with Bebbo's gcc6 Amiga port or with vbcc.

(martin)

Pull up following revision(s) (requested by abs in ticket #189):

sys/arch/amiga/stand/loadbsd/loadbsd.c: revision 1.38
distrib/amiga/stand/loadbsd.uue: revision 1.4
sys/arch/amiga/stand/loadbsd/startit.s: revision 1.1
sys/arch/amiga/stand/loadbsd/Makefile: revision 1.5
sys/arch/amiga/stand/loadbsd/vmakefile: revision 1.1
sys/arch/amiga/stand/loadbsd/README: revision 1.6

Update loadbsd source and distribution binary to version 3.3.
- Loading the kernel to the highest priority memory segment is default now.
- New option -l to revert the to the previous behaviour of largest segment.
- New option -M to define a minimum size for the memory segment.
- Fixed some warnings and typos.
- Put assembler inline source into its own source text startit.s.
- Can be built with Bebbo's gcc6 Amiga port or with vbcc.

(martin)

Pull up following revision(s) (requested by uwe in ticket #188):

sys/ddb/db_command.c: revision 1.182

ddb: PR kern/57435 - fix duplicate "show mount"

Bolivar cannot carry double.  One of these commands should have been
"show mounts", cf. page/pages and a few others.  While here fix the
function name to be db_show_all_mounts to conform to the pattern.

(martin)

Pull up following revision(s) (requested by rin in ticket #1637):

sys/dev/pci/if_aq.c: revision 1.45

aq(4): if_transmit: Invoke softint_schedule(9) with kpreempt disabled.

(martin)

Pull up following revision(s) (requested by rin in ticket #187):

sys/dev/pci/if_aq.c: revision 1.45

aq(4): if_transmit: Invoke softint_schedule(9) with kpreempt disabled.

(martin)

Pull up following revision(s) (requested by yamaguchi in ticket #186):

sys/dev/pci/virtio_pci.c: revision 1.41
sys/dev/pci/virtio_pci.c: revision 1.42
sys/dev/virtio/virtio_mmio.c: revision 1.10
sys/dev/pci/virtiovar.h: revision 1.29
sys/dev/pci/virtio.c: revision 1.75
sys/dev/pci/virtio.c: revision 1.76
sys/dev/pci/virtio.c: revision 1.77
sys/dev/pci/virtio.c: revision 1.78

virtio@pci: Fix assertion on detach.

If the child never attached in the first place, it's OK for it to not
have detached.

XXX This should not be a set of flags; this should be a state
enumeration, because some flags make no sense, like FINISHED|FAILED.

XXX This should not be asserted separately in each bus; there should
be a single place in virtio.c to assert this, uniformly in all buses.

PR kern/57357

Use enumeration for state of a child driver instead of flags
and check its detaching by using sc->sc_child in virtio_softc
pointed out by riastradh, thanks.
fixes PR/57357

Fix not to allocate unnecessary descriptor
fixes PR/57358

virtio(4): change variable name, nfc

virtio(4): change members of struct vring_desc_extra before free a slot

This prevents the following race condition.
1. Thread-A: calls virtio_dequeue_commit() and
            puts a slot into free descriptor chain in vq_free_slot()
2. Thread-B: calls virtio_enqueue_prep() and get the slot stored by Thread-A
3. Thread-B: calls virtio_enqueue_reserve() and
            changes desc_base and desc_free_idx for the slot
4. Thread-A: changes the same members updated by Thread-B
reported by hannken, thanks.

(martin)

Pull up following revision(s) (requested by rin in ticket #1636):

sys/lib/libsa/subr_prf.c: revision 1.30

libsa/printf: Do not fetch long va_arg as long long.

This does real harm iff all of the following conditions are satisfied:
(1) On ILP32 architectures.
(2) Both LIBSA_PRINTF_LONGLONG_SUPPORT and LIBSA_PRINTF_WIDTH_SUPPORT
    compile-time options are enabled.
(3) Width field is used with 'l' modifier.

This is an implicit-fallthrough bug, but unfortunately, GCC 10.4 cannot
find this out somehow...

(martin)

Pull up following revision(s) (requested by rin in ticket #185):

sys/lib/libsa/subr_prf.c: revision 1.30

libsa/printf: Do not fetch long va_arg as long long.

This does real harm iff all of the following conditions are satisfied:
(1) On ILP32 architectures.
(2) Both LIBSA_PRINTF_LONGLONG_SUPPORT and LIBSA_PRINTF_WIDTH_SUPPORT
    compile-time options are enabled.
(3) Width field is used with 'l' modifier.

This is an implicit-fallthrough bug, but unfortunately, GCC 10.4 cannot
find this out somehow...

(martin)

Pull up following revision(s) (requested by lukem in ticket #1635):

external/gpl3/gcc/usr.bin/libdecnumber/Makefile: revision 1.9
external/gpl3/gcc/usr.bin/common/Makefile: revision 1.12
external/gpl3/gcc/usr.bin/backend/Makefile: revision 1.67
external/gpl3/gcc/usr.bin/common-target/Makefile: revision 1.12
external/gpl3/gcc/usr.bin/frontend/Makefile: revision 1.15
external/gpl3/gcc/usr.bin/libcpp/Makefile: revision 1.10

gcc: fix build with clang++ HOST_CXX

Define HOSTPROG_CXX before .include anything that brings in bsd.own.mk.

This ensures that HOST_DBG (etc) gets assigned before HOST_CFLAGS
and HOST_CXXFLAGS is created.
backend: .include <bsd.init.mk> much earlier, as per the other directories.

Fixes backend build when using clang++ as the host compiler (e.g., macOS),
because backend host tools are now built with -O.
Inspired by https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=255760

Fixes PR toolchain/57014

(martin)

ld.elf_so: Fix missing tab in debug/shl.mi in last change.

XXX pullup-10

(riastradh)

mk.conf: fix the year

(lukem)

regen

(lukem)

tools/compat: support all bsd.own.mk disabled warnings

Check the host CC support for all the warnings now in <bsd.own.mk>
and override appropriately in defs.mk.

In general there's a 1:1 mapping, with the special case
CC_WNO_ADDRESS_OF_PACKED_MEMBER which is set from both
@CC_WNO_ADDRESS_OF_PACKED_MEMBER@ (gcc) and
@CC_WNO_ERROR_ADDRESS_OF_PACKED_MEMBER@ (clang).

(lukem)

bsd.own.mk: rename GCC_NO_* to CC_WNO_*

Rename compiler-warning-disable variables from
GCC_NO_warning
to
CC_WNO_warning
where warning is the full warning name as used by the compiler.

GCC_NO_IMPLICIT_FALLTHRU is CC_WNO_IMPLICIT_FALLTHROUGH

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

(lukem)

bsd.own.mk: rename to CC_WNO_ADDRESS_OF_PACKED_MEMBER

Provide a single variable
CC_WNO_ADDRESS_OF_PACKED_MEMBER
with options for both clang and gcc, to replace
CLANG_NO_ADDR_OF_PACKED_MEMBER
CC_NO_ADDR_OF_PACKED_MEMBER
GCC_NO_ADDR_OF_PACKED_MEMBER

Using the convention CC_compilerflag, where compilerflag
is based on the full compiler flag name.

(lukem)

etc.sparc64: remove obsolete MK32BITLIBS

As there's a functional MKCOMPAT implementation, and
MK32BITLIBS=yes hasn't worked since 2002 (and noone
noticed the latter), remove obsolete MK32BITLIBS code.

Per confirmation from martin@, mrg@, and riastradh@ on ICB.

(lukem)

build.sh: MAKECONF and mk.conf(5) improvements

Move MAKECONF to the Environment variables section.
Add mk.conf(5) cross-references.
Make Notes more obvious.
Fix mandoc lint.

(lukem)

build.sh: add show-params operation

Add show-params operation to the makefile target, and reword
params operation to describe what it's done since 2012.

(In 2012-11-04 the Makefile's previous params target was renamed
to show-params and a new params target was added to save a 'params'
file, and build.sh wasn't adapted.)

(lukem)

tools: use NONLS= not MKNLS=no

(lukem)

ld.elf_so: Test dynamic-then-static abuse via ctor.

XXX pullup-10

(riastradh)

ld.elf_so: Test another edge case of mismatched TLS models.

One library defines a symbol and _doesn't_ use it, so it has no
indication of whether the symbol is for static TLS or dynamic TLS,
and then two other libraries use it in different ways.

XXX pullup-10

(riastradh)

ld.elf_so: tls_extern dynamic_defabuse_eager must xfail differently.

If a symbol has already been resolved as dynamic TLS, any library
that tries to use it as static TLS cannot be dlopened.

XXX pullup-10

(riastradh)

indent: force each statement on a new line

Previously, '{} while (cond)' was kept on a single line, even though the
'while' was independent of the '{}'.

(rillig)

indent: remove newline between 'switch' and '{'

(rillig)

etc.sparc64: fix syntax errors in MK32BITLIBS=yes

sparc64 snapshots with MK32BITLIBS=yes has been broken
because of make(1) and sh(1) syntax errors since
my change in revision 1.18 on 2002-12-03, when
snap_md_pre target was deprecated...
Move the rules to snap_md_post and fix the syntax errors.

The cross-build make snapshot snapbecause of the missing
$TOOLDIR/bin/sparc--netbsdelf-gcc due to the invocation
with SPARC32_ENV=MACHINE=sparc MACHINE_ARCH=sparc.
A separate issue to resolve.

(It seems MK32BITLIBS hasn't worked for 20+ years and
noone noticed! Do we need it?)

(lukem)

bsd.own.mk: obsolete non-MK variants MANZ UNPRIVED UPDATE

Remove support for variables deprecated 20 years ago
by their MK* equivalents.

(lukem)

build.sh: fix MKUNPRIVED comment

I renamed UNPRIVED to MKUNPRIVED 20 years ago, and missed a comment.

(lukem)

etc.hp300, etc.sparc64: fix MKUPDATE handling

UPDATE was replaced with MKUPDATE 20 years ago,
but these directories were missed in the conversion.

(lukem)

indent: improve heuristics of classifying '*' as pointer or operator

(rillig)

indent: clean up

Only print the 'token' buffer in debug mode if it is interesting, group
the blocks in handling of '(' tokens by topic, remove obsolete comment
from test.

(rillig)

ld.elf_so: Add new files to debug/shl.mi.

XXX pullup-10

(riastradh)

indent: fix formatting of declarations with preprocessing lines

(rillig)

tests/indent: demonstrate bugs when formatting preprocessing lines

(rillig)