Fix spelling of Kurt Shoens surname.
PR misc/57389

(uwe)

zz9k.4: clean up manual page

New sentence, new line; spelling, duplicate words.

(rillig)

t_fexecve.sh: fix head() function definitions of test cases

(gutteridge)

Driver for the MNT ZZ9000 Zorro board. Submitted by Alain Runa.

It was formerly known as mntzz, which Alain released three years ago.
Since then, the ZZ9000 had several firmware updates which changed some
hardware interface details rendering the former driver non functional in some
aspects. Also the audio card plug-in ZZ9000AX became available from MNT
Research. Considering the major rewrite of the driver in some areas he
decided to rename it to zz9k(9). The driver consists of several sub-drivers
each addressing different functionality of the MNT ZZ9000 & ZZ9000AX combo
card.

zz9k* is the main card driver and need to be enabled if any of the sub-driver
is enabled. zz9k on its own is not very useful, it only provides a common
zz9kbus for the other sub-drivers to connect to, so only enable it if one of
the zz9k sub-drivers are enabled.
zzfb* represents the graphics driver for the boot console and the dumb
framebuffer for X11 based on WSCONS. ZZFB_CONSOLE option enables the ZZ9000
to become the boot console.
zz* represents the ethernet interface of the ZZ9000. It basically works but
is considered experimental.
zzax* represents the ZZ9000AX audio card driver, audio* attaches to it to
provide audio output and input functionality. The driver is not functional
yet.
zzusb* represents the ZZ9000AX usb driver. It was not implemented yet and
probably never will.

(phx)

Cleanup previous: Try new bindings first, document old with DTCOMPAT, KNF

(jmcneill)

Pull up following revision(s) (requested by mrg in ticket #154):

sys/arch/arm/dts/rk3328-crypto.dtsi: revision 1.1
sys/arch/arm/dts/rk3328-rock64.dts: revision 1.8
sys/arch/arm/rockchip/rk3328_cru.c: revision 1.10
sys/arch/arm/rockchip/rk_v1crypto.c: revision 1.11

enable rkv1crypto on rock64.

this comes from upstream d1152bc533c941f7e267bf53d344cee510ea2808.
(i tried to make this be in rk3328.dtsi so all rk3328 boards would
benefit, but it doesn't work, and this is the only one have to test.)

adjust rkv1crypto to support a per-platform clocks setup.

(martin)

Tickets #152 - #155

(martin)

Pull up following revision(s) (requested by jmcneill in ticket #155):

sys/arch/arm/ep93xx/ep93xx_intr.c: revision 1.28
sys/arch/arm/ep93xx/ep93xxvar.h: revision 1.7
sys/arch/evbarm/tsarm/tsarm_machdep.c: revision 1.36

TS7200: Defer event counter registration until after evcnt is initialized

Patch from Lloyd Parkes in PR kern/57386

(martin)

Pull up following revision(s) (requested by mlelstv in ticket #153):

sys/dev/pad/pad.c: revision 1.80
sys/dev/pad/pad.c: revision 1.81
sys/dev/pad/pad.c: revision 1.82
sys/dev/pad/pad.c: revision 1.79
sys/dev/pad/padvar.h: revision 1.17

Pace I/O timing to match the audio interface.

Enable interrupts while copying buffers.

Write slinear_le 16bit samples, independent from platform and
AUDIO_INTERNAL_BITS.

No longer use AUDIO_INTERNAL_BITS but rely on passed audio format.
Don't overflow when scaling 32bit samples.

(martin)

Ticket #1822

(martin)

Pull up following revision(s) (requested by mlelstv in ticket #1822):

lib/libc/locale/newlocale.c: revision 1.4

Fix parsing a locale string with multiple components.
Also check for truncation of a long locale string.

(martin)

Ticket #1630

(martin)

Pull up following revision(s) (requested by mlelstv in ticket #1630):

lib/libc/locale/newlocale.c: revision 1.4

Fix parsing a locale string with multiple components.
Also check for truncation of a long locale string.

(martin)

Pull up following revision(s) (requested by mlelstv in ticket #152):

lib/libc/locale/newlocale.c: revision 1.4

Fix parsing a locale string with multiple components.
Also check for truncation of a long locale string.

(martin)

apparently the 'ahb' and 'ths' clocks were renamed to 'bus' and 'mod' in the
fdt at some point, so look for those as well
with this my pinebook's sensors work again

(macallan)

TS7200: Defer event counter registration until after evcnt is initialized

Patch from Lloyd Parkes <lloyd@must-have-coffee.gen.nz> in PR# kern/57386

(jmcneill)

t_expr.sh: fix naming of head() of lang test case

(gutteridge)

Create the INFODIRFILE if it does not exist, so that we can take a lock
on it. Hopefully fixes a race condition where two parallel makes attempt
to create the file at the same time.

(christos)

Don't overflow when scaling 32bit samples.

(mlelstv)

mutex(9): Write comments in terms of ordering semantics.

Phrasing things in terms of implementation details like `acquiring
and locking cache lines' both suggests a particular cache coherency
protocol, paints an incomplete picture for more involved protocols,
and doesn't really help to prove theorems the way ordering relations
do.

No functional change intended.

(riastradh)

mutex(9): Omit needless membar_consumer.

In practical terms, this is not necessary because MUTEX_SET_WAITERS
already issues MUTEX_MEMBAR_ENTER, which on all architectures is a
sequential consistency barrier, i.e., read/write-before-read/write,
subsuming membar_consumer.

In theoretical terms, MUTEX_MEMBAR_ENTER might imply only
write-before-read/write, so one might imagine that the
read-before-read ordering of membar_consumer _could_ be necessary.
However, the memory operations that are significant here are:

1. load owner := mtx->mtx_owner
2. store mtx->mtx_owner := owner | MUTEX_BIT_WAITERS
3. load owner->l_cpu->ci_curlwp to test if equal to owner

(1) is program-before (2) and at the same memory location,
mtx->mtx_owner, so (1) happens-before (2).

And (2) is separated in program order by MUTEX_MEMBAR_ENTER from (3),
so (2) happens-before (3).

So even if the membar_consumer were intended to guarantee that (1)
happens-before (3), it's not necessary, because we can already prove
it from MUTEX_MEMBAR_ENTER.

But actually, we don't really need (1) happens-before (3), exactly;
what we really need is (2) happens-before (3), since this is a little
manifestation of Dekker's algorithm between cpu_switchto and
mutex_exit, where each CPU sets one flag and must ensure it is
visible to the other CPUs before testing the other flag -- one flag
here is the MUTEX_BIT_WAITERS bit, and the other `flag' here is the
condition owner->l_cpu->ci_curlwp == owner; the corresponding logic,
in cpu_switchto, is:

1'. store owner->l_cpu->ci_curlwp := owner
2'. load mtx->mtx_owner to test if MUTEX_BIT_WAITERS set

(riastradh)

s/betwen/between/ and s/singed/signed/.

(andvar)

drm: KASSERT(A && B) -> KASSERT(A); KASSERT(B)

(riastradh)

xen_clock(4): Sprinkle dtrace probes.

(riastradh)

Default PROC_MACHINE_ARCH to machine_arch and use this for magic
symlinks to resolve "@machine_arch".

This keeps behaviour of magic symlinks and 'uname -p' output the same.
Fixes PR 57320.

(mlelstv)

domains: re-gen with fix.

(nikita)

update-domains: replace missed html.

(nikita)

domains: re-gen

(nikita)

fix update-domains rule.

(nikita)

codec translates to 16bit slinear_le, not the internal format.

(mlelstv)

Ticket #151

(martin)

Pull up following revision(s) (requested by jmcneill in ticket #151):

sys/dev/sdmmc/sdmmc_mem.c: revision 1.75

sdmmc: Only check chipset WP status for SD cards.

The sdmmc_chip_write_protect callback returns the write protect switch
status from the controller (SDWP#). This signal does not exist for eMMC;
instead, write protect is signaled using card registers (CSD). So lets
skip asking the chipset for WP status on eMMC cards for each write
request.

(martin)

sys/sdt.h: Omit spurious trailing semicolon in DTRACE_PROBE*.

(riastradh)

sys/sdt.h: Nix needless SDT_VAR_DECL.

Previously introduced as a provisional build fix, its need has been
obviated by making SDT_PROBE* do __USE on the arguments in builds
without KDTRACE_HOOKS.

(riastradh)

kern/vfs_subr.c: Revert previous build fixes, no longer needed.

SDT_PROBE* will now DTRT here.

(riastradh)

sys/sdt.h: Make sure SDT_PROBE*, DTRACE_PROBE* compile the arguments.

This way there's no need to fuss around with conditional declarations
and assignments in the callers to avoid `variable set but not used'
errors in builds without KDTRACE_HOOKS.

(riastradh)

sys/cdefs.h: New __MACROUSE for macros to type-check arguments.

This way, if there's a macro F(x) with a conditional definition --
e.g., conditional on DIAGNOSTIC or KDTRACE_HOOKS -- it can do
__MACROUSE(x) in the definition that's supposed to compile away,
without triggering `variable set but not used' errors, while still
catching type errors in the expression x.  But there's no cost or
side effects incurred in the generated code because the value is not
computed.

This should be the same as __USE, but I haven't figured out how to
make it work for both bit fields (which are likely to appear in macro
arguments) and aggregates (structs/unions, which are likely to appear
as variable declarations), so for now we use two separate macros.

(riastradh)

sys/sdt.h: Whitespace cleanup (and internal macro semicolon tidying).

No functional change intended.

(riastradh)

sys/sdt.h: Properly parenthesize macro arguments.

(riastradh)

sys/sdt.h: Nix trailing whitspace.

No functional change intended.

(riastradh)

xhci doesn't like 80 packets per USB interval, but 40 seems to be fine
for xhci (and ehci).

(mlelstv)

Fix builds (hopefully) when DTRACE hooks are not included.

(kre)

pthread_create(3): minor markup tweaks

(uwe)

delete spurious space

(jschauma)

Like everywhere else make sure DESTDIR is not empty before using it.
Otherwise if it is empty before we were adding an optargless -d, which
ended up using the next argument (a -Isomething) after the recent change
to xlint.c related to sysroot. This broke using the native tools make
with the cross toolchain (for example typing make in /usr/src/bin/ls)
to build and install a single program.

(christos)

sdmmc: Only check chipset WP status for SD cards.

The sdmmc_chip_write_protect callback returns the write protect switch
status from the controller (SDWP#). This signal does not exist for eMMC;
instead, write protect is signaled using card registers (CSD). So lets
skip asking the chipset for WP status on eMMC cards for each write
request.

(jmcneill)

dk(4): Rename label for consistency.  No functional change intended.

(riastradh)

tests/make: extend test for target-local variables

(rillig)

vfs: Sprinkle dtrace probes into syncer.

(riastradh)

vfs(9): Move SDT_PROVIDER_DEFINE(vfs) from vfs_cache.c to vfs_init.c.

Not a namecache-specific thing.

(riastradh)

kern/vfs_init.c: Sort includes.  No functional change intended.

(riastradh)

sys/vnode_impl.h: Declare vfs sdt provider.

This way it can be used by more than just vfs_cache.c.

(riastradh)

kern/vfs_subr.c: Sort includes.  No functional change intended.

(riastradh)

Fix build after previous. m68k uses symnum instead of symidx.

(skrll)

tmpfs: Assert no arithmetic overflow in directory node tn_size.

Need >2^57 directory entries before this is a problem.  If we created
a million per second, this would take over 4000 years.

(riastradh)

tmpfs: Refuse sizes that overflow round_page.

Reported-by: syzbot+8dbeee84de15f86df65b@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=4a27b9fe074f8d4b0afbe22969339b8dfdb157e8

(riastradh)

kern/vfs_syscalls.c: Nix trailing whitesapce.

No functional change intended.

(riastradh)

tmpfs: Nix trailing whitespace.  No functional change intended.

(riastradh)

sys/vnode_impl.h: Nix trailing whitespace.

No functional change intended.

(riastradh)

dk(4): Fix lock assertion in size increase: parent's, not wedge's.

Reported-by: syzbot+d4dc610473cacc5183dd@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=e18ddae8283d6fab44cfb1ac7e3f8e791f8c0700

(riastradh)

White space fix.

(isaki)

m68k: Support TT(Transparent Translation) for 020/030 buserror handler.
This avoids a panic when trying badaddr() against to an address where
bus error occurs in the TT region.  Only luna68k and news68k use TT.
Discussed on port-m68k.

(isaki)

fix few typos and grammar in comments.

(andvar)

one more place for recently fixed typo, s/phisycal/physical/.

(andvar)

3RDPARTY: the atf-devel mailing list was closed years ago

(gutteridge)

tests/make: add tests for target-local variables

While here, move a test from var-scope-local.mk to parse.mk since that
test is not related to variables.

(rillig)

Fix typo in comment

(pgoyette)

Pass local symbols relocations in both passes and provide the kobj_reloc
implementation visibility of these relocations.

Currently all implementations resolve local symbol relocations in the first
pass and simply skip them in the second. The RISC-V implementation will
make use of this visiblity.

(skrll)

Don't set the clear_to_eol variable in doupdate to NULL, this was a
leftover from previous code that makes no sense and makes worms(6)
crash randomly.  Thanks to kre@ for reporting this.

(blymn)

Unbreak creation of i386 PIEs on amd64.

Functional patch by RVP;  set lists updated accordingly.

This fixes PR toolchain/57380.

(hgutch)

dhcpcd: Fix non INET6 builds.

Thanks to J. Hannken-Illjes for the fix.

(roy)

Remove an unnecessary cast in a KASSERTMSG

(skrll)

Correct a type.

(skrll)

Add a little optional colour, optionally distinguish worm heads,
and optionally randomise worm lengths.  Just exit instead of
continuing with a nonsense display if the window shrinks (and
for consistency if it grows).

Most of the ideas and code from RVP.  Bugs and man page mangling
from me.

(kre)

gcc 13.1 is out

(wiz)

Us daemons don't need no unions - just wait, the easy way.

(kre)

Add an example json lexer, and some tests for it.

(agc)

lint: reword message for missing declaration in header

Suggested by Christos.

(rillig)

pass lint.

(christos)

Tickets #145 - #150

(martin)

Pull up following revision(s) (requested by ozaki-r in ticket #150):

sys/netinet/ip_output.c: revision 1.325

Revert "Fix panic on packet sending via a route with rt_ifa of AF_LINK."

The fix is mistakenly upstreamed.

(martin)

Pull up following revision(s) (requested by kre in ticket #148):

games/worms/worms.c: revision 1.24
games/worms/worms.c: revision 1.25
games/worms/worms.c: revision 1.26
games/worms/worms.c: revision 1.27
games/worms/worms.c: revision 1.28
games/worms/worms.c: revision 1.29
games/worms/worms.6: revision 1.17

Garbage collect "char *mp" - it used to point at memory malloc()'d
to hold the termcap entry, back when worms used termcap rather than
curses, and termcap was termcap, rather that a terminfo wannabe.

This should have been removed when worms was converted to curses in
1999, but wasn't, so worms has been doing a meaningless malloc(1024)
and never using the result, ever since.

While here, since the line needed changing anyway to remove mp,
change a malloc() of a product into calloc() so it can deal with
any possible (admittedly extremely unlikely here) integer overflows.

NFCI

80 column police.

If this code were just a few chars over the limit, it might get
let off with a warning, but 214 in an 80 zone is way beyond that.
Six months loss of coding licence, and a 214000 character fine.

NFCI.

(I verified the the code was unchanged by joining the resulting
lines back into one again, and then diff'ing that line against
the original - it is identical).

When worms default delay was changed from 0, to 20ms (Oct 2020)
it lost the ability to run flat out (no sleeps) - which while not
very useful for actually observing the behaviour of various Nematoda,
can be useful when 'worms' is being used to generate cpu heat - it
turns out to be a simple tool to make all of the app itself, the
xterm it runs in (when running under X) and the X server, all more
or less continuously busy - a trivial perpetual CPU load generator.

Changing that was not a simple matter of just allowing -d 0..1000
rather than -d 1..1000 which had always been the limits on -d, as
previously, simply by excluding 0, common error checking wasn't
essential.  -djunk would return 0 which was invalid, and so an error
- - that it was invalid because 0 < 1, rather than because "junk" is not
a number wasn't material.

Now we need some slightly more elaborate error checking code for the
- -d value, and if we're going to do that, may as well do the same for
the -l and -n options, which also take numeric values.  That is, it
will no longer be possible to say:

worms -n "5 worms"

Just the number is allowed (but -d now allows a "ms" or "us" suffix).

While here, place a reasonable upper limit (depending upon the
screen size, and worm length) upon the number of worms, so they
have somewhere to go, rather than just on top of each other.

exit(1) from the errx() rather than 0, in the case that curses
initscr() fails (doesn't seem right that it should appear as a
successful run of worms, if it never managed to start).

A couple more minor 80 column violations are handled, without
further penalty, in this update (one simply vanishes, the other
is wrapped).

Note that this sounds like a lot, but it is really all just minor
internal bookkeeping updates - the only real advertised user visible
change is the ability to use -d0 which just restores that which was
the default (though it could never be set via the option) until Oct 2020
- - so really all that's happening is replacing minor functionality lost
then, while leaving the change of the default delay that that change
made, untouched.

No man page update required (that never excluded -d0).

Correct some unfortunate behaviour in extreme cases pointed out by RVP.
(Very long worms in a smallish window could result in the max number of
worms being 0...)

While here (also suggested by RVP) seed the random number generator,
also add a -S option to set the seed (note: while this is documented
in the updated man page, it does not appear in the usage message in
case of an error ... not likely to be used often enough to include there).

Also some minor improvements suggested by RVP:
delete the prototype for main()
exit curses mode before abort() (which should not happen, but...)
no need to return (->exit) after abort() as modern abort() can
never return.

In addition, check for extraneous (ignored) (non-option) args.

Check for absurdly small or big screens (the worm placement algorithm
doesn't work well for lines of columns < 3, and the abort() mentioned
above actually happens if one of those is == 1).

More flavours of worms added.

Some minor man page wording improvements.

Typo in an error message (pointed out by RVP; Thanks)

Another err message typo!  (found this one myself!!)

(martin)

Pull up the following, requested by kre in ticket #149:

external/public-domain/tz/dist/CONTRIBUTING    up to 1.1.1.8
external/public-domain/tz/dist/Makefile        up to 1.1.1.36
external/public-domain/tz/dist/NEWS            up to 1.1.1.43
external/public-domain/tz/dist/TZDATA_VERSION  up to 1.35
external/public-domain/tz/dist/africa          up to 1.1.1.31
external/public-domain/tz/dist/antarctica      up to 1.1.1.17
external/public-domain/tz/dist/asia            up to 1.10
external/public-domain/tz/dist/australasia      up to 1.7
external/public-domain/tz/dist/backward        up to 1.11
external/public-domain/tz/dist/backzone        up to 1.1.1.26
external/public-domain/tz/dist/checktab.awk    up to 1.1.1.12
external/public-domain/tz/dist/europe          up to 1.1.1.37
external/public-domain/tz/dist/iso3166.tab      up to 1.1.1.8
external/public-domain/tz/dist/leap-seconds.list up to 1.5
external/public-domain/tz/dist/leapseconds      up to 1.5
external/public-domain/tz/dist/leapseconds.awk  up to 1.1.1.13
external/public-domain/tz/dist/northamerica    up to 1.1.1.33
external/public-domain/tz/dist/southamerica    up to 1.1.1.23
external/public-domain/tz/dist/theory.html      up to 1.1.1.18
external/public-domain/tz/dist/version          up to 1.10
external/public-domain/tz/dist/zone.tab        up to 1.1.1.25
external/public-domain/tz/dist/zone1970.tab    up to 1.1.1.26
doc/3RDPARTY (apply patch)

sync with HEAD: updated tzdata to 2023c

(martin)

Pull up following revision(s) (requested by gutteridge in ticket #147):

usr.bin/resize/resize.h: revision 1.3

resize.c: use estrdup(3) with basename(3)
basename(3) is invoked more than once on different paths. Retain the
correct name for the utility itself on error. Addresses PR bin/57355
from RVP, who provided the patch.

(martin)

Pull up following revision(s) (requested by abs in ticket #146):

lib/librefuse/fuse.h: revision 1.35

Fix incorrect test for FUSE_USE_VERSION 34
(Thanks to Mark Davies for report)

(martin)

Pull up following revision(s) (requested by simonb in ticket #145):

sbin/nvmectl/devlist.c: revision 1.6

In "devlist" mode, exit with a 0 return code if any nvme devices are
found, rather than exiting with 1 return code always.

(martin)

tip.1: s/Mail.1/mail.1/ ("Mail" was removed in 9)

(gutteridge)

tests/rump/modautoload: reorder -lrumpvfs_nofifofs

Make the way we spell "-lrumpvfs -lrumpvfs_nofifofs" hack consistent.
The order doesn't matter here because of --whole-archive.

(uwe)

tests: trim down the list of LIBRUMPBASE libraries

Now that cyclic dependencies are (mostly) broken, we can drop repeated
-l instances that worked around those cycles.  Links on sun2.

(uwe)

PR/57376: Jorge Giner: readline file completion does not quote; do the same.

(christos)

rump_wmd(1): there is no space in -lcomponent

A couple of minor markup tweaks while here.

(uwe)

rump_allserver: trim down the list of libraries

Now that cyclic dependencies are (mostly) broken, we can drop repeated
-l instances that worked around those cycles.  Links on sun2.

(uwe)

Fix DEVMAP_FLAGS, patch from Nick.

(martin)

Merge x86 boot options in x86/boot(8) and add undocumented UEFI options

We were supposed to keep the option list in x86/boot(8), x86/dosoot(8)
and x86/pxeboot(8) in sync, but it did not happen, hence it may work
better with all the options in x86/boot(8). Also add the undocumented
UEFI boot options.

(manu)

enable rkv1crypto on rock64.

this comes from upstream d1152bc533c941f7e267bf53d344cee510ea2808.

(i tried to make this be in rk3328.dtsi so all rk3328 boards would
benefit, but it doesn't work, and this is the only one have to test.)

adjust rkv1crypto to support a per-platform clocks setup.

(mrg)

rump_allserver(1): fix markup, clarify

Reorder text for the -d option to hopefully make it easier to follow.
Clarify that the "disklabel" keyword takes partion letter (from RTFS).

(uwe)

lua: fix ftb in lstrlib.c for clang

(error: enumeration values 'Knumber' and 'Kdouble' not handled in switch [-Werror,-Wswitch])

(nikita)

Allow 24bit support.

(mlelstv)

dlopen(3): Read _rtld_objtail under the lock.

XXX pullup-8
XXX pullup-9
XXX pullup-10

(riastradh)

tests/lint: add rationale for not warning about alignment problems

(rillig)

build.sh: drop -lrumpdev hack introduced in previous

The existing trick in sys/rump/librump/rumpdev/rump_dev.c was not
updated after the renames in the kernel.  kudos to riastradh.

PR kern/56599

(uwe)

lint: be strict when parsing command line for excluded message IDs

Previously, lint accepted -X '1, 2, 3', while the manual page lists the
IDs without spaces.

On 32-bit platforms, lint accepted -X -4294967295, and on 64-bit
platforms, it accepted the corresponding larger numbers.

The code for parsing message IDs and query IDs conceptually does the
same, but the implementations differed for no reason.

(rillig)

print stage formats with AUDIO_DEBUG

(mlelstv)

tests/lint: test command line parsing for message and query IDs

The parsing methods differ but shouldn't.

(rillig)

Be a little bit more informative on device timeout.

(mlelstv)

Whitespace

(mlelstv)

No longer use AUDIO_INTERNAL_BITS but rely on passed audio format.

(mlelstv)

Enable 24bit support by default.

(mlelstv)

Add 24bit/32bit hardware support.

(mlelstv)

rumpdev: Catch up to buf_syncwait -> vfs_syncwait rename.

Do similarly with a do_sys_sync weak stub so we can drop the rumpvfs
dependency.

(riastradh)

Explicitly check machine type (LUNA-II) on secondary spc(4) probe.

So that individual mainbus_attach_args for both LUNA and LUNA-II
are no longer necessary.
While here, use proper address macro in <machine/board.h>.

Tested on both LUNA and LUNA-II.

(tsutsui)

Whitespace

(mlelstv)

Make audio_device information available to drvctl and devpubd.

(mlelstv)

Weed out duplicate sample rates and add comment about UAC2 clocks.

(mlelstv)

build.sh: tweak rumptest and RUMP_LIBSETS

Use --no-whole-archive to keep us as honest as currently possible.
PR kern/56599

(uwe)

t_open_pr_57260.c: KNF a block (spaces to tabs)

(gutteridge)

lint: allow cast from a type to a union containing that type

(rillig)

lint: fix wrong warning about 'extern' temporary identifier

(rillig)

tests/lint: demonstrate wrong warning about extern temporary identifier

(rillig)

lint: fix missing initialization for cast to union

The left operand of a unary AST node must not be NULL.

The previous code crashed lint when run with some query enabled, as
is_cast_redundant assumes that a non-null AST node has valid operands.

$ cat <<EOF > crash.c
double
demo(void) {
union u {
double *num;
} u;
u = (union u)&((double) { 0.0 });
return *u.num;
}
EOF
$ /usr/libexec/lint1 -w -S -g -q8 crash.c /dev/null

(rillig)

tests/lint: test cast to union with stricter alignment

(rillig)

lua: formatting in lvm.c

(nikita)

rumpvfs: Link in secmodel_extensions_vfs.c as intended, like kernel.

Forgot to commit this part when splitting up secmodel_extensions.c.

(riastradh)

lint: rename type_t.t_str to t_sou

The name 't_str' could have meant 'string' or 'struct'.  Since both
struct and union types have members, rename it to 't_sou'.

No functional change.

(rillig)

lint: don't warn about cast between union and one of its member types

Seen in src/sbin/newfs_udf/udf_core.c for context.anchors.

(rillig)

tests/lint: add test for conversions to and from a union type

Additionally, fix the line numbers in another test.

(rillig)

specfs: KNF.  No functional change intended.

(riastradh)

lint: do not warn about parenthesized assignment in controlling expr

Same as for GCC and Clang.

(rillig)

Remove unused mount member mnt_transinfo.

Ride 10.99.4

(hannken)

Remove unused specdev member sd_rdev.

Ride 10.99.4

(hannken)

fcntl(2), flock(2): Assert FHASLOCK is clear if no fo_advlock.

(riastradh)

fcntl(2), flock(2): Unify error branches.

Let's make this a bit less error-prone by having everything converge
in the same place instead of multiple returns in different contexts.

(riastradh)

fcntl(2), flock(2): Fix missing fd_putfile in error branch.

Oops!

(riastradh)

Welcome to 10.99.4, courtesy of struct fileops additions!

(riastradh)

rump: Move vnode_if.c from rumpkern to rumpvfs.

This has become increasingly less of a `fully dynamic interface', and
the need for it in the rest of sys/kern/ has been obviated, so let's
put it where it belongs in rumpvfs.

(riastradh)

secmodel_extensions: Split vfs part into separate .c file.

This way we can provide weak rumpkern stubs that don't require
rumpvfs for things that are relevant to vfs, but if you do link
rumpvfs then you get the same logic in secmodel extensions.

(riastradh)

rump: Move ubc_uiomove, ubc_zerorange from rumpvfs to rumpkern.

Needed by kern_ksyms.c.  We could split kern_ksyms.c up into kernel-
internal interfaces and the user/kernel /dev/ksyms interface, but
there's nothing vfs-specific about ubc_uiomove and ubc_zerorange
anyway, so let's just define them in rumpkern.

(riastradh)

rumpkern: Provide stub pnbuf_cache weak alias.

Needed only by sys_module.c handle_modctl_load, which won't work if
there's no rumpvfs linked in anyway.

(riastradh)

rumpkern: Provide stub uvm_vnodeops weak alias.

Needed for UVM_OBJ_IS_VNODE, but not for anything else in rumpkern
without rumpvfs.

(riastradh)

rumpkern: Provide fs_filtops weak alias.

We should introduce a link set for sys_kfilters, but this works
around the problem for now -- librump's dependency on librumpvfs
symbols.

(riastradh)

file(9): New fo_posix_fadvise operation.

XXX kernel revbump -- changes struct fileops API and ABI

(riastradh)

file(9): New fo_fpathconf operation.

XXX kernel revbump -- struct fileops API and ABI change

(riastradh)

file(9): New fo_advlock operation.

This moves the vnode-specific logic from sys_descrip.c into
vfs_vnode.c, like we did for fo_seek.

XXX kernel revbump -- struct fileops API and ABI change

(riastradh)

sys/file.h: Sort forward declarations.

No functional change intended.

(riastradh)

dk(4): Convert tests to assertions in various devsw operations.

.d_cancel, .d_strategy, .d_read, .d_write, .d_ioctl, and .d_discard
are only ever used between successful .d_open return and entry to
.d_close.  .d_open doesn't return until sc is nonnull and sc_state is
RUNNING, and dkwedge_detach waits for the last .d_close before
setting sc_state to DEAD.  So there is no possibility for sc to be
null or for sc_state to be anything other than RUNNING or DYING.

There is a small functional change here but only in the event of a
race: in the short window between when dkwedge_detach is entered, and
when .d_close runs, any I/O operations (read, write, ioctl, &c.) may
be issued that would have failed with ENXIO before.

This shouldn't matter for anything: disk I/O operations are supposed
to complete reasonably promptly, and these operations _could_ have
begun milliseconds prior, before dkwedge_detach was entered, so it's
not a significant distinction.

Notes:

- .d_open must still contend with trying to open a nonexistent wedge,
  of course.

- .d_close must also contend with closing a nonexistent wedge, in
  case there were two calls to open in quick succession and the first
  failed while the second hadn't yet determined it would fail.

- .d_size and .d_dump are used from ddb without any open/close.

(riastradh)

dk(4): Fix racy access to sc->sc_dk.dk_openmask in dkwedge_delall1.

Need sc->sc_parent->dk_rawlock for this, as used in dkopen/dkclose.

(riastradh)

disk(9): Fix missing unlock in error branch in previous change.

Reported-by: syzbot+870665adaf8911c0d94d@syzkaller.appspotmail.com
https://syzkaller.appspot.com/bug?id=a4ae17cf66b5bb999182ae77fd3c7ad9ad18c891

(riastradh)

readdir(2), lseek(2): Fix races in access to struct file::f_offset.

For non-directory vnodes:
- reading f_offset requires a shared or exclusive vnode lock
- writing f_offset requires an exclusive vnode lock

For directory vnodes, access (read or write) requires either:
- a shared vnode lock AND f_lock, or
- an exclusive vnode lock.

This way, two files for the same underlying directory vnode can still
do VOP_READDIR in parallel, but if two readdir(2) or lseek(2) calls
run in parallel on the same file, the load and store of f_offset is
atomic (otherwise, e.g., on 32-bit systems it might be torn and lead
to corrupt offsets).

There is still a potential problem: the _whole transaction_ of
readdir(2) may not be atomic.  For example, if thread A and thread B
read n bytes of directory content, thread A might get bytes [0,n) and
thread B might get bytes [n,2n) but f_offset might end up at n
instead of 2n once both operations complete.  (However, f_offset
wouldn't be some corrupt garbled number like n & 0xffffffff00000000.)
Fixing this would require either:
(a) using an exclusive vnode lock in vn_readdir,
(b) introducing a new lock that serializes vn_readdir on the same
    file (but ont necessarily the same vnode), or
(c) proving it is safe to hold f_lock across VOP_READDIR, VOP_SEEK,
    and VOP_GETATTR.

(riastradh)

KASSERT(kpreempt_disabled()) before accessing curcpu()

(skrll)

Remove ancient /*ARGSUSED*/ comments.

(tsutsui)

G/C pte_index

(skrll)

Remove ancient /*ARGSUSED*/ comments.

(tsutsui)

Move fdt_update_stdout_path from evbarm code to MI code

(skrll)

lint: fix typos in comments

(rillig)

Remove ancient /* ARGSUSED */ lint comments.

(tsutsui)

Remove ancient /* ARGSUSED */ lint comments.

(tsutsui)

Avoid an extern declaration in .c file.  Just declare it as static.

Suggested on tech-userlevel@.

(tsutsui)

Add new test t_open_pr_57260

New test case that reflects the fix in PR kern/57260. The majority of
work for this case itself was by riastradh@, who'd supplied the basis
for it in the ticket, and provided further guidance.

(gutteridge)

Fix incorrect test for FUSE_USE_VERSION 34

(Thanks to Mark Davies for report)

(abs)

dk(4): Narrow the scope of the device numbering lookup on detach.

Just need it for vdevgone, order relative to other things in detach
doesn't matter.

No functional change intended.

(riastradh)

dk(4): dkdump: Simplify.  No functional change intended.

(riastradh)

dk(4): Omit needless locking in dksize, dkdump.

All the members these use are stable after initialization, except for
the wedge size, which dkwedge_size safely reads a snapshot of without
locking in the caller.

(riastradh)